On 2014-10-01 15:36, Nicholas Mc Guire wrote: > > limit _shipped to c,h and S files > > _shipped targets are intended for generated source files which should > not permit .o binary blobs which is currently the case. This patch > simply restricts _shipped targets to .c, .h and .S files.
Patches 1/3 and 3/3 are fine, but I'm not convinced about this one. Sure, binary blobs are often distributed as *.o_shipped, but they are not going away if you remove support for _shipped. > Note that this patch breaks the handline of > drivers/net/wan/wanxlfw.inc_shipped > which probably really should be moved to a loadable firmware and use > request_firmware - a short term fix could be to move it to a .h file. At a minimum, the patch series should address this before limiting support for *_shipped. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/