[PATCH] [Coding Style]: fs/ext{3,4}/balloc.c

2008-01-04 Thread Mathieu Segaud
Signed-off-by: Mathieu Segaud <[EMAIL PROTECTED]> --- fs/ext3/balloc.c | 101 -- fs/ext4/balloc.c | 93 + 2 files changed, 100 insertions(+), 94 deletions(-) diff --git a/fs/ext3/balloc.

[PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c

2008-01-04 Thread Mathieu Segaud
Misc style fixes from checkpatch.pl Signed-off-by: Mathieu Segaud <[EMAIL PROTECTED]> --- fs/ext3/ext3_jbd.c | 12 ++-- fs/ext4/ext4_jbd2.c | 12 ++-- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/fs/ext3/ext3_jbd.c b/fs/ext3/ext3_jbd.c index e

[PATCH] [Coding Style]: fs/ext{3,4}/bitmap.c

2008-01-04 Thread Mathieu Segaud
Signed-off-by: Mathieu Segaud <[EMAIL PROTECTED]> --- fs/ext3/bitmap.c |2 +- fs/ext4/bitmap.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ext3/bitmap.c b/fs/ext3/bitmap.c index 6afc39d..c402bc4 100644 --- a/fs/ext3/bitmap.c +++ b/fs/ext3/bitmap.c @@

[PATCH] [Coding Style]: fs/ext{3,4}/dir.c

2008-01-04 Thread Mathieu Segaud
Misc style fixes from checkpatch.pl Signed-off-by: Mathieu Segaud <[EMAIL PROTECTED]> --- fs/ext3/dir.c | 55 --- fs/ext4/dir.c | 50 +- 2 files changed, 53 insertions(+), 52 del

[PATCH] [Coding Style]: misc fixes for fs/ext{3,4}/acl.{c,h} from checkpatch.pl

2008-01-04 Thread Mathieu Segaud
Signed-off-by: Mathieu Segaud <[EMAIL PROTECTED]> --- fs/ext3/acl.c | 194 fs/ext3/acl.h |6 +- fs/ext4/acl.c | 190 fs/ext4/acl.h |6 +- 4 files changed, 198 inse

Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c

2008-01-04 Thread Mathieu SEGAUD
Vous m'avez dit récemment : [snip] > Hi Mathieu > > What about changing the __FUNCTION__ to __func__, while you are at it? well, won't do any harm, even though other compilers than GCC are not officialy supported :) thanks a lot And I think I will revamp, including fixes into fs/ext2 -- Mathi

Re: [PATCH] [Coding Style]: misc fixes for fs/ext{3,4}/acl.{c,h} from checkpatch.pl

2008-01-04 Thread Mathieu SEGAUD
Vous m'avez dit récemment : > Coding-style only changes tends to screw up our ability to merge > pending patches, but I'll take care of it, thanks yep, I noticed that... would you rather me wait till 2.6.24 is out ? -- Mathieu -- To unsubscribe from this list: send the line "unsubscribe linux-k

Re: The ext3 way of journalling

2008-01-09 Thread Mathieu SEGAUD
Vous m'avez dit récemment : > On 2008-01-08, John Stoffel <[EMAIL PROTECTED]> wrote: >> Look at your filesystems, using 'tune2fs' and see if the ext3 journal >> is actually turned on and used. If it's not, then I can see why >> you're having problems on reboots. > > Journalling is on, but it's

[RESENT] Fix previously extX_ioctl() patches

2008-01-22 Thread Mathieu Segaud
This two patches discards and replaces 2 previously sent patches they convert ext3/4_ioctl()s to unlocked_ioctl's -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.

[PATCH] Convert ext4_ioctl to an unlocked_ioctl

2008-01-22 Thread Mathieu Segaud
Signed-off-by: Mathieu Segaud <[EMAIL PROTECTED]> --- fs/ext4/dir.c |2 +- fs/ext4/file.c |2 +- fs/ext4/ioctl.c | 161 --- include/linux/ext4_fs.h |3 +- 4 files changed, 112 insertions(+), 56 deletions(-)

[PATCH] Convert ext3_ioctl() to an unlocked_ioctl

2008-01-22 Thread Mathieu Segaud
Signed-off-by: Mathieu Segaud <[EMAIL PROTECTED]> --- fs/ext3/dir.c |2 +- fs/ext3/file.c |2 +- fs/ext3/ioctl.c | 161 --- include/linux/ext3_fs.h |3 +- 4 files changed, 113 insertions(+), 55 deletions(-)

[PATCH] Convert drivers/scsi/ch.c to use unlocked_ioctl

2008-01-14 Thread Mathieu Segaud
As of now, compat_ioctl already runs without the BKL, whereas ioctl runs with the BKL. This patch first converts changer_fops to use a .unlocked_ioctl member. It applies the same locking rationale than ch_ioctl_compat() uses to ch_ioctl(). Signed-off-by: Mathieu Segaud <[EMAIL PROTEC

Re: [PATCH] Convert drivers/scsi/ch.c to use unlocked_ioctl

2008-01-14 Thread Mathieu SEGAUD
Vous m'avez dit récemment : > On Mon, Jan 14, 2008 at 02:32:13PM +0100, Mathieu Segaud wrote: >> +#include > You don't add any uses of lock_kernel() and there are none in the > driver currently. yep, it was before I noticed the locking semantics of ch_ioctl

[PATCH] Convert drivers/scsi/ch.c to use unlocked_ioctl

2008-01-14 Thread Mathieu Segaud
As of now, compat_ioctl already runs without the BKL, whereas ioctl runs with the BKL. This patch first converts changer_fops to use a .unlocked_ioctl member. It applies the same locking rationale than ch_ioctl_compat() uses to ch_ioctl(). Signed-off-by: Mathieu Segaud <[EMAIL PROTEC

[PATCH] Convert drivers/scsi/ch.c to use unlocked_ioctl

2008-01-14 Thread Mathieu Segaud
As of now, compat_ioctl already runs without the BKL, whereas ioctl runs with the BKL. This patch first converts changer_fops to use a .unlocked_ioctl member. It applies the same locking rationale than ch_ioctl_compat() uses to ch_ioctl(). Signed-off-by: Mathieu Segaud <[EMAIL PROTEC

[PATCH] Convert drivers/scsi/ch.c to use unlocked_ioctl

2008-01-14 Thread Mathieu Segaud
As of now, compat_ioctl already runs without the BKL, whereas ioctl runs with the BKL. This patch first converts changer_fops to use a .unlocked_ioctl member. It applies the same locking rationale than ch_ioctl_compat() uses to ch_ioctl(). Signed-off-by: Mathieu Segaud <[EMAIL PROTEC

Re: [RFC on MODULE SUPPORT] hello, Rusty, Should we provide module information even if the kernel module compiled built-in with bzImage?

2008-01-16 Thread Mathieu SEGAUD
Vous m'avez dit récemment : > hello, Rusty: > I encountered a problem when modules compiled built-in with bzImage: > > open-iscsi is an iSCSI software, it has a userspace daemon(iscsid) and > a userspace mani tool(iscsiadm) and a kernel module > (scsi_transport_iscsi), > recently the kernel module

[PATCH] Convert drivers/char/agp/frontend.c to use unlocked_ioctl

2008-01-16 Thread Mathieu Segaud
As of now, agp_compat_ioctl already runs without the BKL. Mutual exclusion is enforced by agp_fe.agp_mutex in agp_ioctl() and agp_compat_ioctl(). Apply the same locking rationale to the two functions allowing BKL cleanup. Signed-off-by: Mathieu Segaud <[EMAIL PROTECTED]> --- drivers/ch

Re: [RFC on MODULE SUPPORT] hello, Rusty, Should we provide module information even if the kernel module compiled built-in with bzImage?

2008-01-17 Thread Mathieu SEGAUD
Vous m'avez dit récemment : > On Wednesday 16 January 2008 22:58:09 Mathieu SEGAUD wrote: >> your userspace program is somewhat broken >> the userspace should not expect to find the version number in >> /sys/module, as this is used by the Linux kernel module subsystem.

[PATCH] Convert ext3_ioctl() to an unlocked_ioctl

2008-01-17 Thread Mathieu Segaud
Signed-off-by: Mathieu Segaud <[EMAIL PROTECTED]> --- fs/ext3/dir.c |2 +- fs/ext3/file.c |2 +- fs/ext3/ioctl.c | 159 -- include/linux/ext3_fs.h |3 +- 4 files changed, 113 insertions(+), 53 deletions(-)

[PATCH] Convert ext4_ioctl to an unlocked_ioctl

2008-01-17 Thread Mathieu Segaud
Signed-off-by: Mathieu Segaud <[EMAIL PROTECTED]> --- fs/ext4/dir.c |2 +- fs/ext4/file.c |2 +- fs/ext4/ioctl.c | 159 --- include/linux/ext4_fs.h |3 +- 4 files changed, 112 insertions(+), 54 deletions(-)

[PATCH] Convert EXT2 to use unlocked_ioctl

2008-01-17 Thread Mathieu Segaud
Change ext_ioctl() to be an unlocked_ioctl(), explicitly exposing BKL's uses. Signed-off-by: Mathieu Segaud <[EMAIL PROTECTED]> --- fs/ext2/dir.c |2 +- fs/ext2/ext2.h |3 +- fs/ext2/file.c |4 +- fs/ext2/ioctl.c | 101 +-

[PATCH] Convert reiserfs_ioctl() to an unlocked_ioctl

2008-01-17 Thread Mathieu Segaud
Signed-off-by: Mathieu Segaud <[EMAIL PROTECTED]> --- fs/reiserfs/dir.c |2 +- fs/reiserfs/file.c |2 +- fs/reiserfs/ioctl.c | 94 --- include/linux/reiserfs_fs.h |2 +- 4 files changed, 65 insertions(

[PATCH] reiserfs: coding style fixes

2008-01-17 Thread Mathieu Segaud
Signed-off-by: Mathieu Segaud <[EMAIL PROTECTED]> --- fs/reiserfs/ioctl.c | 22 -- 1 files changed, 12 insertions(+), 10 deletions(-) diff --git a/fs/reiserfs/ioctl.c b/fs/reiserfs/ioctl.c index 5da64ab..36a886f 100644 --- a/fs/reiserfs/ioctl.c +++ b/fs/reiserfs/i

Re: [PATCH] Convert EXT2 to use unlocked_ioctl

2008-01-17 Thread Mathieu SEGAUD
Vous m'avez dit récemment : > On Thursday 17 January 2008, you wrote: >> >> Change ext_ioctl() to be an unlocked_ioctl(), explicitly >> exposing BKL's uses. >> >> Signed-off-by: Mathieu Segaud <[EMAIL PROTECTED]> > > You are now c

Re: [PATCH] Convert EXT2 to use unlocked_ioctl

2008-01-17 Thread Mathieu SEGAUD
Vous m'avez dit récemment : > Vous m'avez dit récemment : > >> On Thursday 17 January 2008, you wrote: >>> >>> Change ext_ioctl() to be an unlocked_ioctl(), explicitly >>> exposing BKL's uses. >>> >>> Signed-off-by:

Re: [PATCH] Convert EXT2 to use unlocked_ioctl

2008-01-17 Thread Mathieu SEGAUD
Vous m'avez dit récemment : > On Thursday 17 January 2008, Mathieu SEGAUD wrote: >> yep, they do. I noticed this nested calls. I guess I will add >> _extX_compat_ioctl() running with no BKL's which would be used by both >> extX_ioctl() and extX_compat_ioctl(). >

[PATCH] Convert ext3_ioctl() to an unlocked_ioctl

2008-01-17 Thread Mathieu Segaud
Signed-off-by: Mathieu Segaud <[EMAIL PROTECTED]> --- fs/ext3/dir.c |2 +- fs/ext3/file.c |2 +- fs/ext3/ioctl.c | 161 --- include/linux/ext3_fs.h |3 +- 4 files changed, 113 insertions(+), 55 deletions(-)

[PATCH] Convert ext4_ioctl to an unlocked_ioctl

2008-01-17 Thread Mathieu Segaud
Signed-off-by: Mathieu Segaud <[EMAIL PROTECTED]> --- fs/ext4/dir.c |2 +- fs/ext4/file.c |2 +- fs/ext4/ioctl.c | 161 --- include/linux/ext4_fs.h |3 +- 4 files changed, 112 insertions(+), 56 deletions(-)

[PATCH] reiserfs: coding style fixes

2008-01-17 Thread Mathieu Segaud
Signed-off-by: Mathieu Segaud <[EMAIL PROTECTED]> --- fs/reiserfs/ioctl.c | 22 -- 1 files changed, 12 insertions(+), 10 deletions(-) diff --git a/fs/reiserfs/ioctl.c b/fs/reiserfs/ioctl.c index 691008d..1468be5 100644 --- a/fs/reiserfs/ioctl.c +++ b/fs/reiserfs/i

[PATCH] Convert reiserfs_ioctl() to an unlocked_ioctl

2008-01-17 Thread Mathieu Segaud
Signed-off-by: Mathieu Segaud <[EMAIL PROTECTED]> --- fs/reiserfs/dir.c |2 +- fs/reiserfs/file.c |2 +- fs/reiserfs/ioctl.c | 96 +++--- include/linux/reiserfs_fs.h |2 +- 4 files changed, 65 insertions(+), 37 del

[PATCH] Convert EXT2 to use unlocked_ioctl

2008-01-17 Thread Mathieu Segaud
Change ext_ioctl() to be an unlocked_ioctl(), explicitly exposing BKL's uses. Signed-off-by: Mathieu Segaud <[EMAIL PROTECTED]> --- fs/ext2/dir.c |2 +- fs/ext2/ext2.h |3 +- fs/ext2/file.c |4 +- fs/ext2/ioctl.c | 103 +--

Re: [PATCH] Convert ext3_ioctl() to an unlocked_ioctl

2008-01-17 Thread Mathieu SEGAUD
Vous m'avez dit récemment : > --- a/fs/ext3/ioctl.c > +++ b/fs/ext3/ioctl.c > @@ -17,12 +17,19 @@ > #include > #include > > -int ext3_ioctl (struct inode * inode, struct file * filp, unsigned int cmd, > +long ext3_ioctl(struct file *filp, unsigned int cmd, > unsigned long arg)

Re: [PATCH] Convert ext4_ioctl to an unlocked_ioctl

2008-01-17 Thread Mathieu SEGAUD
Vous m'avez dit récemment : as well for this one, > --- a/fs/ext4/ioctl.c > +++ b/fs/ext4/ioctl.c > @@ -17,12 +17,18 @@ > #include > #include > > -int ext4_ioctl (struct inode * inode, struct file * filp, unsigned int cmd, > - unsigned long arg) > +long ext4_ioctl(struct file *f

Re: 2.6.11-rc4-mm1

2005-02-23 Thread Mathieu Segaud
ub_preempt_count } BUG's on SMP and PREEMPT __remove_watch() must be called with ->lock held on dev. Anyway, ->lock is released after label out. Signed-off-by: Mathieu Segaud <[EMAIL PROTECTED]> --- a/drivers/char/inotify.c 20

Re: 2.6.11-rc4-mm1 : IDE crazy numbers, hdb renumbered to hdq ?

2005-02-23 Thread Mathieu Segaud
Andrew Morton <[EMAIL PROTECTED]> disait derniÃrement que : > Helge Hafting <[EMAIL PROTECTED]> wrote: >> >> This kernel came up, but my boot script complained about no /dev/hdb3 >> when trying to mount /var. >> (I have two IDE disks on the same cable, and an IDE cdrom on another.) >> They are

Re: Bigmem in Linux 2.6.8

2005-02-28 Thread Mathieu Segaud
Iwan Sanders <[EMAIL PROTECTED]> disait derniÃrement que : > Hi, > > I've got a quick question about the amount of memory used by Linux. > I compiled a 2.6.8 kernel on a machine with 2GB internal memory but > it seems to use only 882MB. Did I miss an option in the config file? you did, CONFIG_HIG

Re: 2.6.11-rc5-mm1

2005-03-01 Thread Mathieu Segaud
ÃÂ ctail_ok ÃÂ sera toujours ÃÂvaluÃÂe comme ÃÂtant ÃÂ true ÃÂ fs/reiser4/plugin/item/ctail.c: In function `convert_ctail': fs/reiser4/plugin/item/ctail.c:1669: attention : l'adresse de ÃÂ coord_is_unprepped_ctail ÃÂ sera toujours ÃÂvaluÃÂe comme ÃÂtant ÃÂ true ÃÂ Signed-off-by: Mathieu

Re: 2.6.11-rc5-mm1

2005-03-01 Thread Mathieu Segaud
Mathieu Segaud <[EMAIL PROTECTED]> disait derniÃrement que : Hum, one hunk didn't make it. The complete patch is attached > > fs/reiser4/plugin/item/ctail.c: In function `check_ctail': > fs/reiser4/plugin/item/ctail.c:250: attention : l'adresse de ÃÂ ctail_ok >

Re: 2.6.11-rc5-mm1

2005-03-01 Thread Mathieu Segaud
Mathieu Segaud <[EMAIL PROTECTED]> disait derniÃrement que : > Mathieu Segaud <[EMAIL PROTECTED]> disait derniÃrement que : > > Hum, one hunk didn't make it. > The complete patch is attached as any time I post with no sleep for 3 days, more noodles than brain are in