Vous m'avez dit récemment : > On Mon, Jan 14, 2008 at 02:32:13PM +0100, Mathieu Segaud wrote: >> +#include <linux/smp_lock.h> > You don't add any uses of lock_kernel() and there are none in the > driver currently.
yep, it was before I noticed the locking semantics of ch_ioctl_compat() >> - .owner = THIS_MODULE, >> - .open = ch_open, >> - .release = ch_release, >> - .ioctl = ch_ioctl, >> + .owner = THIS_MODULE, >> + .open = ch_open, >> + .release = ch_release, >> + .unlocked_ioctl = ch_ioctl, > > If you're going to do the gratuitous reformatting, at least use tabs > instead of spaces. thanks, will do > Other than that, should be fine. I repost this one thanks a lot. -- Mathieu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
