dev.of_node);
> + }
> +
> + if (!priv->phy_node)
> + priv->phy_node = of_parse_phandle(pdev->dev.of_node,
> + "phy-handle", 0);
> +
> if (!priv->phy_node) {
> dev_err(&pdev->dev, "no PHY specified\n");
> ret = -ENODEV;
> --
> 2.1.4
--
Måns Rullgård
Sebastian Frias writes:
> On 02/05/2016 03:34 PM, Måns Rullgård wrote:
>> Sebastian Frias writes:
>>
>>> Signed-off-by: Sebastian Frias
>>
>> Please change the subject to something like "net: ethernet: nb8800:
>> support fixed-link DT node&quo
Sebastian Frias writes:
> On 02/05/2016 04:08 PM, Måns Rullgård wrote:
>> Sebastian Frias writes:
>>
>>> On 02/05/2016 03:34 PM, Måns Rullgård wrote:
>>>> Sebastian Frias writes:
>>>>
>>>>> Signed-off-by: Sebastian Frias
>&
Andy Shevchenko writes:
> On Fri, Feb 5, 2016 at 3:39 PM, Måns Rullgård wrote:
>>> + if (ret < 0) {
>>> + dev_err(&pdev->dev, "broken fixed-link
>>> specification\n");
>>
>> Line is l
gt;>Another question is if the avr32 kernel still supported, or if I should
>>>just stop trying to build test it. Any thoughts ?
>>
>> I have already stopped building it.
>
> I build the kernel and try to fix small issues here and there.
Even when it builds, it often doesn't work since non-DT support has
bitrotted in many drivers.
--
Måns Rullgård
Guenter Roeck writes:
> On 02/06/2016 06:01 AM, Måns Rullgård wrote:
>> Hans-Christian Noren Egtvedt writes:
>>
>>>>> Example for avr32:defconfig:
>>>>>
>>>>> fs/built-in.o: In function `anon_inode_getfile':
>>>>>
@@ again:
> rxd->report = 0;
> last = next;
> work++;
> - }
> + } while (work < budget);
>
> if (work) {
> priv->rx_descs[last].desc.config |= DESC_EOC;
> --
> 2.7.0
>
--
Måns Rullgård
Nicolas Ferre writes:
> Le 05/01/2016 22:50, Måns Rullgård a écrit :
>> Cyrille Pitchen writes:
>>
>>> This patch relies on the CSAAT (Chip Select Active After Transfer) feature
>>> introduced by the version 2 of the spi controller. This new mode allows to
&
Nicolas Ferre writes:
> Le 27/01/2016 16:53, Måns Rullgård a écrit :
>> Nicolas Ferre writes:
>>
>>> Le 05/01/2016 22:50, Måns Rullgård a écrit :
>>>> Cyrille Pitchen writes:
>>>>
>>>>> This patch relies on the CSAAT (Chip Select
| 12 ++--
>> drivers/dma/dw/regs.h | 4 ++--
>> drivers/spi/spi-pxa2xx-pci.c | 8
>> drivers/tty/serial/8250/8250_pci.c | 8
>> include/linux/platform_data/dma-dw.h | 8
>> 9 files changed, 39 insertions(+), 40 deletions(-)
>
>
>
> --
> Best regards, Hans-Christian Egtvedt
--
Måns Rullgård
Hans-Christian Noren Egtvedt writes:
> Around Sun 24 Jan 2016 20:19:46 + or thereabout, Måns Rullgård wrote:
>> Hans-Christian Noren Egtvedt writes:
>>> Around Sun 24 Jan 2016 19:21:50 + or thereabout, Mans Rullgard wrote:
>>>> From: Andy Shevche
up. Seriously, this is impossible. If I don't include everybody
in the slightest way related to any patch in the series, I get
complaints that patches are missing. If I do, the lists reject it all
due to too many recipients. What the hell am I supposed to do?
--
Måns Rullgård
bits, ..., 5 - 256bits)
>> > +- data-width: Maximum data width supported by hardware (in bytes)
>>
>> To the reader this suggests a value truely byte granular, but code
>> uses ffs
>> implying that it is still power of 2.
>> Can you mention this here (in bytes, always power of 2).
>
> While this comment is good, I have still note that using non-power of 2
> values will not break anything. Least power of two number will be used
> in that case. So, means I would suggest to replace 'always' by 'better
> to be' or something like that.
Although the code rounds down, the hardware actually works in powers of
two, and it's better to document this.
--
Måns Rullgård
rse_args+0x19e/0x27c
[<9418>] repair_env_string+0x0/0x58
[<9374>] kernel_init_freeable+0x88/0x12c
[<9382>] kernel_init_freeable+0x96/0x12c
[<9418>] repair_env_string+0x0/0x58
[<901d2588>] kernel_init+0x8/0xa4
[<90013130>] syscall_return+0x0/0x
, "cs-gpios", NULL)) {
> + as->use_cs_gpios = false;
> + master->num_chipselect = 4;
> + }
This part breaks the AVR32 boards and probably anything else that
doesn't use devicetree but does use GPIOs for chip select.
--
Måns Rullgår
Andy Shevchenko writes:
> On Tue, 2015-12-22 at 00:08 +0000, Måns Rullgård wrote:
>> Andy Shevchenko writes:
>>
>> > On Mon, 2015-12-21 at 19:27 +, Måns Rullgård wrote:
>> > > Andy Shevchenko writes:
>> > >
>> > > >
ip->base = base;
As I said before, this assumes the outer DT node uses a ranges
property. Normally reg properties work the same whether they specify an
offset within an outer "ranges" or have a full address directly. It
would be easy enough to make this work with either, so I don't see any
reason not to.
--
Måns Rullgård
Marc Zyngier writes:
> On 20/01/16 16:10, Måns Rullgård wrote:
>> Marc Zyngier writes:
>>
>>>> + if (of_property_read_u32(node, "reg", &ctl))
>>>> + panic("%s: failed to get reg base", node->name);
>>>>
Marc Gonzalez writes:
> On 20/01/2016 17:10, Måns Rullgård wrote:
>
>> Marc Zyngier wrote:
>>
>>>> + if (of_property_read_u32(node, "reg", &ctl))
>>>> + panic("%s: failed to get reg base", node->name);
>>>
Marc Gonzalez writes:
> On 20/01/2016 17:25, Måns Rullgård wrote:
>
>> Marc Zyngier writes:
>>
>>> On 20/01/16 16:10, Måns Rullgård wrote:
>>>
>>>> Marc Zyngier writes:
>>>>
>>>>>> +if (of_property_read_u32
Mark Rutland writes:
> On Wed, Jan 20, 2016 at 05:24:14PM +0100, Marc Gonzalez wrote:
>> On 20/01/2016 17:10, Måns Rullgård wrote:
>>
>> > Marc Zyngier wrote:
>> >
>> >>> +if (of_property_read_u32(node, "reg", &ctl))
&g
d the driver would
> still function correctly?
Not the one you posted.
--
Måns Rullgård
t;;
> reg = <0x2010 0x1000>;
> cache-level = <2>;
> --
> 2.17.1
>
--
Måns Rullgård
"Invalid block size returned: %d\n",
>> +msg[1].buf[0]);
>> +status = -EINVAL;
>
> I changed this to -EPROTO as described in
> Documentation/i2c/fault-codes.rst.
>
> Applied to for-current, thanks!
>
--
Måns Rullgård
ned long reg;
>
> reg = readl(hdmi->base + SUN4I_HDMI_HPD_REG);
> - if (reg & SUN4I_HDMI_HPD_HIGH) {
> + if (!(reg & SUN4I_HDMI_HPD_HIGH)) {
> cec_phys_addr_invalidate(hdmi->cec_adap);
> return connector_status_disconnected;
> }
> --
> 2.27.0
>
--
Måns Rullgård
p_data(d);
>> +struct irq_chip_type *ct = irq_data_get_chip_type(d);
>> +u32 mask = d->mask;
>> +
>> +irq_gc_lock(gc);
>> +irq_reg_writel(gc, mask, ct->regs.disable);
>> +*ct->mask_cache &= ~mask;
>> +irq_reg_writel(gc, mask, ct->regs.ack);
>> +irq_gc_unlock(gc);
>> +}
This function looks like it should probably be used instead. I'll try
to remember to test it when I have time to fire up that hardware.
--
Måns Rullgård
reg;
>> -ct[i].chip.irq_mask_ack = irq_gc_mask_disable_reg_and_ack;
>> +ct[i].chip.irq_mask_ack = irq_gc_mask_disable_and_ack_set;
>> ct[i].chip.irq_unmask = irq_gc_unmask_enable_reg;
>> ct[i].chip.irq_set_type = tangox_irq_set_type;
>> ct[i].chip.name = gc->domain->name;
>>
>
--
Måns Rullgård
pends on SOC_IMX23 || SOC_IMX28 || SOC_IMX6Q || SOC_IMX6SX ||
>> SOC_IMX6UL
>> select STMP_DEVICE
>> select DMA_ENGINE
>> help
>> --
>> 2.14.1
>>
>
> --
> ~Vinod
--
Måns Rullgård
Florian Fainelli writes:
> What do we do with this patch series to move forward? Can we get Doug's
> changes queued up for 4.14?
My opinion is that the correct combined function should be added and the
tango driver updated to use it. Patches already exist, so what are we
waiting for
ct[i].chip.irq_mask_ack = irq_gc_mask_disable_reg_and_ack;
> ct[i].chip.irq_unmask = irq_gc_unmask_enable_reg;
> ct[i].chip.irq_set_type = tangox_irq_set_type;
> ct[i].chip.name = gc->domain->name;
> --
What happened to the patch adding the proper combined function?
--
Måns Rullgård
Marc Gonzalez writes:
> On 25/07/2017 15:16, Måns Rullgård wrote:
>
>> What happened to the patch adding the proper combined function?
>
> It appears you're not CCed on v2.
>
> https://patchwork.kernel.org/patch/9859799/
>
> Doug wrote:
>> Yes, you under
Florian Fainelli writes:
> On 07/25/2017 06:29 AM, Måns Rullgård wrote:
>> Marc Gonzalez writes:
>>
>>> On 25/07/2017 15:16, Måns Rullgård wrote:
>>>
>>>> What happened to the patch adding the proper combined function?
>>&g
ernet/aurora/nb8800.c
> +++ b/drivers/net/ethernet/aurora/nb8800.c
> @@ -1357,6 +1357,7 @@ static const struct of_device_id nb8800_dt_ids[] = {
> },
> { }
> };
> +MODULE_DEVICE_TABLE(of, nb8800_dt_ids);
>
> static int nb8800_probe(struct platform_device *pdev)
> {
> --
--
Måns Rullgård
401 - 433 of 433 matches
Mail list logo
