The UniPhier platform from Socionext provides the AVE ethernet
controller that includes MAC and MDIO bus supporting RGMII/RMII
modes. The controller is named AVE.
Signed-off-by: Kunihiko Hayashi
Signed-off-by: Jassi Brar
Reviewed-by: Andrew Lunn
---
drivers/net/ethernet/Kconfig
DT bindings for the AVE ethernet controller found on Socionext's
UniPhier platforms.
Signed-off-by: Kunihiko Hayashi
Signed-off-by: Jassi Brar
Acked-by: Rob Herring
Reviewed-by: Florian Fainelli
---
.../bindings/net/socionext,uniphier-ave4.txt | 48 ++
1
Hello David,
On Fri, 15 Dec 2017 12:57:49 -0500 David Miller wrote:
> From: Kunihiko Hayashi
> Date: Thu, 14 Dec 2017 19:05:10 +0900
>
> > +static void ave_desc_write(struct net_device *ndev, enum desc_id id,
> > + int entry, int offset, u32 val)
Hello Srinivas,
This patch was already reviewed and tested for all UniPhier SoCs:
https://patchwork.kernel.org/patch/10069557/
Do you have any comments, or would you please pick it up?
Thank you,
On Wed, 22 Nov 2017 14:14:59 +0900 Kunihiko Hayashi
wrote:
> The efuse on UniPhier allows 8
Hi,
On Tue, 8 Aug 2017 21:29:10 +0800 wrote:
> On Tue, 2017-08-01 at 17:04 +0900, Kunihiko Hayashi wrote:
> > Add a thermal driver for on-chip PVT (Process, Voltage and
> > Temperature)
> > monitoring unit implemented on UniPhier SoCs. This driver supports
> > tempe
n't
handled.
Although ave_init() calls phy_start_aneg(), it doesn't make sense
because phy driver doesn't start yet.
And according to Florian's comment in ave_init(),
> + phy_start_interrupts(phydev);
> +
> + phy_start_aneg(phydev);
>
> No, no, phy_start() would take care of all of that correctly for you,
> you don't have have to do it just there because ave_open() eventually
> calls phy_start() for you, so just drop these two calls.
When moving phy_start_aneg() to ave_open(), the handler doesn't need to call
phy_mac_interrupt() and I can remove it from the handler.
---
Best Regards,
Kunihiko Hayashi
Add pinctrl groups of ethenet phy mode, such as "ether_rgmii", "ether_rmii",
and "ether_mii".
Signed-off-by: Kunihiko Hayashi
---
arch/arm/boot/dts/uniphier-pinctrl.dtsi | 15 +++
1 file changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/uniphier
The ether_rmii_groups should have "ether_rmii" and "ether_rmiib" as
members. This patch replaces to them.
Signed-off-by: Kunihiko Hayashi
---
drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinc
Add clock control for ethernet controller on Pro4, PXs2, LD11 and LD20.
Signed-off-by: Kunihiko Hayashi
---
drivers/clk/uniphier/clk-uniphier-sys.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/clk/uniphier/clk-uniphier-sys.c
b/drivers/clk/uniphier/clk-uniphier-sys.c
Add reset lines for ethernet controller on Pro4, PXs2, LD11 and
LD20 SoCs.
Signed-off-by: Kunihiko Hayashi
---
drivers/reset/reset-uniphier.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
index bda2dd1..6e40f7d 100644
-id and functions
Kunihiko Hayashi (2):
dt-bindings: net: add DT bindings for Socionext UniPhier AVE
net: ethernet: socionext: add AVE ethernet driver
.../bindings/net/socionext,uniphier-ave4.txt | 44 +
drivers/net/ethernet/Kconfig |1 +
drivers/net/ethernet
DT bindings for the AVE ethernet controller found on Socionext's
UniPhier platforms.
Signed-off-by: Kunihiko Hayashi
Signed-off-by: Jassi Brar
---
.../bindings/net/socionext,uniphier-ave4.txt | 44 ++
1 file changed, 44 insertions(+)
create mode 100644
Document
From: Jassi Brar
Add RTL8201F phy-id and the related functions to the driver.
The original patch is as follows:
https://patchwork.kernel.org/patch/2538341/
Signed-off-by: Jongsung Kim
Signed-off-by: Jassi Brar
Signed-off-by: Kunihiko Hayashi
---
drivers/net/phy/realtek.c | 45
The UniPhier platform from Socionext provides the AVE ethernet
controller that includes MAC and MDIO bus supporting RGMII/RMII
modes. The controller is named AVE.
Signed-off-by: Kunihiko Hayashi
Signed-off-by: Jassi Brar
---
drivers/net/ethernet/Kconfig |1 +
drivers/net
thought that the driver had to stop the own interrupt of PHY device
because it might be already enabled.
But surely we don't think of such a case.
> > +
> > + /* When PHY driver can't handle its interrupt directly,
> > +* interrupt request always fails and polling method is used
> > +* alternatively. In this case, the libphy says
> > +* "libphy: uniphier-mdio: Can't get IRQ -1 (PHY)".
> > +*/
> > + phy_start_interrupts(phydev);
>
> -1 is PHY_POLL. So calling phy_start_interrupts() is wrong. In fact,
> you should not be calling phy_start_interrupts() at all. No other
> Ethernet driver does.
The phy_start_interrupts() calls request_threaded_irq(), and it wll succeed
when PHY node has own 'interrupts' property.
In this case, it will fail and phydev->irq sets PHY_POLL.
However, phydev->irq is initialized PHY_POLL in phy_probe(),
surely it isn't necessary.
> > +
> > + phy_start_aneg(phydev);
> > +
> > + return 0;
> > +}
> > +
> > +static void ave_uninit(struct net_device *ndev)
> > +{
> > + struct ave_private *priv = netdev_priv(ndev);
> > +
> > + phy_stop_interrupts(priv->phydev);
>
> And no other Ethernet driver calls phy_stop_interrupts either.
> Please take a look at this.
I see. I'll check it.
>
> > + phy_disconnect(priv->phydev);
> > +}
> > +
>
> Andrew
---
Best Regards,
Kunihiko Hayashi
Hi Yamada-san,
Thank you for your comments,
On Fri, 8 Sep 2017 23:44:13 +0900 wrote:
> 2017-09-08 22:02 GMT+09:00 Kunihiko Hayashi :
>
> > diff --git a/drivers/net/ethernet/socionext/Kconfig
> > b/drivers/net/ethernet/socionext/Kconfig
> > new file mode 100644
&g
Hi Florian,
Thank you for your comments,
On Fri, 8 Sep 2017 12:31:18 -0700 wrote:
> On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote:
> > The UniPhier platform from Socionext provides the AVE ethernet
> > controller that includes MAC and MDIO bus supporting RGMII/RMII
> > mod
Hi Florian,
On Sat, 9 Sep 2017 09:30:58 -0700 wrote:
>
>
> On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote:
> > The UniPhier platform from Socionext provides the AVE ethernet
> > controller that includes MAC and MDIO bus supporting RGMII/RMII
> > modes.
t;
>mdio {
> ethphy: ethernet-phy@6 {
> reg = <6>;
> };
> };
>
> Andrew
I see. I'll rewrite the binding example using mdio node.
---
Best Regards,
Kunihiko Hayashi
Hi Florian,
On Fri, 8 Sep 2017 11:54:31 -0700 wrote:
> On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote:
> > DT bindings for the AVE ethernet controller found on Socionext's
> > UniPhier platforms.
> >
> > Signed-off-by: Kunihiko Hayashi
> > Signed-off-by:
Hi Andrew,
Thank your for reviewing.
On Sat, 9 Sep 2017 17:55:17 +0200 wrote:
> On Sat, Sep 09, 2017 at 09:03:05AM +0530, Jassi Brar wrote:
> > On 9 September 2017 at 00:21, Florian Fainelli wrote:
> > > On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote:
> > >> From:
Add nodes of thermal monitor and thermal zone for UniPhier LD20 SoC.
The thermal monitor is included in sysctrl.
Furthermore, since the reference board doesn't have a calibrated value of
thermal monitor, this patch gives the default value for LD20 reference
board.
Signed-off-by: Kunihiko Ha
evice tree
- fix an interrupt trigger to set 'level-triggered' according to
hardware specification
- bring up threshold temperature for LD20 according to the spec sheet
- add cpuN labels for reference in cooling-device property on PXs2 dts
[1] https://lkml.org/lkml/2017/6/28/170
Kuni
Add nodes of thermal monitor and thermal zone for UniPhier PXs2 SoC.
The thermal monitor is included in sysctrl.
Furthermore, add cpuN labels for reference in cooling-device property.
Signed-off-by: Kunihiko Hayashi
---
arch/arm/boot/dts/uniphier-pxs2.dtsi | 43
Yamada-san,
On Thu, 10 Aug 2017 19:48:22 +0900 wrote:
> Hi Hayashi-san,
>
>
> 2017-07-05 20:53 GMT+09:00 Kunihiko Hayashi :
> > Add nodes of thermal monitor and thermal zone for UniPhier LD20 SoC.
> > The thermal monitor is included in sysctrl.
> >
> > Fu
Yamada-san,
On Thu, 10 Aug 2017 19:44:38 +0900 wrote:
> Hayashi-san
>
>
> 2017-07-05 20:53 GMT+09:00 Kunihiko Hayashi :
> > Add nodes of thermal monitor and thermal zone for UniPhier PXs2 SoC.
> > The thermal monitor is included in sysctrl.
> > Furthermore, ad
Add nodes of thermal monitor and thermal zone for UniPhier LD20 SoC.
The thermal monitor node is included in sysctrl. Since the efuse might not
have a calibrated value of thermal monitor, this patch gives the default
value for LD20.
Signed-off-by: Kunihiko Hayashi
---
arch/arm64/boot/dts
7; according to
hardware specification
- bring up threshold temperature for LD20 according to the spec sheet
- add cpuN labels for reference in cooling-device property on PXs2 dts
[1] https://lkml.org/lkml/2017/6/28/170
Kunihiko Hayashi (2):
ARM: dts: uniphier: add nodes of thermal monitor and t
property.
Signed-off-by: Kunihiko Hayashi
---
arch/arm/boot/dts/uniphier-pxs2.dtsi | 47 +---
1 file changed, 43 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/uniphier-pxs2.dtsi
b/arch/arm/boot/dts/uniphier-pxs2.dtsi
index 90b020c..f2dfebe 100644
Initial version of device tree for LD20/11 Global boards.
---
Changes in v2:
- use SPDX-License-Identifier for the license description
- add the atmel manufacturer to the compatible string for I2C EEPROM
Kunihiko Hayashi (2):
arm64: dts: uniphier: add support for LD11 Global board
arm64
Add initial device tree support for LD20 Global board.
Signed-off-by: Kunihiko Hayashi
---
arch/arm64/boot/dts/socionext/Makefile | 1 +
.../boot/dts/socionext/uniphier-ld20-global.dts| 52 ++
2 files changed, 53 insertions(+)
create mode 100644 arch/arm64
Add initial device tree support for LD11 Global board.
Signed-off-by: Kunihiko Hayashi
---
arch/arm64/boot/dts/socionext/Makefile | 1 +
.../boot/dts/socionext/uniphier-ld11-global.dts| 70 ++
2 files changed, 71 insertions(+)
create mode 100644 arch/arm64
here with the clock, the block is clocked, so it can consume some
> > amount of power, just do the necessary HW initialization with the clock
> > enabled, then defer until ndo_open() before turning it back on.
There are a number of the functions that needs clock enabled and "block reset"
operations, like mdiobus_register(), phy_connect(), and so on.
I tried to move such functions to ndo_open() to defer clock enabled until
ndo_open().
However, the driver didn't work for some reasons of hardware restriction.
I think it's hard to change this sequence.
---
Best Regards,
Kunihiko Hayashi
labels and mask definitions, and remove unused codes
Kunihiko Hayashi (2):
dt-bindings: net: add DT bindings for Socionext UniPhier AVE
net: ethernet: socionext: add AVE ethernet driver
.../bindings/net/socionext,uniphier-ave4.txt | 53 +
drivers/net/ethernet/Kconfig
DT bindings for the AVE ethernet controller found on Socionext's
UniPhier platforms.
Signed-off-by: Kunihiko Hayashi
Signed-off-by: Jassi Brar
---
.../bindings/net/socionext,uniphier-ave4.txt | 53 ++
1 file changed, 53 insertions(+)
create mode 100644
Document
The UniPhier platform from Socionext provides the AVE ethernet
controller that includes MAC and MDIO bus supporting RGMII/RMII
modes. The controller is named AVE.
Signed-off-by: Kunihiko Hayashi
Signed-off-by: Jassi Brar
---
drivers/net/ethernet/Kconfig |1 +
drivers/net
Hello,
On Fri, 21 Jul 2017 22:34:49 +0900 wrote:
> Hello,
>
> 2017-07-21 22:24 GMT+09:00 Masahiro Yamada :
> > 2017-07-21 20:21 GMT+09:00 Kunihiko Hayashi
> > :
> >> This series adds support for CPU temperature monitor modules implemented
> >> on U
On Fri, 21 Jul 2017 22:21:05 +0900 wrote:
> 2017-07-21 20:21 GMT+09:00 Kunihiko Hayashi :
>
> > +static int uniphier_tm_initialize_sensor(struct uniphier_tm_dev *tdev)
> > +{
> > + struct regmap *map = tdev->regmap;
> > + u32 val;
> > +
r of lines
- improve some comments and copyright description
Kunihiko Hayashi (2):
dt-bindings: thermal: add binding documentation for UniPhier thermal
monitor
thermal: uniphier: add UniPhier thermal driver
.../bindings/thermal/uniphier-thermal.txt | 64
drivers/therm
Add a thermal driver for on-chip PVT (Process, Voltage and Temperature)
monitoring unit implemented on UniPhier SoCs. This driver supports
temperature monitoring and alert function.
Signed-off-by: Kunihiko Hayashi
---
drivers/thermal/Kconfig| 8 +
drivers/thermal/Makefile
Add devicetree binding documentation for thermal monitor implemented on
Socionext UniPhier SoCs.
Signed-off-by: Kunihiko Hayashi
Acked-by: Rob Herring
---
.../bindings/thermal/uniphier-thermal.txt | 64 ++
1 file changed, 64 insertions(+)
create mode 100644
Hi Eduardo,
Thank you for your comment.
On Fri, 30 Jun 2017 20:16:33 -0700 wrote:
> Hey,
>
> On Wed, Jun 28, 2017 at 07:11:59PM +0900, Kunihiko Hayashi wrote:
> > Add a thermal driver for on-chip PVT (Process, Voltage and Temperature)
> > monitoring unit implemented o
etif_carrier functions, phydev initializer, and Tx budget check
- change obsolate codes
- replace ndev->{base_addr,irq} with the members of ave_private
- rename goto labels and mask definitions, and remove unused codes
Kunihiko Hayashi (2):
dt-bindings: net: add DT bindings for Socionext UniPhi
DT bindings for the AVE ethernet controller found on Socionext's
UniPhier platforms.
Signed-off-by: Kunihiko Hayashi
Signed-off-by: Jassi Brar
Acked-by: Rob Herring
---
.../bindings/net/socionext,uniphier-ave4.txt | 48 ++
1 file changed, 48 insertions(+)
c
The UniPhier platform from Socionext provides the AVE ethernet
controller that includes MAC and MDIO bus supporting RGMII/RMII
modes. The controller is named AVE.
Signed-off-by: Kunihiko Hayashi
Signed-off-by: Jassi Brar
---
drivers/net/ethernet/Kconfig |1 +
drivers/net
DT bindings for the AVE ethernet controller found on Socionext's
UniPhier platforms.
Signed-off-by: Kunihiko Hayashi
Signed-off-by: Jassi Brar
Acked-by: Rob Herring
---
.../bindings/net/socionext,uniphier-ave4.txt | 48 ++
1 file changed, 48 insertions(+)
c
perations
- add phydev check on ave_{get,set}_wol()
- remove netif_carrier functions, phydev initializer, and Tx budget check
- change obsolate codes
- replace ndev->{base_addr,irq} with the members of ave_private
- rename goto labels and mask definitions, and remove unused codes
Kunihik
The UniPhier platform from Socionext provides the AVE ethernet
controller that includes MAC and MDIO bus supporting RGMII/RMII
modes. The controller is named AVE.
Signed-off-by: Kunihiko Hayashi
Signed-off-by: Jassi Brar
Reviewed-by: Andrew Lunn
---
drivers/net/ethernet/Kconfig
On Mon, 11 Dec 2017 10:19:15 +0100 Phlippe Ombredanne
wrote:
> Dear Kunihiko-san,
>
> On Mon, Dec 11, 2017 at 8:57 AM, Kunihiko Hayashi
> wrote:
> > The UniPhier platform from Socionext provides the AVE ethernet
> > controller that includes MAC and MDIO bus support
on, the variable "no_msi" can be removed.
Initially, test->irq_type has IRQ_TYPE_UNDEFINED, and the
ioctl(GET_IRQTYPE) before calling ioctl(SET_IRQTYPE) will return an error.
Suggested-by: Niklas Cassel
Suggested-by: Manivannan Sadhasivam
Signed-off-by: Kunihiko Hayashi
ot;devm" version of IRQ functions (patch 5/5)
Changes since v1:
- Divide original patch into two
- Add an error message example
- Add "pcitest" display example
- Add a patch to fix an interrupt remaining issue
Kunihiko Hayashi (6):
selftests: pci_endpoint: Add GET_IRQTYPE checks
s issue by propagating the current type to the global "irq_type".
Cc: sta...@vger.kernel.org
Fixes: b2ba9225e031 ("misc: pci_endpoint_test: Avoid using module parameter to
determine irqtype")
Reviewed-by: Niklas Cassel
Signed-off-by: Kunihiko Hayashi
---
drivers/misc/pci_endpoin
Sadhasivam
Signed-off-by: Kunihiko Hayashi
---
drivers/misc/pci_endpoint_test.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
index 326e8e467c42..7a14114488a0 100644
--- a/drivers/misc/pci_endpoint_test.c
o test->num_irqs
and release IRQs in advance by calling pci_endpoint_test_release_irq().
Cc: sta...@vger.kernel.org
Fixes: e03327122e2c ("pci_endpoint_test: Add 2 ioctl commands")
Reviewed-by: Manivannan Sadhasivam
Signed-off-by: Kunihiko Hayashi
---
drivers/misc/pci_endpoint_test.c | 3
Add GET_IRQTYPE API checks to each interrupt test.
And change pci_ep_ioctl() to get the appropriate return value from
ioctl().
Suggested-by: Manivannan Sadhasivam
Signed-off-by: Kunihiko Hayashi
---
.../selftests/pci_endpoint/pci_endpoint_test.c| 11 ++-
1 file changed, 10
uest IRQ 30 for MSI 3
SET IRQ TYPE TO MSI-X: NOT OKAY
Fix this issue by using test->irq_type instead of global "irq_type".
Cc: sta...@vger.kernel.org
Fixes: b2ba9225e031 ("misc: pci_endpoint_test: Avoid using module parameter to
determine irqtype")
Reviewed-by
/gpio-uniphier.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
Looks good to me.
Acked-by: Kunihiko Hayashi
Thank you,
---
Best Regards
Kunihiko Hayashi
401 - 457 of 457 matches
Mail list logo
