The pci_endpoint_test_request_irq() and pci_endpoint_test_release_irq()
are called repeatedly by the users through pci_endpoint_test_set_irq().
So using the managed version of IRQ functions within these functions
has no effect.

Suggested-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org>
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
---
 drivers/misc/pci_endpoint_test.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
index 326e8e467c42..7a14114488a0 100644
--- a/drivers/misc/pci_endpoint_test.c
+++ b/drivers/misc/pci_endpoint_test.c
@@ -208,10 +208,9 @@ static void pci_endpoint_test_release_irq(struct 
pci_endpoint_test *test)
 {
        int i;
        struct pci_dev *pdev = test->pdev;
-       struct device *dev = &pdev->dev;
 
        for (i = 0; i < test->num_irqs; i++)
-               devm_free_irq(dev, pci_irq_vector(pdev, i), test);
+               free_irq(pci_irq_vector(pdev, i), test);
 
        test->num_irqs = 0;
 }
@@ -224,9 +223,9 @@ static int pci_endpoint_test_request_irq(struct 
pci_endpoint_test *test)
        struct device *dev = &pdev->dev;
 
        for (i = 0; i < test->num_irqs; i++) {
-               ret = devm_request_irq(dev, pci_irq_vector(pdev, i),
-                                      pci_endpoint_test_irqhandler,
-                                      IRQF_SHARED, test->name, test);
+               ret = request_irq(pci_irq_vector(pdev, i),
+                                 pci_endpoint_test_irqhandler, IRQF_SHARED,
+                                 test->name, test);
                if (ret)
                        goto fail;
        }
-- 
2.25.1


Reply via email to