Re: [PATCH] xen/arm: correct comment in enlighten.c

2015-10-15 Thread Juergen Gross
David or Stefano, On 09/14/2015 03:39 PM, Stefano Stabellini wrote: On Mon, 14 Sep 2015, Juergen Gross wrote: Correct a comment in arch/arm/xen/enlighten.c referencing a wrong source file. Signed-off-by: Juergen Gross Acked-by: Stefano Stabellini does one of you plan to take this patch

Re: [PATCH] xen: fix the check of e_pfn in xen_find_pfn_range

2015-09-02 Thread Juergen Gross
ro size in xen_find_pfn_range. Signed-off-by: Zhenzhong Duan Reviewed-by: Juergen Gross --- arch/x86/xen/setup.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c index a3a7546..c11f6b2 100644 --- a/arch/x86/xen/setup.c +++

Re: [PATCH RFC] xen: if on Xen, "flatten" the scheduling domain hierarchy

2015-09-02 Thread Juergen Gross
On 08/31/2015 06:12 PM, Boris Ostrovsky wrote: On 08/20/2015 02:16 PM, Juergen Groß wrote: On 08/18/2015 05:55 PM, Dario Faggioli wrote: Hey everyone, So, as a followup of what we were discussing in this thread: [Xen-devel] PV-vNUMA issue: topology is misinterpreted by the guest http://li

Re: [PATCH RFC] xen: if on Xen, "flatten" the scheduling domain hierarchy

2015-09-02 Thread Juergen Gross
On 09/02/2015 04:08 PM, Boris Ostrovsky wrote: On 09/02/2015 07:58 AM, Juergen Gross wrote: On 08/31/2015 06:12 PM, Boris Ostrovsky wrote: On 08/20/2015 02:16 PM, Juergen Groß wrote: On 08/18/2015 05:55 PM, Dario Faggioli wrote: Hey everyone, So, as a followup of what we were discussing

Re: [PATCH] xen/p2m: fix extra memory regions accounting

2015-09-03 Thread Juergen Gross
that the ranges that are added to the xen_extra_mem array are aligned to page boundaries. Signed-off-by: Roger Pau Monné Cc: Konrad Rzeszutek Wilk Cc: Boris Ostrovsky Cc: David Vrabel Cc: Juergen Gross Cc: xen-de...@lists.xenproject.org --- AFAICT this patch needs to be backported to 3.19, 4.0

Re: [PATCH] xen/p2m: fix extra memory regions accounting

2015-09-03 Thread Juergen Gross
stead of 0xdfdf9c00. In order to fix this, make sure that the ranges that are added to the xen_extra_mem array are aligned to page boundaries. Signed-off-by: Roger Pau Monné Cc: Konrad Rzeszutek Wilk Cc: Boris Ostrovsky Cc: David Vrabel Cc: Juergen Gross Cc: xen-de...@lists.xenprojec

Re: [PATCH] xen/p2m: fix extra memory regions accounting

2015-09-03 Thread Juergen Gross
On 09/03/2015 04:38 PM, Roger Pau Monné wrote: El 03/09/15 a les 14.25, Juergen Gross ha escrit: On 09/03/2015 02:05 PM, Roger Pau Monne wrote: On systems with memory maps with ranges that don't end at page boundaries, like: [...] (XEN) 0010 - dfdf9c00 (usable)

Re: [Xen-devel] [PATCH] xen/p2m: fix extra memory regions accounting

2015-09-03 Thread Juergen Gross
On 09/03/2015 04:52 PM, David Vrabel wrote: On 03/09/15 15:45, David Vrabel wrote: On 03/09/15 15:38, Roger Pau Monné wrote: El 03/09/15 a les 14.25, Juergen Gross ha escrit: On 09/03/2015 02:05 PM, Roger Pau Monne wrote: On systems with memory maps with ranges that don't end at

Re: [Xen-devel] [PATCH] xen/p2m: fix extra memory regions accounting

2015-09-03 Thread Juergen Gross
On 09/03/2015 05:01 PM, David Vrabel wrote: On 03/09/15 15:55, Juergen Gross wrote: On 09/03/2015 04:52 PM, David Vrabel wrote: On 03/09/15 15:45, David Vrabel wrote: On 03/09/15 15:38, Roger Pau Monné wrote: El 03/09/15 a les 14.25, Juergen Gross ha escrit: On 09/03/2015 02:05 PM, Roger

Re: [Xen-devel] [PATCH] xen/p2m: fix extra memory regions accounting

2015-09-03 Thread Juergen Gross
On 09/03/2015 05:39 PM, Roger Pau Monné wrote: El 03/09/15 a les 17.20, Juergen Gross ha escrit: On 09/03/2015 05:01 PM, David Vrabel wrote: On 03/09/15 15:55, Juergen Gross wrote: On 09/03/2015 04:52 PM, David Vrabel wrote: On 03/09/15 15:45, David Vrabel wrote: On 03/09/15 15:38, Roger

Re: [Xen-devel] [PATCH] xen/p2m: fix extra memory regions accounting

2015-09-03 Thread Juergen Gross
Hi Roger, On 09/03/2015 05:39 PM, Roger Pau Monné wrote: El 03/09/15 a les 17.20, Juergen Gross ha escrit: On 09/03/2015 05:01 PM, David Vrabel wrote: On 03/09/15 15:55, Juergen Gross wrote: On 09/03/2015 04:52 PM, David Vrabel wrote: On 03/09/15 15:45, David Vrabel wrote: On 03/09/15 15

Re: [4.2, Regression] Queued spinlocks cause major XFS performance regression

2015-09-04 Thread Juergen Gross
On 09/04/2015 09:11 AM, Dave Chinner wrote: On Thu, Sep 03, 2015 at 11:39:21PM -0700, Linus Torvalds wrote: On Thu, Sep 3, 2015 at 10:48 PM, Dave Chinner wrote: When I turned spinlock debugging off on 4.2 to get some perf numbers a request from Linus, I got this: [ ugly numbers deleted ]

Re: [Xen-devel] [PATCH] xen/p2m: fix extra memory regions accounting

2015-09-04 Thread Juergen Gross
On 09/04/2015 09:37 AM, Roger Pau Monné wrote: Hello, El 04/09/15 a les 7.07, Juergen Gross ha escrit: Could you try the attached patch? It should do the job. It is booting fine on my laptop, but I think you should try it on the machine with the memory ranges not at page boundary. Juergen

Re: [Xen-devel] [PATCH] xen/p2m: fix extra memory regions accounting

2015-09-04 Thread Juergen Gross
On 09/04/2015 09:57 AM, Roger Pau Monné wrote: El 04/09/15 a les 9.47, Juergen Gross ha escrit: On 09/04/2015 09:37 AM, Roger Pau Monné wrote: Hello, El 04/09/15 a les 7.07, Juergen Gross ha escrit: Could you try the attached patch? It should do the job. It is booting fine on my laptop, but

Re: Kernel crash with "xen: avoid early crash of memory limited dom0"

2015-09-04 Thread Juergen Gross
On 09/04/2015 11:48 AM, Roger Pau Monné wrote: Hello, The following commit: commit fa84f27e21200dbe7d18c21af424d1de703b7567 Author: Juergen Gross Date: Wed Aug 19 18:52:34 2015 +0200 xen: avoid early crash of memory limited dom0 Which is queued in: git://git.kernel.org/pub/scm/linux

Re: [Xen-devel] Kernel crash with "xen: avoid early crash of memory limited dom0"

2015-09-04 Thread Juergen Gross
On 09/04/2015 12:10 PM, David Vrabel wrote: On 04/09/15 10:48, Roger Pau Monné wrote: Hello, The following commit: commit fa84f27e21200dbe7d18c21af424d1de703b7567 Author: Juergen Gross Date: Wed Aug 19 18:52:34 2015 +0200 xen: avoid early crash of memory limited dom0 Which is queued in

[PATCH] xen: switch extra memory accounting to use pfns

2015-09-04 Thread Juergen Gross
Instead of using physical addresses for accounting of extra memory areas available for ballooning switch to pfns as this is much less error prone regarding partial pages. Reported-by: Roger Pau Monné Signed-off-by: Juergen Gross --- arch/x86/xen/setup.c | 80

[PATCH] xen: limit memory to architectural maximum

2015-09-04 Thread Juergen Gross
oblem will occur when dom0 is started with an initial memory size being a multiple of 1GB, but without specifying it's maximum memory size. The kernel must be configured without CONFIG_XEN_BALLOON_MEMORY_HOTPLUG for the problem to happen. Reported-by: Roger Pau Monné Signed-off-by: Jue

[PATCH] xen: use correct type for HYPERVISOR_memory_op()

2015-09-04 Thread Juergen Gross
TB of memory or more. Correct this by using the correct type. Signed-off-by: Juergen Gross --- arch/x86/include/asm/xen/hypercall.h | 4 ++-- arch/x86/xen/setup.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/include/asm/xen/hypercall.h b/arch

Re: [PATCH 2/4] xen/blkfront: cleanup stale persistent grants

2018-08-07 Thread Juergen Gross
On 07/08/18 16:14, Roger Pau Monné wrote: > On Tue, Aug 07, 2018 at 08:31:31AM +0200, Juergen Gross wrote: >> On 06/08/18 18:16, Roger Pau Monné wrote: >>> On Mon, Aug 06, 2018 at 01:34:01PM +0200, Juergen Gross wrote: >>>> Add a periodic cleanup function to remo

Re: [PATCH] semaphore: use raw_spin_lock_irq instead of raw_spin_lock_irqsave

2018-06-21 Thread Juergen Gross
On 21/06/18 16:02, Ingo Molnar wrote: > > * Ingo Molnar wrote: > >> >> * Mikulas Patocka wrote: >> >>> The sleeping functions down, down_interruptible, down_killable and >>> down_timeout can't be called with interrupts disabled, so we don't have to >>> save and restore interrupt flag. >>> >>> T

Re: [PATCH] x86/irqflags: mark native_restore_fl extern inline

2018-08-27 Thread Juergen Gross
: sta...@vger.kernel.org # 4.18, 4.14, 4.9, 4.4 > Reported-by: Ben Hutchings > Signed-off-by: Nick Desaulniers Reviewed-by: Juergen Gross Juergen

Re: [PATCH] x86/irqflags: mark native_restore_fl extern inline

2018-08-27 Thread Juergen Gross
On 28/08/18 07:13, Greg Kroah-Hartman wrote: > On Mon, Aug 27, 2018 at 02:40:09PM -0700, Nick Desaulniers wrote: >> Fixes commit 208cbb325589 ("x86/irqflags: Provide a declaration for >> native_save_fl") >> >> This should have been marked extern inline in order to pick up the out >> of line definit

Re: [PATCH 1/3] xen/gntdev: fix up blockable calls to mn_invl_range_start

2018-08-27 Thread Juergen Gross
stinguish blockable mode for mmu notifiers") > Cc: Boris Ostrovsky > Cc: Juergen Gross > Signed-off-by: Michal Hocko Reviewed-by: Juergen Gross Juergen

Re: [PATCH] xen-blkback: Switch to closed state after releasing the backing device

2018-08-29 Thread Juergen Gross
On 29/08/18 08:52, Valentin Vidic wrote: > Switching to closed state earlier can cause the block-drbd > script to fail with 'Device is held open by someone': > > root: /etc/xen/scripts/block-drbd: remove XENBUS_PATH=backend/vbd/6/51712 > kernel: [ .278235] block drbd6: State change failed: Dev

Access to non-RAM pages

2018-08-29 Thread Juergen Gross
Running as a Xen guest a customer's system experienced problems due to load_unaligned_zeropad() hitting a ballooned memory page. The 8 byte read was meant to read the last 4 bytes from a kernel page and should have returned 4 zero bytes for the not allocated page after that. In order not to split

[PATCH v2 10/11] x86/paravirt: move the Xen-only pv_mmu_ops under the PARAVIRT_XXL umbrella

2018-08-13 Thread Juergen Gross
Most of the paravirt ops defined in pv_mmu_ops are for Xen PV guests only. Define them only if CONFIG_PARAVIRT_XXL is set. Signed-off-by: Juergen Gross --- arch/x86/include/asm/fixmap.h | 2 +- arch/x86/include/asm/mmu_context.h| 4 +- arch/x86/include/asm/paravirt.h | 115

[PATCH v2 06/11] x86/paravirt: introduce new config option PARAVIRT_XXL

2018-08-13 Thread Juergen Gross
A large amount of paravirt ops is used by Xen PV guests only. Add a new config option PARAVIRT_XXL which is selected by XEN_PV. Later we can put the Xen PV only paravirt ops under the PARACVIRT_XXL umbrella. Signed-off-by: Juergen Gross --- arch/x86/Kconfig | 3 +++ arch/x86/xen/Kconfig | 1

[PATCH v2 00/11] x86/paravirt: several cleanups

2018-08-13 Thread Juergen Gross
ore Xen PV-only code behind CONFIG_XEN_PV. Changes in V2: - patch 4: shorten pv_ops sub-structure names (Jan Beulich) - patch 11: new patch Juergen Gross (11): x86/paravirt: make paravirt_patch_call() and paravirt_patch_jmp() static x86/paravirt: remove clobbers parameter from para

[PATCH v2 05/11] x86/paravirt: remove unused paravirt bits

2018-08-13 Thread Juergen Gross
The macros ENABLE_INTERRUPTS_SYSEXIT, GET_CR0_INTO_EAX and PARAVIRT_ADJUST_EXCEPTION_FRAME are used nowhere. Remove their definitions. Signed-off-by: Juergen Gross --- arch/x86/include/asm/irqflags.h | 4 arch/x86/include/asm/paravirt.h | 9 + arch/x86/kernel/asm-offsets.c | 1

[PATCH v2 01/11] x86/paravirt: make paravirt_patch_call() and paravirt_patch_jmp() static

2018-08-13 Thread Juergen Gross
paravirt_patch_call() and paravirt_patch_jmp() are used in paravirt.c only. Convert them to static. Signed-off-by: Juergen Gross --- arch/x86/include/asm/paravirt_types.h | 6 -- arch/x86/kernel/paravirt.c| 12 ++-- 2 files changed, 6 insertions(+), 12 deletions

Re: Problems with Zen under Xen and recent Linux kernel improvements

2018-07-31 Thread Juergen Gross
On 31/07/18 03:14, Adam Novak wrote: > Hello, > > I was advised to take this here, and to Boris Ostrovsky and Juergen > Gross, by Thomas Gleixner. > > I am having some trouble with the new speculation control code that > has been added to the Linux kernel, for AMD Zen CPUs.

[PATCH] xen/blkfront: remove unused macros

2018-07-25 Thread Juergen Gross
Remove some macros not used anywhere. Signed-off-by: Juergen Gross --- drivers/block/xen-blkfront.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index b5cedccb5d7d..94300dbe358b 100644 --- a/drivers/block/xen-blkfront.c

[PATCH 1/2] x86/acpi: add retrieval function for rsdp address

2018-01-25 Thread Juergen Gross
Add a function to get the address of the RSDP table. Per default use a __weak annotated function being a nop. Cc: # 4.11 Signed-off-by: Juergen Gross --- drivers/acpi/osl.c | 10 +- include/linux/acpi.h | 2 ++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH 0/2] xen: re-enable booting as Xen PVH guest

2018-01-25 Thread Juergen Gross
r the RSDP in low memory. After a recent change in Xen putting the RSDP to a higher address booting as PVH guest is now failing. This small series repairs that by passing the RSDP address from the start_info block to ACPI handling. Juergen Gross (2): x86/acpi: add retrieval function for rsdp ad

[PATCH 2/2] xen: add acpi_arch_get_root_pointer() for pvh guests

2018-01-25 Thread Juergen Gross
method to locate the RSDP was working when running as PVH mode. Cc: # 4.11 Signed-off-by: Juergen Gross --- arch/x86/xen/enlighten_pvh.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/arch/x86/xen/enlighten_pvh.c b/arch/x86/xen/enlighten_pvh.c index

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

2018-01-25 Thread Juergen Gross
On 25/01/18 11:22, Peter Zijlstra wrote: > On Thu, Jan 25, 2018 at 10:02:05AM +, David Woodhouse wrote: >> On Tue, 2018-01-23 at 16:25 +0100, Peter Zijlstra wrote: >>> Paravirt emits indirect calls which get flagged by objtool retpoline >>> checks, annotate it away because all these indirect ca

Re: [PATCH 2/2] xen: add acpi_arch_get_root_pointer() for pvh guests

2018-01-25 Thread Juergen Gross
On 25/01/18 11:37, Greg KH wrote: > On Thu, Jan 25, 2018 at 11:04:54AM +0100, Juergen Gross wrote: >> Add acpi_arch_get_root_pointer() for Xen PVH guests to communicate >> the address of the RSDP table given to the kernel via Xen start info. >> >> This makes the kernel b

Re: [PATCH 2/2] xen: add acpi_arch_get_root_pointer() for pvh guests

2018-01-25 Thread Juergen Gross
On 25/01/18 12:00, Greg KH wrote: > On Thu, Jan 25, 2018 at 11:49:35AM +0100, Juergen Gross wrote: >> On 25/01/18 11:37, Greg KH wrote: >>> On Thu, Jan 25, 2018 at 11:04:54AM +0100, Juergen Gross wrote: >>>> Add acpi_arch_get_root_pointer() for Xen PVH guests to commu

[PATCH v2 1/2] x86/acpi: add retrieval function for rsdp address

2018-01-25 Thread Juergen Gross
Add a function to get the address of the RSDP table. Per default use a __weak annotated function being a nop. Cc: # 4.11 Signed-off-by: Juergen Gross --- drivers/acpi/osl.c | 10 +- include/linux/acpi.h | 2 ++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 0/2] xen: re-enable booting as Xen PVH guest

2018-01-25 Thread Juergen Gross
r the RSDP in low memory. After a recent change in Xen putting the RSDP to a higher address booting as PVH guest is now failing. This small series repairs that by passing the RSDP address from the start_info block to ACPI handling. Juergen Gross (2): x86/acpi: add retrieval function for rsdp ad

[PATCH v2 2/2] xen: add acpi_arch_get_root_pointer() for pvh guests

2018-01-25 Thread Juergen Gross
method to locate the RSDP was working when running as PVH mode. Cc: # 4.11 Signed-off-by: Juergen Gross --- arch/x86/xen/enlighten_pvh.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/arch/x86/xen/enlighten_pvh.c b/arch/x86/xen/enlighten_pvh.c index

Re: [Xen-devel] [block-xen-blkback] question about pontential null pointer dereference

2017-05-11 Thread Juergen Gross
On 10/05/17 18:49, Gustavo A. R. Silva wrote: > > Hello everybody, > > While looking into Coverity ID 1350942 I ran into the following piece of > code at drivers/block/xen-blkback/xenbus.c:490: > > 490static int xen_blkbk_remove(struct xenbus_device *dev) > 491{ > 492struct backend_info

Re: [PATCH v3] x86/amd: don't set X86_BUG_SYSRET_SS_ATTRS when running under Xen

2017-05-11 Thread Juergen Gross
On 27/04/17 07:01, Juergen Gross wrote: > When running as Xen pv guest X86_BUG_SYSRET_SS_ATTRS must not be set > on AMD cpus. > > This bug/feature bit is kind of special as it will be used very early > when switching threads. Setting the bit and clearing it a little bit > later

Re: [Intel-gfx] GPU hang with kernel 4.10rc3

2017-05-11 Thread Juergen Gross
On 11/05/17 23:08, Pavel Machek wrote: > On Mon 2017-01-23 10:39:27, Juergen Gross wrote: >> On 13/01/17 15:41, Juergen Gross wrote: >>> On 12/01/17 10:21, Chris Wilson wrote: >>>> On Thu, Jan 12, 2017 at 07:03:25AM +0100, Juergen Gross wrote: >>>>> On

[GIT PULL] xen: fixes for 4.12-rc0

2017-05-12 Thread Juergen Gross
): xen/x86: Do not call xen_init_time_ops() until shared_info is initialized Juergen Gross (3): x86/xen: fix xsave capability setting x86/amd: don't set X86_BUG_SYSRET_SS_ATTRS when running under Xen xen: adjust early dom0 p2m handling to xen hypervisor behavior

Re: [Xen-devel] HPET enabled in BIOS, not presented as available_clocksource -- config, kernel code, &/or BIOS?

2017-05-14 Thread Juergen Gross
On 13/05/17 22:16, Andrew Cooper wrote: > On 13/05/2017 21:05, PGNet Dev wrote: >> On 5/13/17 12:59 PM, Andrew Cooper wrote: >>> Ok. Lack of a clocksource is to be expected. >>> >>> The reason why the HPETs are unavailable is that dom0 is not a position >>> to program them; dom0 doesn't know what

[for-stable: PATCH] xen: adjust early dom0 p2m handling to xen hypervisor behavior

2017-05-15 Thread Juergen Gross
properly in guest physical address space. So when trying to obtain the guest physical address of such a page pud_pfn() and pmd_pfn() must be avoided as those will mask away guest physical address bits not being zero in this special case. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- This

Re: [patch 16/18] init: Introduce SYSTEM_BOOTING_UP/SMP states

2017-05-15 Thread Juergen Gross
d add them > to the xen do_poweroff() function. > > No functional change. > > Signed-off-by: Thomas Gleixner > Cc: Boris Ostrovsky Acked-by: Juergen Gross Juergen

Re: [PATCHv5, REBASED 8/9] x86: Enable 5-level paging support

2017-05-15 Thread Juergen Gross
On 15/05/17 14:12, Kirill A. Shutemov wrote: > Most of things are in place and we can enable support of 5-level paging. > > Enabling XEN with 5-level paging requires more work. The patch makes XEN > dependent on !X86_5LEVEL. > > Signed-off-by: Kirill A. Shutemov > --- > arch/x86/Kconfig | 5

Support of lguest?

2017-05-15 Thread Juergen Gross
Lguest and Xen pv-guests are the only users of pv_mmu_ops (with the one exception of the .exit_mmap member, which is being used by Xen HVM-guests, too). As it is possible now to build a kernel without Xen pv-guest support while keeping PVH and PVHVM support, I thought about putting most pv_mmu_ops

Re: [PATCHv5, REBASED 8/9] x86: Enable 5-level paging support

2017-05-15 Thread Juergen Gross
On 15/05/17 16:11, Kirill A. Shutemov wrote: > On Mon, May 15, 2017 at 02:31:00PM +0200, Juergen Gross wrote: >>> diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig >>> index 027987638e98..12205e6dfa59 100644 >>> --- a/arch/x86/xen/Kconfig >>> +++

Re: [x86-tip] RSDP changes converted i4790 box SMP -> UP

2018-01-11 Thread Juergen Gross
On 12/01/18 05:25, Mike Galbraith wrote: > Hi Juergen, > > Yesterday I wanted to test the RETPOLINE stuff in tip and tip-rt, but > discovered instead that my box had turned into a complete slug, not due > to incredible RETPOLINE overhead, rather because box had forgotten that > it had more than on

Re: [x86-tip] RSDP changes converted i4790 box SMP -> UP

2018-01-12 Thread Juergen Gross
On 12/01/18 09:01, Mike Galbraith wrote: > On Fri, 2018-01-12 at 07:40 +0100, Juergen Gross wrote: >> On 12/01/18 05:25, Mike Galbraith wrote: >>> Hi Juergen, >>> >>> Yesterday I wanted to test the RETPOLINE stuff in tip and tip-rt, but >>> discovered i

[GIT PULL] xen: fixes for 4.15-rc8

2018-01-12 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.15-rc8-tag xen: fixes for 4.15-rc8 It contains 2 build fixes for clang and 2 fixes for rather unlikely situations in the Xen gntdev driver. Thanks. Juergen arch/x86/xen/mmu_pv.c

Re: [PATCH] x86/paravirt: Remove 'noreplace-paravirt' cmdline option

2018-01-30 Thread Juergen Gross
just remove it. > > Signed-off-by: Josh Poimboeuf Reviewed-by: Juergen Gross Juergen

[PATCH] x86/xen: init %gs very early to avoid page faults with stack protector

2018-02-01 Thread Juergen Gross
When running as Xen pv guest %gs is initialized some time after C code is started. Depending on stack protector usage this might be too late, resulting in page faults. So setup %gs and MSR_GS_BASE in assembly code already. Cc: sta...@vger.kernel.org Signed-off-by: Juergen Gross --- arch/x86

Re: [PATCH] x86/xen: init %gs very early to avoid page faults with stack protector

2018-02-01 Thread Juergen Gross
On 01/02/18 13:22, Andrew Cooper wrote: > On 01/02/18 12:16, Juergen Gross wrote: >> When running as Xen pv guest %gs is initialized some time after >> C code is started. Depending on stack protector usage this might be >> too late, resulting in page faults. >> >>

[PATCH v2] x86/xen: init %gs very early to avoid page faults with stack protector

2018-02-01 Thread Juergen Gross
When running as Xen pv guest %gs is initialized some time after C code is started. Depending on stack protector usage this might be too late, resulting in page faults. So setup %gs and MSR_GS_BASE in assembly code already. Cc: sta...@vger.kernel.org Signed-off-by: Juergen Gross --- arch/x86

[GIT PULL] xen: fix for 4.15-rc7

2018-01-05 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.15-rc7-tag xen: fix for 4.15-rc7 It contains one minor fix adjusting the kmalloc flags in the new pvcalls driver added in rc1. Thanks. Juergen drivers/xen/pvcalls-front.c | 2 +-

Re: [PATCH v3 01/13] x86/retpoline: Add initial retpoline support

2018-01-05 Thread Juergen Gross
On 05/01/18 13:54, Thomas Gleixner wrote: > On Thu, 4 Jan 2018, David Woodhouse wrote: >> diff --git a/arch/x86/include/asm/cpufeatures.h >> b/arch/x86/include/asm/cpufeatures.h >> index 07cdd1715705..900fa7016d3f 100644 >> --- a/arch/x86/include/asm/cpufeatures.h >> +++ b/arch/x86/include/asm/cpu

Re: [PATCH v2] x86: xen: remove the use of VLAIS

2018-01-07 Thread Juergen Gross
o a helpful checkpatch warning from an earlier version of this > patch). > > Suggested-by: Juergen Gross > Signed-off-by: Nick Desaulniers Reviewed-by: Juergen Gross Juergen

Re: [PATCH v2] x86: xen: remove the use of VLAIS

2018-01-08 Thread Juergen Gross
ally. >> Further, we can get rid of the #ifdef's and rely on num_possible_cpus() >> (thanks to a helpful checkpatch warning from an earlier version of this >> patch). >> >> Suggested-by: Juergen Gross >> Signed-off-by: Nick Desaulniers >> --- >

Re: [PATCH v2] x86: xen: remove the use of VLAIS

2018-01-08 Thread Juergen Gross
VLAIS then calling >>> sizeof on *args, we calculate the appropriate sizeof args manually. >>> Further, we can get rid of the #ifdef's and rely on num_possible_cpus() >>> (thanks to a helpful checkpatch warning from an earlier version of this >>> patch). &g

Re: [PATCH v2 1/2] x86/acpi: add retrieval function for rsdp address

2018-01-27 Thread Juergen Gross
On 26/01/18 19:08, Andy Shevchenko wrote: > On Thu, Jan 25, 2018 at 4:36 PM, Juergen Gross wrote: >> Add a function to get the address of the RSDP table. Per default use a >> __weak annotated function being a nop. > > The problem with weak functions that we can

Re: [PATCH] x86/acpi: check rsdp address received via bootparams to be valid

2018-01-17 Thread Juergen Gross
On 17/01/18 12:49, Rafael J. Wysocki wrote: > On Tue, Jan 16, 2018 at 2:57 PM, Juergen Gross wrote: >> There seem to exist several grub2 versions trashing >> boot_params.hdr.acpi_rsdp_addr. >> >> So don't just believe this address to be valid, but verify it p

Re: [PATCH] x86/acpi: check rsdp address received via bootparams to be valid

2018-01-17 Thread Juergen Gross
On 16/01/18 17:35, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> On 16/01/18 16:46, Ingo Molnar wrote: >>> >>> * Juergen Gross wrote: >>> >>>> There seem to exist several grub2 versions trashing >>>> boot_params.hdr.acpi_r

Re: [PATCH] x86/acpi: check rsdp address received via bootparams to be valid

2018-01-17 Thread Juergen Gross
On 17/01/18 16:34, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> On 16/01/18 17:35, Ingo Molnar wrote: >>> >>> * Juergen Gross wrote: >>> >>>> On 16/01/18 16:46, Ingo Molnar wrote: >>>>> >>>>> * Ju

Re: [PATCH v2] x86: xen: remove the use of VLAIS

2018-01-08 Thread Juergen Gross
On 08/01/18 19:49, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> On 08/01/18 17:10, Peter Zijlstra wrote: >>> On Sat, Jan 06, 2018 at 01:39:48PM -0800, Nick Desaulniers wrote: >>>> Variable Length Arrays In Structs (VLAIS) is not supported by Cl

Re: [x86-tip] RSDP changes converted i4790 box SMP -> UP

2018-01-15 Thread Juergen Gross
On 12/01/18 09:01, Mike Galbraith wrote: > On Fri, 2018-01-12 at 07:40 +0100, Juergen Gross wrote: >> On 12/01/18 05:25, Mike Galbraith wrote: >>> Hi Juergen, >>> >>> Yesterday I wanted to test the RETPOLINE stuff in tip and tip-rt, but >>> discovered i

Re: [x86-tip] RSDP changes converted i4790 box SMP -> UP

2018-01-15 Thread Juergen Gross
On 12/01/18 14:11, Ingo Molnar wrote: > > * Mike Galbraith wrote: > >> Hi Juergen, >> >> Yesterday I wanted to test the RETPOLINE stuff in tip and tip-rt, but >> discovered instead that my box had turned into a complete slug, not due >> to incredible RETPOLINE overhead, rather because box had fo

Re: [x86-tip] RSDP changes converted i4790 box SMP -> UP

2018-01-15 Thread Juergen Gross
On 15/01/18 15:56, Borislav Petkov wrote: > On Mon, Jan 15, 2018 at 03:52:25PM +0100, Juergen Gross wrote: >> Ingo, with my finding that above boot failure is related to a bug in >> openSUSE's grub2 (I've verified it soesn't exist in upstream grub2), > > The b

Re: [x86-tip] RSDP changes converted i4790 box SMP -> UP

2018-01-15 Thread Juergen Gross
On 15/01/18 16:32, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> On 15/01/18 15:56, Borislav Petkov wrote: >>> On Mon, Jan 15, 2018 at 03:52:25PM +0100, Juergen Gross wrote: >>>> Ingo, with my finding that above boot failure is related to a bug in >

Re: [x86-tip] RSDP changes converted i4790 box SMP -> UP

2018-01-15 Thread Juergen Gross
On 15/01/18 17:29, Gabriel C wrote: > On 15.01.2018 16:40, Juergen Gross wrote: >> On 15/01/18 16:32, Ingo Molnar wrote: >>> > > Hi Juergen, > >>> * Juergen Gross wrote: >>> >>>> On 15/01/18 15:56, Borislav Petkov wrote: >>&g

Re: [x86-tip] RSDP changes converted i4790 box SMP -> UP

2018-01-15 Thread Juergen Gross
On 15/01/18 17:56, Gabriel C wrote: > On 15.01.2018 17:42, Juergen Gross wrote: >> On 15/01/18 17:29, Gabriel C wrote: >>> On 15.01.2018 16:40, Juergen Gross wrote: >>>> On 15/01/18 16:32, Ingo Molnar wrote: >>>>> >>> >>> Hi Juergen, &

[PATCH] x86/acpi: check rsdp address received via bootparams to be valid

2018-01-16 Thread Juergen Gross
There seem to exist several grub2 versions trashing boot_params.hdr.acpi_rsdp_addr. So don't just believe this address to be valid, but verify it pointing to a valid RSDP table. Signed-off-by: Juergen Gross --- To be applied on top of my RSDP series currently in tip.git x86/boot Mike Galb

Re: [PATCH] x86/acpi: check rsdp address received via bootparams to be valid

2018-01-16 Thread Juergen Gross
On 16/01/18 16:46, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> There seem to exist several grub2 versions trashing >> boot_params.hdr.acpi_rsdp_addr. >> >> So don't just believe this address to be valid, but verify it pointing >> to a valid RSD

Re: [PATCH] xen: xenbus: use put_device() instead of kfree()

2018-03-06 Thread Juergen Gross
On 06/03/18 11:10, Arvind Yadav wrote: > Never directly free @dev after calling device_register(), even > if it returned an error! Always use put_device() to give up the > reference initialized. > > Signed-off-by: Arvind Yadav Reviewed-by: Juergen Gross Juergen

Re: [RFC 0/2] To introduce xenwatch multithreading (xen mtwatch)

2018-04-07 Thread Juergen Gross
On 07/04/18 13:25, Dongli Zhang wrote: > This is to introduce "xenwatch multithreading" (or "multithreaded xenwatch", > abbreviated as 'mtwatch'). The implementation of xen mtwatch involves below > components: > > * dom0 linux kernel > * xen toolstack > > Here are what the RFC is going to discuss

Re: [PATCH] x86/xen: zero MSR_IA32_SPEC_CTRL before suspend

2018-04-11 Thread Juergen Gross
On 14/03/18 09:48, Jan Beulich wrote: On 26.02.18 at 15:08, wrote: >> @@ -35,6 +40,9 @@ void xen_arch_post_suspend(int cancelled) >> >> static void xen_vcpu_notify_restore(void *data) >> { >> +if (xen_pv_domain() && boot_cpu_has(X86_FEATURE_SPEC_CTRL)) >> +wrmsrl(MSR_IA32_

[GIT PULL] xen: fixes for 4.17-rc1

2018-04-12 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.17-rc1-tag xen: fixes for 4.17-rc1 It contains only a few fixes of Xen related core code and drivers. Thanks. Juergen arch/x86/xen/enlighten_pv.c | 8 arc

Re: [PATCH] x86/xen: Delay get_cpu_cap until stack canary is established

2018-03-19 Thread Juergen Gross
On 19/03/18 23:22, Boris Ostrovsky wrote: > On 03/19/2018 12:58 PM, Jason Andryuk wrote: >> Commit 2cc42bac1c79 ("x86-64/Xen: eliminate W+X mappings") introduced a >> call to get_cpu_cap, which is fstack-protected. This is works on x86-64 > > s/This is works/This works/ > > Reviewed-by: Boris Os

Re: [PATCH] xen/pvh: Indicate XENFEAT_linux_rsdp_unrestricted to Xen

2018-04-09 Thread Juergen Gross
r back-compatibility reasons we need to indicate to Xen that we can > handle this, an we do so by setting XENFEAT_linux_rsdp_unrestricted > flag in ELF notes. > > (Also take this opportunity and sync features.h header file with Xen) > > Signed-off-by: Boris Ostrovsky Reviewed-by: Juergen Gross Juergen

Re: [PATCH] xen: xenbus: use put_device() instead of kfree()

2018-03-08 Thread Juergen Gross
On 06/03/18 11:10, Arvind Yadav wrote: > Never directly free @dev after calling device_register(), even > if it returned an error! Always use put_device() to give up the > reference initialized. > > Signed-off-by: Arvind Yadav Committed to xen/tip.git for-linus-4.16a Juergen

[GIT PULL] xen: fix for V4.16-rc5

2018-03-09 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.16a-rc5-tag xen: fix for V4.16-rc5 It contains just one fix for the correct error handling after a negative rc from device_register(). Thanks. Juergen drivers/xen/xenbus/xenbus

[PATCH] xen/x86: add diagnostic printout to xen_mc_flush() in case of error

2018-11-23 Thread Juergen Gross
. without information which caller produced the failing element). Move the printing out of the switch statement in order to have the same information for a single call. Signed-off-by: Juergen Gross --- arch/x86/xen/multicalls.c | 35 --- 1 file changed, 20 insertions

Re: [PATCH] xen/x86: add diagnostic printout to xen_mc_flush() in case of error

2018-11-26 Thread Juergen Gross
On 26/11/2018 21:11, Boris Ostrovsky wrote: > On 11/23/18 11:24 AM, Juergen Gross wrote: >> Failure of an element of a Xen multicall is signalled via a WARN() >> only unless the kernel is compiled with MC_DEBUG. It is impossible to > > s/unless/if > > >> know wh

[PATCH 2/2] x86/acpi, x86/boot: Take RSDP address from boot params if available

2018-11-19 Thread Juergen Gross
In case the RSDP address in struct boot_params is specified don't try to find the table by searching, but take the address directly as set by the boot loader. Signed-off-by: Juergen Gross --- arch/x86/include/uapi/asm/bootparam.h | 3 ++- arch/x86/kernel/acpi/boot.c | 2 +- 2

Re: [PATCH] pvcalls-front: fixes incorrect error handling

2018-11-29 Thread Juergen Gross
On 22/11/2018 03:07, Pan Bian wrote: > kfree() is incorrectly used to release the pages allocated by > __get_free_page() and __get_free_pages(). Use the matching deallocators > i.e., free_page() and free_pages(), respectively. > > Signed-off-by: Pan Bian Pushed to xen/tip.git for-linus-4.20a J

Re: [PATCH] Revert "xen/balloon: Mark unallocated host memory as UNUSABLE"

2018-11-29 Thread Juergen Gross
On 27/11/2018 21:58, Igor Druzhinin wrote: > This reverts commit b3cf8528bb21febb650a7ecbf080d0647be40b9f. > > That commit unintentionally broke Xen balloon memory hotplug with > "hotplug_unpopulated" set to 1. As long as "System RAM" resource > got assigned under a new "Unusable memory" resource

Re: [PATCH] pvcalls-front: Use GFP_ATOMIC under spin_lock

2018-11-29 Thread Juergen Gross
On 29/11/2018 13:01, Wen Yang wrote: > The problem is that we call this with a spin lock held. > The call tree is: > pvcalls_front_accept() holds bedata->socket_lock. > -> create_active() > -> __get_free_pages() uses GFP_KERNEL > > The create_active() function is only called from pvcal

Re: arch/x86/include/asm/cmpxchg.h:245:2: error: 'asm' operand has impossible constraints

2018-11-29 Thread Juergen Gross
On 30/11/2018 07:44, kbuild test robot wrote: > Hi Juergen, > > FYI, the error/warning still remains. This problem is one of gcc. It is in no way the (direct) result of my patch. Please see my gcc bug report: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=908154 Juergen > > tree: https:

Re: [PATCH 1/2] x86/mm: Fix guard hole handling

2018-11-30 Thread Juergen Gross
On 30/11/2018 12:57, Kirill A. Shutemov wrote: > There is a guard hole at the beginning of kernel address space, also > used by hypervisors. It occupies 16 PGD entries. > > We do not state the reserved range directly, but calculate it relative > to other entities: direct mapping and user space ran

Re: [PATCH 1/2] x86/mm: Fix guard hole handling

2018-11-30 Thread Juergen Gross
On 30/11/2018 13:11, Kirill A. Shutemov wrote: > On Fri, Nov 30, 2018 at 12:03:33PM +0000, Juergen Gross wrote: >> On 30/11/2018 12:57, Kirill A. Shutemov wrote: >>> There is a guard hole at the beginning of kernel address space, also >>> used by hypervisors. It occupies

Re: [PATCH v1 4/8] xen/balloon: mark inflated pages PG_offline

2018-11-19 Thread Juergen Gross
On 19/11/2018 11:16, David Hildenbrand wrote: > Mark inflated and never onlined pages PG_offline, to tell the world that > the content is stale and should not be dumped. > > Cc: Boris Ostrovsky > Cc: Juergen Gross > Cc: Stefano Stabellini > Cc: Andrew Morton > Cc: Matt

[PATCH] x86/xen: cleanup includes in arch/x86/xen/spinlock.c

2018-11-19 Thread Juergen Gross
arch/x86/xen/spinlock.c includes several headers which are not needed. Remove the #includes. Signed-off-by: Juergen Gross --- arch/x86/xen/spinlock.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/x86/xen/spinlock.c b/arch/x86/xen/spinlock.c index 1c8a8816a402

Re: [PATCH v8 1/7] xen/pvh: Split CONFIG_XEN_PVH into CONFIG_PVH and CONFIG_XEN_PVH

2018-12-06 Thread Juergen Gross
On 06/12/2018 23:11, Paolo Bonzini wrote: > On 06/12/18 07:04, Maran Wilson wrote: >> +config PVH >> +bool "Support for running PVH guests" >> +---help--- >> + This option enables the PVH entry point for guest virtual machines >> + as specified in the x86/HVM direct boot ABI. >> +

Re: [PATCH v8 1/7] xen/pvh: Split CONFIG_XEN_PVH into CONFIG_PVH and CONFIG_XEN_PVH

2018-12-07 Thread Juergen Gross
On 07/12/2018 14:41, Paolo Bonzini wrote: > On 07/12/18 07:02, Juergen Gross wrote: >> On 06/12/2018 23:11, Paolo Bonzini wrote: >>> On 06/12/18 07:04, Maran Wilson wrote: >>>> +config PVH >>>> + bool "Support for running PVH guests" >>&g

Re: [PATCH v8 1/7] xen/pvh: Split CONFIG_XEN_PVH into CONFIG_PVH and CONFIG_XEN_PVH

2018-12-07 Thread Juergen Gross
On 07/12/2018 14:52, Paolo Bonzini wrote: > On 07/12/18 14:50, Juergen Gross wrote: >> The PVH boot entry is in the same bzImage binary as the normal one. >> Its just another entry, similar to the Xen PV boot entry. So the binary >> arch/x86/boot/bzimage can be booted eit

[PATCH] x86/boot: clear rsdp address in boot_params for broken loaders

2018-12-03 Thread Juergen Gross
af75 ("x86/acpi, x86/boot: Take RSDP address from boot params if available") Reported-by: Gunnar Krueger Tested-by: Gunnar Krueger Signed-off-by: Juergen Gross --- arch/x86/include/asm/bootparam_utils.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/include/asm/bootparam_ut

<    1   2   3   4   5   6   7   8   9   10   >