Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent

2008-02-11 Thread John David Anglin
> James Bottomley wrote: > > On Mon, 2008-02-11 at 17:23 +0100, Roel Kluin wrote: > >> duplicate pa11_dma_alloc_consistent; more appropriate appears > >> pa11_dma_alloc_noncoherent here. > >> > >> Not tested, please confirm that this fix is correct > > > > No, it looks completely incorrect to me.

Re: parisc: orphaned asm/compat_signal.h file?

2012-09-25 Thread John David Anglin
On 24-Sep-12, at 8:39 AM, Denys Vlasenko wrote: Maybe it needs to be removed? Worked for me with 3.5.4. Dave -- John David Anglin dave.ang...@bell.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.

Re: [PATCH] [workqueue] check values of pwq and wq in print_worker_info() before use

2013-10-01 Thread John David Anglin
)) + return; fault_address = regs->ior; fault_space = regs->isr; break; -- To unsubscribe from this list: send the line "unsubscribe linux- parisc" in the body of a message to majord...@vger.kernel.org More majordom

Re: [PATCH] [workqueue] check values of pwq and wq in print_worker_info() before use

2013-10-01 Thread John David Anglin
if (!user_mode(regs) && fixup_exception(regs)) + return; fault_address = regs->ior; fault_space = regs->isr; break; With this change, boot on rp3440 hangs here: Freeing unused kernel memory: 256K (0000

Re: [PATCH] parisc: Export flush_cache_page() (needed by lustre)

2013-09-05 Thread John David Anglin
nclude/asm/cacheflush.h. There are a bunch of callers in mm. The interface in documented in Documentation/cachetlb.txt. We currently use it in copy_to_user_page and copy_from_user_page. Dave -- John David Anglindave.ang...@bell.net -- To unsubscribe from this list: send the line "un

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-06 Thread John David Anglin
e's something else we could do (all we really need is a way to ensure we can insert ELF stubs every 128k). There is now a config work around for this. See: http://www.spinics.net/lists/linux-parisc/msg04521.html Dave -- John David Anglin dave.ang...@bell.net -- To unsubscribe from

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-06 Thread John David Anglin
On 6-Apr-13, at 9:22 PM, James Bottomley wrote: John David Anglin wrote: On 6-Apr-13, at 6:52 AM, James Bottomley wrote: On Sat, 2013-04-06 at 15:22 +1030, Rusty Russell wrote: The problem is our assumption that section names be unique. This assumption is wrong. The ELF spec says

Re: [PATCH 08/10] parisc: Add missing RCU idle APIs on idle loop

2012-08-24 Thread John David Anglin
_idle_exit(); schedule_preempt_disabled(); check_pgt_cache(); } Builds and boots fine on parisc. Acked-by: John David Anglin Dave -- John David Anglindave.ang...@bell.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&qu

Re: Linux 3.4-rc7

2012-08-07 Thread John David Anglin
On 8/7/2012 2:41 PM, Mikulas Patocka wrote: Which restart patch do you mean? http://www.spinics.net/lists/linux-parisc/msg04229.html Dave -- John David Anglindave.ang...@bell.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [next:akpm 129/309] net/core/sock.c:274:36: error: initializer element is not constant

2012-08-12 Thread John David Anglin
currently collecting Alpha patches to send on to Linus so will include this one. A similar change applied to 3.5.1 stable compiles successfully on parisc. Regards, Dave -- John David Anglin dave.ang...@bell.net diff --git a/arch/parisc/include/asm/atomic.h b/arch/parisc/include/asm/atom

Re: [next:akpm 129/309] net/core/sock.c:274:36: error: initializer element is not constant

2012-07-23 Thread John David Anglin
bscribe linux- parisc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- John David Anglin dave.ang...@bell.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [next:akpm 129/309] net/core/sock.c:274:36: error: initializer element is not constant

2012-07-24 Thread John David Anglin
s in a constant expression. Test case: typedef struct { long enabled; } atomic_t; struct static_key { atomic_t enabled; int x; }; struct static_key memalloc_socks = ((struct static_key) { .enabled = ((atomic_t) { (0) }) }); Dave -- John David Anglin dave.ang...@bell.net -- To unsubs

Re: parisc: orphaned asm/compat_signal.h file?

2012-09-29 Thread John David Anglin
On 28-Sep-12, at 9:43 AM, James Bottomley wrote: On Tue, 2012-09-25 at 19:23 -0400, John David Anglin wrote: On 24-Sep-12, at 8:39 AM, Denys Vlasenko wrote: Maybe it needs to be removed? Worked for me with 3.5.4. It's probably time to tidy up all of our asm-generic code and us

Re: [parisc-linux] [RFC][PATCH] use cycle_t instead of u64 in struct

2007-01-02 Thread John David Anglin
> The 32bit and 64bit PARISC Linux kernels suffers from the problem, that the > gettimeofday() call sometimes returns non-monotonic times. This certainly needs to be fixed. I see stuff like this from ping: 64 bytes from 132.246.100.193: icmp_seq=19 ttl=255 time=0.4 ms 64 bytes from 132.246.100.

Re: [parisc-linux] Re: [2.6 patch] parisc: "extern inline" -> "static

2006-12-01 Thread John David Anglin
> The parisc point intentionally switched to "extern inline" at one > point and unless what jda wrote is now incorrect, I'm not inclined > to change it. The handling of "extern inline" is changing in GCC 4.3 to the C99 specified behavior. The attribute gnu_inline on an inline declaration results

Re: [PATCH] parisc: prefer _THIS_IP_ and _RET_IP_ statement expressions

2018-08-03 Thread John David Anglin
current_text_addr() to the parisc unwind code doesn't help. Personally, I prefer the implementation of current_text_addr() because: 1) The generated code is smaller, and 2) it doesn't introduce any unnecessary labels into the text. As noted, these labels can cause issues with unw

Re: [PATCH] parisc: prefer _THIS_IP_ and _RET_IP_ statement expressions

2018-08-03 Thread John David Anglin
ized there was another source of text labels that need linker relocations. Dave -- John David Anglin dave.ang...@bell.net

Re: [PATCH] parisc: prefer _THIS_IP_ and _RET_IP_ statement expressions

2018-08-01 Thread John David Anglin
; - r.gr[2] = (unsigned long) __builtin_return_address(0); + r.iaoq[0] = _THIS_IP_; + r.gr[2] = _RET_IP_; r.gr[30] = sp; unwind_frame_init(&info, current, &r); Dave -- John David Anglin dave.ang...@bell.net

Re: [PATCH] parisc: prefer _THIS_IP_ and _RET_IP_ statement expressions

2018-08-01 Thread John David Anglin
On 2018-08-01 4:52 PM, Nick Desaulniers wrote: Dave, thanks for the quick review! On Wed, Aug 1, 2018 at 1:10 PM John David Anglin wrote: On 2018-08-01 2:22 PM, Nick Desaulniers wrote: As part of the effort to reduce the code duplication between _THIS_IP_ and current_text_addr(), let&#

Re: [PATCH] parisc: prefer _THIS_IP_ and _RET_IP_ statement expressions

2018-08-01 Thread John David Anglin
fs support, etc? Dave -- John David Anglin dave.ang...@bell.net

Re: [PATCH] parisc: prefer _THIS_IP_ and _RET_IP_ statement expressions

2018-08-01 Thread John David Anglin
On 2018-08-01 6:18 PM, Nick Desaulniers wrote: What about the uses in the fs support, etc? Sorry, I don't see it? I mean _THIS_IP_. Dave -- John David Anglin dave.ang...@bell.net

Re: [PATCH] parisc: Remove PTE load and fault check from L2_ptep macro

2018-09-26 Thread John David Anglin
Hi, On 2018-09-25 11:21 PM, Guenter Roeck wrote: This patch causes my parisc qemu tests to fail. Unfortunately I don't have any useful log output; the failure is silent. Reverting the patch fixes the problem. Can you be more specific on how to run these tests? Dave -- John David A

Re: Build regressions/improvements in v4.18-rc3

2018-07-03 Thread John David Anglin
On 2018-07-02 9:09 PM, Michael Ellerman wrote: It's GCC 4.6.3. Are you saying that's not supported anymore? See <https://gcc.gnu.org/> for supported releases. Dave -- John David Anglin dave.ang...@bell.net

Re: [PATCH] arch: uapi: asm: mman.h: Let MADV_FREE have same value for all architectures

2014-12-07 Thread John David Anglin
/index.php/Technical_Documentation Dave -- John David Anglin dave.ang...@bell.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html P

Re: 4.0 parisc regression: memory leak?

2015-04-25 Thread John David Anglin
; (and first revdep-rebuild after nontrivial emerge compilation loop kills > the smaller box). I've also had problems with 4.0. I had HPMC after a few hours on rp3440. > > 3.19 did not seem to have this problem. -- John David Anglin dave.ang...@bell.net -- To unsubscribe f

Re: hppa64-linux-ld: kernel/rcu/refscale.o(.init.text+0x228): cannot reach schedule_timeout_uninterruptible

2021-03-02 Thread John David Anglin
on error.  We need long branch stub support in 64-bit linker. Dave -- John David Anglin dave.ang...@bell.net

Re: hppa64-linux-ld: mm/hugetlb.o(.text+0x50dc): cannot reach printk

2021-01-26 Thread John David Anglin
ot reach snprintf >>hppa64-linux-ld: mm/hugetlb.o(.init.text+0x728): cannot reach printk >>hppa64-linux-ld: mm/hugetlb.o(.init.text+0x744): cannot reach printk >>hppa64-linux-ld: mm/hugetlb.o(.init.text+0x8d4): cannot reach >> _raw_spin_lock >>hppa64-linux-ld: mm/hugetlb.o(.init.text+0x900): cannot reach >> _raw_spin_unlock >>hppa64-linux-ld: mm/hugetlb.o(.init.text+0xa40): cannot reach printk >>hppa64-linux-ld: mm/hugetlb.o(.init.text+0xa70): cannot reach >> kobject_create_and_add >>hppa64-linux-ld: mm/hugetlb.o(.init.text+0xb64): cannot reach >> kobject_create_and_add >>hppa64-linux-ld: mm/hugetlb.o(.init.text+0xb9c): cannot reach kobject_put >>hppa64-linux-ld: mm/hugetlb.o(.init.text+0xbb4): cannot reach printk >>hppa64-linux-ld: mm/hugetlb.o(.init.text+0xc84): cannot reach __muldi3 >>hppa64-linux-ld: mm/hugetlb.o(.init.text+0xde8): cannot reach memparse >>hppa64-linux-ld: mm/hugetlb.o(.init.text+0xec0): cannot reach printk >>hppa64-linux-ld: mm/hugetlb.o(.init.text+0xef0): cannot reach unknown >>hppa64-linux-ld: mm/hugetlb.o(.init.text+0xf94): cannot reach memparse >>hppa64-linux-ld: mm/hugetlb.o(.init.text+0xfcc): cannot reach printk >>hppa64-linux-ld: mm/hugetlb.o(.init.text+0xfe4): cannot reach unknown >>hppa64-linux-ld: mm/slab.o(.text+0x490): cannot reach __udivdi3 >>hppa64-linux-ld: mm/slab.o(.text+0x4ac): cannot reach __umoddi3 >> >> --- >> 0-DAY CI Kernel Test Service, Intel Corporation >> https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org > > -- John David Anglin dave.ang...@bell.net

Re: hppa64-linux-ld: mm/hugetlb.o(.text+0x50dc): cannot reach printk

2021-01-25 Thread John David Anglin
default n >> +def_bool y if !MODULES || UBSAN || FTRACE >> +bool "Enable the -mlong-calls compiler option for big kernels" if >> MODULES && !UBSAN && !FTRACE >> depends on PA8X00 >> help >>If you configure the kernel to include many drivers built-in instead >> diff --git a/arch/parisc/kernel/entry.S b/arch/parisc/kernel/entry.S >> index beba9816cc6c..6320f6a8397c 100644 >> --- a/arch/parisc/kernel/entry.S >> +++ b/arch/parisc/kernel/entry.S >> @@ -997,10 +997,19 @@ intr_do_preempt: >> bb,<,n %r20, 31 - PSW_SM_I, intr_restore >> nop >> >> -BL preempt_schedule_irq, %r2 >> -nop >> +/* ssm PSW_SM_I done later in intr_restore */ >> +#ifdef CONFIG_MLONGCALLS >> +ldilL%intr_restore, %r2 >> +load32 preempt_schedule_irq, %r1 >> +bv %r0(%r1) >> +ldo R%intr_restore(%r2), %r2 >> +#else >> +ldilL%intr_restore, %r2 >> +BL preempt_schedule_irq >> +ldo R%intr_restore(%r2), %r2 >> +#endif >> + >> >> -b,n intr_restore/* ssm PSW_SM_I done by intr_restore */ >> #endif /* CONFIG_PREEMPTION */ >> >> /* >> >> -- John David Anglin dave.ang...@bell.net

Re: hppa64-linux-ld: mm/hugetlb.o(.text+0x50dc): cannot reach printk

2021-01-25 Thread John David Anglin
On 2021-01-25 4:13 p.m., Helge Deller wrote: > On 1/25/21 10:08 PM, John David Anglin wrote: >> I would suggest the following for this hunk: >> >> +    ldil    L%intr_restore, %r2 >> +    BL    preempt_schedule_irq >> +    ldo R%intr_restore(%r2), %r2 >

Re: FIX MES in init.c

2014-09-23 Thread John David Anglin
;fix". Why not just remove "FIXME: " from these comments? Dave -- John David Anglindave.ang...@bell.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.k

Re: [PATCH] parisc:Remove unnecessary FIXMES in init.c

2014-09-24 Thread John David Anglin
e later on. There is nothing you could try to "fix". Why not just remove "FIXME: " from these comments? The wording of the comment is not good. You can't "trick" the compiler into not treating a constant as DP-relative data. Whether or not a constant is loade

Re: [PATCH] parisc,metag: Do not hardcode maximum userspace stack size

2014-04-30 Thread John David Anglin
On 30-Apr-14, at 5:26 PM, Helge Deller wrote: + processes when the stack grows upwards (currently only on parisc and matag "metag" is mispelled. Dave -- John David Anglin dave.ang...@bell.net -- To unsubscribe from this list: send the line "unsubscribe linux-kern

Re: [PATCH] parisc,metag: Do not hardcode maximum userspace stack size

2014-05-01 Thread John David Anglin
ux-me...@vger.kernel.org Cc: John David Anglin I tested this version of the patch last night on 3.14.2. I can confirm that an 80MB region is reserved for stack at the expected location in virtual memory with the default config setting. GCC and many other packages have built successfully with this se

Re: [PATCH] fix fanotify_mark() breakage on big endian 32bit kernel

2014-07-06 Thread John David Anglin
gnificant bits are in r25 and the least significant bits in r26.. In GCC, we typically have an odd even register pair to hold 64-bit values as register r0 is not usable. The rules are different for float values. Dave -- John David Anglin dave.ang...@bell.net -- To unsubscribe from

Re: [PATCH] fix a race condition in cancelable mcs spinlocks

2014-06-01 Thread John David Anglin
recently that the lock must be released with a cmpxchg operation and not a simple write on SMP systems. There is a race in the cache operations or instruction ordering that's not present with the ldcw instruction. Dave -- John David Anglin dave.ang...@bell.net -- To unsubscribe

Re: [PATCH] fix a race condition in cancelable mcs spinlocks

2014-06-02 Thread John David Anglin
On 6/2/2014 10:02 AM, Mikulas Patocka wrote: On Mon, 2 Jun 2014, Mikulas Patocka wrote: On Sun, 1 Jun 2014, John David Anglin wrote: On 1-Jun-14, at 3:20 PM, Peter Zijlstra wrote: If you write to some variable with ACCESS_ONCE and use cmpxchg or xchg at the same time, you break it

Re: [PATCH] aio: fix D-cache aliasing issues

2013-11-16 Thread John David Anglin
's as we do in in flush_dcache_page(). Dave -- John David Anglin dave.ang...@bell.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] aio: fix D-cache aliasing issues

2013-11-16 Thread John David Anglin
On 16-Nov-13, at 5:37 PM, James Bottomley wrote: On Sat, 2013-11-16 at 17:32 -0500, John David Anglin wrote: On 16-Nov-13, at 5:06 PM, James Bottomley wrote: On Sat, 2013-11-16 at 21:07 +0100, Simon Baatz wrote: On Fri, Nov 15, 2013 at 02:42:05PM -0800, James Bottomley wrote: On Fri, 2013

Re: [PATCH] aio: fix D-cache aliasing issues

2013-11-17 Thread John David Anglin
copy_user_page() aren't needed. Dave -- John David Anglin dave.ang...@bell.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Plea

Re: [PATCH] aio: fix D-cache aliasing issues

2013-11-17 Thread John David Anglin
be deferred. I don't think we want that. 2) It seems to unnecessarily call flush_kernel_dcache_page(). Dave -- John David Anglin dave.ang...@bell.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...

Re: [PATCH] fix crash when using XFS on loopback

2014-01-04 Thread John David Anglin
ation of flush_dcache_page() should return if "!mapping || mapping != page->mapping" is true. This would have avoided crash. Dave -- John David Anglin dave.ang...@bell.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH] fix crash when using XFS on loopback

2014-01-04 Thread John David Anglin
On 4-Jan-14, at 2:55 PM, Mikulas Patocka wrote: On Sat, 4 Jan 2014, John David Anglin wrote: On 4-Jan-14, at 12:45 PM, Mikulas Patocka wrote: * flush_dcache_page asks for the list of userspace mappings, however that page->mapping field is reused by the slab subsystem for a differ

Re: [GIT PULL] parisc huge page support for v4.4

2016-01-04 Thread John David Anglin
gh that this can't happen? No. If you look at the TLB handler, you will see that locking is not done for misses in kernel space. So, this deadlock doesn't occur. Dave -- John David Anglin dave.ang...@bell.net -- To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH 14/22] parisc: %pF is only for function pointers

2015-03-12 Thread John David Anglin
x27;t have a working change. Dave -- John David Anglin dave.ang...@bell.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [GIT PULL] parisc architecture updates for v4.3

2015-11-03 Thread John David Anglin
calls. This whole discussion started when I suggested that we needed to bump L1_CACHE_BYTES to 128 bytes on PA8800 and PA8900 processors. -- John David Anglin dave.ang...@bell.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messa

Re: [GIT PULL] parisc architecture updates for v4.3

2015-11-03 Thread John David Anglin
t; but if it is actually real... See page 10 in this document: https://parisc.wiki.kernel.org/images-parisc/e/e9/PA-8700wp.pdf It shows the PA-8700 L1 design. James' comments and this paper are the basis for this change. Dave -- John David Anglin dave.ang...@bell.net -- To

Re: C3600, sata controller

2019-05-12 Thread John David Anglin
aring: done > Testing with pattern 0x55: done > Reading and comparing: done > Testing with pattern 0xff: done > Reading and comparing: done > Testing with pattern 0x00: done > Reading and comparing: done > Pass completed, 0 bad blocks found. > > no problems found > -- John David Anglin dave.ang...@bell.net

Re: C3600, sata controller

2019-05-13 Thread John David Anglin
SD-SATA150R in c3600.  However, it is similar to the Adaptec 1210SA which works.  Maybe they differ in RAID capability. Dave -- John David Anglin dave.ang...@bell.net

Re: [PATCH 1/2] parisc: use the asm-generic version for writeX()

2018-04-16 Thread John David Anglin
or=implicit-function-declaration]    return readl(gc->reg_base + reg_offset);   ^ cc1: some warnings being treated as errors make[1]: *** [Kbuild:58: arch/parisc/kernel/asm-offsets.s] Error 1 Dave -- John David Anglin dave.ang...@bell.net

Re: [PATCH 1/2] parisc: use the asm-generic version for writeX()

2018-04-16 Thread John David Anglin
either 32 or 64 bit mode */ #define F_EXTEND(x) ((unsigned long)((x) | (0xULL))) +#include #include Still lots of problems. Dave -- John David Anglin dave.ang...@bell.net CC arch/parisc/kernel/asm-offsets.s In file included from ./arch/parisc/include/asm/io.h:262:0

Re: [PATCH v2 2/2] parisc: define stronger ordering for the default readX()

2018-04-17 Thread John David Anglin
. The sequence point after the argument evaluation for writel prevents the compiler from reordering 1 and 2.  Accesses to I/O space are strongly ordered on PA-RISC, so 1 must occur before 2 (Page G-1 of the PA-RISC 2.0 Architecture).  Thus, the current code is okay. Dave -- John David Anglin dav

Re: parisc crash on boot with 4.8+git

2016-10-09 Thread John David Anglin
bit Kernel has started... >>> Kernel default page size is 4 KB. Huge pages enabled with 1 MB physical and >>> 2 MB virtual size. The first thing I would suspect is the enabling of huge pages. Dave -- John David Anglin dave.ang...@bell.net

Re: [PATCH] parisc: mm: Fix a memory leak related to pmd not attached to the pgd

2015-07-14 Thread John David Anglin
rwarded Message > Subject: Re: [PATCH] parisc: mm: Fix a memory leak related to pmd not > attached to the pgd > Date: Mon, 13 Jul 2015 20:52:37 +0200 > From: Helge Deller > To: Christophe JAILLET , > j...@parisc-linux.org, mpato...@redhat.com, kirill.shute...@linu

Re: [PATCH] parisc: mm: Fix a memory leak related to pmd not attached to the pgd

2015-07-14 Thread John David Anglin
Faulting instruction is: 4021a11c: 0f 38 12 d0 std r24,8(r25) Register r25 is misaligned by 1. Dave On 2015-07-14, at 7:52 AM, John David Anglin wrote: > Sadly, it appears we are not out of the woods yet: > > mx3210 login: Backtrace: > [<4021c904>] free_h

Re: parisc:generic-64bit_defconfig build failures due to 'kbuild: handle libs-y archives separately...'

2017-07-18 Thread John David Anglin
On 2017-07-18, at 11:21 AM, Guenter Roeck wrote: > Hi, > > parisc64 builds, specifically generic-64bit_defconfig, fail to build > in mainline as follows. It's likely this patch fixes the problem: https://patchwork.kernel.org/patch/9832033/ Dave -- John David Anglin dave.ang...@bell.net

Re: Build regressions/improvements in v4.12-rc2

2017-05-22 Thread John David Anglin
profiling by default? Dave -- John David Anglin dave.ang...@bell.net