[Trivial PATCH 09/33] cdrom: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- drivers/cdrom/cdrom.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index 8a3aff7..d49a76f 100644 --- a/drivers/cdrom/cdrom.c

[Trivial PATCH 08/33] x86: vdso: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- arch/x86/vdso/vdso32-setup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/vdso/vdso32-setup.c b/arch/x86/vdso/vdso32-setup.c index 0faad64..d6bfb87 100644 --- a/arch/x86

[Trivial PATCH 10/33] char: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- drivers/char/hpet.c | 6 +++--- drivers/char/ipmi/ipmi_poweroff.c | 6 +++--- drivers/char/random.c | 8 drivers/char/rtc.c| 6 +++--- 4 files changed, 13

[Trivial PATCH 11/33] infiniband: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- drivers/infiniband/core/ucma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c index 5ca44cd..9416280 100644 --- a/drivers

[Trivial PATCH 06/33] s390: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- arch/s390/appldata/appldata_base.c | 16 arch/s390/kernel/debug.c | 4 ++-- arch/s390/mm/cmm.c | 6 -- 3 files changed, 14 insertions(+), 12 deletions(-) diff

[Trivial PATCH 07/33] tile: proc: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- arch/tile/kernel/proc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/tile/kernel/proc.c b/arch/tile/kernel/proc.c index dafc447..6570813 100644 --- a/arch/tile/kernel/proc.c

[Trivial PATCH 16/33] scsi_sysctl: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- drivers/scsi/scsi_sysctl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/scsi_sysctl.c b/drivers/scsi/scsi_sysctl.c index 2b6b93f..546f162 100644 --- a/drivers/scsi

[Trivial PATCH 20/33] nfs: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- fs/nfs/nfs4sysctl.c | 6 +++--- fs/nfs/sysctl.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/nfs/nfs4sysctl.c b/fs/nfs/nfs4sysctl.c index 2628d92..b6ebe7e 100644 --- a/fs

[Trivial PATCH 19/33] lockd: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- fs/lockd/svc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c index a2aa97d..7df25d7 100644 --- a/fs/lockd/svc.c +++ b/fs/lockd/svc.c @@ -435,7

[Trivial PATCH 12/33] macintosh: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- drivers/macintosh/mac_hid.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/macintosh/mac_hid.c b/drivers/macintosh/mac_hid.c index 6a82388..80d30e8 100644 --- a/drivers

[Trivial PATCH 13/33] md: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- drivers/md/md.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index 9b82377..f7edaf9 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -112,7

[Trivial PATCH 14/33] sgi: xpc: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- drivers/misc/sgi-xp/xpc_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/misc/sgi-xp/xpc_main.c b/drivers/misc/sgi-xp/xpc_main.c index d971817..82dc574 100644 --- a

[Trivial PATCH 18/33] fscache: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- fs/fscache/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/fscache/main.c b/fs/fscache/main.c index 7c27907..5b2c174 100644 --- a/fs/fscache/main.c +++ b/fs/fscache/main.c

[Trivial PATCH 15/33] parport: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- drivers/parport/procfs.c | 58 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/drivers/parport/procfs.c b/drivers/parport/procfs.c index

[Trivial PATCH 21/33] inotify: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- fs/notify/inotify/inotify_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c index 959815c..3e03d81 100644 --- a/fs

[Trivial PATCH 23/33] ocfs2: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- fs/ocfs2/stackglue.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c index 39abf89..cb7ec0b 100644 --- a/fs/ocfs2/stackglue.c +++ b/fs

[Trivial PATCH 33/33] security: keys: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- security/keys/sysctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/keys/sysctl.c b/security/keys/sysctl.c index ee32d18..9a9df6f 100644 --- a/security/keys/sysctl.c +++ b

[Trivial PATCH 32/33] mm: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- mm/page-writeback.c | 2 +- mm/page_alloc.c | 15 --- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 4514ad7..82d1b74 100644

[Trivial PATCH 26/33] fs: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- fs/dcache.c | 2 +- fs/drop_caches.c | 2 +- fs/eventpoll.c | 2 +- fs/file_table.c | 4 ++-- fs/inode.c | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/dcache.c b/fs

[Trivial PATCH 25/33] xfs: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- fs/xfs/xfs_sysctl.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/fs/xfs/xfs_sysctl.c b/fs/xfs/xfs_sysctl.c index 2801b5c..1743b9f 100644 --- a/fs/xfs

[Trivial PATCH 28/33] ipv6: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- include/net/ipv6.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/net/ipv6.h b/include/net/ipv6.h index ab47582..5fe5649 100644 --- a/include/net/ipv6.h +++ b/include/net/ipv6

[Trivial PATCH 27/33] key: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- include/linux/key.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/key.h b/include/linux/key.h index 4dfde11..3b98ce0 100644 --- a/include/linux/key.h +++ b/include/linux

[Trivial PATCH 31/33] sysctl: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- kernel/sysctl.c | 2 +- kernel/utsname_sysctl.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/sysctl.c b/kernel/sysctl.c index fb90f7c..aa357a2 100644 --- a/kernel

[Trivial PATCH 29/33] ndisc: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- include/net/ndisc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/ndisc.h b/include/net/ndisc.h index 745bf74..949d775 100644 --- a/include/net/ndisc.h +++ b/include/net

[Trivial PATCH 24/33] quota: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- fs/quota/dquot.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c index b3d1ac9..017eaea 100644 --- a/fs/quota/dquot.c +++ b/fs/quota/dquot.c

[Trivial PATCH 30/33] ipc: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- ipc/ipc_sysctl.c | 14 +++--- ipc/mq_sysctl.c | 10 +- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/ipc/ipc_sysctl.c b/ipc/ipc_sysctl.c index 130dfec..27fab60 100644 --- a

[Trivial PATCH 22/33] ntfs: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- fs/ntfs/sysctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ntfs/sysctl.c b/fs/ntfs/sysctl.c index 79a8918..a3e6626 100644 --- a/fs/ntfs/sysctl.c +++ b/fs/ntfs/sysctl.c

[Trivial PATCH 17/33] coda: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- fs/coda/sysctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/coda/sysctl.c b/fs/coda/sysctl.c index af56ad5..34218a8 100644 --- a/fs/coda/sysctl.c +++ b/fs/coda/sysctl.c

Re: [Trivial PATCH 25/33] xfs: Convert use of typedef ctl_table to struct ctl_table

On Fri, 2013-06-14 at 15:21 +1000, Dave Chinner wrote: > On Thu, Jun 13, 2013 at 07:37:50PM -0700, Joe Perches wrote: > > This typedef is unnecessary and should just be removed. > > > > Signed-off-by: Joe Perches > > Looks fine, Joe. > > Acked-by: Dave Ch

Re: [PATCH] power: Include additional information in pm_print_times

On Fri, 2013-06-14 at 10:33 -0600, Shuah Khan wrote: > Change __device_suspend() path to include driver name and the ops that > get run for a device. [] > diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c [] > -static ktime_t initcall_debug_start(struct device *dev) > +static ktime

Re: [PATCH v2] power: Include additional information in pm_print_times

On Fri, 2013-06-14 at 14:35 -0600, Shuah Khan wrote: > Change __device_suspend() path to include driver name and the ops that > get run for a device. This additional information helps associate the > driver and the type of pm_ops the device uses in the suspend path very > quickly which will aid in

Re: [PATCH v4] ethernet/arc/arc_emac - Add new driver

On Sun, 2013-06-16 at 00:20 +0400, Alexey Brodkin wrote: > Driver for non-standard on-chip ethernet device ARC EMAC 10/100, > instantiated in some legacy ARC (Synopsys) FPGA Boards such as > ARCAngel4/ML50x. > diff --git a/drivers/net/ethernet/arc/emac_main.c > b/drivers/net/ethernet/arc/emac_mai

Re: [PATCH v4] ethernet/arc/arc_emac - Add new driver

On Sat, 2013-06-15 at 20:47 +, Alexey Brodkin wrote: > On 06/16/2013 12:37 AM, Joe Perches wrote: > > On Sun, 2013-06-16 at 00:20 +0400, Alexey Brodkin wrote: [] > >> +static int arc_emac_rx(struct net_device *ndev, int budget) > > [] > >> +

Re: [PATCH 4/4] solicom: checkpatch: added parenthesis to macros

On Mon, 2013-06-17 at 18:26 +0200, Lorenz Haspel wrote: > fixed checkpatch error: > added parenthesis around complex macros. [] > diff --git a/drivers/staging/silicom/bpctl_mod.c > b/drivers/staging/silicom/bpctl_mod.c [] > @@ -44,9 +44,11 @@ MODULE_VERSION(BP_MOD_VER); > spinlock_t bpvm_lock; >

Re: [PATCH 1/4] silicom: checkpatch: assignments in if conditions

On Mon, 2013-06-17 at 20:22 +0300, Dan Carpenter wrote: > This will need to be redone because there were some buggy extra > lines added toward the end of the patch. [] > > @@ -4867,10 +4884,12 @@ int set_tx_fn(bpctl_dev_t *pbpctl_dev, int tx_state) > > (pbpctl_dev->bp_caps & SW_CTL_CAP))

[PATCH] jfs: Convert jfs_error to jfs_sb_err

-by: Joe Perches --- fs/jfs/jfs_dmap.c | 94 - fs/jfs/jfs_dtree.c | 45 --- fs/jfs/jfs_extent.c | 2 +- fs/jfs/jfs_imap.c | 89 +- fs/jfs/jfs_metapage.c | 9

[PATCH 4/4] cw1200: hwio: Remove an unnecessary goto

goto after return is wrong. The other code in this block needs to set an error value then goto an error release block. This one doesn't need to release anything and was likely a copy/paste remainder. Signed-off-by: Joe Perches --- drivers/net/wireless/cw1200/hwio.c | 1 - 1 file chang

[PATCH 1/4] swim: Release memory region after incorrect return/goto

The code uses return foo; goto err_type; when instead the form should have been ret = foo; goto err_type; Here this causes a useful release_mem_region to be skipped. Signed-off-by: Joe Perches --- drivers/block/swim.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 3/4] mtd: onenand: samsung: Release memory after incorrect return/goto

The code uses return foo; goto err_type; when instead the form should have been ret = foo; goto err_type; Here this causes a useful kfree to be skipped. Signed-off-by: Joe Perches --- drivers/mtd/onenand/samsung.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH 2/4] inkern: iio_device_put after incorrect return/goto

The code uses return foo; goto err_type; when instead the form should have been ret = foo; goto err_type; Here this causes a useful iio_device_put to be skipped. Signed-off-by: Joe Perches --- drivers/iio/inkern.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH] jfs: Convert jfs_error to jfs_sb_err

On Tue, 2013-06-04 at 11:00 -0500, Dave Kleikamp wrote: > I generally like this cleanup except for one thing. > > On 06/04/2013 12:22 AM, Joe Perches wrote: > > Use a more current logging style. > > > > Rename function jfs_error to jfs_sb_err. > > Why the ren

Re: [PATCH] jfs: Convert jfs_error to jfs_sb_err

(added linux-fsdevel to cc) On Tue, 2013-06-04 at 17:25 -0500, Dave Kleikamp wrote: > On 06/04/2013 11:28 AM, Joe Perches wrote: > > This one takes a super_block * and emits a logging message > > so I chose jfs_sb_err to try to describe the sb * bit. > > > > I li

[PATCH 1/2] jfs: Update jfs_error

and align arguments. Object size reduced ~1KiB. $ size fs/jfs/built-in.o* textdata bss dec hex filename 201891 35488 63936 301315 49903 fs/jfs/built-in.o.new 202821 35488 64192 302501 49da5 fs/jfs/built-in.o.old Signed-off-by: Joe Perches --- fs/jfs/jfs_dmap.c

[PATCH 0/2] jfs: neatening

The second patch is speculative and maybe not necessary. Is a 3KB reduction in object size when embedded and !CONFIG_PRINTK worth it? Joe Perches (2): jfs: Update jfs_error jfs: Reduce object size when CONFIG_PRINTK=n fs/jfs/jfs_dmap.c | 70

[PATCH 2/2] jfs: Reduce object size when CONFIG_PRINTK=n

is not set CONFIG_JFS_STATISTICS=y $ size fs/jfs/built-in.o* textdata bss dec hex filename 1365211408 520 138449 21cd1 fs/jfs/built-in.o.new 1398341408 552 141794 229e2 fs/jfs/built-in.o.old Signed-off-by: Joe Perches --- fs/jfs/jfs_superbl

[PATCH] ext4: Reduce object size when !CONFIG_PRINTK

EXT4_USE_FOR_EXT23=y CONFIG_EXT4_FS_POSIX_ACL=y # CONFIG_EXT4_FS_SECURITY is not set # CONFIG_EXT4_DEBUG is not set Signed-off-by: Joe Perches --- fs/ext4/ext4.h | 80 +++-- fs/ext4/super.c | 15 ++- 2 files changed, 75 insertions(+), 2

Re: [PATCH] Staging: anrdroid: sync.c: fixed all checkpatch errors and warnings

On Wed, 2013-06-05 at 23:23 +0300, Aldo Iljazi wrote: > diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c [] > @@ -893,13 +892,13 @@ static void sync_print_obj(struct seq_file *s, struct > sync_timeline *obj) > if (obj->ops->timeline_value_str) { > ch

Re: [PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err

On Thu, 2013-06-06 at 18:10 +0200, Johannes Schilling wrote: > From: Laura Lawniczak [] > diff --git a/drivers/staging/keucr/init.c b/drivers/staging/keucr/init.c [] > @@ -19,13 +19,13 @@ int ENE_InitMedia(struct us_data *us) [] > - printk(KERN_INFO "MiscReg03 = %x\n", MiscReg03); > + dev_

Re: [PATCH 6/6] keucr: fix some alignment- and whitespace-problems

On Thu, 2013-06-06 at 18:10 +0200, Johannes Schilling wrote: > resolves checkpatch errors and warnings regarding whitespace around > operators, line lengths and indentation. I suggest adding --strict to your checkpatch runs to report a few more style usage elements. > diff --git a/drivers/staging

Re: [PATCH v2 4/6] PCI/ACPI: Move AER severity defines to aer.h

On Thu, 2013-06-06 at 12:10 -0600, Betty Dall wrote: > The function aer_recover_queue() is a public interface and the > severity argument uses #defines that are in the private header > pci/pcie/aer/aerdrv.h. > > This patch moves the #defines from pci/pcie/aer/aerdrv.h to > include/linux/aer.h. []

Re: [PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err

On Fri, 2013-06-07 at 00:11 +0300, Dan Carpenter wrote: > On Thu, Jun 06, 2013 at 10:53:20AM -0700, Joe Perches wrote: > > On Thu, 2013-06-06 at 18:10 +0200, Johannes Schilling wrote: > > > From: Laura Lawniczak > > [] > > > diff --git a/drivers/staging/keucr/init

[PATCH] power: Add missing newlines, fix a couple of typos, add pr_fmt

open parenthesis for these dev_ calls. Add missing spaces after coalescing multiple string segments. Signed-off-by: Joe Perches --- diff --git a/drivers/power/charger-manager.c b/drivers/power/charger-manager.c index 98de1dd..ba42029 100644 --- a/drivers/power/charger-manager.c +++ b/drivers/pow

Re: [PATCH] staging: comedi: proc.c Fixed warning and brace code style issue [kernel: linux-next: next-20130607]

On Fri, 2013-06-07 at 01:27 -0600, Daniel Hamacher wrote: > checkpatch provided a warning on line 38. It recommended seq_puts instead of > seq_printf. > Since the return value of printf is ignored, I decided to switch to the > seq_puts > function since it is just regular character output. > sourc

Re: [PATCH 4/4 v2] silicom: checkpatch: errors caused by macros

On Mon, 2013-06-17 at 21:20 +0200, Lorenz Haspel wrote: > fixed checkpatch error: > added parenthesis around complex macro. > > Macro with return was only used once in the code, > so I expandet it in-place. [] > diff --git a/drivers/staging/silicom/bpctl_mod.c > b/drivers/staging/silicom/bpctl_mo

Re: [PATCH 4/4 v2] silicom: checkpatch: errors caused by macros

On Mon, 2013-06-17 at 23:49 +0300, Dan Carpenter wrote: > On Mon, Jun 17, 2013 at 12:42:12PM -0700, Joe Perches wrote: > > On Mon, 2013-06-17 at 21:20 +0200, Lorenz Haspel wrote: > > > fixed checkpatch error: > > > added parenthesis around complex macro. > > &g

Re: [PATCH 4/4 v2] silicom: checkpatch: errors caused by macros

On Mon, 2013-06-17 at 14:14 -0700, Greg KH wrote: > On Mon, Jun 17, 2013 at 02:03:43PM -0700, Joe Perches wrote: > > Generally I think it's better that new submitters patches > > should go through more strict reviews and be as correct > > as possible. I think this is e

[PATCH 1/2] ext2: Reduce object size when !CONFIG_PRINTK

_FS_XATTR is not set # CONFIG_EXT2_FS_XIP is not set Signed-off-by: Joe Perches --- fs/ext2/ext2.h | 22 -- fs/ext2/super.c | 6 +++--- 2 files changed, 23 insertions(+), 5 deletions(-) diff --git a/fs/ext2/ext2.h b/fs/ext2/ext2.h index d9a17d0..888ae31 100644 --- a/fs/ext2/

[PATCH 2/2] ext3: Reduce object size when !CONFIG_PRINTK

EFAULTS_TO_ORDERED=y CONFIG_EXT3_FS_XATTR=y # CONFIG_EXT3_FS_POSIX_ACL is not set # CONFIG_EXT3_FS_SECURITY is not set Signed-off-by: Joe Perches --- fs/ext3/ext3.h | 44 fs/ext3/super.c | 14 +++--- 2 files changed, 47 insertions(+), 11 deletions(-)

[PATCH] checkpatch: Ignore SI unit CamelCase variants like "_uV"

Many existing variable names use SI like variants that should be otherwise obvious and acceptable. Whitelist them from the CamelCase message. Suggested-by: Phil Carmody Signed-off-by: Joe Perches --- scripts/checkpatch.pl | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts

Re: [RFC PATCH] led: add Cycle LED trigger.

On Tue, 2013-06-18 at 18:24 +0200, Gaël PORTAY wrote: > Currently, none of available triggers supports playing with the LED brightness > level. The cycle trigger provides a way to define custom brightness cycle. > For example, it is easy to customize the cycle to mock up the rhythm of human > brea

Re: [net] checkpatch: modify logFunction regular expression to allow repeated front tags

On Wed, 2013-06-19 at 03:38 -0700, Jeff Kirsher wrote: > From: Jacob Keller > > The previous logFunction regular expression allowed names for log functions > like > dev_warn or e_dbg and so forth, but some log functions are of the forms > similar to e_dev_warn, (adding an additional tag in front

Re: [patch -next] FMC: NULL dereference on allocation failure

On Wed, 2013-06-19 at 19:01 +0300, Dan Carpenter wrote: > If we don't allocate "arr" then the cleanup path will dereference it and > oops. [] > diff --git a/drivers/fmc/fmc-sdb.c b/drivers/fmc/fmc-sdb.c [] > @@ -46,16 +46,17 @@ static struct sdb_array *__fmc_scan_sdb_tree(struct > fmc_device *fmc,

Re: [patch -next] FMC: NULL dereference on allocation failure

On Wed, 2013-06-19 at 19:57 +0200, Alessandro Rubini wrote: > >> + arr->record = kzalloc(sizeof(arr->record[0]) * n, GFP_KERNEL); > >> + arr->subtree = kzalloc(sizeof(arr->subtree[0]) * n, GFP_KERNEL); > > > n comes from the hardware no? > > Yes. Length of hardware description array. > > > May

getxattr: kzalloc/vmalloc mismatch

It seems the kzalloc could be kmalloc instead. (it's filled by xattr_getsecurity) in fs/xattr.c: static ssize_t getxattr(struct dentry *d, const char __user *name, void __user *value, size_t size) { [] if (size) { if (size > XATTR_SIZE_MAX)

Re: [tip:x86/asm] x86/vdso: Convert use of typedef ctl_table to struct ctl_table

On Wed, 2013-06-19 at 13:47 -0500, H. Peter Anvin wrote: > Shouldn't this actually remove the typedef? Much later, yes. The uses are ~50:50 for the typedef vs struct ctl_table. It's used all over the tree and it likely won't be removed for several months after Jiri lets it filter through the var

[trivial PATCH] treewide: Add __GFP_NOWARN to k.alloc calls with v.alloc fallbacks

Don't emit OOM warnings when k.alloc calls fail when there there is a v.alloc immediately afterwards. Converted a kmalloc/vmalloc with memset to kzalloc/vzalloc. Signed-off-by: Joe Perches --- drivers/block/drbd/drbd_bitmap.c | 2 +- drivers/infiniband/hw/ehca/ipz_pt

[PATCH v2] checkpatch: Allow longer logging function names

Brown Signed-off-by: Jeff Kirsher Signed-off-by: Joe Perches --- jp: Modified Jacob's patch and commit message to limit the number of word blocks because foo_bar_baz_dev_warn is just too long to live. scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[PATCH] MAINTAINERS: Remove Hans J. Koch entries

On Thu, 2013-06-20 at 18:01 +0200, Pavel Machek wrote: > Anyway, Hans disappeared, so Greg takes patches, again. Maybe this is appropriate then. Signed-off-by: Joe Perches --- diff --git a/MAINTAINERS b/MAINTAINERS index 69fea4f..dc9d04a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -525

Re: [lm-sensors] [PATCH] MAINTAINERS: Remove Hans J. Koch entries

On Thu, 2013-06-20 at 09:30 -0700, Guenter Roeck wrote: > On Thu, Jun 20, 2013 at 09:20:27AM -0700, Joe Perches wrote: > > On Thu, 2013-06-20 at 18:01 +0200, Pavel Machek wrote: > > > Anyway, Hans disappeared, so Greg takes patches, again. [] > > MAX6650 HARDWARE MONITOR A

Re: [RFC PATCH] led: add Cycle LED trigger.

On Thu, 2013-06-20 at 11:44 +0200, Gaël PORTAY wrote: > On 19/06/2013 00:05, Joe Perches wrote: > > On Tue, 2013-06-18 at 18:24 +0200, Gaël PORTAY wrote: > >> Currently, none of available triggers supports playing with the LED > >> brightness > >> level.

Re: Re: [PATCH] gpio MIPS/OCTEON: Add a driver for OCTEON's on-chip GPIO pins.

On Thu, 2013-06-20 at 11:10 -0700, David Daney wrote: > Sorry for not responding earlier, but my e-mail system seems to have > malfunctioned with respect to this message... [] > On 06/17/2013 01:51 AM, Linus Walleij wrote: > >> +static int octeon_gpio_get(struct gpio_chip *chip, unsigned offset) >

[PATCH] mm: remove unused VM_ macros and expand other in-place

Signed-off-by: Joe Perches --- Found by looking for CamelCase variable name exceptions include/linux/mm.h | 6 -- mm/filemap.c | 6 +++--- mm/memory.c| 2 +- mm/rmap.c | 2 +- 4 files changed, 5 insertions(+), 11 deletions(-) diff --git a/include/linux/mm.h b/include/

Re: [PATCH] gpio MIPS/OCTEON: Add a driver for OCTEON's on-chip GPIO pins.

On Thu, 2013-06-20 at 11:27 -0700, David Daney wrote: > On 06/20/2013 11:18 AM, Joe Perches wrote: > > On Thu, 2013-06-20 at 11:10 -0700, David Daney wrote: > >> Sorry for not responding earlier, but my e-mail system seems to have > >> malfunctioned with respect to thi

[PATCH] checkpatch: Ignore existing CamelCase uses from include/...

--strict and only when there is a CamelCase use found. If a .git directory is found, it uses git ls-files include If not, it uses 'find $root/include -name "*.h" Signed-off-by: Joe Perches --- scripts/checkpatch.pl | 57 --- 1 f

Re: [PATCH] cpufreq: MAINTAINERS: Add git tree path for ARM specific updates

On Wed, 2013-05-29 at 16:10 +0530, Viresh Kumar wrote: > ARM specific patches would be > Applied by me now. Rafael will pull in these changes from time to time (at > rc's). [] > diff --git a/MAINTAINERS b/MAINTAINERS [] > @@ -2216,6 +2216,7 @@ L: cpuf...@vger.kernel.org [] > T: git://git.ke

Re: [PATCH] checkpatch: forgive use of mixed case variables measuring units

On Wed, 2013-05-29 at 14:02 +0300, Phil Carmody wrote: > I don't think anyone really has an issue with things like max_mV. > And whilst nS et al. may not be SI standard, at least it's clear > what they represent. [] > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -2940,6 +2940,

Re: Improving or replacing snd_printk()

On Wed, 2013-05-29 at 15:27 -0400, Alan Stern wrote: > Has there been any thought of improving snd_printk(), or even better, > changing the call sites to use the dev_*() routines instead? Perhaps better would be to add and use some combination of type specific logging message functions/macros like

Re: [PATCH] timer: Fix jiffies wrap behavior of round_jiffies*()

On Wed, 2013-05-29 at 16:01 -0700, Andrew Morton wrote: > On Tue, 21 May 2013 20:43:50 +0200 Bart Van Assche > wrote: > > > Make sure that the round_jiffies*() functions return a time that is > > in the future when the jiffies counter is about to wrap. > > Actually "when the jiffies counter has

Re: [PATCH] timer: Fix jiffies wrap behavior of round_jiffies*()

On Wed, 2013-05-29 at 16:38 -0700, Andrew Morton wrote: > On Wed, 29 May 2013 16:17:47 -0700 Joe Perches wrote: > > > > We could perhaps have a checkpatch rule > > > which looks for comparisons against jiffes (and any other > > > time-measuring variables we can

Re: [PATCH] timer: Fix jiffies wrap behavior of round_jiffies*()

On Wed, 2013-05-29 at 16:38 -0700, Andrew Morton wrote: > On Wed, 29 May 2013 16:17:47 -0700 Joe Perches wrote: > > > > We could perhaps have a checkpatch rule > > > which looks for comparisons against jiffes (and any other > > > time-measuring variables we can

Re: [PATCH] powerpc/pseries: use 'true' instead of '1' for orderly_poweroff

On Thu, 2013-05-30 at 15:07 +0800, liguang wrote: > orderly_poweroff is expecting a bool parameter, so > use 'ture' instead '1' [] > diff --git a/arch/powerpc/platforms/pseries/ras.c > b/arch/powerpc/platforms/pseries/ras.c [] > @@ -162,7 +162,7 @@ void rtas_parse_epow_errlog(struct rtas_error_log

Re: [PATCH 1/4] sys: remove unnecesscary parameter of set_one_prio

On Thu, 2013-05-30 at 15:58 +0800, liguang wrote: [] > diff --git a/kernel/sys.c b/kernel/sys.c [] > -static int set_one_prio(struct task_struct *p, int niceval, int error) > +static int set_one_prio(struct task_struct *p, int niceval) Umm, error is forwarded through do_each loops. Are you sure y

Re: [alsa-devel] Improving or replacing snd_printk()

On Thu, 2013-05-30 at 15:43 -0400, Alan Stern wrote: > On Thu, 30 May 2013, Jaroslav Kysela wrote: > > > Date 30.5.2013 20:14, Alan Stern wrote: > > > On Wed, 29 May 2013, Joe Perches wrote: > > > > > >> On Wed, 2013-05-29 at 15:27 -0400, Alan Stern wr

[PATCH 0/3] pktcdvd: A few more neatenings

Joe Perches (3): pktcdvd: Convert ZONE macro to static function get_zone() pktcdvd: Convert printk to pr_ pktcdvd: Consolidate DPRINTK and VPRINTK macros drivers/block/pktcdvd.c | 248 1 file changed, 126 insertions(+), 122 deletions

[PATCH 1/3] pktcdvd: Convert ZONE macro to static function get_zone()

Macros should be converted to functions where feasible to verify arguments and the like. Signed-off-by: Joe Perches --- drivers/block/pktcdvd.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index

[PATCH 2/3] pktcdvd: Convert printk to pr_

Use a more current logging style and add messages levels to the logging messages. Convert bare printks to pr_cont where appropriate and add a simple function to emit the sense string. Signed-off-by: Joe Perches --- drivers/block/pktcdvd.c | 123

[PATCH 3/3] pktcdvd: Consolidate DPRINTK and VPRINTK macros

Use the more common pkt_dbg(level, fmt, ...) form. These messages are emitted at KERN_NOTICE. Always emit function name with pkt_dbg(2, ...) uses and remove the sometimes abbreviated embedded function name. This form always verifies the format and arguments. Signed-off-by: Joe Perches

Re: [PATCH] net: skbuff: use _RET_IP_

On Thu, 2013-05-30 at 18:11 -0700, Davidlohr Bueso wrote: > On Thu, 2013-05-30 at 13:08 +0200, Bjørn Mork wrote: > > Sergei Shtylyov writes: > > > > > Why not "text:%#lx" as already used in this string? It's > > > equivalent to "0x%lx". > > > > Well, I don't know the reasoning in this case,

Re: [PATCH 0/3] pktcdvd: A few more neatenings

On Thu, 2013-05-30 at 13:57 -0700, Joe Perches wrote: > Joe Perches (3): > pktcdvd: Convert ZONE macro to static function get_zone() > pktcdvd: Convert printk to pr_ > pktcdvd: Consolidate DPRINTK and VPRINTK macros > > drivers/blo

Re: [alsa-devel] Improving or replacing snd_printk()

On Fri, 2013-05-31 at 08:37 +0200, Takashi Iwai wrote: > It's a problem only with snd_printk(), as CONFIG_SND_VERBOSE_PRINTK > influences on the behavior of snd_printk() and not on the debug prints > with snd_printd() & co. Are you're perhaps confused about how CONFIG_SND_VERBOSE_PRINTK works with

Re: [alsa-devel] Improving or replacing snd_printk()

On Fri, 2013-05-31 at 09:23 +0200, Takashi Iwai wrote: > At Fri, 31 May 2013 00:06:07 -0700, Joe Perches wrote: > > On Fri, 2013-05-31 at 08:37 +0200, Takashi Iwai wrote: > > > I think most of snd_printd() and snd_printdd() can be kept as is. > > > These are jus

Re: [alsa-devel] Improving or replacing snd_printk()

On Fri, 2013-05-31 at 09:35 +0200, Takashi Iwai wrote: > At Fri, 31 May 2013 00:30:09 -0700, Joe Perches wrote: > > On Fri, 2013-05-31 at 09:23 +0200, Takashi Iwai wrote: > > > At Fri, 31 May 2013 00:06:07 -0700, Joe Perches wrote: > > > > On Fri, 2013-05-31 at 0

Re: [PATCH] net: skbuff: use _RET_IP_

On Fri, 2013-05-31 at 18:33 +0400, Sergei Shtylyov wrote: > On 31-05-2013 9:20, Joe Perches wrote: > > Don't use a standalone gcc compiled program to > > determine what the kernel outputs. [] > > The kernel output is; > > > printk("0x%lx\n", 0x1

Re: [alsa-devel] Improving or replacing snd_printk()

On Fri, 2013-05-31 at 16:34 +0200, Takashi Iwai wrote: > Also, another expected problem is that neither card->card_dev nor > card->dev are set when snd_card_err() is called. Many drivers set the > device pointers at the late stage just before the device > registration. So, systematic replacements

Re: [PATCH 2/3] pktcdvd: Convert printk to pr_

On Fri, 2013-05-31 at 22:44 +0300, Andy Shevchenko wrote: > On Thu, May 30, 2013 at 11:57 PM, Joe Perches wrote: > > Use a more current logging style and add messages levels > > to the logging messages. > > > > Convert bare printks to pr_cont where appropriate and &

[PATCH V2 0/8] pktcdvd: More neatenings

Removed the compile error the patch 1 and compile fix in 2 Added Andy's suggestion in patch 2. Added conversions to print pd->name in logging macros. Joe Perches (8): pktcdvd: Convert ZONE macro to static function get_zone() pktcdvd: Convert printk to pr_ pktcdvd: Consolidate DPR

[PATCH V2 1/8] pktcdvd: Convert ZONE macro to static function get_zone()

Macros should be converted to functions where feasible to verify arguments and the like. Signed-off-by: Joe Perches --- drivers/block/pktcdvd.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index

[PATCH V2 5/8] pktcdvd: Add struct pktcdvd_device.name to pr_err logging where possible

Add a new pkt_err macro to prefix the name to the logging output. Convert pr_err where there is a non-null struct pktcdvd_device. Signed-off-by: Joe Perches --- drivers/block/pktcdvd.c | 44 1 file changed, 24 insertions(+), 20 deletions(-) diff

[PATCH V2 8/8] pktcdvd: Add struct pktcdvd_device * to pkt_dump_sense()

Allow the device name to be emitted with pkt_err when logging the sense data. Signed-off-by: Joe Perches --- drivers/block/pktcdvd.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index

[PATCH V2 2/8] pktcdvd: Convert printk to pr_

Use a more current logging style and add messages levels to the logging messages. Simplify pkt_dump_sense by using %*ph and adding a simple function to emit the sense string. Signed-off-by: Joe Perches Improved-by: Andy Shevchenko --- drivers/block/pktcdvd.c | 123

<    4   5   6   7   8   9   10   11   12   13   >