On Tue, 2013-10-08 at 17:49 -0700, Joe Perches wrote:
> On Wed, 2013-10-09 at 11:15 +1100, Ryan Mallon wrote:
> > Some setuid binaries will allow reading of files which have read
> > permission by the real user id. This is problematic with files which
> > use %pK because the f
On Wed, 2013-10-09 at 12:55 +1100, Ryan Mallon wrote:
> On 09/10/13 12:30, Joe Perches wrote:
> > On Tue, 2013-10-08 at 17:49 -0700, Joe Perches wrote:
> >> On Wed, 2013-10-09 at 11:15 +1100, Ryan Mallon wrote:
> >>> Some setuid binaries will allow reading of files wh
On Wed, 2013-10-09 at 13:22 +1100, Ryan Mallon wrote:
> Anyway, updated patch below:
nit:
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
[]
> @@ -1312,11 +1313,36 @@ char *pointer(const char *fmt, char *buf, char *end,
> void *ptr,
> spec.field_width = default_widt
On Wed, 2013-10-09 at 13:00 +0900, Sangjung Woo wrote:
> In order to be free automatically and make the cleanup paths more
> simple, use devm_kzalloc() instead of kzalloc().
[]
> diff --git a/drivers/rtc/rtc-pl030.c b/drivers/rtc/rtc-pl030.c
[]
> @@ -106,7 +106,7 @@ static int pl030_probe(struct am
On Wed, 2013-10-09 at 13:36 +0900, sangjung.woo wrote:
> On 10/09/2013 01:07 PM, Joe Perches wrote:
> > On Wed, 2013-10-09 at 13:00 +0900, Sangjung Woo wrote:
> >> In order to be free automatically and make the cleanup paths more
> >> simple, use devm_k
__GFP_ZERO added to the gfp flag where appropriate:
devm_kzalloc
devm_kcalloc
devm_kmalloc_array
Add gfp.h to device.h for the newly added static inlines.
Signed-off-by: Joe Perches
---
drivers/base/devres.c | 27 ---
include/linux/device.h | 21
On Tue, 2013-10-08 at 22:43 -0700, Greg KH wrote:
> On Tue, Oct 08, 2013 at 10:32:27PM -0700, Joe Perches wrote:
> > Currently, devm_ managed memory only supports kzalloc.
> >
> > Convert the devm_kzalloc implementation to devm_kmalloc
> > and remove the complete me
On Wed, 2013-10-09 at 14:49 +0900, Sangjung Woo wrote:
> Because dev_*() are used along with pr_debug() function in this code,
> the debug message is not tidy. This patch converts from pr_debug() to
> dev_dbg() since dev_*() are encouraged to use in device driver code.
[]
> diff --git a/drivers/rtc
On Tue, 2013-10-08 at 23:54 -0700, Greg KH wrote:
> On Tue, Oct 08, 2013 at 11:16:44PM -0700, Joe Perches wrote:
> > On Tue, 2013-10-08 at 22:43 -0700, Greg KH wrote:
> > > On Tue, Oct 08, 2013 at 10:32:27PM -0700, Joe Perches wrote:
> > > > Currently, devm_ manage
On Wed, 2013-10-09 at 07:14 -0400, Dan Rosenberg wrote:
> isn't the default value of kptr_restrict 0 now, unless I'm missing
> something? If I recall it was 1 when originally written, and then
> changed to 0 at some point. Could the documentation be updated to
> reflect that?
Yeah, the default got
On Wed, 2013-10-09 at 12:52 +0200, Michal Simek wrote:
> Simplify driver probe and release function.
[]
> diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c
[]
> @@ -423,7 +419,7 @@ static int xilinxfb_of_probe(struct platform_device *pdev)
> pdata = xilinx_fb_default_pdata;
>
On Wed, 2013-10-09 at 12:30 -0400, Tejun Heo wrote:
> Hello,
>
> On Wed, Oct 09, 2013 at 12:04:42AM -0700, Joe Perches wrote:
> > > > > > devm_kzalloc
> > > > > > devm_kcalloc
> > > > > > devm_kmalloc_array
> >
Hey Bjorn
On Wed, 2013-10-09 at 15:02 -0600, Bjorn Helgaas wrote:
> I handle many arch/x86/pci changes, so help those patches get to the
> PCI patchwork.
[]
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e61c2e8..d1ab647 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6338,6 +6338,7 @@ S:
On Thu, 2013-10-10 at 08:52 +1100, Ryan Mallon wrote:
> Some setuid binaries will allow reading of files which have read
> permission by the real user id. This is problematic with files which
> use %pK because the file access permission is checked at open() time,
> but the kptr_restrict setting is
On Thu, 2013-10-10 at 09:04 +1100, Ryan Mallon wrote:
> On 10/10/13 09:00, Joe Perches wrote:
[]
> > Move the interrupt tests and pK-error printk
> > into case 1:
> >
> > It's the only case where CAP_SYSLOG needs to be
> > tested so it doesn't need
On Thu, 2013-10-10 at 09:25 +1100, Ryan Mallon wrote:
> if (kptr_restrict && (in_irq() || in_serving_softirq() ||
> in_nmi())) {
>
> Is making sure that you don't have kernel code doing something like this:
>
> irqreturn_t some_irq_handler(int irq, void *d
inal-patch-by: Ryan Mallon
Signed-off-by: Joe Perches
---
On Thu, 2013-10-10 at 09:42 +1100, Ryan Mallon wrote:
> If it was noisy, it would indicate a bunch of broken kernel code which
> needs fixing :-).
Or maybe a single kernel source line but
you'd still have a filled up log file.
On Thu, 2013-10-10 at 10:18 +1100, Ryan Mallon wrote:
> On 10/10/13 10:09, Joe Perches wrote:
> > Do the in_irq tests only when kptr_restrict is 1.
> > Document the %pK mechanism in vsnprintf
> > Add missing documentation for %pV and %pNF too
>
> I really did mean post
On Thu, 2013-10-10 at 12:39 +0200, Michal Simek wrote:
> Code changes to fix checkpatch warnings listed below.
> - WARNING: quoted string split across lines
[]
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
[]
> @@ -271,11 +271,8 @@ static void xiic_read_rx(struct xiic
These aren't necessary after switch, if and while statements.
Also remove some unnecessary braces where these
semicolons were removed around single statement
and some unnecessary blank lines.
Signed-off-by: Joe Perches
---
drivers/staging/iio/adc/ad7291.c| 2 +-
dr
On Thu, 2013-10-10 at 16:06 -0700, Andrew Morton wrote:
> On Tue, 08 Oct 2013 21:59:27 -0700 Joe Perches wrote:
>
> > I was a bit surprised to find there isn't a devm_kmalloc.
>
> Yes, the unconditional memset is silly. Especially when the
> function has a handy
On Thu, 2013-10-10 at 19:18 -0400, Tejun Heo wrote:
> Do we have an
> actual cases where this makes meaningful differences?
There are already a few array allocations
where the array is completely reinitialized.
Does it matter? Shrug.
It's more API compatible and more symmetric.
Direct conversi
On Thu, 2013-10-10 at 18:00 -0700, Linus Torvalds wrote:
> the first step is to realize you have a problem.
Says the guy that can only send patches to the list
as attachments not plain text because he uses gmail.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the bo
Just a few cleanups to use zalloc style calls and reduce
the uses of __GFP_ZERO for kmem_cache_alloc[_node] uses.
Use the more kernel normal zalloc style.
Joe Perches (6):
slab/block: Add and use kmem_cache_zalloc_node
block: Convert kmem_cache_alloc(...GFP_ZERO) to kmem_cache_zalloc
Create and use kmem_cache_zalloc_node utility to be
acompatible style with all the zalloc equivalents
for kmem_cache_zalloc.
Reduce the uses of __GFP_ZERO.
Signed-off-by: Joe Perches
---
block/blk-core.c | 3 +--
block/blk-ioc.c | 6 ++
block/cfq-iosched.c | 10
The helper exists, might as well use it instead of __GFP_ZERO.
Signed-off-by: Joe Perches
---
block/blk-integrity.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/block/blk-integrity.c b/block/blk-integrity.c
index 03cf717..b97f2e2 100644
--- a/block/blk-integrity.c
+++ b
The helper exists, might as well use it instead of __GFP_ZERO.
Signed-off-by: Joe Perches
---
fs/aio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/aio.c b/fs/aio.c
index 9f783e3..f680878 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -774,7 +774,7 @@ static inline struct
The helper exists, might as well use it instead of __GFP_ZERO.
Signed-off-by: Joe Perches
---
fs/f2fs/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 13d0a0f..d43709a 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -286,7
The helper exists, might as well use it instead of __GFP_ZERO.
Signed-off-by: Joe Perches
---
fs/ceph/dir.c | 2 +-
fs/ceph/file.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c
index 868b61d..c10bc70 100644
--- a/fs/ceph/dir.c
+++ b/fs
The helper exists, might as well use it instead of __GFP_ZERO.
Signed-off-by: Joe Perches
---
drivers/gpu/drm/i915/i915_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 8a0eb96..c4acd96 100644
--- a
Use the convenience function instead of __GFP_ZERO.
Signed-off-by: Joe Perches
---
arch/x86/kernel/cpu/perf_event_amd.c | 3 +--
arch/x86/kernel/cpu/perf_event_intel_ds.c | 6 +++---
arch/x86/kernel/cpu/perf_event_intel_uncore.c | 2 +-
3 files changed, 5 insertions(+), 6 deletions
kzalloc already adds this __GFP_ZERO.
Signed-off-by: Joe Perches
---
drivers/tty/hvc/hvc_xen.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c
index 682210d..e61c36c 100644
--- a/drivers/tty/hvc/hvc_xen.c
+++ b
This sequence can return non-zeroed memory from the
padding area of the original allocation.
ptr = kzalloc(foo, GFP_KERNEL);
if (!ptr)
...
new_ptr = krealloc(ptr, foo + bar, GFP_KERNEL | __GFP_ZERO);
If the realloc size is within the first actual allocation
Use the helper function instead of __GFP_ZERO.
Signed-off-by: Joe Perches
---
block/cfq-iosched.c | 2 +-
block/deadline-iosched.c | 2 +-
block/elevator.c | 2 +-
block/genhd.c| 3 +--
4 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/block/cfq-iosched.c b
Use the helper function instead of __GFP_ZERO.
Signed-off-by: Joe Perches
---
mm/mempool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/mempool.c b/mm/mempool.c
index 5499047..659aa42 100644
--- a/mm/mempool.c
+++ b/mm/mempool.c
@@ -73,7 +73,7 @@ mempool_t
Use the helper function instead of __GFP_ZERO.
Signed-off-by: Joe Perches
---
lib/genalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/genalloc.c b/lib/genalloc.c
index e57cc70..26cf20b 100644
--- a/lib/genalloc.c
+++ b/lib/genalloc.c
@@ -187,7 +187,7 @@ int
Use the helper function instead of __GFP_ZERO.
Signed-off-by: Joe Perches
---
kernel/timer.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/kernel/timer.c b/kernel/timer.c
index 4296d13..fab8eac 100644
--- a/kernel/timer.c
+++ b/kernel/timer.c
@@ -1518,9 +1518,8
kcalloc returns zeroed memory.
There's no need to use this flag.
Signed-off-by: Joe Perches
---
mm/ksm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/ksm.c b/mm/ksm.c
index 0bea2b2..175fff7 100644
--- a/mm/ksm.c
+++ b/mm/ksm.c
@@ -2309,8 +2309,8 @@ static ss
On Thu, 2013-08-29 at 22:09 -0400, David Miller wrote:
> Applied, thanks a lot Joe.
Too bad I didn't know there was a dma_zalloc_coherent
the first time...
cheers, Joe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
On Fri, 2013-08-30 at 01:06 +0200, Francois Romieu wrote:
just trivia:
> diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c
[]
> @@ -288,19 +291,19 @@ static void sr9700_set_multicast(struct net_device *net)
[]
> +static int sr9700_set_mac_address(struct net_device *netdev, void *p)
On Fri, 2013-08-30 at 09:40 -0700, Guenter Roeck wrote:
> H8/300 has been dead for several years, the kernel for it has
> not compiled for ages, and recent versions of gcc for it are broken.
> It is time to drop support for it.
Adding Yoshinori Sato
just in case the MAINTAINER address is still al
Just some potential cleanings...
Joe Perches (4):
i40e: Whitespace cleaning
i40e: Add and use pf_
i40e: pf_ remove "%s: " ... __func__
i40e: Convert pf_ macros to functions
drivers/net/ethernet/intel/i40e/i40e.h | 149 +--
drivers/net/ethernet/intel/i40e/i40
rivers/net/ethernet/intel/i40e/built-in.o.new
177030 35867 49936 262833 402b1
drivers/net/ethernet/intel/i40e/built-in.o.old
Signed-off-by: Joe Perches
---
drivers/net/ethernet/intel/i40e/i40e.h | 12
drivers/net/ethernet/intel/i40e/i40e_main.c | 45 ++
On Fri, 2013-08-30 at 15:48 -0700, Randy Dunlap wrote:
> On 08/30/13 15:14, Anatol Pomozov wrote:
> > But another question still remains: why compiler does not warn that
> > size truncation happens? How to prevent bugs like CFQ one in the
> > future? Should we add a compile-time assert to do_div()
When dma_addr_t is a 32 bit value, >> 32 emits compiler warnings
Use ((addr>>16) >>16) to avoid this.
I presume the macro should actually use the kernel.h
macro upper_32_bits() eventually.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/intel/i40e/i40e_hmc.h | 2 +-
dr
On Sat, 2013-08-31 at 16:31 +0200, Andi Kleen wrote:
> > A similar patch was suggested by Andi Kleen
> > https://lkml.org/lkml/2013/8/5/648
>
> My patch checked for const <-> initdata / non const initconst mistakes.
>
> I don't think your patch does that?
Hi Andi.
No it doesn't.
This patch is
!= 0
+ ether_addr_equal(a, b)
@@
expression a,b;
@@
- !!ether_addr_equal(a, b)
+ ether_addr_equal(a, b)
Signed-off-by: Joe Perches
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 18 +-
drivers/staging/rtl8192e/rtllib_rx.c | 13 ++---
drivers/staging/sli
;
@@
- ether_addr_equal(a, b) == 0
+ !ether_addr_equal(a, b)
@@
expression a,b;
@@
- ether_addr_equal(a, b) != 0
+ ether_addr_equal(a, b)
@@
expression a,b;
@@
- !!ether_addr_equal(a, b)
+ ether_addr_equal(a, b)
Signed-off-by: Joe Perches
---
drivers/net/ethernet
(a, b)
@@
expression a,b;
@@
- ether_addr_equal(a, b) == 0
+ !ether_addr_equal(a, b)
@@
expression a,b;
@@
- ether_addr_equal(a, b) != 0
+ ether_addr_equal(a, b)
@@
expression a,b;
@@
- !!ether_addr_equal(a, b)
+ ether_addr_equal(a, b)
Signed-off-by: Joe
On Mon, 2013-09-02 at 03:30 +0800, Wang Shilong wrote:
> Hello, Using checkpatch.pl, i get the following warnings(errors):
Hello.
Especially for staging patches, all of these are "don't care"
types of messages.
You should change your script to check if these are existing
warnings and if so, not
Convert the llc_ static inlines to the
equivalents from etherdevice.h and remove
the llc_ static inline functions.
llc_mac_null -> is_zero_ether_addr
llc_mac_multicast -> is_multicast_ether_addr
llc_mac_match -> ether_addr_equal
Signed-off-by: Joe Perches
---
include/net/llc_
compare_ether_addr is being removed so remove
even the commented out code referring to it.
Signed-off-by: Joe Perches
---
drivers/staging/vt6655/vntwifi.c | 22 --
1 file changed, 22 deletions(-)
diff --git a/drivers/staging/vt6655/vntwifi.c b/drivers/staging/vt6655
This function is being removed, rename the reference.
Signed-off-by: Joe Perches
---
net/batman-adv/main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h
index 5e9aebb..7333cf8 100644
--- a/net/batman-adv/main.h
+++ b/net/batman
This function is being removed, so remove the reference to it.
Signed-off-by: Joe Perches
---
net/wireless/scan.c | 4
1 file changed, 4 deletions(-)
diff --git a/net/wireless/scan.c b/net/wireless/scan.c
index ad1e406..eeb7148 100644
--- a/net/wireless/scan.c
+++ b/net/wireless/scan.c
(cc'ing lkml, Andrew Morton and Linus)
Hi David.
I'm making a few comments to your otherwise unedited
original email sent to me and ksummit-2013-discuss below:
On Mon, 2013-09-02 at 15:31 +0100, David Howells wrote:
> I have some questions about the process of changing the coding style:
>
> (1)
The use of extern in .h files is a bit contentious.
Make it emitted only when --strict is used on the
command-line.
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index
On Mon, 2013-09-02 at 13:25 +0200, Gerd Hoffmann wrote:
> xhci maintains a radix tree for each stream endpoint because it must
> be able to map a trb address to the stream ring. Each ring segment
> must be added to the ring for this to work. Currently xhci sticks
> only the first segment of each
On Mon, 2013-09-02 at 15:39 -0300, Mauro Carvalho Chehab wrote:
> Em Mon, 2 Sep 2013 11:19:01 -0700
> Josh Triplett escreveu:
[]
> > +# This file does not define the kernel coding style;
> > Documentation/CodingStyle
> > +# does. If you add a new style test to this file, add the corresponding
>
Add a message describing the lack of value in using
--file to generate patches.
Exclude files in staging from this message.
A similar message was removed by commit cf655043d4b
("update checkpatch.pl to version 0.15")
Signed-off-by: Joe Perches
---
Maybe this sort of wordsmithing i
On Mon, 2013-09-02 at 22:51 +0200, Geert Uytterhoeven wrote:
> I know it's not the subject of this patch, but shouldn't "extern prototypes"
> be "extern keywords"?
No, extern is required for variables.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a me
On Mon, 2013-09-02 at 21:50 +0100, David Howells wrote:
> Josh Triplett wrote:
>
> > > There are many checkpatch rules (like semicolons) that
> > > are not in CodingStyle.
> >
> > It's a rule of thumb, not a mandate. In *general*, checkpatch.pl should
> > not be enforcing style rules that aren'
On Mon, 2013-09-02 at 23:37 +0300, Dan Carpenter wrote:
> On Mon, Sep 02, 2013 at 12:40:47PM -0700, Joe Perches wrote:
> > +WARNING: When using --file mode, do not send patches that just make
> > +whitespace or formatting changes unless more significant changes are
> > +also m
Spaces around trigraphs are specified by CodingStyle
but checkpatch is currently silent about them because
there are many current instances without them.
Make missing spaces around trigraphs a --strict message.
Signed-off-by: Joe Perches
---
> Oddly enough, the opposite is true as well.
> would you mind looking at why
> it gives a false positive for spaces around '*' on my recent patch at
> http://mid.gmane.org/20130901234251.GB25057@leaf ? It appears to
> mistake the '*' of a pointer for a multiply.
Looks like checkpatch thinks this should be a multiplication.
Try this:
---
s
On Tue, 2013-09-03 at 08:39 +0800, Fengguang Wu wrote:
> On Mon, Sep 02, 2013 at 02:11:36PM -0700, Joe Perches wrote:
[]
> > Fengguang Wu's very useful build robot
> > sends out emails on build failures.
> > I think that's great.
>
> Thanks! Yes I'm now
On Mon, 2013-09-02 at 18:34 -0700, Josh Triplett wrote:
> I'd suggest a couple more, which
> *should* always make sense, and to the best of my knowledge don't tend
> to generate false positives:
>
> C99_COMMENTS
I don't have a problem with c99 comments.
As far as I know, Linus doesn't either.
ht
On Mon, 2013-09-02 at 19:12 -0700, Josh Triplett wrote:
> On Mon, Sep 02, 2013 at 06:52:45PM -0700, Joe Perches wrote:
> > On Mon, 2013-09-02 at 18:34 -0700, Josh Triplett wrote:
> > > I'd suggest a couple more, which
> > > *should* always make sense, and to the
."
So, if checking a patch, scan the original patched file if it's
available and add any preexisting CamelCase types so reuses do
not generate CamelCase messages.
That also means Andrew's not so cruelly spurned anymore.
https://lkml.org/lkml/2013/2/22/426
Signed-off-by: Joe Perches
Tyops should be fixed.
Signed-off-by: Joe Perches
---
drivers/net/wireless/rtlwifi/rtl8192de/dm.c | 2 +-
drivers/scsi/bfa/bfad_im.c | 2 +-
drivers/scsi/hpsa.c | 2 +-
drivers/scsi/lpfc/lpfc_bsg.c| 2 +-
drivers/scsi/qla2xxx/qla_bsg.c
Use normal kernel-doc "Returns:" instead of retruns
Assignment to bool is always 1 or 0 so the !! isn't necessary.
Signed-off-by: Joe Perches
---
include/linux/pci.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/pci.h b/include/linux/pci.
2}' | \
sort | uniq -c
121 *return:
838 *Return:
778 *RETURN:
191 *returns:
1965 *Returns:
603 *RETURNS:
Rather than change all of the variants to the
canonical "Return:", adapt the script to accept
case insensitive "Return:" and "Returns:&qu
On Wed, 2013-09-04 at 01:00 +, Nelson, Shannon wrote:
Hi Shannon.
> > -Original Message- > From: Joe Perches
> [mailto:j...@perches.com] > Sent: Friday, August 30, 2013 4:06 PM > >
> Just some potential cleanings...
>
> > i40e: Whitespace cleaning
On Wed, 2013-09-04 at 01:00 +000, Nelson, Shannon wrote:
> we hadn't noticed the new experimental "--fix" option before. There
> are a lot of good suggestions there, but obviously it needs a lot of
> reading and tweaking before it can be used.
Yes, I think --fix works best on patches.
When you u
On Wed, 2013-09-25 at 21:11 +0100, Al Viro wrote:
> On Wed, Sep 25, 2013 at 12:22:00PM -0700, Joe Perches wrote:
> > It's pretty obvious from fs/binfmt_misc.c that you have
> > your own taste.
> >
> > $ scripts/checkpatch.pl -f --strict fs/binfmt_misc.c
> > [
On Wed, 2013-09-25 at 17:21 -0700, Andrew Morton wrote:
> On Wed, 25 Sep 2013 16:08:20 -0700 Linus Torvalds
> wrote:
>
> > On Wed, Sep 25, 2013 at 9:18 AM, Frederic Weisbecker
> > wrote:
> > > +#ifdef CONFIG_X86_64
> > > +# define __ARCH_IRQ_EXIT_ON_IRQ_STACK
> > > +#endif
> >
> > Ok, see the
On Wed, 2013-09-25 at 14:43 +1000, Stephen Rothwell wrote:
> Hi all,
>
> Heads up: I will be having a 3 week break leading up to the kernel
> summit. This means that next-20130927 (next Friday) will be the last
> linux-next release until next-20131028 (or maybe 29). I presume that
> Linus will b
On Wed, 2013-09-25 at 18:26 -0700, Linus Torvalds wrote:
> On Wed, Sep 25, 2013 at 5:40 PM, Joe Perches wrote:
> >
> > Huh? That matches all the ARCH_HAS_ patterns.
>
> Right. And they are all crap. lib/string.c is a prime example of
> something that should never
On Wed, 2013-09-25 at 19:32 -0700, Andrew Morton wrote:
> On Wed, 25 Sep 2013 19:00:54 -0700 Joe Perches wrote:
>
> > +# Use of __ARCH_HAS_ or ARCH_HAVE_ is wrong.
> > + if ($line =~
> > /\+\s*#\s*define\s+((?:__)?ARCH_(?:HAS|HAVE)\w*)\b/) {
>
On Thu, 2013-09-26 at 12:47 +0300, Tomi Valkeinen wrote:
> On 20/09/13 04:53, Joe Perches wrote:
> > s/framebugger/framebuffer/
[]
> Thanks, queued for 3.13. Although I have to say I kinda like the sound
> of framebugger.
I wondered if I should even change it
because it _is_ kind o
On Thu, 2013-09-26 at 15:45 +0100, David Howells wrote:
> Use no_printk() for the null dprintk() and dfprintk() so that the compiler
> doesn't complain about unused variables for stuff that's just printed.
no_printk doesn't prevent any argument side-effects
from being optimized away by the compile
On Thu, 2013-09-26 at 16:35 +0100, David Howells wrote:
> Joe Perches wrote:
>
> > no_printk doesn't prevent any argument side-effects
> > from being optimized away by the compiler.
> >
> > ie:
> > dprintk("%d", func())
> > func is
On Thu, 2013-09-26 at 13:44 -0400, David Miller wrote:
> From: Joe Perches
> Date: Wed, 25 Sep 2013 12:37:18 -0700
[]
> Pulled, thanks Joe.
> That should be about it for networking right?
Yes for drivers/net/...
There are some more files like:
include/linux/etherdevice.h
i
On Thu, 2013-09-26 at 13:54 -0700, Greg Kroah-Hartman wrote:
> On Thu, Sep 05, 2013 at 06:36:08PM -0700, Joe Perches wrote:
> > Whitespace neatening...
> >
> > Multiline statement argument alignment.
> > Argument wrapping.
> > Use
On Thu, 2013-09-26 at 18:11 +, Perez-Gonzalez, Inaky wrote:
> > From: Joe Perches [mailto:j...@perches.com]
> > >
> > > The W: link is dead.
> > >
> > > Given wimax never really took off, is there any point in keeping this in
> > > the kernel
u to fetch changes up to f629d208d27a22f495b7734eede585b5d207e912:
[networking]device.h: Remove extern from function prototypes (2013-09-26
15:06:58 -0700)
----
Joe Perches (3):
netfilter: Remove extern from function prototypes
net.
clare automatic/local variables in a block.
Signed-off-by: Joe Perches
---
include/linux/netfilter.h| 10 +-
include/linux/netfilter/nf_conntrack_common.h| 2 +-
include/linux/netfilter/nf_conntrack_h323.h | 14 +--
include/linux/netfilter/nf_conntrack_proto_gre.h
clare automatic/local variables in a block.
Signed-off-by: Joe Perches
---
include/linux/net.h| 82
include/linux/skbuff.h | 250 ++---
2 files changed, 148 insertions(+), 184 deletions(-)
diff --git a/include/linux/net.h b/include/linux/
clare automatic/local variables in a block.
Signed-off-by: Joe Perches
---
include/linux/etherdevice.h | 35 ++--
include/linux/fcdevice.h| 2 +-
include/linux/fddidevice.h | 7 +-
include/linux/hippidevice.h | 10 +-
include/linux/inetdevice.h | 28 +--
include/linux/netdevice.h
M: Jes Sorensen
L: linux-hi...@sunsite.dk
The list appears dead.
Are you doing any work on this or should this
be set to Orphan.
HIPPI
S: Orphan
F: include/linux/hippidevice.h
F: include/uapi/linux/if_hippi.h
F: net/802/hippi.c
F: drivers/net/hippi/
--
To uns
On Fri, 2013-09-27 at 13:23 +0200, Peter Zijlstra wrote:
> checkpatch.pl should really warn about that; and it appears there
> code in there for that; however:
>
> # grep -C3 smp_mb scripts/checkpatch.pl
[]
> # check for memory barriers without a comment.
> if ($line =~
> /\b(mb|
On Fri, 2013-09-27 at 15:48 +0200, Peter Zijlstra wrote:
> On Fri, Sep 27, 2013 at 06:44:55AM -0700, Joe Perches wrote:
> > It's a CHK test, so it's only tested with --strict
> >
> > $ scripts/checkpatch.pl -f --strict kernel/mutex.c 2>&1 | grep memory
>
e the patch context
block.
And checkpatch is still stupid, it only looks for existence
of any comment, not at the comment content.
Suggested-by: Peter Zijlstra
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sc
On Fri, 2013-09-27 at 16:26 +0200, Peter Zijlstra wrote:
> On Fri, Sep 27, 2013 at 07:14:17AM -0700, Joe Perches wrote:
> > Peter Zijlstra prefers that comments be required near uses
> > of memory barriers.
> >
> > Change the message level for memory barrier uses from
On Fri, 2013-09-27 at 09:22 -0400, Prarit Bhargava wrote:
> I'm proposing with this patch to do something similar to the WARN()
> mechanism that is currently implemented in the kernel. This
> patchset introduces FW_INFO() and FW_INFO_DEV() which logs output
My first thought was "how ugly".
There
On Fri, 2013-09-27 at 19:05 +1000, Stephen Rothwell wrote:
> Hi all,
>
> Heads up: I will be having a 3 week break leading up to the kernel
> summit. This means that next-20130927 (today) will be the last
> linux-next release until next-20131028 (or maybe 29). I presume that
> Linus will be up t
On Fri, 2013-09-27 at 09:49 -0700, Sudeep Dutt wrote:
> These patches address code review feedback received on the
> patch series @ https://lkml.org/lkml/2013/9/5/561 ,from:
> a) Greg Kroah-Hartman on sysfs and header file cleanups.
> b) Joe Perches on issues found by "--s
On Mon, 2013-09-30 at 15:23 +0200, Bartlomiej Zolnierkiewicz wrote:
> __initdata tag should be placed between the variable name and equal
> sign for the variable to be placed in the intended .init.data section.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -4275,6 +4275,12
clare automatic/local variables in a block.
Signed-off-by: Joe Perches
---
include/net/dst.h | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/include/net/dst.h b/include/net/dst.h
index 3bc4865..211dcf1 100644
--- a/include/net/dst.h
+++ b/include/net/
clare automatic/local variables in a block.
Signed-off-by: Joe Perches
---
include/net/garp.h | 27 +--
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/include/net/garp.h b/include/net/garp.h
index 834d8ad..abf33bb 100644
--- a/include/net/garp.h
+++ b/include/net/g
On Fri, 2013-09-20 at 14:49 -0400, David Miller wrote:
> Series applied, thanks Joe.
I've got 36 more of these.
How many do you want, how often?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
401 - 500 of 10416 matches
Mail list logo
