On Wed, 2013-10-09 at 13:00 +0900, Sangjung Woo wrote: > In order to be free automatically and make the cleanup paths more > simple, use devm_kzalloc() instead of kzalloc(). [] > diff --git a/drivers/rtc/rtc-pl030.c b/drivers/rtc/rtc-pl030.c [] > @@ -106,7 +106,7 @@ static int pl030_probe(struct amba_device *dev, const > struct amba_id *id) > if (ret) > goto err_req; > > - rtc = kmalloc(sizeof(*rtc), GFP_KERNEL); > + rtc = devm_kzalloc(&dev->dev, sizeof(*rtc), GFP_KERNEL);
You're not deleting a memset and you're converting a kmalloc. Why do you need the zalloc version? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
