On Mon, 2012-11-05 at 14:11 +0100, Greg Kroah-Hartman wrote:
> On Mon, Nov 05, 2012 at 08:34:42PM +0900, YAMANE Toshiaki wrote:
> > fixed below checkpatch warnings.
> > - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then
> > pr_err(... to printk(KERN_ERR ...
> > - WARNING: Prefer
On Mon, 2012-11-05 at 16:22 +0100, Greg Kroah-Hartman wrote:
> On Mon, Nov 05, 2012 at 07:11:11AM -0800, Joe Perches wrote:
> > On Mon, 2012-11-05 at 14:11 +0100, Greg Kroah-Hartman wrote:
> > > On Mon, Nov 05, 2012 at 08:34:42PM +0900, YAMANE Toshiaki wrote:
> > &g
On Thu, 2012-07-26 at 19:29 +0530, Jeffrin Jose wrote:
> Fixed coding style issue relating to switch and case
> statement in file net/appletalk/ddp.c
Don't just move the case labels, move the code blocks
including comments.
> diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
[]
> @@ -1798,7
On Thu, 2012-07-26 at 03:08 -0600, Paul Walmsley wrote:
> On Wed, 13 Jun 2012, Joe Perches wrote:
> > Parenthesis alignment doesn't correctly check an existing line
> > after an inserted or modified line with an open parenthesis.
[]
> This fixes some bogus checkpatch wa
On Thu, 2012-07-26 at 15:37 -0600, Bjorn Helgaas wrote:
> PNP0C01:00: new device for \_SB_.PCI0.ISA_.MBIO
>
> I fiddled with this a while ago; it would look something like this:
[]
> +static noinline_for_stack
> +char *acpi_name_string(char *buf, char *end, acpi_handle handle,
> +
On Thu, 2012-07-26 at 15:50 -0600, Bjorn Helgaas wrote:
> On Thu, Jul 26, 2012 at 3:43 PM, Joe Perches wrote:
> > On Thu, 2012-07-26 at 15:37 -0600, Bjorn Helgaas wrote:
> >> PNP0C01:00: new device for \_SB_.PCI0.ISA_.MBIO
> >>
> >> I fiddled with this
On Fri, 2012-07-27 at 08:49 +0900, Toshiaki Yamane wrote:
> Now checkpatch clean.
[]
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c
> b/drivers/staging/olpc_dcon/olpc_dcon.c
[]
> @@ -11,6 +11,7 @@
[]
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
[]
> @@ -71,18 +72,18 @@ static int dcon_hw_i
On Fri, 2012-07-27 at 13:46 +0900, Toshiaki Yamane wrote:
> fixed some checkpatch warnings.
> (Excluding -WARNING: msleep < 20ms can sleep for up to 20ms-)
[]
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c
> b/drivers/staging/olpc_dcon/olpc_dcon.c
[]
> @@ -71,18 +72,18 @@ static int dcon_hw_
ev_printk and
eliminate call to dev_printk to remove another recursion via %pV
Signed-off-by: Joe Perches
---
drivers/base/core.c | 57 +++
include/linux/device.h| 11 +++-
include/linux/netdevice.h |3 --
lib/dyn
On Sat, 2012-07-28 at 16:15 +0530, Jeffrin Jose wrote:
> Fixed coding style issues relating to indentation found in
> net/appletalkddp.c."git diff -w" is empty and the compiled objects
> are the same too.
Hello Jeffrin.
Your commit message is OK but your patch not.
The switch/case that could use
On Sat, 2012-07-28 at 19:45 +0800, Fengguang Wu wrote:
> FD_RAW_NEED_DISK | FD_RAW_NEED_DISK
That's a pretty old defect from kernel 1.1 days.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Sat, 2012-07-28 at 17:06 +0200, Philipp Kern wrote:
> ip6_xmit checks if the outgoing packet is larger than the path MTU and
> emits ICMPv6 packet too big locally if this is the case. Logging this,
> even at KERN_DEBUG, confuses users. It is also not actually helpful for
> debugging, given that
On Tue, 2012-09-25 at 15:13 +0300, Andy Shevchenko wrote:
> Signed-off-by: Andy Shevchenko
You also added yourself as a maintainer.
Congrats/sympathies, etc...
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -6007,10 +6007,13 @@ F:drivers/tty/serial
>
> SYNOPSYS DESIGNWARE DMAC DRIVER
>
On Tue, 2012-09-25 at 16:37 +0300, Andy Shevchenko wrote:
> On Tue, 2012-09-25 at 06:19 -0700, Joe Perches wrote:
> > You also added yourself as a maintainer.
> > Congrats/sympathies, etc...
> Actually I prefer to be just a supporter, because I introduce few
> addit
Also add __printf() verification for format string.
Reported-by: Geert Uytterhoeven
Signed-off-by: Joe Perches
---
include/linux/device.h | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/include/linux/device.h b/include/linux/device.h
index 8873603..86ef6ab
On Wed, 2012-09-26 at 12:09 +0200, Paul Bolle wrote:
> When fast calibration of the TSC fails an error is printed:
> tsc: Fast TSC calibration failed
[]
> 1) By the way, it's debatable whether this message should be printed at
> informational or at notice level. But the difference between KERN_
On Wed, 2012-09-26 at 20:31 +0530, Kishon Vijay Abraham I wrote:
> The PHY framework provides a set of API's for the PHY drivers to
> create/destroy a PHY and API's
Just some trivial notes.
> diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
[]
> @@ -0,0 +1,445 @@
[]
> +static void de
On Fri, 2012-10-26 at 02:30 +0800, Fengguang Wu wrote:
> Hi Joe,
>
> FYI, kernel build failed on
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/misc
> head: 334a57560cf08a04f530aa5546b4c9379c622544
> commit: f23a277e64d8173e8cddd9e1903c3f9a564aaae5 [1/2] PCI: Conv
When the previous line is not a line continuation and the
current line has a line continuation but is not a #define,
emit a warning.
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b
dev_ create smaller objects than dev_printk(KERN_.
Convert non-debug calls to this form.
Joe Perches (16):
tile: Convert dev_printk(KERN_ to dev_(
ata: Convert dev_printk(KERN_ to dev_(
drivers: base: Convert dev_printk(KERN_ to dev_(
block: Convert dev_printk(KERN_ to dev_(
pcmcia
dev_ calls take less code than dev_printk(KERN_
and reducing object size is good.
Coalesce formats for easier grep.
Signed-off-by: Joe Perches
---
arch/tile/kernel/pci_gx.c | 15 ++-
1 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/arch/tile/kernel/pci_gx.c b/arch
dev_ calls take less code than dev_printk(KERN_
and reducing object size is good.
Coalesce formats for easier grep.
Signed-off-by: Joe Perches
---
drivers/ata/pata_cmd64x.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ata/pata_cmd64x.c b/drivers/ata
dev_ calls take less code than dev_printk(KERN_
and reducing object size is good.
Signed-off-by: Joe Perches
---
drivers/base/attribute_container.c |2 +-
drivers/base/devres.c |4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/base
dev_ calls take less code than dev_printk(KERN_
and reducing object size is good.
Signed-off-by: Joe Perches
---
drivers/block/umem.c | 97 +++---
1 files changed, 45 insertions(+), 52 deletions(-)
diff --git a/drivers/block/umem.c b/drivers/block
dev_ calls take less code than dev_printk(KERN_
and reducing object size is good.
Coalesce formats for easier grep.
Add missing newline.
Signed-off-by: Joe Perches
---
drivers/char/pcmcia/cm4040_cs.c |5 +-
drivers/pcmcia/cistpl.c | 10 ++---
drivers/pcmcia/cs.c
dev_ calls take less code than dev_printk(KERN_
and reducing object size is good.
Coalesce formats for easier grep.
Signed-off-by: Joe Perches
---
drivers/dma/at_hdmac_regs.h |8 +++---
drivers/dma/iop-adma.c | 45 +++
drivers/dma/mv_xor.c| 62
dev_ calls take less code than dev_printk(KERN_
and reducing object size is good.
Coalesce multiline formats for easier grep.
Coalesce unnecessarily segmented formats on a single line too.
Remove trailing space after newline in a format.
Signed-off-by: Joe Perches
---
drivers/gpu/drm/gma500
dev_ calls take less code than dev_printk(KERN_
and reducing object size is good.
Coalesce formats for easier grep.
Signed-off-by: Joe Perches
---
drivers/i2c/busses/i2c-piix4.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers
dev_ calls take less code than dev_printk(KERN_
and reducing object size is good.
Coalesce formats for easier grep.
Signed-off-by: Joe Perches
---
drivers/net/wireless/at76c50x-usb.c | 85 ++---
drivers/net/wireless/iwlegacy/common.h|5 +-
drivers/net
dev_ calls take less code than dev_printk(KERN_
and reducing object size is good.
Coalesce formats for easier grep.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/chelsio/cxgb3/common.h |7 +++
drivers/net/ethernet/marvell/pxa168_eth.c |7 +++
2 files changed, 6
dev_ calls take less code than dev_printk(KERN_
and reducing object size is good.
Coalesce formats for easier grep.
Signed-off-by: Joe Perches
---
drivers/pci/irq.c | 10 +-
drivers/pci/pci-stub.c |2 +-
drivers/pci/pcie/aspm.c |7 ++-
3 files changed, 8 insertions
dev_ calls take less code than dev_printk(KERN_
and reducing object size is good.
Coalesce formats for easier grep.
Signed-off-by: Joe Perches
---
drivers/scsi/53c700.c|2 +-
drivers/scsi/aic7xxx/aic79xx_osm_pci.c |4 +-
drivers/scsi/aic7xxx/aic7xxx_osm_pci.c
dev_ calls take less code than dev_printk(KERN_
and reducing object size is good.
Convert if (printk_ratelimit()) dev_printk to dev__ratelimited.
Signed-off-by: Joe Perches
---
drivers/virtio/virtio_balloon.c |7 +++
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers
dev_ calls take less code than dev_printk(KERN_
and reducing object size is good.
Signed-off-by: Joe Perches
---
drivers/watchdog/mpcore_wdt.c | 19 +--
1 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/watchdog/mpcore_wdt.c b/drivers/watchdog
dev_ calls take less code than dev_printk(KERN_
and reducing object size is good.
Coalesce multiline formats for easier grep.
Coalesce segmented single line formats too.
Signed-off-by: Joe Perches
---
sound/pci/asihpi/hpidspcd.c | 22 +-
sound/pci/asihpi/hpioctl.c | 17
dev_ calls take less code than dev_printk(KERN_
and reducing object size is good.
Signed-off-by: Joe Perches
---
drivers/usb/core/hub.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 5b131b6..fbaf3c3 100644
--- a
These printks should all be emitted at KERN_DEBUG level.
Make them dependent on CONFIG_DEBUG or (#define DEBUG)
simplify the code a bit.
Add missing newlines where appropriate.
Most all of these messages could be deleted too.
Signed-off-by: Joe Perches
---
drivers/tty/serial/jsm/jsm.h
On Sun, 2012-10-28 at 14:54 +0400, Sergei Shtylyov wrote:
> Hello.
Hi Sergei.
> On 28-10-2012 12:05, Joe Perches wrote:
>
> > dev_ create smaller objects than dev_printk(KERN_.
> > Convert non-debug calls to this form.
>
> > Joe Perches (16):
> >ti
On Tue, 2012-10-30 at 12:02 +0800, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/misc
> head: 347593eb10fce5b691551d72cf63f1ea6a533f2a
> commit: 545974a28f786eb0ed42c90b4b5df9605b1d824c [1/4] PCI: Convert
> pci_resource_ macros to static inl
On Mon, 2013-08-26 at 10:14 +0800, liujunliang_ljl wrote:
> do you need me to merge the patch and re-send it again.
I do not.
> And which version of kernel will release this driver.
No idea.
That's up to David Miller or Greg KH to pick
up the driver and maybe take the follow-on
patch I sent.
I
On Mon, 2013-08-26 at 19:02 +0300, Dan Carpenter wrote:
> On Mon, Aug 26, 2013 at 05:10:04PM +0200, Iker Pedrosa wrote:
[]
> > diff --git a/drivers/staging/winbond/phy_calibration.c
> > b/drivers/staging/winbond/phy_calibration.c
[]
> > @@ -1233,8 +1233,10 @@ u8 _rx_iq_calibration_loop_winbond(str
On Mon, 2013-08-26 at 16:31 -0400, David Miller wrote:
> From: Enrico Mioso
[]
> > + int ret = 0;
> > + struct usbnet *usbnet_dev = usb_get_intfdata(intf);
> > + struct huawei_cdc_ncm_state *drvstate = (void *)&usbnet_dev->data;
> > + struct cdc_ncm_ctx *ctx = drvstate->ctx;
> > +
On Mon, 2013-08-26 at 16:58 -0400, David Miller wrote:
> From: Joe Perches
> Date: Mon, 26 Aug 2013 13:45:13 -0700
>
> > I think the premise of local variable
> > declaration by line length is flawed.
>
> I disagree.
>
> > It can't work when local vari
On Mon, 2013-08-26 at 17:09 -0400, David Miller wrote:
> From: Joe Perches
[]
> Don't try to over-simplify things and act as if they are black
> and white when they aren't.
It wasn't me simplifying.
I commented on your request to:
"order local function variable
__GFP_ZERO instead.
Trivially reduces the size of the existing uses of
dma_zalloc_coherent.
Realign arguments as appropriate.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/aeroflex/greth.c | 12 -
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 6 ++---
drivers/net
On Tue, 2013-08-27 at 01:39 -0400, Mike Frysinger wrote:
> On Thursday 25 July 2013 14:53:25 Joe Perches wrote:
> > Using 0x%# emits 0x0x. Only one is necessary.
>
> sounds like a job for checkpatch.pl :)
Here. Submit it yourself...
---
scripts/checkpatch.pl | 12
On Tue, 2013-08-27 at 17:47 +0300, Dmitry Kasatkin wrote:
> When DEBUG is defined, dev_dbg_ratelimited uses dynamic debug data
> structures even when CONFIG_DYNAMIC_DEBUG is not defined.
> It leads to build break.
> For example, when I try to use dev_dbg_ratelimited in USB code and
> CONFIG_USB_DEB
On Tue, 2013-08-27 at 13:32 -0400, Jason Baron wrote:
> On 08/27/2013 12:20 PM, Joe Perches wrote:
> > On Tue, 2013-08-27 at 17:47 +0300, Dmitry Kasatkin wrote:
> >> When DEBUG is defined, dev_dbg_ratelimited uses dynamic debug data
> >> structures even when CONFIG_D
On Tue, 2013-08-27 at 22:01 +0100, Imededdine Aimene Bounab wrote:
> Fixed a coding style issue.
Hi Imededdine.
Just some simple notes.
Your subject line doesn't match the patch and
you are doing more than a single brace change.
There are lots of whitespace changes.
Maybe multiple patches for
milar patch was suggested by Andi Kleen
https://lkml.org/lkml/2013/8/5/648
Suggested-by: Jean Delvare
Signed-off-by: Joe Perches
Tested-by: Guenter Roeck
---
scripts/checkpatch.pl | 47 ++-
1 file changed, 46 insertions(+), 1 deletion(-)
diff --git a/script
On Wed, 2013-08-28 at 20:29 +0200, Mischa Jonker wrote:
> Make sure that usecs is casted to long long, to ensure that the
> (usecs * 4295 * HZ) multiplication is 64 bit.
>
> Initially, the (usecs * 4295 * HZ) part was done as a 32 bit
> multiplication, with the result casted to 64 bit. This led to
On Wed, 2013-08-28 at 12:24 -0600, Tim Gardner wrote:
> Drop a couple of ifdef/endif pairs by moving the ifdef
> surrounding neigh_app_ns() to the interior of neigh_app_ns().
[]
> This is an admittedly trivial change. I stumbled on it while trying to figure
> out why Ubuntu doesn't have CONFIG_ARPD
On Wed, 2013-08-28 at 18:53 +, Mischa Jonker wrote:
> > > Make sure that usecs is casted to long long, to ensure that the (usecs
> > > * 4295 * HZ) multiplication is 64 bit.
> > >
> > > Initially, the (usecs * 4295 * HZ) part was done as a 32 bit
> > > multiplication, with the result casted to
On Wed, 2013-08-28 at 13:09 -0600, Tim Gardner wrote:
> On 08/28/2013 12:51 PM, Joe Perches wrote:
> > On Wed, 2013-08-28 at 12:24 -0600, Tim Gardner wrote:
> >> Drop a couple of ifdef/endif pairs by moving the ifdef
> >> surrounding neigh_app_ns() to t
On Wed, 2013-08-28 at 19:12 +, Mischa Jonker wrote:
> Hello Joe,
>
> > I don't see the loops_per_jiffy initial shift << 32.
>
> loops_per_jiffy * HZ = loops_per_second
> loops_per_jiffy * HZ = 1,000,000 * loops_per_us
> loops_per_jiffy * HZ * 4295 = 4,295,000 * loops_per_us
>
> loops_per_jif
On Thu, 2013-08-29 at 12:55 +0800, 黃清隆 wrote:
> Update the patch code.
This patch is whitespace damaged.
Please send the email to yourself and make sure it applies
correctly before resending to the lists.
If necessary, read Documentation/email-clients.txt
cheers, Joe
--
To unsubscribe from thi
On Thu, 2013-08-29 at 05:55 +, Vineet Gupta wrote:
> The intent of writing orig code was to generate only 1 MPYHU insn (32*32 =
> high-part-64) for the whole math, at any optimization level whatsoever. If the
> first MPY is overflowing, u r likely spinning for > 10,000 usec (10ms) which
> is
On Thu, 2013-08-29 at 06:24 +, Vineet Gupta wrote:
> On 08/29/2013 11:31 AM, Joe Perches wrote:
> > I think the whole thing is odd and it should simply be
> >
> > loops = loops_per_jiffy * usecs_to_jiffies(usecs)
[]
> On the topic of multiply vs. divide (which pro
On Thu, 2013-08-29 at 11:47 +0800, Ching wrote:
> From: Ching
>
> Support Areca new SATA Raid Adapter ARC1214/1224/1264/1284
> Modify maximum outstanding command number.
> Notify command complete with auto request sense data.
> Fix bug of updating adapter firmware through ioctl(ARCHTTP) interface
On Tue, 2013-10-01 at 12:29 +, OS Engineering wrote:
> From 6ff5102b3cd8047bb4bfb4d0165f289249e23bbe Mon Sep 17 00:00:00 2001
> From: rchinthekindi
> Date: Tue, 1 Oct 2013 17:49:58 +0530
> Subject: [PATCH 2/2] skd: Restricted pr_debug() lines to 80 characters
>
> Restricted pr_debug() lines t
On Tue, 2013-10-01 at 21:39 -0400, Mathieu Rhéaume wrote:
> Fixed a lot of warnings from checkpatch.pl about the 80 characters per line
> limitation.
I'd prefer
s/binder_user_error/binder_user_err/
or
s/binder_user_error/binder_err/
without doing the strange wrapping
checkpatch
Convert the memset/memcpy uses of 6 to ETH_ALEN
where appropriate.
Also convert some struct definitions and u8 array
declarations of [6] to ETH_ALEN.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/8390/ax88796.c| 2 +-
drivers/net/ethernet/amd/atarilance.c
On Tue, 2013-10-01 at 21:57 -0400, Mathieu Rhéaume wrote:
> This patch changes seq_printf for seq_puts in binder.c.
> It fixes the warnings emitted by checkpatch.pl.
Please realign function argument to the open parenthesis.
> diff --git a/drivers/staging/android/binder.c
> b/drivers/staging/andr
On Tue, 2013-10-01 at 23:57 -0400, Mathieu Rhéaume wrote:
> Changes since v2:
> * Fixed the indent problems (2 tab and 1 space) by Joe Perches.
> * Found more calls to convert from seq_printf to seq_puts
[]
> diff --git a/drivers/staging/android/binder.c
> b/drivers/staging/a
On Wed, 2013-10-02 at 01:02 -0400, Mathieu Rhéaume wrote:
> Changes since v2:
> * Fixed the indent in the method calls that had too many tab.
>
> >8--8<
>
> This patch changes seq_printf for seq_puts in binder.c.
> It fixes the warnings emitted
On Wed, 2013-10-02 at 15:15 +1000, Ryan Mallon wrote:
> On 02/10/13 11:57, Mathieu Rhéaume wrote:
> > This patch changes seq_printf for seq_puts in binder.c.
> > It fixes the warnings emitted by checkpatch.pl.
[]
> Umm, this won't compile. seq_puts() is defined as:
>
> int seq_puts(struct seq_fi
On Wed, 2013-10-02 at 14:06 +0200, Andi Shyti wrote:
> > +# $ scripts/checkpatch.pl WHATEVER > /tmpcheckpatch.log
>^^
> I guess you have a typo here.
>
> I actually used this, it doesn't know what msleep is and it
> fails, so that to go ahead I had to re
On Wed, 2013-10-02 at 17:35 +0200, Michal Simek wrote:
> This new fpga subsystem core should unify all fpga drivers/managers which
> do the same things. Load configuration data to fpga or another programmable
> logic through common interface. It doesn't matter if it is MMIO device,
> gpio bitbangin
On Thu, 2013-10-03 at 10:09 +, Ramprasad Chinthekindi wrote:
> > -Original Message-
> > On Tue, 2013-10-01 at 12:25 +, OS Engineering wrote:
> > > Hi Jens,
> > > I'm sending a patch to replace custom debug macros with pr_debug().
> > Kindly please review the patch.
> > > Thanking yo
On Fri, 2013-10-04 at 09:36 -0700, Srinivas Pandruvada wrote:
> The Intel Running Average Power Limit(RAPL) technology provides platform
> software with the ability to monitor, control, and get notifications on
> power usage.
[]
> diff --git a/drivers/powercap/Makefile b/drivers/powercap/Makefile
[
On Fri, 2013-10-04 at 13:12 -0700, Jacob Pan wrote:
> On Fri, 04 Oct 2013 11:07:45 -0700
> Joe Perches wrote:
>
> > On Fri, 2013-10-04 at 09:36 -0700, Srinivas Pandruvada wrote:
> > > The Intel Running Average Power Limit(RAPL) technology provides
> > > plat
On Sat, 2013-10-05 at 23:19 +0800, Chen Gang wrote:
> Theoretically, the maximize size of "%d" or "%u" is 11 (10 + '\0'), so
> need set MAX_NAMELEN 11 instead of 10.
%d can be negative.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord.
On Sat, 2013-10-05 at 18:02 +0200, Matthias Beyer wrote:
> - removing spaces before array indexing (foo [] to foo[])
[]
> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
[]
> @@ -93,7 +93,7 @@ EXPORT_SYMBOL_GPL (usb_bus_list);
> /* used when allocating bus numbers */
> #define USB_MA
On Sat, 2013-10-05 at 11:04 -0700, Joe Perches wrote:
> On Sat, 2013-10-05 at 18:02 +0200, Matthias Beyer wrote:
> > - removing spaces before array indexing (foo [] to foo[])
> []
> > diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> []
> > @@ -93,7
On Sat, 2013-10-05 at 11:43 -0700, Josh Triplett wrote:
> Kernel maintainers reject new instances of the GPL boilerplate paragraph
> directing people to write to the FSF for a copy of the GPL, since the
> FSF has moved in the past and may do so again.
[]
> diff --git a/scripts/checkpatch.pl b/scrip
On Sat, 2013-10-05 at 23:27 -0700, Greg Kroah-Hartman wrote:
> On Sat, Oct 05, 2013 at 11:51:48AM -0700, Joe Perches wrote:
> > On Sat, 2013-10-05 at 11:43 -0700, Josh Triplett wrote:
> > > Kernel maintainers reject new instances of the GPL boilerplate paragraph
> > > d
It's only set once so mark it __read_mostly.
Neaten the alignment so it matches the rest of the
pr__once #defines too.
Signed-off-by: Joe Perches
---
include/linux/printk.h | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/include/linux/printk.h b/in
On Sun, 2013-10-06 at 13:38 -0600, Jason Gunthorpe wrote:
> This is preparation for making the tpm module multi-file. kbuild does
> not like having a .c file with the same name as a module. We wish to
> keep the tpm module name so that userspace doesn't see this change.
If that's true, and I don't
On Sun, 2013-10-06 at 14:18 -0700, Josh Triplett wrote:
> On Sat, Oct 05, 2013 at 11:27:39PM -0700, Greg Kroah-Hartman wrote:
> > On Sat, Oct 05, 2013 at 11:51:48AM -0700, Joe Perches wrote:
> > > On Sat, 2013-10-05 at 11:43 -0700, Josh Triplett wrote:
> > > >
On Sun, 2013-10-06 at 14:33 -0700, Josh Triplett wrote:
> On Sun, Oct 06, 2013 at 02:27:17PM -0700, Joe Perches wrote:
> > On Sun, 2013-10-06 at 14:18 -0700, Josh Triplett wrote:
> > > On Sat, Oct 05, 2013 at 11:27:39PM -0700, Greg Kroah-Hartman wrote:
> > > > On S
On Sun, 2013-10-06 at 14:48 -0700, Josh Triplett wrote:
> There are two common approaches to breaking long lines at binary
> operators: breaking the line before the operator (putting the operator
> at the start of the next line), or breaking the line after the operator
> (putting the operator at th
t; Make this an error for new code, but just a --strict CHK in --file mode;
> anyone interested in doing tree-wide cleanups of this form can enable
> this test explicitly.
>
> Signed-off-by: Josh Triplett
> ---
>
> v2: Make this a CHK in --file mode, using a code pattern suggested
On Mon, 2013-10-07 at 14:56 +0800, ZHAO Gang wrote:
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
[]
> @@ -378,7 +378,7 @@ typedef enum gro_result gro_result_t;
> * RX_HANDLER_EXACT. The skb will only be delivered to protocol handlers that
> * are registered on exact devi
On Mon, 2013-07-08 at 18:10 +0100, Alasdair G Kergon wrote:
> On Tue, Jul 02, 2013 at 05:01:47PM +0200, Yann Droneaud wrote:
> > This patch changes type of dm-de...@redhat.com
> > The output of ./scripts/get_maintainer.pl is
> > modified to report dm-de...@redhat.com as a list:
>
> > DEVICE-MAPP
On Mon, 2013-07-08 at 20:51 -0700, Wedson Almeida Filho wrote:
> On Sat, Jul 6, 2013 at 9:59 PM, Joe Perches wrote:
> >
> > Not correct.
> >
> >> while (start < end) {
> >> - size_t mid = start + (end - start) / 2;
> &g
On Tue, 2013-07-09 at 17:43 +0200, Jean Delvare wrote:
> Add const to all DMI string pointers where this is possible. This
> fixes a checkpatch warning.
That's a nice little improvement.
> +++ linux-3.10-rc0/drivers/firmware/dmi_scan.c2013-05-04
> 11:20:52.808187924 +0200
[]
> @@ -252,7
On Tue, 2013-07-09 at 17:42 +0200, Jean Delvare wrote:
> Fix all errors and trivial warnings reported by checkpatch for file
> drivers/firmware/dmi_scan.c.
trivia:
> +++ linux-3.11-rc0/drivers/firmware/dmi_scan.c2013-07-09
> 16:08:13.979592957 +0200
> @@ -63,7 +63,7 @@ static char * __in
x86/ia64 have a slight mismatch in dmi_alloc as
x86 does a memset(0), and ia64 just does kmalloc.
Make the ia64 dmi_alloc match the x86 style.
Signed-off-by: Joe Perches
---
arch/ia64/include/asm/dmi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/ia64/include/asm
even more trivial...
On Wed, 2013-07-10 at 14:47 +0200, Jean Delvare wrote:
> +++ linux-3.11-rc0/drivers/firmware/dmi_scan.c2013-07-10
> 14:11:56.544792703 +0200
> @@ -62,8 +62,6 @@ static const char * __init dmi_string(co
> str = dmi_alloc(len);
> if (str != NULL)
[]
> @@ -21
On Wed, 2013-07-10 at 14:28 +0200, Jean Delvare wrote:
> Hi Joe,
hi Jean.
> Le Tuesday 09 July 2013 à 09:19 -0700, Joe Perches a écrit :
> > On Tue, 2013-07-09 at 17:42 +0200, Jean Delvare wrote:
[]
> > If the function name is used in every printk, it might
> > be b
On Wed, 2013-07-10 at 18:17 +0200, Jean Delvare wrote:
> Le Wednesday 10 July 2013 à 07:51 -0700, Joe Perches a écrit :
> > even more trivial...
[]
> > It'd also be nice to use the same test style
> > in all 6 uses.
> >
> > if (!foo)
>
> B
On Wed, 2013-07-10 at 19:27 +0100, John Stultz wrote:
> I've been doing a bad job at managing the drivers/clocksource directory,
> so Daniel has been helping with review and patch queuing for the clocksource
> and clockevent drivers, so add him formally to the MAINTAINERS list.
>
> Cc: Daniel Lezc
On Wed, 2013-07-10 at 23:31 +0200, Jiri Kosina wrote:
> Introduce a method for run-time instrucntion patching on a live SMP kernel
> based on int3 breakpoint, completely avoiding the need for stop_machine().
Yet more trivia:
instruction typo
> The way this is achieved:
>
> - add a int3
He must be too, umm, busy to update his own bouncing
email address too.
Signed-off-by: Joe Perches
---
poke - prod...
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index e51d018..3c81917 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
On Thu, 2013-07-11 at 22:26 +0200, Jiri Kosina wrote:
> Introduce a method for run-time instrucntion patching on a live SMP kernel
Some of the typos anyway.
s/instrunction/instruction
[]
> v2 -> v3:
> + fixed few typos (Joe Perches)
[]
> + /* we are not interested in
Documentation shouldn't be executable.
Signed-off-by: Joe Perches
---
diff --git a/Documentation/devicetree/bindings/mfd/tps6507x.txt
b/Documentation/devicetree/bindings/mfd/tps6507x.txt
old mode 100755
new mode 100644
--
To unsubscribe from this list: send the line "unsubscribe li
On Fri, 2013-07-12 at 17:58 -0700, Darren Hart wrote:
> The MinnowBoard uses an AR803x PHY with the PCH GBE which requires
> special handling. Use the MinnowBoard PCI Subsystem ID to detect this
> and add a pci_device_id.driver_data structure and functions to handle
> platform setup.
trivial comme
On Sat, 2013-07-13 at 14:20 +0530, Prabhakar Lad wrote:
> Use the dev_* message logging API instead of raw printk.
[]
> diff --git a/drivers/media/platform/davinci/vpbe.c
> b/drivers/media/platform/davinci/vpbe.c
[]
> @@ -735,7 +735,7 @@ static int vpbe_initialize(struct device *dev, struct
> vpb
seq_vprintf, seq_printf and seq_puts are logging functions
and should be allowed to exceed the maximium line length.
Add maximum line length exceptions for these functions.
Also, suggesting seq_printf conversions to seq_puts
should be tested for arguments after the format.
Signed-off-by: Joe
On Fri, 2013-09-13 at 16:03 -0700, Kees Cook wrote:
> On Fri, Sep 13, 2013 at 3:27 PM, Joe Perches wrote:
> > On Fri, 2013-09-13 at 15:53 -0400, George Spelvin wrote:
> >> > Maybe WARN_ONCE so it's easier to emit the format too.
> >>
> >> Good idea.
201 - 300 of 10416 matches
Mail list logo
