On Thu, 2013-07-11 at 22:26 +0200, Jiri Kosina wrote: > Introduce a method for run-time instrucntion patching on a live SMP kernel
Some of the typos anyway. s/instrunction/instruction [] > v2 -> v3: > + fixed few typos (Joe Perches) [] > + /* we are not interested in non-int3 faults and ring > 0 faults */ > + if (val != DIE_INT3 || !args->regs || user_mode_vm(args->regs) > + || (unsigned long) bp_int3_addr != args->regs->ip) > + return NOTIFY_DONE; > + > + /* set up the specified breakpoint handler */ > + args->regs->ip = (unsigned long) bp_int3_handler; Still think the test and set should be in the same order. > +/* > + * text_poke_bp() -- update instructions on live kernel on SMP > + * @addr: address to patch > + * @opcode: opcode of new instruction > + * @len: length to copy > + * @handler: address to jump to when the temporary breakpoint is hit > + * This sure looks like kernel-doc but misses the leading /** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
