etch changes up to ac8672419217a49c966d2458498c082d2572cf27:
staging: vt6655: Whitespace cleanups (2013-02-28 13:48:42 -0800)
------------
Joe Perches (1):
staging: vt6655: Whitespace cleanups
drivers/staging/vt6655/80211hdr.h|
On Mon, 2013-02-18 at 20:13 -0800, Simon Glass wrote:
> On Sat, Feb 16, 2013 at 12:49 PM, Dmitry Torokhov
> > On Fri, Feb 15, 2013 at 08:16:12PM -0800, Simon Glass wrote:
> >> + for (row = 0; row < ckdev->rows; row++) {
> >> + if (cros_ec_keyb_row_has_ghosting(ckdev, buf, row))
> >>
On Tue, 2013-02-19 at 10:48 -0600, Philip J. Kelleher wrote:
> From: Philip J Kelleher
>
> This patch include a few driver fixes for the IBM RamSan 70/80 driver.
trivial comments:
> diff -uprN -X linux-block-vanilla/Documentation/dontdiff
> linux-block-vanilla/drivers/block/rsxx/config.c
> li
On Tue, 2013-01-08 at 21:33 +0100, Jiri Kosina wrote:
> On Mon, 7 Jan 2013, Joe Perches wrote:
>
> > > Remove the somewhat awkward uses of print_symbol and convert all the
> > > existing uses to a new vsprintf pointer type of %pSR.
> >
> > Jiri? Are you goin
)
Avoid this interleaving error messages.
Signed-off-by: Joe Perches
---
drivers/acpi/sleep.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
index 6d3a06a..2421303 100644
--- a/drivers/acpi/sleep.c
+++ b/drivers
Add the ClearPage/SetPage/TestClearPage/TestSetPage
variants to the not reported Page CamelCase variables.
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 747bcd7
On Fri, 2013-02-22 at 17:01 -0500, Peter Hurley wrote:
> I didn't bother to mention it before, but since your addressing mm
> CamelCase exceptions, perhaps
>
> _
> xx_XXX_xxx
> XXX_xxx
>
> could be exceptions as well?
Maybe the check should only be for "[A-Z][a-z]|[a-z][A-Z]"
to ma
dOn Fri, 2013-02-22 at 15:57 -0700, Shuah Khan wrote:
> What are the guidelines on camelcase warnings on patches. A recent one
> I ran into is on a variable in a structure and fixing it would require
> changing the original variable.
The same as all other checkpatch warnings.
Ignore the ones you d
On Tue, 2013-03-12 at 09:27 +, James Bottomley wrote:
> On Tue, 2013-03-12 at 13:25 +0800, Zhang Yanfei wrote:
> > remove cast for kmalloc/kzalloc return value.
>
> I've got to ask why? Just because void * can be assigned to any pointer
> doesn't mean we should religiously eliminate all casts
On Tue, 2013-03-12 at 20:30 +0200, Silviu-Mihai Popescu wrote:
> Use resource_size() instead of explicit calculation. This was found via
> make coccicheck.
[]
> diff --git a/drivers/net/ethernet/nxp/lpc_eth.c
> b/drivers/net/ethernet/nxp/lpc_eth.c
[]
> @@ -1421,7 +1421,7 @@ static int lpc_eth_drv_
On Tue, 2013-03-12 at 15:44 -0700, Joe Perches wrote:
> The cERROR macro is always used as cERROR(1, and cifserror
> is just a printk(KERN_ERR "CIFS VFS: ".
>
> Make a cifs_vfs_err function that uses the vsprintf %pV
> extension to avoid duplicating the "CIFS VFS: &q
On Wed, 2013-03-13 at 07:51 -0400, Jeff Layton wrote:
> On Wed, 13 Mar 2013 04:36:54 -0700
> Joe Perches wrote:
> > Perhaps a better idea than this patch is to
> > change both the cERROR and cFYI macros to
> > a new use of cifs_dbg(type, fmt, ...)
> >
> > cER
On Thu, 2013-03-14 at 13:30 +, David Woodhouse wrote:
> If krealloc() returns NULL, it *doesn't* free the original. So any code
> of the form 'foo = krealloc(foo, …);' is almost certainly a bug.
So add a check for it to checkpatch.
Signed-off-by: Joe Perches
---
scri
.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/aeroflex/greth.c | 20 ---
drivers/net/ethernet/amd/sunlance.c| 5 ++-
drivers/net/ethernet/apple/macmace.c | 16 -
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 2 --
drivers
On Fri, 2013-03-15 at 08:35 -0400, David Miller wrote:
> From: Kirill Kapranov
> Date: Thu, 14 Mar 2013 14:40:52 +0400
>
> > @@ -867,7 +821,6 @@ void phy_state_machine(struct work_struct *work)
> > netif_carrier_on(phydev->attached_dev);
> > } e
Signed-off-by: Joe Perches
---
drivers/net/ethernet/aeroflex/greth.c | 8 ++--
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 8
drivers/net/ethernet/broadcom/bnx2.c | 5 ++---
drivers/net/ethernet/broadcom/bnx2x/bnx2x.h| 9 +++--
drivers
On Fri, 2013-03-15 at 15:16 -0500, Steve French wrote:
> I would like to merge the three we have (one still has to be put in
> for-next - the one from Jeff) for for-next in the next three or fouir
> days - but I can create another temporary branch for the ones for 3.10
> - but ... I would like to
On Fri, 2013-03-15 at 22:51 +, Abodunrin, Akeem G wrote:
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On
> Behalf Of Joe Perches
[]
> Reduce the number of calls required to alloc a zeroed block of memory.
[]
> diff --gi
appropriately.
The actual function definition for seq_printf must now
be enclosed in parenthesis to avoid further macro expansion.
Signed-off-by: Joe Perches
---
fs/seq_file.c| 7 ++-
include/linux/seq_file.h | 24
2 files changed, 30 insertions(+), 1 deletion(
On Sat, 2013-03-16 at 11:57 -0400, Steven Rostedt wrote:
> My macro nastiness is contagious ;-)
True.
> On Sat, 2013-03-16 at 06:50 -0700, Joe Perches wrote:
> > +int (seq_printf)(struct seq_file *m, const char *f, ...)
>
> That's rather ugly. Why not just #undef seq_pr
On Sat, 2013-03-16 at 09:43 -0600, Bjorn Helgaas wrote:
> Checkpatch could look for additions of seq_printf() with constant formats.
Suggested-by: Bjorn Helgaas
Signed-off-by: Joe Perches
---
I don't know what perl version introduced $-[0] and $+[0]
so this may not work with ol
On Sat, 2013-03-16 at 09:43 -0600, Bjorn Helgaas wrote:
> On Sat, Mar 16, 2013 at 7:50 AM, Joe Perches wrote:
> > Instead of converting the 800 or so uses of seq_printf with
> > a constant format (without a % substitution) to seq_puts,
> > maybe there's another way
On Thu, 2012-08-30 at 13:19 +0800, gang@intel.com wrote:
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> INTEL(R) TRUSTED EXECUTION TECHNOLOGY (TXT)
[]
> -T: Mercurial http://www.bughost.org/repos.hg/tboot.hg
> +T: Mercurial http://tboot.hg.sourceforge.net:8000/hgroot/tboot/tboot
Perhaps th
On Thu, 2012-08-30 at 11:43 -0600, Jim Cromie wrote:
> On Sun, Aug 26, 2012 at 5:25 AM, Joe Perches wrote:
> > The recent commit to fix dynamic_debug was a bit unclean.
> > Neaten the style for dynamic_debug.
> > Reduce the stack use of message logging that uses netdev_p
On Fri, 2012-08-31 at 23:18 +1000, Cruz Julian Bishop wrote:
> This patch allows for much easier implementation of arguments
> when modifying checkincludes.pl
>
> The variable $file is also initially named $arg - I wasn't sure
> if memory would be a problem (I know it would be in Java/C#) if
> ano
On Sat, 2012-09-01 at 20:35 +0530, devendra.aaru wrote:
> Hello,
> This is a very big patch. It will be difficult for reviewers to review.
Hello, this is a carelessly large reply quoting all 100K of
the original patch for your three sentences. Don't do that.
Thanks
--
To unsubscribe from this
While breaking up what I think is the overly large printk.c,
this non-dependency between CONFIG_PRINTK and CONFIG_EARLY_PRINTK
showed up.
Perhaps CONFIG_EARLY_PRINTK should be marked "depends on" PRINTK.
Uncompiled, untested.
---
arch/alpha/Kconfig.debug |2 +-
arch/arm/Kconfig.debug
On Mon, 2012-09-10 at 19:52 -0700, Greg KH wrote:
> On Tue, Sep 11, 2012 at 04:50:15AM +0200, Bruce Humphrey wrote:
> > Change 5 instances of printk(KERN_INFO, KERN_WARN and KERN_ERROR for the
> > prefered pr_info, pr_warn and pr_error
[]
> > diff --git a/drivers/staging/comedi/drivers/fl512.c
>
On Mon, 2012-09-10 at 20:44 -0700, Greg KH wrote:
> On Mon, Sep 10, 2012 at 08:40:11PM -0700, Joe Perches wrote:
> > On Mon, 2012-09-10 at 19:52 -0700, Greg KH wrote:
> > > On Tue, Sep 11, 2012 at 04:50:15AM +0200, Bruce Humphrey wrote:
> > > > Change 5 instances of p
brace.
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index ca05ba2..e1f4390 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -421,7 +421,7 @
s put the trailing */ on a separate line
#12: FILE: net/t.c:12:
+ * bar */
total: 0 errors, 2 warnings, 12 lines checked
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/sc
The block comment style in net/ and drivers/net is non-standard.
Document it.
Signed-off-by: Joe Perches
---
> This conflicts with the preferred style for long (multi-line) comments
> documented in
> ./Documentation/CodingStyle. If this is the way comments should be done in
> the
On Wed, 2012-09-12 at 03:43 +0530, raghu.prabh...@gmail.com wrote:
> Ratelimited printk will be useful in printing xfs messages which are otherwise
> not required to be printed always due to their high rate (to prevent kernel
> ring
> buffer from overflowing), while at the same time required to be
3 and older:
Sep 9 10:43:01 x kernel: DENY in: IN=eth0 OUT= MAC..
commit 04d2c8c83d0
("printk: convert the format for KERN_ to a 2 byte pattern")
updated the syslog header style but did not update netfilter uses.
Do so.
Signed-off-by: Joe Perches
cc: auto75914...@hushmail.com
3 and older:
Sep 9 10:43:01 x kernel: DENY in: IN=eth0 OUT= MAC..
commit 04d2c8c83d0
("printk: convert the format for KERN_ to a 2 byte pattern")
updated the syslog header style but did not update netfilter uses.
Do so.
Signed-off-by: Joe Perches
cc: auto75914...@hushmail.co
On Thu, 2012-09-06 at 13:53 -0400, Jason Baron wrote:
> On Thu, Sep 06, 2012 at 09:13:59AM -0700, Greg Kroah-Hartman wrote:
> > Jason, any ACK on these, or any of the other random dynamic debug
> > patches floating around? What am I supposed to be applying here?
[]
> I just posted some follow up c
ynamic_emit_prefix
o Call create_syslog_header and printk_emit
o Whitespace neatening
Signed-off-by: Joe Perches
Acked-by: David S. Miller
Tested-by: Jim Cromie
Acked-by: Jason Baron
---
drivers/base/core.c| 64 +--
include/linux/device.h |8 ++
. Duplicate the logic
and form of dev_printk instead.
Make __netdev_printk static.
Remove EXPORT_SYMBOL(__netdev_printk)
Whitespace and brace style neatening.
Signed-off-by: Joe Perches
Acked-by: David S. Miller
Tested-by: Jim Cromie
Acked-by: Jason Baron
---
include/linux/netdevice.h |3
:00.0: eth0: Link is up at 100 Mbps, full duplex, flow control
both
new: sky2 :02:00.0 eth0: Link is up at 100 Mbps, full duplex, flow control
both
Signed-off-by: Joe Perches
Acked-by: David S. Miller
Tested-by: Jim Cromie
Acked-by: Jason Baron
---
lib/dynamic_debug.c |2 +-
net/core
Add utility functions to consolidate the use of
create_syslog_header and vprintk_emit.
This allows conversion of logging functions that
call create_syslog_header and then call vprintk_emit
or printk_emit to the dev_ equivalents.
Signed-off-by: Joe Perches
Acked-by: David S. Miller
Tested-by
Convert direct calls of vprintk_emit and printk_emit to the
dev_ equivalents.
Make create_syslog_header static.
Signed-off-by: Joe Perches
Acked-by: David S. Miller
Tested-by: Jim Cromie
Acked-by: Jason Baron
---
drivers/base/core.c| 14 +-
include/linux/device.h |2
On Thu, 2012-09-13 at 20:49 +0300, Dan Carpenter wrote:
> On Thu, Sep 13, 2012 at 08:43:12PM +0300, Dan Carpenter wrote:
> > On Wed, Sep 12, 2012 at 02:55:29PM +0200, Samuel Iglesias Gonsalvez wrote:
> > > From: Jens Taprogge
> > >
> > > This way interrupt handling becomes independent of the chan
On Thu, 2012-09-13 at 22:17 +0300, Dan Carpenter wrote:
> If it weren't in staging-next then, yeah, it probably would have
> been better to resend those two patches. You could send them by
> themselves without resending any of the others. But once they hit
> staging-next, it's too late.
>
> No
On Thu, 2012-09-13 at 21:49 +0200, Thomas Petazzoni wrote:
> Instead of using a temporary buffer, snprintf() and kstrdup(), just
> use kasprintf() that does the same thing in just oneline.
>
> Signed-off-by: Thomas Petazzoni
> ---
> drivers/pinctrl/pinmux.c |5 +
> 1 file changed, 1 inse
On Tue, 2012-10-02 at 15:13 +0200, Peter Senna Tschudin wrote:
> On Tue, Oct 2, 2012 at 3:08 PM, Ezequiel Garcia wrote:
> > Just looking through media list I can spot lots of different subject
> > schemes:
> > [media] foo: fix some bug
> > media: foo: fix some bug
> > foo: fix some bug
> >
On Wed, 2012-10-03 at 11:14 -0400, Steven Rostedt wrote:
> I first check
> the MAINTAINERS file. If the subsystem I'm working on exists there, I
> only email those that are listed there, including any mailing lists that
> are mentioned (as well as LKML). If it's not listed, I then do a git log
> an
On Wed, 2012-10-03 at 20:32 -0400, Steven Rostedt wrote:
> On Wed, 2012-10-03 at 08:38 -0700, Joe Perches wrote:
> > On Wed, 2012-10-03 at 11:14 -0400, Steven Rostedt wrote:
> > > I first check
> > > the MAINTAINERS file. If the subsystem I'm working on exists ther
On Thu, 2012-10-04 at 11:02 -0500, Nathan Zimmer wrote:
> At many of our customer sites the log level is set to KERN_DEBUG. It
> helps avoid reboots due to operator impatience. Machines this large
> take significantly longer then typical to boot and seeing the extra
> messages reassures them th
On Thu, 2012-10-04 at 14:54 -0400, David Miller wrote:
> From: Peter Senna Tschudin
> > On Thu, Oct 4, 2012 at 8:23 PM, David Miller wrote:
> >> We want to know the implications of the bug being fixed.
> >> Does it potentially cause an OOPS? Bad reference counting and thus
> >> potential leaks o
On Fri, 2012-10-05 at 07:22 +0200, Julia Lawall wrote:
> A tool was used to find a potential problem, and then Peter
> studied the code to see what fix was appropriate.
Hi Julia.
Was it true that a static analysis tool found the original
potential issue? If so, what tool was it?
But wasn't the
On Fri, 2012-10-05 at 08:55 -0500, Nathan Zimmer wrote:
> On 10/04/2012 11:37 AM, Joe Perches wrote:
> > On Thu, 2012-10-04 at 11:02 -0500, Nathan Zimmer wrote:
> >> At many of our customer sites the log level is set to KERN_DEBUG. It
> >> helps avoid reboots due to ope
On Fri, 2012-10-05 at 09:16 -0600, Bjorn Helgaas wrote:
> On Fri, Oct 5, 2012 at 8:54 AM, Nathan Zimmer wrote:
> > On 10/05/2012 09:14 AM, Joe Perches wrote:
> >> On Fri, 2012-10-05 at 08:55 -0500, Nathan Zimmer wrote:
> >>> On 10/04/2012 11:37 AM, Joe Perches wrote
On Fri, 2012-10-05 at 13:17 +0200, Jiri Slaby wrote:
> CCing Joe.
[]
> > I'll let Jiri handle this :). It's his patch anyway.
>
> Actually this is Joe's version of the patch. Joe, people started hitting
> the bug [1]. Could you resend your patch?
> [1] https://patchwork.kernel.org/patch/1339221/
On Tue, 2012-10-23 at 14:42 +1100, Stephen Rothwell wrote:
> Hi Andrew,
>
> After merging the akpm tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> kernel/printk/printk_syslog.c: In function 'printk_syslog_print':
> kernel/printk/printk_syslog.c:108:3: error: impli
On Tue, 2012-10-23 at 21:41 +0800, Ming Lei wrote:
> If CONFIG_A11Y_BRAILLE_CONSOLE is not enabled, _braille_console_setup()
> should return NULL to parse the parameter further in console_setup().
>
> This patch fixes the broken 'console' kernel parameter, which makes the
> Pandaboard not boot wit
On Tue, 2012-10-23 at 12:44 -0700, Andrew Morton wrote:
> On Tue, 23 Oct 2012 14:42:21 +1100
> Stephen Rothwell wrote:
>
> > Hi Andrew,
> >
> > After merging the akpm tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> >
> > kernel/printk/printk_syslog.c: In functio
On Tue, 2012-10-23 at 11:44 -0700, Andrey Smirnov wrote:
> This patch adds all necessary header files and Kbuild plumbing for the
> core driver for Silicon Laboratories Si476x series of AM/FM tuner
> chips.
[]
> +#ifdef DEBUG
> +#define DBG_BUFFER(device, header, buffer, bcount)
On Wed, 2012-10-24 at 04:00 -0700, Jeff Kirsher wrote:
> With the recent commit to checkpatch.pl:
>
> commit 058806007450489bb8f457b275e5cb5c946320c1
> Author: Joe Perches
> Date: Thu Oct 4 17:13:35 2012 -0700
>
> checkpatch: check networking specific block comm
On Wed, 2012-10-24 at 19:58 +0800, hongbo.zhang wrote:
> This patch adds device tree properties for ST-Ericsson DB8500 thermal driver,
> also adds the platform data to support the old fashion.
Just a trivial note:
> diff --git a/arch/arm/mach-ux500/board-mop500.c
> b/arch/arm/mach-ux500/board-mo
On Mon, 2012-10-22 at 18:22 -0700, Randy Dunlap wrote:
> on i386, when CONFIG_PRINTK is not enabled:
>
> note: some of these build errors could result from my use of
> -sik (keep going, ignore build errors).
>
>
> case 1. CONFIG_TTY_PRINTK=y, CONFIG_EARLY_PRINTK=y
>
> see config-r8272
[]
>
On Tue, 2012-10-23 at 13:02 -0700, Andrew Morton wrote:
> On Tue, 23 Oct 2012 12:51:29 -0700
> Joe Perches wrote:
>
> > > btw, what's up with printk_syslog.h? It includes two header files which
> > > it
> > > doesn't need but fails to include
On Wed, 2012-10-24 at 13:51 -0700, Jeff Kirsher wrote:
> On Wed, 2012-10-24 at 07:12 -0700, Joe Perches wrote:
> > On Wed, 2012-10-24 at 04:00 -0700, Jeff Kirsher wrote:
> > > With the recent commit to checkpatch.pl:
> > >
> > > commit 058806007450489bb8f457
On Wed, 2012-10-24 at 18:12 -0600, Stephen Warren wrote:
> On 10/17/2012 12:06 AM, Joe Perches wrote:
> > Create files with prototypes and static inlines for braille
> > support. Make braille_console functions return 1 on success.
>
> Joe,
>
> Between next-20121022 an
Braille console support
devkmsg.c /dev/kmsg support
kmsg_dump.c kmsg_dump support
Changes from v1:
Fix braille.h: _braille_console_setup return value
Remove duplicated #define
Add missing #include
Joe Perches (23):
printk: Move to separate directory
Make it easier to break up printk into bite-sized chunks.
Remove printk path/filename from comment.
Signed-off-by: Joe Perches
---
kernel/Makefile |3 ++-
kernel/printk/Makefile |1 +
kernel/{ => printk}/printk.c |2 --
3 files changed, 3 insertions(+)
Add an include file for the console_cmdline struct
so that the braille console driver can be separated.
Signed-off-by: Joe Perches
---
kernel/printk/console_cmdline.h | 14 ++
kernel/printk/printk.c | 13 -
2 files changed, 18 insertions(+), 9 deletions
cc: Samuel Thibault
cc: Ming Lei
Signed-off-by: Joe Perches
---
drivers/accessibility/braille/braille_console.c |9 +++-
kernel/printk/Makefile |1 +
kernel/printk/braille.c | 48 +++
kernel/printk/braille.h
Make the code a bit more compact by always using a pointer
for the active console_cmdline.
Move overly indented code to correct indent level.
Signed-off-by: Joe Perches
---
kernel/printk/printk.c | 49 +--
1 files changed, 26 insertions(+), 23
Rename the struct to enable moving portions of
printk.c to separate files.
The rename changes output of /proc/vmcoreinfo.
Signed-off-by: Joe Perches
---
kernel/printk/printk.c | 80
1 files changed, 40 insertions(+), 40 deletions(-)
diff
Make these generic names more specific to the printk
subsystem and allow these variables to become non-static.
Rename log_buf to printk_log_buf.
Rename __LOG_BUF_LEN define to __PRINTK_LOG_BUF_LEN.
Signed-off-by: Joe Perches
---
kernel/printk/printk.c | 76
.
Signed-off-by: Joe Perches
---
kernel/printk/printk.c | 150
1 files changed, 75 insertions(+), 75 deletions(-)
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index c45afb1..602a1ab 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk
printk_log_store.
Signed-off-by: Joe Perches
---
kernel/printk/printk.c | 100
1 files changed, 50 insertions(+), 50 deletions(-)
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 602a1ab..992c064 100644
--- a/kernel/printk
Make this generic enum more specific to the printk subsystem.
Signed-off-by: Joe Perches
---
kernel/printk/printk.c | 32 +---
1 files changed, 17 insertions(+), 15 deletions(-)
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 992c064..341f2d9
Make this generic name more specific to the printk
subsystem and allow it to become non-static.
Signed-off-by: Joe Perches
---
kernel/printk/printk.c | 102
1 files changed, 51 insertions(+), 51 deletions(-)
diff --git a/kernel/printk/printk.c
Make these variables more specific to the printk log subsystem
adding prefix printk_log_. This allows them to become non-static.
Signed-off-by: Joe Perches
---
kernel/printk/printk.c | 34 +-
1 files changed, 17 insertions(+), 17 deletions(-)
diff --git a
Allow a separation of functions and variables into
multiple files.
Signed-off-by: Joe Perches
---
kernel/printk/printk.c | 46 +++---
1 files changed, 23 insertions(+), 23 deletions(-)
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index
Make the #define more specific to the printk subsystem.
Signed-off-by: Joe Perches
---
kernel/printk/printk.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 0134b2e..bc0b4ed 100644
--- a/kernel/printk
Create a header file for printk_log functions and variables.
Signed-off-by: Joe Perches
---
kernel/printk/printk.c | 91 +--
kernel/printk/printk_log.h | 115
2 files changed, 116 insertions(+), 90 deletions
Move print_log variables and functions into a separate file.
Signed-off-by: Joe Perches
---
kernel/printk/Makefile |1 +
kernel/printk/printk.c | 128 -
kernel/printk/printk_log.c | 149
3 files
Move the variable to the .h file too.
Signed-off-by: Joe Perches
---
kernel/printk/printk_log.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kernel/printk/printk_log.h b/kernel/printk/printk_log.h
index 0327f8d..e846f1d 100644
--- a/kernel/printk/printk_log.h
+++ b
Rename the LOG_LINE_MAX and PREFIX_MAX #defines with PRINTK_ prefixes.
Move the defines to printk_log.h
Remove duplicate define too.
Fixed redefined PRINTK_LOG_LINE_MAX and PRINTK_PREFIX_MAX.
Reported-by: Yuanhan Liu
Signed-off-by: Joe Perches
---
kernel/printk/printk.c | 22
Move the devkmsg_ functions and kmsg_fops declaration
to devkmsg.c.
Add devkmsg.o to Makefile.
Signed-off-by: Joe Perches
---
kernel/printk/Makefile |1 +
kernel/printk/devkmsg.c | 309 +++
kernel/printk/printk.c | 296
Make these static functions global and prefix them with printk_.
Create declarations for these functions in printk_log.h
Signed-off-by: Joe Perches
---
kernel/printk/printk.c | 43 ---
kernel/printk/printk_log.h |4
2 files changed, 28
Move these functions to printk_log.
Move the static function print_prefix too.
Add "#include " to printk_log.c.
Signed-off-by: Joe Perches
---
kernel/printk/printk.c | 112 ---
kernel/printk/printk_lo
Move syslog functions to a separate file.
Add compilation unit to Makefile.
Add missing #include
Reported-by: Yuanhan Liu
Signed-off-by: Joe Perches
---
kernel/printk/Makefile|1 +
kernel/printk/printk.c| 351 +
kernel/printk
Generic restructuring.
Create kmsg_dump.c, add to Makefile and remove from printk.c
Signed-off-by: Joe Perches
---
kernel/printk/Makefile|1 +
kernel/printk/kmsg_dump.c | 328 +
kernel/printk/printk.c| 318
Make this generic variable more specific to the printk
subsystem to allow this variable to be used without
a specific extern.
Also update fs/proc/kmsg.c as it uses log_wait.
Signed-off-by: Joe Perches
---
fs/proc/kmsg.c |4 ++--
kernel/printk/printk.c | 12 ++--
2 files
On Tue, 2008-02-12 at 23:04 -0800, David Miller wrote:
> > In the big "linux-next" series of emails, David Miller suggested that
> > the feature-removal-schedule file be broken up into little pieces, as it
> > is causing merge problems for different trees.
I suggest the same for MAINTAINERS
I'd p
On Wed, 2008-02-13 at 08:59 -0800, Greg KH wrote:
> > I suggest the same for MAINTAINERS
> Why, is it a merge problem for you?
$ git-log --pretty=oneline --name-only | \
grep -vP "[a-fA-F0-9]{40,40}\s" | sort | uniq -c | sort -rbn
541 MAINTAINERS
506 kernel/sched.c
374 drivers/scsi/l
On Thu, 2008-02-14 at 23:56 +, Ben Dooks wrote:
> On Thu, Feb 14, 2008 at 01:53:15PM -0800, Harvey Harrison wrote:
> > In C, signed 1-bit bitfields can only take the values 0 and -1, only
> > 0 and 1 are ever assigned in current code. Make them unsigned
> > bitfields.
> >
> > Fixes the (repea
The kernel doesn't use decimals though.
Joe Perches (3):
checkpatch: Find hex constants as a single IDENT
checkpatch: Add support for decimal constants
checkpatch: Emit a warning when decimal values are used
scripts/checkpatch.pl | 10 +-
1 files changed, 9 insertions(
: Joe Perches
---
scripts/checkpatch.pl |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f18750e..099a0ad 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -227,7 +227,7 @@ our $Inline = qr{inline
Even though the kernel doesn't support using decimal constants,
add a regex for them.
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 099a0ad..3e727c5 100755
Linux kernel doesn't like decimals, say so.
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 3e727c5..3339ecf 100755
--- a/scripts/checkpatch.pl
+++ b/sc
vpr_info_dq should be a function and vpr_info should have
a do {} while (0)
Add missing newlines to pr_s.
Miscellaneous neatening too.
braces, coalescing formats, alignments, etc...
Signed-off-by: Joe Perches
---
lib/dynamic_debug.c | 118
The kernel doesn't support them though.
v2: Make it clearer that checkpatch understands floating point constants
Support floating point hex constants too
Joe Perches (3):
checkpatch: Find hex constants as a single IDENT
checkpatch: Add support for floating point constants
check
: Joe Perches
---
scripts/checkpatch.pl |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f18750e..099a0ad 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -227,7 +227,7 @@ our $Inline = qr{inline
Even though the kernel doesn't support using floating point constants,
add a regex for them.
Support forms like: 0x123p1, 123e-1, 1.23, 1.5e23f
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/sc
Linux kernel doesn't like floating point, say so.
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index c3a2162..96685c6 100755
--- a/scripts/checkpatch.pl
On Fri, 2012-11-02 at 11:14 +0300, Dan Carpenter wrote:
> On Fri, Nov 02, 2012 at 12:36:30AM -0700, Kumar amit mehta wrote:
> > On Fri, Nov 02, 2012 at 09:55:55AM +0300, Dan Carpenter wrote:
> > > On Thu, Nov 01, 2012 at 11:42:59PM -0700, Kumar Amit Mehta wrote:
> > > > fix for macro coding style.
101 - 200 of 10416 matches
Mail list logo
