[PATCH 01/14] perf tool: Introduce perf_hpp__list for period related columns

2012-11-28 Thread Jiri Olsa
data for multiple files. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Namhyung Kim --- tools/perf/builtin-diff.c | 21 - tools/perf/builtin-report.c| 1 + tools/pe

[PATCH 04/14] perf diff: Remove displacement from struct hist_entry_diff

2012-11-28 Thread Jiri Olsa
Removing displacement from struct hist_entry_diff, because it's not used. Displacement is not used for sorting, so there's no reason to pre-calculate it. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey A

[PATCH 02/14] perf tool: Add struct perf_hpp_fmt into hpp callbacks

2012-11-28 Thread Jiri Olsa
Adding 'struct perf_hpp_fmt' into hpp callbacks, so commands can access their private data. It'll be handy for diff command in future to be able to access file related data for each column. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo M

[PATCH 09/14] perf diff: Update perf diff documentation for multiple data comparison

2012-11-28 Thread Jiri Olsa
Updating perf diff documentation to include multiple perf data files comparison. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Namhyung Kim --- tools/perf/Documentation/perf

[PATCH 11/14] perf diff: Making compute functions static

2012-11-28 Thread Jiri Olsa
All compute functions are now local to the diff command, making them static. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Namhyung Kim --- tools/perf/builtin-diff.c | 24

[PATCH 12/14] perf diff: Display data file info ahead of the diff output

2012-11-28 Thread Jiri Olsa
Data files are referenced through the index of the file on the command line. Adding list of data files for each index to ease up navigation. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker

[PATCH 14/14] perf diff: Add generic order option for compute sorting

2012-11-28 Thread Jiri Olsa
Adding option 'o' to allow sorting based on the input file number. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Namhyung Kim --- tools/perf/Documentation/perf-dif

[PATCH 08/14] perf diff: Change diff command to work over multiple data files

2012-11-28 Thread Jiri Olsa
erates the A (baseline) data and display B and C data (symbol samples) only if they found in A (baseline) All other standard diff command computation features (delta,ratio,wdiff) stays. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Ma

[PATCH 13/14] perf diff: Display zero calculation results

2012-11-28 Thread Jiri Olsa
Forcing zero calculation outputs to appear in final output, so we can differ between zero output calculation result and empty space for missing pair of baseline hist_entry. Also skipping the compute and period output for dummy entries. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc

[PATCH 03/14] perf tool: Fix period symbol_conf.field_sep display

2012-11-28 Thread Jiri Olsa
Currently we don't properly display hist data with symbol_conf.field_sep separator. We need to display either space or separator. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecke

[PATCH 05/14] perf diff: Change compute methods to work with pair directly

2012-11-28 Thread Jiri Olsa
Changing compute methods to operate over hist entry and its pair directly. This makes the code more obvious and readable, instead of all time checking for pair being != NULL. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey

[PATCH 10/14] perf tool: Centralize default columns init in perf_hpp__init

2012-11-28 Thread Jiri Olsa
Now when diff command is separated from other standard outputs, we can use perf_hpp__init to initialize all standard columns. Moving PERF_HPP__OVERHEAD column init back to perf_hpp__init, and removing extra enable calls. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra

[PATCH 06/14] perf diff: Change formula methods to work with pair directly

2012-11-28 Thread Jiri Olsa
Changing formula methods to operate over hist entry and its pair directly. This makes the code more obvious and readable, instead of all time checking for pair being != NULL. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey

[PATCH 07/14] perf diff: Add callback to hists__match/hists__link functions

2012-11-28 Thread Jiri Olsa
It's possible different users of hists__match/hists__link will need specific processing of matching hists_entry data. Adding callback to hists__match/hists__link functions to allow that. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc:

[PATCH/RFC 00/14] perf, tool: Fix endian issues

2012-11-28 Thread Jiri Olsa
hi, adding support to display diff for more than 2 perf.data files. Sending as RFC, since the change touches lot of hists code, so I might be breaking something I missed.. still testing. Also it could colide with Namhyung changes for group report wrt patches 7 and 8, where I changed the linking of

Re: [PATCH/RFC 00/14] perf, diff: Support for multiple files

2012-11-28 Thread Jiri Olsa
aargh.. fixed subject.. copy&paste error ;-) also patches are available here: git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/linux.git perf/multi2 thanks, jirka On Wed, Nov 28, 2012 at 02:52:35PM +0100, Jiri Olsa wrote: > hi, > adding support to display diff for more than 2

Re: [PATCH v3 04/19] perf, core: Add a concept of a weightened sample

2012-11-28 Thread Jiri Olsa
On Wed, Nov 21, 2012 at 01:49:30PM +0100, Stephane Eranian wrote: > From: Andi Kleen SNIP > index 4f63c05..c52caab 100644 > --- a/include/uapi/linux/perf_event.h > +++ b/include/uapi/linux/perf_event.h > @@ -132,8 +132,10 @@ enum perf_event_sample_format { > PERF_SAMPLE_BRANCH_STACK

Re: [PATCH 25/32] tools, perf: Add a precise event qualifier

2012-11-28 Thread Jiri Olsa
On Fri, Nov 09, 2012 at 05:27:41PM -0800, Andi Kleen wrote: > From: Andi Kleen > > Add a precise qualifier, like cpu/event=0x3c,precise=1/ > > This is needed so that the kernel can request enabling PEBS > for TSX events. The parser bails out on any sysfs parse errors, > so this is needed in any

Re: [PATCH 31/32] perf, tools: Default to cpu// for events v3

2012-11-28 Thread Jiri Olsa
On Fri, Nov 09, 2012 at 05:27:47PM -0800, Andi Kleen wrote: > From: Andi Kleen > > When an event fails to parse and it's not in a new style format, > try to parse it again as a cpu event. > > This allows to use sysfs exported events directly without //, so I can use > > perf record -e tx-aborts

Re: [PATCH/RFC 00/14] perf, diff: Support for multiple files

2012-11-28 Thread Jiri Olsa
On Wed, Nov 28, 2012 at 02:56:55PM +0100, Jiri Olsa wrote: > aargh.. fixed subject.. copy&paste error ;-) > > also patches are available here: > > git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/linux.git > perf/multi2 worked out some fixies with Arnaldo, new

Re: [PATCH 08/14] perf diff: Change diff command to work over multiple data files

2012-11-29 Thread Jiri Olsa
On Thu, Nov 29, 2012 at 08:37:50PM +0900, Namhyung Kim wrote: > On Wed, 28 Nov 2012 14:52:43 +0100, Jiri Olsa wrote: > > Adding diff command the flexibility to specify multiple data > > files on input. If not input file is given the standard behaviour > > stands and diff ins

Re: [PATCH 03/14] perf tool: Fix period symbol_conf.field_sep display

2012-11-29 Thread Jiri Olsa
On Thu, Nov 29, 2012 at 04:56:04PM +0900, Namhyung Kim wrote: > On Wed, 28 Nov 2012 14:52:38 +0100, Jiri Olsa wrote: > > Currently we don't properly display hist data with > > symbol_conf.field_sep separator. We need to display > > either space or separator. > &

Re: [PATCH 09/14] perf diff: Update perf diff documentation for multiple data comparison

2012-11-29 Thread Jiri Olsa
On Thu, Nov 29, 2012 at 08:52:18PM +0900, Namhyung Kim wrote: > On Wed, 28 Nov 2012 14:52:44 +0100, Jiri Olsa wrote: > > +COMPARISON > > +-- > > +The comparison is governed by the baseline file. The baseline perf.data > > +file is iterated for samples. All othe

Re: [PATCH 10/14] perf tool: Centralize default columns init in perf_hpp__init

2012-11-29 Thread Jiri Olsa
On Thu, Nov 29, 2012 at 08:55:47PM +0900, Namhyung Kim wrote: > On Wed, 28 Nov 2012 14:52:45 +0100, Jiri Olsa wrote: > > Now when diff command is separated from other standard outputs, > > we can use perf_hpp__init to initialize all standard columns. > > > > Moving PER

Re: [PATCH 14/14] perf diff: Add generic order option for compute sorting

2012-11-29 Thread Jiri Olsa
On Thu, Nov 29, 2012 at 09:02:01PM +0900, Namhyung Kim wrote: > On Wed, 28 Nov 2012 14:52:49 +0100, Jiri Olsa wrote: > > Adding option 'o' to allow sorting based on the > > input file number. > [snip] > > hist_entry__cmp_compute(struct hist_ent

Re: [PATCH 00/18] perf report: Add support for event group view (v6)

2012-11-29 Thread Jiri Olsa
On Thu, Nov 29, 2012 at 03:38:28PM +0900, Namhyung Kim wrote: > Hi all, > > This is my 6th iteration of event group view patchset. > For basic idea and usage example, please see my original post [1]. > > The largest change in this version is using 'pairs' list of hist_entry > instead of allocatin

Re: [PATCH 01/18] perf evsel: Set leader evsel's ->leader to itself

2012-11-29 Thread Jiri Olsa
self will remove this. > > Suggested-by: Arnaldo Carvalho de Melo > Cc: Jiri Olsa > Cc: Stephane Eranian > Signed-off-by: Namhyung Kim > --- Acked-by: Jiri Olsa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH 02/18] perf evsel: Convert to _is_group_leader method

2012-11-29 Thread Jiri Olsa
#x27;s IMHO somewhat > ambiguous - leader also *is* a member of the group. > > Signed-off-by: Namhyung Kim > --- Acked-by: Jiri Olsa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 03/18] perf tools: Keep group information

2012-11-29 Thread Jiri Olsa
On Thu, Nov 29, 2012 at 03:38:31PM +0900, Namhyung Kim wrote: > From: Namhyung Kim SNIP > --- a/tools/perf/util/evlist.h > +++ b/tools/perf/util/evlist.h > @@ -21,6 +21,7 @@ struct perf_evlist { > struct list_head entries; > struct hlist_head heads[PERF_EVLIST__HLIST_SIZE]; > i

[PATCH] perf hists: Fix period symbol_conf.field_sep display, again

2012-11-29 Thread Jiri Olsa
On Thu, Nov 29, 2012 at 12:53:44PM +0100, Jiri Olsa wrote: > On Thu, Nov 29, 2012 at 04:56:04PM +0900, Namhyung Kim wrote: SNIP > > > - if (!sep || !first) { > > > - ret = scnprintf(hpp->buf, hpp->size, "%s", sep ?: " "

Re: [PATCH 05/18] perf tools: Fix typo on hist__entry_add_pair

2012-11-29 Thread Jiri Olsa
gt; Signed-off-by: Namhyung Kim > --- Acked-by: Jiri Olsa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 03/18] perf tools: Keep group information

2012-11-29 Thread Jiri Olsa
On Thu, Nov 29, 2012 at 11:58:54PM +0900, Namhyung Kim wrote: > 2012-11-29 (목), 15:33 +0100, Jiri Olsa: > > On Thu, Nov 29, 2012 at 03:38:31PM +0900, Namhyung Kim wrote: > > > From: Namhyung Kim > > > > SNIP > > > > > --- a/tools/perf/util/

Re: [PATCHv3] perf: Fix vmalloc ring buffer free function

2013-03-18 Thread Jiri Olsa
On Wed, Mar 13, 2013 at 12:15:57PM +0100, Jiri Olsa wrote: > On Tue, Mar 12, 2013 at 06:04:16PM +0100, Jiri Olsa wrote: > > On Tue, Mar 12, 2013 at 05:24:50PM +0100, Peter Zijlstra wrote: > > > Right you are.. > > > > > > How about something like the

[PATCHv4] perf: Fix vmalloc ring buffer pages handling

2013-03-19 Thread Jiri Olsa
im Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Arnaldo Carvalho de Melo Signed-off-by: Jiri Olsa --- kernel/events/ring_buffer.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/kernel/events/ring_buffer.c b/kernel/events/ring_buffer.c index 23cb34f..27a1af4

Re: [PATCH 1/7] perf: Ensure we do not free event->parent before event

2013-03-20 Thread Jiri Olsa
On Mon, Feb 04, 2013 at 08:02:43PM +0100, Oleg Nesterov wrote: > __perf_event_exit_task() does: > > sync_child_event(event) > free_event(event) > > sync_child_event() does put_event(event->parent) which can actually > free ->parent. This means that event->destroy(event) is called with

Re: [PATCH 1/8] perf tools: Add '.' as part of the event 'name' token

2013-02-03 Thread Jiri Olsa
On Sun, Feb 03, 2013 at 09:37:16PM +0100, Stephane Eranian wrote: > On Tue, Jan 29, 2013 at 9:03 AM, Ingo Molnar wrote: > > > > * Stephane Eranian wrote: > > > >> On Mon, Jan 28, 2013 at 9:52 PM, Stephane Eranian > >> wrote: SNIP > Adding the option for users to link with libpfm4 was no big >

[PATCH 1/2] perf tools: Fix perf_evsel::exclude_GH handling

2013-02-04 Thread Jiri Olsa
Let the perf_evsel::exclude_GH only prevent the reset of exclude_host and exclude_guest attributes in case they were already set. We cannot reset their values to 0, because they might have other defaults set by event_attr_init. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter

[PATCH 0/2] perf tools: Fix GH group modifiers handling

2013-02-04 Thread Jiri Olsa
hi, we were not handling GH group modifiers properly, fixing that plus adding some more tests for this. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Namhyung Kim --- Jiri Olsa (2

[PATCH 2/2] perf tests: Adding automated parsing tests for group :GH modifiers

2013-02-04 Thread Jiri Olsa
cache-misses:H}:uG" Plus fixing test__group2 test. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Namhyung Kim --- tools/perf/tests/parse-events.c | 178 ++

[PATCH 00/11] perf tool: Add PERF_SAMPLE_READ sample read support

2013-02-04 Thread Jiri Olsa
Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Namhyung Kim --- Jiri Olsa (11): perf ui/hist: Add support to display whole group data for raw columns perf: Add PERF_EVENT_IOC_ID ioctl to return event ID perf: Do n

[PATCH 02/11] perf: Add PERF_EVENT_IOC_ID ioctl to return event ID

2013-02-04 Thread Jiri Olsa
e returned for the whole group and there's no way to find out what ID belongs to our fd (if we are not group leader event). Adding a simple ioctl that returns event primary ID for given fd. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Pau

[PATCH 08/11] perf tools: Add PERF_SAMPLE_READ sample related processing

2013-02-04 Thread Jiri Olsa
r). We deliver separated samples for all the values contained within the 'struct sample_read'. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Namhyung Kim --- tools/perf/util

[PATCH 09/11] perf tools: Add 'S' event/group modifier to read sample value

2013-02-04 Thread Jiri Olsa
11.24% 29.19% 1414554 753 ls [kernel.kallsyms] [k] sched_clock_cpu 8.50% 0.35% 1070150 9 ls [kernel.kallsyms] [k] check_chain_key ... Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Ma

[PATCH 11/11] perf tests: Add parse events tests for leader sampling

2013-02-04 Thread Jiri Olsa
Adding 2 more tests to the automated parse events suite for following event config: '{cycles,cache-misses,branch-misses}:S' '{instructions,branch-misses}:Su' Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras C

[PATCH 06/11] perf tools: Fix event ID retrieval for group format read case

2013-02-04 Thread Jiri Olsa
f the read syscall, because we have no guarantee of the event placement within leader kernel sibling list. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Namhyung Kim --- tools

[PATCH 07/11] perf tools: Add perf_evlist__id2sid function to get event ID related data

2013-02-04 Thread Jiri Olsa
Adding perf_evlist__id2sid function to be able to get ID related data. This will be helpful for PERF_FORMAT_GROUP samples where we need to store ID related period value for each event. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras

[PATCH 10/11] perf tests: Add attr record group sampling test

2013-02-04 Thread Jiri Olsa
Adding test to validate perf_event_attr data for command: 'record -e '{cycles,cache-misses}:S' Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Namhyung Kim --- t

[PATCH 05/11] perf tools: Add support for parsing PERF_SAMPLE_READ sample type

2013-02-04 Thread Jiri Olsa
Adding support to parse out the PERF_SAMPLE_READ sample bits. The code contains both single and group format specification. This code parse out and prepare PERF_SAMPLE_READ data into the perf_sample struct. It will be used for group leader sampling feature comming in shortly. Signed-off-by: Jiri

[PATCH 04/11] perf tools: Use PERF_EVENT_IOC_ID perf ioctl to read event id

2013-02-04 Thread Jiri Olsa
PERF_FORMAT_GROUP read format set, where it's impossible to get correct event id out of the read call data. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Namhyung Kim --- tools/perf/util/evl

[PATCH 01/11] perf ui/hist: Add support to display whole group data for raw columns

2013-02-04 Thread Jiri Olsa
2 ls [kernel.kallsyms] [k] intel_pmu_enable_all 0.00% 11.73% 0 331 ls ld-2.14.90.so [.] _dl_cache_libcmp 0.00% 11.06% 0 312 ls [kernel.kallsyms] [k] vma_interval_tree_insert Signed-off-by: Jiri Olsa Cc:

[PATCH 03/11] perf: Do not get values from disabled counters in group format read

2013-02-04 Thread Jiri Olsa
nabled counters for PERF_SAMPLE_READ sample type processing. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Namhyung Kim --- kernel/events/core.c | 3 ++- 1 file changed, 2 insertions

Re: [PATCH 0/2] perf: add new uncore command

2013-02-04 Thread Jiri Olsa
On Fri, Feb 01, 2013 at 05:35:23PM -0800, Andi Kleen wrote: > > And there's a patchset [1] from Jiri to support some kind of formula - > > yeah, now I've written the correct spelling. :) - that might fit to this > > purpose if you provide suitable formula file IMHO. So I guess we don't > > need to

[PATCH 0/2] perf scripts: Fix rwtop script

2013-02-05 Thread Jiri Olsa
r Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Namhyung Kim Cc: Andrew Jones Cc: David Ahern --- Jiri Olsa (2): perf scripts: Fix SIGALRM and pipe read race for rwtop perf scripts: Fix rwtop record script tools/perf/scripts/perl/bin/rwtop-record | 2 +- tools

[PATCH 1/2] perf scripts: Fix SIGALRM and pipe read race for rwtop

2013-02-05 Thread Jiri Olsa
& fix is here: https://lkml.org/lkml/2012/9/18/123 Original-patch-by: Andrew Jones Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Namhyung Kim Cc: Andrew Jones Cc: David A

[PATCH 2/2] perf scripts: Fix rwtop record script

2013-02-05 Thread Jiri Olsa
Adding -D option into the rwtop record command line, to get immediate response when there's event in the buffer. Otherwise we need to wait till half of the buffer is filled, which is the default wattermark if it's not set. Suggested-by: Andrew Jones Signed-off-by: Jiri Olsa C

Re: [PATCH 2/2] perf scripts: Fix rwtop record script

2013-02-06 Thread Jiri Olsa
On Tue, Feb 05, 2013 at 09:15:20AM -0700, David Ahern wrote: > On 2/5/13 9:05 AM, Jiri Olsa wrote: > >Adding -D option into the rwtop record command line, to get > >immediate response when there's event in the buffer. > > Seems like this will dramatically increase CPU

Re: [PATCH 6/9] perf sort: Add 'addr' sort key

2013-04-02 Thread Jiri Olsa
On Tue, Apr 02, 2013 at 11:15:23AM +0900, Namhyung Kim wrote: > On Mon, 1 Apr 2013 22:40:23 +0200, Jiri Olsa wrote: > > On Mon, Apr 01, 2013 at 08:35:22PM +0900, Namhyung Kim wrote: > >> From: Namhyung Kim > >> > >> New addr sort key provides a w

Re: [PATCH 1/8] perf tools: Add '.' as part of the event 'name' token

2013-01-29 Thread Jiri Olsa
On Tue, Jan 29, 2013 at 09:03:05AM +0100, Ingo Molnar wrote: > > * Stephane Eranian wrote: > > > On Mon, Jan 28, 2013 at 9:52 PM, Stephane Eranian > > wrote: > > > Jiri, > > > > > > I don't see part 0/8 of this series. Did you send it to me too? oops, it went to lkml only, here it is: http://

Re: [RFC/PATCH] perf x86: Add off-core event constraints for Sandy/IvyBridge micro architecture

2013-01-29 Thread Jiri Olsa
On Mon, Jan 28, 2013 at 06:49:55PM +0100, Stephane Eranian wrote: > On Sun, Jan 27, 2013 at 6:33 PM, Jiri Olsa wrote: > > hi, > > I was looking at the offcore stuff and it looks like we might > > be missing some constraints for offcore response events on > > Sandy/I

Re: [PATCH] perf tools: fix set event list leader

2013-01-31 Thread Jiri Olsa
e role > of the function to also do this. This is a requirement for an upcoming > patch set. agreed, Acked/Tested-by Jiri Olsa > > Signed-off-by: Stephane Eranian > --- > > diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c > index dc8aee9..050d5bc 100644 &

Re: Mixed group of sw/hw counters are not started if sw counter is group leader

2013-02-01 Thread Jiri Olsa
On Tue, Jan 29, 2013 at 11:56:01AM -0500, Vince Weaver wrote: > On Tue, 29 Jan 2013, Jiri Olsa wrote: > > > ok, there's been perf fixies wrt enable events groups, but they > > landed in 3.8-rc1.. until that point all the group members are > > specifically enable

[PATCH] perf: Fix event group context move

2013-02-01 Thread Jiri Olsa
ich is not what we want at this stage of creating groups. The fix is to initialize event state after removal from sw context. Reported-by: Andreas Hollmann Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Namhyung Kim Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyu

Re: [PATCH] perf tools: Fix build with older versions of bison.

2013-01-24 Thread Jiri Olsa
On Wed, Jan 23, 2013 at 06:58:31PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Nov 13, 2012 at 01:50:07PM -0800, Vinson Lee escreveu: > > This patch fixes this build error with older versions of bison. > > Sorry for leaving this patch unapplied, fell thru the cracks. > > But can you please e

[PATCHv2] tools lib traceevent: Handle dynamic array's element size properly

2013-01-24 Thread Jiri Olsa
eld->elementsize based on the parsed dynamic type. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Steven Rostedt Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra --- tools/lib/traceevent/event-parse.

[PATCH 2/9] perf tools: Add precise object to interface sysfs precise

2013-01-26 Thread Jiri Olsa
not found (supported) -1 if we failed to read the sysfs attribute Signed-off-by: Jiri Olsa Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Arnaldo Carvalho de Melo Cc: Andi Kleen Cc: David Ahern --- tools/per

[PATCH 5/9] perf tools: Read maximal precise value for 'precise' term

2013-01-26 Thread Jiri Olsa
Currently if the term is specified without any value like -e 'cpu/...,precise,../', the number '1' is assigned as its default value. Adding special treatment for 'precise' term to use the maximum allowed precise value in such case using the perf_precise__get funct

[PATCH 4/9] perf tools: Add a precise event qualifier

2013-01-26 Thread Jiri Olsa
Kleen Cc: Jiri Olsa Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Arnaldo Carvalho de Melo Cc: Andi Kleen Cc: David Ahern [ nit: changed subject line a bit] Signed-off-by: Jiri Olsa --- tools/perf/util/parse-events.c

[PATCH 8/9] perf: Document the ABI for 'precise' sysfs attribute

2013-01-26 Thread Jiri Olsa
Adding ABI documentation for newly added 'precise' sysfs attribute. It's added under the testing section. Signed-off-by: Jiri Olsa Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Arnaldo Carvalho de Melo

[PATCH 6/9] perf tools: Favor 'p' modifier before 'precise' term properly

2013-01-26 Thread Jiri Olsa
#x27;p' is specified the precise_ip is set to zero, like: 'cpu/cycles,precise/u' - precise_ip = 0 This patch makes sure that the precise_ip value is overwritten only if any 'p' event modifier is specified, like: 'cpu/cycles,precise/u' - precise_ip = sysfs pr

[PATCH 7/9] perf tests: Add automated precise term test

2013-01-26 Thread Jiri Olsa
Adding automated test for precise term test in event: 'cpu/cycles,precise/' 'cpu/cycles,precise/p' 'cpu/cycles,precise/u' to check proper values of precise_ip driven by sysfs precise attribute. Signed-off-by: Jiri Olsa Cc: Corey Ashford Cc: Frederic W

[PATCH 3/9] perf tests: Add precise event automated test

2013-01-26 Thread Jiri Olsa
The test detects the precise attribute availability and try to open perf event with each allowed precise attribute value. Signed-off-by: Jiri Olsa Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Arnaldo Carvalho de Melo

[PATCH 9/9] perf: Document the ABI for 'rdpmc' sysfs attribute

2013-01-26 Thread Jiri Olsa
Adding ABI documentation for newly added 'rdpmc' sysfs attribute. It's added under the testing section. Signed-off-by: Jiri Olsa Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Arnaldo Carvalho de Melo Cc:

[PATCH 0/9] perf: Adding better precise_ip field handling

2013-01-26 Thread Jiri Olsa
ka Signed-off-by: Jiri Olsa Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Arnaldo Carvalho de Melo Cc: Andi Kleen Cc: David Ahern --- Andi Kleen (1): perf tools: Add a precise event qualifier Jiri Olsa (8):

[PATCH 1/9] perf x86: Add precise sysfs cpu pmu attribute

2013-01-26 Thread Jiri Olsa
or default adding of precise attribute for HW events. Signed-off-by: Jiri Olsa Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Arnaldo Carvalho de Melo Cc: Andi Kleen Cc: David Ahern --- arch/x86/kernel/cpu/perf_ev

Re: [PATCH 0/9] perf: Adding better precise_ip field handling

2013-01-26 Thread Jiri Olsa
On Sat, Jan 26, 2013 at 06:27:46PM +0100, Jiri Olsa wrote: > hi, > adding sysfs attribute to specify the maximum allowed value > for perf_event_attr::precise_ip field. > > Adding functionality for simple 'precise' term to get the > maximum allowed value for perf_

[RFCv2 0/8] perf tools: Add non-architectural event aliases

2013-01-26 Thread Jiri Olsa
: List kernel supplied event aliases in perf list v2 Jiri Olsa (7): perf tools: Add '.' as part of the event 'name' token perf tools: Change perf_pmu__new_alias function interface perf tools: Add name term processing for alias perf tools: Add pmu interfa

[PATCH 1/8] perf tools: Add '.' as part of the event 'name' token

2013-01-26 Thread Jiri Olsa
Adding '.' to be recognized as valid part of the event 'name' token. Upcoming non architectural events use '.' as part of the name. Signed-off-by: Jiri Olsa Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter

[PATCH 6/8] perf tools: Add non arch events for SandyBridge microarchitecture

2013-01-26 Thread Jiri Olsa
Adding non architectural event aliases for SandyBridge micro architecture. Signed-off-by: Jiri Olsa Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Arnaldo Carvalho de Melo Cc: Andi Kleen Cc: Stephane Eranian

[PATCH 8/8] perf tools: List kernel supplied event aliases in perf list v2

2013-01-26 Thread Jiri Olsa
hanges ] Signed-off-by: Jiri Olsa Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Arnaldo Carvalho de Melo Cc: Andi Kleen Cc: Stephane Eranian --- tools/perf/Documentation/perf-list.txt | 4 ++- tools/perf/builtin-list.

[PATCH 4/8] perf tools: Add pmu interface to parse single file of aliases

2013-01-26 Thread Jiri Olsa
,umask=0x1 Signed-off-by: Jiri Olsa Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Arnaldo Carvalho de Melo Cc: Andi Kleen Cc: Stephane Eranian --- tools/perf/util/pmu.c | 23 +++ tools/perf/util/

[PATCH 2/8] perf tools: Change perf_pmu__new_alias function interface

2013-01-26 Thread Jiri Olsa
Changing perf_pmu__new_alias interface not to work directly with FILE object, so it can be reused by other code paths coming in shortly. Signed-off-by: Jiri Olsa Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Arnaldo

[PATCH 7/8] perf tools: Add non arch events for IvyBridge micro architecture

2013-01-26 Thread Jiri Olsa
Adding non architectural event aliases for IvyBridge micro architecture. Signed-off-by: Jiri Olsa Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Arnaldo Carvalho de Melo Cc: Andi Kleen Cc: Stephane Eranian --- tools

[PATCH 3/8] perf tools: Add name term processing for alias

2013-01-26 Thread Jiri Olsa
Adding support for name term being specified within the alias definition and gives the name for the alias. Alias could be now defined like: name=BR_MISP_EXEC.ALL_BRANCHES,event=0x89,umask=0xff It'll be handy for having single file with multiple alias definitions. Signed-off-by: Jiri Ols

[PATCH 5/8] perf tools: Add support to include non architectural event aliases

2013-01-26 Thread Jiri Olsa
Adding support to parse non architectural event aliases for given cpu. These aliases will be provided as single files parsed by pmu_aliases_parse_multi function. Signed-off-by: Jiri Olsa Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter

Re: [PATCH 0/9] perf: Adding better precise_ip field handling

2013-01-27 Thread Jiri Olsa
On Sun, Jan 27, 2013 at 01:41:33PM +0100, Ingo Molnar wrote: > > * Jiri Olsa wrote: > > > hi, > > adding sysfs attribute to specify the maximum allowed value > > for perf_event_attr::precise_ip field. > > > > Adding functionality for simple 'precis

[RFC/PATCH] perf x86: Add off-core event constraints for Sandy/IvyBridge micro architecture

2013-01-27 Thread Jiri Olsa
y for PMC0/PMC3 respectively. Adding related constraints. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Namhyung Kim Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Stephane Eranian --- arch/x86/

[PATCH 1/5] perf tools: Fix -C option for record command

2013-02-25 Thread Jiri Olsa
Currently the -C option does not work for record command, because of the targets mismatch when synthesizing threads. Fixing this by using proper target interface for the synthesize decision. Reported-by: Oleg Nesterov Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra

[PATCH 2/5] perf tests: Make attr script verbose friendly

2013-02-25 Thread Jiri Olsa
Making the attr test script runner to pass proper verbose option. Also making single '-v' be more reader friendly and display just the test name. Making the current output to be display for '-vv'. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra

[PATCH 3/5] perf tests: Make attr script test event cpu

2013-02-25 Thread Jiri Olsa
Make attr script to check for 'cpu' when testing event properties. This will allow us to check the '-C X' option for both record and stat commands. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey A

[PATCH 0/5] perf tools: Fix -C option for record command

2013-02-25 Thread Jiri Olsa
Available in: git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/linux.git perf/oleg1 jirka Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Namhyung Kim Cc: David Ahern Cc: Oleg Nesterov --- Jiri Olsa (5)

[PATCH 5/5] perf tests: Add attr stat -C cpu test

2013-02-25 Thread Jiri Olsa
Adding test to validate perf_event_attr data for command: 'stat -C 0' Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Namhyung Kim Cc: David Ahern Cc: Oleg Nesterov

[PATCH 4/5] perf tests: Add attr record -C cpu test

2013-02-25 Thread Jiri Olsa
Adding test to validate perf_event_attr data for command: 'record -C 0' Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Namhyung Kim Cc: David Ahern Cc: Oleg Nesterov

Re: [PATCH 1/1] perf/tools: Fix "perf record -C... workload" behaviour

2013-02-25 Thread Jiri Olsa
On Wed, Feb 06, 2013 at 08:42:58PM +0100, Oleg Nesterov wrote: > Test-case: > > # perf record -e probe_libc:syscall -C0 true > true: Terminated > > The child process is killed by perf_record__sig_exit(). This is because > perf_evlist__prepare_workload() doesn't initialize threads->map

Re: [PATCH 1/5] perf tools: Fix -C option for record command

2013-02-25 Thread Jiri Olsa
On Mon, Feb 25, 2013 at 11:56:38AM -0700, David Ahern wrote: > On 2/25/13 11:39 AM, Oleg Nesterov wrote: > >To clarify, I am not trying to review this patch, I'd like to ask > >the question... > > > >On 02/25, Jiri Olsa wrote: > >> > >>Curren

[PATCH] perf: Fix vmalloc ring buffer free function

2013-02-26 Thread Jiri Olsa
to be recognized in the rb_free_work function and set 'nr' to 0 in this case, so only the user page gets freed. Reported-by: Jan Stancek Signed-off-by: Jiri Olsa Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Arnaldo C

Re: [PATCH] perf: Fix vmalloc ring buffer free function

2013-02-27 Thread Jiri Olsa
On Wed, Feb 27, 2013 at 02:02:39PM +0100, Frederic Weisbecker wrote: > 2013/2/26 Jiri Olsa : > > If we allocate perf ring buffer with the size of single page, > > we will get memory corruption when releasing it. It's caused > > by rb_free_work function (the CONF

Re: [PATCH v4 2/2] perf: add sysfs entry to adjust multiplexing interval per PMU

2013-02-19 Thread Jiri Olsa
On Mon, Feb 18, 2013 at 06:54:44PM +0100, Stephane Eranian wrote: SNIP > +perf_event_mux_interval_ms_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + struct pmu *pmu = dev_get_drv

[PATCH] perf x86: Change SandyBridge and IvyBrige instructions event to be precise

2013-02-20 Thread Jiri Olsa
stribution for both SandyBridge and IvyBrige micro-archs. It allows to use precise modifier on 'instructions' event on SandyBridge and IvyBrige micro-archs which is not possible now. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Namhyung Kim Cc: Corey Ashford Cc: Frederic W

Re: [PATCH] perf x86: Change SandyBridge and IvyBrige instructions event to be precise

2013-02-20 Thread Jiri Olsa
On Wed, Feb 20, 2013 at 10:01:20PM +0100, Stephane Eranian wrote: > On Wed, Feb 20, 2013 at 9:55 PM, Andi Kleen wrote: > > Jiri Olsa writes: > > > >> Changing the default 'instructions' HW event for SandyBridge and > >> IvyBrige to use the available

Re: [PATCH] perf x86: Change SandyBridge and IvyBrige instructions event to be precise

2013-02-20 Thread Jiri Olsa
On Wed, Feb 20, 2013 at 12:55:59PM -0800, Andi Kleen wrote: > Jiri Olsa writes: > > > Changing the default 'instructions' HW event for SandyBridge and > > IvyBrige to use the available precise 'instructions' event. > > > > The precise event is

  1   2   3   4   5   6   7   8   9   10   >