On Tue, Apr 02, 2013 at 11:15:23AM +0900, Namhyung Kim wrote: > On Mon, 1 Apr 2013 22:40:23 +0200, Jiri Olsa wrote: > > On Mon, Apr 01, 2013 at 08:35:22PM +0900, Namhyung Kim wrote: > >> From: Namhyung Kim <namhyung....@lge.com> > >> > >> New addr sort key provides a way to sort the entries by the symbol > >> addresses. It can be helpful to figure out symbol resolution problem > >> when a dso cannot do it properly as well as finding hotpath in a dso > >> and/or a function. > > > > maybe it's just the recent mem profiling patches, but wouldn't > > it be better to use 'ip' instead of 'addr'? > > > > also it's following code getting the data: > > ... > > if (sample_type & PERF_SAMPLE_IP) > > data->ip = perf_instruction_pointer(regs); > > ... > > > > same for the "perf sort: Add 'addr_to/from' sort key" patch > > I'm not sure I understand what you mean exactly. > > I used hist_entry->ip but it was set by al->addr which was converted > from the original sample ip to a relative ip by map->map_ip(). > > I can change it to use ->unmap_ip() before printing. Is that your > concern?
what I meant was the 'addr' name itself for -s option, like use: '-s ip' instead of '-s addr' I'm fine with the implementation jirka > > And it seems that addr in branch info is original ip, Stephane? > > Thanks, > Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
