Re: [PATCH 01/11] HID: hid-input factorize hid_input allocation

2012-11-27 Thread Jiri Kosina
input_dev->id.bustype = hid->bus; > - input_dev->id.vendor = hid->vendor; > - input_dev->id.product = hid->product; > - input_dev->id.version = hid->version; > -

Re: [PATCH 02/11] HID: hid-input: simplify hid_input allocation and registration

2012-11-27 Thread Jiri Kosina
g in a particular way internally, that spells > disaster. There must be some other way in which the same effect can be > achieved? The changelog doesn't seem to be really verbose enough to me. What exactly is the scenario you are looking at here, Benjamin, please? Thanks, -- Jir

Re: [PATCH 01/11] HID: hid-input factorize hid_input allocation

2012-11-29 Thread Jiri Kosina
On Fri, 23 Nov 2012, Benjamin Tissoires wrote: > This just refactors the allocation of hid_input. > No semantic changes. As this is a generic cleanup, I am taking this one through for-3.8/upstream branch. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send th

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-18 Thread Jiri Kosina
errupts go away. My understanding from the other mail is that DAniel Vetter already has an idea what might be going wrong with IRQ acking on GM45 chipsets; hopefully this datapoint regarding MSI will fit into it. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "

Re: [PATCH] drm/i915: Flush writes to GMBUS registers

2013-03-18 Thread Jiri Kosina
rnel.org/r/alpine.lnx.2.00.1303151424140.9...@pobox.suse.cz > Cc: Shawn Starr > Cc: Jiri Kosina > Cc: Daniel Vetter Unfortunately I can't provide my Tested-by or Acked-by for this, as I am still seeing the "nobody cared" for irq 16 with this patch applied. > --- > dri

Re: [PATCH] HID: usbhid: quirk for Realtek Multi-card reader

2013-03-18 Thread Jiri Kosina
On Mon, 18 Mar 2013, Josh Boyer wrote: > This device has an odd HID entry I can't really say I understand this portion of the changelog. I will rephrase it a little bit and apply, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [PATCH] HID: usbhid: quirk for MSI GX680R led panel

2013-03-18 Thread Jiri Kosina
On Mon, 18 Mar 2013, Josh Boyer wrote: > This keyboard backlight device causes a 10 second delay to boot. Add it > to the quirk list with HID_QUIRK_NO_INIT_REPORTS. Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&q

[PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses))

2013-03-18 Thread Jiri Kosina
Okay, so I think that for 3.9 we want the patch below, and if eventually hardware root cause / workaround is found for GM45, we can have it merged later. From: Jiri Kosina Subject: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips Commit 28c70f162 ("drm/i915: use the gmbus irq for

Re: [PATCH] HID: usbhid: quirk for MSI GX680R led panel

2013-03-18 Thread Jiri Kosina
ng. I shall hang > my head in shame and send a fixed v2. My apologies. I have already fixed that in my tree, no need to resend. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.o

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-18 Thread Jiri Kosina
idance code and replaces it with the same trick Paulo used to > fix pch irq handling races. Unfortunately it didn't change anything, the spurious interrupt report is still there. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-18 Thread Jiri Kosina
th IRQ acking on GM45 chipsets; hopefully > > this datapoint regarding MSI will fit into it. > > What is /proc/interrupts difference between with and without pci=nomsi ? > > drm is forced to share irq 16? Yup, IRQ 16 is being shared, and one of the owners is i915. -- Jiri Kosina SUSE

Re: [PATCH 0/7] HID: multitouch: support of hybrid finger/pen devices

2013-03-18 Thread Jiri Kosina
so 3.10 is definitely a realistic target. Just to set my own expectations correctly -- Henrik, are you going to review this patchset as well, or there is no need for me to wait for your feedback? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses))

2013-03-19 Thread Jiri Kosina
out should work and it indeed does in my case, hence the (tested) patch below. I think it's a 3.9-rc material, and I am all open to debug this further for 3.10 so that the race is closed and gmbus irqs can be used on Gen4 platform properly. From: Jiri Kosina Subject: [PATCH]

[PATCH][RESEND] [IA64] tiocx: check retval from bus_register()

2013-03-19 Thread Jiri Kosina
Properly check return value from bus_register() and propagate it out of tiocx_init() in case of failure. Reported-by: Fengguang Wu Signed-off-by: Jiri Kosina --- arch/ia64/sn/kernel/tiocx.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/arch/ia64/sn/kernel

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-20 Thread Jiri Kosina
t, I have been thinking of writing a > test driver module, with a module parameter telling it which IRQ number > to register for. It seems like the sort of thing that would be useful > to have, from time to time. Ok, so how about this? Daniel, is it enough to make the problem appe

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-20 Thread Jiri Kosina
CI hotplug bridges The problem is still there ... so the inconsistency between DisINTx+ and INTx+ is unfortunately not the whole story. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.ker

[PATCH] dummy-irq: introduce a dummy IRQ handler driver (was Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1]

2013-03-20 Thread Jiri Kosina
On Wed, 20 Mar 2013, Alan Stern wrote: > > Ok, so how about this? > > Daniel, is it enough to make the problem appear on your system (by > > building this into the kernel and booting with dummy-irq.irq=16)? > > > > Thanks. > > > > From: Jiri Kosina &

Re: [PATCH v2 1/9] HID: core: add "report" hook, called once the report has been parsed

2013-02-04 Thread Jiri Kosina
er; > > + if (hdrv && hdrv->report) > > + hdrv->report(hid, report); > > I think this is more useful if called before the individual fields. In > fact, it seems raw_event() is already doing exactly that. No need for > a new callba

Re: [TRIVIAL PATCH V2] Doc: percpu_counter doc code for better readability

2013-02-05 Thread Jiri Kosina
is? Absolutely, now applied. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 0/9] Support of Nexio 42" and new default class for hid-multitouch

2013-02-05 Thread Jiri Kosina
so, Benjamin, perhaps it'd make sense to put a link somewhere into in-tree documentation, with pointer to your testing suite? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.ke

Re: [PATCH resend] ARM: at91/ide: remove unsused at91-ide Kconfig entry

2013-02-05 Thread Jiri Kosina
> -config BLK_DEV_IDE_AT91 > - tristate "Atmel AT91 (SAM9, CAP9, AT572D940HF) IDE support" > - depends on ARM && ARCH_AT91 && !ARCH_AT91RM9200 && !ARCH_AT91X40 > - select IDE_TIMINGS > - > config BLK_DEV_IDE_ICSIDE > tristate &

Re: [PATCH v2 0/9] Support of Nexio 42" and new default class for hid-multitouch

2013-02-06 Thread Jiri Kosina
ind if I send the usbhid dependency and the pen+multitouch > series this week, or we are too close to the 3.9 opening window? Please just send the patches, and let's see whether they will make it for 3.8 or I'll queue (some of) them for 3.9. Thanks, -- Jiri Kosina SUSE Labs -- T

Re: [PATCH v2 0/9] Support of Nexio 42" and new default class for hid-multitouch

2013-02-06 Thread Jiri Kosina
if you'd > rather wait for 3.10 :) Yeah, sorry, my sentence was off-by-one, but I guess you got me :) > Anyway, I'm doing my best to push them soon. Thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in th

Re: [PATCH 07/15] drivers/hid: add missing GENERIC_HARDIRQ dependency

2013-02-07 Thread Jiri Kosina
On Wed, 6 Feb 2013, Heiko Carstens wrote: > HID Sensors framework support (CONFIG_HID_SENSOR_HUB) unconditionally > selects MFD_CORE which however depends on GENERIC_HARDIRQS. > So add this dependency to HID_SENSOR_HUB as well. Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubsc

Re: [PATCH] HID: multitouch: do not use pointers towards hid-core

2013-02-07 Thread Jiri Kosina
etter choice. > > Signed-off-by: Benjamin Tissoires Applied this one on top of the previous hid-multitouch patchset. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

Re: [PATCH v2] i2c-hid: fix length for set/get report in i2c hid

2013-04-04 Thread Jiri Kosina
rent tree would be absolutely sufficient). Thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] HID: hid-sensor-hub: do not process feature reports in raw_event

2013-04-04 Thread Jiri Kosina
On Wed, 27 Mar 2013, Jiri Kosina wrote: > > I am looking at 3.9.rc1. > > The only place I see the raw_event callback is called from > > hid/hid_input_report(). hid_input_report is called with type > > HID_INPUT_REPORT > > in all cases, except hid_ctrl(), where it

Re: [PATCH v3.7+] HID: magicmouse: fix race between input_register() and probe()

2013-04-04 Thread Jiri Kosina
gt; Fixes: > https://bugzilla.redhat.com/show_bug.cgi?id=908604 > > Reported-and-Tested-By: Clarke Wixon > Signed-off-by: Benjamin Tissoires > --- > > Hi Jiri, > > this one can goes to stable (so 3.8) as well. Applied, and will push for 3.9 still. Thanks. -- Jiri

Re: [PATCH v2] i2c-hid: fix length for set/get report in i2c hid

2013-04-04 Thread Jiri Kosina
on my computer... > And there is no point rebasing it on top of Linus' tree as the > i2c_hid_request() callback is scheduled for 3.10. > > Could you double check Jiri? Apologies, that was an error on my side, I have forgotten about the i2c_hid_request()-related refactoring that is queue

Re: [RFC PATCH] Use target compiler for user binaries in samples/

2013-04-04 Thread Jiri Kosina
e the new > infrastructure. > > The file says: > +# Sample syntax (see Documentation/kbuild/makefiles.txt for reference) > > But I did not bother to write this yet - awaiting feedback. I generally like the idea. It'd be nice to know whether this fixes the ARCH=sparc all

[GIT] HID

2013-04-04 Thread Jiri Kosina
tions(-) Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 5/5] HID: hid-lenovo-tpkbd, remove doubled hid_get_drvdata

2013-04-04 Thread Jiri Kosina
On Thu, 4 Apr 2013, Jiri Slaby wrote: > In pointer_press_speed_show, we do > data_pointer = hid_get_drvdata(hdev); > twice in a row. Remove one of those. > > Signed-off-by: Jiri Slaby > Cc: Jiri Kosina > Cc: linux-in...@vger.kernel.org > --- > drivers/hid/hid

Re: [PATCH 3/3] x86: kernel base offset ASLR

2013-04-05 Thread Jiri Kosina
ly vaguely mentioning this requirement in the changelog (and calling it recommendation), but make it a hard prerequisity. Without kernel addresses being invisible to userspace, this feature is completely useless, but might provide very false sense of security if just blindly enabled by random Joe B

Re: [PATCH] IB: cxgb3: delay freeing mem untill entirely done with it

2013-01-29 Thread Jiri Kosina
On Mon, 14 Jan 2013, Steve Wise wrote: > Reviewed-by: Steve Wise Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.

Re: [PATCH 1/4] USB: HID: SRW-S1 Gaming Wheel Driver

2013-01-29 Thread Jiri Kosina
t; > > I don't think it's strictly required, but it seems to work quite nicely > > for other drivers as well. > > OK I'll wait a couple of days in-case any more comments come in and re-do > the patch with the file name 'hid-steelseries.c' towards the end of

Re: [PATCH 1/5] USB: HID: SRW-S1 Gaming Wheel Driver

2013-01-31 Thread Jiri Kosina
o Simon, thanks for respin of the patchset. I thought we converged to hid-steelseries name in the end originally? If you agree, I'll change it and apply. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/5] USB: HID: SRW-S1 Gaming Wheel Driver

2013-01-31 Thread Jiri Kosina
ise we'll be corrupting memory in steelseries_srws1_probe() here: drv_data->led[SRWS1_NUMBER_LEDS] = led; From: Jiri Kosina Subject: [PATCH] HID: steelseries: fix out of bound array access The last field of the driver_data->leds[] array is used to store the special toggle for setting al

Re: [PATCH] HID: i2c-hid: fix i2c_hid_output_raw_report

2013-01-31 Thread Jiri Kosina
argument of i2c_hid_output_raw_report. > > Not removing the report_id from the given buffer adds this byte 2 times > in the command, leading to a non working command. > > Reported-by: Andrew Duggan > Signed-off-by: Benjamin Tissoires Applied, will push it for 3.8 still. Than

[GIT] HID

2013-01-31 Thread Jiri Kosina
, by Nicholas Santos Thanks. Benjamin Tissoires (1): HID: i2c-hid: fix i2c_hid_output_raw_report Jiri Kosina (1): HID: remove x bit from sensor doc Nicholas Santos (1): HID: usbhid: quirk for Formosa IR receiver drivers/hid/hid-ids.h|3 +++ drivers/hid/i2c

Re: [PATCH 6/6] Drivers: hv: Execute shutdown in a thread context

2013-01-24 Thread Jiri Kosina
@@ static struct hv_util_service util_kvp = { > .util_deinit = hv_kvp_deinit, > }; > > +static void perform_shutdown(struct work_struct *dummy) > +{ > + orderly_poweroff(true); > +} Is there any particular reason for this kind of crazy indentation? -- Jiri K

Re: [PATCH 5/6] Drivers: hid: hid-hyperv: Use consolidated GUID definitions

2013-01-24 Thread Jiri Kosina
On Wed, 23 Jan 2013, K. Y. Srinivasan wrote: > Use the consolidated GUID definitions in the Hyper-V mouse driver. > > Signed-off-by: K. Y. Srinivasan > Reviewed-by: Haiyang Zhang Acked-by: Jiri Kosina Greg, I guess you are taking this as a whole? Thanks. > --- > driver

Re: [PATCH 1/4] USB: HID: SRW-S1 Gaming Wheel Driver

2013-01-28 Thread Jiri Kosina
++ Is hid-srws1 really the best name? My understanding is that the vendor is called Steelseries, and we mostly stick to calling the drivers according to the device vendors (and grouping the quirks accordingly). So how about hid-steelseries? -- Jiri Kosina SUSE Labs -- To unsubscribe from this lis

Re: [PATCH 4/4] USB: HID: SRW-S1 Add support controlling all LEDs simultaneously

2013-01-28 Thread Jiri Kosina
; > - name_sz = strlen(hdev->uniq) + 15; > + name_sz = strlen(hdev->uniq) + 16; > + > + /* 'ALL', for setting all LEDs simultaneously */ > + led = kzalloc(sizeof(struct led_classdev)+name_sz, GFP_KERNEL); Is this memory ever freed? -- Jiri Kosina

Re: [PATCH 1/4] USB: HID: SRW-S1 Gaming Wheel Driver

2013-01-28 Thread Jiri Kosina
s vendor, we can operatively decide on a different naming for the future. > If you still would prefer a name change I can do that. In which case is > the naming of the LED interfaces still OK? > > ie. > -- > echo 1 > /sys/class/leds/SRWS1\:\:69005002125011007452\:

Re: [PATCH v2 0/8] hid driver transport cleanup

2013-02-25 Thread Jiri Kosina
i2c-hid driver change into the series > > I still did not implemented the final usb cleanup for hid-multitouch as it may > required few comments. I have now taken the series. Thanks Benjamin, thanks Henrik. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "u

Re: [PATCH] HID: make sensor autodetection independent of underlying bus

2013-02-25 Thread Jiri Kosina
gt; bluetooth (and other transports) as well. > > > > Reported-by: Alexander Holler > > Signed-off-by: Mika Westerberg > > Reviewed-By: Benjamin Tissoires Applied. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: I2C: Fix i2c fail problem when a process is terminated by a signal on octeon in 3.8

2013-02-26 Thread Jiri Kosina
, > + result = wait_event_timeout(i2c->queue, > octeon_i2c_test_iflg(i2c), > i2c->adap.timeout); > >   > >   > > [IMAGE] > > [SeenTimeChecker?do=5c4ee24ec3c4b5ef0b1e1d188d51662fbee53716e9d11aa47790d17410439b26f5961395f090d04f94a68828d2d0a0

Re: [PATCH] i2o: remove compile-time warnings

2013-02-26 Thread Jiri Kosina
gt; kernel interface. > So we should cast this to 'unsigned long' before casting > it to a pointer. > Minimal fix, doesn't break anything which wasn't broken > before. > > Cc: Jiri Kosina > Signed-off-by: Hannes Reinecke > > diff --git a/drivers/m

Re: [GIT PULL] Load keys from signed PE binaries

2013-02-26 Thread Jiri Kosina
NG might be sufficient), but it is doable. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [GIT PULL] Load keys from signed PE binaries

2013-02-28 Thread Jiri Kosina
On Thu, 21 Feb 2013, David Howells wrote: > The way we have come up with to get around this is to embed an X.509 > certificate containing the key in a section called ".keylist" in an EFI PE > binary and then get the binary signed by Microsoft. The key can then be > passed > to the kernel by pass

Re: [GIT PULL] Load keys from signed PE binaries

2013-02-28 Thread Jiri Kosina
s blacklisted. In other words -- you blacklist the population of the key on systems by blakclisting the key-carrying binary, but the key remains trusted on whatever system the binary has been processed by keyctl before. Right? If so, that's a clear difference from normal X.509 chain of trust (i

Re: [GIT PULL] Load keys from signed PE binaries

2013-02-28 Thread Jiri Kosina
#x27;s not a permanent thing. That unfortunately seems to be very weak security measure as well. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [GIT PULL] Load keys from signed PE binaries

2013-02-28 Thread Jiri Kosina
by a key that has been blacklisted on the very particular machine in its dbx is not going to work (as there is a very direct x509 chain of trust link). No? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a me

Re: [GIT PULL] Load keys from signed PE binaries

2013-02-28 Thread Jiri Kosina
ke the blacklisting work properly, yes. It of course still doesn't fix the principal problem, that you are artificially changing the signature semantics of "Microsoft trusts this binary" to "we claim that Microsoft actually meant that they trust this key". That has very li

Re: [PATCH 1/2] hid: Add report descriptor for Logitech Driving Force wheel

2013-02-19 Thread Jiri Kosina
On Sun, 17 Feb 2013, Paul Sbarra wrote: > This is the original report descriptor as reported by lsusb -vd 046d:c294. I have now applied both patches. Paul, please try to provide more verbose changelogs in the future even for such trivial changes as this. Thanks. -- Jiri Kosina SUSE L

Re: [PATCH 1/5] HID: LG: Add support for Logitech Momo Force (Red) Wheel

2013-02-20 Thread Jiri Kosina
On Tue, 19 Feb 2013, Simon Wood wrote: > This patch provides a modified report descriptor to split accelerator > and brake, and adds the 'NO_GET' flag to prevent it hanging on > connection. Applied, thanks Simon. -- Jiri Kosina SUSE Labs -- To unsubscribe from this

[GIT] trivial

2013-02-21 Thread Jiri Kosina
of_platform_populate() Jesper Dangaard Brouer (1): percpu_counter.h: comment code for better readability Jesper Juhl (3): pcmcia: avoid static analysis complaint about use-after-free net: mvneta: remove unneeded version.h include IB: cxgb3: delay freeing mem untill entirely done with it Jiri

[GIT] HID

2013-02-21 Thread Jiri Kosina
dependency Ian Abbott (1): HID: blacklist Velleman data acquisition boards Jiri Kosina (3): HID: steelseries: rename driver to be compliant with other drivers HID: steelseries: fix out of bound array access HID: hidraw: print message when succesfully initialized Mauro Carva

Re: [PATCH] Documentation: update top level 00-INDEX file with new additions

2013-02-21 Thread Jiri Kosina
gh ... as long as it's acked by appropriate maitaniners, patch monkey in re-transmission mode works well. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo in

Re: [PATCH 2/5] HID: roccat: Removed actual profile from chardev reports

2013-03-13 Thread Jiri Kosina
On Sun, 10 Mar 2013, Stefan Achatz wrote: > Userland-tools now keep track of actual profile themselves. > Spared out Pyra, which is a harder case. Hi Stefan, I fail to see how this is not breaking backwards compatibility? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: se

Re: USB Mouse Disconnect Kernel-3.7/3.8

2013-03-13 Thread Jiri Kosina
modules). > > The motherboard I use is Intel DP55KG which has the P55 Express > chipset to control the USB. > > I've seen this behavior on the current kernel-3.8.x and also > on the previous kernel-3.7. I have not tested anything earlier. > > Please CC to frank.pet

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-14 Thread Jiri Kosina
g. > > Can you try to do a git bisect for this? Is the sluggish system > response clear enough that you can tell reliably when it is present and > when it isn't? That was my first thought, but unfortunately I am afraid there will be point at which I will easily make a bi

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-14 Thread Jiri Kosina
IRC > it was for OHCI rather than UHCI) which appeared to be related to > activity on the built-in webcam. Will check this. No external devices are plugged in, I think the only internal one it has is bluetooth chip. I'll try turning it off. -- Jiri Kosina SUSE Labs -- To unsubscr

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-14 Thread Jiri Kosina
On Thu, 14 Mar 2013, Jiri Kosina wrote: > > Is occurrence of the "nobody cared" connected with any particular > > device? Somebody reported a similar problem not long ago (although IIRC > > it was for OHCI rather than UHCI) which appeared to be related to > &g

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-14 Thread Jiri Kosina
On Thu, 14 Mar 2013, Jiri Kosina wrote: > > > I don't think I have seen this message on rc1+ (8343bce, to be precise), > > > but I have definitely seen sluggish system response on that kernel as > > > well. > > > > > > Attaching lspci, /proc/i

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-15 Thread Jiri Kosina
t, we > need to figure out why the fix may not be sufficient. With either 4f535093cf or 181380b702 I do *not* see the problem, i.e. these commits are not the culprit and it was caused by some later change. I will proceed with bisect now, hopefully it'll produce a meaningful result. -- Jir

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-15 Thread Jiri Kosina
drm/i915: use the gmbus irq for waits Adding Daniel, Imre and Daniel to CC while I will try to figure out what's happening in parallel. Attaching dmesg.txt from the machine with 28c70f162a as head, with drm.debug=0xe. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-15 Thread Jiri Kosina
On Fri, 15 Mar 2013, Jiri Kosina wrote: > > I have the same problem on my Lenovo T500. I think the graphics card is > > involved. > > > > This laptop has "hybrid graphics" - one Intel GMA 4500MHD and one ATI > > Mobility Radeon HD 3650. When I boot with t

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-15 Thread Jiri Kosina
; > Wasn't this fixed by the merge from David > (2cc79544bd0aabb4b3cf467ead5df526d9134c64)? Why do you think it should, please? (I am seeing this with a2362d247 still). -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-15 Thread Jiri Kosina
s fixed by the merge from David > > > (2cc79544bd0aabb4b3cf467ead5df526d9134c64)? > > > > Why do you think it should, please? > > The line: > - Fix PCH irq handling race which resulted in missed gmbus/dp > aux irqs and subsequent fallout (Paul

Re: PER_LINUX32, Was: [PATCH v2 21/31] arm64: 32-bit (compat) applications support

2012-08-28 Thread Jiri Kosina
ret = PER_LINUX; > > > > + return ret; > > > > +} > > > > > > Where did you get this from? > > > > > > You should not need compat_sys_personality, just call the native function. > > > > Hmm, but in that case an aarch32 application d

Re: [PATCH] [RFC] cross-arch: don't corrupt personality flags upon exec()

2012-08-28 Thread Jiri Kosina
should be rather doing set_personality(PER_LINUX | (current->personality & (~PER_MASK))) otherwise you clobber the upper personality bits upon exec(). Something like the patch below. Either you can take it for tile, or I can ask Andrew to fold it into my tree-wide fix cu

[PATCH] tile: Fix personality bits handling upon exec()

2012-08-28 Thread Jiri Kosina
current->personality. - as pointed out by Arnd Bergmann, PER_LINUX_32BIT is not used anywhere by tile, so let's just drop that in favor of PER_LINUX Signed-off-by: Jiri Kosina Acked-by: Chris Metcalf --- Andrew, this is kind of followup to cross-arch-dont-corrupt-personality-flags-upon-ex

Re: [PATCH v2] HID: multitouch: Remove the redundant touch state

2012-08-28 Thread Jiri Kosina
onst > struct hid_device_id *id) > if (id->vendor == HID_ANY_ID && id->product == HID_ANY_ID) > mt_post_parse_default_settings(td); > > - td->slots = kzalloc(td->maxcontacts * sizeof(struct mt_slot), > - GFP_KERNEL); > - if (!td->slots) { > - dev_err(&hdev->dev, "cannot allocate multitouch slots\n"); > - hid_hw_stop(hdev); > - ret = -ENOMEM; > - goto fail; > - } > - > ret = sysfs_create_group(&hdev->dev.kobj, &mt_attribute_group); > > mt_set_maxcontacts(hdev); > @@ -774,7 +733,6 @@ static void mt_remove(struct hid_device *hdev) > struct mt_device *td = hid_get_drvdata(hdev); > sysfs_remove_group(&hdev->dev.kobj, &mt_attribute_group); > hid_hw_stop(hdev); > - kfree(td->slots); > kfree(td); > hid_set_drvdata(hdev, NULL); > } > @@ -1087,6 +1045,7 @@ static struct hid_driver mt_driver = { > .remove = mt_remove, > .input_mapping = mt_input_mapping, > .input_mapped = mt_input_mapped, > + .input_configured = mt_input_configured, > .feature_mapping = mt_feature_mapping, > .usage_table = mt_grabbed_usages, > .event = mt_event, > -- > 1.7.11.5 > -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] x86, apm: Make on_cpu0() use workqueue instead of work_on_cpu()

2012-08-28 Thread Jiri Kosina
e. Applying to apm.git, thanks Tejun. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v6 04/13] pktcdvd: Switch to bio_kmalloc()

2012-08-28 Thread Jiri Kosina
me some more trouble in the future ... :) Well, I definitely have hardware back at home that supports this, so I can take it. Doesn't seem to be heavy traffic code either. Peter, ok with that? Also, how was this usually fed upstream -- through Jens' tree? -- Jiri Kosina SUSE Labs -- T

Re: [PATCH v2] HID: multitouch: Remove the redundant touch state

2012-08-29 Thread Jiri Kosina
ces. > It's now on the top of my TODO list. Ah, I have missed the fact that this one is also part of Henrik's series, sorry for the noise. I haven't unfortunately reviewed the series yet due to kernel summit & related events, but I'll get to it shortly. Thanks, -- Jir

Re: [PATCH v3 16/20] HID: Only dump input if someone is listening

2012-09-02 Thread Jiri Kosina
from your series. The remaining ones I am still about to review (currently travelling). There is no inter-dependency between the Input and HID ones, and so we can handle them with Dmitry as two independent Input and HID series, right? Thanks a lot, -- Jiri Kosina SUSE Labs -- To unsubscribe fro

Re: [PATCH] Documentation: fix broken utf8 encoding

2012-09-02 Thread Jiri Kosina
Well, your MTA didn't make it any better by not encoding it properly :) I have fixed it manually and applied. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majord

Re: [PATCH] [trivial] dma: Fix typo various drivers in dma

2012-09-02 Thread Jiri Kosina
On Fri, 3 Aug 2012, Masanari Iida wrote: > Correct spelling typo in drivers/dma. Applied. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vg

Re: [PATCH] security: unconditionally call Yama

2012-09-02 Thread Jiri Kosina
citly enable this feature). Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: linux page table

2012-09-02 Thread Jiri Kosina
what is loaded into cr3 in switch_mm()) is the same. LKML is however very inappropriate list for such questions. Please ask on kernelnewbies list next time. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to m

Re: regression 3.5->3.6: usb keyboard not working anymore

2012-09-02 Thread Jiri Kosina
depends on USB_HID select NEW_LEDS select LEDS_CLASS + default HID_GENERIC ---help--- Support for the Lenovo ThinkPad USB Keyboard with TrackPoint. That will fix the oldconfig issue and will not polute the hid_have_special_driver[] by a rather ugly ifdef. Thanks,

Re: linux page table

2012-09-02 Thread Jiri Kosina
me different at that point ? That is a different story. COW is applied on fork() (i.e. spawning new process), not on clone(CLONE_VM) (i.e. spawning new thread). -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] hid: Remove "default m" from HID_LOGITECH_DJ

2012-09-03 Thread Jiri Kosina
Unifying receivers full support" > depends on HID_LOGITECH > - default m > ---help--- > Say Y if you want support for Logitech Unifying receivers and devices. > Unifying receivers are capable of pairing up to 6 Logitech compliant That was an overlook on my

Re: [PATCH v3 16/20] HID: Only dump input if someone is listening

2012-09-03 Thread Jiri Kosina
an either take the set through my tree with his Signed-off-by: on the Input patches, or vice-versa. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Bug fixes/cleanups for floppy driver (v4)

2012-09-03 Thread Jiri Kosina
t; liberty to include now, I just fixed the changelog as was noticed that > time to reference the right commit, and included my ack. > > Patch 5 and 6 implements earlier suggested cleanups and enhancements. I have now finally got to reviewing the series and all the previous Vivek's an

Re: [PATCH v6 04/13] pktcdvd: Switch to bio_kmalloc()

2012-09-03 Thread Jiri Kosina
have just tested this v6 patchset (and it works for pktcddvd), only to see that Kent has sent out v7 (unfortunately he hasn't CCed me on it). v6 works nicely, bus as far as I understand it, even in v7 we are not resetting bi_end_io and bi_private properly, right? -- Jiri Kosina SUSE Labs -

Re: [PATCH v7 4/9] pktcdvd: Switch to bio_kmalloc()

2012-09-04 Thread Jiri Kosina
ave now tested it and it works properly. You can add Signed-off-by: Jiri Kosina once you will be pushing the patchset through (I will be pushing MAINTAINERS update through my tree to Jens separately). -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "uns

[GIT] floppy, pktcdvd

2012-09-04 Thread Jiri Kosina
orkqueue inside the alloc_disk loop floppy: do put_disk on current dr if blk_init_queue fails floppy: properly handle failure on add_disk loop floppy: use common function to check if floppies can be registered floppy: remove dr, reuse drive on do_floppy_init Jiri Kosina (1)

[RFC] [PATCH] HID: remove Paul Walmsley's copyright from places where it shouldn't be

2012-09-04 Thread Jiri Kosina
he bus, the copyright has been blindly transfered into all the tiny drivers, which actually don't contain any of Pauls' copyrighted code. Remove the copyright from those sub-drivers. Signed-off-by: Jiri Kosina --- Paul, I am sending this out to you as RFC, and am not willing to app

Re: [PATCH v2] powerpc: fix personality handling in ppc64_personality()

2012-09-05 Thread Jiri Kosina
ersonality to PER_LINUX32 or PER_LINUX > > discards any flags stored in the top three bytes > > > > Use personality() macro to compare only PER_MASK bytes and make sure that > > we are setting only the bits that should be set, instead of > > overwriting the whole value.

Re: [PATCH 0/6] HID: picoLCD additional fixes + CIR support

2012-09-05 Thread Jiri Kosina
On Sun, 19 Aug 2012, Bruno Prémont wrote: > This series fixes some race conditions in picoLCD driver during remove() > and adds support for IR functionality. I have now applied the series, thanks Bruno. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH] HID: hid-lcpower: Use HID_UP_LOGIVENDOR instead of hard coded 0x0ffbc0000

2012-09-05 Thread Jiri Kosina
non-Logitech devices using this usage page. I am applying your patch now, but I guess we'll rather rename the define in a near future. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord

Re: how to tell i386 from x86-64 kernel

2008-02-01 Thread Jiri Kosina
imes make debugging user-reported bugs a little bit harder. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please re

Re: brk randomization breaks columns

2008-02-04 Thread Jiri Kosina
On Mon, 4 Feb 2008, Jiri Kosina wrote: > I still don't seem to fully understand what is happening here -- > aparently this is triggerable only with old programs linked against > libc.so.5, and I am not able to trigger it with my trivial program when > I link it against old

Re: brk randomization breaks columns

2008-02-04 Thread Jiri Kosina
cess is being established during loading of the binary, the beginning and the end of the heap are the same ... -- Jiri Kosina -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel

Re: brk randomization breaks columns

2008-02-04 Thread Jiri Kosina
libc.so.5-linked binaries on any Fedora distro should trigger this bug ... (or you can use the binary that Pavel supplied). Haven't tried this yet. Thanks, -- Jiri Kosina -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAI

Re: Fwd: brk randomization breaks columns

2008-02-04 Thread Jiri Kosina
me from CC, thanks ] Abel, I actually don't think you have chance to have any issues with randomization, as the mentioned post talks about 2.6.22.10, which doesn't randomize the brk start at all. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "u

Re: brk randomization breaks columns

2008-02-04 Thread Jiri Kosina
es anyone have any comments regarding this patch please? Still, it will probably not fix your particular program crashes, just because it will always assume that brk starts immediately after the end of the bss, which is plain wrong and has never been assured. Could you please check whether ther

  1   2   3   4   5   6   7   8   9   10   >