pdata->name);
Please use GPIOF_INIT flags if you want to turn off GPIO backlight.
If gbl->active is inverted, GPIOF_INIT_HIGH can be used as below:
ret = devm_gpio_request_one(gbl->dev, gbl->gpio,
GPIOF_DIR_OUT
On Monday, November 26, 2012 7:25 PM, Laurent Pinchart wrote
>
> Hi Jingoo,
>
> On Monday 26 November 2012 09:49:36 Jingoo Han wrote:
> > On Saturday, November 24, 2012 1:35 AM, Laurent Pinchart wrote
> > >
> > > Signed-off-by: Laurent Pinchart
> >
>
), 'can_sleep' should be
set as 1. However, I cannot find 'can_sleep = 1' in the PXA gpio driver.
What gpio driver do you use to test corgi_lcd driver?
Best regards,
Jingoo Han
>
> From: Marko Katic
>
>
> Signed-off-by: Marko Katic
> ---
> driv
On Thusday, 14 Mar 2013 17:19:55 -0700, Milo(Woogyom) Kim wrote:
> The sysfs allocates PAGE_SIZE. It is used by each R/W operation method.
> Use it instead of another buffer size.
>
> Signed-off-by: Milo(Woogyom) Kim
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
&
https://patchwork.kernel.org/patch/2217301/
https://patchwork.kernel.org/patch/2217291/
Best regards,
Jingoo Han
>
> diff --git a/drivers/mfd/davinci_voicecodec.c
> b/drivers/mfd/davinci_voicecodec.c
> index c0bcc87..c60ab0c 100644
> --- a/drivers/mfd/davinci_voicecodec.c
>
Jeff Garzik
> Cc: linux-...@vger.kernel.org
> ---
> drivers/ata/pata_at32.c | 13 +
> 1 file changed, 1 insertion(+), 12 deletions(-)
I already submitted the patch 2 weeks ago.
http://www.spinics.net/lists/linux-ide/msg45141.html
Best regards,
Jingoo Han
>
> diff --g
Switch to using SIMPLE_DEV_PM_OPS macro to declare the driver's
pm_ops. It reduces code size.
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-at91rm9200.c | 16
1 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rt
Switch to using SIMPLE_DEV_PM_OPS macro to declare the driver's
pm_ops. It reduces code size.
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-mxc.c | 11 +++
1 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/rtc/rtc-mxc.c b/drivers/rtc/rtc-mxc.c
index 13
Switch to using SIMPLE_DEV_PM_OPS macro to declare the driver's
pm_ops. It reduces code size.
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-rc5t583.c | 15 ---
1 files changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/rtc/rtc-rc5t583.c b/drivers/rtc/rtc-rc5t
Switch to using SIMPLE_DEV_PM_OPS macro to declare the driver's
pm_ops. It reduces code size.
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-sa1100.c | 12
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/rtc/rtc-sa1100.c b/drivers/rtc/rtc-sa1100.c
Switch to using SIMPLE_DEV_PM_OPS macro to declare the driver's
pm_ops. It reduces code size. Also, CONFIG_PM_SLEEP is added to
prevent build warning when CONFIG_PM_SLEEP is not selected.
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-sh.c |9 -
1 files changed, 4 insertions(
Switch to using SIMPLE_DEV_PM_OPS macro to declare the driver's
pm_ops. It reduces code size.
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-wm8350.c | 12 +++-
1 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/rtc/rtc-wm8350.c b/drivers/rtc/rtc-wm8350.c
Switch to using SIMPLE_DEV_PM_OPS macro to declare the driver's
pm_ops. It reduces code size.
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-tps6586x.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/rtc/rtc-tps6586x.c b/drivers/rtc/rtc-tps6586x.c
Switch to using SIMPLE_DEV_PM_OPS macro to declare the driver's
pm_ops. It reduces code size.
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-tps65910.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/rtc/rtc-tps65910.c b/drivers/rtc/rtc-tps65910.c
Switch to using SIMPLE_DEV_PM_OPS macro to declare the driver's
pm_ops. It reduces code size.
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-tps80031.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/rtc/rtc-tps80031.c b/drivers/rtc/rtc-tps80031.c
Switch to using SIMPLE_DEV_PM_OPS macro to declare the driver's
pm_ops. It reduces code size.
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-pxa.c | 11 +++
1 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/rtc/rtc-pxa.c b/drivers/rtc/rtc-pxa.c
index 72
r592_pm_ops is not exported. Also, CONFIG_PM_SLEEP is used to
remove unnecessary ifdefs.
Signed-off-by: Jingoo Han
Cc: Maxim Levitsky
---
drivers/memstick/host/r592.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/memstick/host/r592.c b/drivers/memstick
dev_err() is more preferred than pr_err().
Signed-off-by: Jingoo Han
---
drivers/extcon/extcon-max8997.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
index 69641bc..20772ad 100644
--- a/drivers/extcon
Fixed the checkpatch warning as below:
WARNING: static const char * array should probably be static const char *
const
#163: FILE: drivers/extcon/extcon-max8997.c:163:
+static const char *max8997_extcon_cable[] = {
Signed-off-by: Jingoo Han
---
drivers/extcon/extcon-max8997.c |2
> -Original Message-
> From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
> Sent: Tuesday, March 19, 2013 12:33 PM
> To: Jingoo Han
> Cc: MyungJoo Ham; Chanwoo Choi; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 2/2] extcon: max8997: add missing const
>
>
dev_err() is more preferred than pr_err().
Signed-off-by: Jingoo Han
---
No Changes since v1:
drivers/extcon/extcon-max8997.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
index 69641bc..20772ad
vent
build warning as below:
drivers/extcon/extcon-max8997.c: In function 'max8997_muic_probe':
drivers/extcon/extcon-max8997.c:708:30: warning: assignment discards 'const'
qualifier from pointer target type [enabled by
default]
Signed-off-by: Jingoo Han
---
Changes since
On Tuesday, March 19, 2013 6:45 PM, Chanwoo Choi wrote:
>
> On 03/19/2013 02:31 PM, Jingoo Han wrote:
> > Fixed the checkpatch warning as below:
> >
> > WARNING: static const char * array should probably be static const char *
> > const
> > #163: FILE:
rs/rtc/rtc-tegra.c: use managed rtc_device_register()
>
> Signed-off-by: Laxman Dewangan
It looks good.
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> drivers/rtc/rtc-tegra.c |5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/driver
There is no need to return -EIO, because backlight_device_register()
already returns correct error values.
Signed-off-by: Jingoo Han
---
drivers/video/backlight/lm3630_bl.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/lm3630_bl.c
b/drivers
On Friday, February 01, 2013 11:42 PM, Anatolij Gustschin wrote
CC'ed Andrew Morton
>
> From: Stefano Babic
>
> Add LCD driver for Ilitek ILI9221/ILI9222 controller.
>
> Signed-off-by: Stefano Babic
> Signed-off-by: Anatolij Gustschin
> Cc: Richard Purdie
> Cc: Florian Tobias Schandinat
>
itionally the implementation takes care of adjacent ranges and merges
> > them
> > into a single range (as was the case with powerpc and microblaze).
> >
> > The modifications to microblaze, mips and powerpc have not been tested.
> >
> > Signed-off-by: Andrew Murra
Use the wrapper functions for getting and setting the driver data using
spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we
can directly pass a struct spi_device.
Signed-off-by: Jingoo Han
---
drivers/video/backlight/ili9320.c |2 +-
1 files changed, 1 insertion
Use the wrapper functions for getting and setting the driver data using
spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we
can directly pass a struct spi_device.
Signed-off-by: Jingoo Han
---
drivers/video/backlight/ili922x.c |2 +-
1 files changed, 1 insertion
Use the wrapper functions for getting and setting the driver data using
spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we
can directly pass a struct spi_device.
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-rx4581.c |2 +-
1 files changed, 1 insertions(+), 1 de
Use the wrapper functions for getting and setting the driver data using
spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we
can directly pass a struct spi_device.
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-m41t94.c |2 +-
1 files changed, 1 insertions(+), 1 de
Use the wrapper functions for getting and setting the driver data using
spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we
can directly pass a struct spi_device.
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-r9701.c |2 +-
1 files changed, 1 insertions(+), 1 de
Use the wrapper functions for getting and setting the driver data using
spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we
can directly pass a struct spi_device.
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-ds3234.c |2 +-
1 files changed, 1 insertions(+), 1 de
Use the wrapper functions for getting and setting the driver data using
spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we
can directly pass a struct spi_device.
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-ds1390.c |2 +-
1 files changed, 1 insertions(+), 1 de
Use the wrapper functions for getting and setting the driver data using
spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we
can directly pass a struct spi_device.
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-m41t93.c |2 +-
1 files changed, 1 insertions(+), 1 de
Use the wrapper functions for getting and setting the driver data using
spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we
can directly pass a struct spi_device.
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-max6902.c |2 +-
1 files changed, 1 insertions(+), 1 de
Use the wrapper functions for getting and setting the driver data using
spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we
can directly pass a struct spi_device.
Signed-off-by: Jingoo Han
---
drivers/misc/eeprom/at25.c |4 ++--
1 files changed, 2 insertion
Use the wrapper functions for getting and setting the driver data using
spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we
can directly pass a struct spi_device.
Signed-off-by: Jingoo Han
---
drivers/misc/eeprom/eeprom_93xx46.c |6 +++---
1 files changed, 3 ins
Use the wrapper functions for getting and setting the driver data using
spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we
can directly pass a struct spi_device.
Signed-off-by: Jingoo Han
---
drivers/misc/lattice-ecp3-config.c |2 +-
1 files changed, 1 insertion
On Friday, April 05, 2013 3:57 PM, Tomi Valkeinen wrote:
>
> Hi,
>
> On 2013-03-29 03:40, Jingoo Han wrote:
> > VESA_DMT_VSYNC_HIGH should be used instead of VESA_DMT_HSYNC_HIGH,
> > because FB_SYNC_VERT_HIGH_ACT is related to vsync, not to hsync.
> >
> &g
Use the wrapper functions for getting and setting the driver data using
spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we
can directly pass a struct spi_device.
Signed-off-by: Jingoo Han
---
drivers/mfd/wm831x-spi.c |6 +++---
1 files changed, 3 insertion
Use the wrapper functions for getting and setting the driver data using
spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we
can directly pass a struct spi_device.
Signed-off-by: Jingoo Han
---
drivers/mfd/da9052-spi.c |4 ++--
1 files changed, 2 insertion
Use the wrapper functions for getting and setting the driver data using
spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we
can directly pass a struct spi_device.
Signed-off-by: Jingoo Han
---
drivers/mfd/ezx-pcap.c |4 ++--
1 files changed, 2 insertions(+), 2 de
Use the wrapper functions for getting and setting the driver data using
spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we
can directly pass a struct spi_device.
Signed-off-by: Jingoo Han
---
drivers/mfd/mc13xxx-spi.c |6 +++---
1 files changed, 3 insertion
Use the wrapper functions for getting and setting the driver data using
spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we
can directly pass a struct spi_device.
Signed-off-by: Jingoo Han
---
drivers/mfd/arizona-spi.c |2 +-
1 files changed, 1 insertions(+), 1 de
Use the wrapper functions for getting and setting the driver data using
spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we
can directly pass a struct spi_device.
Signed-off-by: Jingoo Han
---
drivers/mfd/stmpe-spi.c |2 +-
1 files changed, 1 insertions(+), 1 de
Use dev_dbg() instaed of pr_debug() to be consistent.
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-s3c.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
index 0c397ac..fb994e9 100644
--- a/drivers/rtc/rtc
On Thursday, January 24, 2013 10:45 PM, Vivek Gautam wrote
>
> Using specific chip in compatible strings. Newer SOCs can claim
> device by using older string in the compatible list.
>
> Signed-off-by: Vivek Gautam
> Acked-by: Grant Likely
> Reviewed-by: Doug Anderson
On Thursday, January 24, 2013 10:45 PM, Vivek Gautam wrote
>
> Using specific chip in compatible strings. Newer SOCs can claim
> device by using older string in the compatible list.
>
> Signed-off-by: Vivek Gautam
> Acked-by: Grant Likely
> Reviewed-by: Doug Anderson
On Thursday, January 24, 2013 10:45 PM, Dan Carpenter wrote
CC'ed Andrew Morton, Inki Dae.
>
> gamma_table has 3 arrays which each hold MAX_GAMMA_LEVEL pointers to
> int.
>
> The current code sets ->gamma_table_count to 6 on 64bit arches and to 3
> on 32 bit arches. It should be 3 on everythin
problems. It looks good.
However, some hardcoded numbers need to be changed
to the bit definitions.
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
>
> Tested on sh73a0-based kzm9g board. As the commit message says, only one
> mode has been tested and is enabled. That mode copies
On Friday, January 25, 2013 4:49 PM, Guennadi Liakhovetski wrote
>
> Hi Jingoo Han
>
> On Fri, 25 Jan 2013, Jingoo Han wrote:
>
> > On Wednesday, January 09, 2013 2:55 AM, Guennadi Liakhovetski wrote
> > >
> > > This is an initial commit of a bac
On Saturday, February 23, 2013 6:26 AM, Andrew Morton wrote:
>
> On Fri, 22 Feb 2013 19:42:59 +0900
> Jingoo Han wrote:
>
> > Instead of using legacy suspend/resume methods, using newer dev_pm_ops
> > structure allows better control over power management.
> >
>
Instead of using legacy suspend/resume methods, using newer dev_pm_ops
structure allows better control over power management.
Signed-off-by: Jingoo Han
---
Changes since v1:
- Remove unnecessary ifdefs.
drivers/video/backlight/ams369fg06.c | 21 ++---
1 files changed, 10
On Saturday, February 23, 2013 6:44 AM, Andrew Morton wrote:
>
> On Fri, 22 Feb 2013 14:39:40 +0900
> Jingoo Han wrote:
>
> > A misplaced #endif causes link errors related to pcim_*() functions.
> >
> > --- a/lib/devres.c
> > +++ b/lib/devres.c
> >
ed reference to `pcim_iomap_regions'
drivers/ata/libata-sff.c:2329: undefined reference to `pcim_iomap_table
Signed-off-by: Jingoo Han
---
Changes since v1:
- Added more detailed commit message
lib/devres.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/devres.c
These functios allows the driver core to automatically clean up
any allocation made by rtc drivers. Thus, it simplifies the error
paths.
Signed-off-by: Jingoo Han
---
drivers/rtc/class.c | 72 +++
include/linux/rtc.h |6
2 files changed
When the macro such as SIMPLE_DEV_PM_OPS is used, there is
no need to use '#ifdef CONFIG_PM' to prevent build error. Thus,
this patch removes unnecessary ifdefs.
Signed-off-by: Jingoo Han
---
drivers/video/backlight/platform_lcd.c |6 ++
1 files changed, 2 insertions(+), 4
When the macro such as SIMPLE_DEV_PM_OPS is used, there is
no need to use '#ifdef CONFIG_PM' to prevent build error. Thus,
this patch removes unnecessary ifdefs.
Signed-off-by: Jingoo Han
Cc: Thierry Reding
---
drivers/video/backlight/pwm_bl.c |7 ++-
1 files changed, 2
These functios allows the driver core to automatically clean up
any allocation made by rtc drivers. Thus, it simplifies the error
paths.
Signed-off-by: Jingoo Han
---
Changes since v1:
- Simplified 'if' statements using WARN_ON()
- Added a description of the retur
> the code in question is complex / fragile. Here, the code involved is
> like 20 lines and self-contained.
OK, I see.
Thank you for your comment.
I will send v3 patch soon :)
Best regards,
Jingoo Han
>
> Thanks.
>
> --
> tejun
--
To unsubscribe from this list
These functios allows the driver core to automatically clean up
any allocation made by rtc drivers. Thus, it simplifies the error
paths.
Signed-off-by: Jingoo Han
---
Changes since v2:
- Removed unnecessary WARN_ON() of devm_rtc_device_match()
Changes since v1:
- Simplified 'if'
devres_release() can simplify the code, because devres_release()
will call the destructor for the resource as well as freeing
the devres data.
Signed-off-by: Jingoo Han
---
drivers/pinctrl/core.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/core.c b
On Wednesday, February 27, 2013 7:33 AM, Dmitry Torokhov wrote:
>
> On Tue, Feb 26, 2013 at 10:21:06AM +0900, Jingoo Han wrote:
> > +/**
> > + * devm_rtc_device_unregister - resource managed
> > devm_rtc_device_unregister()
> > + * @dev: the device to unregist
This patch uses module_platform_driver() macro which makes
the code smaller and simpler.
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-max77686.c | 12 +---
1 files changed, 1 insertions(+), 11 deletions(-)
diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
index
This patch adds missing module author name to MODULE_AUTHOR macro.
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-max77686.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
index a8e31fc..4da2a55 100644
--- a
Use devm_kzalloc() to make cleanup paths more simple.
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-max77686.c |9 ++---
1 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
index 4da2a55..36b1f5c 100644
--- a/drivers/rtc
This patch fixes indentation of bit definitions to enhance the
readability.
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-max77686.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
index 36b1f5c..9de93e7
dev_info()/dev_emerg() are more preferred than pr_info()/pr_emerg().
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-max77686.c | 15 +--
1 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
index 9de93e7..df66bab
On Wednesday, February 27, 2013 10:13 PM, Ian Lartey wrote:
>
> The Palmas familly of chips has LED support. This is not always muxed
> to output pins so depending on the setting of the mux this driver
> will create the appropriate LED class devices.
Hi Ian Lartey,
I added some minor comments :)
CONFIG_HOTPLUG was removed, so __devexit or __exit of remove()
should not be used.
Signed-off-by: Jingoo Han
---
drivers/video/backlight/atmel-pwm-bl.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/atmel-pwm-bl.c
b/drivers/video/backlight
__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.
Signed-off-by: Jingoo Han
__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.
Signed-off-by: Jingoo Han
__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.
Signed-off-by: Jingoo Han
__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.
Signed-off-by: Jingoo Han
__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.
Signed-off-by: Jingoo Han
__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.
Signed-off-by: Jingoo Han
__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.
Signed-off-by: Jingoo Han
__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.
Signed-off-by: Jingoo Han
__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.
Signed-off-by: Jingoo Han
__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.
Signed-off-by: Jingoo Han
__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.
Signed-off-by: Jingoo Han
__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.
Signed-off-by: Jingoo Han
__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.
Signed-off-by: Jingoo Han
__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.
Signed-off-by: Jingoo Han
__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.
Signed-off-by: Jingoo Han
__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.
Signed-off-by: Jingoo Han
__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.
Signed-off-by: Jingoo Han
__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.
Signed-off-by: Jingoo Han
__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.
Signed-off-by: Jingoo Han
On Thursday, February 28, 2013 5:56 PM, Geert Uytterhoeven wrote:
>
> On Thu, Feb 28, 2013 at 9:41 AM, Jingoo Han wrote:
> > __init/__exit annotations for probe()/remove() are supposed to be
> > __devinit/__devexit, because __init/__exit for probe()/remove()
> >
On Thursday, February 28, 2013 5:38 PM, Jingoo Han wrote:
>
> __init/__exit annotations for probe()/remove() are supposed to be
> __devinit/__devexit, because __init/__exit for probe()/remove()
> are not correct. However, __devinit/__devexit are not used,
> because CONFIG_HOTP
On Thursday, February 28, 2013 1:05 PM, Jingoo Han wrote:
>
> CONFIG_HOTPLUG was removed, so __devexit or __exit of remove()
> should not be used.
This driver also use platform_driver_probe().
So, this patch is useless.
Please, abandon this patch.
Thank you.
Best regards,
J
When platform_driver_probe() is used, bind/unbind via sysfs is
disabled. Thus, __init/__exit annotations can be added to
probe()/remove().
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-mv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/rtc/rtc-mv.c b/drivers
When platform_driver_probe() is used, bind/unbind via sysfs is
disabled. Thus, __init/__exit annotations can be added to
probe()/remove().
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-davinci.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc
When platform_driver_probe() is used, bind/unbind via sysfs is
disabled. Thus, __init/__exit annotations can be added to
probe()/remove().
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-ds1302.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-ds1302.c
When platform_driver_probe() is used, bind/unbind via sysfs is
disabled. Thus, __init/__exit annotations can be added to
probe()/remove().
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-imxdi.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/rtc/rtc-imxdi.c
When platform_driver_probe() is used, bind/unbind via sysfs is
disabled. Thus, __init/__exit annotations can be added to
probe()/remove().
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-pcap.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/rtc/rtc-pcap.c b
When platform_driver_probe() is used, bind/unbind via sysfs is
disabled. Thus, __init/__exit annotations can be added to
probe()/remove().
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-tegra.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/rtc/rtc-tegra.c
When platform_driver_probe() is used, bind/unbind via sysfs is
disabled. Thus, __init/__exit annotations can be added to
probe()/remove().
Signed-off-by: Jingoo Han
---
drivers/rtc/rtc-nuc900.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/rtc/rtc-nuc900
1 - 100 of 1882 matches
Mail list logo
