> -----Original Message----- > From: Sachin Kamat [mailto:sachin.ka...@linaro.org] > Sent: Tuesday, March 19, 2013 12:33 PM > To: Jingoo Han > Cc: MyungJoo Ham; Chanwoo Choi; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 2/2] extcon: max8997: add missing const > > On 19 March 2013 07:33, Jingoo Han <jg1....@samsung.com> wrote: > > Fixed the checkpatch warning as below: > > > > WARNING: static const char * array should probably be static const char * > > const > > #163: FILE: drivers/extcon/extcon-max8997.c:163: > > +static const char *max8997_extcon_cable[] = { > > > > Signed-off-by: Jingoo Han <jg1....@samsung.com> > > --- > > drivers/extcon/extcon-max8997.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/extcon/extcon-max8997.c > > b/drivers/extcon/extcon-max8997.c > > index 20772ad..6e8724f 100644 > > --- a/drivers/extcon/extcon-max8997.c > > +++ b/drivers/extcon/extcon-max8997.c > > @@ -160,7 +160,7 @@ enum { > > _EXTCON_CABLE_NUM, > > }; > > > > -static const char *max8997_extcon_cable[] = { > > +static const char const *max8997_extcon_cable[] = { > > Shouldn't this be "static const char * const max8997_extcon_cable[]" > as suggested by checkpatch (as mentioned in your commit log)?
Hi Sachin Kamat, Although the checkpatch warning is already fixed, I will send v2 patch for clarity. Thank you for your comment. Best regards, Jingoo Han > > > -- > With warm regards, > Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
