Re: [RFC] Staging: imx-drm: Do not use fractional part of divider

2013-06-14 Thread Jiada Wang
Hello Alexander Alexander Shiyan wrote: Hello. Analysis of driver imx-drm led me to believe that the use fractional part of the divider is not always a good idea. For example, for a parallel display bus connected to LVDS converter chip (DS90C363), in this case the use of fractional part, clo

Re: [PATCH RFC 0/5] *** SPI Slave mode support ***

2017-05-29 Thread Jiada Wang
Hi Fabio On 05/29/2017 05:01 AM, Fabio Estevam wrote: Hi Jiada, On Thu, Apr 27, 2017 at 3:43 AM, Jiada Wang wrote: BUT if you think the use case don't need to be supported from SPI core, then I don't have objection either, I will only submit imx SPI slave support patch, after your

Re: [PATCH linux-next 1/1] ASoC: rsnd: ssiu: reset SSI_MODE register

2017-10-30 Thread Jiada Wang
have different value. This patch resets SSI_MODE register in .stop callback, when last stream calls .stop. Fixes: 186fadc132f0 ("ASoC: rsnd: add TDM Extend Mode support") Signed-off-by: Jiada Wang --- sound/soc/sh/rcar/ssiu.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/s

[PATCH 1/2] ASoC: WM8962: mark cache_dirty flag after software reset in pm_resume

2015-10-06 Thread Jiada Wang
By doing software reset of wm8962 in pm_resume, all registers which have already been set will be reset to default value without regmap interface be involved, thus driver need to mark cache_dirty flag, to let regcache can be updated by regcache_sync(). Signed-off-by: Jiada Wang --- sound/soc

[PATCH 0/2] *** wm8962 regmap related fix ***

2015-10-06 Thread Jiada Wang
962's regulator is set to 'regulator-always-on' mode, then after wm8962 is resumed from suspend, wm8962 codec is reset, but cache_dirty flag isn't set, this cause difference between actual wm8962 HW and regmap cache. Jiada Wang (2): ASoC: WM8962: mark cache_dirty flag after so

[PATCH 2/2] ASoC: Codec: wm8962: declare ALC Coefficients as 4 separate registers

2015-10-06 Thread Jiada Wang
which contains ALC1 ~ ALC3 and Noise Gate, this patch declares 4 separate registers, so that regmap can handle these registers differently based on their classification. Signed-off-by: Jiada Wang --- sound/soc/codecs/wm8962.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a

Re: [PATCH 1/2] ASoC: WM8962: mark cache_dirty flag after software reset in pm_resume

2015-10-07 Thread Jiada Wang
Hi On 10/06/2015 07:59 PM, Mark Brown wrote: On Tue, Oct 06, 2015 at 04:06:54PM +0900, Jiada Wang wrote: + /* All registers have been reset to default value without calling +* to regmap interface, even if reset fails, some registers +* maybe in intermediate status, so we

Re: [PATCH 2/2] ASoC: Codec: wm8962: declare ALC Coefficients as 4 separate registers

2015-10-07 Thread Jiada Wang
Hi On 10/06/2015 08:01 PM, Mark Brown wrote: On Tue, Oct 06, 2015 at 04:06:55PM +0900, Jiada Wang wrote: As ALC2 register is volatile, declare it as one of ALC Coefficients register together with other non-volatile registers will cause issue, in case wm8962 has enter suspend mode, and

[PATCH] usb: chipidea: udc: clear vbus_active flag in udc_stop

2015-10-19 Thread Jiada Wang
. This patch clears vbus_active flag in udc_stop callback. Signed-off-by: Jiada Wang --- drivers/usb/chipidea/udc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 8223fe7..b9ac228 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers

[PATCH v2 0/2] *** wm8962 regmap related fix ***

2015-10-19 Thread Jiada Wang
962's regulator is set to 'regulator-always-on' mode, then after wm8962 is resumed from suspend, wm8962 codec is reset, but cache_dirty flag isn't set, this cause difference between actual wm8962 HW and regmap cache. Changeset: -- v1 -> v2 * removed comment before

[PATCH 2/2] ASoC: Codec: wm8962: declare ALC Coefficients as 4 separate registers

2015-10-19 Thread Jiada Wang
which contains ALC1 ~ ALC3 and Noise Gate, this patch declares 4 separate registers, so that regmap can handle these registers differently based on their classification. Signed-off-by: Jiada Wang --- sound/soc/codecs/wm8962.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a

[PATCH 1/2] ASoC: WM8962: mark cache_dirty flag after software reset in pm_resume

2015-10-19 Thread Jiada Wang
By doing software reset of wm8962 in pm_resume, all registers which have already been set will be reset to default value without regmap interface be involved, thus driver need to mark cache_dirty flag, to let regcache can be updated by regcache_sync(). Signed-off-by: Jiada Wang --- sound/soc

Re: [PATCH] usb: chipidea: udc: clear vbus_active flag in udc_stop

2015-10-19 Thread Jiada Wang
Hi On 10/20/2015 03:01 PM, Peter Chen wrote: On Tue, Oct 20, 2015 at 11:29:18AM +0900, Jiada Wang wrote: Currently in udc_stop, if vbus_active flag is true, all USB activities will be stopped, but vbus_active flag is still left to be true, this causes issue, when afterwards driver tries to

Re: [PATCH] usb: chipidea: udc: clear vbus_active flag in udc_stop

2015-10-19 Thread Jiada Wang
Hi On 10/20/2015 03:28 PM, Peter Chen wrote: On Tue, Oct 20, 2015 at 03:09:02PM +0900, Jiada Wang wrote: Hi On 10/20/2015 03:01 PM, Peter Chen wrote: On Tue, Oct 20, 2015 at 11:29:18AM +0900, Jiada Wang wrote: Currently in udc_stop, if vbus_active flag is true, all USB activities will be

[PATCH] ASoC: wm8962: set ALC2 as non-volatile register

2015-10-22 Thread Jiada Wang
in ALC2 aren't used anywhere nor are useful to end user, so this patch removes ALC2 register from volatile register list to make ALC2 be possible to be accessed when cache_only flag is set. Signed-off-by: Jiada Wang --- sound/soc/codecs/wm8962.c | 3 +-- 1 file changed, 1 insertion(

Re: [PATCH v2 4/8] spi: imx: add selection for iMX53 and iMX6 controller type

2015-10-25 Thread Jiada Wang
Hello Subject: [PATCH v2 4/8] spi: imx: add selection for iMX53 and iMX6 controller type ECSPI contorller for iMX53 and iMX6 has few hardware issues in slave mode and (32*n+1) SPI word size handling comparing to iMX51. The change add possibility to detect the SPI controller is use and apply wo

potential deadlock in cpufreq-dt

2018-07-19 Thread Jiada Wang
Hello all After enable lockdep, by poking /sys/kernel/debug/sched_features, I triggered the following lockdep report: [ 34.410559] == [ 34.416766] WARNING: possible circular locking dependency detected [ 34.422987] 4.14.50-03493-g65adcd3b

Re: Applied "ASoC: rsnd: ssi: fix race condition in rsnd_ssi_pointer_update" to the asoc tree

2018-01-08 Thread Jiada Wang
Hi Mark Only the first patch in https://www.spinics.net/lists/alsa-devel/msg71021.html was applied, but the second patch "ASoC: rsnd: ssi: remove unnesessary period_pos" was missed Could you please have a look Thanks, Jiada On 12/11/2017 03:38 AM, Mark Brown wrote: On Sat, Dec 09, 2017 at

Re: Applied "ASoC: rsnd: ssi: fix race condition in rsnd_ssi_pointer_update" to the asoc tree

2018-01-09 Thread Jiada Wang
Hi Sakamoto-san On 01/08/2018 10:53 PM, Takashi Sakamoto wrote: Hi Jiada, On Jan 9 2018 14:42, Jiada Wang wrote: Only the first patch in https://www.spinics.net/lists/alsa-devel/msg71021.html was applied, but the second patch "ASoC: rsnd: ssi: remove unnesessary period_pos"

Re: [PATCH linux-next v1 2/4] clk: renesas: Add binding document for AVB Counter Clock

2018-11-21 Thread Jiada Wang
Hi Stephen On 2018/11/04 12:14, Stephen Boyd wrote: Quoting Jiada Wang (2018-10-31 05:00:49) On 2018/10/30 3:29, Stephen Boyd wrote: Quoting jiada_w...@mentor.com (2018-10-25 00:23:47) +Required Properties: + - compatible: Must be "renesas,clk-avb" + - reg: Base address and len

[PATCH linux-next v3 2/7] clk: renesas: r8a7796: Add ADG clock

2018-12-04 Thread Jiada Wang
From: Takeshi Kihara This patch adds ADG clock to the R8A7796 SoC. Signed-off-by: Takeshi Kihara --- drivers/clk/renesas/r8a7796-cpg-mssr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c b/drivers/clk/renesas/r8a7796-cpg-mssr.c index 10567386e6dd..7

[PATCH linux-next v3 0/7] clk: renesas: adg: add AVB Clock

2018-12-04 Thread Jiada Wang
s v2: - expends adg register size and register avb clocks instead of add new clk-avb driver - Add adg clock v1: initial version Jiada Wang (2): ASoC: rsnd: add avb clocks clk: renesas: Add binding document for ADG Takeshi Kihara (5): clk: renesas: r8a7795: Add ADG clock clk: renesas: r8

[PATCH linux-next v3 3/7] clk: renesas: r8a77990: Add ADG clock

2018-12-04 Thread Jiada Wang
From: Takeshi Kihara This patch adds ADG clock to the R8A77990 SoC. Signed-off-by: Takeshi Kihara Signed-off-by: Jiada Wang --- drivers/clk/renesas/r8a77990-cpg-mssr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/renesas/r8a77990-cpg-mssr.c b/drivers/clk/renesas/r8a77990

[PATCH linux-next v3 4/7] clk: renesas: r8a77995: Add ADG clock

2018-12-04 Thread Jiada Wang
From: Takeshi Kihara This patch adds ADG clock to the R8A77995 SoC. Signed-off-by: Takeshi Kihara Signed-off-by: Jiada Wang --- drivers/clk/renesas/r8a77995-cpg-mssr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/renesas/r8a77995-cpg-mssr.c b/drivers/clk/renesas/r8a77995

[PATCH linux-next v3 1/7] clk: renesas: r8a7795: Add ADG clock

2018-12-04 Thread Jiada Wang
From: Takeshi Kihara This patch adds ADG clock to the R8A7795 SoC. Signed-off-by: Takeshi Kihara Signed-off-by: Jiada Wang --- drivers/clk/renesas/r8a7795-cpg-mssr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/renesas/r8a7795-cpg-mssr.c b/drivers/clk/renesas/r8a7795-cpg

[PATCH linux-next v3 5/7] clk: renesas: r8a77965: Add ADG clock

2018-12-04 Thread Jiada Wang
From: Takeshi Kihara This patch adds ADG clock to the R8A77965 SoC. Signed-off-by: Takeshi Kihara Signed-off-by: Jiada Wang --- drivers/clk/renesas/r8a77965-cpg-mssr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/renesas/r8a77965-cpg-mssr.c b/drivers/clk/renesas/r8a77965

[PATCH linux-next v3 7/7] clk: renesas: Add binding document for ADG

2018-12-04 Thread Jiada Wang
Add device tree bindings for Audio Clock Generator (ADG) of R-Car Socs. Signed-off-by: Jiada Wang --- .../clock/renesas,rcar-adg-clocks.txt | 24 +++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/renesas,rcar-adg-clocks.txt

[PATCH linux-next v3 6/7] ASoC: rsnd: add avb clocks

2018-12-04 Thread Jiada Wang
There are AVB Counter Clocks in ADG, each clock has 12bits integral and 8 bits fractional dividers which operates with S0D1ϕ clock. This patch registers 8 AVB Counter Clocks when clock-cells of rcar_sound node is 2, Signed-off-by: Jiada Wang --- sound/soc/sh/rcar/adg.c | 316

Re: [PATCH linux-next v3 6/7] ASoC: rsnd: add avb clocks

2018-12-05 Thread Jiada Wang
rcar_sound node is 2, Signed-off-by: Jiada Wang --- +static void clk_avb_div_write(struct rsnd_adg *adg, u32 data, unsigned int idx) (snip) +static u32 clk_avb_div_read(struct rsnd_adg *adg, unsigned int idx) As I mentioned before, I think we can avoid confusable parameter by static

Re: [PATCH linux-next v3 7/7] clk: renesas: Add binding document for ADG

2018-12-05 Thread Jiada Wang
Hi Morimoto-san will rename dt bindings doc in next version Thanks. Jiada On 2018/12/05 18:04, Kuninori Morimoto wrote: Hi Jiada Add device tree bindings for Audio Clock Generator (ADG) of R-Car Socs. Signed-off-by: Jiada Wang --- .../clock/renesas,rcar-adg-clocks.txt | 24

Re: [PATCH linux-next v3 6/7] ASoC: rsnd: add avb clocks

2018-12-05 Thread Jiada Wang
Hi Morimoto-san Thanks for your comments On 2018/12/06 9:59, Kuninori Morimoto wrote: Hi Jiada + avb = devm_kzalloc(dev, sizeof(*avb), GFP_KERNEL); + if (!avb) + return ERR_PTR(-ENOMEM); + + parent_name = __clk_get_name(adg->clkadg); This parent_name is very s

Re: [PATCH linux-next v3 6/7] ASoC: rsnd: add avb clocks

2018-12-05 Thread Jiada Wang
Hi Morimoto-san On 2018/12/06 14:38, Kuninori Morimoto wrote: Hi Jiada SMSTPCR922 controls input of two clocks "S0D1ϕ" and "S0D4ϕ", Ahh, OK I could check it via Block diagram. But it is "Module stop" for these, anyway. "Module stop" and "S0D1ϕ/S0D4ϕ" are completely different clocks. Yes, "m

Re: [PATCH linux-next v2 0/6] clk: renesas: adg: add AVB Clock

2018-12-04 Thread Jiada Wang
Hi Vladimir Thanks for your comments On 2018/12/03 21:11, Vladimir Zapolskiy wrote: Hi Jiada, On 12/03/2018 01:21 PM, jiada_w...@mentor.com wrote: From: Jiada Wang on R-Car SoCs there are AVB Counter Clocks, each clock has 12bits integral and 8 bits fractional dividers which operates with

Re: [PATCH linux-next v2 6/6] ASoC: rsnd: add avb clocks

2018-12-04 Thread Jiada Wang
Hi Vladimir Thanks for your comments I will address your findings in next version Thanks, Jiada On 2018/12/03 21:53, Vladimir Zapolskiy wrote: Hi Jiada, On 12/03/2018 01:24 PM, jiada_w...@mentor.com wrote: From: Jiada Wang There are AVB Counter Clocks in ADG, each clock has 12bits

Re: [PATCH linux-next v2 6/6] ASoC: rsnd: add avb clocks

2018-12-04 Thread Jiada Wang
. This patch registers 8 AVB Counter Clocks when clock-cells of rcar_sound node is 2, Signed-off-by: Jiada Wang --- (snip) +struct clk_avb { + struct clk_hw hw; + unsigned int idx; + struct rsnd_mod *mod; + /* lock reg access */ + spinlock_t *lock; +}; + +#define

Re: [alsa-devel] [PATCH linux-next v2 9/9] ASoC: rsnd: add busif property to dai stream

2018-10-09 Thread Jiada Wang
Hi Morimoto-san Thanks for your comment On 2018/10/09 9:44, Kuninori Morimoto wrote: Hi Jiada SSI can work in following modes 1. Basic Mode: (channel 1, 2, 4, 6, 8, 16) 2. TDM Extended Mode: (channel 6, 8) 3. TDM Split Mode: (channel 1, 2) 4. TDM Ex-Split mode: (Channel 2, 4, 6, 8, 10) (snip

Re: [alsa-devel] [PATCH linux-next v2 9/9] ASoC: rsnd: add busif property to dai stream

2018-10-09 Thread Jiada Wang
Hi Morimoto-san Thanks for your feedback On 2018/10/09 16:47, Kuninori Morimoto wrote: Hi Jiada Thanks for your feedback 1ch:  (tdm_slots < 4) Basic mode, (tdm_slots >= 4) TDM Split mode 2ch: (2 <= tdm_slots < 8) Basic mode, (tdm_slots >= 8) TDM Ex-Split mode 4ch: (4 <= tdm_slots < 8) Basic

Re: [alsa-devel] [PATCH linux-next v2 9/9] ASoC: rsnd: add busif property to dai stream

2018-10-03 Thread Jiada Wang
() to automatically select BUSIF (currently only BUSIF0 is selected) Signed-off-by: Jiada Wang --- sound/soc/sh/rcar/core.c | 3 +++ sound/soc/sh/rcar/dma.c | 31 +++ sound/soc/sh/rcar/rsnd.h | 3 +++ sound/soc/sh/rcar/ssi.c | 30

Re: [PATCH linux-next v2 8/9] ASoC: rsnd: ssi: Request dedicated dma channels for busif0 to 7

2018-10-03 Thread Jiada Wang
data transfer through these busif. Signed-off-by: Jiada Wang --- (snip) + if (rsnd_ssi_use_busif(io)) { + if (is_play) + snprintf(name, SSI_DMA_NAME_SIZE, "rxu"); + else + snprintf(name, SSI_DMA_NAME_

Re: [PATCH linux-next v2 1/9] arm64: r8a7795: add dma request number for busif0 ~ busif7

2018-10-03 Thread Jiada Wang
Hi Morimoto-san On 2018/10/04 9:55, Kuninori Morimoto wrote: Hi Jiada Thank you for your patch From: Jiada Wang This patch adds dma request number for busif0 ~ busif7 to be used by GEN3 series. GEN2 continues to use rxu/txu for busif data transfer. Signed-off-by: Jiada Wang --- arch

Re: [alsa-devel] [PATCH linux-next v2 9/9] ASoC: rsnd: add busif property to dai stream

2018-10-04 Thread Jiada Wang
. Also adds rsnd_ssi_select_busif() to automatically select BUSIF (currently only BUSIF0 is selected) Signed-off-by: Jiada Wang --- (snip) And this patch selects it on runtime (= hw_param) ? Because, in order to automatically determine BUSIF number, information like SSI mode (non-Split/Split/Ex

[PATCH v1 03/15] serial: imx: remove unneeded imx_transmit_buffer() from imx_start_tx()

2014-12-09 Thread Jiada Wang
From: Dirk Behme Use imx_start_tx() just to enable the TX interrupt. It's the job of the TX interrupt ISR to fill the transmit buffer, then. If the transmit buffer is empty, the TX interrupt should be executed as soon as the start_tx() enables the interrupt, so there is no reason for the extra im

[PATCH v1 08/15] Revert "serial: imx: always wake up the processes in the TX callback"

2014-12-09 Thread Jiada Wang
a threshold. Signed-off-by: Jiada Wang --- drivers/tty/serial/imx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 3db6a5b..3d86851 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -516,7

[PATCH v1 11/15] serial: imx: initialized DMA w/o HW flow enabled

2014-12-09 Thread Jiada Wang
From: Anton Bondarenko DMA mode for UART can be used even w/o HW flow control with RTS/CTS. So it need to be initialized and enabled earlier. Signed-off-by: Anton Bondarenko Signed-off-by: Jiada Wang --- drivers/tty/serial/imx.c | 15 --- 1 file changed, 8 insertions(+), 7

[PATCH v1 15/15] serial: imx: Support sw flow control in DMA mode

2014-12-09 Thread Jiada Wang
This patch adds Software flow control support in DMA mode. Signed-off-by: Jiada Wang --- drivers/tty/serial/imx.c | 30 -- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 301cf8c..642e88e 100644

[PATCH v1 14/15] serial: imx: Fix issue in software flow control

2014-12-09 Thread Jiada Wang
After send out x_char in UART driver, x_char needs to be cleared by UART driver itself, otherwise data in TXFIFO can no longer be sent out. Also tx counter needs to be increased to keep track of correct number of transmitted data. Signed-off-by: Jiada Wang --- drivers/tty/serial/imx.c | 2 ++ 1

[PATCH v1 13/15] serial: imx: Enable UCR4_OREN in startup interface

2014-12-09 Thread Jiada Wang
Other than enable Receiver Overrun Interrupt Enable (UCR4_OREN) in start_tx interface, UCR4_OREN should be enabled before enable of Receiver. Signed-off-by: Jiada Wang --- drivers/tty/serial/imx.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/tty

[PATCH v1 10/15] serial: imx: disable TDMAEN in imx_flush_buffer()

2014-12-09 Thread Jiada Wang
From: Dirk Behme Terminating the DMA, make sure the interrupt is disabled, too. This fixes random kernel Oops due to dma_tx_call() called for invalid transmissions. If we disable the TDMAEN, make sure it's enabled again if a TX DMA is started. Signed-off-by: Jiada Wang Signed-off-by:

[PATCH v1 12/15] serial: imx: start rx_dma once RXFIFO is not empty

2014-12-09 Thread Jiada Wang
From: Robin Gong Start rx_dma once RXFIFO is not empty that can avoid dma request lost and causes data delay issue. Signed-off-by: Robin Gong Signed-off-by: Fugang Duan --- drivers/tty/serial/imx.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/tty

[PATCH v1 09/15] serial: imx: call imx_dma_tx() again in dma_tx_callback

2014-12-09 Thread Jiada Wang
uart hasn't been stopped. Signed-off-by: Jiada Wang Signed-off-by: Dirk Behme --- drivers/tty/serial/imx.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 3d86851..c9e6891 100644 --- a/drivers/tty/serial/imx.c +++ b/driver

[PATCH v1 07/15] serial: imx: use dma_is_txing to synchronize dma_tx_callback and imx_dma_tx

2014-12-09 Thread Jiada Wang
From: Dirk Behme To synchronize between dma_tx_callback() and imx_dma_tx() use the same variable, dma_is_txing. This prevents any race between these two functions and ensures that a new DMA can start only after the first has been finished. Before the new DMA can be set up, update the circular bu

[PATCH v1 06/15] serial: imx: unmap scatter gather list in imx_flush_buffer

2014-12-09 Thread Jiada Wang
From: Dirk Behme First, reformat the code to exit immediately. This allows us to add more code in more readable format. In case the TX DMA was still running, remove and disable it's resources. Signed-off-by: Dirk Behme --- drivers/tty/serial/imx.c | 13 ++--- 1 file changed, 10 insert

[PATCH v1 05/15] serial: imx: unmap sg in case of dmaengine_prep_slave_sg() failure

2014-12-09 Thread Jiada Wang
From: Dirk Behme In case dmaengine_prep_slave_sg() fails, add the missing dma_unmap_sg(). Signed-off-by: Dirk Behme Signed-off-by: Anton Bondarenko --- drivers/tty/serial/imx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index f4b

[PATCH v1 01/15] serial: imx: add CREAD flag support

2014-12-09 Thread Jiada Wang
Add CREAD flag hanlding in set_termios and UART DMA mode which ignores all received chars when CREAD flag cleared. Signed-off-by: Jiada Wang Signed-off-by: Anton Bondarenko --- drivers/tty/serial/imx.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/tty

[PATCH v1 02/15] serial: imx: use locking to stop concurrent access of UCR1

2014-12-09 Thread Jiada Wang
Several places are accessing the UCR1 register without locking. This probably will cause a race issue when another thread is accessing the same register. Add locking to preventing concurrent access of the UCR1 register. Signed-off-by: Jiada Wang --- drivers/tty/serial/imx.c | 12 1

[PATCH v1 00/15] serial: imx: misc fix and features

2014-12-09 Thread Jiada Wang
imx_flush_buffer() Jiada Wang (7): serial: imx: add CREAD flag support serial: imx: use locking to stop concurrent access of UCR1 Revert "serial: imx: always wake up the processes in the TX callback" serial: imx: call imx_dma_tx() again in dma_tx_callback serial: imx: Enable UC

[PATCH v1 04/15] serial: imx: TX DMA: clean up sg initialization

2014-12-09 Thread Jiada Wang
From: Dirk Behme Inverting the logic of the if statement for the sg initialization makes the if statement easier and better to read. No functional change. Signed-off-by: Dirk Behme --- drivers/tty/serial/imx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH v2] serial: imx: protect Soft Reset of port with lock

2015-04-13 Thread Jiada Wang
: Jiada Wang --- drivers/tty/serial/imx.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index c8cfa06..38717c7 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -1114,6 +1114,12 @@ static

Re: [PATCHv2,1/7] sched: Add static_key for asymmetric cpu capacity optimizations

2018-04-27 Thread Jiada Wang
Hi with this patch, if enable CONFIG_DEBUG_ATOMIC_SLEEP=y, then I am getting following BUG report during early startup Backtrace caused by [1] during early kernel startup: [ 5.325288] CPU: All CPU(s) started at EL2 [ 5.325700] alternatives: patching kernel code [ 5.329255] BUG: sleeping function

Re: [PATCH v1 1/1] thermal: rcar_gen3_thermal: request IRQ after device initialization

2019-04-16 Thread Jiada Wang
Hi Daniel On 2019/04/17 4:22, Daniel Lezcano wrote: On 11/04/2019 12:03, Jiada Wang wrote: Currently IRQ is remain enabled after .remove, later if device is probed, IRQ is requested before .thermal_init, this may cause IRQ function be triggered but not able to clear IRQ status, thus cause

Re: [PATCH v1 1/1] thermal: rcar_gen3_thermal: request IRQ after device initialization

2019-04-16 Thread Jiada Wang
Hi Eugeniu thanks for your test & comments and adding more people for review I will add necessary backtrace information to description and rephrase commit summary in V2 patch Thanks, Jiada On 2019/04/17 2:48, Eugeniu Rosca wrote: Hi Jiada, Adding below people, since they've made recent contr

Re: [PATCH v1 1/1] thermal: rcar_gen3_thermal: request IRQ after device initialization

2019-04-18 Thread Jiada Wang
Hi Daniel Thanks for your comments On 2019/04/17 17:05, Daniel Lezcano wrote: On 17/04/2019 05:01, Jiada Wang wrote: Hi Daniel On 2019/04/17 4:22, Daniel Lezcano wrote: On 11/04/2019 12:03, Jiada Wang wrote: Currently IRQ is remain enabled after .remove, later if device is probed, IRQ is

[PATCH v4 2/2] thermal: rcar_gen3_thermal: disable interrupt in .remove

2019-04-23 Thread Jiada Wang
. Signed-off-by: Jiada Wang --- drivers/thermal/rcar_gen3_thermal.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c index 065e16f53285..280230951dfe 100644 --- a/drivers/thermal/rcar_gen3_thermal.c +++ b/drivers/thermal

[PATCH v4 1/2] thermal: rcar_gen3_thermal: fix interrupt type

2019-04-23 Thread Jiada Wang
) Signed-off-by: Jiada Wang --- drivers/thermal/rcar_gen3_thermal.c | 38 + 1 file changed, 6 insertions(+), 32 deletions(-) diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c index 88fa41cf16e8..065e16f53285 100644 --- a/

[PATCH v4 0/2] thermal: rcar_gen3_thermal: fix IRQ issues

2019-04-23 Thread Jiada Wang
fix typos in ("thermal: rcar_gen3_thermal: disable interrupt in .remove") v3: fix to use correct code base remove unused "flag" variable in rcar_gen3_thermal_irq v2: use irq type IRQF_ONESHOT instead of IRQF_SHARED disable interrupt in .remove v1: initial version

Re: [PATCH linux-next v2 1/2] ASoC: rsnd: src: Avoid a potential deadlock

2019-03-13 Thread Jiada Wang
Hi Geert On 2019/03/12 18:15, Geert Uytterhoeven wrote: Hi Jiada, Fabrizio, On Thu, Mar 7, 2019 at 7:17 AM Jiada Wang wrote: lockdep warns us that priv->lock and k->k_lock can cause a deadlock when after acquire of k->k_lock, process is interrupted by src, while in another routi

[PATCH v1 1/1] thermal: rcar_gen3_thermal: request IRQ after device initialization

2019-04-11 Thread Jiada Wang
issue. Signed-off-by: Jiada Wang --- drivers/thermal/rcar_gen3_thermal.c | 48 - 1 file changed, 26 insertions(+), 22 deletions(-) diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c index 88fa41cf16e8..4d095d7f9763 100644 --- a/drivers

Re: Bug in spi: imx: Add support for SPI Slave mode

2019-02-26 Thread Jiada Wang
Hi Trent Thanks for reporting On 2019/02/27 6:41, Trent Piepho wrote: On Tue, 2017-09-05 at 14:12 +0900, Jiada Wang wrote: Previously i.MX SPI controller only works in Master mode. This patch adds support to i.MX51, i.MX53 and i.MX6 ECSPI controller to work also in Slave mode. Recently DMA

[PATCH 1/2] Input: atmel_mxt_ts - output status from T48 Noise Suppression

2020-07-29 Thread Jiada Wang
symbolic names, Fixed typo in commit title & message] Signed-off-by: Jiada Wang --- drivers/input/touchscreen/atmel_mxt_ts.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_

[PATCH 2/2] Input: atmel_mxt_ts - output status from T42 Touch Suppression

2020-07-29 Thread Jiada Wang
() with dev_dbg(), Move logical continuation to previous line to address checkpatch CHECK] Signed-off-by: Jiada Wang --- drivers/input/touchscreen/atmel_mxt_ts.c | 25 1 file changed, 25 insertions(+) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers

[PATCH 1/1] Input: atmel_mxt_ts - allow specification of firmware file name

2020-07-31 Thread Jiada Wang
: Nick Dyer Acked-by: Benson Leung Acked-by: Yufeng Shen (cherry picked from ndyer/linux/for-upstream commit 76ebb7cee971cb42dfb0a3a9224403b8b09abcf1) [gdavis: Forward port and fix conflicts.] Signed-off-by: George G. Davis Signed-off-by: Jiada Wang --- drivers/input/touchscreen/atmel_mxt_ts.c

[PATCH v2] Bluetooth: BCSP fails to ACK re-transmitted frames from the peer

2014-07-15 Thread Jiada Wang
Dean Jenkins Signed-off-by: Jiada Wang --- drivers/bluetooth/hci_bcsp.c | 94 1 file changed, 60 insertions(+), 34 deletions(-) diff --git a/drivers/bluetooth/hci_bcsp.c b/drivers/bluetooth/hci_bcsp.c index 21cc45b..0f4664d 100644 --- a/drivers/blue

Re: [PATCH v2] Bluetooth: BCSP fails to ACK re-transmitted frames from the peer

2014-07-15 Thread Jiada Wang
ed in out of order reliable frame. Signed-off-by: Dean Jenkins Signed-off-by: Jiada Wang --- drivers/bluetooth/hci_bcsp.c | 94 1 file changed, 60 insertions(+), 34 deletions(-) diff --git a/drivers/bluetooth/hci_bcsp.c b/drivers/bluetooth/hci_bcsp.c

[PATCH v3] Bluetooth: BCSP fails to ACK re-transmitted frames from the peer

2014-07-15 Thread Jiada Wang
Dean Jenkins Signed-off-by: Jiada Wang --- drivers/bluetooth/hci_bcsp.c | 85 ++-- 1 file changed, 51 insertions(+), 34 deletions(-) diff --git a/drivers/bluetooth/hci_bcsp.c b/drivers/bluetooth/hci_bcsp.c index 21cc45b..602f2a1 100644 --- a/drivers/blue

[PATCH v4] Bluetooth: BCSP fails to ACK re-transmitted frames from the peer

2014-07-15 Thread Jiada Wang
Dean Jenkins Signed-off-by: Jiada Wang --- drivers/bluetooth/hci_bcsp.c | 85 ++-- 1 file changed, 51 insertions(+), 34 deletions(-) diff --git a/drivers/bluetooth/hci_bcsp.c b/drivers/bluetooth/hci_bcsp.c index 21cc45b..a0cbd69 100644 --- a/drivers/blue

Re: [PATCH v1 00/10] *** imx-sdma: misc fix ***

2016-05-25 Thread Jiada Wang
Hello On 05/17/2016 07:04 PM, Vinod Koul wrote: On Tue, May 17, 2016 at 12:47:46PM +0900, Jiada Wang wrote: this patch set contains the following changes 1. fix issues in cyclic dma 2. add support to SYNC DMA termination 3. avoid system hang, when SDMA channel 0 timeouts 4. add lock to prevent

[PATCH v1 00/10] *** imx-sdma: misc fix ***

2016-05-16 Thread Jiada Wang
this patch set contains the following changes 1. fix issues in cyclic dma 2. add support to SYNC DMA termination 3. avoid system hang, when SDMA channel 0 timeouts 4. add lock to prevent race condition Jiada Wang (10): dma: imx-sdma: use chn_real_count to report residue for UART dma: imx-sdma

[PATCH 02/10] dma: imx-sdma: don't update BD in isr routine

2016-05-16 Thread Jiada Wang
So move updating of BD back to tasklet. Signed-off-by: Jiada Wang --- drivers/dma/imx-sdma.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 1f1b64b..887e4e5 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dm

[PATCH 03/10] dma: imx-sdma: clear BD_RROR flag before pass it to sdma script

2016-05-16 Thread Jiada Wang
ssful, but as BD_RROR flag is set, client side will still think the transfer failed. This patch clears BD_RROR flag before pass it to sdma script. Signed-off-by: Jiada Wang --- drivers/dma/imx-sdma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-s

[PATCH 07/10] dma: imx-sdma: Add synchronization support

2016-05-16 Thread Jiada Wang
for all currently running complete callbacks to finish. Signed-off-by: Jiada Wang --- drivers/dma/imx-sdma.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 040cbf2..0b23407 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma

[PATCH 09/10] dma: imx-sdma: disable channel 0 when it timeouts

2016-05-16 Thread Jiada Wang
Previously when channel0 timeouts to finish its task, sdma_run_channel0() just returns without disable channel0, this will cause continuous interrupt later when channel0 finishs its task and set channel0 interrupt bit. Signed-off-by: Jiada Wang --- drivers/dma/imx-sdma.c | 43

[PATCH 10/10] dma: imx-sdma: clear channel0 interrupt bit in irq routine

2016-05-16 Thread Jiada Wang
nnel0 timeouts, it won't cause irq storm, also adds lock to prevent irq routine to clear this bit when sdma_run_channel0() is busy checking it. Signed-off-by: Jiada Wang --- drivers/dma/imx-sdma.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/dma/imx-sdma.c

[PATCH 06/10] dma: imx-sdma: add terminate_all support

2016-05-16 Thread Jiada Wang
Implement device_terminate_all(), so that dmaengine_terminate_async() can work. Signed-off-by: Jiada Wang --- drivers/dma/imx-sdma.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index ef5d37c..040cbf2 100644 --- a/drivers/dma/imx

[PATCH 04/10] dma: imx-sdma: update sdma channel status for cyclic dma

2016-05-16 Thread Jiada Wang
buffer descriptor. Signed-off-by: Jiada Wang --- drivers/dma/imx-sdma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 1489de0..36f5e39 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -670,6 +670,8 @@ static void

[PATCH 05/10] dma: imx-sdma: add flag to indicate SDMA channel state

2016-05-16 Thread Jiada Wang
nnel to indicate its state. only when SDMA channel is in its enabled state, irq handler can schedule a sdma tasklet for it. Signed-off-by: Jiada Wang --- drivers/dma/imx-sdma.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/

[PATCH 08/10] dma: imx-sdma: abort updating channel when it has been terminated

2016-05-16 Thread Jiada Wang
of channel status in sdma_handle_channel_loop(). Signed-off-by: Jiada Wang --- drivers/dma/imx-sdma.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 0b23407..bc867e5 100644 --- a/drivers/dma/imx-sdma.c +++ b

[PATCH 01/10] dma: imx-sdma: use chn_real_count to report residue for UART

2016-05-16 Thread Jiada Wang
ned-off-by: Jiada Wang --- drivers/dma/imx-sdma.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 0f6fd42..1f1b64b 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -680,6 +680,11 @@ s

[PATCH 08/10] dma: imx-sdma: abort updating channel when it has been terminated

2016-05-16 Thread Jiada Wang
of channel status in sdma_handle_channel_loop(). Signed-off-by: Jiada Wang --- drivers/dma/imx-sdma.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 0b23407..bc867e5 100644 --- a/drivers/dma/imx-sdma.c +++ b

[PATCH 05/10] dma: imx-sdma: add flag to indicate SDMA channel state

2016-05-16 Thread Jiada Wang
nnel to indicate its state. only when SDMA channel is in its enabled state, irq handler can schedule a sdma tasklet for it. Signed-off-by: Jiada Wang --- drivers/dma/imx-sdma.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/

[PATCH 01/10] dma: imx-sdma: use chn_real_count to report residue for UART

2016-05-16 Thread Jiada Wang
ned-off-by: Jiada Wang --- drivers/dma/imx-sdma.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 0f6fd42..1f1b64b 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -680,6 +680,11 @@ s

[PATCH v1 00/10] *** imx-sdma: misc fix ***

2016-05-16 Thread Jiada Wang
this patch set contains the following changes 1. fix issues in cyclic dma 2. add support to SYNC DMA termination 3. avoid system hang, when SDMA channel 0 timeouts 4. add lock to prevent race condition Jiada Wang (10): dma: imx-sdma: use chn_real_count to report residue for UART dma: imx-sdma

[PATCH 07/10] dma: imx-sdma: Add synchronization support

2016-05-16 Thread Jiada Wang
for all currently running complete callbacks to finish. Signed-off-by: Jiada Wang --- drivers/dma/imx-sdma.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 040cbf2..0b23407 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma

[PATCH 10/10] dma: imx-sdma: clear channel0 interrupt bit in irq routine

2016-05-16 Thread Jiada Wang
nnel0 timeouts, it won't cause irq storm, also adds lock to prevent irq routine to clear this bit when sdma_run_channel0() is busy checking it. Signed-off-by: Jiada Wang --- drivers/dma/imx-sdma.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/dma/imx-sdma.c

[PATCH 07/10] dma: imx-sdma: Add synchronization support

2016-05-16 Thread Jiada Wang
for all currently running complete callbacks to finish. Signed-off-by: Jiada Wang --- drivers/dma/imx-sdma.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 040cbf2..0b23407 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma

[PATCH 06/10] dma: imx-sdma: add terminate_all support

2016-05-16 Thread Jiada Wang
Implement device_terminate_all(), so that dmaengine_terminate_async() can work. Signed-off-by: Jiada Wang --- drivers/dma/imx-sdma.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index ef5d37c..040cbf2 100644 --- a/drivers/dma/imx

[PATCH 10/10] dma: imx-sdma: clear channel0 interrupt bit in irq routine

2016-05-16 Thread Jiada Wang
nnel0 timeouts, it won't cause irq storm, also adds lock to prevent irq routine to clear this bit when sdma_run_channel0() is busy checking it. Signed-off-by: Jiada Wang --- drivers/dma/imx-sdma.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/dma/imx-sdma.c

[PATCH 08/10] dma: imx-sdma: abort updating channel when it has been terminated

2016-05-16 Thread Jiada Wang
of channel status in sdma_handle_channel_loop(). Signed-off-by: Jiada Wang --- drivers/dma/imx-sdma.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 0b23407..bc867e5 100644 --- a/drivers/dma/imx-sdma.c +++ b

[PATCH 09/10] dma: imx-sdma: disable channel 0 when it timeouts

2016-05-16 Thread Jiada Wang
Previously when channel0 timeouts to finish its task, sdma_run_channel0() just returns without disable channel0, this will cause continuous interrupt later when channel0 finishs its task and set channel0 interrupt bit. Signed-off-by: Jiada Wang --- drivers/dma/imx-sdma.c | 43

[PATCH 03/10] dma: imx-sdma: clear BD_RROR flag before pass it to sdma script

2016-05-16 Thread Jiada Wang
ssful, but as BD_RROR flag is set, client side will still think the transfer failed. This patch clears BD_RROR flag before pass it to sdma script. Signed-off-by: Jiada Wang --- drivers/dma/imx-sdma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-s

[PATCH 04/10] dma: imx-sdma: update sdma channel status for cyclic dma

2016-05-16 Thread Jiada Wang
buffer descriptor. Signed-off-by: Jiada Wang --- drivers/dma/imx-sdma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 1489de0..36f5e39 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -670,6 +670,8 @@ static void

  1   2   3   4   5   >