style for networking my differ
from the rest of the kernel, both styles should be permitted.
This patch reverts a portion of the commit to allow multi-line code
comments to use either style.
Signed-off-by: Jeff Kirsher
Tested-by: Jeff Pieper
---
scripts/checkpatch.pl | 7 ---
1 file
On Sun, 2013-01-27 at 18:59 -0500, David Miller wrote:
> From: Jeff Kirsher
> Date: Sun, 27 Jan 2013 03:35:39 -0800
>
> > Produces warnings on code comments which follow the Linux coding style
> > guide. While the desired code comment style for networking my differ
>
On Mon, 2013-01-28 at 09:30 -0800, Joe Perches wrote:
> On Mon, 2013-01-28 at 17:17 +, Allan, Bruce W wrote:
> > David Miller Sent: Sunday, January 27, 2013 7:07 PM
> > > From: Jeff Kirsher
> > > > So will you be fine with cleanup patches which go through and
&g
On Tue, 2013-03-12 at 15:25 -0600, Alex Williamson wrote:
> igb is ineffective at setting a lower total VFs because:
>
> int pci_sriov_set_totalvfs(struct pci_dev *dev, u16 numvfs)
> {
> ...
> /* Shouldn't change if VFs already enabled */
> if (dev->sriov->ctrl & PCI_SRIOV_
On Tue, 2013-03-12 at 14:09 -0600, Alex Williamson wrote:
> The max_vfs= option has always been self limiting to the number of VFs
> supported by the device. fa44f2f1 added SR-IOV configuration via
> sysfs, but in the process broke this self correction factor. The
> failing path is:
>
> igb_prob
On Fri, 2012-10-19 at 20:19 +0100, Richard Davies wrote:
> Jeff Kirsher wrote:
> > Dmitry Fleytman wrote:
> > > Reported-by: Chris Webb
> > > Reported-by: Richard Davies
> > >
> > > Signed-off-by: Dmitry Fleytman
> > > ---
> >
On Tue, 2012-10-23 at 13:02 -0700, Kees Cook wrote:
> This config item has not carried much meaning for a while now and is
> almost always enabled by default. As agreed during the Linux kernel
> summit, remove it.
>
> CC: Paul Gortmaker
> CC: "David S. Miller"
>
On Tue, 2012-10-23 at 13:02 -0700, Kees Cook wrote:
> This config item has not carried much meaning for a while now and is
> almost always enabled by default. As agreed during the Linux kernel
> summit, remove it.
>
> CC: Jeff Kirsher
> CC: Jesse Brandeburg
> CC: Bruce
With the recent commit to checkpatch.pl:
commit 058806007450489bb8f457b275e5cb5c946320c1
Author: Joe Perches
Date: Thu Oct 4 17:13:35 2012 -0700
checkpatch: check networking specific block comment style
We are seeing false positive warnings. Here is an example of the
code the would gener
On Wed, 2012-10-24 at 07:12 -0700, Joe Perches wrote:
> On Wed, 2012-10-24 at 04:00 -0700, Jeff Kirsher wrote:
> > With the recent commit to checkpatch.pl:
> >
> > commit 058806007450489bb8f457b275e5cb5c946320c1
> > Author: Joe Perches
> > Date
On Tue, 2012-07-31 at 22:23 +0200, Jesper Juhl wrote:
> On Wed, 25 Jul 2012, Wyborny, Carolyn wrote:
>
> >
> > > -Original Message-
> > > From: Jesper Juhl [mailto:j...@chaosbits.net]
> > > Sent: Wednesday, July 25, 2012 12:06 PM
> > > To: linux-kernel@vger.kernel.org
> > > Cc: net...@vg
On Wed, 2012-07-25 at 21:19 +0200, Jesper Juhl wrote:
> Even when they go beyond 80 characters, user visible strings should be
> on one line to make them easy to grep for.
>
> Signed-off-by: Jesper Juhl
> ---
> drivers/net/ethernet/intel/igb/igb_ethtool.c | 23
> +++
> 1 file
On Tue, 2012-07-31 at 23:19 +0200, Jesper Juhl wrote:
> On Tue, 31 Jul 2012, Jeff Kirsher wrote:
>
> > On Tue, 2012-07-31 at 22:23 +0200, Jesper Juhl wrote:
> > > On Wed, 25 Jul 2012, Wyborny, Carolyn wrote:
> > >
> > > >
> > > > &g
ve memset from the static inline dma_zalloc_coherent
> and add just one use of __GFP_ZERO instead.
>
> Trivially reduces the size of the existing uses of
> dma_zalloc_coherent.
>
> Realign arguments as appropriate.
>
> Signed-off-by: Joe Perches
Acked-by: Jeff Kirsh
n contain
> partial
> stack garbage.
>
> Zero the input field in eee_set_cur() too.
>
> Cc: jeffrey.t.kirs...@intel.com
> Cc: net...@vger.kernel.org
> Signed-off-by: Andi Kleen
> ---
> drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 ++
> 1 file changed,
On Mon, 2013-07-08 at 11:22 +0400, Konstantin Khlebnikov wrote:
> This adds missing rtnl_unlock()
>
> Signed-off-by: Konstantin Khlebnikov
> Cc: Jeff Kirsher
> Cc: e1000-de...@lists.sourceforge.net
> ---
> drivers/net/ethernet/intel/igb/igb_main.c |1 +
> 1 file cha
On Tue, 2013-09-03 at 15:35 +0800, Yijing Wang wrote:
> use pcie_capability_read_word() to simplify code.
>
> Signed-off-by: Yijing Wang
> Cc: e1000-de...@lists.sourceforge.net
> Cc: net...@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |
On Fri, 2013-08-30 at 16:06 -0700, Joe Perches wrote:
> Just some potential cleanings...
>
> Joe Perches (4):
> i40e: Whitespace cleaning
> i40e: Add and use pf_
> i40e: pf_ remove "%s: " ... __func__
> i40e: Convert pf_ macros to functions
Thanks Joe, I will add these to my queue.
sign
On Fri, 2013-08-30 at 18:47 -0700, Joe Perches wrote:
> When dma_addr_t is a 32 bit value, >> 32 emits compiler warnings
> Use ((addr>>16) >>16) to avoid this.
>
> I presume the macro should actually use the kernel.h
> macro upper_32_bits() eventually.
>
> Signed-off-by: Joe Perches
> ---
> dri
On Tue, 2013-09-24 at 14:09 -0700, Joe Perches wrote:
> There are a mix of function prototypes with and without extern
> in the kernel sources. Standardize on not using extern for
> function prototypes.
>
> Function prototypes don't need to be written with extern.
> extern is assumed by the compi
On Mon, 2012-12-03 at 09:47 -0800, Joe Perches wrote:
> On Sat, 2012-10-20 at 09:22 -0700, Joe Perches wrote:
> > Use the normal kernel test instead of a module specific one.
>
> ping?
Your timely is perfect, I just cleared out all the ixgbe patches in my
queue that were before yours, and your pa
On Sat, 2012-10-20 at 09:22 -0700, Joe Perches wrote:
> Use the normal kernel test instead of a module specific one.
>
> Signed-off-by: Joe Perches
> ---
> found when doing that larger style conversion,
> might as well submit it.
>
> drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c | 2 +-
> dr
+++
> include/linux/udp.h |5 ++
> net/core/skbuff.c |9
> 7 files changed, 125 insertions(+), 1 deletions(-)
Acked-by: Jeff Kirsher
signature.asc
Description: OpenPGP digital signature
change due
> to routing table changes without impacting features on the VXLAN itself.
>
> Signed-off-by: Alexander Duyck
> ---
> net/core/dev.c | 15 +--
> net/ipv4/ip_output.c |4
> 2 files changed, 17 insertions(+), 2 deletions(-)
Acked-by: Jeff K
er P Waskiewicz Jr
> Signed-off-by: Alexander Duyck
> ---
> drivers/net/vxlan.c | 10 +-
> 1 files changed, 9 insertions(+), 1 deletions(-)
Acked-by: Jeff Kirsher
signature.asc
Description: OpenPGP digital signature
On 11/08/2012 03:15 AM, pkill.2012 wrote:
> Hello,
>
> I installed kvm and tried to use SR-IOV virtualizaton for 82599EB(Intel
> XT-520 T2) dual port card with latest ixgbe driver(version:3.11.33) ,
> kernel2.6.32-279.14.1(OS:Centos6.3) ,after configuration and reboot
> It seems that only first
On Fri, 2012-11-16 at 04:26 +0100, Cyril Roelandt wrote:
>
> copy_to_user() cannot return a negative value: it returns the number
> of bytes
> that could not be copied.
>
> Return -EFAULT on failure rather than the number of bytes that could
> not be
> copied, as this seems more standard.
>
> Si
On Thu, 2013-04-18 at 22:15 -0700, Alexey Khoroshilov wrote:
> If e1000_get_hw_semaphore_82574() succeed, it acquires swflag_mutex,
> otherwise it does not. But the returned value of
> e1000_get_hw_semaphore_82574() is ignored, so unlocking of
> swflag_mutex
> happens anyway.
>
> The patch fixes t
to enable use of this type of log function name.
Signed-off-by: Jacob Keller
Tested-by: Aaron Brown
Signed-off-by: Jeff Kirsher
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b954de5..a38d71e
On Wed, 2013-07-10 at 13:57 -0600, Bjorn Helgaas wrote:
> [+cc Jeff, Jesse, et al, e1000-devel]
>
> Holy cow, you guys have a lot of folks listed in MAINTAINERS for Intel
> drivers :) This is an ASPM question, if that helps narrow down the
> folks interested.
Bruce Allan is the e1000e maintainer
duced in commit 23606cf5d1192c2b17912cb2ef6e62f9b11de133
> ("e1000e / PCI / PM: Add basic runtime PM support (rev. 4)") in
> v2.6.35
>
> Signed-off-by: Konstantin Khlebnikov
> Acked-by: Rafael J. Wysocki
> Cc: e1000-de...@lists.sourceforge.net
> Cc: Jeff Kirsher
> Cc: Bruce
> suspend.
>
> This patch also enables wakeup for device if management mode is
> enabled
> (like for WoL) as result pci_prepare_to_sleep() would setup wakeup
> without
> special actions like custom 'enable_wakeup' sign.
>
> Signed-off-by: Konstantin Khlebnikov
>
-by: Rafael J. Wysocki
> Cc: e1000-de...@lists.sourceforge.net
> Cc: Jeff Kirsher
> Cc: Bruce Allan
> ---
> drivers/net/ethernet/intel/e1000e/ethtool.c | 13 +
> drivers/net/ethernet/intel/e1000e/netdev.c |2 ++
> 2 files changed, 15 insertions(+)
I
On Tue, 2013-03-05 at 10:42 +0100, Jiri Slaby wrote:
> On 03/05/2013 01:16 AM, Bjorn Helgaas wrote:
> > [+cc e1000-devel, Jeff, Bruce]
> >
> > On Mon, Mar 4, 2013 at 2:50 PM, Borislav Petkov wrote:
> >> On Fri, Feb 15, 2013 at 10:16:41AM +0100, Borislav Petkov wrote:
> >>> So it looks Bjorn has t
On Tue, 2013-03-05 at 10:58 +0100, Borislav Petkov wrote:
> On Tue, Mar 05, 2013 at 10:42:17AM +0100, Jiri Slaby wrote:
> > On 03/05/2013 01:16 AM, Bjorn Helgaas wrote:
> > > [+cc e1000-devel, Jeff, Bruce]
> > >
> > > On Mon, Mar 4, 2013 at 2:50 PM, Borislav Petkov wrote:
> > >> On Fri, Feb 15, 2
On Tue, 2013-03-05 at 11:14 +0100, Borislav Petkov wrote:
>
> On Tue, Mar 05, 2013 at 02:02:48AM -0800, Jeff Kirsher wrote:
> > They are in my queue of e1000e patches for net and are being testing
> > currently. I should be able to push them upstream this week.
>
> Right,
On Tue, 2013-03-05 at 12:27 +0100, Borislav Petkov wrote:
> On Tue, Mar 05, 2013 at 02:29:01AM -0800, Jeff Kirsher wrote:
> > On Tue, 2013-03-05 at 11:14 +0100, Borislav Petkov wrote:
> > >
> > > On Tue, Mar 05, 2013 at 02:02:48AM -0800, Jeff Kirsher wrote:
> > &
On Thu, 2013-05-02 at 16:06 +0300, laura.vasile...@rosedu.org wrote:
> From: Laura Mihaela Vasilescu
>
> Signed-off-by: Laura Mihaela Vasilescu
> ---
> drivers/net/ethernet/intel/igb/e1000_82575.c | 33
> --
> 1 file changed, 15 insertions(+), 18 deletions(-)
I belie
On Mon, 2013-05-06 at 19:09 -0400, David Miller wrote:
> From: Linus Torvalds
> Date: Mon, 6 May 2013 15:57:15 -0700
>
> > On Mon, May 6, 2013 at 2:05 PM, David Miller wrote:
> >>
> >> Just a small pile of fixes:
> >
> > Ok, apparently the e1000e problem didn't get fixed yet. Should I just
> >
From: Bruce Allan
A scheduling while atomic bug was introduced recently (by commit ce43a216
e1000e: cleanup USLEEP_RANGE checkpatch checks). Revert the particular
instance of usleep_range() which causes the bug.
Reported-by: Maarten Lankhorst
Signed-off-by: Bruce Allan
Signed-off-by: Jeff
On Mon, 2013-05-06 at 22:10 -0400, David Miller wrote:
> From: Jeff Kirsher
> Date: Mon, 06 May 2013 16:32:46 -0700
>
> > On Mon, 2013-05-06 at 19:09 -0400, David Miller wrote:
> >> From: Linus Torvalds
> >> Date: Mon, 6 May 2013 15:57:15 -0700
> >>
&g
s wakeup for device if management mode is enabled
> > (like for WoL) as result pci_prepare_to_sleep() would setup wakeup without
> > special actions like custom 'enable_wakeup' sign.
> >
> > Cc: Bruce Allan
> > Signed-off-by: Konstantin Khlebnikov
> > Acked-by: Rafael J. Wysocki
> > Tested-by: Borislav Petkov
> > Tested-by: Aaron Brown
> > Signed-off-by: Jeff Kirsher
> > Signed-off-by: Steven Rostedt
>
signature.asc
Description: This is a digitally signed message part
On Sun, 2013-05-19 at 22:20 +0300, Eliezer Tamir wrote:
> On 19/05/2013 22:06, Or Gerlitz wrote:
> > On Sun, May 19, 2013 at 1:25 PM, Eliezer Tamir
> > wrote:
> >> This is an updated version of the code we posted on February.
> >
> > Last time you've placed a copy of the patchset in the rfc branch
On Mon, 2013-05-20 at 15:35 -0400, Steven Rostedt wrote:
> On Fri, 2013-05-17 at 22:40 -0700, Jeff Kirsher wrote:
> > On Sat, 2013-05-18 at 09:35 +0400, Konstantin Khlebnikov wrote:
> > > Steven Rostedt wrote:
> > > > 3.6.11.4 stable review patch.
> > > >
On 03/11/2013 12:19 PM, Borislav Petkov wrote:
> Hi,
>
> When I try to suspend with 3.9-rc2, it fails to do so and returns back
> to the prompt. Below's what's in dmesg.
>
> Jeff, am I assuming correctly that the fixes I was testing last week
> haven't trickled upstream yet?
>
> If so, then it's a
hernet/intel/e1000e/netdev.c | 27
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 12 ++--
> 2 files changed, 10 insertions(+), 29 deletions(-)
Acked-by: Jeff Kirsher
signature.asc
Description: This is a digitally signed message part
On Mon, 2012-08-27 at 10:38 -0700, Joe Perches wrote:
> commit ec21e2ec36769 ("freescale: Move the Freescale drivers")
> moved the files, update the pattern.
>
> Signed-off-by: Joe Perches
> ---
> MAINTAINERS |2 +-
> 1 files changed, 1 insertions(+), 1 deleti
On Tue, 2012-07-10 at 15:31 -0700, Jon Mason wrote:
> Use PCI_VENDOR_ID_* from pci_ids.h instead of creating #define locally.
>
> Signed-off-by: Jon Mason
> Cc: Jeff Kirsher
> Cc: Jesse Brandeburg
> Cc: Bruce Allan
> Cc: Carolyn Wyborny
> Cc: Don Skidmore
> C
On Tue, 2012-07-10 at 15:31 -0700, Jon Mason wrote:
> Remove unused IXGBE_INTEL_VENDOR_ID #define
>
> Signed-off-by: Jon Mason
> Cc: Jeff Kirsher
> Cc: Jesse Brandeburg
> Cc: Bruce Allan
> Cc: Carolyn Wyborny
> Cc: Don Skidmore
> Cc: Greg Rose
> Cc: Peter P W
On Tue, 2012-07-10 at 15:43 -0700, Jeff Kirsher wrote:
> On Tue, 2012-07-10 at 15:31 -0700, Jon Mason wrote:
> > Remove unused IXGBE_INTEL_VENDOR_ID #define
> >
> > Signed-off-by: Jon Mason
> > Cc: Jeff Kirsher
> > Cc: Jesse Brandeburg
> > Cc: Bruce Alla
On Thu, 2012-07-12 at 12:49 -0700, Jon Mason wrote:
> On Thu, Jul 12, 2012 at 11:15 AM, Jeff Kirsher
> wrote:
> > On Tue, 2012-07-10 at 15:43 -0700, Jeff Kirsher wrote:
> >> On Tue, 2012-07-10 at 15:31 -0700, Jon Mason wrote:
> >> > Remove unused IXGBE_INTEL_VENDO
On Sun, 2012-10-14 at 19:19 +0200, Dmitry Fleytman wrote:
> Reported-by: Chris Webb
> Reported-by: Richard Davies
>
> Signed-off-by: Dmitry Fleytman
> ---
> drivers/net/ethernet/intel/e1000/e1000_ethtool.c |9 +
> drivers/net/ethernet/intel/e1000/e1000_main.c| 18
> ++
Signed-off-by: Jeff Kirsher
---
drivers/pps/kapi.c | 4 +---
drivers/pps/pps.c | 1 -
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/pps/kapi.c b/drivers/pps/kapi.c
index f197e8e..3231176 100644
--- a/drivers/pps/kapi.c
+++ b/drivers/pps/kapi.c
@@ -150,9
On 9/1/05, Daniel Walker <[EMAIL PROTECTED]> wrote:
>
> This should fix a small warning in the e1000 driver. It casts to the
> largest possible type dma field. This was found while compiling for
> X86_64 .
>
> Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]>
>
> Index: linux-2.6.13/drivers/net/e
On 12/8/06, Auke Kok <[EMAIL PROTECTED]> wrote:
Stephen Hemminger wrote:
> On Fri, 08 Dec 2006 13:45:05 -0800
>
> Hmm.. looks like all that code should really be moved off to PCI bus
> quirk/setup. None of it is E1000 specific. Something like this (untested):
This is not true, and I have to NA
bridges.
Signed-off by: Peter Oruba <[EMAIL PROTECTED]>
Based on work by Stephen Hemminger <[EMAIL PROTECTED]>
Ack.
--
Cheers,
Jeff Kirsher
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordom
On Sun, 2016-09-18 at 16:50 +0800, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/net/ethernet/intel/igb/igb_ethtool.c:2707:5: warning: no previous
> prototype for 'igb_rxnfc_write_vlan_prio_filter' [-Wmissing-prototypes]
>
> In fact, this function is only used in th
On Sun, 2016-09-25 at 14:03 +0800, Baoyou Xie wrote:
> We get 2 warnings when building kernel with W=1:
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2128:5: warning: no
> previous prototype for 'ixgbe_led_on_t_x550em' [-Wmissing-prototypes]
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2150:5:
On Sun, 2016-09-25 at 14:05 +0800, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/net/ethernet/intel/igb/igb_ethtool.c:2707:5: warning: no previous
> prototype for 'igb_rxnfc_write_vlan_prio_filter' [-Wmissing-prototypes]
>
> In fact, this function is only used in th
On Tue, 2016-07-26 at 11:14 +0200, Eric Dumazet wrote:
> Could you try this ?
>
> diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c
> b/drivers/net/ethernet/intel/e1000/e1000_main.c
> index
> f42129d09e2c23ba9fdb5cde890d50ecb7166a42..a53c41c4c4f7d1fe52f95a2cab8784a
> 938b3820b 100644
> --
be suppressed with --suppress-cc=bylines.
>
> Signed-off-by: Joe Perches
> ---
> Documentation/git-send-email.txt | 11 +++
> git-send-email.perl | 16 +++-
> 2 files changed, 18 insertions(+), 9 deletions(-)
Acked-by: Jeff Kirsher
signature.asc
Description: This is a digitally signed message part
On Wed, 2017-08-16 at 19:52 +0200, Juergen Gross wrote:
> Using direct assignment for a cpumask is wrong, cpumask_copy() should
> be used instead.
>
> Otherwise crashes like the following might happen:
>
> [62792.326374] BUG: unable to handle kernel paging request at
> 8800049ff000
> [62792.3
On Tue, 2017-10-17 at 12:23 +0200, Arnd Bergmann wrote:
> The new bandwidth calculation causes a link error on 32-bit
> architectures, like
>
> ERROR: "__aeabi_uldivmod" [drivers/net/ethernet/intel/i40e/i40e.ko]
> undefined!
>
> The problem is the max_tx_rate calculation that uses 64-bit integers
From: Liang-Min Wang
When a SR-IOV supported device is bound with vfio-pci, the driver
could not create SR-IOV instance through /sys/bus/pci/devices/...
/sriov_numvfs. This patch re-activates this capability for a PCIe
device that supports SR-IOV and is bound with vfio-pci.ko.
Signed-off-by: L
15:00.0: eth0: (PCIe:2.5Gb/s:Width x1)
> e8:ea:6a:00:1b:2a
> [ 8010.597543] igb :15:00.0: eth0: PBA No: 000200-000
> [ 8010.597545] igb :15:00.0: Using MSI-X interrupts. 4 rx
> queue(s), 4 tx queue(s)
> [ 8010.600468] igb :15:00.0 enp21s0: renamed from eth0
> [ 8010.6193
On Tue, 2015-10-13 at 15:23 -0700, Alexander Duyck wrote:
> On 10/13/2015 02:39 PM, Janusz Wolak wrote:
> > From: Janusz Wolak
> >
> > Signed-off-by: Janusz Wolak
> > ---
> > drivers/net/ethernet/intel/e1000/e1000_param.c | 114
> ++---
> > 1 file changed, 82 insertions(+),
On Wed, 2015-10-14 at 18:57 -0400, Nicholas Krause wrote:
> This removes the reducant error path and now no longer used goto
> label err_sw_init after the call to ixgb_probe in the function
> ixgb_sw_init after calling this function due to it always returning
> zero as it is guarantee to run succe
On Tue, 2015-10-20 at 17:05 -0400, Nicholas Krause wrote:
> This fixes error handling in the function fm10k_setup_tc to properly
> check if the call to the function fm10k_open has failed by returning
> a error and if so return immediately to the caller of the function
> fm10k_setup_tc to properly s
On Wed, 2018-07-25 at 14:52 -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas
>
> The igb driver doesn't need anything provided by pci-aspm.h, so
> remove
> the unnecessary include of it.
>
> Signed-off-by: Bjorn Helgaas
Acked-by: Jeff Kirsher
I am fine with
On Fri, 2018-01-12 at 17:13 +, Colin King wrote:
> From: Colin Ian King
>
> The incorrect operator && is being used and will always return false
> as offset can never be two different values at the same time. Fix
> this
> by using the || operator instead.
>
> Detected by CoverityScan, CID#14
On Wed, 2018-03-21 at 14:56 -0400, Sinan Kaya wrote:
> Remove ixgbevf_write_tail() in favor of moving writel() close to
> wmb().
>
> Signed-off-by: Sinan Kaya
> Reviewed-by: Alexander Duyck
> ---
> drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 5 -
> drivers/net/ethernet/intel/ixgbevf
On Thu, 2018-12-20 at 15:23 -0600, Kangjie Lu wrote:
> When e1000_read_kmrn_reg_80003es2lan() fails, "kum_reg_data" is
> uninitialized and may contain random value. However, it is further
> used in the following execution, which will lead to undefined
> behaviors.
> The fix checks the failure of e1
1 insertion(+), 1 deletion(-)
Acked-by: Jeff Kirsher
Dave, since this is apart of a series, please feel free to commit this
patch with the series.
signature.asc
Description: This is a digitally signed message part
On Thu, 2019-01-03 at 16:37 -0800, David Miller wrote:
> From: Jeff Kirsher
> Date: Thu, 03 Jan 2019 15:58:10 -0800
>
> > On Sun, 2018-12-30 at 16:53 +0100, Julia Lawall wrote:
> > > Convert spaces to tabs to get correct alignment.
> > >
> &
On Tue, 2018-10-16 at 09:35 -0700, Shannon Nelson wrote:
> On 10/16/2018 3:03 AM, Arnd Bergmann wrote:
> > When XFRM_ALGO is not enabled, the new igxge ipsec code produces a
> > link error:
>
> s/igxge/ixgbe/
>
> >
> > drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.o: In function
> > `ixgbe_ipsec_
On Wed, 2014-12-31 at 17:48 +0100, Rickard Strandqvist wrote:
> Remove the function i40e_rx_is_fip() that is not used anywhere.
>
> This was partially found by using a static code analysis program
> called cppcheck.
>
> Signed-off-by: Rickard Strandqvist
>
> ---
> drivers/net/ethernet/intel/i40
ks depending on
> CONFIG_PM may be dropped now.
>
> Do that in the e1000e and igb network drivers.
>
> Signed-off-by: Rafael J. Wysocki
Acked-by: Jeff Kirsher
> ---
>
> Note: This depends on commit b2b49ccbdd54 (PM: Kconfig: Set PM_RUNTIME
> if
> PM_SLEEP is select
On Thu, 2014-12-04 at 10:39 -0800, Joe Stringer wrote:
> ndo_gso_check() was recently introduced to allow NICs to report the
> offloading support that they have on a per-skb basis. Add an
> implementation for this driver which checks for IPIP, GRE, UDP
> tunnels.
>
> Signed-off-by: Joe Stringer
>
On Thu, 2014-12-04 at 22:11 +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 12/04/2014 09:39 PM, Joe Stringer wrote:
>
> > ndo_gso_check() was recently introduced to allow NICs to report the
> > offloading support that they have on a per-skb basis. Add an
> > implementation for this driver which ch
On Fri, 2014-12-05 at 10:41 -0800, Joe Stringer wrote:
> ndo_gso_check() was recently introduced to allow NICs to report the
> offloading support that they have on a per-skb basis. Add an
> implementation for this driver which checks for IPIP, GRE, UDP
> tunnels.
>
> Signed-off-by: Joe Stringer
>
'i40e_dbg_dump_desc':
> > drivers/net/ethernet/intel/i40e/i40e_debugfs.c:855:1: warning: the frame
> > size of 8192 bytes is larger than 2048 bytes [-Wframe-larger-than=]
>
> Patched.
> Waiting for Jeff Kirsher to get 'round to applying it.
>
> http:/
On Sun, 2014-12-21 at 19:47 +0100, Richard Cochran wrote:
> This patch changes the driver to use the new and improved method
> for adjusting the offset of a timecounter.
>
> Signed-off-by: Richard Cochran
Acked-by: Jeff Kirsher
> ---
> drivers/net/ethernet/intel/e
Richard Cochran
Acked-by: Jeff Kirsher
For the Intel driver changes...
> ---
> drivers/net/ethernet/amd/xgbe/xgbe.h|2 +-
> drivers/net/ethernet/broadcom/bnx2x/bnx2x.h |2 +-
> drivers/net/ethernet/freescale/fec.h|1 +
> drivers/net/ethernet/intel/e1000e/
On Sun, 2014-12-21 at 19:47 +0100, Richard Cochran wrote:
> This patch changes the driver to use the new and improved method
> for adjusting the offset of a timecounter.
>
> Signed-off-by: Richard Cochran
Acked-by: Jeff Kirsher
> ---
> drivers/net/ethernet/intel/ig
On Sun, 2014-12-21 at 19:47 +0100, Richard Cochran wrote:
> This patch changes the driver to use the new and improved method
> for adjusting the offset of a timecounter.
>
> Compile tested only.
>
> Signed-off-by: Richard Cochran
Acked-by: Jeff Kirsher
Just for sanity
On Thu, 2015-01-22 at 23:53 +0100, Rasmus Villemoes wrote:
> The comment explains the intention, but vid has type u16. Before the
> inner shift, it is promoted to int, which has plenty of space for all
> vid's bits, so nothing is dropped. Use a simple mask instead.
>
> Signed-off-by: Rasmus Villem
On Wed, 2015-01-14 at 18:24 -0800, Jesse Gross wrote:
> On Fri, Dec 26, 2014 at 3:58 PM, Jesse Gross wrote:
> > On Fri, Dec 5, 2014 at 2:12 PM, Jeff Kirsher
> > wrote:
> >> On Fri, 2014-12-05 at 10:41 -0800, Joe Stringer wrote:
> >>> ndo_gso_check() was
On Thu, 2015-01-15 at 14:40 +0100, Ondrej Zary wrote:
> On Thursday 13 November 2014, Jeff Kirsher wrote:
> > On Wed, 2014-11-12 at 18:18 -0500, David Miller wrote:
> > > From: Ondrej Zary
> > > Date: Wed, 12 Nov 2014 23:47:25 +0100
> > >
> > > &g
On Thu, 2015-01-15 at 16:18 +0100, Ondrej Zary wrote:
> On Thursday 15 January 2015, Jeff Kirsher wrote:
> > On Thu, 2015-01-15 at 14:40 +0100, Ondrej Zary wrote:
> > > On Thursday 13 November 2014, Jeff Kirsher wrote:
> > > > On Wed, 2014-11-12 at 18:18 -0500, Davi
On Wed, 2015-01-07 at 14:41 +0200, Asaf Vertz wrote:
> To be future-proof and for better readability the time comparisons are
> modified to use time_after_eq() instead of plain, error-prone math.
>
> Signed-off-by: Asaf Vertz
> ---
> drivers/net/ethernet/intel/e1000/e1000_ethtool.c |3 ++-
>
On Wed, 2015-01-14 at 20:03 -0500, Sowmini Varadhan wrote:
> Relaxed ordering is disabled by default at driver initialization
> and re-enabled when DCA is used. The reason it is disabled was
> due to an issue on some chipsets (see comments in
> ixgbe_update_tx_dca()).
> But when DCA is not used, R
gt;hw.func_caps.fcoe" is true. so if
> >> i40e_reset_and_rebuild() is called for VLAN setup, ethtool diagnostic test.
> >>And then i40e_init_pf_fcoe() is to be called,
> >>
> >>While if (!pf->hw.func_caps.fcoe) wouldn't return,
> >>
&g
On Thu, 2015-03-19 at 15:11 -0600, Jonathan Corbet wrote:
> On Tue, 24 Feb 2015 20:22:56 -0800
> Jeff Kirsher wrote:
>
> > When 4.0 is released, the README should reflect the new numbering.
>
> OK, I've applied this because it came in first. There were two other
>
code right away (patch #3)
The Intel driver changes look fine to me and as noted, more work appears
to be needed for igb. It does not appear that Jake Jacobs got copied on
the patches, so I will make sure he takes a look at the changes for our
Intel drivers, since he did much of the work.
You get
On Sun, 2015-03-29 at 22:30 -0700, Stephen Hemminger wrote:
> Patch was rejected upstream by Greg
Thanks for the update Stephen, I will drop the patch.
> On Sun, Mar 29, 2015 at 4:55 PM, Jeff Kirsher
> wrote:
> On Sun, 2015-03-29 at 15:41 +0200, Michael S. T
On Sun, 2015-03-29 at 18:25 -0700, Joe Perches wrote:
> Use bool constants as the return values instead of 1 and 0.
>
> Signed-off-by: Joe Perches
Acked-by: Jeff Kirsher
For the ixgbe changes...
> ---
> > To be honest I'd might rather get bunches of these, there has to
On Tue, 2015-03-31 at 13:22 -0400, David Miller wrote:
> From: Jeff Kirsher
> Date: Fri, 27 Mar 2015 16:04:10 -0700
>
> > The following are changes since commit
> dde93dfea53c72b07907d9e44a6e4b1545f6bdc4:
> > cxgb4: Fix frame size warning for 32 bit arch
> >
On Tue, 2015-03-31 at 19:19 -0700, Jeff Kirsher wrote:
> On Tue, 2015-03-31 at 13:22 -0400, David Miller wrote:
> > From: Jeff Kirsher
> > Date: Fri, 27 Mar 2015 16:04:10 -0700
> >
> > > The following are changes since commit
> > dde93dfea53c72b07907d9e44a6e4b
e moved on to different projects.
Made an update to the section header so that it is more manageable
going forward as we add new drivers.
Signed-off-by: Jeff Kirsher
---
MAINTAINERS | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/MAINTAINERS b/M
On Tue, 2015-03-31 at 21:42 -0700, Jeff Kirsher wrote:
> Update the git tree info with a recent change in tree names. Also
> add our new mailing list created solely for Linux kernel patches
> and kernel development, as well as the new patchwork project for
> tracking patches. Lastl
1 - 100 of 336 matches
Mail list logo
