On Tue, 2012-07-10 at 15:43 -0700, Jeff Kirsher wrote: > On Tue, 2012-07-10 at 15:31 -0700, Jon Mason wrote: > > Remove unused IXGBE_INTEL_VENDOR_ID #define > > > > Signed-off-by: Jon Mason <jdma...@kudzu.us> > > Cc: Jeff Kirsher <jeffrey.t.kirs...@intel.com> > > Cc: Jesse Brandeburg <jesse.brandeb...@intel.com> > > Cc: Bruce Allan <bruce.w.al...@intel.com> > > Cc: Carolyn Wyborny <carolyn.wybo...@intel.com> > > Cc: Don Skidmore <donald.c.skidm...@intel.com> > > Cc: Greg Rose <gregory.v.r...@intel.com> > > Cc: Peter P Waskiewicz Jr <peter.p.waskiewicz...@intel.com> > > Cc: Alex Duyck <alexander.h.du...@intel.com> > > Cc: John Ronciak <john.ronc...@intel.com> > > --- > > drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 3 --- > > 1 file changed, 3 deletions(-) > > This should also go through David Miller's networking tree's. Adding > netdev mailing list. > > Acked-by: Jeff Kirsher <jeffrey.t.kirs...@intel.com>
After looking at this further, I rescind my ACK. NAK, this define is used in several places in ixgbe_main.c and the driver will not compile with this patch. > > > > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h > > b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h > > index 204848d..c8d8040 100644 > > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h > > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h > > @@ -32,9 +32,6 @@ > > #include <linux/mdio.h> > > #include <linux/netdevice.h> > > > > -/* Vendor ID */ > > -#define IXGBE_INTEL_VENDOR_ID 0x8086 > > - > > /* Device IDs */ > > #define IXGBE_DEV_ID_82598 0x10B6 > > #define IXGBE_DEV_ID_82598_BX 0x1508 > >
signature.asc
Description: This is a digitally signed message part
