Re: [PATCH] irqchip: gic: Don't complain in gic_get_cpumask() if UP system

2013-07-12 Thread Javi Merino
On Sat, Jul 06, 2013 at 12:39:33AM +0100, Stephen Boyd wrote: > In a uniprocessor implementation the interrupt processor targets > registers are read-as-zero/write-ignored (RAZ/WI). Unfortunately > gic_get_cpumask() will print a critical message saying > > GIC CPU mask not found - kernel will fai

Re: [PATCH] smp: harmonize prototypes of smp functions

2013-09-18 Thread Javi Merino
On Tue, Sep 17, 2013 at 10:22:28PM +0100, Andrew Morton wrote: > On Mon, 2 Sep 2013 15:33:13 +0100 Javi Merino wrote: > > > Avoid unnecessary casts from int to bool in smp functions. Some > > functions in kernel/smp.c have a wait parameter that can be set to one > > if

[PATCH RESEND] smp: harmonize prototypes of smp functions

2013-09-10 Thread Javi Merino
%rbp 8109bf3b: c3 retq 8109bf3c: 0f 1f 40 00 nopl 0x0(%rax) Cc: Andrew Morton Signed-off-by: Javi Merino --- include/linux/smp.h |6 +++--- kernel/smp.c|6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --

[PATCH] smp: harmonize prototypes of smp functions

2013-09-02 Thread Javi Merino
%rbp 8109bf3b: c3 retq 8109bf3c: 0f 1f 40 00 nopl 0x0(%rax) Cc: Andrew Morton Signed-off-by: Javi Merino --- include/linux/smp.h |6 +++--- kernel/smp.c|6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --

[PATCH] of: add missing documentation for of_platform_populate()

2012-11-23 Thread Javi Merino
15c3597d (dt/platform: allow device name to be overridden) added a lookup parameter to of_platform_populate() but did not update the documentation. This patch adds the missing documentation entry. Cc: Grant Likely Cc: Jiri Kosina Signed-off-by: Javi Merino --- drivers/of/platform.c |1

Re: [PATCH] devfreq_cooling: pass a pointer to devfreq in the power model callbacks

2016-06-20 Thread Javi Merino
Eduardo, Rui, On Fri, Jun 03, 2016 at 10:25:31AM +0100, Javi Merino wrote: > When the devfreq cooling device was designed, it was an oversight not to > pass a pointer to the struct devfreq as the first parameters of the > callbacks. The design patterns of the kernel suggest it f

Re: [PATCH] of: thermal: Fixed governor at each thermal zone

2016-09-27 Thread Javi Merino
On Tue, Sep 27, 2016 at 09:46:57AM +0800, Zhang Rui wrote: > On 一, 2016-09-19 at 10:18 +0900, Inhyuk Kang wrote: > > It is necessary to be added governor at each thermal_zone. > > Because some governors should be operated in the during the kernel > > booting > > in order to avoid heating problem. >

Re: [PATCH] thermal: cpu_cooling: Fix wrong comment call function name

2016-09-08 Thread Javi Merino
On Wed, Sep 07, 2016 at 09:35:39AM +0900, Inhyuk Kang wrote: > The last_load is updated not cpufreq_get_actual_power() function call > but cpufreq_get_requested_power() function call. Yep, my bad. Thanks for fixing it! > Signed-off-by: Inhyuk Kang Acked-by: Javi Merino >

Re: [PATCH 1/2] tracing, thermal: Hide devfreq trace events when not in use

2017-10-17 Thread Javi Merino
> The trace events thermal_power_devfreq_get_power and > thermal_power_devfreq_limit are only used when CONFIG_DEVFREQ_THERMAL > is set. Make those events only defined when that is set as well. > > Signed-off-by: Steven Rostedt (VMware) Acked-by: Javi Merino > --- > Index: linux-t

Re: [PATCH 2/2] tracing, thermal: Hide cpu cooling trace events when not in use

2017-10-17 Thread Javi Merino
> The trace events thermal_power_cpu_get_power and > thermal_power_cpu_limit are only used when CONFIG_CPU_THERMAL is set. > Make those events only defined when that is set as well. > > Signed-off-by: Steven Rostedt (VMware) Acked-by: Javi Merino > --- > Index: linux-t

Re: [PATCH] thermal: cpu_cooling: pr_err() strings should end with newlines

2017-10-25 Thread Javi Merino
On Tue, Oct 24, 2017 at 01:20:39PM +0530, Arvind Yadav wrote: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. > > Signed-off-by: Arvind Yadav FWIW, Acked-by: Javi Merino > --- > drivers/thermal/cpu_cooling.c | 2 +- > 1 file

Re: [PATCH v4 4/5] thermal: power_allocator: don't require tzp to be present for the thermal zone

2015-08-28 Thread Javi Merino
On Fri, Aug 28, 2015 at 03:18:20AM +0100, Daniel Kurtz wrote: > On Wed, Aug 26, 2015 at 9:26 PM, Javi Merino wrote: > > Thermal zones created using thermal_zone_device_create() may not have > > tzp. As the governor gets its parameters from there, allocate it while > > the

Re: [PATCH] thermal: power_allocator: allocate with kcalloc what you free with kfree

2015-08-29 Thread Javi Merino
Hi Linus, On Thu, Aug 27, 2015 at 04:49:37PM +0100, Javi Merino wrote: > On Tue, Aug 25, 2015 at 07:22:35PM +0100, Javi Merino wrote: > > Commit cf736ea6f902 ("thermal: power_allocator: do not use devm* > > interfaces") forgot to change a devm_kcalloc() to jus

Re: [PATCH 0/2] Fixes for cpu cooling

2015-09-01 Thread Javi Merino
On Tue, Aug 25, 2015 at 07:53:48PM +0100, Javi Merino wrote: > On Mon, Aug 17, 2015 at 07:21:41PM +0100, Javi Merino wrote: > > Commit c36cf0717631 ("thermal: cpu_cooling: implement the power > > cooling device API") introduced two bugs: a call to kcalloc() (that > >

Re: [PATCH v6 4/5] devfreq_cooling: add trace information

2015-10-14 Thread Javi Merino
Hi Steve, On Thu, Sep 10, 2015 at 06:19:28PM +0100, Steven Rostedt wrote: > On Thu, 10 Sep 2015 18:09:31 +0100 > Javi Merino wrote: > > > Tracing is useful for debugging and performance tuning. Add similar > > traces to what's present in the cpu cooling device. >

[PATCH v5 0/5] Let the power allocator thermal governor run on any thermal zone

2015-09-07 Thread Javi Merino
ggested by Eduardo Valentin. - power_actor_get_min_power() moved to a patch of its own. Changes since v2: - Typos suggested by Daniel Kurtz Changes since v1: - Let the power allocator governor operate if the thermal zone doesn't have tzp as suggested by Chung-yih Wang Javi Merino

[PATCH v5 4/5] thermal: power_allocator: don't require tzp to be present for the thermal zone

2015-09-07 Thread Javi Merino
: Zhang Rui Cc: Eduardo Valentin Reviewed-by: Daniel Kurtz Signed-off-by: Javi Merino --- While this would be easier to do by just ignoring the thermal zone if there was no tzp, I think the approach in this patch provides a more consistent behavior for the system integrator as it doesn't m

[PATCH v5 3/5] thermal: power_allocator: relax the requirement of two passive trip points

2015-09-07 Thread Javi Merino
oints they have. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Javi Merino --- Documentation/thermal/power_allocator.txt | 2 +- drivers/thermal/power_allocator.c | 101 +- 2 files changed, 58 insertions(+), 45 deletions(-) diff --git a/Document

[PATCH v5 1/5] thermal: Add a function to get the minimum power

2015-09-07 Thread Javi Merino
The thermal core already has a function to get the maximum power of a cooling device: power_actor_get_max_power(). Add a function to get the minimum power of a cooling device. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Javi Merino --- drivers/thermal/thermal_core.c | 28

[PATCH v5 5/5] thermal: power_allocator: exit early if there are no cooling devices

2015-09-07 Thread Javi Merino
ces. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Javi Merino --- drivers/thermal/power_allocator.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/thermal/power_allocator.c b/drivers/thermal/power_allocator.c index 78d589e7e65f..8a0d801ed29b 100644 --- a/drivers/thermal/po

[PATCH v5 2/5] thermal: power_allocator: relax the requirement of a sustainable_power in tzp

2015-09-07 Thread Javi Merino
it doesn't need to be mandatory. Relax the requirement and allow the governor to bind to thermal zones that don't provide it by estimating it from the cooling devices' power model. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Javi Merino --- drivers/therma

Re: [PATCH v5 3/5] thermal: Add devfreq cooling

2015-09-09 Thread Javi Merino
On Wed, Sep 09, 2015 at 06:10:22AM +0100, Eduardo Valentin wrote: > Hi Hi Eduardo, > On Thu, Aug 27, 2015 at 11:55:49AM +0100, Javi Merino wrote: > > From: Ørjan Eide > > > > Add a generic thermal cooling device for devfreq, that is similar to > > cpu_cooling

Re: [PATCH 3/3] Thermal: do thermal zone update after a cooling device registered

2015-10-14 Thread Javi Merino
On Mon, Oct 12, 2015 at 09:23:28AM +, Chen, Yu C wrote: > Hi, Javi > Sorry for my late response, > > > -Original Message- > > From: Javi Merino [mailto:javi.mer...@arm.com] > > Sent: Wednesday, September 30, 2015 12:02 AM > > To: Chen, Yu C > &g

Re: [PATCH 3/3] Thermal: do thermal zone update after a cooling device registered

2015-10-15 Thread Javi Merino
On Wed, Oct 14, 2015 at 07:23:55PM +, Chen, Yu C wrote: > > -Original Message- > > From: Javi Merino [mailto:javi.mer...@arm.com] > > Sent: Thursday, October 15, 2015 1:08 AM > > To: Chen, Yu C > > Cc: linux...@vger.kernel.org; edubez...@gmail.c

Re: [PATCH v4 0/5] Let the power allocator thermal governor run on any thermal zone

2015-09-02 Thread Javi Merino
On Wed, Aug 26, 2015 at 02:26:39PM +0100, Javi Merino wrote: > Relax the thermal governor requirements of sustainable_power and at > least two trip points so that it can be bound to any thermal zone. > Its behavior won't be optimal, it would be the best it can with the &

Re: [PATCH 3/3] Thermal: do thermal zone update after a cooling device registered

2015-10-20 Thread Javi Merino
Hi Yu, On Tue, Oct 20, 2015 at 01:44:20AM +, Chen, Yu C wrote: > > -Original Message- > > From: Javi Merino [mailto:javi.mer...@arm.com] > > Sent: Thursday, October 15, 2015 10:05 PM > > To: Chen, Yu C > > Cc: linux...@vger.kernel.org; edubez...@gmail.co

Re: [PATCH] thermal: avoid division by zero in power allocator

2015-10-01 Thread Javi Merino
On Tue, Sep 29, 2015 at 09:33:30PM +0100, Andrew Morton wrote: > On Mon, 28 Sep 2015 23:28:34 +0200 Andrea Arcangeli > wrote: > > > During boot I get a div by zero Oops regression starting in v4.3-rc3. > > > > ... > > > > --- a/drivers/thermal/power_allocator.c > > +++ b/drivers/thermal/power_a

Re: [RFC PATCH 0/7] Introduce thermal pressure

2018-10-09 Thread Javi Merino
On Tue, Oct 09, 2018 at 12:24:55PM -0400, Thara Gopinath wrote: > Thermal governors can respond to an overheat event for a cpu by > capping the cpu's maximum possible frequency. This in turn > means that the maximum available compute capacity of the > cpu is restricted. But today in linux kernel, i

Re: [RFC PATCH 6/7] sched/fair: update cpu_capcity to reflect thermal pressure

2018-10-09 Thread Javi Merino
On Tue, Oct 09, 2018 at 12:25:01PM -0400, Thara Gopinath wrote: > cpu_capacity relflects the maximum available capacity of a cpu. Thermal > pressure on a cpu means this maximum available capacity is reduced. This > patch reduces the average thermal pressure for a cpu from its maximum > available ca

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2014-12-09 Thread Javi Merino
Hi Viresh, On Tue, Dec 09, 2014 at 01:59:39AM +, Viresh Kumar wrote: > On 8 December 2014 at 19:52, Javi Merino wrote: > > Ok, changed it into: > > > > cpu = cpumask_any(&cpufreq_device->allowed_cpus); > > dev = get_cpu

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2014-12-09 Thread Javi Merino
On Tue, Dec 09, 2014 at 10:36:46AM +, Viresh Kumar wrote: > On 9 December 2014 at 16:02, Javi Merino wrote: > > Sorry but I don't follow. __cpufreq_cooling_register() is passed a > > clip_cpus mask, not a single cpu. How do I get "the cpu for which > > __cpufr

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2014-12-09 Thread Javi Merino
On Tue, Dec 09, 2014 at 11:06:46AM +, Viresh Kumar wrote: > On 9 December 2014 at 16:30, Javi Merino wrote: > > Ok, how about this then? I've pasted the whole commit so as to avoid > > confusion. > > Yeah, the cpu_dev part looks fine now. Great, thanks! -- To

Re: [RFC PATCH v6 1/9] tracing: Add array printing helpers

2014-12-10 Thread Javi Merino
On Mon, Dec 08, 2014 at 04:04:52PM +, Dave P Martin wrote: > On Mon, Dec 08, 2014 at 03:42:10PM +, Steven Rostedt wrote: > > On Fri, 5 Dec 2014 19:04:12 +0000 > > "Javi Merino" wrote: > > [...] > > > > + > > > +DEFINE_PRINT_ARRAY(u8,

Re: [RFC PATCH v6 5/9] thermal: extend the cooling device API to include power information

2015-01-05 Thread Javi Merino
On Tue, Dec 23, 2014 at 03:14:11PM +, Eduardo Valentin wrote: > Hi Javi > > On Fri, Dec 05, 2014 at 07:04:16PM +0000, Javi Merino wrote: > > Add three optional callbacks to the cooling device interface to allow > > them to express power. In addition to the call

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2015-01-05 Thread Javi Merino
pt to > send a couple of feedback here.. Yes, some SMTP servers here are known to do that and I was using the wrong one. Sorry for that, it should not happen again. > On Tue, Dec 09, 2014 at 11:00:43AM +, Javi Merino wrote: > > On Tue, Dec 09, 2014 at 10:36:46AM +, Viresh Kuma

Re: [RFC PATCH v6 9/9] of: thermal: Introduce sustainable power for a thermal zone

2015-01-06 Thread Javi Merino
On Fri, Jan 02, 2015 at 03:53:00PM +, Eduardo Valentin wrote: > On Fri, Dec 05, 2014 at 07:04:20PM +0000, Javi Merino wrote: > > From: Punit Agrawal > > > > Introduce an optional property called, sustainable-power, which > > represents the power (in mW) which

Re: [RFC PATCH v6 5/9] thermal: extend the cooling device API to include power information

2015-01-06 Thread Javi Merino
Hi Eduardo, On Mon, Jan 05, 2015 at 09:04:09PM +, Eduardo Valentin wrote: > On Mon, Jan 05, 2015 at 03:37:10PM +0000, Javi Merino wrote: > > On Tue, Dec 23, 2014 at 03:14:11PM +, Eduardo Valentin wrote: > > > Hi Javi > > > > > > On Fri, Dec 05, 2014 at

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2015-01-06 Thread Javi Merino
Hi Eduardo, On Mon, Jan 05, 2015 at 08:44:53PM +, Eduardo Valentin wrote: > On Mon, Jan 05, 2015 at 04:53:40PM +0000, Javi Merino wrote: > > On Fri, Jan 02, 2015 at 02:37:23PM +, Eduardo Valentin wrote: > > > On Tue, Dec 09, 2014 at 11:00:43AM +, Javi Merino wrote: &

Re: [RFC PATCH v6 7/9] thermal: introduce the Power Allocator governor

2015-01-06 Thread Javi Merino
Hi Eduardo, On Fri, Jan 02, 2015 at 03:46:24PM +, Eduardo Valentin wrote: > On Fri, Dec 05, 2014 at 07:04:18PM +0000, Javi Merino wrote: > > The power allocator governor is a thermal governor that controls system > > and device power allocation to control temperature. Co

Re: [RFC PATCH v6 9/9] of: thermal: Introduce sustainable power for a thermal zone

2015-01-06 Thread Javi Merino
On Tue, Jan 06, 2015 at 01:13:03PM +, Eduardo Valentin wrote: > On Tue, Jan 06, 2015 at 09:42:15AM +0000, Javi Merino wrote: > > On Fri, Jan 02, 2015 at 03:53:00PM +, Eduardo Valentin wrote: > > > On Fri, Dec 05, 2014 at 07:04:20PM +, Javi Merino wrote: > >

Re: [RFC PATCH v6 7/9] thermal: introduce the Power Allocator governor

2015-01-06 Thread Javi Merino
Hi Eduardo, On Tue, Jan 06, 2015 at 02:18:36PM +, Eduardo Valentin wrote: > On Tue, Jan 06, 2015 at 01:23:42PM +0000, Javi Merino wrote: > > On Fri, Jan 02, 2015 at 03:46:24PM +, Eduardo Valentin wrote: > > > On Fri, Dec 05, 2014 at 07:04:18PM +, Javi Merino wrote:

[RFC PATCH v6 0/9] The power allocator thermal governor

2014-12-05 Thread Javi Merino
in (1): tracing: Add array printing helpers Javi Merino (7): tools lib traceevent: Generalize numeric argument tools lib traceevent: Add support for __print_u{8,16,32,64}_array() thermal: let governors have private data for each thermal zone thermal: extend the cooling device API to inc

[RFC PATCH v6 1/9] tracing: Add array printing helpers

2014-12-05 Thread Javi Merino
From: Dave Martin If a trace event contains an array, there is currently no standard way to format this for text output. Drivers are currently hacking around this by a) local hacks that use the trace_seq functionailty directly, or b) just not printing that information. For fixed size arrays, fo

[RFC PATCH v6 4/9] thermal: let governors have private data for each thermal zone

2014-12-05 Thread Javi Merino
some initialization and teardown when they are bound/unbound to a tz and possibly store that information in the governor_data field of the struct thermal_zone_device. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Javi Merino --- drivers/thermal/thermal_core.c | 83

[RFC PATCH v6 5/9] thermal: extend the cooling device API to include power information

2014-12-05 Thread Javi Merino
Add three optional callbacks to the cooling device interface to allow them to express power. In addition to the callbacks, add helpers to identify cooling devices that implement the power cooling device API. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Javi Merino --- Documentation

[RFC PATCH v6 8/9] thermal: add trace events to the power allocator governor

2014-12-05 Thread Javi Merino
Add trace events for the power allocator governor and the power actor interface of the cpu cooling device. Cc: Zhang Rui Cc: Eduardo Valentin Cc: Steven Rostedt Cc: Frederic Weisbecker Cc: Ingo Molnar Signed-off-by: Javi Merino --- drivers/thermal/cpu_cooling.c | 26

[RFC PATCH v6 7/9] thermal: introduce the Power Allocator governor

2014-12-05 Thread Javi Merino
udget does not exceed the control temperature. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Punit Agrawal Signed-off-by: Javi Merino --- Documentation/thermal/power_allocator.txt | 196 drivers/thermal/Kconfig | 15 + drivers/thermal/Makefile

[RFC PATCH v6 9/9] of: thermal: Introduce sustainable power for a thermal zone

2014-12-05 Thread Javi Merino
From: Punit Agrawal Introduce an optional property called, sustainable-power, which represents the power (in mW) which the thermal zone can safely dissipate. If provided the property is parsed and associated with the thermal zone via the thermal zone parameters. Cc: Zhang Rui Cc: Eduardo Valen

[RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2014-12-05 Thread Javi Merino
-off-by: Punit Agrawal Signed-off-by: Javi Merino --- Documentation/thermal/cpu-cooling-api.txt | 144 +- drivers/thermal/cpu_cooling.c | 431 +- include/linux/cpu_cooling.h | 49 +++- 3 files changed, 611 insertions(+), 13 deletions

[RFC PATCH v6 3/9] tools lib traceevent: Add support for __print_u{8,16,32,64}_array()

2014-12-05 Thread Javi Merino
Trace can now generate traces with u8, u16, u32 and u64 dynamic arrays. Add support to parse them. Cc: Arnaldo Carvalho de Melo Cc: Steven Rostedt Cc: Jiri Olsa Signed-off-by: Javi Merino --- tools/lib/traceevent/event-parse.c | 62 +++--- tools/lib

[RFC PATCH v6 2/9] tools lib traceevent: Generalize numeric argument

2014-12-05 Thread Javi Merino
Numeric arguments can be in different bases, so rename it to num so that they can be used for formats other than PRINT_HEX Cc: Steven Rostedt Cc: Arnaldo Carvalho de Melo Cc: Jiri Olsa Signed-off-by: Javi Merino --- tools/lib/traceevent/event-parse.c | 26 +- tools

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2014-12-08 Thread Javi Merino
wer_table; > +=09cpufreq_device->dyn_power_table_entries =3D i; > + > > I have seen this a lot, while I was in ARM. Had to adopt some work-arounds to > get over it. :) Sigh. Care to share them (privately I guess)? > On Sat, Dec 6, 2014 at 12:34 AM, Javi Merino wrote: > > >

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2014-12-08 Thread Javi Merino
On Mon, Dec 08, 2014 at 01:31:35PM +, Viresh Kumar wrote: > On 8 December 2014 at 18:20, Javi Merino wrote: > > Is this loop pointless? I seem to recall that it was needed but I > > forgot the details. If you think it is, I can remove it. > > Yes it is pointless. The C

Re: [RFC PATCH v6 4/9] thermal: let governors have private data for each thermal zone

2015-01-23 Thread Javi Merino
Hi Rui, On Mon, Dec 08, 2014 at 04:11:32AM +, Zhang Rui wrote: > On Fri, 2014-12-05 at 19:04 +0000, Javi Merino wrote: > > A governor may need to store its current state between calls to > > throttle(). That state depends on the thermal zone, so store it as > > p

[PATCH v4 0/3] Add array printing helpers to ftrace

2015-01-26 Thread Javi Merino
nting helpers Javi Merino (2): tools lib traceevent: factor out allocating and processing args tools lib traceevent: Add support for __print_array() include/linux/ftrace_event.h | 4 + include/trace/ftrace.h | 9 +++ kernel/trace/trace_output.c| 44 ++ tool

[PATCH v4 2/3] tools lib traceevent: factor out allocating and processing args

2015-01-26 Thread Javi Merino
: Arnaldo Carvalho de Melo Cc: Steven Rostedt Cc: Jiri Olsa Signed-off-by: Javi Merino --- tools/lib/traceevent/event-parse.c | 77 -- 1 file changed, 40 insertions(+), 37 deletions(-) diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event

[PATCH v4 1/3] tracing: Add array printing helpers

2015-01-26 Thread Javi Merino
, they take a pointer and element count: they can be used with __get_dynamic_array() for use with dynamic arrays. Cc: Steven Rostedt Cc: Ingo Molnar Signed-off-by: Dave Martin Signed-off-by: Javi Merino --- include/linux/ftrace_event.h | 4 include/trace/ftrace.h | 9

[PATCH v4 3/3] tools lib traceevent: Add support for __print_array()

2015-01-26 Thread Javi Merino
Trace can now generate traces with variable element size arrays. Add support to parse them. Cc: Namhyung Kim Cc: Arnaldo Carvalho de Melo Cc: Steven Rostedt Cc: Jiri Olsa Signed-off-by: Javi Merino --- tools/lib/traceevent/event-parse.c | 94 ++ tools

[PATCH] sysfs: fix warning when creating a sysfs group without attributes

2015-01-15 Thread Javi Merino
t Cc: Greg Kroah-Hartman Signed-off-by: Javi Merino --- fs/sysfs/group.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/sysfs/group.c b/fs/sysfs/group.c index 7d2a860ba788..2554d8835b48 100644 --- a/fs/sysfs/group.c +++ b/fs/sysfs/group.c @@ -99,7 +99,7 @@ stati

[RESEND PATCH v2 2/2] tools lib traceevent: Add support for __print_array()

2015-01-15 Thread Javi Merino
Trace can now generate traces with variable element size arrays. Add support to parse them. Cc: Namhyung Kim Cc: Arnaldo Carvalho de Melo Cc: Steven Rostedt Cc: Jiri Olsa Signed-off-by: Javi Merino --- tools/lib/traceevent/event-parse.c | 127 + tools

[RESEND PATCH v2 1/2] tracing: Add array printing helpers

2015-01-15 Thread Javi Merino
, they take a pointer and element count: they can be used with __get_dynamic_array() for use with dynamic arrays. Cc: Steven Rostedt Cc: Ingo Molnar Signed-off-by: Dave Martin Signed-off-by: Javi Merino --- Changes since v1[0] - Replaced the DEFINE_PRINT_ARRAY macros with a single

Re: [RESEND PATCH v2 1/2] tracing: Add array printing helpers

2015-01-16 Thread Javi Merino
On Fri, Jan 16, 2015 at 02:22:02AM +, Steven Rostedt wrote: > On Thu, 15 Jan 2015 16:50:58 + > Javi Merino wrote: > > > +const char * > > +ftrace_print_array_seq(struct trace_seq *p, const void *buf, int > > buf_len, > > + size_t el_siz

Re: [RESEND PATCH v2 2/2] tools lib traceevent: Add support for __print_array()

2015-01-16 Thread Javi Merino
On Fri, Jan 16, 2015 at 02:35:19AM +, Steven Rostedt wrote: > On Thu, 15 Jan 2015 12:05:52 -0500 > Javi Merino wrote: > > > Trace can now generate traces with variable element size arrays. Add > > support to parse them. > > > > Cc: Namhyung Kim > &g

[PATCH v3 1/3] tracing: Add array printing helpers

2015-01-19 Thread Javi Merino
, they take a pointer and element count: they can be used with __get_dynamic_array() for use with dynamic arrays. Cc: Steven Rostedt Cc: Ingo Molnar Signed-off-by: Dave Martin Signed-off-by: Javi Merino --- Changes since v2[0]: - Changed BUG() into a trace_seq_printf() - Add BUILD_BUG_ON

[PATCH v3 2/3] tools lib traceevent: factor out allocating and processing args

2015-01-19 Thread Javi Merino
: Arnaldo Carvalho de Melo Cc: Steven Rostedt Cc: Jiri Olsa Signed-off-by: Javi Merino --- This patch wasn't part of v2. It avoids repeating code in patch 3. tools/lib/traceevent/event-parse.c | 77 -- 1 file changed, 40 insertions(+), 37 deletions(-)

[PATCH v3 3/3] tools lib traceevent: Add support for __print_array()

2015-01-19 Thread Javi Merino
Trace can now generate traces with variable element size arrays. Add support to parse them. Cc: Namhyung Kim Cc: Arnaldo Carvalho de Melo Cc: Steven Rostedt Cc: Jiri Olsa Signed-off-by: Javi Merino --- Changes since v2[0]: - Avoid repeating the alloc and process of fields in

Re: [PATCH v4 1/3] tracing: Add array printing helpers

2015-01-28 Thread Javi Merino
On Wed, Jan 28, 2015 at 03:35:57AM +, Steven Rostedt wrote: > On Mon, 26 Jan 2015 12:11:49 + > Javi Merino wrote: > > > From: Dave Martin > > > > If a trace event contains an array, there is currently no standard > > way to format this for text outpu

Re: [PATCH v4 1/3] tracing: Add array printing helpers

2015-01-28 Thread Javi Merino
On Wed, Jan 28, 2015 at 11:26:09AM +, Javi Merino wrote: > On Wed, Jan 28, 2015 at 03:35:57AM +, Steven Rostedt wrote: > > On Mon, 26 Jan 2015 12:11:49 + > > Javi Merino wrote: > > > > > From: Dave Martin > > > > > > If a trac

[PATCH v1 2/7] thermal: extend the cooling device API to include power information

2015-01-28 Thread Javi Merino
Add three optional callbacks to the cooling device interface to allow them to express power. In addition to the callbacks, add helpers to identify cooling devices that implement the power cooling device API. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Javi Merino --- drivers/thermal

[PATCH v1 0/7] The power allocator thermal governor

2015-01-28 Thread Javi Merino
aced the cooling device interface with a separate power actor API - Addressed most of Eduardo's comments - Incorporated ftrace support for bitmask to trace cpumasks Cheers, Javi & Punit Javi Merino (6): thermal: let governors have private data for each thermal zone thermal: exte

[PATCH v1 6/7] of: thermal: Introduce sustainable power for a thermal zone

2015-01-28 Thread Javi Merino
From: Punit Agrawal Introduce an optional property called, sustainable-power, which represents the power (in mW) which the thermal zone can safely dissipate. If provided the property is parsed and associated with the thermal zone via the thermal zone parameters. Cc: Zhang Rui Cc: Eduardo Valen

[PATCH v1 5/7] thermal: add trace events to the power allocator governor

2015-01-28 Thread Javi Merino
Add trace events for the power allocator governor and the power actor interface of the cpu cooling device. Cc: Zhang Rui Cc: Eduardo Valentin Cc: Steven Rostedt Cc: Frederic Weisbecker Cc: Ingo Molnar Signed-off-by: Javi Merino --- drivers/thermal/cpu_cooling.c | 31

[PATCH v1 7/7] thermal: export thermal_zone_parameters to sysfs

2015-01-28 Thread Javi Merino
It's useful for tuning to be able to edit thermal_zone_parameters from userspace. Export them to the thermal_zone sysfs so that they can be easily changed. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Javi Merino --- Documentation/thermal/sysfs-api.txt | 52 + dr

[PATCH v1 4/7] thermal: introduce the Power Allocator governor

2015-01-28 Thread Javi Merino
udget does not exceed the control temperature. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Punit Agrawal Signed-off-by: Javi Merino --- Documentation/thermal/power_allocator.txt | 241 +++ drivers/thermal/Kconfig | 15 + drivers/thermal/Makefile

[PATCH v1 1/7] thermal: let governors have private data for each thermal zone

2015-01-28 Thread Javi Merino
some initialization and teardown when they are bound/unbound to a tz and possibly store that information in the governor_data field of the struct thermal_zone_device. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Javi Merino --- Hi Rui, You said[0] that you had applied it but I can't s

[PATCH v1 3/7] thermal: cpu_cooling: implement the power cooling device API

2015-01-28 Thread Javi Merino
-off-by: Punit Agrawal Signed-off-by: Javi Merino --- Documentation/thermal/cpu-cooling-api.txt | 156 +- drivers/thermal/cpu_cooling.c | 480 +- include/linux/cpu_cooling.h | 39 +++ 3 files changed, 670 insertions(+), 5 deletions

[PATCH v5 1/3] tracing: Add array printing helper

2015-01-28 Thread Javi Merino
take a pointer and element count: they can be used with __get_dynamic_array() for use with dynamic arrays. Cc: Steven Rostedt Cc: Ingo Molnar Signed-off-by: Dave Martin Signed-off-by: Javi Merino --- include/linux/ftrace_event.h | 4 include/trace/ftrace.h | 9 + kernel

[PATCH 0/4] Consolidate DIV_ROUND_CLOSEST_ULL()

2015-03-20 Thread Javi Merino
vor of the one in kernel.h Javi Merino (4): kernel.h: Implement DIV_ROUND_CLOSEST_ULL clk: bcm/kona: use DIV_ROUND_CLOSEST_ULL() cpuidle: menu: use DIV_ROUND_CLOSEST_ULL() media: cxd2820r: use DIV_ROUND_CLOSEST_ULL() drivers/clk/bcm/clk-kona.c

[PATCH 2/4] clk: bcm/kona: use DIV_ROUND_CLOSEST_ULL()

2015-03-20 Thread Javi Merino
Now that the kernel provides DIV_ROUND_CLOSEST_ULL(), drop the internal implementation and use the kernel one. Cc: Mike Turquette Cc: Stephen Boyd Cc: Alex Elder Signed-off-by: Javi Merino --- I've only compile-tested this, I don't have the hardware to test it. drivers/clk/bcm/

[PATCH 4/4] media: cxd2820r: use DIV_ROUND_CLOSEST_ULL()

2015-03-20 Thread Javi Merino
Now that the kernel provides DIV_ROUND_CLOSEST_ULL(), drop the internal implementation and use the kernel one. Cc: Antti Palosaari Cc: Mauro Carvalho Chehab Signed-off-by: Javi Merino --- I've only compile-tested it, I don't have the hardware to run it. drivers/media/dvb

[PATCH 3/4] cpuidle: menu: use DIV_ROUND_CLOSEST_ULL()

2015-03-20 Thread Javi Merino
Now that the kernel provides DIV_ROUND_CLOSEST_ULL(), drop the internal implementation and use the kernel one. Cc: "Rafael J. Wysocki" Cc: Mel Gorman Cc: Stephen Hemminger Signed-off-by: Javi Merino --- drivers/cpuidle/governors/menu.c | 8 +--- 1 file changed, 1 inser

[PATCH 1/4] kernel.h: Implement DIV_ROUND_CLOSEST_ULL

2015-03-20 Thread Javi Merino
We have grown a number of different implementations of DIV_ROUND_CLOSEST_ULL throughout the kernel. Move the i915 one to kernel.h so that it can be reused. Cc: Daniel Vetter Cc: Jani Nikula Cc: David Airlie Cc: Darrick J. Wong Cc: Guenter Roeck Cc: Andrew Morton Signed-off-by: Javi Merino

Re: [PATCH 4/4] media: cxd2820r: use DIV_ROUND_CLOSEST_ULL()

2015-03-20 Thread Javi Merino
On Fri, Mar 20, 2015 at 01:51:36PM +, Alex Elder wrote: > On 03/20/2015 06:14 AM, Javi Merino wrote: > > Now that the kernel provides DIV_ROUND_CLOSEST_ULL(), drop the internal > > implementation and use the kernel one. > > > > Cc: Antti Palosaari > > Cc:

[RESEND PATCH v8 0/2] Add array printing support to libtraceevent

2015-03-20 Thread Javi Merino
rnel/1897935 [1] http://thread.gmane.org/gmane.linux.kernel/1896232 Javi Merino (2): tools lib traceevent: factor out allocating and processing args tools lib traceevent: Add support for __print_array() tools/lib/traceevent/event-parse.c | 158 + tools/

[RESEND PATCH v8 1/2] tools lib traceevent: factor out allocating and processing args

2015-03-20 Thread Javi Merino
Melo Cc: Jiri Olsa Acked-by: Steven Rostedt Acked-by: Namhyung Kim Signed-off-by: Javi Merino --- tools/lib/traceevent/event-parse.c | 77 -- 1 file changed, 40 insertions(+), 37 deletions(-) diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib

[RESEND PATCH v8 2/2] tools lib traceevent: Add support for __print_array()

2015-03-20 Thread Javi Merino
Since 6ea22486ba46 ("tracing: Add array printing helper") trace can traces with variable element size arrays. Add support to parse them. Cc: Arnaldo Carvalho de Melo Cc: Jiri Olsa Acked-by: Steven Rostedt Acked-by: Namhyung Kim Signed-off-by: Javi Merino --- tools/lib/tracee

Re: [PATCH 1/4] kernel.h: Implement DIV_ROUND_CLOSEST_ULL

2015-03-20 Thread Javi Merino
On Fri, Mar 20, 2015 at 06:19:26PM +, Emil Velikov wrote: > On 20 March 2015 at 11:14, Javi Merino wrote: > > We have grown a number of different implementations of > > DIV_ROUND_CLOSEST_ULL throughout the kernel. Move the i915 one to > > kernel.h so that it can be reuse

Re: [GIT PULL 0/4] perf/urgent fixes

2015-04-24 Thread Javi Merino
trace_seq *s, void > *data, int size, > } else if (el_size == 4) { > trace_seq_printf(s, "%u", *(uint32_t *)num); > } else if (el_size == 8) { > - trace_seq_printf(s, "%lu", *(uin

Re: [GIT PULL] Thermal-SoC management updates for v4.1-rc1

2015-04-27 Thread Javi Merino
On Wed, Apr 15, 2015 at 06:48:20AM +0100, Eduardo Valentin wrote: > Hello Rui, > > Please pull from > > git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal > linus > > to receive Thermal-SoC Management updates for v4.1-rc1 with top-most > > 55920e072776533fd314fb3d9b69c8

Re: [PATCH v2] tracing: make ftrace_print_array_seq compute buf_len

2015-04-29 Thread Javi Merino
On Wed, Apr 29, 2015 at 05:06:22PM +0100, Steven Rostedt wrote: > On Wed, 29 Apr 2015 17:02:50 +0100 > Alex Bennée wrote: > > > > > Steven Rostedt writes: > > > > > On Wed, 29 Apr 2015 16:18:46 +0100 > > > Alex Bennée wrote: > > > > > >> The only caller to this function (__print_array) was ge

Re: [PATCH v5 3/3] tools lib traceevent: Add support for __print_array()

2015-06-04 Thread Javi Merino
Hi Steve, On Fri, Feb 27, 2015 at 02:15:05PM +, Steven Rostedt wrote: > On Fri, 27 Feb 2015 12:32:32 + > Javi Merino wrote: > > On Wed, Jan 28, 2015 at 12:48:55PM +, Javi Merino wrote: > > > Trace can now generate traces with variable element size arrays. Add &

Re: [RESEND PATCH] MAINTAINERS: update thermal CPU cooling section

2021-04-10 Thread Javi Merino
gt; >>> > >>> Regards, > >>> Lukasz > >>> > >>>   MAINTAINERS | 2 +- > >>>   1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/MAINTAINERS b/MAINTAINERS > >>> index f32eb

Re: [PATCH] thermal: tell cooling devices when a trip_point changes

2014-07-31 Thread Javi Merino
On Thu, Jul 31, 2014 at 12:10:40AM +0100, Matt Longnecker wrote: > Some hardware can react autonomously at a programmed temperature. > For example, an SoC might implement a last ditch throttle or a > hardware thermal shutdown. The driver for such a device can > register itself as a cooling_device w

checkpatch: false positives when parsing trace includes

2014-04-29 Thread Javi Merino
Hi, checkpatch complains about the spaces before the close parenthesis in trace events: ERROR: space prohibited before that close parenthesis ')' #94: FILE: include/trace/events/thermal.h:14: + __field(unsigned int, freq ) However, in that directory, that's actually the norm,

[PATCH] thermal: document struct thermal_zone_device and thermal_governor

2014-05-16 Thread Javi Merino
Document struct struct thermal_zone_device and struct thermal_governor fields and their use by the thermal framework code. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Javi Merino --- Hi linux-pm, I have some patches that add new fields to these structures but I don't have a good

Re: [RFC PATCH 2/5] thermal: cpu_cooling: Add notifications support for the clients

2014-05-16 Thread Javi Merino
Hi Amit, On Thu, May 08, 2014 at 03:37:57PM +0100, Amit Daniel Kachhap wrote: > This patch adds notification support for those clients of cpu_cooling > APIs which may want to do something interesting after receiving these > cpu_cooling events. The notifier structure passed is of both Set/Get type.

[RFC PATCH v2 3/7] thermal: let governors have private data for each thermal zone

2014-05-20 Thread Javi Merino
some initialization and teardown when they are bound/unbound to a tz and possibly store that information in the governor_data field of the struct thermal_zone_device. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Javi Merino --- drivers/thermal/thermal_core.c | 83

[RFC PATCH v2 1/7] tracing: Add __bitmask() macro to trace events to cpumasks and other bitmasks

2014-05-20 Thread Javi Merino
mm=ksmtuned pid=3615 prio=120 orig_cpu=2 dest_cpu=3 cpumask=,000f Link: http://lkml.kernel.org/r/1399377998-14870-6-git-send-email-javi.mer...@arm.com Link: http://lkml.kernel.org/r/20140506132238.22e13...@gandalf.local.home Suggested-by: Javi Merino Tested-by: Javi Merino Signed-off-b

[RFC PATCH v2 5/7] thermal: add a basic cpu power actor

2014-05-20 Thread Javi Merino
their OPPs in the OPP library. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Punit Agrawal Signed-off-by: Javi Merino --- Documentation/thermal/power_actor.txt | 46 drivers/thermal/Kconfig |5 + drivers/thermal/power_actor/Kconfig |9 + drivers

[RFC PATCH v2 2/7] thermal: document struct thermal_zone_device and thermal_governor

2014-05-20 Thread Javi Merino
Document struct thermal_zone_device and struct thermal_governor fields and their use by the thermal framework code. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Javi Merino --- Hi linux-pm, This was sent as a separate patch to linux-pm and can be merged independently, as it documents

  1   2   3   4   5   >