Re: [PATCH 0/6] mailbox: arm_mhu: add support to use in doorbell mode

2019-06-06 Thread Jassi Brar
On Thu, Jun 6, 2019 at 7:51 AM Sudeep Holla wrote: > > > BTW, this is not going to be the end of SCMI troubles (I believe > > that's what his client is). SCMI will eventually have to be broken up > > in layers (protocol and transport) for many legit platforms to use it. > > That is mbox_send_mess

Re: [PATCH 1/4] mailbox: arm_mhuv2: add device tree binding documentation

2019-07-21 Thread Jassi Brar
On Wed, Jul 17, 2019 at 2:26 PM Tushar Khandelwal wrote: > diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhuv2.txt > b/Documentation/devicetree/bindings/mailbox/arm,mhuv2.txt > new file mode 100644 > index ..3a05593414bc > --- /dev/null > +++ b/Documentation/devicetree/b

Re: [PATCH 1/2] dt-bindings: milbeaut-m10v-hdmac: Add Socionext Milbeaut HDMAC bindings

2019-07-09 Thread Jassi Brar
On Tue, Jul 9, 2019 at 9:34 AM Rob Herring wrote: > > On Wed, Jun 12, 2019 at 07:52:37PM -0500, jassisinghb...@gmail.com wrote: > > From: Jassi Brar > > > > Document the devicetree bindings for Socionext Milbeaut HDMAC > > controller. Controller has upto 8 floa

[GIT PULL] Mailbox fixes for v5.0

2019-02-18 Thread Jassi Brar
Hi Linus, The following changes since commit a3b22b9f11d9fbc48b0291ea92259a5a810e9438: Linux 5.0-rc7 (2019-02-17 18:46:40 -0800) are available in the Git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.git tags/mailbox-fixes-v5.0-rc7 for you to fetch changes u

Re: [PATCH 5/5] hisi: Consolidate the Kconfigs for the CLOCK_STUB and the MAILBOX

2018-05-08 Thread Jassi Brar
nsible defaults in place, we can leave > other choices for EXPERT. > Acked-by: Jassi Brar

Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2017-01-31 Thread Jassi Brar
On Thu, Jan 26, 2017 at 2:07 PM, Horng-Shyang Liao wrote: > Hi Jassi, > > On Thu, 2017-01-26 at 10:08 +0530, Jassi Brar wrote: >> On Wed, Jan 4, 2017 at 8:36 AM, HS Liao wrote: >> >> > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c >> > b/drivers/mailbo

Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2017-01-25 Thread Jassi Brar
On Wed, Jan 4, 2017 at 8:36 AM, HS Liao wrote: > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c > b/drivers/mailbox/mtk-cmdq-mailbox.c > new file mode 100644 > index 000..747bcd3 > --- /dev/null > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c ... > +static void cmdq_task_exec(struct cmdq_pkt *

Re: [RFC PATCH v2 1/9] mailbox: Add Amlogic Meson Message-Handling-Unit

2016-07-06 Thread Jassi Brar
On Wed, Jul 6, 2016 at 6:47 PM, Neil Armstrong wrote: > 2016-07-04 17:38 GMT+02:00 Jassi Brar : >> On Tue, Jun 21, 2016 at 3:32 PM, Neil Armstrong >> wrote: >>> Add Amlogic Meson SoCs Message-Handling-Unit as mailbox controller >>> with 2 independent channels/l

Re: [RFC PATCH 0/5] USB Audio Gadget refactoring

2016-07-26 Thread Jassi Brar
On Tue, Jul 26, 2016 at 7:01 AM, Ruslan Bilovol wrote: > On Fri, Jul 15, 2016 at 10:43 AM, Clemens Ladisch wrote: On Tue, May 24, 2016 at 2:50 AM, Ruslan Bilovol wrote: > it may break current usecase for some people >> >> And what are the benefits that justify breaking the kernel A

Re: [RFC PATCH v2 1/9] mailbox: Add Amlogic Meson Message-Handling-Unit

2016-07-04 Thread Jassi Brar
On Tue, Jun 28, 2016 at 8:36 PM, Jassi Brar wrote: > On Tue, Jun 28, 2016 at 7:30 PM, Neil Armstrong > wrote: >> >> My main question is : do you really want to transform this simple driver into >> a dirty multi-bus generic mailbox driver ? >> The meson_mhu is only

Re: [RFC PATCH v2 1/9] mailbox: Add Amlogic Meson Message-Handling-Unit

2016-07-04 Thread Jassi Brar
.c from : > + * Copyright (C) 2013-2015 Fujitsu Semiconductor Ltd. > + * Copyright (C) 2015 Linaro Ltd. > + * Author: Jassi Brar > + * > + * This program is free software: you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as publishe

Re: [PATCH v4 2/2] mailbox: Add Tegra HSP driver

2016-11-15 Thread Jassi Brar
On Tue, Nov 15, 2016 at 9:18 PM, Thierry Reding wrote: > + > +struct tegra_hsp_channel; > +struct tegra_hsp; > + > +struct tegra_hsp_channel_ops { > + int (*send_data)(struct tegra_hsp_channel *channel, void *data); > + int (*startup)(struct tegra_hsp_channel *channel); > +

Re: [PATCH v4 2/2] mailbox: Add Tegra HSP driver

2016-11-16 Thread Jassi Brar
On Wed, Nov 16, 2016 at 8:38 PM, Thierry Reding wrote: > On Wed, Nov 16, 2016 at 10:58:07AM +0530, Jassi Brar wrote: >> On Tue, Nov 15, 2016 at 9:18 PM, Thierry Reding >> wrote: >> >> >> > + >> > +struct tegra_hsp_channel; >> > +struc

Re: [PATCH v5] mailbox: Add Tegra HSP driver

2016-11-18 Thread Jassi Brar
by Joseph Lo . > > Signed-off-by: Thierry Reding Acked-by: Jassi Brar

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

2016-10-10 Thread Jassi Brar
On 11 October 2016 at 08:10, Horng-Shyang Liao wrote: > On Thu, 2016-10-06 at 18:40 +0530, Jassi Brar wrote: >> On 6 October 2016 at 18:31, Horng-Shyang Liao wrote: >> >> > Back to our original statement, we need to flush all tasks to queue >> > in GCE HW; i.e.

[GIT PULL] Mailbox changes for v4.9

2016-10-05 Thread Jassi Brar
Hi Linus, The following changes since commit d060e0f603a4156087813d221d818bb39ec91429: Merge tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dledford/rdma (2016-09-06 12:33:12 -0700) are available in the git repository at: git://git.linaro.org/landing-teams/working/fujitsu/

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

2016-10-06 Thread Jassi Brar
On 6 October 2016 at 18:31, Horng-Shyang Liao wrote: > Back to our original statement, we need to flush all tasks to queue > in GCE HW; i.e. we need to use mbox_client_txdone after > mbox_send_message, or send tx_done once mailbox controller receive > message (task). However, we still need a way

Re: [PATCH v16 0/5] Mediatek MT8173 CMDQ support

2016-11-13 Thread Jassi Brar
On 11 November 2016 at 15:04, Horng-Shyang Liao wrote: > On Fri, 2016-11-11 at 11:15 +0530, Jassi Brar wrote: >> On Thu, Nov 10, 2016 at 4:45 PM, Horng-Shyang Liao >> wrote: >> > On Tue, 2016-11-01 at 19:28 +0800, HS Liao wrote: >> >> Hi, >> >>

Re: [PATCH v16 0/5] Mediatek MT8173 CMDQ support

2016-11-10 Thread Jassi Brar
On Thu, Nov 10, 2016 at 4:45 PM, Horng-Shyang Liao wrote: > On Tue, 2016-11-01 at 19:28 +0800, HS Liao wrote: >> Hi, >> >> This is Mediatek MT8173 Command Queue(CMDQ) driver. The CMDQ is used >> to help write registers with critical time limitation, such as >> updating display configuration during

[GIT PULL] Mailbox changes for v4.10

2016-12-20 Thread Jassi Brar
Hi Linus, The following changes since commit 16ae16c6e5616c084168740990fc508bda6655d4: Merge tag 'mmc-v4.9-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc (2016-11-24 10:51:18 -0800) are available in the git repository at: git://git.linaro.org/landing-teams/working/fujitsu/in

Re: [PATCH 1/2] mailbox: mailbox-test: add support for fasync/poll

2016-12-10 Thread Jassi Brar
ch implements the poll and fasync file operation callback for >> the test mailbox device. >> >> Cc: Lee Jones >> Cc: Jassi Brar >> Signed-off-by: Sudeep Holla > > Gentle Ping! > Would be good to have Lee's ack.

Re: [PATCH v5 1/2] mailbox: Add driver for Broadcom FlexRM ring manager

2017-03-14 Thread Jassi Brar
On Mon, Mar 6, 2017 at 10:40 AM, Anup Patel wrote: > Some of the Broadcom iProc SoCs have FlexRM ring manager > which provides a ring-based programming interface to various > offload engines (e.g. RAID, Crypto, etc). > > This patch adds a common mailbox driver for Broadcom FlexRM > ring manager wh

Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2017-02-22 Thread Jassi Brar
On Wed, Feb 22, 2017 at 8:42 AM, Horng-Shyang Liao wrote: > On Thu, 2017-02-16 at 21:02 +0530, Jassi Brar wrote: >> On Mon, Feb 6, 2017 at 11:07 AM, Horng-Shyang Liao >> wrote: >> > Hi Jassi, >> > >> > On Wed, 2017-02-01 at 10:52 +0530, Jassi Brar wr

Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2017-02-16 Thread Jassi Brar
On Mon, Feb 6, 2017 at 11:07 AM, Horng-Shyang Liao wrote: > Hi Jassi, > > On Wed, 2017-02-01 at 10:52 +0530, Jassi Brar wrote: >> On Thu, Jan 26, 2017 at 2:07 PM, Horng-Shyang Liao >> wrote: >> > Hi Jassi, >> > >> > On Thu, 2017-01-26 at 10:08 +0

Re: [PATCH 1/6] mailbox: Add new API mbox_channel_device() for clients

2017-02-03 Thread Jassi Brar
On Thu, Feb 2, 2017 at 10:17 AM, Anup Patel wrote: > The remote processor can have DMAENGINE capabilities and client > can pass data to be processed via main memory. In such cases, > the client will require DMAble memory for remote processor. > > This patch adds new API mbox_channel_device() which

Re: [PATCH 1/3] Documentation: dtb: xgene: Add hwmon dts binding documentation

2016-06-07 Thread Jassi Brar
On Tue, May 24, 2016 at 6:31 AM, Hoan Tran wrote: > Hi Rob, > > Thanks for your review ! > > On Mon, May 23, 2016 at 1:30 PM, Rob Herring wrote: >> >> On Mon, May 16, 2016 at 09:17:25AM -0700, Hoan Tran wrote: >> > This patch adds the APM X-Gene hwmon device tree node documentation. >> > >> > Sig

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

2016-06-03 Thread Jassi Brar
On Fri, Jun 3, 2016 at 4:48 PM, Matthias Brugger wrote: > On 03/06/16 08:12, Horng-Shyang Liao wrote: >> On Thu, 2016-06-02 at 10:46 +0200, Matthias Brugger wrote: >>> I keep thinking about how to get rid of the two data structures, >>> task_busy_list and the task_release_wq. We need the latter f

Re: [RFC PATCH v2 1/9] mailbox: Add Amlogic Meson Message-Handling-Unit

2016-06-25 Thread Jassi Brar
-#define INTR_STAT_OFS 0x0 -#define INTR_SET_OFS 0x8 -#define INTR_CLR_OFS 0x10 - -#define MHU_LP_OFFSET 0x0 -#define MHU_HP_OFFSET 0x20 -#define MHU_SEC_OFFSET 0x200 -#define TX_REG_OFFSET 0x100 +#define INTR_SET_OFS 0x0 +#define INTR_STAT_OFS 0x4 +#define INTR_CLR_OFS 0x8 -#define M

Re: [PATCH 2/3] mailbox: Add Broadcom PDC mailbox driver

2016-06-25 Thread Jassi Brar
On Tue, May 24, 2016 at 11:37 PM, Rob Rice wrote: > From: Rob Rice > > The Broadcom PDC mailbox driver is a mailbox controller that > manages data transfers to and from one or more offload engines. > > Signed-off-by: Rob Rice > Reviewed-by: Scott Branden > Reviewed-by: Ray Jui > --- > drivers

Re: [RFC PATCH v2 1/9] mailbox: Add Amlogic Meson Message-Handling-Unit

2016-06-28 Thread Jassi Brar
On Tue, Jun 28, 2016 at 7:30 PM, Neil Armstrong wrote: > On 06/25/2016 07:50 PM, Jassi Brar wrote: >> -#define INTR_STAT_OFS 0x0 >> -#define INTR_SET_OFS 0x8 >> -#define INTR_CLR_OFS 0x10 >> - >> -#define MHU_LP_OFFSET 0x0 >> -#define MHU_HP_OFFSET

Re: [PATCH 2/3] mailbox: Add Broadcom PDC mailbox driver

2016-06-28 Thread Jassi Brar
On Tue, Jun 28, 2016 at 7:06 PM, Rob Rice wrote: >>> drivers/mailbox/Kconfig |9 + >>> drivers/mailbox/Makefile|2 + >>> drivers/mailbox/mailbox-pdc/Makefile|8 + >>> drivers/mailbox/mailbox-pdc/pdc.c | 1181 >>> +

Re: [PATCH v1 2/3] mailbox: rockchip: Add Rockchip mailbox driver

2016-03-10 Thread Jassi Brar
On Tue, Mar 8, 2016 at 1:48 AM, Heiko Stübner wrote: > Hi Jassi, > > Am Dienstag, 27. Oktober 2015, 15:31:45 schrieb Caesar Wang: >> This driver is found on RK3368 SoCs. >> >> The Mailbox module is a simple APB peripheral that allows both >> the Cortex-A53 MCU system to communicate by writing oper

Re: [PATCH 30/41] clk: mb86s7x: Remove CLK_IS_ROOT

2016-03-03 Thread Jassi Brar
On 2 March 2016 at 00:30, Stephen Boyd wrote: > This flag is a no-op now. Remove usage of the flag. > > Cc: Jassi Brar > Signed-off-by: Stephen Boyd Acked-by: Jassi Brar

Re: [PATCH V2 2/2] mailbox: Introduce TI message manager driver

2016-03-03 Thread Jassi Brar
On Sat, Feb 27, 2016 at 3:54 AM, Nishanth Menon wrote: > Support for TI Message Manager Module. This hardware block manages a > bunch of hardware queues meant for communication between processor > entities. > > Clients sitting on top of this would manage the required protocol > for communicating w

Re: [PATCH V2 2/2] mailbox: Introduce TI message manager driver

2016-03-07 Thread Jassi Brar
On Fri, Mar 4, 2016 at 8:05 PM, Nishanth Menon wrote: > Hi Jassi, > > Thanks for reviewing the patch. > On 03/03/2016 11:18 PM, Jassi Brar wrote: > > [...] > >>> >>> drivers/mailbox/Kconfig | 11 + >>> drivers/mailbox/Makefile| 2 + &g

Re: [PATCH V2 2/2] mailbox: Introduce TI message manager driver

2016-03-07 Thread Jassi Brar
On Tue, Mar 8, 2016 at 2:18 AM, Nishanth Menon wrote: > On 03/07/2016 12:31 PM, Jassi Brar wrote: >> On Fri, Mar 4, 2016 at 8:05 PM, Nishanth Menon wrote: >>>> >>>>> +static int ti_msgmgr_send_data(struct mbox_chan *chan, void *data) >>>>> +{

[GIT PULL 2nd] Mailbox changes for v4.6

2016-03-23 Thread Jassi Brar
Hi Linus, Due to some last minute cosmetic changes, the driver was not included in the first pull request, otherwise the driver has been reviewed twice. Could you please consider pulling it, so it doesn't get delayed for another cycle? The following changes since commit c5a9d1f30c066b7922a5f66b8

[GIT PULL] Mailbox changes for v4.6

2016-03-20 Thread Jassi Brar
Hi Linus, The following changes since commit 1926e54f115725a9248d0c4c65c22acaf94de4c4: MAINTAINERS: Update mailing list for Renesas ARM64 SoC Development (2016-02-14 18:38:15 -0800) are available in the git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.git ma

Re: [PATCH 1/2] Documentation: dt: mailbox: Add TI Message Manager

2016-02-10 Thread Jassi Brar
On Tue, Feb 9, 2016 at 11:40 PM, Nishanth Menon wrote: > On 09:43-20160209, Nishanth Menon wrote: >> On Tue, Feb 9, 2016 at 8:54 AM, Jassi Brar wrote: > [..] >> Let me prototype this as part of of_xlate and see if I can pull the >> qinst data back out.. obviously one nega

Re: [PATCH 0/3] mailbox: rockchip: Add mailbox driver for Rockchip platform

2015-09-28 Thread Jassi Brar
On Sun, Sep 27, 2015 at 7:09 PM, Caesar Wang wrote: > Hello Jassi, > > Friendly Ping! > > Could you review this series patchs if you have free time? > It's been only 2 weeks since you posted the driver and I have been busy with stuff that missed the last release. I did not miss your patchset. -Ja

Re: [PATCH 1/2] mailbox: switch to hrtimer for tx_complete polling

2015-07-31 Thread Jassi Brar
On Fri, Jul 31, 2015 at 3:22 PM, Sudeep Holla wrote: > >>> >>> Again, sorry for misleading comment, we do need hrtimer as replied on >>> scpi thread. Any other concern with this patch ? >>> >> Polling by hrtimers is OK. Not to mean this is the best solution for >> your platform. Please revise the

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-31 Thread Jassi Brar
On Fri, Jul 31, 2015 at 3:10 PM, Sudeep Holla wrote: > > I forgot to mention, we have a the following description in > mbox_client_txdone which is misleading: > > "The client/protocol had received some 'ACK' packet and it notifies the > API that the last packet was sent successfully. This only wor

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-31 Thread Jassi Brar
On Fri, Jul 31, 2015 at 6:38 PM, Sudeep Holla wrote: > > > On 31/07/15 11:43, Sudeep Holla wrote: >> >> >> >> On 31/07/15 11:38, Jassi Brar wrote: >>> >>> On Fri, Jul 31, 2015 at 3:10 PM, Sudeep Holla >>> wrote: >>>&g

[GIT PULL] Mailbox changes for v4.2

2015-06-25 Thread Jassi Brar
Hi Linus, The following changes since commit 030bbdbf4c833bc69f502eae58498bc5572db736: Linux 4.1-rc3 (2015-05-10 15:12:29 -0700) are available in the git repository at: http://git.linaro.org/landing-teams/working/fujitsu/integration.git mailbox-for-next for you to fetch changes up to 7d641

Re: [GIT PULL] Mailbox changes for v4.2

2015-06-25 Thread Jassi Brar
On Fri, Jun 26, 2015 at 7:10 AM, Linus Torvalds wrote: > On Thu, Jun 25, 2015 at 8:58 AM, Jassi Brar wrote: >> >> http://git.linaro.org/landing-teams/working/fujitsu/integration.git >> mailbox-for-next > > So just looking at this pull request (and my previous merges

Re: [PATCH v2 2/6] mailbox: dt-bindings: Add shared [driver <=> device tree] defines

2015-08-12 Thread Jassi Brar
On Wed, Aug 12, 2015 at 2:23 PM, Lee Jones wrote: > On Mon, 10 Aug 2015, Jassi Brar wrote: > >> On Mon, Aug 10, 2015 at 1:54 PM, Lee Jones wrote: >> > On Mon, 10 Aug 2015, Jassi Brar wrote: >> >> On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones wrote: >> >

Re: [PATCHv6 1/2] dts: Adding docs for Xilinx LogiCORE IP mailbox driver.

2015-07-06 Thread Jassi Brar
On Mon, Jul 6, 2015 at 10:57 PM, Sören Brinkmann wrote: > On Mon, 2015-07-06 at 10:16AM -0700, Moritz Fischer wrote: >> Signed-off-by: Moritz Fischer >> Acked-by: Michal Simek >> --- >> .../devicetree/bindings/mailbox/xilinx-mailbox.txt | 44 >> ++ >> 1 file changed, 44 ins

Re: Query: Clock driver requests mailbox channel

2015-07-06 Thread Jassi Brar
On Mon, Jul 6, 2015 at 5:03 PM, Leo Yan wrote: > Hi all, > > i'm working with one clock driver, which will invoke mailbox API to > request the mailbox channel and send message. > > Usually clock driver will init with devicetree, below is the example: > CLK_OF_DECLARE(hi6220_clk_power, "hisilicon,h

Re: [PATCH] mailbox: pcc: fix channel calculation in get_pcc_channel()

2016-02-01 Thread Jassi Brar
On Mon, Feb 1, 2016 at 8:49 PM, Alexey Klimov wrote: > (adding Rafael and linux-acpi) > > On Fri, Jan 15, 2016 at 6:22 PM, Ashwin Chaugule > wrote: >> + Jassi (Linaro addr) >> >> On 15 January 2016 at 13:20, Ashwin Chaugule >> wrote: >>> Jassi, >>> >>> On 10 December 2015 at 13:19, Ashwin Chau

Re: [PATCH v5 1/4] dt-bindings: mailbox: Document Hi6220 mailbox driver

2016-02-01 Thread Jassi Brar
On Mon, Feb 1, 2016 at 8:53 PM, Leo Yan wrote: > Hi Rob, > > Thanks for reviewing, please see below inline comments. > > On Mon, Feb 01, 2016 at 08:08:28AM -0600, Rob Herring wrote: >> On Mon, Feb 01, 2016 at 09:34:44PM +0800, Leo Yan wrote: >> > Document DT binding for Hisilicon Hi6220 mailbox dr

Re: [PATCH v4 1/3] mailbox: Add support for APM X-Gene platform mailbox driver

2016-02-01 Thread Jassi Brar
On Tue, Feb 2, 2016 at 1:08 AM, Duc Dang wrote: > Hi Jassi, > > On Fri, Jan 15, 2016 at 6:57 PM, Duc Dang wrote: >> X-Gene mailbox controller provides 8 mailbox channels, with >> each channel has a dedicated interrupt line. > > Did you have a chance to look into this version 4 of my mail-box patc

Re: [PATCH] mailbox: pcc: fix channel calculation in get_pcc_channel()

2016-02-02 Thread Jassi Brar
On Tue, Feb 2, 2016 at 2:21 AM, Rafael J. Wysocki wrote: > On Mon, Feb 1, 2016 at 4:43 PM, Jassi Brar wrote: >> On Mon, Feb 1, 2016 at 8:49 PM, Alexey Klimov wrote: >>> (adding Rafael and linux-acpi) >>> >>> On Fri, Jan 15, 2016 at 6:22 PM, Ashwin Chaugule &

[GIT PULL] Mailbox fixes for -rc3

2016-02-07 Thread Jassi Brar
Hi Linus, The following changes since commit 34229b277480f46c1e9a19f027f30b074512e68b: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net (2016-02-01 15:56:08 -0800) are available in the git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.git mailbo

Re: [PATCH 1/4] mailbox: mailbox-test: Use more consistent format for calling copy_from_user()

2016-01-27 Thread Jassi Brar
On Thu, Jan 14, 2016 at 12:41 PM, Lee Jones wrote: > While we're at it, ensure copy-to location is NULL'ed in the error path. > > Suggested-by: Dan Carpenter > Signed-off-by: Lee Jones > --- > drivers/mailbox/mailbox-test.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --

Re: [PATCH] firmware: arm_scmi: fix timeout value for send_message

2020-06-10 Thread Jassi Brar
On Wed, Jun 10, 2020 at 3:23 AM Sudeep Holla wrote: > > On Sun, Jun 07, 2020 at 02:30:23PM -0500, jassisinghb...@gmail.com wrote: > > From: Jassi Brar > > > > Currently scmi_do_xfer() submits a message to mailbox api and waits > > for an apparently very short tim

Re: [PATCH] firmware: arm_scmi: fix timeout value for send_message

2020-06-10 Thread Jassi Brar
On Wed, Jun 10, 2020 at 10:56 AM Sudeep Holla wrote: [I admit you can write bigger posts than me, so I am not going to write a passionate response to each of your paragraphs. Let's keep it to the point.] > > > > if (xfer->hdr.poll_completion) { > > > > - ktime_t stop = ktime_ad

[GIT PULL] Mailbox changes for v5.8

2020-06-10 Thread Jassi Brar
Hi Linus, The following changes since commit ffeb595d84811dde16a28b33d8a7cf26d51d51b3: Merge tag 'powerpc-5.7-6' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux (2020-05-30 12:28:44 -0700) are available in the Git repository at: git://git.linaro.org/landing-teams/working/fuji

Re: [PATCH] firmware: arm_scmi: fix timeout value for send_message

2020-06-11 Thread Jassi Brar
On Thu, Jun 11, 2020 at 3:40 AM Sudeep Holla wrote: > > > > > > > > if (xfer->hdr.poll_completion) { > > > > > > - ktime_t stop = ktime_add_ns(ktime_get(), > > > > > > SCMI_MAX_POLL_TO_NS); > > > > > > + ktime_t stop = ktime_add_ns(ktime_get(), 500 * 1000 * > > > >

Re: [GIT PULL] Mailbox changes for v5.8

2020-06-11 Thread Jassi Brar
On Thu, Jun 11, 2020 at 11:56 AM Rob Herring wrote: > > On Wed, Jun 10, 2020 at 11:10:56PM -0500, Jassi Brar wrote: > > > > Sivaprakash Murugesan (3): > > dt-bindings: mailbox: Add YAML schemas for QCOM APCS global block > > mailbox: qcom: Add clo

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-11 Thread Jassi Brar
On Thu, Jun 11, 2020 at 5:00 AM Sudeep Holla wrote: > > > > > Interesting logs ! The time taken to complete _successful_ requests > > > are arguably better in bad_trace ... there are many <10usec responses > > > in bad_trace, while the fastest response in good_trace is 53usec. > > > > Indeed th

Re: [PATCH 0/7] Add initial Keem Bay SoC / Board support

2020-07-07 Thread Jassi Brar
On Tue, Jul 7, 2020 at 4:18 PM Daniele Alessandrelli wrote: > Just one question: should I remove the mailbox and scmi nodes from the > soc DT or can I keep them there even if the mailbox driver is not > available yet? > A device node can not be merged before its dt-bindings are.

Re: [PATCH 4/4] mailbox: arm_mhu: Add ARM MHU doorbell driver

2020-10-02 Thread Jassi Brar
On Mon, Sep 28, 2020 at 6:45 AM Sudeep Holla wrote: > + > +static void mhu_db_shutdown(struct mbox_chan *chan) > +{ > + struct mhu_db_channel *chan_info = chan->con_priv; > + struct mbox_controller *mbox = &chan_info->mhu->mbox; > + int i; > + > + for (i = 0; i < mbox->num

Re: [PATCH 0/4] Mediatek DRM driver detect CMDQ execution timeout by vblank IRQ

2020-10-02 Thread Jassi Brar
On Sun, Sep 27, 2020 at 6:04 PM Chun-Kuang Hu wrote: > > CMDQ helper provide timer to detect execution timeout, but DRM driver > could have a better way to detect execution timeout by vblank IRQ. > For DRM, CMDQ command should execute in vblank, so if it fail to > execute in next 2 vblank, timeout

Re: [PATCH 4/4] mailbox: arm_mhu: Add ARM MHU doorbell driver

2020-10-07 Thread Jassi Brar
On Wed, Oct 7, 2020 at 6:40 AM Sudeep Holla wrote: > > On Fri, Oct 02, 2020 at 02:42:37PM -0500, Jassi Brar wrote: > > On Mon, Sep 28, 2020 at 6:45 AM Sudeep Holla wrote: > > > > > + > > > +static void mhu_db_shutdown(struct mbox_chan *chan) > >

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-05-28 Thread Jassi Brar
On Thu, May 28, 2020 at 2:20 PM Rob Herring wrote: > > On Fri, May 15, 2020 at 10:47:38AM +0530, Viresh Kumar wrote: > > From: Sudeep Holla > > > > Hi Rob, Arnd and Jassi, > > > > This stuff has been doing rounds on the mailing list since several years > > now with no agreed conclusion by all the

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-03 Thread Jassi Brar
On Wed, Jun 3, 2020 at 1:04 PM Sudeep Holla wrote: > > On Fri, May 29, 2020 at 09:37:58AM +0530, Viresh Kumar wrote: > > On 28-05-20, 13:20, Rob Herring wrote: > > > Whether Linux > > > requires serializing mailbox accesses is a separate issue. On that side, > > > it seems silly to not allow drivi

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-03 Thread Jassi Brar
On Wed, Jun 3, 2020 at 1:31 PM Sudeep Holla wrote: > > > > > > H/W is actually fine :) Its just that the driver is written to > > _also_ support a platform (my original) that doesn't have shmem and > > need to pass data via 32bit registers. > > Frankly, I am not against the doorbell mode, I am a

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-04 Thread Jassi Brar
On Thu, Jun 4, 2020 at 4:20 AM Sudeep Holla wrote: > > On Wed, Jun 03, 2020 at 01:32:42PM -0500, Jassi Brar wrote: > > On Wed, Jun 3, 2020 at 1:04 PM Sudeep Holla wrote: > > > > > > On Fri, May 29, 2020 at 09:37:58AM +0530, Viresh Kumar wrote: > > >

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-04 Thread Jassi Brar
On Thu, Jun 4, 2020 at 11:56 PM Sudeep Holla wrote: > > > >> bash-1526 [000] 1149.472553: scmi_xfer_begin: > > >> transfer_id=1538 msg_id=6 protocol_id=21 seq=0 poll=0 > > >> -0 [001] 1149.472733: scmi_xfer_begin: > > >> transfer_id=1539 msg_id=7 protocol_id=19 seq=1 p

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-05 Thread Jassi Brar
On Fri, Jun 5, 2020 at 3:58 AM Sudeep Holla wrote: > > > > > >> bash-1526 [000] 1149.472553: scmi_xfer_begin: > > > > >> transfer_id=1538 msg_id=6 protocol_id=21 seq=0 poll=0 > > > > >> -0 [001] 1149.472733: scmi_xfer_begin: > > > > >> transfer_id=1539 msg_id=7 protocol

Re: [PATCH v4 2/2] mailbox: sprd: Add Spreadtrum mailbox driver

2020-05-21 Thread Jassi Brar
On Thu, May 21, 2020 at 7:24 AM Baolin Wang wrote: > > Hi Jassi, > > On Wed, May 13, 2020 at 2:32 PM Baolin Wang wrote: > > > > On Wed, May 13, 2020 at 2:05 PM Jassi Brar wrote: > > > > > > On Tue, May 12, 2020 at 11:14 PM Baolin Wang > > >

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-05-15 Thread Jassi Brar
On Fri, May 15, 2020 at 12:17 AM Viresh Kumar wrote: > > - The hardware gives us the capability to write the register in > parallel, i.e. we can write 0x800 and 0x400 together without any > software locks, and so these 32 bits should be considered as separate > channel even if only one inter

Re: [PATCH V2 3/3] mailbox: qcom: Add ipq6018 apcs compatible

2020-06-07 Thread Jassi Brar
On Sat, Jun 6, 2020 at 5:59 AM Sivaprakash Murugesan wrote: > > The Qualcomm ipq6018 has apcs block, add compatible for the same. > Also, the apcs provides a clock controller functionality similar > to msm8916 but the clock driver is different. > > Create a child platform device based on the apcs

Re: [PATCH] mailbox: cancel timer before starting it

2020-10-15 Thread Jassi Brar
On Thu, Oct 15, 2020 at 8:58 AM Jerome Brunet wrote: > > > On Thu 15 Oct 2020 at 15:46, Ionela Voinescu wrote: > > > Hi guys, > > > > On Wednesday 23 Sep 2020 at 14:39:16 (+0200), Jerome Brunet wrote: > >> If the txdone is done by polling, it is possible for msg_submit() to start > >> the timer w

Re: [PATCH] mailbox: cancel timer before starting it

2020-10-16 Thread Jassi Brar
On Fri, Oct 16, 2020 at 4:00 AM Jerome Brunet wrote: > > > On Fri 16 Oct 2020 at 10:52, Ionela Voinescu wrote: > > > On Thursday 15 Oct 2020 at 13:45:54 (-0500), Jassi Brar wrote: > > [..] > >> > >> --- a/drivers/mailbox/mailbox.c > >> >

Re: [PATCH] mailbox: avoid timer start from callback

2020-10-16 Thread Jassi Brar
On Fri, Oct 16, 2020 at 12:50 PM Sudeep Holla wrote: > > On Fri, Oct 16, 2020 at 12:30:20PM -0500, jassisinghb...@gmail.com wrote: > > From: Jassi Brar > > > > If the txdone is done by polling, it is possible for msg_submit() to start > > the timer while txdone_hrt

Re: [PATCH] mailbox: avoid timer start from callback

2020-10-16 Thread Jassi Brar
On Fri, Oct 16, 2020 at 1:38 PM Jerome Brunet wrote: > > > On Fri 16 Oct 2020 at 19:30, jassisinghb...@gmail.com wrote: > > > From: Jassi Brar > > > > If the txdone is done by polling, it is possible for msg_submit() to start > > the timer while txdone_hrtimer

Re: [PATCH] mailbox: cancel timer before starting it

2020-10-16 Thread Jassi Brar
On Fri, Oct 16, 2020 at 1:54 PM Jerome Brunet wrote: > > > On Fri 16 Oct 2020 at 19:33, Jassi Brar wrote: > > > On Fri, Oct 16, 2020 at 4:00 AM Jerome Brunet wrote: > >> > >> > >> On Fri 16 Oct 2020 at 10:52, Ionela Voinescu > >> wrote:

[GIT PULL] Mailbox changes for v5.10

2020-10-18 Thread Jassi Brar
platform_get_irq error handling - bcm: convert tasklets to use new tasklet_setup api - core: fix race cause by hrtimer starting inappropriately Allen Pais (1): mailbox: bcm: convert tasklets to use new tasklet_setup() API Jassi Brar (1

Re: [PATCH] mailbox: arm_mhuv2: Add driver

2020-11-12 Thread Jassi Brar
On Wed, Nov 11, 2020 at 12:02 AM Viresh Kumar wrote: > > On 27-10-20, 17:23, Viresh Kumar wrote: > > This adds driver for the ARM MHUv2 (Message Handling Unit) mailbox > > controller. > > > > This is based on the accepted DT bindings of the controller and supports > > combination of all transport

Re: [PATCH 0/7] Add initial Keem Bay SoC / Board support

2020-07-05 Thread Jassi Brar
On Tue, Jun 16, 2020 at 10:56 AM Daniele Alessandrelli wrote: > > Hi, > > This patch-set adds initial support for a new Intel Movidius SoC code-named > Keem Bay. The SoC couples an ARM Cortex A53 CPU with an Intel Movidius VPU. > > This initial patch-set enables only the minimal set of components

Re: [PATCH 23/32] usb: gadget: udc: max3420_udc: Remove set, but never checked variable 'addr'

2020-07-06 Thread Jassi Brar
1); > + spi_rd8_ack(udc, MAX3420_REG_FNADDR, 1); > dev_dbg(udc->dev, "Assigned Address=%d\n", udc->setup.wValue); > return; > case USB_REQ_CLEAR_FEATURE: Acked-by: Jassi Brar

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-09-08 Thread Jassi Brar
On Tue, Sep 8, 2020 at 4:15 AM Arnd Bergmann wrote: > > Picking up the old thread again after and getting pinged by multiple > colleagues about it (thanks!) reading through the history. > > On Fri, Jun 12, 2020 at 7:29 AM Viresh Kumar wrote: > > > > On 11-06-20, 19:34,

Re: [PATCH V3 1/2] dt-bindings: mailbox : arm,mhu: Convert to Json-schema

2020-09-15 Thread Jassi Brar
4 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml > > @@ -0,0 +1,86 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/mailbox/arm,mhu.yaml# > > +$schema: http://device

Re: [PATCH 0/6] mailbox: arm_mhu: add support to use in doorbell mode

2019-06-05 Thread Jassi Brar
On Wed, Jun 5, 2019 at 2:46 PM Mark Brown wrote: > > On Tue, Jun 04, 2019 at 10:44:24AM +0100, Sudeep Holla wrote: > > On Mon, Jun 03, 2019 at 08:39:46PM +0100, Mark Brown wrote: > > > > > > It feels like the issues with sharing access to the hardware and with the > > > API for talking to doorbell

Re: [PATCH V2 1/2] DT: mailbox: add binding doc for the ARM SMC mailbox

2019-06-20 Thread Jassi Brar
On Thu, Jun 20, 2019 at 11:13 AM Andre Przywara wrote: > > On Thu, 20 Jun 2019 10:22:41 +0100 > Sudeep Holla wrote: > > > On Mon, Jun 03, 2019 at 04:30:04PM +0800, peng@nxp.com wrote: > > > From: Peng Fan > > > > > > The ARM SMC mailbox binding describes a firmware interface to trigger > > >

Re: [PATCH V2 2/2] mailbox: introduce ARM SMC based mailbox

2019-06-20 Thread Jassi Brar
On Mon, Jun 3, 2019 at 3:28 AM wrote: > > From: Peng Fan > > This mailbox driver implements a mailbox which signals transmitted data > via an ARM smc (secure monitor call) instruction. The mailbox receiver > is implemented in firmware and can synchronously return data when it > returns execution

Re: [PATCH 0/6] mailbox: arm_mhu: add support to use in doorbell mode

2019-05-31 Thread Jassi Brar
Hi Sudeep, On Fri, May 31, 2019 at 9:33 AM Sudeep Holla wrote: > > This is my another attempt to extend mailbox framework to support > doorbell mode mailbox hardware. It also adds doorbell support to ARM > MHU driver. > Nothing has really changed since the last time we discussed many months ago.

Re: [PATCH 1/6] mailbox: add support for doorbell/signal mode controllers

2019-06-03 Thread Jassi Brar
On Fri, May 31, 2019 at 9:33 AM Sudeep Holla wrote: > diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c > index 38d9df3fb199..e26a079f8223 100644 > --- a/drivers/mailbox/mailbox.c > +++ b/drivers/mailbox/mailbox.c > @@ -77,7 +77,10 @@ static void msg_submit(struct mbox_chan *chan

Re: [PATCH v4 2/2] mailbox: sprd: Add Spreadtrum mailbox driver

2020-05-06 Thread Jassi Brar
On Wed, May 6, 2020 at 8:29 AM Baolin Wang wrote: > > Hi Jassi, > > On Tue, Apr 28, 2020 at 11:10 AM Baolin Wang wrote: > > > > From: Baolin Wang > > > > The Spreadtrum mailbox controller supports 8 channels to communicate > > with MCUs, and it contains 2 different parts: inbox and outbox, which

Re: [PATCH v4 2/2] mailbox: sprd: Add Spreadtrum mailbox driver

2020-05-12 Thread Jassi Brar
On Tue, May 12, 2020 at 11:14 PM Baolin Wang wrote: > > Hi Jassi, > > On Thu, May 7, 2020 at 11:23 AM Baolin Wang wrote: > > > > Hi Jassi, > > > > On Thu, May 7, 2020 at 7:25 AM Jassi Brar wrote: > > > > > > On Wed, May 6, 2020 a

Re: [PATCH 1/3] mailbox: always wait in mbox_send_message for blocking Tx mode

2017-03-28 Thread Jassi Brar
o the > caller without waiting in mbox_send_message even when it's blocking Tx. > > This patch fixes the issue by waiting for the completion always if Tx > is in blocking mode. > > Fixes: 2b6d83e2b8b7 ("mailbox: Introduce framework for mailbox") > Cc: Jassi Brar >

Re: [PATCH v7 0/3] Broadcom FlexRM ring manager support

2017-03-28 Thread Jassi Brar
On Wed, Mar 29, 2017 at 11:00 AM, Anup Patel wrote: > The Broadcom FlexRM ring manager provides producer-consumer style > ring interface for offload engines on Broadcom iProc SoCs. We can > have one or more instances of Broadcom FlexRM ring manager in a SoC. > > This patchset adds a mailbox driver

[PATCH] mailbox: fix completion order for blocking requests

2017-03-29 Thread Jassi Brar
res to each queued request, so that the threads could wait on their own completions. Reported-by: Alexey Klimov Signed-off-by: Jassi Brar --- drivers/mailbox/mailbox.c | 15 +++ drivers/mailbox/omap-mailbox.c | 2 +- drivers/mailbox/pcc.c | 2 +- include/li

Re: [PATCH 1/3] mailbox: always wait in mbox_send_message for blocking Tx mode

2017-03-29 Thread Jassi Brar
On Wed, Mar 29, 2017 at 5:04 PM, Sudeep Holla wrote: > > On 28/03/17 19:20, Jassi Brar wrote: >> Hi Sudeep, >> >> On Tue, Mar 21, 2017 at 5:00 PM, Sudeep Holla wrote: >>> There exists a race when msg_submit return immediately as there was an >>> act

Re: [PATCH] mailbox: fix completion order for blocking requests

2017-04-06 Thread Jassi Brar
On 6 April 2017 at 22:28, Alexey Klimov wrote: > Hi Jassi/Sudeep, > > On Wed, Mar 29, 2017 at 07:01:09PM +0100, Sudeep Holla wrote: >> >> >> On 29/03/17 18:43, Jassi Brar wrote: ... >> > diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.

Re: [PATCH RFC] mailbox: move controller timer to per-channel timers

2017-04-07 Thread Jassi Brar
On Thu, Apr 6, 2017 at 11:01 PM, Alexey Klimov wrote: > When mailbox controller provides two or more channels and > they are actively used by mailbox client(s) it's very easy > to trigger the warning in hrtimer_forward(): > > [ 247.853060] WARNING: CPU: 6 PID: 0 at kernel/time/hrtimer.c:805 > hr

Re: [PATCH RFC] mailbox: move controller timer to per-channel timers

2017-04-11 Thread Jassi Brar
On 11 April 2017 at 18:04, Alexey Klimov wrote: > On Fri, Apr 07, 2017 at 08:39:35PM +0530, Jassi Brar wrote: >> On Thu, Apr 6, 2017 at 11:01 PM, Alexey Klimov wrote: >> > When mailbox controller provides two or more channels and >> > they are actively used by mailb

Re: [PATCH] mailbox: fix completion order for blocking requests

2017-04-23 Thread Jassi Brar
On Tue, Apr 11, 2017 at 6:15 PM, Alexey Klimov wrote: > On Thu, Apr 06, 2017 at 10:45:26PM +0530, Jassi Brar wrote: >> On 6 April 2017 at 22:28, Alexey Klimov wrote: >> > Hi Jassi/Sudeep, >> > >> > On Wed, Mar 29, 2017 at 07:01:09PM +0100, Sudeep Holla wrote:

Re: [PATCH 1/5] clk: mb86s7x: Suppress build

2017-06-28 Thread Jassi Brar
On 28 June 2017 at 21:43, Stephen Boyd wrote: > On 06/25, Andreas Färber wrote: >> It fails to build once we introduce the ARCH_MB86S7X Kconfig symbol: >> >> drivers/clk/clk-mb86s7x.c:27:10: fatal error: soc/mb86s7x/scb_mhu.h: No >> such file or directory >>#include >> ^~~~

<    1   2   3   4   5   6   >