On Tue, Jun 28, 2016 at 8:36 PM, Jassi Brar <jassisinghb...@gmail.com> wrote: > On Tue, Jun 28, 2016 at 7:30 PM, Neil Armstrong <narmstr...@baylibre.com> > wrote:
>> >> My main question is : do you really want to transform this simple driver into >> a dirty multi-bus generic mailbox driver ? >> The meson_mhu is only 199 lines and this patch adds 181 lines to the arm_mhu >> driver. >> >> I'll personally push to have two separate drivers here. >> > It is a shame if we need to copy a driver only due to changed register > offsets. Let me give it a shot and see how worse off we would be. > OK, so I trimmed the differences further but it still doesn't look any better. The best approach seems to be have a separate driver but with consideration that its a 3rd party IP and hence likely to be used by other platforms. That is, call it something meson-neutral. I will make a few comments on the patch post. Thanks
