>>> Jeff Garzik <[EMAIL PROTECTED]> 19.07.07 16:46 >>>
>Andi Kleen wrote:
>> From: "Jan Beulich" <[EMAIL PROTECTED]>
>> Consolidate the three 32-bit system call entry points so that they all
>> treat registers in similar ways.
>>
>>> Andi Kleen <[EMAIL PROTECTED]> 06.08.07 12:36 >>>
>On Monday 06 August 2007 12:15:01 Jan Beulich wrote:
>> But that is still wrong - you're again flushing the page table page rather
>> than
>> the data one. Fixing this was the purpose of
The 64-bit conditional seems wrong to me, I'd assume you mean
if (1 || !cpu_has_clflush)
Jan
>>> Andi Kleen <[EMAIL PROTECTED]> 09.08.07 14:41 >>>
It turns out CLFLUSH support is still not complete; we
flush the wrong pages. Again disable it for the re
>>> Muli Ben-Yehuda <[EMAIL PROTECTED]> 09.08.07 15:11 >>>
>On Thu, Aug 09, 2007 at 02:41:31PM +0200, Andi Kleen wrote:
>>
>> It turns out CLFLUSH support is still not complete; we
>> flush the wrong pages. Again disable it for the release.
>>
() fails.
The patch at once adjusts the code to account for the fact that
pnp_assign_dma() now doesn't need to report failure anymore.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Cc: Adam Belay <[EMAIL PROTECTED]>
drivers/pnp/manager.c | 28 ++--
1
The floppy driver is already written to be able to operate in virtual
DMA mode. Thus it can easily be adjusted to tolerate failure from
fd_request_dma() as long as virtual DMA mode is not disallowed.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
drivers/block/floppy.c | 14 +--
AUTO_DMA and FLOPPY_MOTOR_MASK in include/asm-*/floppy.h are dead
symbols - remove them.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
include/asm-alpha/floppy.h |2 --
include/asm-arm/floppy.h |2 --
include/asm-i386/floppy.h|4
include/asm-m68k/floppy.h
.. when dumping register state. This is particularly useful when gcc
managed to tail-call optimize an indirect call which happens to hit a
NULL (or otherwise invalid) pointer.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/i386/kernel/cpu/amd.c |4
arch/i386/kern
>>> Andi Kleen <[EMAIL PROTECTED]> 13.08.07 15:08 >>>
>On Mon, Aug 13, 2007 at 12:33:05PM +0100, Jan Beulich wrote:
>> +if (__get_cpu_var(ler_msr)) {
>> +u32 from, to, hi;
>> +
>> +
Various architectures may call bust_spinlocks() recursively (when calling die()
in
the context do an unresolved page fault); the function itself, however, doesn't
appear to be meant to be called in this manner. Nevertheless, this doesn't
appear to be a problem as long as bust_spinlocks(0) doesn't
I'll try to, but it may take some time. Jan
>>> Sam Ravnborg <[EMAIL PROTECTED]> 10/20/07 6:50 PM >>>
Jan - I assume you will look into this.
And thanks to David/Randy for narrowing this down.
Thanks,
Sam
On Fri, Oct 19, 2007 at 09:25:55PM -0700, Linus Torvalds wrote:
>
>
> On Fri, 1
Jeremy,
CONFIG_XEN (in 2.6.23) depends on X86_CMPXCHG and X86_TSC. This
precludes enabling the option in kernels using M386, M486, or M586, despite
the fact that the detection code doesn't need these features and if Xen is
present the features are implicitly there. At least the X86_TSC dependency
>>> Jeremy Fitzhardinge <[EMAIL PROTECTED]> 23.10.07 20:09 >>>
>Jan Beulich wrote:
>> Jeremy,
>>
>> CONFIG_XEN (in 2.6.23) depends on X86_CMPXCHG and X86_TSC. This
>> precludes enabling the option in kernels using M386, M486, or M586, despite
>
>>> Jeremy Fitzhardinge <[EMAIL PROTECTED]> 13.01.07 02:45 >>>
>Xen does not allow guests to have the kernel pmd shared between page
>tables, so parameterize pgtable.c to allow both modes of operation.
I don't think the change to vmalloc_sync_all in this patch is necessary -
the mechanism exists s
A patch was sent out to (hopefully) address this problem (or at least allow you
to
work around it), which had been reported for a similar machine before. The patch
is present in 2.6.20-rc5.
Jan
>>> Martin Bretschneider <[EMAIL PROTECTED]> 15.01.07 13:07 >>>
Hi,
it seems to me that the new hardw
Annotate i386/kernel/entry.S with END/ENDPROC to assist disassemblers and
other analysis tools.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.20-rc5/arch/i386/kernel/entry.S 2007-01-15 14:09:19.0
+0100
+++ 2.6.20-rc5-i386-entry-end/arch/i386/kernel/entry.S 2007
s specifically the case for all page
tables covering kernel space)
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.20-rc5/arch/i386/mm/fault.c 2007-01-15 14:09:19.0
+0100
+++ 2.6.20-rc5-i386-page-fault-dump/arch/i386/mm/fault.c2007-01-17
08:48:49.
swiotlb_dma_supported() when
io_tlb_end is exactly at the end of memory
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.20-rc3/arch/ia64/mm/init.c2007-01-02 16:04:52.0
+0100
+++ 2.6.20-rc3-swiotlb-bugs/arch/ia64/mm/init.c 2006-12-20 12:02:01.0
+0100
@@ -128,6 +
Convert all phys_to_virt/virt_to_phys uses to bus_to_virt/virt_to_bus, as
is what is meant and what is needed in (at least) some virtualized
environments like Xen.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Acked-by: Muli Ben-Yehuda <[EMAIL PROTECTED]>
Index: 2.6.20-rc3-swio
This patch
- adds proper __init decoration to swiotlb's init code (and the code calling
it, where not already the case)
- replaces uses of 'unsigned long' with dma_addr_t where appropriate
- does miscellaneous simplicfication and cleanup
Signed-off-by: Jan Beulich <[EMAIL
This patch adds abstraction so that the file can be used by environments other
than IA64 and EM64T, namely for Xen.
Even if this patch is considered too convoluted, I would appreciate if the
other three ones could still be considered for merging.
Signed-off-by: Jan Beulich <[EMAIL PROTEC
This patch adds missing exports to allow several drivers to be built as
module with CONFIG_IA64_HP_ZX1_SWIOTLB.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.20-rc3/arch/ia64/hp/common/hwsw_iommu.c 2006-11-29
22:57:37.0 +0100
+++ 2.6.20-rc3-ia64-zx1-swiotlb/arch/i
having a respective RNG).
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.20-rc3/drivers/char/hw_random/intel-rng.c 2006-11-29
22:57:37.0 +0100
+++ 2.6.20-rc3-intel-rng-skip-fhw-detect/drivers/char/hw_random/intel-rng.c
2006-11-29 09:09:21.0 +0100
@@
Don't force CONFIG_SWIOTLB on when not actually needed (i.e. HP_ZX1 and
SGI_SN2).
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.20-rc3/arch/ia64/Kconfig 2007-01-02 15:41:38.0 +0100
+++ 2.6.20-rc3-ia64-swiotlb-opt/arch/ia64/Kconfig 2006-12-22
16:44:5
A change early last year reordered struct page so that ptl overlaps not only
private, but also mapping. Since spinlock_t can be much larger, I'm wondering
whether there's a reason to not also overlay the space index and lru take -
are these used for anything on page table pages?
Thanks, Jan
-
To u
>>> Andi Kleen <[EMAIL PROTECTED]> 06.02.07 08:53 >>>
>On Monday 05 February 2007 23:50, Siddha, Suresh B wrote:
>> On Mon, Feb 05, 2007 at 06:19:59PM +0100, Andreas Herrmann wrote:
>> > o added check to restrict base address to 36 bit on i386
>>
>> Why is this? It can go upto implemented physical
>Shouldn't be applied without further analysis.
I don't think further analysis is required before this change be done, the
missing
conversion is rather obvious when comparing to all other functions in that file.
Whether the observed crashes really origin from the missing bits here is a
different
>> I don't think I remember a restriction here, at least not below 44 bits
>> (that's where pfn-s would need to become 64-bit wide).
>
>The i386 mm code only supports 4 entries in the PGD, so more than 36bit cannot
>be mapped right now.
That has nothing to do with the number of physical address b
On Wed, Feb 07, 2007 at 09:32:54AM +0100, Christoph Hellwig wrote:
> On Wed, Feb 07, 2007 at 07:59:18AM +, Linux Kernel Mailing List wrote:
> > [IA64] swiotlb abstraction (e.g. for Xen)
> >
> > Add abstraction so that the file can be used by environments other than
> > IA64
> >
>> > If Jan actually had a goal with that except making the code utterly
>> > unreadable he should try again with small patches that are well
>> > explained and do one thing at a at time. (And cane be reviewed an
>> > improved on if needed.
>>
>> As the topic says - the goal is to support Xen.
>
>>> Andi Kleen <[EMAIL PROTECTED]> 10.02.07 12:50 >>>
>
>From: Jeff Dike <[EMAIL PROTECTED]>
>
>Kernel-mode traps on x86_64 can pollute the trap information for a previous
>userspace trap for which the signal has not yet been delivered to the
>process.
>
>do_trap and do_general_protection set task-
>>> Andi Kleen <[EMAIL PROTECTED]> 10.02.07 12:50 >>>
>
>From: "Bryan O'Sullivan" <[EMAIL PROTECTED]>
>
>This copy routine is memcpy-compatible, but on some architectures will use
>cache-bypassing loads to avoid bringing the source data into the cache.
>
>One case where this is useful is when a dev
that makes things work
again.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.20/arch/i386/kernel/sysenter.c2007-02-04 19:44:54.0
+0100
+++ 2.6.20/arch/i386/kernel/sysenter.c 2007-02-12 16:01:29.0 +0100
@@ -77,7 +77,7 @@ int __init sysenter_setup(void)
>Yup. How does this patch look to you? We set error_code and trap_no
>for userspace faults and kernel faults which call die(). We don't set
>them for kernelspace faults which are fixed up.
That seems a reasonable approach.
Thanks, Jan
-
To unsubscribe from this list: send the line "unsubscribe
>>> Christoph Hellwig <[EMAIL PROTECTED]> 12.02.07 18:12 >>>
>On Mon, Feb 12, 2007 at 07:30:55AM +, Jan Beulich wrote:
>>
>> As the topic says - the goal is to support Xen. But yes, I was afraid
>> someone would
>> claim this make the code
>Yup. How does this patch look to you? We set error_code and trap_no
>for userspace faults and kernel faults which call die(). We don't set
>them for kernelspace faults which are fixed up.
Actually, after a second round of thinking I believe there's still more to do
- your second patch missed f
in
actually in high memory (which is specifically the case for all page
tables covering kernel space)
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.20/arch/i386/mm/fault.c 2007-02-04 19:44:54.0 +0100
+++ 2.6.20-i386-page-fault-dump/arch/i386/mm/fault.c
Use mask_ack_irq() where possible.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.20/kernel/irq/chip.c 2007-02-04 19:44:54.0 +0100
+++ 2.6.20-irq-mask-ack/kernel/irq/chip.c 2007-02-09 10:17:26.0
+0100
@@ -534,10 +534,8 @@ __set_irq_handler(unsign
Whether a region is below 1Mb is determined by its start rather than
its end.
This hunk got erroneously dropped from a previous patch.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.20/arch/i386/kernel/cpu/mtrr/generic.c2007-02-04
19:44:54.0 +0100
+++ 2.6.20-x8
ions, save/restore interrupts rather than disabling/
enabling them.
On x86-64, eliminate one function used here by folding it into its
single caller, convert to static, and rename for consistency with i386
(lkcd may like this).
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.20/
Move inclusion of asm/fixmap.h to where it is really used rather than
where it may have been used long ago (requires a few other adjustments
to includes due to previous implicit dependencies).
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.20/arch/x86_64/kernel/genapic.c 2
>>> Jeremy Fitzhardinge <[EMAIL PROTECTED]> 14.02.07 02:36 >>>
>Dan Hecht wrote:
>> Why doesn't Xen allocate the shared_info page from the pseudo-physical
>> space? Doesn't it already have to steal pages from the
>> pseudo-physical space for e.g. initial page tables, console, etc? Why
>> not do t
>>> @@ -528,7 +532,7 @@ ENTRY(_stext)
>>> /*
>>> * BSS section
>>> */
>>> -.section ".bss.page_aligned","w"
>>> +.section ".bss.page_aligned"
>>>
>>
>> Why?
>>
>
>I got complaints about section attribute mismatches without it.
Then perhaps ... "aw" is meant?
>>> +fastcall unsigned l
o also get updated if possible.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.20/drivers/pci/probe.c2007-02-04 19:44:54.0 +0100
+++ 2.6.20-pci-ide-legacy/drivers/pci/probe.c 2007-02-14 15:54:58.0
+0100
@@ -639,7 +639,29 @@ static void pci_read_ir
>>> Alan <[EMAIL PROTECTED]> 14.02.07 16:40 >>>
>On Wed, 14 Feb 2007 15:05:24 +
>"Jan Beulich" <[EMAIL PROTECTED]> wrote:
>
>> The change to force legacy mode IDE channels' resources to fixed
>> non-zero values confuses (a
>>> Jeff Dike <[EMAIL PROTECTED]> 14.02.07 18:51 >>>
>On Tue, Feb 13, 2007 at 07:52:54AM +, Jan Beulich wrote:
>> Actually, after a second round of thinking I believe there's still more to do
>> - your second patch missed fixing i386's do_trap()
o also get updated if possible.
(The only change to the original version is an added comment.)
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.20/drivers/pci/probe.c2007-02-04 19:44:54.0 +0100
+++ 2.6.20-pci-ide-legacy/drivers/pci/probe.c 2007-02-15 08:54:58.
Jeremy,
is there a particular reason for this?
Thanks, Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
lookup on PAE.)
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.20/arch/i386/mm/fault.c 2007-02-04 19:44:54.0 +0100
+++ 2.6.20-i386-page-fault-dump/arch/i386/mm/fault.c2007-02-14
08:31:38.0 +0100
@@ -20,6 +20,7 @@
#include
#include /* For unblank_sc
>>> Chuck Ebbert <[EMAIL PROTECTED]> 18.02.07 22:33 >>>
>Jan Beulich wrote:
>> Whether a region is below 1Mb is determined by its start rather than
>> its end.
>>
>> This hunk got erroneously dropped from a previous patch.
>>
>>
>Would it be possible to add printks for the EIOs? We want to know
>when dwarf2 is corrupted.
Here's a patch to do this and some more (applies on firstfloor tree, but
probably not on plain 2.6.19).
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.19-ff/kernel/unw
ain
2.6.19).
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Index: 2.6.19-ff-unwind-debug-msg/kernel/unwind.c
===
--- 2.6.19-ff-unwind-debug-msg.orig/kernel/unwind.c 2006-12-04
17:11:14.0 +0100
+++ 2.6.19-ff-unwind-
The .eh_frame section contents is never written to, so it can as well
benefit from CONFIG_DEBUG_RODATA.
Diff-ed against firstfloor tree.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Index: 2.6.19-ff-unwind-debug-msg/arch/i386/kernel/vmlinux
Kallsyms data is never written to, so it can as well benefit from
CONFIG_DEBUG_RODATA.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.19/kernel/kallsyms.c 2006-11-29 22:57:37.0 +0100
+++ 2.6.19-kallsyms-rodata/kernel/kallsyms.c2006-12-04 15:20:16.0
>>> Randy Dunlap <[EMAIL PROTECTED]> 04.12.06 23:58 >>>
>On Mon, 04 Dec 2006 16:23:27 + Jan Beulich wrote:
>
>> Now that binutils' ld is able to properly populate .eh_frame_hdr in the
>> Linux kernel case, here's a patch to add some functio
>>> Jan Engelhardt <[EMAIL PROTECTED]> 05.12.06 20:52 >>>
>
Now that binutils' ld is able to properly populate .eh_frame_hdr in the
Linux kernel case, here's a patch to add some functionality to the Dwarf2
unwinder to actually be able to make use of this (applies on firstfloor
t
s the formerly file-scope static variable rtc_int_handler_ptr into the
only function using it, and makes it automatic.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.19/drivers/char/rtc.c 2006-12-08 13:03:35.0 +0100
+++ 2.6.19-rtc-cleanup/drivers/char/rtc.c 2006-
Ensure RTC driver doesn't use its timer when it doesn't get to set it up (as
it cannot currently prevent other of its functions to be called from outside
when not built as a module - probably this should also be addressed).
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linu
s the formerly file-scope static variable rtc_int_handler_ptr into the
only function using it, and makes it automatic.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.19/drivers/char/rtc.c 2006-12-08 13:03:35.0 +0100
+++ 2.6.19-rtc-cleanup/drivers/char/rtc.c 2006-
>with the patch it boots perfectly without any command-line args.
Are you getting the 'Firmware space is locked read-only' message then?
Thanks, Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
>>> dean gaudet <[EMAIL PROTECTED]> 14.12.06 09:40 >>>
>On Thu, 14 Dec 2006, Jan Beulich wrote:
>
>> >with the patch it boots perfectly without any command-line args.
>>
>> Are you getting the 'Firmware space is locked read-only' messa
When I submitted a patch to replace __get_user() with probe_kernel_address(),
Andi told me he had done this conversion already. I had assumed that he had
included this in his final merge submission. As he hasn't I now have to conclude
that he has or will submit it for 2.6.20.
Also, there is extra
>>> Ingo Molnar <[EMAIL PROTECTED]> 15.12.06 12:24 >>>
>
>* Jan Beulich <[EMAIL PROTECTED]> wrote:
>
>> validating that the item read is between current and previous stack
>> pointer, which in turn are being derived from register state and
having a respective RNG).
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.20-rc4/drivers/char/hw_random/intel-rng.c 2006-11-29
22:57:37.0 +0100
+++ 2.6.20-rc4-intel-rng-skip-fhw-detect/drivers/char/hw_random/intel-rng.c
2007-01-08 10:51:06.0 +0100
@@
- make the page table contents printing PAE capable
- make sure the address stored in current->thread.cr2 is unmodified from
what was read from CR2
- don't call oops_may_print() multiple times, when one time suffices
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.20
Remove all parameters from this function that aren't really variable.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.20-rc4/arch/i386/mm/fault.c 2007-01-08 09:57:20.0
+0100
+++ 2.6.20-rc4-x86-simplify-notify_page_fault/arch/i386/mm/fault.c
2007-
>>> Andrew Morton <[EMAIL PROTECTED]> 09.01.07 23:04 >>>
>On Tue, 9 Jan 2007 12:01:21 +0100
>Andi Kleen <[EMAIL PROTECTED]> wrote:
>
>> On Tuesday 09 January 2007 03:55, Adrian Bunk wrote:
>> > RESTORE_CONTEXT lost a newline in
>> > commit 658fdbef66e5e9be79b457edc2cbbb3add840aa9:
>> > http://www.
Despite it being small, there should be the option of making it a
module...
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.19-rc5/drivers/char/hw_random/Kconfig 2006-09-20
05:42:06.0 +0200
+++ 2.6.19-rc5-modular-rng/drivers/char/hw_random/Kconfig 2006-11-
>>> Dave Jones <[EMAIL PROTECTED]> 24.11.06 21:27 >>>
>On Wed, Nov 22, 2006 at 08:53:08AM +0100, Jan Beulich wrote:
> > >It does appear to work w/out the patch. I've asked for a small bit
> > >of diagnostics (below), perhaps you've got some
This fixes a problem with gcc4 mis-compiling the stack unwind code under
-Os, which resulted in 'stuck' messages whenever an assembly routine was
encountered.
(The second hunk is trivial cleanup.)
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.19-rc6/kernel/unwind
>"mis-compiling" and "work around" are wrong words, the code had undefined
>behavior (there is no sequence point between evaluation of ptr and
>get_uleb128(&ptr, end) and ptr is modified twice, so the compiler can
>evaluate it e.g. as:
>temp = ptr;
>temp = temp + get_uleb128(&ptr, end);
>ptr = temp
>>> Dave Jones <[EMAIL PROTECTED]> 24.11.06 21:27 >>>
>On Wed, Nov 22, 2006 at 08:53:08AM +0100, Jan Beulich wrote:
> > >It does appear to work w/out the patch. I've asked for a small bit
> > >of diagnostics (below), perhaps you've got some
Use probe_kernel_address() instead of __get_user() in Dwarf2 unwinder.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.19-rc6/kernel/unwind.c2006-11-29 10:04:11.0 +0100
+++ 2.6.19-rc6-unwind-probe_kernel_address/kernel/unwind.c 2006-11-29
10:22:16.0
Tighten the requirements on both input to and output from the Dwarf2
unwinder.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--- linux-2.6.19-rc6/arch/i386/kernel/traps.c 2006-11-29 10:03:03.0
+0100
+++ 2.6.19-rc6-unwind-more-sanity-checks/arch/i386/kernel/traps.c
2006
>> while (unwind(info) == 0 && UNW_PC(info)) {
>> n++;
>> oad->ops->address(oad->data, UNW_PC(info));
>> if (arch_unw_user_mode(info))
>> break;
>> +if ((sp & ~(PAGE_SIZE - 1)) == (UNW_SP(info) & ~(PAGE_SIZE - 1))
>> +
>>> Andi Kleen <[EMAIL PROTECTED]> 29.11.06 14:15 >>>
>On Wednesday 29 November 2006 12:14, Jan Beulich wrote:
>> Use probe_kernel_address() instead of __get_user() in Dwarf2 unwinder.
>
>I had already done this here. Thanks.
I had checked firstfloor and on
The code to retrieve this information was (a) inside a CONFIG_VIDEO_SELECT
section and (b) protected by a check of a variable (vbe_version) that
would get initialized only when a VESA mode was selected on the command
line.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/i386/boot/v
>>> Andi Kleen <[EMAIL PROTECTED]> 20.06.07 12:23 >>>
>
>Kernel text is protected now so this won't work.
>
>We'll fix it better next time.
>
>Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
>
>---
> arch/i386/kernel/alternative.c |5 +
> 1 file changed, 5 insertions(+)
>
>Index: linux/arch/i3
This is the right way I think. With mtrr_bp_init being __init, get_mtrr_state
can then also be __init, making the other two changes unnecessary. I had
submitted a patch to that effect about a week ago. Beyond that patch, as
I now looked at this again, it would seem to me that print_fixed can then i
>vmlinux does not contain relocation entries which is
>used by the section mismatch checks.
>Reported by: Atsushi Nemoto <[EMAIL PROTECTED]>
>
>Use the individual objects as inputs to overcome
>this limitation.
>In modpost check the .o files and skip non-ELF files.
>
>Signed-off-by: Sam Ravnborg <[
Constrain __supported_pte_mask and NX handling to just the PAE kernel.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/i386/mm/init.c |7 ---
include/asm-i386/page.h |1 -
2 files changed, 4 insertions(+), 4 deletions(-)
--- linux-2.6.22-rc4/arch/i386/mm/init.c
.. which modpost started warning about.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
kernel/kthread.c |2 +-
mm/page_alloc.c | 18 +-
2 files changed, 10 insertions(+), 10 deletions(-)
--- linux-2.6.22-rc4/kernel/kthread.c 2007-06-11 18:09:47.0
Kill pte_rdprotect(), pte_exprotect(), pte_mkread(), pte_mkexec(), pte_read(),
pte_exec(), and pte_user() except where arch-specific code is making use of
them.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Cc: Andi Kleen <[EMAIL PROTECTED]>
Cc: Christoph Hellwig <[EMAIL PROTECTED
gcc puts data into .data.rel or .data.rel.* on some architectures (e.g.
ia64) or under certain conditions, so whatever is legal relative to
.data should also be legal for those other sections. Fixes a few
modpost warnings on ia64.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
scrip
Especially when !CONFIG_HOTPLUG_CPU, avoid needlessy allocating
resources for CPUs that can never become available.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
init/main.c | 42 +++---
1 files changed, 27 insertions(+), 15 deletions(-)
--- linux-
This symbol got orphaned quite a while ago.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
include/asm-i386/pgtable.h |2 +-
include/linux/mm.h |1 -
mm/memory.c|2 --
3 files changed, 1 insertion(+), 4 deletions(-)
--- linux-2.6.22-rc4/include/as
change_page_attr() failed to flush the caches for the affected pages
for quite a while, and on x86-64 only recently got a brute-force fix to
flush the entire TLB (which now gets reduced to just the affected pages
when possible).
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/i
alternatives.
Note that while I expect this to work properly on it own, it was only
tested together with the change_page_attr() patch submitted before,
which namely fixed the reference counting on split pages (which
affected earlier versions of this patch).
Signed-off-by: Jan Beulich <[EMAIL PROTEC
.. which modpost is warning about.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/i386/kernel/cpu/intel_cacheinfo.c|6 +++---
arch/i386/kernel/cpu/mcheck/therm_throt.c |2 +-
arch/i386/kernel/cpu/mtrr/generic.c |2 +-
arch/i386/kernel/cpu/mtrr/main.c
Hence remove its handling in the opposite case.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/i386/kernel/alternative.c | 14 +-
1 files changed, 9 insertions(+), 5 deletions(-)
--- linux-2.6.22-rc4/arch/i386/kernel/alternative.c 2007-06-11
18:09:52.0
.. and adjust documentation to properly reflect options that are
x86-64 specific.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Documentation/x86_64/boot-options.txt |6 --
arch/x86_64/kernel/mpparse.c |1 -
2 files changed, 7 deletions(-)
--- linux-2.6.
>> -static __init void kthreadd_setup(void)
>> +static noinline __init_refok void kthreadd_setup(void)
>> {
>> struct task_struct *tsk = current;
>
>This isn't ok. There isn't any __init function that is (safely) referenced
>by kthreadd_setup(), so we shouldn't really be marking it as such
>> The cacheinfo_cpu_notifier itself is called out from _cpu_down() which
>> is ... yep, *not* __cpuinit (and obviously *cannot* be so). _cpu_down()
>> is called from cpu_down() which is (thankfully!) protected inside
>> #ifdef CONFIG_HOTPLUG_CPU, so we've /just about/ escaped trouble
>> so far, bu
>> And from a purely theoretical
>> perspective I don't think such references should be considered bad -
>> .exit.* should be discarded together with .init.* if unloading is
>> impossible (built-in or configured off), not before module/kernel
>> initialization.
>
>Hmm, but that's not how things are
>>> Sam Ravnborg <[EMAIL PROTECTED]> 13.06.07 06:35 >>>
>>
>> Yup, we were only discussing possibility that modpost not complain
>> about .init -> .exit references that will never go oops (because the arch
>> guarantees that).
>
>And there are no good reasosns why the rules should be different for
>But then why not simply lose the __exit (and .exit.*) altogether? Because
>__exit becomes redundant in the suggested changed semantics -- just mark
>all the cleanup code as __init too (when it's built-in, the only
>callsite for the
>cleanup code would be from the startup code in .init.*, and when
Adam,
I'm having some difficulty understanding why failure to probe for a resource
(in the given case, a DMA channel, but the issue is perhaps more generic) must
always result in failure of the probing of the requesting device. In any case,
the driver is required to call request_dma(), and in many
>> void alternatives_smp_module_del(struct module *mod)
>> {
>> struct smp_alt_module *item;
>> -unsigned long flags;
>>
>> if (smp_alt_once || noreplace_smp)
>> return;
>>
>> -spin_lock_irqsave(&smp_alt, flags);
>> +spin_lock(&smp_alt);
>
>Unrelated change?
I like this approach much better, just one small note (I think I
had the same mistake in my changes initially):
>@@ -202,7 +209,7 @@ static void alternatives_smp_lock(u8 **s
> continue;
> if (*ptr > text_end)
> continue;
>- **p
>--- a/arch/i386/xen/time.c
>+++ b/arch/i386/xen/time.c
>@@ -105,17 +105,15 @@ static void get_runstate_snapshot(struct
> preempt_enable();
> }
>
>-static void setup_runstate_info(void)
>+static void setup_runstate_info(int cpu)
> {
> struct vcpu_register_runstate_memory_area area;
>
501 - 600 of 1374 matches
Mail list logo
