Short of getting a reply on the query why the argument of fls() here is
missing the decrement, here's a patch to add it (reducing the resulting
size when the incoming size is an exact power of two).
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Cc: James Bottomley <[EMAIL PROTEC
Remove the dead .text.lock. Move _etext and __{start,stop}___ex_table
into their sections.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
---
arch/x86/kernel/vmlinux_64.lds.S | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
--- linux-2.6.24-rc7/arch/x86/kernel/vmli
Use build target when creating compatibility link, and use $(boot)
where possible.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/x86/Makefile_32 |4 ++--
arch/x86/Makefile_64 |4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
--- linux-2.6.24-rc4/arch/x86/Makef
a way to make these entries visible via the
'mce=bootlog' command line option even on these machines.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/x86/kernel/cpu/mcheck/mce_64.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
--- linux-2.6
The patch introducing this left out x86-64, despite it also having
extra entries.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Cc: Olaf Hering <[EMAIL PROTECTED]>
include/asm-x86/system_64.h |6 ++
1 file changed, 6 insertions(+)
--- linux-2.6.24-rc4/include/asm-x86
m
the submitter of the first patch.
The issue is the writing of the 'checkbit' member at the end of
setup_intel_arch_watchdog(), which my patch made go to intel_arch_wd_ops
rather than wd_ops.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Cc: Stephane Eranian <[EMAIL PROTECTED]>
-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/x86/kernel/head_64.S |2 +-
arch/x86/mm/init_64.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.24-rc4/arch/x86/kernel/head_64.S 2007-12-10 16:11:18.0
+0100
+++ 2.6.24-rc4-x86_64-init-warning/ar
Two prior changes resulted in the "ecx" clobber being lost.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/x86/kernel/irq_32.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.24-rc4/arch/x86/kernel/irq_32.c 2007-12-07 09:00:59.0
+0100
+++
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/x86/kernel/head_32.S |2 +-
arch/x86/xen/setup.c |2 +-
arch/x86/xen/xen-head.S |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
--- linux-2.6.24-rc4/arch/x86/kernel/head_32.S 2007-12-07 09:00:59.0
This fixes an unused variable warning in mm/vmalloc.c.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
include/asm-ia64/tlbflush.h |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
--- linux-2.6.24-rc5/include/asm-ia64/tlbflush.h2007-12-12
12:27:38.0
Neither __cpu_down() nor __cpu_die() are being referenced without
CONFIG_HOTPLUG_CPU.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/ia64/kernel/smpboot.c | 11 ---
1 file changed, 11 deletions(-)
--- linux-2.6.24-rc5/arch/ia64/kernel/smpboot.c 2007-12-12 12:27:11.000
This requires making die() and die_if_kernel() return a value, and
their callers to honor this (and be prepared that it returns).
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/ia64/ia32/ia32_support.c |5 +++--
arch/ia64/kernel/traps.c
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
drivers/acpi/numa.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.24-rc5/drivers/acpi/numa.c2007-10-09 22:31:38.0
+0200
+++ 2.6.24-rc5-acpi-init-warning/drivers/acpi/numa.c2007-12-04
.. since it uses ILL_BADSTK (which is meaningless in the context of
SIGSEGV).
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/x86/kernel/traps_32.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.24-rc5/arch/x86/kernel/traps_32.c 2007-12-12 11:28:18.0
the option to be available when selecting M386, M486, or
M586.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Cc: Jeremy Fitzhardinge <[EMAIL PROTECTED]>
arch/x86/xen/Kconfig |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.24-rc5/arch/x86/xen/Kconfig
.. as it it used only during early boot.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/ia64/kernel/acpi.c |2 +-
arch/x86/kernel/acpi/boot.c |4 ++--
drivers/acpi/osl.c |3 ++-
3 files changed, 5 insertions(+), 4 deletions(-)
--- linux-2.6.24-rc5/arch/ia64/
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/x86/kernel/process_32.c |4 ++--
include/asm-x86/processor_32.h |2 --
2 files changed, 2 insertions(+), 4 deletions(-)
--- linux-2.6.24-rc5/arch/x86/kernel/process_32.c 2007-12-12
11:28:18.0 +0100
+++ 2.6.24-rc
ing for %r8d in cstar_tracesys
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Cc: Chuck Ebbert <[EMAIL PROTECTED]>
arch/x86/ia32/ia32entry.S | 24 +---
1 file changed, 9 insertions(+), 15 deletions(-)
--- linux-2.6.24-rc5/arch/x86/ia32/ia32entry.S 2007-12-1
rex64 prefix.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
include/asm-x86/pda.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.24-rc5/include/asm-x86/pda.h 2007-12-12 16:48:43.0
+0100
+++ 2.6.24-rc5-x86_64-unsigned-cpu/include/asm-x86
ation of a large page or missing the opportunity to do
so.
At the same time, make __PHYSICAL_MASK_SHIFT on 64-bits the value it
architecturally ought to have.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Cc: Andi Kleen <[EMAIL PROTECTED]>
arch/x86/mm/ioremap_64.c |
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/x86/Kconfig.cpu |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.24-rc5/arch/x86/Kconfig.cpu 2007-12-12 11:28:17.0
+0100
+++ 2.6.24-rc5-x86-cmov/arch/x86/Kconfig.cpu2007-12-04 16:11:19.0
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/x86/kernel/smp_32.c |1 -
arch/x86/kernel/smp_64.c |3 ---
2 files changed, 4 deletions(-)
--- linux-2.6.24-rc5/arch/x86/kernel/smp_32.c 2007-12-12 11:28:18.0
+0100
+++ 2.6.24-rc5-x86-flushtlb-exports/arch/x86/kernel/
The array is never written, and on 64-bits it's not even being used
past initial boot.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/x86/kernel/entry_32.S |2 +-
arch/x86/kernel/i8259_64.c |2 +-
include/asm-x86/hw_irq_32.h |2 +-
3 files changed, 3 inser
With CONFIG_PM, but without CONFIG_PM_SLEEP, the intention of the
conditional in ohci_pci_start() doesn't work since device_may_wakeup()
references pdev only with the latter config option.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
drivers/usb/host/ohci-pci.c |2 +-
1 files
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/x86/kernel/entry_64.S |4
arch/x86/kernel/traps_64.c |3 ---
2 files changed, 7 deletions(-)
--- linux-2.6.24-rc5/arch/x86/kernel/entry_64.S 2007-12-12 16:48:17.0
+0100
+++ 2.6.24-rc5-x86_64-dead-code/arch/x86/
This requires making die() return a value, making its callers honor
this (and be prepared that it may return), and making oops_end() have
two additional parameters.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/x86/kernel/cpu/mcheck/mce_64.c |8
arch/x86/kernel/trap
Neither __cpu_disable() nor __cpu_die() are being referenced without
CONFIG_HOTPLUG_CPU.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/x86/kernel/smpboot_32.c | 11 ---
arch/x86/kernel/smpboot_64.c | 12
2 files changed, 23 deletions(-)
--- linux-2.6.24-rc
.. allowing to remove their declarations from a global include file
(the symbols don't exist for anything but x86).
Likewise for 64-bits' fix_processor_context(), just that that one was
properly declared in an arch-specific header.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
check_timer() also was lacking that
attribute).
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/x86/kernel/apic_32.c|2 +-
arch/x86/kernel/apic_64.c|2 +-
arch/x86/kernel/io_apic_32.c |4 ++--
arch/x86/kernel/io_apic_64.c |6 +++---
arch/x86/kernel/smpboot_32.c |2 +-
The two files in question are unused without CONFIG_PM_SLEEP.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/x86/kernel/Makefile_64 |2 +-
arch/x86/power/Makefile |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.24-rc5/arch/x86/kernel/Makef
The change to mtrr_ap_init() depends on the previously submitted
Makefile change altering the condition for building of two files from
CONFIG_PM to CONFIG_PM_SLEEP (the latter implies CONFIG_HOTPLUG_CPU).
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/x86/kernel/cpu/mcheck/mce_64.c
James,
in a change over three years ago, you added implicit aligning to
__get_vm_area() for VM_IOREMAP requests. I wonder, though,
whether it was intentional to over-align requests of sizes that are
an exact power of two (and between PAGE_SIZE and
(1 << IOREMAP_MAX_ORDER)). I would think that the
>--- a/arch/x86/mm/fault_64.c
>+++ b/arch/x86/mm/fault_64.c
>@@ -158,22 +158,22 @@ void dump_pagetable(unsigned long addres
> pgd = __va((unsigned long)pgd & PHYSICAL_PAGE_MASK);
> pgd += pgd_index(address);
> if (bad_address(pgd)) goto bad;
>- printk("PGD %lx ", pgd_val(*pg
>>> Jeremy Fitzhardinge <[EMAIL PROTECTED]> 14.12.07 08:12 >>>
>Jan Beulich wrote:
>> When either calling change_page_attr() with the default attributes
>> pages in the direct mapping have and a page's attributes already were
>> set to the de
>>> Jeremy Fitzhardinge <[EMAIL PROTECTED]> 14.12.07 09:44 >>>
>Jan Beulich wrote:
>>> --- a/arch/x86/mm/fault_64.c
>>> +++ b/arch/x86/mm/fault_64.c
>>> @@ -158,22 +158,22 @@ void dump_pagetable(unsigned long addres
>>> pg
>>> Greg KH <[EMAIL PROTECTED]> 19.01.08 02:28 >>>
>On Fri, Jan 11, 2008 at 01:57:27AM -0700, Jan Beulich wrote:
>> The drivers picked just serve as examples (which I routinely build and
>> hence am able to easily verify), i.e. as before he patch doesn't
enforce
read-only section attributes at present, so only built-in files matter)
or where compiler warnings would result otherwise.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Cc: Tony Luck <[EMAIL PROTECTED]>
Cc: Ingo Molnar <[EMAIL PROTECTED]>
Cc: Jens Axboe <[EMAIL PROTEC
ere 'const' could have been
added as a result of the base structure changes, only where either the
change has a real effect (the module loader doesn't enforce read-only
section attributes at present, so only built-in files matter) or where
compiler warnings would result otherwise.
S
been added as a result of the base structure changes, only where the
change has a real effect (the module loader doesn't enforce read-only
section attributes at present, so only built-in files matter).
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Cc: Tony Luck <[EMAIL PROTEC
>>> Greg KH <[EMAIL PROTECTED]> 22.01.08 23:15 >>>
>On Tue, Jan 22, 2008 at 01:31:21PM +, Jan Beulich wrote:
>> .. as all consumers of it don't require it to be modifiable.
>>
>> Unfortunately, due to the two-level constifications, this requi
Change kconfig behavior so that mixing bool and tristate config
settings in a choice is possible and has the desired effect of offering
just the tristate options individually if the choice gets set to M, and
a normal boolean selection if the choice gets set to Y.
Signed-off-by: Jan Beulich
x27;s handling of children of choice values -
there may be more than one immediate child, and all of them need to be
processed.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
---
scripts/kconfig/conf.c |4 ++--
scripts/kconfig/expr.c | 10 --
scripts/kconfig/me
>menu_finalize as it stand today is already too complicated.
>
>Could we have this additional functionlity factored out or at least commented
>so mare humans have a small chance to understand what is going on.
I'd prefer leaving the factoring-out to Roman, in fear of breaking
something if I do it
>Yes, but why export variables? Wouldn't it be better to export
>an API?
>
>That simplifies the callers (they all pass "current" as task
>and "task_notifier_list" as arguments).
>
>It also prevents exposing internal variables (notifier lists
>ARE internal variables) to modules.
>
>What do you t
Thanks for catching this!
>>> Dave Jones <[EMAIL PROTECTED]> 21.12.07 03:30 >>>
On Thu, Dec 20, 2007 at 04:14:05PM -0700, Eric W. Biederman wrote:
> Remains the question whether it is intended that many, perhaps even
> large, tables are compiled in without ever having a chance to get used,
> i
>>> Eric W. Biederman <[EMAIL PROTECTED]> 21.12.07 00:05 >>>
>"Jan Beulich" <[EMAIL PROTECTED]> writes:
>
>> Remains the question whether it is intended that many, perhaps even
>> large, tables are compiled in without ever having a
Remains the question whether it is intended that many, perhaps even
large, tables are compiled in without ever having a chance to get used,
i.e. whether there shouldn't #ifdef CONFIG_xxx get added.
(Cut-n-paste mistake corrected, pointed out by Dave Jones.)
Signed-off-by: Jan Beulich &l
Ever since I started to try to get at least some fundamental infrastructure
pieces merged for using NLKD on Linux I was told that direct calls out of
exception handlers for the sake of an individual (and perhaps even small)
sub-system is undesirable.
Making the exception notifiers report the right
>>> "Andrew Pinski" <[EMAIL PROTECTED]> 25.11.07 19:45 >>>
>On 11/25/07, Luca <[EMAIL PROTECTED]> wrote:
>> 7.1. Add __attribute__((pointer_size(XXX))) and #pragma pointer_size
>> to allow 64-bit pointers in 32-bit mode and viceversa
>
>This is already there, try using __attribute__((mode(DI) )).
There apparently was an unnoticed conflict between your patch (committed
as 23d5ea5d3edcfe899cd91fca87a4af799bcc5794 2.6.23) and mine
(d1e084746b0e5806e6345ab31c5b370f8dee2b23), which I noticed only now.
I suppose a change like the one below (untested) is needed; before officially
submitting I'd li
This patch (in its incarnation in our SLE10SP2 tree) is causing resource
allocation failures on one of my machines. The condition for this is that
besides ROMs behind a bridge not having their base addresses assigned
there's no extra space available in the non-prefetch window to
accommodate the ROM
>>> Greg KH <[EMAIL PROTECTED]> 21.11.07 00:14 >>>
>On Tue, Nov 20, 2007 at 03:49:43AM -0700, Jan Beulich wrote:
>> This patch (in its incarnation in our SLE10SP2 tree) is causing resource
>> allocation failures on one of my machines.
>
>Does the latest
>2. I noticed the _PAGE_PCD|_PAGE_PWT combination being used a lot, so
>I created _PAGE_NOCACHE to wrap them up. asm-x86/fb.h uses plain
>_PAGE_PCD; should it be _PAGE_NOCACHE too?
Setting PCD but not PWT (or the other way around) is yielding not fully
defined behavior (model specific) as per the
ere 'const' could have been
added as a result of the base structure changes, only where either the
change has a real effect (the module loader doesn't enforce read-only
section attributes at present, so only built-in files matter) or where
compiler warnings would result otherwise.
S
been added as a result of the base structure changes, only where the
change has a real effect (the module loader doesn't enforce read-only
section attributes at present, so only built-in files matter).
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Cc: Tony Luck <[EMAIL PROTEC
enforce
read-only section attributes at present, so only built-in files matter)
or where compiler warnings would result otherwise.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Cc: Tony Luck <[EMAIL PROTECTED]>
Cc: Ingo Molnar <[EMAIL PROTECTED]>
Cc: Jens Axboe <[EMAIL PROTEC
sumer.
Patch 2 adds a number of x86 consumers of __cpuinitconst.
Patch 3 introduces __devinitconst and common code consumers.
Patch 4 adds a number of x86 consumers of __devinitconst.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
--
To unsubscribe from this list: send the line "u
nce).
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Cc: Len Brown <[EMAIL PROTECTED]>
Cc: Andi Kleen <[EMAIL PROTECTED]>
---
drivers/acpi/processor_idle.c |2 +-
include/linux/init.h |2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
--- 2.6.24-rc7-initco
difference).
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Cc: Ingo Molnar <[EMAIL PROTECTED]>
---
arch/x86/kernel/cpu/amd.c |2 +-
arch/x86/kernel/cpu/centaur.c |2 +-
arch/x86/kernel/cpu/common.c | 14 +++---
arch/x86/ker
n the same object could likewise be done in an almost global fashion,
although drivers/ide/pci/ seems to be the most significant violator.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Cc: Greg Kroah-Hartman <[EMAIL PROTECTED]>
---
drivers/i2c/busses/i2c-piix4.c |4 ++--
drivers
difference).
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Cc: Ingo Molnar <[EMAIL PROTECTED]>
---
arch/x86/pci/acpi.c |2 +-
arch/x86/pci/common.c |2 +-
arch/x86/pci/fixup.c |4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
--- 2.6.24-rc7-initconst.orig/ar
ignore it and use the [faster] built-in.)
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
---
scripts/mkmakefile | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
--- linux-2.6.24-rc7/scripts/mkmakefile 2008-01-10 16:55:30.0 +0100
+++ 2.6.24-rc7-mkmakefile-objdir/s
e the table, which would result in this code
possibly, but unintentionally screwing up other symbol names.
Besides that, the presented alternative is both smaller and faster.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/module_64.c | 10 --
1 file changed, 4
.. allowing it to be write-protected just as other read-only data
under CONFIG_DEBUG_RODATA.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Cc: Linus Torvalds <[EMAIL PROTECTED]>
Cc: Ingo Molnar <[EMAIL PROTECTED]>
---
arch/x86/kernel/vmlinux_32.lds.S |7 ---
arch/x86
rcall interface expects the LDT address to be
virtual, not machine.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Cc: Ingo Molnar <[EMAIL PROTECTED]>
---
arch/x86/kernel/ldt_32.c |7 +++
arch/x86/kernel/ldt_64.c |7 +++
arch/x86/xen/enlighten.c |9 +
3
>> --- linux-2.6.24-rc7/arch/x86/kernel/ldt_32.c2008-01-10
>> 16:53:54.0 +0100
>> +++ 2.6.24-rc7-x86-xen-ldt/arch/x86/kernel/ldt_32.c 2008-01-09
>> 13:59:50.0 +0100
>[...]
>> @@ -73,7 +72,7 @@ static int alloc_ldt(mm_context_t *pc, u
>> if (oldsize*LDT_ENTRY_
>>> Jeremy Fitzhardinge <[EMAIL PROTECTED]> 11.01.08 18:28 >>>
>Jan Beulich wrote:
>> Don't rely on kmalloc(PAGE_SIZE) returning PAGE_SIZE aligned memory
>> (Xen requires GDT *and* LDT to be page-aligned).
>
>Can kmalloc return non-page-aligned
>> --- 2.6.24-rc7-initconst.orig/include/linux/init.h
>> +++ 2.6.24-rc7-initconst/include/linux/init.h
>> @@ -269,11 +269,13 @@ void __init parse_early_param(void);
>> #ifdef CONFIG_HOTPLUG_CPU
>> #define __cpuinit
>> #define __cpuinitdata
>> +#define __cpuinitconst const
>> #define __cpuexit
>
>>> Sam Ravnborg <[EMAIL PROTECTED]> 13.01.08 22:42 >>>
>> And I found another small buglet too. I hope to post a complete
>> solution later today.
>
>The modpost bits turned out to take longer than expected so
>they are not done yet. The problem was the modpost structure
>were not prepared for ad
>> The one thing that I'm not sure is really consistent yet wrt. the
>> constification is that now you need to write e.g.
>>
>> static const char __cpuinitcdata example[];
>>
>> and (accidentally) omitting the 'const' (as it's really an apparently
>> redundant thing now) as in
>>
>> static char
>>> Ingo Molnar <[EMAIL PROTECTED]> 14.01.08 16:48 >>>
>
>* Jan Beulich <[EMAIL PROTECTED]> wrote:
>
>> Don't rely on kmalloc(PAGE_SIZE) returning PAGE_SIZE aligned memory
>> (Xen requires GDT *and* LDT to be page-aligned). Using the pag
>+static unsigned short pat_bit[5] = {
Could be const and perhaps even local to cache_attr_changed()...
Jan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
>- /* clflush is still broken. Disable for now. */
>- if (1 || !cpu_has_clflush)
>+ if (a->full_flush)
> asm volatile("wbinvd" ::: "memory");
>- else list_for_each_entry(pg, l, lru) {
>- void *adr = page_address(pg);
>- clflush_cache_range
>+ ref_prot = canon_pgprot(ref_prot);
>+ prot = canon_pgprot(prot);
>+
> if (pgprot_val(prot) != pgprot_val(ref_prot)) {
>...
> } else if (level == 4) {
>...
> } else {
> /*
>* When you're here you either set the same page to PAGE_KERNEL
D
of the reference protection for a large page range that got fully converted
to another type (namely relevant for .rodata if it exceeds 2/4 Mb), allowing
to use a large page mapping in this case even for non-default mappings.
Apart from the other comments, the whole series
Acked-by: Jan Beulich <
>> The one concept that I'm missing (but that I can easily produce a follow-up
>> patch for, as I had this in my c_p_a() changes) is the tracking and adjusting
>> of the reference protection for a large page range that got fully converted
>> to another type (namely relevant for .rodata if it exceed
>>> Andi Kleen <[EMAIL PROTECTED]> 15.01.08 11:04 >>>
>On Tuesday 15 January 2008 10:05:44 Jan Beulich wrote:
>> >+ ref_prot = canon_pgprot(ref_prot);
>> >+ prot = canon_pgprot(prot);
>> >+
>> >if (pgprot_val(prot) !=
>>> Randy Dunlap <[EMAIL PROTECTED]> 20.10.07 05:21 >>>
Sorry for only now getting back to this.
>On Fri, 19 Oct 2007 19:55:35 -0700 Randy Dunlap wrote:
>
>> On Fri, 19 Oct 2007 19:01:09 -0700 Randy Dunlap wrote:
>>
>> > >>> I noticed a regression, visible in the drivers/usb/gadget Kconfig;
>> >
Roman,
now that I finally found time to look into the problems that caused the
patch changing boolean/tristate choice behavior to be reverted I find
that due to the way things worked in the past there are a couple of
cases where config options not really belonging to the choice are inside
the choi
>But one feature I really would like to see is named chocies so we can do stuff
>like:
>
>choice X86_PROCESSOR
>
>config GENERIC_PROCESSOR
> bool "A generic X86 processor"
>endchoice
>
>
>...
>
>choice PPC_PROCESSOR
>
>config GENERIC_PROCESSOR
> bool "A generic PowerPC processor
>
>end
>Yes, but if you cast to long the result will be 32bit again. Or do you
>rely on it being always used in 64bit signed context with sign extension?
>While that might work it would seem rather fragile to me, just asking
>for similar future bugs.
Even if conversion is to 64-bit unsigned, the value (b
>>> David Brownell <[EMAIL PROTECTED]> 17.01.08 01:02 >>>
>On Wednesday 16 January 2008, Jan Beulich wrote:
>> >>> Randy Dunlap <[EMAIL PROTECTED]> 20.10.07 05:21 >>>
>>
>> Sorry for only now getting back t
>>> Ingo Molnar <[EMAIL PROTECTED]> 17.12.07 14:26 >>>
>
>* Jan Beulich <[EMAIL PROTECTED]> wrote:
>
>> This generally allows better code to be generated, since the zero-
>> extension during 32-bit operations comes for free (needed when the
&g
>>> Ingo Molnar <[EMAIL PROTECTED]> 17.12.07 14:28 >>>
>
>* Jan Beulich <[EMAIL PROTECTED]> wrote:
>
>> When either calling change_page_attr() with the default attributes
>> pages in the direct mapping have and a page's attributes
>>> Ingo Molnar <[EMAIL PROTECTED]> 17.12.07 14:42 >>>
>
>* Jan Beulich <[EMAIL PROTECTED]> wrote:
>
>> The patch introducing this left out x86-64, despite it also having
>> extra entries.
>
>thanks, applied. Is there any 2.6.24 urgency fo
creation
and deletion.
Patch 2 switches delayacct to make use of the notifier.
Patch 3 makes the procevents/connector use the infrastructure and adds
additional notifiers needed there.
Patch 4 makes the security keys handling use this, too.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
This is the base patch, adding notification for task creation and
deletion.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
---
include/linux/sched.h |8 +++-
kernel/fork.c | 11 +++
2 files changed, 18 insertions(+), 1 deletion(-)
--- 2.6.24-rc5-notify-tas
This has the additional benefit of allowing the code to now be built
as a module (which made it necessary to add MODULE_xxx declarations).
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Cc: Matt Helsley <[EMAIL PROTECTED]>
---
drivers/connector/Kconfig |5 +--
drivers/connect
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Cc: David Howells <[EMAIL PROTECTED]>
---
arch/mips/kernel/kspd.c |7 +++--
include/linux/key.h |4 ---
kernel/sys.c |8 --
security/keys/process_k
Actually, another thought: permitting (and handling) spurious faults for
kernel mappings conflicts with NMI handling, i.e. great care would be
needed to ensure the NMI path cannot touch any such mapping. So
even the present Xen/Linux Dom0 implementation may have some
(perhaps unlikely) problems her
>>> Nick Piggin <[EMAIL PROTECTED]> 25.01.08 09:38 >>>
>On Friday 25 January 2008 19:15, Jan Beulich wrote:
>> Actually, another thought: permitting (and handling) spurious faults for
>> kernel mappings conflicts with NMI handling, i.e. great care would be
ement/decrement oops_in_progress, and wake klogd
only when the count drops back to zero.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
lib/bust_spinlocks.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- linux-2.6.23-rc4/lib/bust_spinlocks.c 2007-04-26 05:08:32.0
__setup_str_* are referenced only during boot, hence there's no need to
waste image space for aligning these strings (with the aim of improving
performance).
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
include/linux/init.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
.. in an effort to make read-only whatever can be made, so that
CONFIG_DEBUG_RODATA can catch as many issues as possible.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
include/linux/moduleparam.h | 18 +++---
kernel/params.c | 17 +++--
2 files c
.. when dumping register state. This is particularly useful when gcc
managed to tail-call optimize an indirect call which happens to hit a
NULL (or otherwise invalid) pointer.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
Documentation/kernel-parameters.txt |3 +++
arch/i386/kern
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/i386/mm/fault.c |3 ++-
arch/x86_64/mm/fault.c |2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
--- linux-2.6.23-rc4/arch/i386/mm/fault.c 2007-08-28 09:41:59.0
+0200
+++ 2.6.23-rc4-x86-page-walk-pse/arch/i
.. and handle use of the x86-64 file by make logic instead.
Signed-off-by: Jan Beulich <[EMAIL PROTECTED]>
arch/i386/kernel/Makefile |1 +
arch/i386/kernel/early_printk.c |2 --
2 files changed, 1 insertion(+), 2 deletions(-)
--- linux-2.6.23-rc4/arch/i386/kernel/Makefile
infrastructural things work independent of
the fact that the fault and the callbacks are running on other then
the normal kernel stack.
Signed-Off-By: Jan Beulich <[EMAIL PROTECTED]>
Acked-By: Andi Kleen <[EMAIL PROTECTED]>
arch/i386/kernel/cpu/common.c | 63 -
>>> Andi Kleen <[EMAIL PROTECTED]> 01.09.07 12:33 >>>
>
>Can you cc the next version to Linus please? He's probably best qualified
>to review the i386 double fault handler because he wrote it originally.
>I must admit the code always scared me a bit.
Will do.
>> +#ifdef CONFIG_HOTPLUG_CPU
>> +sta
But that is still wrong - you're again flushing the page table page rather than
the data one. Fixing this was the purpose of the patch I had sent, plus the
broken reference counting used by the reversion logic. Jan
>>> Andi Kleen <[EMAIL PROTECTED]> 19.07.07 11:54 >>>
Fix a bug introduced with th
401 - 500 of 1374 matches
Mail list logo
