>>> Jeremy Fitzhardinge <[EMAIL PROTECTED]> 14.12.07 08:12 >>> >Jan Beulich wrote: >> When either calling change_page_attr() with the default attributes >> pages in the direct mapping have and a page's attributes already were >> set to the default or when changing the attributes from one non-default >> value to another, the reference counting broke, leading to either >> premature restoration of a large page or missing the opportunity to do >> so. >> >> At the same time, make __PHYSICAL_MASK_SHIFT on 64-bits the value it >> architecturally ought to have. >> > >Could you put this in a separate patch? I have a bunch of page*.h and >pgtable*.h refactoring patches which will conflict with this.
I doesn't seem logical to do so: The patch needs to introduce the definitions for 32-bits (in order to define pte_pgprot()), and not doing the adjustment for 64-bits here means (a) becoming inconsistent and (b) the pte_pgprot() there would be incorrect. So such a split out patch would need to be a pre- requisite to the one here, which wouldn't help avoiding the collisions with your unification patches. Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
