rst request */
> mmc_claim_host(card->host);
> + if (card->ext_csd.bkops_en &&
> + card->bkops_info.started_delayed_bkops) {
> + card->bkops_info.started_delayed_bkops = false;
> +
Hi Doug,
Great..i have found the problem like this.
I will check your patch..and share the result.
Best Regards,
Jaehoon Chung
On 03/16/2013 06:29 AM, Doug Anderson wrote:
> On a flaky piece of hardware that seems good at generating CRC errors,
> we have found that often times the CRC
Hi Doug,
You're right..it's something wrong.
Actually i didn't test with your patch, but your commit message is reasonable.
I will check until next week after test.
Best Regards,
Jaehoon Chung
On 03/27/2013 03:06 AM, Doug Anderson wrote:
> Jaehoon,
>
> On Mon, Mar 18,
be called if SDIO IRQ isn't
> used...
Right, But I think that need to check whether the host->sdio_irq_thread is
assigned or not.
Best Regards,
Jaehoon Chung
>
> Thanks
> Guennadi
>
>>
>> Signed-off-by: Joonyoung Shim
>> ---
>> Currently the ker
Looks good to me.
Acked-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
On 03/12/2013 07:43 PM, James Hogan wrote:
> Call the setpower platform callback in response to set_ios with
> ios->power_mode == MMC_POWER_UP or MMC_POWER_OFF, instead of from the
> card detect work functio
Hi James,
There is no reason that can't change the verid check position.
So this patch looks good to me.
Acked-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
On 03/12/2013 07:43 PM, James Hogan wrote:
> host->data_offset is initialised at the end of the probe function
> dependin
Acked-by: Jaehoon Chung
On 03/12/2013 07:53 PM, Markos Chandras wrote:
> There is no reason to loop when handling an interrupt. The "if" clauses
> will handle all of them sequentially. This also eliminates the extra loop
> we used to take with no pending interrupts and we en
you ever tried to use rootwait or rootdelay on command line ?
> If no, You can use them.
I agreed the Namjae's suggestion..if you use the rootwait or rootdelay, it's
waiting for mounting rootfs.
Best Regards,
Jaehoon Chung
>
> Thanks.
>
--
To unsubscribe from this list: sen
-developers.com/showthread.php?t=1644364
> https://plus.google.com/111398485184813224730/posts/21pTYfTsCkB#111398485184813224730/posts/21pTYfTsCkB
>
> Signed-off-by: Ian Chen
> Reviewed-by: Namjae Jeon
> Acked-by: Jaehoon Chung
> Reviewed-by: Linus Walleij
> --
Hi Chris,
Could you merge this patch?
We want to prevent this problem at mainline kernel.
Best Regards,
Jaehoon Chung
On 08/29/2012 03:05 PM, IAN CHEN wrote:
> For several MoviNAND, there are some known issue with secure option.
> For these specific MoviNAND device, we skip secure
ly and if needed, the BKOPs will be performed
> without waiting for the next idle time.
>
> Signed-off-by: Maya Erez
> Signed-off-by: Jaehoon Chung
> ---
> This patch depends on the following patch:
> [PATCH v11] mmc: support BKOPS feature for eMMC
>
> This patch is b
Before call the blk_queue_congestion_threshold(),
the blk_queue_congestion_threshold() is already called at
blk_queue_make_rquest().
Because this code is the duplicated, it has removed.
Signed-off-by: Jaehoon Chung
Signed-off-by: Kyungmin Park
---
block/blk-core.c |2 --
1 files changed
I didn't understand why defer the probe?
I think that some board can't control vqmmc or vmmc.
Best Regards,
Jaehoon Chung
On 10/23/2012 04:18 PM, Pavan Kunapuli wrote:
> vmmc and vqmmc regulators control the voltage to
> the host and device. Defer the probe if either of
> the
Looks good to me.
Acked-by: Jaehoon Chung
On 10/31/2012 07:21 AM, Sergei Trofimovich wrote:
> From: Sergei Trofimovich
>
> Found by gcc:
>
> linux-2.6/drivers/mmc/host/dw_mmc-exynos.c: At top level:
> linux-2.6/drivers/mmc/host/dw_mmc-exynos.c:226:1: error:
> &
Hi Doug,
On 08/24/2013 05:40 AM, Doug Anderson wrote:
> Jaehoon,
>
> On Fri, Aug 23, 2013 at 6:21 AM, Jaehoon Chung wrote:
>> Hi Doug,
>>
>> If the clock-gating is enabled, then maybe it's continuously printed the
>> kernel message for Bus_speed.
>
>
>> +if (slot->clock == 0) {
>> +mci_writel(host, CLKENA, 0);
>> +mci_send_cmd(slot,
>> + SDMMC_CMD_UPD_CLK | SDMMC_CMD_PRV_DAT_WAIT, 0);
> Basically dw_mmc driver uses host's low power mode(auto clock gating)
ler didn't have responsibility to ensure whether power is
enabled or not at probing time.
If just needed to balance vreg, then i think this function can be removed.
How about?
Also before using regulator_is_enabled(), i had found the hole for balancing
the vreg.
Best Regards,
Jaehoon Chung
Hi, Chanho.
I remembered Shawn Guo had posted this patch.
Do you resend it?
Best Regards,
Jaehoon Chung
On 09/06/2013 03:01 PM, Chanho Min wrote:
> This patch supports non-blocking mmc request function for the sdchi driver.
> (commit: aa8b683a7d392271ed349c6ab9f36b8c313794b7)
>
Hi,
your patch[1/3] is also "Fixed lines > 80chars".
Why do you separate with patch[1/6] and patch[3/6]?
Best Regards,
Jaehoon Chung
On 10/19/2012 01:31 AM, Sangho Yi wrote:
> I fixed lines over 80 characters per line.
>
> Signed-off-by: Sangho Yi
> ---
> driver
Hi Tushar,
Could you make one patch? Why do you separate patches?
Best Regards,
Jaehoon Chung
On 11/09/2012 08:39 PM, Tushar Behera wrote:
> Documents/CodingStyle Chapter 3 recommends usage of braces for both
> if and else statements if any of the branches contains multiple
> s
Hi Maya,
I tested with dw-mmc controller.
It's look good to me.
Tested-by: Jaehoon Chung
On 11/07/2012 01:28 PM, me...@codeaurora.org wrote:
> Hi Jaehoon,
>
> Any update on this patch review and testing?
>
> Thanks,
> Maya
> On Mon, October 15, 2012 11:53 pm, Jaeho
Great..Thanks Arnd and Chris.
Best Regards,
Jaehoon Chung
On 11/08/2012 11:35 PM, Chris Ball wrote:
> Hi Arnd,
>
> On Thu, Nov 08 2012, Arnd Bergmann wrote:
>> The patch "dw_mmc: fix multiple drv_data NULL dereferences" has
>> unfortunately clashed
Hi All,
Sorry for reply..I didn't fully read about this patch history.
So i will resend the my opinion after reading the mail-history
Best Regards,
Jaehoon Chung
On 12/21/2012 06:56 PM, Ulf Hansson wrote:
> On 21 December 2012 09:35, Maya Erez wrote:
>> Hi Ulf,
>>
>&g
Acked-by: Jaehoon Chung
On 06/03/2013 07:58 AM, Heiko Stübner wrote:
> dw_mci_pltfm_remove gets exported and used by dw_mmc-exynos, so should
> not be static.
>
> Signed-off-by: Heiko Stuebner
> ---
> drivers/mmc/host/dw_mmc-pltfm.c |2 +-
> 1 files changed, 1 inser
On 06/03/2013 07:59 AM, Heiko Stübner wrote:
> Cortex-A9 SoCs from Rockchip use a slightly modified variant of dw_mmc
> controllers that seems to require the SDMMC_CMD_USE_HOLD_REG bit to
> always be set.
>
> There also seem to be no other modifications (additional register etc)
> present, so to k
Looks good to me. If you can add the usage example, it will be more helpful to
me.
Acked-by: Jaehoon Chung
On 06/07/2013 01:46 PM, Doug Anderson wrote:
> As of now we rely on code outside of the driver to set the ciu clock
> frequency. There's no reason to do that. Add support for
lue.
Best Regards,
Jaehoon Chung
On 06/08/2013 02:28 AM, Doug Anderson wrote:
> As of now we rely on code outside of the driver to set the ciu clock
> frequency. There's no reason to do that. Add support for setting up
> the clock in the driver during probe.
>
> Signed-off
Hi All,
I tested with Seungwon's patch and this patch.
I'm agreed with Seungwon's opinion.
Best Regards,
Jaehoon Chung
On 06/18/2013 09:36 PM, Seungwon Jeon wrote:
> On Thursday, June 13, 2013, Doug Anderson wrote:
>> Seungwon,
>>
>> On Wed, Apr 10, 20
Hi Doug,
I'm researching for fixed-rate-clocks.
Maybe i misunderstood for using . :)
Best Regards,
Jaehoon Chung
On 06/19/2013 12:15 AM, Doug Anderson wrote:
> Jaehoon,
>
> On Mon, Jun 17, 2013 at 9:51 PM, Jaehoon Chung wrote:
>> Hi Doug,
>>
>> I have one que
Hi Seungwon,
I didn't get the same result..In my case, it's working fine.
But as Bing's result, i will check more and share the result.
Best Regards,
Jaehoon Chung
On 06/26/2013 10:53 AM, Seungwon Jeon wrote:
> Hi Jaehoon,
> Do you have the same result?
> Could you share
Hi Georgi,
I found the you use the "vreg->is_enabled".
why don't you use the regulator_is_enabled()? i think better that use this
function.
Is there a special reason that use the "vreg->is_enabled"?
Best Regards,
Jaehoon Chung
On 08/13/2013 11:06 PM, Georgi Djako
Hi Doug,
I think these patch-set didn't base on latest mmc-next.
If you can rebase on latest mmc-next, it's helpful to me for testing.
Best Regards,
Jaehoon Chung
On 07/11/2013 12:42 AM, Doug Anderson wrote:
> If the WAKEUP_INT is asserted at wakeup and not cleared, we'l
Acked-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
On 07/30/2013 10:33 PM, Seungwon Jeon wrote:
> On Tue, July 30, 2013, Mark Brown wrote:
>> From: Mark Brown
>>
>> Use regulator_get_optional() to tell the core that requests for regulators
>> can fail in a real
Acked-by: Jaehoon Chung
On 08/23/2013 01:19 AM, Doug Anderson wrote:
> The TMOUT register is initted to 0x at probe time but isn't
> initted after suspend/resume. Add an init of this value.
>
> No problems were observed without this (it will also get initted in
> __
Hi Doug,
If the clock-gating is enabled, then maybe it's continuously printed the kernel
message for Bus_speed.
Best Regards,
Jaehoon Chung
On 08/23/2013 01:19 AM, Doug Anderson wrote:
> Previously the dw_mmc driver would ignore any requests to disable the
> card's clock. T
_flags & MMC_PM_KEEP_POWER) {
> dw_mci_set_ios(slot->mmc, &slot->mmc->ios);
> - dw_mci_setup_bus(slot, true);
If we need not to call dw_mci_setup_bus() at here,
the we can also remove the "force_clkinit".
Best Regards
Looks good to me.
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
On 04/05/2013 05:18 PM, Jaehoon Chung wrote:
> Hi Doug,
>
> You're right..it's something wrong.
> Actually i didn't test with your patch, but your commit message is reasonable.
>
> I
On 04/10/2013 04:02 PM, Seungwon Jeon wrote:
> On Tuesday, April 09, 2013, Doug Anderson wrote:
>> Seungwon,
>>
>> On Mon, Apr 8, 2013 at 5:17 AM, Seungwon Jeon wrote:
>>> I guess Doug are debugging it with wifi, right?
>>
>> Yes, we're debugging it on the Samsung ARM Chromebook on a part that
>>
Hi Felipe,
I didn't understand this patch, why need to add set_power?
We can use to control the power with the fixed regulator.
Then we can also use the regulator framework.
And i know also control the module like wifi with rfkill.
In set_power, what is it controlled?
Best Regards,
Jaehoon
away from platform
> callbacks, because they are incompatible with DT. Second, because the
> proper solution IMHO would be for your platform to export a regulator, and
> the SDHCI core driver already includes regulator support.
We can use the regulator framework.
i think this
Hi Doug,
I didn't know what purpose is.
Why need to add the MMC_CAP2_NO_MMC?
If card is SD or SDIO, mmc_attach_mmc(host) should not be entered.
Could you explain to me in more detail?
Best Regards,
Jaehoon Chung
On 08/22/2012 01:05 PM, Doug Anderson wrote:
> On some systems we need
ady we used the flags with "_SEC_"
It's no problem.
Best Regards,
Jaehoon Chung
> So, how about MMC_QUIRK_SECDISCARD_BROKEN which was used in
> mmc_blk_issue_secdiscard_rq() naming, the function we skip.
> Or, MMC_QUIRK_SECERASE_SECTRIM_BROKEN?
>
> Regards,
On 07/20/2012 07:47 AM, Kukjin Kim wrote:
> Thomas Abraham wrote:
>>
>> On 19 July 2012 20:58, Jaehoon Chung wrote:
>>> Hi Thomas,
>>>
>>> I think not good that added the samsung specific code into dw_mmc-
>> pltfm.c
>>> How about separa
On 07/24/2012 02:02 AM, Doug Anderson wrote:
> The documentation for the dw_mmc part says that the low power
> mode should normally only be set for MMC and SD memory and should
> be turned off for SDIO cards that need interrupts detected.
>
> The best place I could find to do this is when the SDIO
eave low power mode disabled and it will get
> + * re-enabled again in dw_mci_setup_bus().
> + */
> + dw_mci_disable_low_power(mmc_priv(mmc));
Just use the slot. slot is already assigned to mmc_priv(mmc)
Reviewed-by: Jaehoon Chung
--
To unsubscribe from this
the same drv_data, should be changed to more generic name, not
"exynos5250_".
Best Regards,
Jaehoon Chung
> { .compatible = "samsung,exynos5250-dw-mshc",
> .data = &exynos5250_drv_data, },
> {},
>
--
To unsubscribe from this li
ODEV;
> + goto out_vmmc;
> }
>
> spin_lock_init(&host->lock);
> @@ -3121,6 +3122,9 @@ reset:
> untasklet:
> tasklet_kill(&host->card_tasklet);
> tasklet_kill(&host->finish_tasklet);
> +out_vmmc:
> + if (host-&g
Hi Maya,
I'm testing with your patch..but i need to have the more time for testing.
In now, it looks good to me. Thank you for working the idle bkops.
Best Regards,
Jaehoon Chung
> ---
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index 172a768..ed040d5
Looks good to me.
Acked-by: Jaehoon Chung
On 10/16/2012 05:43 PM, James Hogan wrote:
> Commit 800d78bfccb3d38116abfda2a5b9c8afdbd5ea21 ("mmc: dw_mmc: add
> support for implementation specific callbacks") merged in v3.7-rc1.
>
> The above commit introduced multiple NUL
quot;, 0);
> +
> + /* Having a missing entry is valid; return silently */
> + if (!gpio_is_valid(gpio))
> + return -1;
> +
> + if (devm_gpio_request(dev, gpio, "dw-mci-wp")) {
> + dev_warn(dev, "gpio [%d] request
Hi Shawn,
On 09/20/2016 06:47 PM, Shawn Lin wrote:
> Hi Jaehoon,
>
> Friendly ping... :)
Thanks for reminding! :) I forgot your patch-set..sorry!
Best Regards,
Jaehoon Chung
>
> On 2016/9/2 12:14, Shawn Lin wrote:
>> We could see an obvious race condition by test tha
ist and call both of them
> when staring idmac.
Applied on my tree. Thanks!
Best Regards,
Jaehoon Chung
>
> Signed-off-by: Shawn Lin
>
> ---
>
> Changes in v2:
> - remove dw_mci_translate_sglist
>
> drivers/mmc/host/dw_mmc.c | 149
> +++
On 09/02/2016 01:14 PM, Shawn Lin wrote:
> It's very prone to make mistake as we might forget
> to replace all PAGE_SIZEs with new values if we try
> to modify the ring buffer size for whatever reasons.
> Let's use a macro to define it.
Applied on my tree. Thanks!
Best
On 09/02/2016 01:14 PM, Shawn Lin wrote:
> The original log didn't figure out that we could still
> finish this transfer by PIO mode even if failing to use
> DMA. And it should be kept for debug level instead of
> error one.
Applied on my tree. Thanks!
Best Regards,
Jaehoon C
n the same address,
> and this should be protected by adding check of OWN
> bit before preparing new descriptors.
Applied on my tree. Thanks!
Best Regards,
Jaehoon Chung
>
> Signed-off-by: Shawn Lin
>
> ---
>
> Changes in v2:
> - fallback to PIO mode if failing to wait f
On 09/21/2016 11:40 AM, Shawn Lin wrote:
> msize and rx_wmark are properly initialized, we dont't
> need to assign them again.
Applied on my tree. Thanks!
Best Regards,
Jaehoon Chung
>
> Signed-off-by: Shawn Lin
> ---
>
> drivers/mmc/host/dw_mmc.c | 5 +
>
rce_clkinit)
> + if (clock != slot->__clk_old || div != slot->__div_old ||
> + force_clkinit)
I have realized why we put this condition..after checking your below codes.
This was patch to avoid the spamming for CONFIG_MMC_CLKGATE..
but
Hi Enric,
On 06/20/2016 04:59 PM, Enric Balletbo Serra wrote:
> Hi Jaehoon,
>
> 2016-04-27 10:53 GMT+02:00 Enric Balletbo i Serra
> :
>>
>>
>> On 27/04/16 10:35, Jaehoon Chung wrote:
>>> On 04/26/2016 05:03 PM, Enric Balletbo i Serra wrote:
>>>
e system into a confused state causing
> all future tuning phases to report failure.
I understood this patch what purpose has.
Does it need to consider for other tuning cases?
Best Regards,
Jaehoon Chung
>
> When in the confused state, the controller would show these (hex codes
> are inte
Although there is no requirement in the spec, I think the driver can
> give some time to the device to perform/complete its internal GC during the
> idle time.
> Thus I think we can check the BKOPS_STATUS on Runtime suspend.
I'm not sure we can check BKOPS_STATUS when use the AUTO_BKO
Hi guys,
On 06/21/2016 11:31 AM, Shawn Lin wrote:
> On 2016/6/21 10:24, Seung-Woo Kim wrote:
>> Hello Shawn,
>>
>>> -Original Message-
>>> From: Shawn Lin [mailto:shawn@rock-chips.com]
>>> Sent: Tuesday, June 21, 2016 10:52 AM
>>> To: Seung-Woo Kim; jh80.ch...@samsung.com; ulf.hans...@
_bounds+0x18c/0x1bc
> [] dw_mci_setup_bus+0x384/0x438
> [...]
>
> The warnings are caused because of bit shift which is used to
> filter spamming message for CONFIG_MMC_CLKGATE, but the config is
> already removed. So this patch just removes the shift.
>
> Signed-off-by:
Hi Enric,
On 06/22/2016 01:30 AM, Enric Balletbo Serra wrote:
> Hi Jaehoon,
>
> 2016-06-20 12:14 GMT+02:00 Jaehoon Chung :
>> Hi Enric,
>>
>> On 04/26/2016 05:03 PM, Enric Balletbo i Serra wrote:
>>> From: Doug Anderson
>>>
>>> According to
Dwmmc controller didn't support the slot sub-nodes.
(dwmmc controller decided not to consider the slot nodes.)
And "supports-highspeed" property was deprecated.
Instead, use "cap-sd/mmc-highspeed" properties.
Signed-off-by: Jaehoon Chung
---
arch/arm/boot/
Remvoe the deprecated "supports-highspeed" property.
DWMMC controller will not use this property anymore.
Signed-off-by: Jaehoon Chung
---
drivers/mmc/host/dw_mmc.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
ind
Hi Shawn,
On 07/29/2016 11:44 AM, Shawn Lin wrote:
> 在 2016/7/28 17:55, Jaehoon Chung 写道:
>> Remvoe the deprecated "supports-highspeed" property.
>> DWMMC controller will not use this property anymore.
>>
>
> We had set up a flag day to remove these deprecat
;
> - /* Set last descriptor */
> - desc_last->des0 &= cpu_to_le32(~(IDMAC_DES0_CH |
> -IDMAC_DES0_DIC));
> - desc_last->des0 |= cpu_to_le32(IDMAC_DES0_LD);
> - }
> + /* Set last descriptor */
> + desc_last->des0 &= cpu_to_le32(~(IDMAC_DES0_CH |
> +IDMAC_DES0_DIC));
> + desc_last->des0 |= cpu_to_le32(IDMAC_DES0_LD);
> +}
> +
> +static void dw_mci_translate_sglist(struct dw_mci *host, struct mmc_data
> *data,
> + unsigned int sg_len)
> +{
> + if (host->dma_64bit_address == 1)
> + dw_mci_prepare_desc64(host, data, sg_len);
> + else
> + dw_mci_prepare_desc32(host, data, sg_len);
I think dw_mci_translate_sglist can be removed.
Instead, these functions should be called in dw_mci_idamc_start_dma().
How about?
Best Regards,
Jaehoon Chung
>
> wmb(); /* drain writebuffer */
> }
>
> + dev_err(host->dev, "DESC is still owned
> by IDMAC.\n");
> + break;
Doesn't it need the error handling? Just display the message?
Best Regards,
Jaehoon Chung
> +
ert the
power controlling?
But it's not general case. We can discuss about this.
Best Regards,
Jaehoon Chung
>
>
> Changes in v2:
> - fix copy-paste err and typo
>
> Shawn Lin (6):
> dt-bindings: rockchip-dw-mshc: add description of
> rockchip,power-invert
>
i_hi6220_set_ios(struct dw_mci
>>> *host, struct mmc_ios *ios)
>>> host->bus_hz = clk_get_rate(host->biu_clk);
>>> }
>>>
>>> +static int dw_mci_hi6220_execute_tuning(struct dw_mci_slot *slot, u32
>>> opcode)
>>> +{
>&g
On 05/27/2017 06:53 AM, David Woods wrote:
> Using the device_property interfaces allows the dw_mmc driver to work
> on platforms which run on either device tree or ACPI.
>
> Signed-off-by: David Woods
> Reviewed-by: Chris Metcalf
> Cc: sta...@vger.linux.org
Acked-by: Ja
On 08/27/2015 09:26 PM, Krzysztof Kozlowski wrote:
> W dniu 27.08.2015 o 18:29, Jaehoon Chung pisze:
>> Currently vmmc's property is wrong.
>> If it needs to control two supplies, then it has to use vmmc/vqmmc-supply.
>> (Card supply power and I/O Line supply Power.)
&g
] mmc_host mmc1: Bus speed (slot 0) = 10000Hz (slot
> req 1Hz, actual 1HZ div = 0)
> [4.639820] mmc1: new ultra high speed SDR50 SDHC card at address
> [4.646266] mmcblk0: mmc1: SL32G 29.7 GiB
> [4.650293] IRQ56 no longer affine to CPU7
Sandisk Ultra UHS-I class 10 card support.
>> OdroidXU3/XU4 board would not boot up using this card.
>>
>> Depending on the capability of the UHS-I card, the speed of the card
>> is selected.
>> I have just added the enhance capability feature to support them.
>
>
rds"). Why? There is no explanation in
>>> the commit message about this.
>>
>> I don't remember to send the patch relevant to this. Hmm...
>> Well, Is this patch really signed-off by me?
>>
>> Best Regards,
>>
>> Jaehoon Chung
>>>
>
On 10/12/2015 10:16 PM, Krzysztof Kozlowski wrote:
> W dniu 12.10.2015 o 22:04, Jaehoon Chung pisze:
>> On 10/12/2015 09:42 PM, Krzysztof Kozlowski wrote:
>>> W dniu 12.10.2015 o 19:46, Anand Moon pisze:
>>>> Hi Krzysztof,
>>>>
>>>> On 12
g = <0 2>;
>>>>>>>> +vmmc-supply = <&ldo19_reg>;
>>>>>>>> +vqmmc-supply = <&ldo13_reg>;
>>>>>>>
>>>>>>> It looks wrong. LDO13 is used in one place as VQMMC and in other as
torage part of User manual, it described the overview.
Mobile storage host supports these specification:
- Secure Digital memory (SD memory version 3.0)
- Secure Digital I/O SDIO (SDIO version 3.0)
- etc...
SD3.0 is supported UHS-I mode.
If user manual of exynos5422 is mentioned this specificatio
= 5000Hz (slot
>>>>> req 5000Hz, actual 5000HZ div = 0)
>>>>> [4.001604] mmc1: new ultra high speed DDR50 SDHC card at address
>>>>> [4.00450
patch-set, ciu_drv and ciu_sample are controlled by clock
framework.
It's a little strange.
Are there ciu_drv and ciu_sample clock on Rockchip?
Best Regards,
Jaehoon Chung
>
> We do not touch ciu_drive (and by extension define default-drive-phase).
> Drive phase is mostly used to
eep_range(500, 1000);
Need to drain writebuffer at here?
I don't know why you choose those values..Just some margin?
And if you want to apply this, i recommend to use the shift with card number.
Best Regards,
Jaehoon Chung
> +}
> +
> static void dw_mci_init_ca
Dear, All.
I will apply patch 01-03 at my repository on today.
But i don't know better how i do about other patches relevant to config file.
Best Regards,
Jaehoon Chung
On 09/16/2015 03:40 PM, Shawn Lin wrote:
> Synopsys DesignWare mobile storage host controller supports three
&g
Hi, Shawn.
On 10/02/2015 06:49 PM, Shawn Lin wrote:
> On 2015/10/1 17:14, Jaehoon Chung wrote:
>> Dear, All.
>>
>> I will apply patch 01-03 at my repository on today.
>> But i don't know better how i do about other patches relevant to config file.
>>
>
&g
On 03/13/2018 01:53 PM, Jinbum Park wrote:
> To enable UBSAN on arm, ARCH_HAS_UBSAN_SANITIZE_ALL is needed to be selected.
>
> Basic test has passed on Raspberry Pi2, Raspbian jessi lite with
> CONFIG_UBSAN_SANITIZE_ALL, CONFIG_UBSAN_NULL.
>
> Signed-off-by: Jinbum Park
> ---
> arch/arm/Kconfig
gwoo.
https://patchwork.kernel.org/patch/9344477/
Best Regards,
Jaehoon Chung
>
> Signed-off-by: Jinbum Park
> ---
> arch/arm/Kconfig | 1 +
> arch/arm/boot/compressed/Makefile | 1 +
> arch/arm/vdso/Makefile| 1 +
> 3 files changed, 3 inserti
Dear Lorenzo,
On 03/13/2018 08:12 PM, Lorenzo Pieralisi wrote:
> Hi Jaehoon,
>
> On Thu, Dec 21, 2017 at 09:14:06PM +0900, Jaehoon Chung wrote:
>> PCI_EXYNOS has the dependency with SOC_EXYNOS5440.
>> It's modified to ARCH_EXYNOS from SOC_EXYNOS5440, because other
Add sd0_rst node to exynos5420-pinctrl.dtsi.
(It's used on odroid-xu3 board)
Signed-off-by: Jaehoon Chung
---
arch/arm/boot/dts/exynos5420-pinctrl.dtsi |5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
b/arch/arm/boot/dts/exyno
s
>> defined in that file, so i don't see the problem with including it in
>> that pinctrl file
>
> In that case I completely agree that it should be defined in the .dtsi
> but that is not what the commit message said though :-)
I will resend the patch with obvious commit m
8;
> + drto_ms = DIV_ROUND_UP(drto_clks, host->bus_hz / 1000);
> +
> + /* add a buffer */
> + drto_ms += 10;
Add a buffer? What means?
> +
> + return drto_ms;
> +}
dw_mci_set_drto() instead of dw_mci_get_drto_ms().
Then you can include the codes relevant to b
it's not
critical..
But there is much different between 2ms and 500ms(or 130ms).
Best Regards,
Jaehoon Chung
>
> Fixes: 5c935165da79 ("mmc: dw_mmc: Add a timeout for sending CMD11")
> Signed-off-by: Doug Anderson
> ---
> drivers/mmc/host/dw_mmc.c | 8 +---
&g
Hi, Doug.
On 04/07/2015 04:32 AM, Doug Anderson wrote:
> Jaehoon,
>
> On Mon, Apr 6, 2015 at 3:46 AM, Jaehoon Chung wrote:
>> Hi, Doug.
>>
>> On 04/04/2015 03:13 AM, Doug Anderson wrote:
>>> The Designware databook claims that cmd11 should be finished in 2ms
Hi Thomas,
I think not good that added the samsung specific code into dw_mmc-pltfm.c
How about separating to dw-mmc-exynos.c?
Best Regards,
Jaehoon Chung
On 07/12/2012 09:54 PM, Thomas Abraham wrote:
> This patch series adds device tree support for Synopsis Designware Mobile
> Storag
Hi, Pradu.
Sorry for late.
I will wait for your next version than i will check yours.
To Ulf.
Thanks for review!
Best Regards,
Jaehoon Chung
On 05/22/2015 10:21 PM, Ulf Hansson wrote:
> On 18 May 2015 at 16:23, Prabu Thangamuthu wrote:
>> Removing dw_mmc driver immediately after
patch??
>
> I'm currently testing out of tree, but my dw_mmc is very close to mainline.
>
>
>> Have not checked the dw TRM for this change, will do that as soon as I
>> get access to it.
>
> OK, sounds good. I have some old version of the DesignWare TRM,
Hi, Prabu.
Thanks for resending the patch.
Will apply this patch at my tree.
Thanks!
Best Regards,
Jaehoon Chung
On 05/28/2015 09:21 PM, Prabu Thangamuthu wrote:
> Remove module of dw_mmc driver will hung for eMMC devices if we follow the
> steps which are listed below,
>
amp; !div && host->max_clk <= 2500) {
> + div = 1;
> + }
I can't understand fully. how can it be broken for divider zero?
When formatting error is occurred, do you check really clock value?
I think your patch loo
Hi,
On 05/02/2018 03:19 AM, Liming Sun wrote:
> This commit adds extension to the dw_mmc driver for Mellanox BlueField
> SoC. It updates the UHS_REG_EXT register to bring up the eMMC card on
> this SoC.
Could you heck Shawn's comments? And add the minor comment.
>
> Cc: sta...@kernel.org
> Sign
ns.
> * Use timing field in each slot structure instead of common field in
>host structure.
> * Add locks to serialize access to registers.
Sorry for late. :(
Well, I will read the other comments..and reply soon.
Best Regards,
Jaehoon Chung
>
> NOTE: this patch is based off of v4.
hy: samsung: Add support for the Exynos5420 variant of
> the USB2 PHY")
> Signed-off-by: Marek Szyprowski
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> Vinod: this a fix to the patch merged yesterday. If you want me to resend
> a fixed initi
Hi, Felipe.
When you send the patch related with dw_mmc controller, could you use the
prefix "mmc: dw_mmc:"?
"mmc: dw_mmc: fix possible build error"
Acked-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
On 02/25/2014 11:57 PM, Felipe Balbi wrote:
> Fix the following bui
1 - 100 of 487 matches
Mail list logo
