Re: [RFC v3 36/45] NFSv4: Fix GETATTR bitmap verification

2015-05-28 Thread J. Bruce Fields
On Fri, Apr 24, 2015 at 01:04:33PM +0200, Andreas Gruenbacher wrote: > The NFSv4 client sends the server GETATTR requests with different sets of > requested attributes depending on the situation. The requested set of > attributes is encoded in a bitmap; the server replies with the set of > attribu

Re: [PATCH 1/1 linux-next] nfsd: use swap() in sort_pacl_range()

2015-06-16 Thread J. Bruce Fields
Applying, thanks.--b. On Fri, Jun 12, 2015 at 06:58:57PM +0200, Fabian Frederick wrote: > Use kernel.h macro definition. > > Thanks to Julia Lawall for Coccinelle scripting support. > > Signed-off-by: Fabian Frederick > --- > fs/nfsd/nfs4acl.c | 6 ++ > 1 file changed, 2 insertions(+), 4 d

Re: linux-next: unsigned patch on the top of the nfsd tree

2015-06-04 Thread J. Bruce Fields
On Thu, Jun 04, 2015 at 07:58:36AM +1000, Stephen Rothwell wrote: > I noticed that it appears that you have leaked an unsigned debugging > patch at the top of the nsfd tree today ... Whoops--thanks for catching that. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [RFC v3 43/45] uapi/nfs: Add NFSv4.1 ACL definitions

2015-05-29 Thread J. Bruce Fields
On Fri, Apr 24, 2015 at 01:04:40PM +0200, Andreas Gruenbacher wrote: > Add the ACL related protocol definitions which were added in the NFSv4.1 > specifiction. No harm in taking this now, I guess, I'll queue this one up for 4.2. --b. > > Signed-off-by: Andreas Gruenbacher > --- > include/uapi

Re: [PATCH 1/1 net-next] sunrpc: use sg_init_one() in krb5_rc4_setup_enc/seq_key()

2015-06-19 Thread J. Bruce Fields
Thanks, applying.--b. On Tue, Jun 16, 2015 at 09:57:52PM +0200, Fabian Frederick wrote: > Don't opencode sg_init_one() > > Signed-off-by: Fabian Frederick > --- > net/sunrpc/auth_gss/gss_krb5_crypto.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/net/sunrpc/a

[GIT PULL] nfsd changes for 4.17

2018-04-05 Thread J. Bruce Fields
coders Colin Ian King (1): lockd: make nlm_ntf_refcnt and nlm_ntf_wq static Eric Biggers (1): sunrpc: remove incorrect HMAC request initialization Fengguang Wu (1): nfsd: fix boolreturn.cocci warnings J. Bruce Fields (11): nfsd: remove unsused "cp_consecutive"

Re: NFS mounts failing when keytab present on client

2018-03-28 Thread J. Bruce Fields
On Tue, Mar 27, 2018 at 03:29:50PM -0700, Eric Biggers wrote: > Hi Michael, > > On Tue, Mar 27, 2018 at 11:06:14PM +0100, Michael Young wrote: > > NFS mounts stopped working on one of my computers after a kernel update from > > 4.15.3 to 4.15.4. I traced the problem to the commit > > [46e8d06e423c

Re: NFS mounts failing when keytab present on client

2018-03-28 Thread J. Bruce Fields
On Wed, Mar 28, 2018 at 10:50:51AM -0700, Eric Biggers wrote: > On Wed, Mar 28, 2018 at 11:46:28AM -0400, J. Bruce Fields wrote: > > On Tue, Mar 27, 2018 at 03:29:50PM -0700, Eric Biggers wrote: > > > Hi Michael, > > > > > > On Tue, Mar 27, 2018 at 1

Re: NFS mounts failing when keytab present on client

2018-03-28 Thread J. Bruce Fields
On Wed, Mar 28, 2018 at 02:03:34PM -0400, J. Bruce Fields wrote: > Thanks, got it. Do you know how to find a commit id for that change? > It's not entirely fair to blame the crypto change for what was really a > latent nfs bug, but it might still be worth adding a Fixes: line ju

Re: [PATCH 4.4 014/190] lockd: fix lockd shutdown race

2018-05-16 Thread J. Bruce Fields
On Tue, May 15, 2018 at 07:44:24PM +0100, Ben Hutchings wrote: > On Wed, 2018-04-11 at 20:34 +0200, Greg Kroah-Hartman wrote: > > 4.4-stable review patch.  If anyone has any objections, please let me know. > > > > ------ > > > > From: "J. B

[GIT PULL] nfsd bugfixes for 5.1

2019-04-23 Thread J. Bruce Fields
Please pull nfsd bugfixes from: git://linux-nfs.org/~bfields/linux.git tags/nfsd-5.1-1 Fix miscellaneous nfsd bugs, in NFSv4.1 callbacks, NFSv4.1 lock-notification callbacks, NFSv3 readdir encoding, and the cache/upcall code. --b. Jeff Layton (2): nfsd: wake waiters blocked on file_lock

[GIT PULL] nfsd changes for 5.1

2019-03-12 Thread J. Bruce Fields
warnings in work completion handlers Dan Carpenter (1): nfsd: fix an IS_ERR() vs NULL check Gustavo A. R. Silva (1): svcrdma: Use struct_size() in kmalloc() J. Bruce Fields (4): svcrpc: svc_xprt_has_something_to_do seems a little long svcrpc: fix unlikely races preventing

Re: [PATCH 3/7] kthreads: allow multiple kthreadd's

2019-03-12 Thread J. Bruce Fields
I'd like to try to get this in 5.2. Can anyone give me an ACK for the kthread parts? Or tell me who to ask? Let me know if I should resend. Or, of course, tell me if I've missed something and this is all a terrible idea. --b. On Fri, Feb 08, 2019 at 03:10:43PM -0500, J. Bruce Fi

Re: [PATCH 20/38] vfs: Convert nfsctl to fs_context

2019-03-14 Thread J. Bruce Fields
cc: "J. Bruce Fields" > cc: Jeff Layton > cc: linux-...@vger.kernel.org > --- > > fs/nfsd/nfsctl.c | 33 ++--- > 1 file changed, 26 insertions(+), 7 deletions(-) > > diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c > index f2feb2

Re: [PATCH v2 02/24] fs/locks: print full locks information

2021-02-24 Thread J. Bruce Fields
On Wed, Feb 24, 2021 at 03:35:44AM -0500, Luo Longjun wrote: > @@ -2912,17 +2922,66 @@ static int locks_show(struct seq_file *f, void *v) > struct file_lock *fl, *bfl; > struct pid_namespace *proc_pidns = > proc_pid_ns(file_inode(f->file)->i_sb); > > + struct list_head root; > +

Re: [PATCH] Repair misuse of sv_lock in 5.10.16-rt30.

2021-02-26 Thread J. Bruce Fields
Adding Chuck, linux-nfs. Makes sense to me.--b. On Fri, Feb 26, 2021 at 09:38:20AM -0500, Joe Korty wrote: > Repair misuse of sv_lock in 5.10.16-rt30. > > [ This problem is in mainline, but only rt has the chops to be > able to detect it. ] > > Lockdep reports a circular lock dependency between

Re: [PATCH] nfsd: Fix typo in comment

2020-08-20 Thread J. Bruce Fields
Applying, thanks.--b. On Mon, Aug 17, 2020 at 06:51:26PM +0100, Alex Dewar wrote: > Missing "is". > > Signed-off-by: Alex Dewar > --- > Ahh I see. Is this better? > --- > fs/nfsd/nfs4xdr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4

Re: [PATCH] SUNRPC: Output oversized frag reclen as ASCII if printable

2021-03-19 Thread J. Bruce Fields
that takes a number and > > outputs it in various formats is also a possible solution. For now, it > > seems reasonable to put this here since this particular code path is the > > one that has repeatedly come up in production. > > > > Signed-off-by: Chris Down > &g

Re: Linux 5.10.25

2021-03-22 Thread J. Bruce Fields
> > > > > > > Greg Kroah-Hartman wrote: > > > > > J. Bruce Fields (2): > > > > > Revert "nfsd4: remove check_conflicting_opens warning" > > > > > Revert "nfsd4: a client's own opens needn't prevent d

Re: [PATCH] fs/locks: print full locks information

2021-02-21 Thread J. Bruce Fields
On Sun, Feb 21, 2021 at 01:43:03PM -0500, Jeff Layton wrote: > On Sun, 2021-02-21 at 16:52 +, Al Viro wrote: > > On Sat, Feb 20, 2021 at 01:32:50AM -0500, Luo Longjun wrote: > > > + list_for_each_entry(bfl, &fl->fl_blocked_requests, fl_blocked_member) > > > + __locks_show(f, bfl, level

[GIT PULL] nfsd bugfix for 5.10

2020-11-18 Thread J. Bruce Fields
Please pull git://linux-nfs.org/~bfields/linux.git tags/nfsd-5.10-2 Just one quick fix for a tracing oops. --b. Scott Mayhew (1): SUNRPC: Fix oops in the rpc_xdr_buf event class include/trace/events/sunrpc.h | 3 ++- 1 f

Re: [PATCH] nfsd: Fix error return code in nfsd_file_cache_init()

2020-11-25 Thread J. Bruce Fields
On Wed, Nov 25, 2020 at 03:39:33AM -0500, Huang Guobin wrote: > Fix to return PTR_ERR() error code from the error handling case instead of > 0 in function nfsd_file_cache_init(), as done elsewhere in this function. > > Fixes: 65294c1f2c5e7("nfsd: add a new struct file caching facility to nfsd") >

Re: fscache: Redesigning the on-disk cache

2021-03-08 Thread J. Bruce Fields
On Mon, Mar 08, 2021 at 09:13:55AM +, David Howells wrote: > Amir Goldstein wrote: > > With ->fiemap() you can at least make the distinction between a non existing > > and an UNWRITTEN extent. > > I can't use that for XFS, Ext4 or btrfs, I suspect. Christoph and Dave's > assertion is that th

Re: [RFC][PATCH 00/25] Network fs helper library & fscache kiocb API

2021-01-21 Thread J. Bruce Fields
On Wed, Jan 20, 2021 at 10:21:24PM +, David Howells wrote: > Note that this uses SEEK_HOLE/SEEK_DATA to locate the data available > to be read from the cache. Whilst this is an improvement from the > bmap interface, it still has a problem with regard to a modern > extent-ba

Re: [RFC][PATCH 00/25] Network fs helper library & fscache kiocb API

2021-01-21 Thread J. Bruce Fields
On Thu, Jan 21, 2021 at 05:02:57PM +, David Howells wrote: > J. Bruce Fields wrote: > > > On Wed, Jan 20, 2021 at 10:21:24PM +, David Howells wrote: > > > Note that this uses SEEK_HOLE/SEEK_DATA to locate the data available > > > to be read from

Re: [RFC][PATCH 00/25] Network fs helper library & fscache kiocb API

2021-01-21 Thread J. Bruce Fields
On Thu, Jan 21, 2021 at 06:55:13PM +, David Howells wrote: > J. Bruce Fields wrote: > > > > Fixing this requires a much bigger overhaul of cachefiles than this > > > patchset > > > performs. > > > > That sounds like "sometimes you may get

Re: [RFC][PATCH 00/25] Network fs helper library & fscache kiocb API

2021-01-22 Thread J. Bruce Fields
On Thu, Jan 21, 2021 at 08:08:24PM +, David Howells wrote: > J. Bruce Fields wrote: > > So, I'm still confused: there must be some case where we know fscache > > actually works reliably and doesn't corrupt your data, right? > > Using ext2/3, for ex

Re: [PATCH 08/11] vfs: Merge check_submounts_and_drop and d_invalidate

2014-02-25 Thread J. Bruce Fields
On Mon, Feb 24, 2014 at 04:01:29PM -0800, Eric W. Biederman wrote: > Miklos Szeredi writes: > > > On Sat, Feb 15, 2014 at 01:39:22PM -0800, Eric W. Biederman wrote: > >> > >> Now that d_invalidate is the only caller of check_submounts_and_drop, > >> expand check_submounts_and_drop inline in d_in

Re: [PATCH 08/11] vfs: Merge check_submounts_and_drop and d_invalidate

2014-02-26 Thread J. Bruce Fields
On Tue, Feb 25, 2014 at 02:03:36PM -0800, Eric W. Biederman wrote: > "J. Bruce Fields" writes: > > > On Mon, Feb 24, 2014 at 04:01:29PM -0800, Eric W. Biederman wrote: > >> Miklos Szeredi writes: > >> > >> > > >> > You ca

Re: [PATCH 13/13] net: Mark functions as static in net/sunrpc/svc_xprt.c

2014-02-11 Thread J. Bruce Fields
On Sun, Feb 09, 2014 at 01:40:54AM +0530, Rashika Kheria wrote: > Mark functions as static in net/sunrpc/svc_xprt.c because they are not > used outside this file. > > This eliminates the following warning in net/sunrpc/svc_xprt.c: > net/sunrpc/svc_xprt.c:574:5: warning: no previous prototype for

[PATCH] nfsd4: fix acl buffer overrun

2014-02-11 Thread J. Bruce Fields
From: "J. Bruce Fields" 4ac7249ea5a0ceef9f8269f63f33cc873c3fac61 "nfsd: use get_acl and ->set_acl" forgets to set the size in the case get_acl() succeeds, so _posix_to_nfsv4_one() can then write past the end of its allocation. Symptoms were slab corruption warnings. A

Re: [PATCH] nfsd4: fix acl buffer overrun

2014-02-11 Thread J. Bruce Fields
On Tue, Feb 11, 2014 at 12:25:48PM -0800, Christoph Hellwig wrote: > Looks good and sorry for the regression. Well, my fault for not reviewing the patch, I saw it and didn't give it more than a skim. Not sure I would have caught that, though. The only thing I can think of that might have made it

Re: [PATCH 00/13] cross rename v4

2014-02-13 Thread J. Bruce Fields
On Tue, Feb 11, 2014 at 04:57:44PM +0100, Miklos Szeredi wrote: > On Fri, Feb 07, 2014 at 05:46:30PM -0500, J. Bruce Fields wrote: > > > > Bruce, could you please review the locking and delegation thing in patch > > > #8 > > > "vfs: add cross-rename"?

Re: [PATCH] NFSD, lost nfserrno() call in nfsd_setattr()

2014-02-18 Thread J. Bruce Fields
On Wed, Feb 19, 2014 at 12:27:53AM +0900, J. R. Okajima wrote: > > There is a regression in > 208d0ac 2014-01-07 nfsd4: break only delegations when appropriate > which deletes an nfserrno() call in nfsd_setattr() (by accident, > probably), and NFSD becomes ignoring an error from VFS. > > He

Re: [PATCH] nfsd: check passed socket's net matches NFSd superblock's one

2014-02-19 Thread J. Bruce Fields
On Wed, Feb 19, 2014 at 02:26:33PM +0400, Stanislav Kinsbursky wrote: > 18.02.2014 19:44, J. Bruce Fields пишет: > >On Tue, Feb 18, 2014 at 07:19:31PM +0400, Stanislav Kinsbursky wrote: > >>18.02.2014 02:19, J. Bruce Fields пишет: > >>>On Sat, Feb 15, 2014 at 09:51:

Re: [PATCH] nfsd: check passed socket's net matches NFSd superblock's one

2014-02-20 Thread J. Bruce Fields
On Wed, Feb 19, 2014 at 06:57:46PM +0400, Stanislav Kinsbursky wrote: > 19.02.2014 18:50, J. Bruce Fields пишет: > >On Wed, Feb 19, 2014 at 02:26:33PM +0400, Stanislav Kinsbursky wrote: > >>18.02.2014 19:44, J. Bruce Fields пишет: > >>>On Tue, Feb 18, 2014 at 07:19:31

Re: [PATCH] gss_krb5: use lcm from kernel lib

2014-01-22 Thread J. Bruce Fields
On Sun, Jan 19, 2014 at 09:50:51PM +, Luis Henriques wrote: > Replace hardcoded lowest common multiple algorithm by the lcm() > function in kernel lib. Looks OK to me. Applying for 3.14 if Trond hasn't already picked it up. --b. > > Signed-off-by: Luis Henriques > --- > net/sunrpc/auth_g

Re: [PATCH] SUNRPC: Allow one callback request to be received from two sk_buff

2014-01-22 Thread J. Bruce Fields
On Tue, Jan 21, 2014 at 08:35:36AM -0700, Trond Myklebust wrote: > > On Jan 21, 2014, at 3:08, shaobingqing wrote: > > > 2014/1/21 Trond Myklebust : > >> On Mon, 2014-01-20 at 14:59 +0800, shaobingqing wrote: > >>> In current code, there only one struct rpc_rqst is prealloced. If one > >>> callb

[PATCH] dcache: make d_splice_alias use d_materialise_unique

2014-01-23 Thread J. Bruce Fields
From: "J. Bruce Fields" d_splice_alias can create duplicate directory aliases (in the !new case), or (in the new case) d_move directories without holding appropriate locks. d_materialise_unique deals with both of these problems. (The latter seems to be dealt by trylocks (see _

Re: linux-3.14 nfsd regression

2014-04-03 Thread J. Bruce Fields
On Thu, Apr 03, 2014 at 12:33:55PM -0400, Mark Lord wrote: > This commit from linux-3.14 breaks our NFS-root clients here: > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=6e14b46b91fee8a049b0940333ce13a820beaaa5 > > > - *p++ = htonl((u32) stat->mode); > + *p++ = ht

Re: linux-3.14 nfsd regression

2014-04-03 Thread J. Bruce Fields
On Thu, Apr 03, 2014 at 01:51:06PM -0400, Mark Lord wrote: > On 14-04-03 01:16 PM, J. Bruce Fields wrote: > > On Thu, Apr 03, 2014 at 12:33:55PM -0400, Mark Lord wrote: > >> This commit from linux-3.14 breaks our NFS-root clients here: > >> > >> https://

Re: linux-3.14 nfsd regression

2014-04-03 Thread J. Bruce Fields
On Thu, Apr 03, 2014 at 03:30:24PM -0400, J. Bruce Fields wrote: > On Thu, Apr 03, 2014 at 01:51:06PM -0400, Mark Lord wrote: > > On 14-04-03 01:16 PM, J. Bruce Fields wrote: > > > On Thu, Apr 03, 2014 at 12:33:55PM -0400, Mark Lord wrote: > > >> This commit from

Re: linux-3.14 nfsd regression

2014-04-03 Thread J. Bruce Fields
On Thu, Apr 03, 2014 at 01:51:06PM -0400, Mark Lord wrote: > On 14-04-03 01:16 PM, J. Bruce Fields wrote: > > The original behavior was in practice harmless and changing it broke > > something, so I think we should definitely just revert this patch. > > Yup. Who? I'

Re: linux-3.14 nfsd regression

2014-04-03 Thread J. Bruce Fields
On Thu, Apr 03, 2014 at 02:55:04PM -0400, Jeff Layton wrote: > On Thu, 03 Apr 2014 13:51:06 -0400 > Mark Lord wrote: > > > On 14-04-03 01:16 PM, J. Bruce Fields wrote: > > > On Thu, Apr 03, 2014 at 12:33:55PM -0400, Mark Lord wrote: > > >> This commit from li

Re: linux-3.14 nfsd regression

2014-04-03 Thread J. Bruce Fields
On Thu, Apr 03, 2014 at 04:48:11PM -0400, Mark Lord wrote: > On 14-04-03 03:30 PM, J. Bruce Fields wrote: > > On Thu, Apr 03, 2014 at 01:51:06PM -0400, Mark Lord wrote: > >> On 14-04-03 01:16 PM, J. Bruce Fields wrote: > >>> On Thu, Apr 03, 2014 at 12:33:55PM -0400

Re: linux-3.14 nfsd regression

2014-04-04 Thread J. Bruce Fields
the client v2 decode_fattr function to > throw a warning if the server sends us mismatched type bits and ftype > values. That would have helped us catch this sooner... Yes, that might be a reasonable thing to do, though I don't know if it's worth it. --b. commit 35a8dff14e76c00

Re: [PATCH v5 13/14] locks: skip deadlock detection on FL_FILE_PVT locks

2014-01-14 Thread J. Bruce Fields
On Thu, Jan 09, 2014 at 04:58:59PM -0800, Andy Lutomirski wrote: > On Thu, Jan 9, 2014 at 4:49 PM, Jeff Layton wrote: > > On Thu, 09 Jan 2014 12:25:25 -0800 > > Andy Lutomirski wrote: > >> When I think of deadlocks caused by r/w locks (which these are), I think > >> of two kinds. First is what t

Re: [PATCH v5 13/14] locks: skip deadlock detection on FL_FILE_PVT locks

2014-01-14 Thread J. Bruce Fields
On Tue, Jan 14, 2014 at 12:29:17PM -0800, Andy Lutomirski wrote: > [cc: drh, who I suspect is responsible for the most widespread > userspace software that uses this stuff] > > On Tue, Jan 14, 2014 at 11:27 AM, J. Bruce Fields > wrote: > > On Thu, Jan 09, 2014 at 0

Re: [PATCH v5 13/14] locks: skip deadlock detection on FL_FILE_PVT locks

2014-01-14 Thread J. Bruce Fields
On Tue, Jan 14, 2014 at 01:17:20PM -0800, Andy Lutomirski wrote: > On Tue, Jan 14, 2014 at 1:10 PM, J. Bruce Fields wrote: > > On Tue, Jan 14, 2014 at 12:29:17PM -0800, Andy Lutomirski wrote: > >> [cc: drh, who I suspect is responsible for the most widespread > >> u

Re: [PATCH v5 13/14] locks: skip deadlock detection on FL_FILE_PVT locks

2014-01-14 Thread J. Bruce Fields
t; > userspace software that uses this stuff] > >> > > >> > On Tue, Jan 14, 2014 at 11:27 AM, J. Bruce Fields > >> wrote: > >> > > On Thu, Jan 09, 2014 at 04:58:59PM -0800, Andy Lutomirski wrote: > >> > >> On Thu, Jan 9, 20

Re: [PATCH v5 13/14] locks: skip deadlock detection on FL_FILE_PVT locks

2014-01-14 Thread J. Bruce Fields
On Tue, Jan 14, 2014 at 04:21:53PM -0500, Richard Hipp wrote: > SQLite uses only F_SETLK, never F_SETLKW. Doesn't that mean that SQLite > will work the same with or without deadlock detection? Doesn't deadlock > detection only come into play with F_SETLKW? That's correct. > > >> (Actually, what

Re: [PATCH v5 13/14] locks: skip deadlock detection on FL_FILE_PVT locks

2014-01-14 Thread J. Bruce Fields
On Tue, Jan 14, 2014 at 01:26:26PM -0800, Andy Lutomirski wrote: > [grr, gmail -- I didn't actually intend to send that.] > > On Tue, Jan 14, 2014 at 1:24 PM, Andy Lutomirski wrote: > > On Tue, Jan 14, 2014 at 1:19 PM, Frank Filz wrote: > >>> process 2 requests a write lock, gets -EDEADLK,

[PATCH] dcache: fix d_splice_alias handling of aliases

2014-01-15 Thread J. Bruce Fields
From: "J. Bruce Fields" d_splice_alias can create duplicate directory aliases (in the !new case), or (in the new case) d_move without holding appropriate locks. d_materialise_unique deals with both of these problems. (The latter seems to be dealt by trylocks (see __d_unalias), which

Re: [PATCH] dcache: fix d_splice_alias handling of aliases

2014-01-15 Thread J. Bruce Fields
On Wed, Jan 15, 2014 at 06:34:56PM +0100, Miklos Szeredi wrote: > On Wed, 2014-01-15 at 10:17 -0500, J. Bruce Fields wrote: > > From: "J. Bruce Fields" > > > > d_splice_alias can create duplicate directory aliases (in the !new > > case), or (in the new cas

Re: [PATCH 11/11] ext4: add cross rename support

2014-01-15 Thread J. Bruce Fields
On Mon, Jan 13, 2014 at 01:25:17PM +0100, Jan Kara wrote: > I think this deserves a comment that RENAME_EXCHANGE expects both source > and target to exist... I'm always pondering about this condition before I > realize that. Do you have a man page update somewhere for the two new flags? --b. --

Re: [PATCH 05/11] vfs: add RENAME_NOREPLACE flag

2014-01-15 Thread J. Bruce Fields
On Wed, Jan 08, 2014 at 11:10:09PM +0100, Miklos Szeredi wrote: > From: Miklos Szeredi > > If this flag is specified and the target of the rename exists then the > rename syscall fails with EEXIST. Why is this useful? (I'm sure it is, it'd just be useful to have the reasons recorded someplace.)

Re: Why is O_DSYNC on linux so slow / what's wrong with my SSD?

2013-11-20 Thread J. Bruce Fields
On Wed, Nov 20, 2013 at 10:37:03AM -0500, Theodore Ts'o wrote: > On Wed, Nov 20, 2013 at 08:52:36PM +0530, Chinmay V S wrote: > > > > If you have confirmed the performance numbers, then it indicates that > > the Intel 530 controller is more advanced and makes better use of the > > internal disk-ca

Re: Why is O_DSYNC on linux so slow / what's wrong with my SSD?

2013-11-20 Thread J. Bruce Fields
On Wed, Nov 20, 2013 at 10:41:54PM +0530, Chinmay V S wrote: > On Wed, Nov 20, 2013 at 9:25 PM, J. Bruce Fields wrote: > > Some SSD's are also claim the ability to flush the cache on power loss: > > > > > > http://www.intel.com/content/www/us/en/solid-s

Re: [RFC PATCH v2 4/5] locks: show private lock types in /proc/locks

2013-11-20 Thread J. Bruce Fields
On Wed, Nov 20, 2013 at 03:00:56PM -0500, bfields wrote: > On Wed, Nov 20, 2013 at 11:45:05AM -0500, Jeff Layton wrote: > > Show "private" locks in /proc/locks with a 'P' suffix. This does mean > > that we need to widen the column by one character. > > > > Also, tighten up the check in locks_remov

Re: [RFC PATCH 0/5] locks: implement "filp-private" (aka UNPOSIX) locks

2013-10-11 Thread J. Bruce Fields
On Fri, Oct 11, 2013 at 08:25:17AM -0400, Jeff Layton wrote: > At LSF this year, there was a discussion about the "wishlist" for > userland file servers. One of the things brought up was the goofy and > problematic behavior of POSIX locks when a file is closed. Boaz started > a thread on it here: >

Re: [PATCH] sunrpc: fix some typos

2013-12-02 Thread J. Bruce Fields
Thanks, applying.--b. On Sat, Nov 30, 2013 at 05:56:44PM +0800, Weng Meiling wrote: > > From: Weng Meiling > > Signed-off-by: Weng Meiling > --- > include/linux/sunrpc/svc.h | 2 +- > net/sunrpc/xprtsock.c | 7 +++ > 2 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/

[GIT PULL] nfsd reply cache bugfix

2013-12-12 Thread J. Bruce Fields
Please pull one bugfix for nfsd crashes from git://linux-nfs.org/~bfields/linux.git for-3.13 --b. Jeff Layton (1): nfsd: when reusing an existing repcache entry, unhash it first fs/nfsd/nfscache.c |9 - 1 file

Re: [PATCH] nfsd: silence sparse warning about accessing credentials

2014-07-17 Thread J. Bruce Fields
On Tue, Jul 15, 2014 at 12:59:36PM -0400, Jeff Layton wrote: > sparse says: > > fs/nfsd/auth.c:31:38: warning: incorrect type in argument 1 (different > address spaces) > fs/nfsd/auth.c:31:38:expected struct cred const *cred > fs/nfsd/auth.c:31:38:got struct cred const [nodere

nfsd bug fixes for 3.15

2014-04-23 Thread J. Bruce Fields
f vfs delegation support. --b. ---- J. Bruce Fields (1): Revert "nfsd4: fix nfs4err_resource in 4.1 case" Jeff Layton (2): locks: allow __break_lease to sleep even when break_time is 0 nfsd: set timepar

Re: nfsd bug fixes for 3.15

2014-04-24 Thread J. Bruce Fields
On Thu, Apr 24, 2014 at 06:51:03AM -0400, Trond Myklebust wrote: > Hi Bruce, > > On Thu, Apr 24, 2014 at 2:25 AM, J. Bruce Fields wrote: > > Please pull the following bug fixes for 3.15 from: > > > > git://linux-nfs.org/~bfields/linux.git for-3.15 > > > &g

Re: nfsd bug fixes for 3.15

2014-04-24 Thread J. Bruce Fields
On Thu, Apr 24, 2014 at 11:31:16AM -0400, J. Bruce Fields wrote: > On Thu, Apr 24, 2014 at 06:51:03AM -0400, Trond Myklebust wrote: > > Hi Bruce, > > > > On Thu, Apr 24, 2014 at 2:25 AM, J. Bruce Fields > > wrote: > > > Please pull the following bug fi

Re: VFS tree for 3.17?

2014-07-30 Thread J. Bruce Fields
On Thu, Jul 24, 2014 at 08:30:57AM -0700, Christoph Hellwig wrote: > I've pushed out the current queue to: > > git://git.infradead.org/users/hch/vfs.git vfs-for-3.17 > > Stephen, can you include this in linux-next for testing? I plan to > send the first two patches to Linus on Saturday as they s

Re: [PATCH 05/11] vfs: add RENAME_NOREPLACE flag

2014-01-15 Thread J. Bruce Fields
On Wed, Jan 15, 2014 at 07:35:04PM +0100, Miklos Szeredi wrote: > On Wed, Jan 15, 2014 at 7:19 PM, J. Bruce Fields wrote: > > On Wed, Jan 08, 2014 at 11:10:09PM +0100, Miklos Szeredi wrote: > >> From: Miklos Szeredi > >> > >> If this flag is specified and the

Re: [PATCH 05/11] vfs: add RENAME_NOREPLACE flag

2014-01-15 Thread J. Bruce Fields
On Wed, Jan 15, 2014 at 10:26:23AM -0800, Andy Lutomirski wrote: > On Wed, Jan 15, 2014 at 10:19 AM, J. Bruce Fields > wrote: > > On Wed, Jan 08, 2014 at 11:10:09PM +0100, Miklos Szeredi wrote: > >> From: Miklos Szeredi > >> > >> If this flag is specif

Re: [PATCH 11/11] ext4: add cross rename support

2014-01-16 Thread J. Bruce Fields
On Thu, Jan 16, 2014 at 11:54:06AM +0100, Miklos Szeredi wrote: > > On Wed, Jan 15, 2014 at 7:23 PM, J. Bruce Fields > > wrote: > > > Do you have a man page update somewhere for the two new flags? > > Here's the updated man page (and attached the patch

Re: [PATCH] dcache: fix d_splice_alias handling of aliases

2014-01-16 Thread J. Bruce Fields
On Wed, Jan 15, 2014 at 07:25:11PM +0100, Miklos Szeredi wrote: > On Wed, Jan 15, 2014 at 6:57 PM, J. Bruce Fields wrote: > > On Wed, Jan 15, 2014 at 06:34:56PM +0100, Miklos Szeredi wrote: > >> On Wed, 2014-01-15 at 10:17 -0500, J. Bruce Fields wrote: > >&g

Re: [PATCH] dcache: fix d_splice_alias handling of aliases

2014-01-16 Thread J. Bruce Fields
On Wed, Jan 15, 2014 at 10:17:49AM -0500, bfields wrote: > From: "J. Bruce Fields" > > d_splice_alias can create duplicate directory aliases (in the !new > case), or (in the new case) d_move without holding appropriate locks. > > d_materialise_unique deals with b

Re: [PATCH] dcache: fix d_splice_alias handling of aliases

2014-01-16 Thread J. Bruce Fields
On Thu, Jan 16, 2014 at 04:15:42PM +, Steven Whitehouse wrote: > Hi, > > On Thu, 2014-01-16 at 11:10 -0500, J. Bruce Fields wrote: > > On Wed, Jan 15, 2014 at 10:17:49AM -0500, bfields wrote: > > > From: "J. Bruce Fields" > > > > > > d_spl

Re: [PATCH] dcache: fix d_splice_alias handling of aliases

2014-01-16 Thread J. Bruce Fields
" I guess. This is what I've got for what it's worth. --b. commit 6fba5295019b52a03d76c9e9570952466051a7a6 Author: J. Bruce Fields Date: Thu Jan 16 11:44:53 2014 -0500 gfs2: revert "GFS2: d_splice_alias() can't return error" 0d0d110720d7960b77c03c9f2597

Re: [PATCH] dcache: fix d_splice_alias handling of aliases

2014-01-17 Thread J. Bruce Fields
On Fri, Jan 17, 2014 at 04:17:23AM -0800, Christoph Hellwig wrote: > On Wed, Jan 15, 2014 at 10:17:49AM -0500, J. Bruce Fields wrote: > > From: "J. Bruce Fields" > > > > d_splice_alias can create duplicate directory aliases (in the !new > > case), or (in

Re: [PATCH] dcache: fix d_splice_alias handling of aliases

2014-01-17 Thread J. Bruce Fields
On Fri, Jan 17, 2014 at 10:04:30AM +, Steven Whitehouse wrote: > Hi, > > On Thu, 2014-01-16 at 13:51 -0500, J. Bruce Fields wrote: > > On Thu, Jan 16, 2014 at 11:54:07AM -0500, Bob Peterson wrote: > > > - Original Message - > > > | Something like thi

Re: [PATCH] dcache: fix d_splice_alias handling of aliases

2014-01-17 Thread J. Bruce Fields
On Fri, Jan 17, 2014 at 10:39:17AM -0500, J. Bruce Fields wrote: > On Fri, Jan 17, 2014 at 04:17:23AM -0800, Christoph Hellwig wrote: > > Also the inode == NULL case really should be split out from > > d_materialise_unique into a separate helper. It shares almost no > &

Re: [PATCH] dcache: fix d_splice_alias handling of aliases

2014-01-17 Thread J. Bruce Fields
On Fri, Jan 17, 2014 at 04:03:43PM -0500, J. Bruce Fields wrote: > - d_splice_alias handles inode == NULL in the same way, Actually, not exactly; simplifying a bit, in the NULL case they do: d_splice_alias: __d_instantiate(dentry, N

Re: [PATCH 11/11] ext4: add cross rename support

2014-01-17 Thread J. Bruce Fields
On Fri, Jan 17, 2014 at 11:53:07PM +1300, Michael Kerrisk (man-pages) wrote: > Hi Miklos, > > A few comments below, including one piece in the code that really must be > fixed. > > On 01/16/2014 11:54 PM, Miklos Szeredi wrote: > >> On Wed, Jan 15, 2014 at 7:23 PM, J

Re: [PATCH 11/11] ext4: add cross rename support

2014-01-18 Thread J. Bruce Fields
On Sat, Jan 18, 2014 at 07:49:29AM +0100, Miklos Szeredi wrote: > On Fri, Jan 17, 2014 at 11:08 PM, J. Bruce Fields > wrote: > > On Fri, Jan 17, 2014 at 11:53:07PM +1300, Michael Kerrisk (man-pages) wrote: > >> >The following additional errors a

Re: [RFC PATCH 01/12] locks: add a new struct file_locking_context pointer to struct inode

2014-09-10 Thread J. Bruce Fields
On Wed, Sep 10, 2014 at 10:28:39AM -0400, Jeff Layton wrote: > The current scheme of using the i_flock list is really difficult to > manage. Start conversion to a new scheme to eventually replace it. > > We start by adding a new i_flctx to struct inode. For now, it lives in > parallel with i_flock

Re: [RFC PATCH 08/12] nfs: convert lock handling to use file_lock_context

2014-09-10 Thread J. Bruce Fields
On Wed, Sep 10, 2014 at 10:28:46AM -0400, Jeff Layton wrote: > Signed-off-by: Jeff Layton > --- > fs/nfs/delegation.c | 37 + > fs/nfs/nfs4state.c | 24 +++- > fs/nfs/pagelist.c | 3 ++- > fs/nfs/write.c | 39 +++

Re: [RFC PATCH 08/12] nfs: convert lock handling to use file_lock_context

2014-09-10 Thread J. Bruce Fields
On Wed, Sep 10, 2014 at 03:28:10PM -0400, Jeff Layton wrote: > Yes, that's the downside of moving to multiple list_heads. Still, I > think it's worth doing that even if we end up with the code a bit more > verbose. > > It may be best to consider moving some of this into helpers that live > in lock

Re: nfsd bug fixes for 3.15

2014-04-25 Thread J. Bruce Fields
On Thu, Apr 24, 2014 at 12:46:36PM -0400, Trond Myklebust wrote: > On Thu, Apr 24, 2014 at 12:34 PM, J. Bruce Fields > wrote: > > On Thu, Apr 24, 2014 at 11:31:16AM -0400, J. Bruce Fields wrote: > >> On Thu, Apr 24, 2014 at 06:51:03AM -0400, Trond Myklebust w

Re: [GIT PULL] please pull file locking changes for v3.15 (pile #2)

2014-04-25 Thread J. Bruce Fields
On Thu, Apr 24, 2014 at 07:45:57AM -0400, Jeff Layton wrote: > > The following changes since commit 55101e2d6ce1c780f6ee8fee5f37306971aac6cd: > > Merge git://git.kernel.org/pub/scm/virt/kvm/kvm (2014-04-14 16:21:28 -0700) > > are available in the git repository at: > > > git://git.samba.or

Re: [GIT PULL] please pull file locking changes for v3.15 (pile #2)

2014-04-25 Thread J. Bruce Fields
On Fri, Apr 25, 2014 at 05:57:39AM -0400, J. Bruce Fields wrote: > On Thu, Apr 24, 2014 at 07:45:57AM -0400, Jeff Layton wrote: > > > > The following changes since commit 55101e2d6ce1c780f6ee8fee5f37306971aac6cd: > > > > Merge git://git.kernel.org/pub/scm/virt/k

Re: [GIT PULL] please pull file locking changes for v3.15 (pile #2)

2014-04-26 Thread J. Bruce Fields
On Fri, Apr 25, 2014 at 06:39:18AM -0400, Jeff Layton wrote: > On Fri, 25 Apr 2014 05:57:39 -0400 > "J. Bruce Fields" wrote: > > > On Thu, Apr 24, 2014 at 07:45:57AM -0400, Jeff Layton wrote: > > > > > > The following changes since commit >

[GIT PULL] nfsd bugfixes for 3.14

2014-02-13 Thread J. Bruce Fields
Please pull two nfsd bugfixes for 3.14: git://linux-nfs.org/~bfields/linux.git for-3.14 --b. J. Bruce Fields (1): nfsd4: fix acl buffer overrun NeilBrown (1): lockd: send correct lock when granting a delayed lock

Re: [PATCH] nfsd: check passed socket's net matches NFSd superblock's one

2014-02-17 Thread J. Bruce Fields
fsd to fail? No network namespaces should be involved. I haven't investigated any further. --b. > > Thanks! > Weng Meiling > > > On 2014/1/4 6:22, J. Bruce Fields wrote: > > On Mon, Dec 30, 2013 at 05:23:59PM +0300, Stanislav Kinsbursky wrote: > >> The

Re: [PATCH] nfsd: check passed socket's net matches NFSd superblock's one

2014-02-18 Thread J. Bruce Fields
On Tue, Feb 18, 2014 at 07:19:31PM +0400, Stanislav Kinsbursky wrote: > 18.02.2014 02:19, J. Bruce Fields пишет: > >On Sat, Feb 15, 2014 at 09:51:20AM +0800, Weng Meiling wrote: > >>Hi Bruce, > >> > >>The upstream has merged your git tree for-3.14, but there

Re: linux-3.14 nfsd regression

2014-05-01 Thread J. Bruce Fields
On Thu, May 01, 2014 at 07:50:34AM -0400, Mark Lord wrote: > Still a regression in 3.14.2 now. > Anyone got plans to push this patch out to mainline, as well as +stable ? This is upstream as 082f31a2169bd639785e45bf252f3d5bce0303c6 "nfsd: revert v2 half of "nfsd: don't return high mode bits"", wit

Re: [PATCH] lockd: avoid warning when CONFIG_SYSCTL undefined

2014-05-04 Thread J. Bruce Fields
On Thu, May 01, 2014 at 02:15:02PM -0700, Kees Cook wrote: > When building without CONFIG_SYSCTL, the compiler saw an unused > label. This moves the label into the #ifdef it is used under. Thanks, applying. --b. > > fs/lockd/svc.c: In function ‘init_nlm’: > fs/lockd/svc.c:626:1: warning: label

nfsd bug fixes for 3.15, part 2

2014-05-09 Thread J. Bruce Fields
Please pull some nfsd bugfixes for 3.15: git://linux-nfs.org/~bfields/linux.git for-3.15 --b. Kinglong Mee (1): NFSD: Call ->set_acl with a NULL ACL structure if no entries Trond Myklebust (2): NFSd: Move default ini

nfsd fix for 3.14

2014-03-25 Thread J. Bruce Fields
Please pull an nfsd fix from git://linux-nfs.org/~bfields/linux.git nfsd-next J. R. Okajima sent this early and I was just slow to pass it along, apologies. Fortunately it's a simple fix. --b. J. R. Okajima (1): nfsd: fix

Re: [PATCH] NFSD, lost nfserrno() call in nfsd_setattr()

2014-03-25 Thread J. Bruce Fields
On Tue, Mar 25, 2014 at 05:19:02PM +0900, J. R. Okajima wrote: > > "J. Bruce Fields": > > On Wed, Feb 19, 2014 at 12:27:53AM +0900, J. R. Okajima wrote: > > > > > > There is a regression in > > > 208d0ac 2014-01-07 nfsd4: break only delegations

Re: relative objtree change broke tar builds?

2014-06-18 Thread J. Bruce Fields
On Wed, Jun 18, 2014 at 11:06:12AM +0200, Michal Marek wrote: > Dne 18.6.2014 00:38, J. Bruce Fields napsal(a): > > The scripts I use for my kernel testing rely on the targz-pkg make > > target. After updating to 3.16-rc1 my scripts started failing. In > > scr

Re: relative objtree change broke tar builds?

2014-06-18 Thread J. Bruce Fields
On Wed, Jun 18, 2014 at 02:33:22PM +0200, Michal Marek wrote: > Dne 18.6.2014 14:20, J. Bruce Fields napsal(a): > > On Wed, Jun 18, 2014 at 11:06:12AM +0200, Michal Marek wrote: > >> Dne 18.6.2014 00:38, J. Bruce Fields napsal(a): > >>> The changelog there says > &

Re: [PATCH] kbuild: Fix tar-pkg with relative $(objtree)

2014-06-18 Thread J. Bruce Fields
mand and not for the whole script, which at one point references the > now relative $(objtree). Works for me, thanks.--b. > > Reported-by: "J. Bruce Fields" > Signed-off-by: Michal Marek > --- > scripts/package/buildtar | 3 +-- > 1 file changed, 1 insertion(+

bugfixes for 3.16

2014-06-19 Thread J. Bruce Fields
Please pull bugfixes for 3.16 from git://linux-nfs.org/~bfields/linux.git for-3.16 Fixes for a new regression from the xdr encoding rewrite, and a delegation problem we've had for a while (made somewhat more annoying by the vfs delegation support added in 3.13.) --b. -

nfsd bugfix for 3.16

2014-07-11 Thread J. Bruce Fields
Please pull another nfsd bugfix from git://linux-nfs.org/~bfields/linux.git for-3.16 Another xdr encoding regression that may cause incorrect encoding on failures of certain readdirs. --b. Kinglong Mee (1): nfsd: Fix bad r

<    4   5   6   7   8   9   10   11   12   13   >