Re: [PATCH] nfsd: prevent NULL ptr derefs on fault injection

2012-11-27 Thread J. Bruce Fields
On Tue, Nov 27, 2012 at 11:31:11AM -0500, Sasha Levin wrote: > A recent patch series has moved hashtable initialization to when the net > struct is initialized. > > When injecting faults, we tried accessing the hashtables even if the struct > wasn't really initialized (nfsd wasn't in use) - this c

Re: [PATCH] nfsd4: remove state lock from nfs4_state_shutdown

2012-11-27 Thread J. Bruce Fields
OK, applying.--b. On Wed, Nov 21, 2012 at 06:07:38PM +0300, Stanislav Kinsbursky wrote: > Protection of __nfs4_state_shutdown() with nfs4_lock_state() looks redundant. > > This function is called by the last NFSd thread on it's exit and state lock > protects actually two functions (del_recall_lru

Re: [PATCH 0/5] nfsd: more NFSv4 state containerization

2012-11-27 Thread J. Bruce Fields
On Mon, Nov 26, 2012 at 03:21:49PM +0300, Stanislav Kinsbursky wrote: > This patch set makes NFSv4 state created and destroyed per net and thus > completes it's containerization (the only exceprtion is client_mutex, but this > one a hard nut to crack). > > Note: patch set depend on previously sent

Re: [PATCH 0/2] nfsd: containerise NFSv4 recovery state

2012-11-28 Thread J. Bruce Fields
On Mon, Nov 26, 2012 at 04:16:18PM +0300, Stanislav Kinsbursky wrote: > This patch set makes rec_file and in_grace global static variables allocated > per network namespace. > Both of them are a part of client tracking engine, which is containerised > already. Thanks, applying for 3.8.--b. > > T

Re: [PATCH 1/2] nfsd: make NFSv4 lease time per net

2012-11-28 Thread J. Bruce Fields
On Tue, Nov 27, 2012 at 02:11:44PM +0300, Stanislav Kinsbursky wrote: > diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c > index dab350d..4930981 100644 > --- a/fs/nfsd/nfsctl.c > +++ b/fs/nfsd/nfsctl.c > @@ -912,7 +912,8 @@ static ssize_t nfsd4_write_time(struct file *file, char > *buf, size_t si

Re: [PATCH 2/2] nfsd: make NFSv4 grace time per net

2012-11-28 Thread J. Bruce Fields
On Tue, Nov 27, 2012 at 02:11:49PM +0300, Stanislav Kinsbursky wrote: > diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c > index 4930981..7e41bd1 100644 > --- a/fs/nfsd/nfsctl.c > +++ b/fs/nfsd/nfsctl.c > @@ -928,7 +928,8 @@ static ssize_t write_leasetime(struct file *file, char > *buf, size_t siz

Re: [PATCH] nfsd: remove redundant declarations

2012-11-28 Thread J. Bruce Fields
On Tue, Nov 27, 2012 at 02:42:20PM +0300, Stanislav Kinsbursky wrote: > This is a cleanup patch. Functions nfsd_pool_stats_open() and > nfsd_pool_stats_release() are declared in fs/nfsd/nfsd.h. OK, applying. --b. > > Signed-off-by: Stanislav Kinsbursky > --- > fs/nfsd/nfsctl.c |3 --- > 1

Re: [PATCH 1/2] nfsd: make NFSv4 lease time per net

2012-11-28 Thread J. Bruce Fields
On Wed, Nov 28, 2012 at 07:12:03PM +0400, Stanislav Kinsbursky wrote: > 28.11.2012 19:09, J. Bruce Fields пишет: > >On Tue, Nov 27, 2012 at 02:11:44PM +0300, Stanislav Kinsbursky wrote: > >>diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c > >>index dab350d..49309

Re: [PATCH 1/2] nfsd: make NFSv4 lease time per net

2012-11-28 Thread J. Bruce Fields
On Wed, Nov 28, 2012 at 07:35:20PM +0400, Stanislav Kinsbursky wrote: > 28.11.2012 19:15, J. Bruce Fields пишет: > >On Wed, Nov 28, 2012 at 07:12:03PM +0400, Stanislav Kinsbursky wrote: > >>28.11.2012 19:09, J. Bruce Fields пишет: > >>>On Tue, Nov 27, 2012 at 02:11:44

Re: [PATCHSET] idr: implement idr_alloc() and convert existing users

2013-03-21 Thread J. Bruce Fields
On Mon, Feb 04, 2013 at 09:11:28AM -0800, Tejun Heo wrote: > On Mon, Feb 04, 2013 at 09:10:31AM -0800, Tejun Heo wrote: > > Yeah, that should be easily convertable to the new interface. How > > should we route these changes? Your patch can go through the usual > > nfs channel and the conversion a

Re: linux-next: build failure after merge of the nfsd tree

2013-02-03 Thread J. Bruce Fields
On Sat, Feb 02, 2013 at 07:57:19AM -0500, J. Bruce Fields wrote: > On Sat, Feb 02, 2013 at 01:04:03PM +1100, Stephen Rothwell wrote: > > Hi, > > > > After merging the nfsd tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > >

Re: [PATCHSET] idr: implement idr_alloc() and convert existing users

2013-02-03 Thread J. Bruce Fields
On Sat, Feb 02, 2013 at 05:20:01PM -0800, Tejun Heo wrote: > * Bruce, I couldn't convert nfsd. Can you please help? More on it > later. ... > I converted all in-kernel users except nfsd and staging drivers. nfsd > splits preloading and actual id allocation in a way that per-cpu > preloading ca

Re: [PATCHSET] idr: implement idr_alloc() and convert existing users

2013-02-03 Thread J. Bruce Fields
On Sun, Feb 03, 2013 at 12:02:41PM -0500, J. Bruce Fields wrote: > On Sat, Feb 02, 2013 at 05:20:01PM -0800, Tejun Heo wrote: > > * Bruce, I couldn't convert nfsd. Can you please help? More on it > > later. > ... > > I converted all in-kernel users except nf

Re: [PATCH v2 0/6] SUNRPC: rework cache upcall to avoid NFSd root

2013-02-04 Thread J. Bruce Fields
On Mon, Feb 04, 2013 at 02:02:29PM +0300, Stanislav Kinsbursky wrote: > swapping > > The main idea of this patch set is to call cache request not on kthread > upcall, but on userspace daemon cache_read call. This fixes the problem with > gaining of wrong dentry path after calling d_path() in kthre

Re: [PATCH 2/4] SUNRPC: remove cache_detail->cache_upcall callback

2013-02-04 Thread J. Bruce Fields
On Mon, Feb 04, 2013 at 11:50:02AM -0500, Jeff Layton wrote: > On Tue, 15 Jan 2013 11:09:36 +0300 > Stanislav Kinsbursky wrote: > > > This callback is redundant since all that its' implementations are doing is > > calling sunrpc_cache_pipe_upcall() with proper function address argument. > > This

Re: [PATCHSET] idr: implement idr_alloc() and convert existing users

2013-02-04 Thread J. Bruce Fields
On Mon, Feb 04, 2013 at 09:10:31AM -0800, Tejun Heo wrote: > Hey, > > On Sun, Feb 03, 2013 at 07:15:58PM -0500, J. Bruce Fields wrote: > > On Sun, Feb 03, 2013 at 12:02:41PM -0500, J. Bruce Fields wrote: > > > On Sat, Feb 02, 2013 at 05:20:01PM -0800, Tejun Heo wrote: >

Re: [PATCHSET] idr: implement idr_alloc() and convert existing users

2013-02-04 Thread J. Bruce Fields
On Mon, Feb 04, 2013 at 09:11:28AM -0800, Tejun Heo wrote: > On Mon, Feb 04, 2013 at 09:10:31AM -0800, Tejun Heo wrote: > > Yeah, that should be easily convertable to the new interface. How > > should we route these changes? Your patch can go through the usual > > nfs channel and the conversion a

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-05 Thread J. Bruce Fields
On Tue, Feb 05, 2013 at 03:45:31PM +0400, Pavel Shilovsky wrote: > 2013/1/31 J. Bruce Fields : > > On Thu, Jan 17, 2013 at 08:52:59PM +0400, Pavel Shilovsky wrote: > >> If O_DENYMAND flag is specified, O_DENYREAD/WRITE/MAND flags are > >> translated to flock

Re: [PATCH v2 0/8] Add O_DENY* support for VFS and CIFS/NFS

2013-02-05 Thread J. Bruce Fields
On Tue, Feb 05, 2013 at 03:33:21PM +0400, Pavel Shilovsky wrote: > 2013/1/31 J. Bruce Fields : > > On Thu, Jan 17, 2013 at 08:52:09PM +0400, Pavel Shilovsky wrote: > >> This patchset adds support of O_DENY* flags for Linux fs layer. These > >> flags can be used by any a

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-07 Thread J. Bruce Fields
On Thu, Feb 07, 2013 at 01:53:46PM +0400, Pavel Shilovsky wrote: > 2013/2/5 J. Bruce Fields : > > On Tue, Feb 05, 2013 at 03:45:31PM +0400, Pavel Shilovsky wrote: > >> 2013/1/31 J. Bruce Fields : > >> > On Thu, Jan 17, 2013 at 08:52:59PM +0400, Pavel Shilovsky wrote:

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-07 Thread J. Bruce Fields
On Thu, Feb 07, 2013 at 06:32:38PM +0400, Pavel Shilovsky wrote: > 2013/2/7 J. Bruce Fields : > > On Thu, Feb 07, 2013 at 01:53:46PM +0400, Pavel Shilovsky wrote: > >> Nothing prevents it. If somebody grabbed a share mode lock on a file > >> before we call deny_lock_file

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-07 Thread J. Bruce Fields
On Thu, Feb 07, 2013 at 08:00:13PM +0400, Pavel Shilovsky wrote: > 2013/2/7 J. Bruce Fields : > > On Thu, Feb 07, 2013 at 06:32:38PM +0400, Pavel Shilovsky wrote: > >> 2013/2/7 J. Bruce Fields : > >> > On Thu, Feb 07, 2013 at 01:53:46PM +0400, Pavel Shilovsky wrote: &

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-07 Thread J. Bruce Fields
On Thu, Feb 07, 2013 at 08:50:16PM +0400, Pavel Shilovsky wrote: > 2013/2/7 J. Bruce Fields : > > That would be a bug, I think. E.g. "man 3posix open": > > > > No files shall be created or modified if the function returns > > -1. &g

Re: BUG at net/sunrpc/svc_xprt.c:921

2013-02-08 Thread J. Bruce Fields
On Thu, Feb 07, 2013 at 07:56:51AM -0500, Tom Horsley wrote: > I noticed some previous messages with this subject, but the > walkback I'm getting doesn't match exactly the ones shown > in the threads I saw, so I figured I'd send this in. > > This happens on both my Fedora 18 and Fedora 17 partitio

Re: [PATCH v2 1/6] NFS: use SUNRPC cache creation and destruction helper for DNS cache

2013-02-08 Thread J. Bruce Fields
On Mon, Feb 04, 2013 at 02:02:35PM +0300, Stanislav Kinsbursky wrote: > This cache was the first containerized and doesn't use net-aware cache > creation and destruction helpers. > This is a cleanup patch which just makes code looks clearer and reduce amount > of lines of code. This looks like unc

Re: [PATCH v2 2/6] NFS; simlify and clean cache library

2013-02-08 Thread J. Bruce Fields
On Mon, Feb 04, 2013 at 02:02:40PM +0300, Stanislav Kinsbursky wrote: > This is a cleanup patch. > Such helpers like nfs_cache_init() and nfs_cache_destroy() are redundant, > because they are just a wrappers around sunrpc_init_cache_detail() and > sunrpc_destroy_cache_detail() respectively. > So le

Re: linux-next: build failure after merge of the nfsd tree

2013-02-08 Thread J. Bruce Fields
On Fri, Feb 08, 2013 at 09:41:05AM +0400, Stanislav Kinsbursky wrote: > 03.02.2013 18:41, J. Bruce Fields пишет: > >On Sat, Feb 02, 2013 at 07:57:19AM -0500, J. Bruce Fields wrote: > >>On Sat, Feb 02, 2013 at 01:04:03PM +1100, Stephen Rothwell wrote: > >>>Hi, > >

Re: [PATCH 0/2] NFSD: fix races in service per-net resources allocation

2013-02-10 Thread J. Bruce Fields
than by adding another lock. Do you see anything wrong with the following? --b commit e8202f39f84b8863337f55159dd18478b9ccb616 Author: J. Bruce Fields Date: Sun Feb 10 16:08:11 2013 -0500 svcrpc: fix and simplify server shutdown Simplify server shutdown, and make it correct whet

Re: [PATCH 0/2] NFSD: fix races in service per-net resources allocation

2013-02-11 Thread J. Bruce Fields
On Mon, Feb 11, 2013 at 10:18:18AM +0400, Stanislav Kinsbursky wrote: > This one looks a bit complicated and confusing to me. Probably because > I'm not that familiar with service transports processing logic. So, > as I can see, we now try to run over all per-net pool-assigned > transports, remove

Re: [PATCH 0/2] NFSD: fix races in service per-net resources allocation

2013-02-11 Thread J. Bruce Fields
On Mon, Feb 11, 2013 at 11:37:15AM -0500, J. Bruce Fields wrote: > On Mon, Feb 11, 2013 at 10:18:18AM +0400, Stanislav Kinsbursky wrote: > > This one looks a bit complicated and confusing to me. Probably because > > I'm not that familiar with service transports processing logi

Re: [PATCH 0/2] NFSD: fix races in service per-net resources allocation

2013-02-12 Thread J. Bruce Fields
On Tue, Feb 12, 2013 at 01:52:32PM +0400, Stanislav Kinsbursky wrote: > 12.02.2013 00:58, J. Bruce Fields пишет: > > > void svc_close_net(struct svc_serv *serv, struct net *net) > > { > >-svc_close_list(serv, &serv->sv_tempsocks, net); > >-svc_clos

Re: BUG at net/sunrpc/svc_xprt.c:921 (another one)

2013-02-12 Thread J. Bruce Fields
On Sun, Jan 20, 2013 at 05:51:12PM -0500, Mark Lord wrote: > Got it again, this time on a different system > running mostly the same software. Mark, Paweł, Tom, could any of you confirm whether this helps? --b. diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c index dbf12ac..2d34b6b 100644 --- a/

Re: [PATCH linux-next] lockd: nlmclnt_reclaim(): avoid stack overflow

2013-02-12 Thread J. Bruce Fields
pointer into nlmclnt_reclaim() for reuse on > subsequent calls. > > smatch analysis: > > fs/lockd/clntproc.c:620 nlmclnt_reclaim() warn: 'reqst' puts > 928 bytes on stack > > Also remove redundant assignment of 0 after memset. > > Cc: Trond Myklebust >

Re: [PATCH linux-next] lockd: nlmsvc_mark_resources(): avoid stack overflow

2013-02-12 Thread J. Bruce Fields
tack at this point. > > smatch analysis: > > fs/lockd/svcsubs.c:366 nlmsvc_mark_resources() warn: 'hint' puts > 512 bytes on stack > > Cc: Trond Myklebust > Cc: "J. Bruce Fields" > Cc: linux-...@vger.kernel.org > Signed-off-by: Tim Gardner > -

nfsd bugfix for 3.9

2013-04-02 Thread J. Bruce Fields
Please pull another nfsd bugfix from the for-3.9 branch at git://linux-nfs.org/~bfields/linux.git for-3.9 (An xdr decoding error--thanks, Toralf Förster, and Trinity!) --b. J. Bruce Fields (1): nfsd4: reject "neg

Re: linux-next: build failure after merge of the final tree (nfsd tree related)

2013-04-03 Thread J. Bruce Fields
On Wed, Apr 03, 2013 at 07:10:54AM -0400, Jeff Layton wrote: > On Wed, 3 Apr 2013 17:42:19 +1100 > Stephen Rothwell wrote: > > > Hi all, > > > > After merging the final tree, today's linux-next build (arm defconfig) > > failed like this: > > > > fs/built-in.o: In function `nfsd_reply_cache_stat

Re: linux-next: build failure after merge of the final tree (nfsd tree related)

2013-04-03 Thread J. Bruce Fields
On Wed, Apr 03, 2013 at 07:38:57AM -0400, Jeff Layton wrote: > On Wed, 3 Apr 2013 07:33:01 -0400 > "J. Bruce Fields" wrote: > > > On Wed, Apr 03, 2013 at 07:10:54AM -0400, Jeff Layton wrote: > > > On Wed, 3 Apr 2013 17:42:19 +1100 > > > Ste

Re: [PATCH] nfsd4: Fix NULL dereference in legacy_recdir_name_error()

2013-04-03 Thread J. Bruce Fields
On Wed, Apr 03, 2013 at 06:27:26PM +0200, Takashi Iwai wrote: > The recent rewrite of NFSv4 recovery client tracking options per net > (commit 9a9c6478) introduced Oops when it faces an error for recdir > generation. Thanks. Looks like that could hit a lot of people actually, so I'll pass that al

Re: [PATCH v2] nfsd: fix bug on nfs4 stateid deallocation

2013-04-03 Thread J. Bruce Fields
On Wed, Apr 03, 2013 at 06:58:43PM +0800, Yanchuan Nian wrote: > On Mon, Apr 01, 2013 at 09:50:44PM -0400, J. Bruce Fields wrote: > > On Wed, Mar 13, 2013 at 11:04:54PM +0800, Yanchuan Nian wrote: > > > 2013/3/11 J. Bruce Fields > > > > > > > On Mon

Re: [PATCH v1 4/6] nfsd: convert nfs4_alloc_stid to use idr_alloc_cyclic

2013-04-03 Thread J. Bruce Fields
ACK.--b. On Wed, Mar 27, 2013 at 09:18:06AM -0400, Jeff Layton wrote: > Signed-off-by: Jeff Layton > Cc: "J. Bruce Fields" > Cc: linux-...@vger.kernel.org > --- > fs/nfsd/nfs4state.c | 9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) > > dif

Re: [PATCH v2 4/6] nfsd: convert nfs4_alloc_stid to use idr_alloc_cyclic

2013-04-03 Thread J. Bruce Fields
Err, and ack v2.--b. On Wed, Mar 27, 2013 at 03:29:36PM -0400, Jeff Layton wrote: > Signed-off-by: Jeff Layton > Cc: "J. Bruce Fields" > Cc: linux-...@vger.kernel.org > --- > fs/nfsd/nfs4state.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > >

Re: [PATCH] SUNRPC/cache: add module_put() on error path in cache_open()

2013-04-03 Thread J. Bruce Fields
Thanks, applying.--b. On Sat, Mar 23, 2013 at 12:36:44AM +0400, Alexey Khoroshilov wrote: > If kmalloc() fails in cache_open(), module cd->owner left locked. > The patch adds module_put(cd->owner) on this path. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by:

Re: [PATCH v2] nfsd: fix bug on nfs4 stateid deallocation

2013-04-05 Thread J. Bruce Fields
On Thu, Apr 04, 2013 at 10:04:03PM +0800, Yanchuan Nian wrote: > On Wed, Apr 03, 2013 at 02:55:08PM -0400, J. Bruce Fields wrote: > > On Wed, Apr 03, 2013 at 06:58:43PM +0800, Yanchuan Nian wrote: > > > On Mon, Apr 01, 2013 at 09:50:44PM -0400, J. Bruce Fields wrote: > >

Re: [PATCH 15/19] sunrpc: don't warn for unused variable 'buf'

2013-01-28 Thread J. Bruce Fields
On Sat, Jan 26, 2013 at 01:34:56PM +, Arnd Bergmann wrote: > On Saturday 26 January 2013, Russell King - ARM Linux wrote: > > On Fri, Jan 25, 2013 at 11:45:25PM +, Arnd Bergmann wrote: > > > On Friday 25 January 2013, Myklebust, Trond wrote: > > > > > -Original Message- > > > > > Fr

Re: [RFC PATCH] SUNRPC: protect transport processing with rw sem

2013-01-29 Thread J. Bruce Fields
On Tue, Jan 29, 2013 at 02:03:30PM +0300, Stanislav Kinsbursky wrote: > There could be a service transport, which is processed by service thread and > racing in the same time with per-net service shutdown like listed below: > > CPU#0:CPU#1: > > svc_recv

Re: [PATCH 11/14] nfs: idr_destroy() no longer needs idr_remove_all()

2013-01-29 Thread J. Bruce Fields
esn't necessarily release all idr_layers which could lead to memory > leak. Seems fine, but actually this is client-side so I think you meant the cc to be to Trond. --b. > > Signed-off-by: Tejun Heo > Cc: "J. Bruce Fields" > Cc: linux-...@vger.kernel.org > --- >

Re: [RFC PATCH] SUNRPC: protect transport processing with rw sem

2013-01-30 Thread J. Bruce Fields
On Wed, Jan 30, 2013 at 09:42:14AM +0400, Stanislav Kinsbursky wrote: > 30.01.2013 02:57, J. Bruce Fields пишет: > >On Tue, Jan 29, 2013 at 02:03:30PM +0300, Stanislav Kinsbursky wrote: > >>There could be a service transport, which is processed by service thread and > >

Re: [PATCH v2 0/8] Add O_DENY* support for VFS and CIFS/NFS

2013-01-30 Thread J. Bruce Fields
On Thu, Jan 17, 2013 at 08:52:09PM +0400, Pavel Shilovsky wrote: > This patchset adds support of O_DENY* flags for Linux fs layer. These flags > can be used by any application that needs share reservations to organize a > file access. VFS already has some sort of this capability - now it's done

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-01-30 Thread J. Bruce Fields
On Thu, Jan 17, 2013 at 08:52:59PM +0400, Pavel Shilovsky wrote: > If O_DENYMAND flag is specified, O_DENYREAD/WRITE/MAND flags are > translated to flock's flags: > > !O_DENYREAD -> LOCK_READ > !O_DENYWRITE -> LOCK_WRITE > O_DENYMAND -> LOCK_MAND > > and set through flock_lock_file on a file.

Re: [PATCH v2 4/8] CIFS: Add O_DENY* open flags support

2013-01-30 Thread J. Bruce Fields
On Thu, Jan 17, 2013 at 08:53:00PM +0400, Pavel Shilovsky wrote: > Make CIFSSMBOpen take share_flags as a parm that allows us > to pass new O_DENY* flags to the server. > > Signed-off-by: Pavel Shilovsky > --- > fs/cifs/cifsacl.c | 10 ++ > fs/cifs/cifsglob.h | 12 +++- > fs/c

Re: [RFC PATCH 0/4] SUNRPC: rework cache upcall to avoid NFSd root swapping

2013-01-30 Thread J. Bruce Fields
On Tue, Jan 15, 2013 at 11:09:23AM +0300, Stanislav Kinsbursky wrote: > The main idea of this patch set is to call cache request not on kthread > upcall, but on userspace daemon cache_read call. This fixes the problem with > gaining of wrong dentry path after calling d_path() in kthread root contex

Re: linux-next: build failure after merge of the nfsd tree

2013-02-02 Thread J. Bruce Fields
On Sat, Feb 02, 2013 at 01:04:03PM +1100, Stephen Rothwell wrote: > Hi, > > After merging the nfsd tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > fs/nfs/dns_resolve.c: In function 'nfs_dns_resolver_cache_init': > fs/nfs/dns_resolve.c:375:4: error: 'struct cache_detai

Re: BUG at net/sunrpc/svc_xprt.c:921

2013-02-25 Thread J. Bruce Fields
On Mon, Feb 25, 2013 at 03:45:07PM -0500, Mark Lord wrote: > On 13-01-17 08:53 AM, J. Bruce Fields wrote: > > On Thu, Jan 17, 2013 at 08:11:52AM -0500, Mark Lord wrote: > >> On 13-01-14 11:17 AM, Mark Lord wrote: > >>> > >>> Here's the code w

nfsd changes for 3.9

2013-02-28 Thread J. Bruce Fields
r the last year. --b. Andriy Skulysh (1): sunrpc: Fix lockd sleeping until timeout Fengguang Wu (1): nfsd4: free_stid can be static J. Bruce Fields (7): nfsd4: simplify nfsd4_encode_fattr interface slightly s

Re: [PATCH 1/6] fs/nfsd/nfs4idmap.c: adjust inconsistent IS_ERR and PTR_ERR

2012-08-27 Thread J. Bruce Fields
On Sat, Aug 25, 2012 at 09:57:04PM +0200, Julia Lawall wrote: > From: Julia Lawall > > Change the call to PTR_ERR to access the value just tested by IS_ERR. Applying for 3.7, thanks.--b. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @@

Re: [PATCH] exportfs: add FILEID_INVALID to indicate invalid fid_type

2012-08-30 Thread J. Bruce Fields
On Wed, Aug 29, 2012 at 10:10:10AM -0400, Namjae Jeon wrote: > This commit adds FILEID_INVALID = 0xff in fid_type to > indicate invalid fid_type OK, applying for 3.7. Looks like this shows up in a lot of filesystems too as just "255". Are you planning to patch up the filesystems afterwards? --b

Re: [PATCH] nfsd: remove duplicate init in nfsd4_cb_recall

2012-08-30 Thread J. Bruce Fields
On Wed, Aug 29, 2012 at 10:10:53AM -0400, Namjae Jeon wrote: > remove duplicate init in nfsd4_cb_recall Thanks, applying for 3.7.--b. > > Signed-off-by: Namjae Jeon > Signed-off-by: Vivek Trivedi > --- > fs/nfsd/nfs4callback.c |1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/nfs

Re: [PATCH v2 4/5] fat: eliminate orphaned inode number allocation

2012-09-04 Thread J. Bruce Fields
On Wed, Sep 05, 2012 at 02:07:40AM +0900, OGAWA Hirofumi wrote: > OGAWA Hirofumi writes: > > > Namjae Jeon writes: > > > >> From: Namjae Jeon > >> > >> Maintain a list of inode(i_pos) numbers of orphaned inodes (i.e the > >> inodes that have been unlinked but still having open file > >> descrip

Re: [RFC PATCH 0/5] net: socket bind to file descriptor introduced

2012-09-04 Thread J. Bruce Fields
On Mon, Aug 20, 2012 at 02:18:13PM +0400, Stanislav Kinsbursky wrote: > 16.08.2012 07:03, Eric W. Biederman пишет: > >Stanislav Kinsbursky writes: > > > >>This patch set introduces new socket operation and new system call: > >>sys_fbind(), which allows to bind socket to opened file. > >>File to bi

Re: [PATCH v2 4/5] fat: eliminate orphaned inode number allocation

2012-09-04 Thread J. Bruce Fields
On Wed, Sep 05, 2012 at 04:02:13AM +0900, OGAWA Hirofumi wrote: > "J. Bruce Fields" writes: > > > On Wed, Sep 05, 2012 at 02:07:40AM +0900, OGAWA Hirofumi wrote: > >> OGAWA Hirofumi writes: > >> > >> > Namjae Jeon writes: > >> &g

Re: [RFC PATCH 0/2] issues with NFS filesystems as lower layer

2012-09-11 Thread J. Bruce Fields
On Tue, Sep 11, 2012 at 10:56:52PM +0200, Miklos Szeredi wrote: > "J. Bruce Fields" writes: > > >> > Secondly when using an NFSv3 R/O lower layer the filesystem permissions > >> > check refuses permission to write to the inode which prevents us from &g

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-12 Thread J. Bruce Fields
On Wed, Sep 12, 2012 at 11:12:56PM +0900, Namjae Jeon wrote: > 2012/9/12 OGAWA Hirofumi : > > Namjae Jeon writes: > > > I think that it is unfixable because we can not know i_pos of inode > changed by rename. > And even though we know it, there is no rebuild inode routine in -mm. >

Re: [RFC PATCH 0/2] issues with NFS filesystems as lower layer

2012-09-12 Thread J. Bruce Fields
On Wed, Sep 12, 2012 at 05:20:17PM +0200, Miklos Szeredi wrote: > "J. Bruce Fields" writes: > > > On Tue, Sep 11, 2012 at 10:56:52PM +0200, Miklos Szeredi wrote: > >> "J. Bruce Fields" writes: > >> > >> >> > Secondly when

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-12 Thread J. Bruce Fields
On Thu, Sep 13, 2012 at 02:03:51AM +0900, OGAWA Hirofumi wrote: > "J. Bruce Fields" writes: > > >> > Supposing, the server/client state is after cold boot, and client try to > >> > rename at first without any cache on client/server. > >> > >

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-12 Thread J. Bruce Fields
On Thu, Sep 13, 2012 at 02:38:11AM +0900, OGAWA Hirofumi wrote: > "J. Bruce Fields" writes: > > >> On other view (as server side solution), we are thinking there is > >> possible to make the stable filehandle on FAT if we disabled some > >> operations (

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-13 Thread J. Bruce Fields
On Thu, Sep 13, 2012 at 05:33:02PM +0900, OGAWA Hirofumi wrote: > Namjae Jeon writes: > > >> I see. So, client can't solve the ESTALE if inode cache was evicted, > >> right? (without application changes) > > > > There can be situation where we may get not only ESTALE but EIO also. > > > > For exa

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-13 Thread J. Bruce Fields
On Thu, Sep 13, 2012 at 11:24:30PM +0900, Namjae Jeon wrote: > 2012/9/13, OGAWA Hirofumi : > > "J. Bruce Fields" writes: > > > >>> >> Grepping around... Documentation/sysctl/vm.txt mentions a > >>> >> vfs_cache_pressure parameter

Re: [PATCH] strings: helper for maximum decimal encoding of an unsigned integer

2012-09-14 Thread J. Bruce Fields
ecause I like typing char buf[ULONG_STR_MAX + 1]; better than char bug[base10len(unsigned long) + 1]; --b. commit 59a620640cd05d3d29e678ff893cfe266091fba7 Author: J. Bruce Fields Date: Wed Aug 15 17:41:47 2012 -0400 strings: helper for maximum decimal encoding of an

nfsd patches for 2.6.25

2008-02-01 Thread J. Bruce Fields
length signage in nfsd request argument structures SUNRPC: RPC program information is stored in unsigned integers Frank Filz (1): nfsd: Allow AIX client to read dir containing mountpoints J. Bruce Fields (34): nfsd4: probe callback channel only once nfsd: move callback

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread J. Bruce Fields
On Mon, Feb 04, 2008 at 11:44:31AM -0800, Linus Torvalds wrote: ... > Pure user-space solutions work, but tend to eventually be turned into > kernel-space if they are simple enough and really do have throughput and > latency considerations (eg nfsd), and aren't quite complex and crazy > enough t

Re: [RFC PATCH 0/5] net: socket bind to file descriptor introduced

2012-10-05 Thread J. Bruce Fields
On Tue, Sep 04, 2012 at 03:00:07PM -0400, bfields wrote: > On Mon, Aug 20, 2012 at 02:18:13PM +0400, Stanislav Kinsbursky wrote: > > 16.08.2012 07:03, Eric W. Biederman пишет: > > >Stanislav Kinsbursky writes: > > > > > >>This patch set introduces new socket operation and new system call: > > >>sy

Re: Heads-up: 3.6.2 / 3.6.3 NFS server panic: 3.6.2+ regression?

2012-10-23 Thread J. Bruce Fields
On Tue, Oct 23, 2012 at 03:07:59PM +0100, Nix wrote: > On 23 Oct 2012, J. Bruce Fields uttered the following: > > > On Mon, Oct 22, 2012 at 05:17:04PM +0100, Nix wrote: > >> I just had a panic/oops on upgrading from 3.6.1 to 3.6.3, after weeks of > >> smooth oper

Re: Heads-up: 3.6.2 / 3.6.3 NFS server oops: 3.6.2+ regression? (also an unrelated ext4 data loss bug)

2012-10-23 Thread J. Bruce Fields
On Tue, Oct 23, 2012 at 05:32:21PM +0100, Nix wrote: > On 23 Oct 2012, J. Bruce Fields uttered the following: > > nfs-utils shouldn't be capable of oopsing the kernel, so from my > > (selfish) point of view I'd actually rather you stick with whatever you > > hav

Re: Heads-up: 3.6.2 / 3.6.3 NFS server oops: 3.6.2+ regression? (also an unrelated ext4 data loss bug)

2012-10-23 Thread J. Bruce Fields
On Tue, Oct 23, 2012 at 12:46:21PM -0400, J. Bruce Fields wrote: > On Tue, Oct 23, 2012 at 05:32:21PM +0100, Nix wrote: > > On 23 Oct 2012, J. Bruce Fields uttered the following: > > > nfs-utils shouldn't be capable of oopsing the kernel, so from my > > > (sel

Re: Heads-up: 3.6.2 / 3.6.3 NFS server oops: 3.6.2+ regression? (also an unrelated ext4 data loss bug)

2012-10-23 Thread J. Bruce Fields
On Tue, Oct 23, 2012 at 06:36:15PM +0100, Nix wrote: > On 23 Oct 2012, n...@esperi.org.uk uttered the following: > > > On 23 Oct 2012, Trond Myklebust spake thusly: > >> On Tue, 2012-10-23 at 12:46 -0400, J. Bruce Fields wrote: > >>> Looks like there's some

Re: [PATCH] nfs: fix wrong object type in lockowner_slab

2012-10-24 Thread J. Bruce Fields
On Wed, Oct 24, 2012 at 02:44:19PM +0800, ycn...@gmail.com wrote: > From: Yanchuan Nian > > The object type in the cache of lockowner_slab is wrong, and it is better to > fix it. > > Signed-off-by: Yanchuan Nian > --- > fs/nfsd/nfs4state.c |2 +- > 1 files changed, 1 insertions(+), 1 dele

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread J. Bruce Fields
On Wed, Feb 13, 2008 at 12:48:41AM +, Al Viro wrote: > On Tue, Feb 12, 2008 at 07:16:50PM -0500, J. Bruce Fields wrote: > > > Ahem... Use of git-cherry-pick preserves commit information just fine. > > > > Not by default, at least (note they said "commiters"

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread J. Bruce Fields
~/local/linux-2.6$ git show --pretty=raw HEAD commit c445dc0a8b11877d6038dc528254733348c9f110 tree 4018d5d93f857d946dd89acbb4e45c9da04eadaf parent b6ce068a1285a24185b01be8a49021827516b3e1 author Linus Torvalds <[EMAIL PROTECTED]> 1202681894 -0800 committer J. Bruce Fields <[EMAIL PROTECTED]>

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread J. Bruce Fields
On Tue, Feb 12, 2008 at 05:31:10PM -0800, Linus Torvalds wrote: > The importance of merging (rather, not screwing up history in general) > becomes really obvious when things go tits-up. Then they go tits-up > *without* screwing up the history of the trees that were hopefully tested > individuall

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread J. Bruce Fields
On Tue, Feb 12, 2008 at 05:20:51PM -0800, David Miller wrote: > From: Linus Torvalds <[EMAIL PROTECTED]> > Date: Tue, 12 Feb 2008 16:44:47 -0800 (PST) > > > gitk --merge > ... > > This is something where I actually think git could and should do better: > > git has the capability to act as mo

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread J. Bruce Fields
On Tue, Feb 12, 2008 at 11:31:48AM -0500, Jeff Garzik wrote: > David Miller wrote: >> I rebase my tree all the time, at least once or twice per >> week. Why? >> >> Firstly, to remove crap. When you have "great idea A" then "oh shit A >> won't work, revert that" there is zero sense in keeping both

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-13 Thread J. Bruce Fields
On Tue, Feb 12, 2008 at 09:43:10PM -0800, Linus Torvalds wrote: > So just the fact that the right commit gets blamed when somebody does a > "git bisect" is I think a big issue. It's just fundamentally more fair to > everybody. And it means that the people who push their work to me can > really c

Re: [2.6 patch] make nfsd_create_setattr() static

2008-02-13 Thread J. Bruce Fields
On Wed, Feb 13, 2008 at 11:30:26PM +0200, Adrian Bunk wrote: > This patch makes the needlessly global nfsd_create_setattr() static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Thanks, applied.--b. > > --- > 7cfb17a22a0cf76477fbf1fbe6bf586108a13a44 diff --git a/fs/nfsd/vfs.c > b/fs/nfsd/

Re: linux-next: first tree

2008-02-15 Thread J. Bruce Fields
On Thu, Feb 14, 2008 at 05:27:57PM -0500, Trond Myklebust wrote: > > On Fri, 2008-02-15 at 00:35 +1100, Stephen Rothwell wrote: > > > > Also, more trees please ... :-) > > Please add the 'linux-next' branch of > > git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git And 'nfsd-next' at

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-15 Thread J. Bruce Fields
On Thu, Feb 14, 2008 at 07:35:03PM +0200, Benny Halevy wrote: > One idea that I thought about when debating rebase vs. merge (and it's > far far from being fully baked) is versioned commits. The gist of it > is that patches are assigned an hash identifier like today when they > are first committed

Re: [PATCHv3] locks: prevent side-effects of locks_release_private before file_lock is initialized

2012-07-27 Thread J. Bruce Fields
g") which originally introduced the > lm_release_private callback. Looks fine, thanks. I think can also do something like the following (on top of your patch). --b. commit 96d6d59ceaeaacba4088862f3c57fcd011f52832 Author: J. Bruce Fields Date: Fri Jul 27 16:18:00 2012 -0400 locks: move l

Re: [PATCH v2 09/15] NFSd: make nfsd4_manager allocated per network namespace context.

2012-07-27 Thread J. Bruce Fields
On Wed, Jul 25, 2012 at 04:56:58PM +0400, Stanislav Kinsbursky wrote: > Signed-off-by: Stanislav Kinsbursky > --- > fs/nfsd/netns.h |2 ++ > fs/nfsd/nfs4state.c | 32 +++- > 2 files changed, 21 insertions(+), 13 deletions(-) > > diff --git a/fs/nfsd/netns.h

Re: [PATCH v2 00/15] Lockd: grace period containerization

2012-07-27 Thread J. Bruce Fields
On Wed, Jul 25, 2012 at 04:55:45PM +0400, Stanislav Kinsbursky wrote: > Bruce, I feel this patch set is ready for inclusion. > > v2: > 1) Rebase on Bruce's "for-3.6" branch. > > This patch set makes grace period and hosts reclaiming network namespace > aware. On a quick skim--yes, that looks rea

Re: [PATCHv3] locks: prevent side-effects of locks_release_private before file_lock is initialized

2012-07-29 Thread J. Bruce Fields
On Fri, Jul 27, 2012 at 04:45:52PM -0400, J. Bruce Fields wrote: > On Fri, Jul 27, 2012 at 12:42:52AM -0400, Filipe Brandenburger wrote: > > When calling fcntl(fd, F_SETLEASE, lck) [with lck=F_WRLCK or F_RDLCK], > > the custom signal or owner (if any were previously set using

Re: [PATCH v2 00/15] Lockd: grace period containerization

2012-07-31 Thread J. Bruce Fields
On Mon, Jul 30, 2012 at 02:03:57PM +0400, Stanislav Kinsbursky wrote: > 28.07.2012 01:54, J. Bruce Fields пишет: > >On Wed, Jul 25, 2012 at 04:55:45PM +0400, Stanislav Kinsbursky wrote: > >>Bruce, I feel this patch set is ready for inclusion. > >> > >>v2: >

nfsd changes for 3.6

2012-07-31 Thread J. Bruce Fields
re file_lock is initialized J. Bruce Fields (10): nfsd4: remove unnecessary comment nfsd4: nfsd4_lock() cleanup nfsd4: process_open2 cleanup nfsd4: our filesystems are normally case sensitive nfsd4: release openowners on free in >=4.1 case nfsd: allow owner_overrid

Re: nfsd changes for 3.6

2012-07-31 Thread J. Bruce Fields
On Tue, Jul 31, 2012 at 10:29:48AM -0400, bfields wrote: > Please pull nfsd (and some lockd and a couple locks/lease) changes from: By the way, for a few years now I've been semi-regularly picking up locks.c changes for my tree. I wonder if I should be. At the least we should probably remove thi

Re: [PATCH v3 2/5] fat: allocate persistent inode numbers

2012-09-24 Thread J. Bruce Fields
On Mon, Sep 24, 2012 at 09:32:00PM +0900, OGAWA Hirofumi wrote: > Namjae Jeon writes: > > > 2012/9/24, OGAWA Hirofumi : > >> Namjae Jeon writes: > >> > I see. fileid seems to be stat.ino on nfsd4. inode->i_ino is actually > just a hash key of inode hash (exception is only in audit, iir

Re: [PATCH v3 2/5] fat: allocate persistent inode numbers

2012-09-24 Thread J. Bruce Fields
On Tue, Sep 25, 2012 at 01:16:45AM +0900, OGAWA Hirofumi wrote: > "J. Bruce Fields" writes: > > >> > There is some unclear thing. > >> > When I see first mail, I think maybe you don't want to use i_pos for > >> > inode->ino. > >&

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-26 Thread J. Bruce Fields
On Wed, Oct 10, 2012 at 02:32:28PM +0400, Stanislav Kinsbursky wrote: > 10.10.2012 05:23, J. Bruce Fields пишет: > >On Tue, Oct 09, 2012 at 03:47:42PM -0700, Eric W. Biederman wrote: > >>"J. Bruce Fields" writes: > >> > >>>On Tue, Oct 09,

Re: [PATCH v7 09/16] SUNRPC/cache: use new hashtable implementation

2012-10-29 Thread J. Bruce Fields
On Mon, Oct 29, 2012 at 11:13:43AM -0400, Mathieu Desnoyers wrote: > * Linus Torvalds (torva...@linux-foundation.org) wrote: > > On Mon, Oct 29, 2012 at 5:42 AM, Mathieu Desnoyers > > wrote: > > > > > > So defining e.g.: > > > > > > #include > > > > > > #define DFR_HASH_BITS (PAGE_SHIFT - ilog2(

Re: [PATCH v8 11/32] vfs: make do_unlinkat retry on ESTALE errors

2012-10-30 Thread J. Bruce Fields
On Sat, Oct 27, 2012 at 08:33:18AM -0400, Jeff Layton wrote: > Signed-off-by: Jeff Layton > --- > fs/namei.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/fs/namei.c b/fs/namei.c > index 7c9bb50..467b9f1 100644 > --- a/fs/namei.c > +++ b/fs/namei.c > @@ -

Re: [PATCH v8 11/32] vfs: make do_unlinkat retry on ESTALE errors

2012-10-30 Thread J. Bruce Fields
On Tue, Oct 30, 2012 at 12:33:55PM -0400, Jeff Layton wrote: > On Tue, 30 Oct 2012 12:14:29 -0400 > "J. Bruce Fields" wrote: > > > On Sat, Oct 27, 2012 at 08:33:18AM -0400, Jeff Layton wrote: > > > Signed-off-by: Jeff Layton > > > --- > > >

Re: Issues with a rather unusual configured NFS server

2013-08-27 Thread J. Bruce Fields
d trinity is used > > > > > > I could find a scenario for an automated bisect. 2 times it brought this > > > commit > > > commit 68a3396178e6688ad7367202cdf0af8ed03c8727 > > > Author: J. Bruce Fields > > > Date: Thu Mar 21 11:21:50 2013 -0400 > &

Re: [uml-devel] Issues with a rather unusual configured NFS server

2013-08-29 Thread J. Bruce Fields
On Thu, Aug 29, 2013 at 11:57:45AM +0200, richard -rw- weinberger wrote: > On Wed, Aug 28, 2013 at 7:21 PM, Toralf Förster > wrote: > > On 08/27/2013 08:06 PM, J. Bruce Fields wrote: > >> On Tue, Aug 13, 2013 at 05:53:14PM -0400, bfields wrote: > >>> On Mon, Aug

  1   2   3   4   5   6   7   8   9   10   >