[PATCH v3] platform/x86: peaq-wmi: Add new peaq-wmi driver

2017-05-12 Thread Hans de Goede
it adds support for this button making it report KEY_SOUND input events. KEY_SOUND is already used in various places to switch sound into theatre mode and things like that so it seems appropriate here. Signed-off-by: Hans de Goede Reviewed-by: Andy Shevchenko Reviewed-by: Dmitry Torokhov --- Chang

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

2017-05-12 Thread Hans de Goede
Hi, On 24-04-17 15:12, Guenter Roeck wrote: On 04/24/2017 04:02 AM, Heikki Krogerus wrote: +Guenter On Fri, Apr 21, 2017 at 09:51:50PM +0300, Andy Shevchenko wrote: +Cc: Heikki. He might comment on this. Thanks Andy. On Fri, Apr 21, 2017 at 4:01 PM, Hans de Goede wrote: Add support

[PATCH v2] platform/x86: dell-laptop: Filter out spurious keyboard backlight change events

2018-01-11 Thread Hans de Goede
ár Signed-off-by: Hans de Goede --- Changes in v2: -Add Fixes tag -Add Pali's Acked-by --- drivers/platform/x86/dell-laptop.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell

Re: [PATCH v2] iio: accel: bmc150: Check for a second ACPI device for BOSC0200

2018-01-31 Thread Hans de Goede
H5, On 01/30/2018 06:38 PM, Andy Shevchenko wrote: On Tue, Jan 30, 2018 at 7:25 PM, Steve Presser wrote: Andy, Where did the assertion the second device is a magnetometer come from? Just the data sheet? Yep. See chapter 8.2. Isn't enough proof? Or you believe in two accelerometers with off-

Re: [PATCH v2] iio: accel: bmc150: Check for a second ACPI device for BOSC0200

2018-01-31 Thread Hans de Goede
Hi, On 31-01-18 13:25, Andy Shevchenko wrote: Have you chance a look at the branch I pushed yesterday? I assume you mean: https://bitbucket.org/andy-shev/linux/branch/topic/iio-acpi This looks very nice and a much better solution then what Jeremy Cline posted, which is my fault as I suggeste

[PATCH 1/3] platform/x86: GPD pocket fan: Set speed to max on get_temp failure

2018-01-19 Thread Hans de Goede
When we fail to get the temperature, assume the worst and set the speed to max. While at it introduce a define for MAX_SPEED. Cc: James Suggested-by: James Signed-off-by: Hans de Goede --- drivers/platform/x86/gpd-pocket-fan.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions

[PATCH 3/3] platform/x86: GPD pocket fan: Stop work on suspend

2018-01-19 Thread Hans de Goede
Stop the work on suspend, otherwise it may run between our suspend method running and the system suspending, possibly restarting the fan which we've just stopped. Note we already requeue the work on resume, so that we get a fresh speed at resume. Signed-off-by: Hans de Goede --- dr

[PATCH 2/3] platform/x86: GPD pocket fan: Use a min-speed of 2 while charging

2018-01-19 Thread Hans de Goede
Newer versions of the GPD pocket BIOS set the fan-speed to 2 when a charger gets plugged in while the device is off. Mirror this in our fan driver and use a minimum speed of 2 while charging, Cc: James Suggested-by: James Signed-off-by: Hans de Goede --- drivers/platform/x86/gpd-pocket-fan.c

Re: [PATCH] platform/x86: dell-laptop: Filter out spurious keyboard backlight change events

2018-01-05 Thread Hans de Goede
Hi, On 05-01-18 11:40, Andy Shevchenko wrote: On Thu, Jan 4, 2018 at 10:52 AM, Hans de Goede wrote: On some Dell XPS models WMI events of type 0x reporting a keycode of 0xe00c get reported when the brightness of the LCD panel changes. This leads to us reporting false-positive kbd_led

Re: [PATCH] platform/x86: dell-laptop: Filter out spurious keyboard backlight change events

2018-01-05 Thread Hans de Goede
Hi, On 05-01-18 12:07, Pali Rohár wrote: On Friday 05 January 2018 12:40:04 Andy Shevchenko wrote: On Thu, Jan 4, 2018 at 10:52 AM, Hans de Goede wrote: On some Dell XPS models WMI events of type 0x reporting a keycode of 0xe00c get reported when the brightness of the LCD panel changes

Re: [PATCH] vboxvideo: Fix incorrect type in assignment sparse warning

2018-01-06 Thread Hans de Goede
Hi, On 06-01-18 15:20, Alexander Kapshuk wrote: On Mon, Dec 25, 2017 at 04:42:59PM +0200, Alexander Kapshuk wrote: Sparse emitted the following warning: ../drivers/staging/vboxvideo/vbox_fb.c:173:27: warning: incorrect type in assignment (different address spaces) ../drivers/staging/vboxvideo/

Re: [PATCH] vboxvideo: Fix incorrect type in assignment sparse warning

2018-01-06 Thread Hans de Goede
HI, On 06-01-18 20:30, Alexander Kapshuk wrote: On Sat, Jan 6, 2018 at 6:00 PM, Hans de Goede wrote: Hi, On 06-01-18 15:20, Alexander Kapshuk wrote: On Mon, Dec 25, 2017 at 04:42:59PM +0200, Alexander Kapshuk wrote: Sparse emitted the following warning: ../drivers/staging/vboxvideo

Re: [PATCH] vboxvideo: Fix incorrect type in assignment sparse warning

2018-01-06 Thread Hans de Goede
Hi, On 06-01-18 20:56, Alexander Kapshuk wrote: On Sat, Jan 6, 2018 at 9:43 PM, Hans de Goede wrote: HI, On 06-01-18 20:30, Alexander Kapshuk wrote: On Sat, Jan 6, 2018 at 6:00 PM, Hans de Goede wrote: Hi, On 06-01-18 15:20, Alexander Kapshuk wrote: On Mon, Dec 25, 2017 at 04:42

Re: [PATCH] uas: ignore UAS for Norelsys NS1068(X) chips

2018-01-06 Thread Hans de Goede
chip. Cc: sta...@vger.kernel.org Signed-off-by: Icenowy Zheng A quick internet search shows various problems with this device even under Windows, so yes this seems like a good idea: Acked-by: Hans de Goede The NS1066 chip from the same vendor seems to also suffer from this problem (its USB ID

[PATCH] platform/x86: silead_dmi: Add entry for newer BIOS for Trekstor Surftab 7.0

2018-01-16 Thread Hans de Goede
Some versions of the Trekstor Surftab 7.0 ship with a newer BIOS which uses different DMI strings. Signed-off-by: Hans de Goede --- drivers/platform/x86/silead_dmi.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/platform/x86/silead_dmi.c b/drivers/platform/x86

Re: [PATCH v2] fs: Add VirtualBox guest shared folder (vboxsf) support

2018-01-17 Thread Hans de Goede
Hi, On 17-01-18 04:19, Al Viro wrote: On Tue, Jan 16, 2018 at 11:15:15AM +0100, Hans de Goede wrote: * your ->rename() can race with ->get_link(). Look at the place where the former reassigns ->path and frees the old value and think what happens if the latter is called just

Re: [PATCH] staging: rtl8723bs: Fix trailing semicolon

2018-01-09 Thread Hans de Goede
Hi, On 09-01-18 17:02, Luis de Bethencourt wrote: On 01/09/2018 03:20 PM, Greg Kroah-Hartman wrote: On Tue, Jan 09, 2018 at 03:09:27PM +, Luis de Bethencourt wrote: Signed-off-by: Luis de Bethencourt --- I can't take patches without any changelog text, sorry :( Hi Greg, I have done

[PATCH 1/2] extcon: axp288: Constify the axp288_pwr_up_down_info array

2018-01-14 Thread Hans de Goede
Make the axp288_pwr_up_down_info array const char * const, this leads to the following section size changes: .text 0x674 -> 0x664 .data 0x148 -> 0x0f0 .rodata 0x0b4 -> 0x114 Signed-off-by: Hans de Goede --- drivers/extcon/extcon-axp288.c | 4 ++-- 1 file changed, 2 inserti

[PATCH 2/2] extcon: axp288: Only reschedule charger-detection at boot when a SDP is detected

2018-01-14 Thread Hans de Goede
interrupt which reschedules the charger-detection. Also update the comment about the re-detection to reflect this. Signed-off-by: Hans de Goede --- drivers/extcon/extcon-axp288.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/extcon/extcon-axp288.c b

[PATCH] ACPI / LPSS: Do not instiate a platform_dev for devs without a mmio resource

2018-01-14 Thread Hans de Goede
handler for the device and that handler has no attach callback, so we simply behave as a handler without an attach function in this case. Signed-off-by: Hans de Goede --- drivers/acpi/acpi_lpss.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c

Re: [PATCH 2/2] extcon: axp288: Only reschedule charger-detection at boot when a SDP is detected

2018-01-15 Thread Hans de Goede
Hi, On 15-01-18 06:22, Chanwoo Choi wrote: On 2018년 01월 15일 00:10, Hans de Goede wrote: The only misdetection which can happen at boot due to data-lines mux issues is detecting a non SDP as SDP, so we only need to retry if we detect a SDP on our first detection. Note Vbus misdetection is not

Re: [PATCH] ACPI / LPSS: Do not instiate a platform_dev for devs without a mmio resource

2018-01-15 Thread Hans de Goede
Hi, On 15-01-18 00:36, Rafael J. Wysocki wrote: On Sun, Jan 14, 2018 at 9:01 PM, Hans de Goede wrote: acpi_lpss_create_device() skips handling LPSS devices which do not have a mmio resources in their resource list (typically these devices are disabled by the firmware). But since the LPSS code

Re: [PATCH 2/2] extcon: axp288: Only reschedule charger-detection at boot when a SDP is detected

2018-01-15 Thread Hans de Goede
HI, On 15-01-18 10:08, Chanwoo Choi wrote: On 2018년 01월 15일 17:36, Hans de Goede wrote: Hi, On 15-01-18 06:22, Chanwoo Choi wrote: On 2018년 01월 15일 00:10, Hans de Goede wrote: The only misdetection which can happen at boot due to data-lines mux issues is detecting a non SDP as SDP, so we

[PATCH] virt: vbox: Add error mapping for VERR_INVALID_NAME and VERR_NO_MORE_FILES

2018-01-15 Thread Hans de Goede
Add error mapping for VERR_INVALID_NAME and VERR_NO_MORE_FILES vbox status codes, these are both used by the vboxsf (shared folder) code. Signed-off-by: Hans de Goede --- drivers/virt/vboxguest/vboxguest_utils.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/virt/vboxguest

[PATCH 0/1] virt: vbox: Add error mapping for 2 more vbox status codes

2018-01-15 Thread Hans de Goede
Hi All, This patch adds error mapping for 2 more vbox status codes, it applies on top of the vboxguest currently queued in char-misc-next. Mapping of these 2 status codes is necessary for the vboxsf (shared folders on the guest) fs driver I'm about to submit for mainline inclusion, IOW this is a

[PATCH v2 0/1] fs: Add VirtualBox guest shared folder (vboxsf) support

2018-01-15 Thread Hans de Goede
Hi All, Now that the vboxguest driver which the vboxsf (guest shared folder) fs driver depends on is queued for merging into 4.16 in char-misc-next, all the dependencies for the vboxsf are in place. So here is a v2 of my initial vboxsf, addressing all of the remark from Christoph Hellwig about v1

[PATCH v2] fs: Add VirtualBox guest shared folder (vboxsf) support

2018-01-15 Thread Hans de Goede
: Hans de Goede --- fs/Kconfig | 1 + fs/Makefile| 1 + fs/vboxsf/Kconfig | 9 + fs/vboxsf/Makefile | 3 + fs/vboxsf/dir.c| 648 + fs/vboxsf/file.c

Re: [PATCH v2] fs: Add VirtualBox guest shared folder (vboxsf) support

2018-01-15 Thread Hans de Goede
Hi, On 15-01-18 18:55, Christoph Hellwig wrote: The mount uabi stuff is a red flag - all filesystems should use text options only these days. From a 20 second view it seems like this one does that, and the header can just be removed, but if not a lot more work will be needed. Thank you for th

Re: [PATCH v2] fs: Add VirtualBox guest shared folder (vboxsf) support

2018-01-15 Thread Hans de Goede
Hi, On 15-01-18 20:32, Amir Goldstein wrote: On Mon, Jan 15, 2018 at 7:51 PM, Hans de Goede wrote: VirtualBox hosts can share folders with guests, this commit adds a VFS driver implementing the Linux-guest side of this, allowing folders exported by the host to be mounted under Linux. This

Re: [PATCH 2/2] extcon: axp288: Only reschedule charger-detection at boot when a SDP is detected

2018-01-16 Thread Hans de Goede
Hi, On 16-01-18 00:43, Chanwoo Choi wrote: On 2018년 01월 15일 20:32, Hans de Goede wrote: HI, On 15-01-18 10:08, Chanwoo Choi wrote: On 2018년 01월 15일 17:36, Hans de Goede wrote: Hi, On 15-01-18 06:22, Chanwoo Choi wrote: On 2018년 01월 15일 00:10, Hans de Goede wrote: The only misdetection

Re: [PATCH v2] fs: Add VirtualBox guest shared folder (vboxsf) support

2018-01-16 Thread Hans de Goede
Hi Al, Thank you for the quick review. On 15-01-18 23:36, Al Viro wrote: * what hch said about mount options. Get rid of that before the thing goes into mainline. Ack. * all "inode = GET_F_DENTRY(f)->d_inode;" are complete BS; it's called file_inode(f). Kill GET_F_DENTRY() off and b

Re: [Possible REGRESSION, 4.16-rc4] Error updating SMART data during runtime and could not connect to lvmetad at some boot attempts

2018-03-11 Thread Hans de Goede
hat would be great. Regards, Hans >From 551654d311d91c3cecde233eda86686f5d786fc2 Mon Sep 17 00:00:00 2001 From: Hans de Goede Date: Sun, 11 Mar 2018 15:32:00 +0100 Subject: [PATCH] libata: Apply NOLPM quirk to Crucial M500 480GB SSDs There have been reports of the Crucial M500 480GB model not wo

Re: [Possible REGRESSION, 4.16-rc4] Error updating SMART data during runtime and could not connect to lvmetad at some boot attempts

2018-03-11 Thread Hans de Goede
Hi, On 11-03-18 17:28, Martin Steigerwald wrote: Hans de Goede - 11.03.18, 15:37: Hi Martin, On 11-03-18 09:20, Martin Steigerwald wrote: Hello. Since 4.16-rc4 (upgraded from 4.15.2 which worked) I have an issue with SMART checks occassionally failing like this: smartd[28017]: Device: /dev

Re: [PATCH v6 01/12] drivers: base: Unified device connection lookup

2018-03-11 Thread Hans de Goede
Hi all, On 09-03-18 18:53, Greg Kroah-Hartman wrote: On Fri, Mar 02, 2018 at 11:20:46AM +0100, Hans de Goede wrote: From: Heikki Krogerus Several frameworks - clk, gpio, phy, pmw, etc. - maintain lookup tables for describing connections and provide custom API for handling them. This

Re: [PATCH v6 01/12] drivers: base: Unified device connection lookup

2018-03-12 Thread Hans de Goede
Hi, On 12-03-18 09:13, Heikki Krogerus wrote: On Sun, Mar 11, 2018 at 07:24:18PM +0100, Hans de Goede wrote: Hi all, On 09-03-18 18:53, Greg Kroah-Hartman wrote: On Fri, Mar 02, 2018 at 11:20:46AM +0100, Hans de Goede wrote: From: Heikki Krogerus Several frameworks - clk, gpio, phy, pmw

Re: [PATCH v7 00/12] USB Type-C device-connection, mux and switch support

2018-03-12 Thread Hans de Goede
ate an immutable branch for the platform/x86 and extcon maintainers to merge once this is done? Regards, Hans Hans de Goede (7): usb: typec: tcpm: Set USB role switch to device mode when configured as such usb: typec: tcpm: Use new Type-C switch/mux and usb-role-switch functions

Re: Regression from efi: call get_event_log before ExitBootServices

2018-03-13 Thread Hans de Goede
Hi, On 12-03-18 20:55, Thiebaud Weksteen wrote: On Mon, Mar 12, 2018 at 7:33 PM Jeremy Cline wrote: On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel < ard.biesheu...@linaro.org> wrote: On 12 March 2018 at 17:01, Jeremy Cline wrote: On 03/1

Re: Regression from efi: call get_event_log before ExitBootServices

2018-03-13 Thread Hans de Goede
Hi, On 12-03-18 22:02, Ard Biesheuvel wrote: On 12 March 2018 at 19:55, Thiebaud Weksteen wrote: On Mon, Mar 12, 2018 at 7:33 PM Jeremy Cline wrote: On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel < ard.biesheu...@linaro.org> wrote: On 12

Re: [PATCH] hwmon/sch5627: Use common error handling code in sch5627_probe()

2018-03-13 Thread Hans de Goede
Hi, On 12-03-18 22:23, SF Markus Elfring wrote: From: Markus Elfring Date: Mon, 12 Mar 2018 22:15:59 +0100 Adjust jump targets so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus

Re: Regression from efi: call get_event_log before ExitBootServices

2018-03-07 Thread Hans de Goede
Hi, On 07-03-18 09:41, Thiebaud Weksteen wrote: Hi, Thanks for testing and sending this report! This patch relies heavily on the functions exposed by the firmware. My first guess would be that some of these may not be implemented correctly by the manufacturer. Could you share more information

Re: [PATCH] ata: ahci-platform: add reset control support

2018-04-06 Thread Hans de Goede
Hi, On 06-04-18 06:48, Kunihiko Hayashi wrote: Hi Hans, On Thu, 5 Apr 2018 16:08:24 +0200 Hans de Goede wrote: Hi, On 05-04-18 16:00, Hans de Goede wrote: Hi, On 05-04-18 15:54, Thierry Reding wrote: On Thu, Apr 05, 2018 at 03:27:03PM +0200, Hans de Goede wrote: Hi, On 05-04-18 15:17

Re: [PATCH] ata: ahci-platform: add reset control support

2018-04-06 Thread Hans de Goede
Hi, On 06-04-18 11:36, Kunihiko Hayashi wrote: Hi Hans, On Fri, 6 Apr 2018 10:29:37 +0200 Hans de Goede wrote: Hi, On 06-04-18 06:48, Kunihiko Hayashi wrote: Hi Hans, On Thu, 5 Apr 2018 16:08:24 +0200 Hans de Goede wrote: Hi, On 05-04-18 16:00, Hans de Goede wrote: Hi, On 05-04-18

Re: [PATCH 2/2] efi: Add embedded peripheral firmware support

2018-04-07 Thread Hans de Goede
Hi, On 06-04-18 16:08, Luis R. Rodriguez wrote: On Thu, Apr 05, 2018 at 07:43:49AM +0200, Lukas Wunner wrote: On Wed, Apr 04, 2018 at 01:18:36PM -0400, Peter Jones wrote: On Tue, Apr 03, 2018 at 08:07:11PM +0200, Lukas Wunner wrote: * Add the EFI Firmware Volume Protocol to include/linux/efi.

[PATCH] firmware: Fix firmware documentation for recent file renames

2018-04-08 Thread Hans de Goede
firmware_class.c was split into several files under drivers/base/firmware_loader. The new main.c has the functions which /request_firmware.rst references. Signed-off-by: Hans de Goede --- Documentation/driver-api/firmware/request_firmware.rst | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH v2] firmware: Fix firmware documentation for recent file renames

2018-04-08 Thread Hans de Goede
firmware_class.c was split into several files under drivers/base/firmware_loader. The new main.c has the functions which /request_firmware.rst references. Acked-by: Luis R. Rodriguez Signed-off-by: Hans de Goede --- Changes in v2: -Fix the same issue in 2 more files -Add Luis' Ack

[PATCH v2 0/5] efi/firmware/platform-x86: Add EFI embedded fw support

2018-04-08 Thread Hans de Goede
Hi All, Here is v2 of my patch-set to add support for EFI embedded fw to the kernel. The 3 most prominent changes are: 1) Add documentation describing the EFI embedded firmware mechanism to: Documentation/driver-api/firmware/request_firmware.rst 2) Instead of having a single dmi_system_id ar

[PATCH v2 2/5] efi: Add embedded peripheral firmware support

2018-04-08 Thread Hans de Goede
Signed-off-by: Hans de Goede --- Changes in v2: -Rebased on driver-core/driver-core-next -Add documentation describing the EFI embedded firmware mechanism to: Documentation/driver-api/firmware/request_firmware.rst -Add a new EFI_EMBEDDED_FIRMWARE Kconfig bool and only build the embedded fw

[PATCH v2 3/5] platform/x86: Rename silead_dmi to touchscreen_dmi

2018-04-08 Thread Hans de Goede
: Hans de Goede --- MAINTAINERS | 2 +- drivers/platform/x86/Kconfig | 16 ++--- drivers/platform/x86/Makefile | 2 +- .../x86/{silead_dmi.c => touchscreen_dmi.c} | 66 +-- 4 files changed, 43 insertions(+),

[PATCH v2 5/5] platform/x86: touchscreen_dmi: Add info for the Chuwi Vi8 Plus tablet

2018-04-08 Thread Hans de Goede
Add touchscreen info for the Chuwi Vi8 Plus tablet. This tablet uses a Chipone ICN8505 touchscreen controller, with the firmware used by the touchscreen embedded in the EFI firmware. Signed-off-by: Hans de Goede --- drivers/platform/x86/touchscreen_dmi.c | 25 + 1 file

[PATCH v2 4/5] platform/x86: touchscreen_dmi: Add EFI embedded firmware info support

2018-04-08 Thread Hans de Goede
necessary info for the new EFI embedded-firmware code to extract these firmwares, making the touchscreen work OOTB without the user needing to manually add the firmware. Signed-off-by: Hans de Goede --- drivers/firmware/efi/embedded-firmware.c | 3 +++ drivers/platform/x86/Kconfig

[PATCH v2 1/5] efi: Export boot-services code and data as debugfs-blobs

2018-04-08 Thread Hans de Goede
: Hans de Goede --- Changes in v2: -Do not call pr_err on debugfs call failures --- arch/x86/platform/efi/quirks.c | 4 +++ drivers/firmware/efi/efi.c | 53 ++ 2 files changed, 57 insertions(+) diff --git a/arch/x86/platform/efi/quirks.c b/arch/x86/platform/efi

[PATCH v3 2/5] efi: Add embedded peripheral firmware support

2018-04-08 Thread Hans de Goede
Signed-off-by: Hans de Goede --- Changes in v2: -Rebased on driver-core/driver-core-next -Add documentation describing the EFI embedded firmware mechanism to: Documentation/driver-api/firmware/request_firmware.rst -Add a new EFI_EMBEDDED_FIRMWARE Kconfig bool and only build the embedded fw

[PATCH v3 4/5] platform/x86: touchscreen_dmi: Add EFI embedded firmware info support

2018-04-08 Thread Hans de Goede
necessary info for the new EFI embedded-firmware code to extract these firmwares, making the touchscreen work OOTB without the user needing to manually add the firmware. Signed-off-by: Hans de Goede --- drivers/firmware/efi/embedded-firmware.c | 3 +++ drivers/platform/x86/Kconfig

[PATCH v3 5/5] platform/x86: touchscreen_dmi: Add info for the Chuwi Vi8 Plus tablet

2018-04-08 Thread Hans de Goede
Add touchscreen info for the Chuwi Vi8 Plus tablet. This tablet uses a Chipone ICN8505 touchscreen controller, with the firmware used by the touchscreen embedded in the EFI firmware. Signed-off-by: Hans de Goede --- drivers/platform/x86/touchscreen_dmi.c | 25 + 1 file

[PATCH v3 3/5] platform/x86: Rename silead_dmi to touchscreen_dmi

2018-04-08 Thread Hans de Goede
: Hans de Goede --- MAINTAINERS | 2 +- drivers/platform/x86/Kconfig | 16 ++--- drivers/platform/x86/Makefile | 2 +- .../x86/{silead_dmi.c => touchscreen_dmi.c} | 66 +-- 4 files changed, 43 insertions(+),

[PATCH v3 0/5] efi/firmware/platform-x86: Add EFI embedded fw support

2018-04-08 Thread Hans de Goede
Hi All, Sorry for sending a v3 so soon after v2, I got the property name wrong in the documentation added in v2 and of course noticed that minutes after sending v2. This version fixes this. Here is the v2 coverletter again: Here is v2 of my patch-set to add support for EFI embedded fw to the ker

[PATCH v3 1/5] efi: Export boot-services code and data as debugfs-blobs

2018-04-08 Thread Hans de Goede
: Hans de Goede --- Changes in v2: -Do not call pr_err on debugfs call failures --- arch/x86/platform/efi/quirks.c | 4 +++ drivers/firmware/efi/efi.c | 53 ++ 2 files changed, 57 insertions(+) diff --git a/arch/x86/platform/efi/quirks.c b/arch/x86/platform/efi

Re: [PATCH v8 01/12] drivers: base: Unified device connection lookup

2018-03-20 Thread Hans de Goede
Hi, On 20-03-18 11:32, Heikki Krogerus wrote: On Tue, Mar 20, 2018 at 12:04:12PM +0200, Heikki Krogerus wrote: +void device_connection_remove(struct device_connection *con) +{ + mutex_lock(&devcon_lock); + list_del_rcu(&con->list); See, rcu? True. I'll send one more version. B

Re: [PATCH] ata: ahci-platform: add reset control support

2018-03-23 Thread Hans de Goede
with all ahci controller instances. Signed-off-by: Kunihiko Hayashi Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans --- .../devicetree/bindings/ata/ahci-platform.txt | 1 + drivers/ata/ahci.h | 1 + drivers/ata

Re: [PATCH] Revert "ata: ahci-platform: add reset control support"

2018-04-09 Thread Hans de Goede
Thierry Reding Suggested-by: Hans de Goede Signed-off-by: Kunihiko Hayashi Acked-by: Hans de Goede Regards, Hans --- .../devicetree/bindings/ata/ahci-platform.txt | 1 - drivers/ata/ahci.h | 1 - drivers/ata/libahci_platform.c

Re: Regression from efi: call get_event_log before ExitBootServices

2018-03-08 Thread Hans de Goede
Hi, On 07-03-18 12:34, Javier Martinez Canillas wrote: On 03/07/2018 12:10 PM, Hans de Goede wrote: Both according to the BIOS and to the /sys/class/tpm/tpm0/device/description file it is a TPM 2.0. I see, so you can choose enabling the TPM 1.2 or TPM 2.0 device? At least that'

Re: Regression from efi: call get_event_log before ExitBootServices

2018-03-09 Thread Hans de Goede
Hi, On 08-03-18 18:26, Jeremy Cline wrote: On 03/08/2018 11:50 AM, Hans de Goede wrote: Hi, On 07-03-18 12:34, Javier Martinez Canillas wrote: Are you also able to read the TPM event logs? $ hexdump /sys/kernel/security/tpm0/binary_bios_measurements Yes for me that outputs a lot of

[PATCH] platform/x86: silead_dmi: Add entry for the Yours Y8W81 tablet

2018-03-09 Thread Hans de Goede
n ALC5640 audio codec) and the Yours Y8W81 being REV21 (and having an ALC5651 audio codec). The wifi, accelerometer and touchscreen are identical on both. Signed-off-by: Hans de Goede --- drivers/platform/x86/silead_dmi.c | 8 1 file changed, 8 insertions(+) diff --git a/drive

Re: hwmon/sch5627: Use common error handling code in sch5627_probe()

2018-03-13 Thread Hans de Goede
Hi, On 13-03-18 09:25, SF Markus Elfring wrote: Adjust jump targets so that a bit of exception handling can be better reused at the end of this function. … goto-s going to a label calling another goto is completely unreadable. I got an other software development view. I really do not see

Re: [Possible REGRESSION, 4.16-rc4] Error updating SMART data during runtime and could not connect to lvmetad at some boot attempts

2018-03-14 Thread Hans de Goede
Hi, On 14-03-18 12:01, Martin Steigerwald wrote: Hans de Goede - 11.03.18, 15:37: Hi Martin, On 11-03-18 09:20, Martin Steigerwald wrote: Hello. Since 4.16-rc4 (upgraded from 4.15.2 which worked) I have an issue with SMART checks occassionally failing like this: smartd[28017]: Device: /dev

Re: [PATCH 2/2] mmc: Add mmc_force_detect_change_begin / _end functions

2018-09-26 Thread Hans de Goede
Hi, On 26-09-18 16:44, Frieder Schrempf wrote: Hi, On Fri, Feb 09, 2018 at 03:01:00PM +0100, Ulf Hansson wrote: [...] >> > I'd like to know if any progress has been made on that problem (I may >> > have missed patches). >> > Had you had the time to look at the issue? >> >> I have looked at

Re: [PATCH v2 05/13] i2c: acpi: Return error pointers from i2c_acpi_new_device()

2018-11-27 Thread Hans de Goede
clients again. But at the same time we would like to bail out if the error seems unrecoverable, such as out of memory condition. To achieve this, return error pointer in some cases. Signed-off-by: Andy Shevchenko Reviewed-by: Hans de Goede --- drivers/i2c/i2c-core-acpi.c | 9 ++--- 1 file

Re: [PATCH v2 05/13] i2c: acpi: Return error pointers from i2c_acpi_new_device()

2018-11-27 Thread Hans de Goede
Hi, On 27-11-18 14:46, Andy Shevchenko wrote: On Tue, Nov 27, 2018 at 01:49:53PM +0200, Mika Westerberg wrote: On Tue, Nov 27, 2018 at 10:16:25AM +0100, Hans de Goede wrote: One problem is that i2c_new_device() currently simply returns NULL on all errors. Andy, you could take a look how much

Re: [PATCH v3 05/13] i2c: acpi: Return error pointers from i2c_acpi_new_device()

2018-11-27 Thread Hans de Goede
Hi, On 27-11-18 16:37, Andy Shevchenko wrote: The caller would like to know the reason why the i2c_acpi_new_device() fails. For example, if adapter is not available, it might be in the future and we would like to re-probe the clients again. But at the same time we would like to bail out if the e

Re: [PATCH v3 05/13] i2c: acpi: Return error pointers from i2c_acpi_new_device()

2018-11-27 Thread Hans de Goede
Hi, On 27-11-18 17:14, Hans de Goede wrote: Hi, On 27-11-18 16:37, Andy Shevchenko wrote: The caller would like to know the reason why the i2c_acpi_new_device() fails. For example, if adapter is not available, it might be in the future and we would like to re-probe the clients again. But at

Re: [PATCH v3 05/13] i2c: acpi: Return error pointers from i2c_acpi_new_device()

2018-11-27 Thread Hans de Goede
Hi, On 27-11-18 20:27, Andy Shevchenko wrote: On Tue, Nov 27, 2018 at 05:14:06PM +0100, Hans de Goede wrote: On 27-11-18 16:37, Andy Shevchenko wrote: The caller would like to know the reason why the i2c_acpi_new_device() fails. For example, if adapter is not available, it might be in the

Re: [PATCH v1 00/15] i2c-multi-instantiate: Adapt for INT3515 and alike

2018-11-21 Thread Hans de Goede
athan. Patches 1-5, 7-13 and 15 are: Reviewed-by: Hans de Goede I will send separate replies to: [PATCH v1 06/15] i2c: acpi: Assign fwnode for devices created via i2c_acpi_new_device() [PATCH v1 14/15] ACPI / scan: Create platform device for BOSC0200 ACPI nodes Which are both a NACK from m

Re: [PATCH v1 06/15] i2c: acpi: Assign fwnode for devices created via i2c_acpi_new_device()

2018-11-21 Thread Hans de Goede
Hi, On 20-11-18 16:59, Andy Shevchenko wrote: i2c_acpi_new_device() doesn't assign fwnode like it's done, for example, in i2c_acpi_register_devices() path. Assign fwnode in i2c_acpi_new_device() as it's done elsewhere. Signed-off-by: Andy Shevchenko As already mentioned in my reply to the c

Re: [PATCH v1 09/15] platform/x86: i2c-multi-instantiate: Count I2cSerialBus() resources

2018-11-21 Thread Hans de Goede
Hi, On 20-11-18 16:59, Andy Shevchenko wrote: Instead of relying on hard coded and thus expected number of I2C clients, count the real amount provided by firmware. This allows to support non-fixed amount of the slaves. Signed-off-by: Andy Shevchenko --- drivers/platform/x86/i2c-multi-instan

Re: [PATCH v1 00/15] i2c-multi-instantiate: Adapt for INT3515 and alike

2018-11-21 Thread Hans de Goede
Hi, On 21-11-18 12:27, Hans de Goede wrote: Hi, On 20-11-18 16:59, Andy Shevchenko wrote: Currently i2c-multi-instantiate driver does not support the case of INT3515 USB PD device, where: - Interrupt() is used instead of GpioInt() - All slaves may be the same from IP point of view - There

Re: [PATCH v1 14/15] ACPI / scan: Create platform device for BOSC0200 ACPI nodes

2018-11-21 Thread Hans de Goede
HI, On 20-11-18 16:59, Andy Shevchenko wrote: On some laptops the ACPI device with BOSC0200 _HID is representing two accelerometers under one node. We add an ID to the I2C multi instantiate list to enumerate all I2C slaves correctly. For reference here is the relevant DSDT blurb from the Yoga

Re: [PATCH v5 00/15] i2c-multi-instantiate: Adapt for INT3515 and alike

2018-11-28 Thread Hans de Goede
s are warmly welcome. In v5: - unmess with patches 3 and 4 (there were squashed by my mistake) - other than above no code change from v4 v5 looks good to me, you can add my: Reviewed-by: Hans de Goede To the patches which don't have this yet. Regards, Hans In v4: - direc

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-12-02 Thread Hans de Goede
Hi, On 01-11-18 07:55, Mogens Jensen wrote: ‐‐‐ Original Message ‐‐‐ On Wednesday, October 31, 2018 9:29 AM, Hans de Goede wrote: Hi, On 31-10-18 07:02, Mogens Jensen wrote: ‐‐‐ Original Message ‐‐‐ On Tuesday, October 30, 2018 7:10 PM, Hans de Goede hdego...@redhat.com

[PATCH] platform/x86: touchscreen_dmi: Add info for the Mediacom Flexbook Edge 11

2018-12-04 Thread Hans de Goede
Add a DMI match for the Mediacom Flexbook Edge 11, this is the same hw as the Trekstor Primebook C11, so we use the same settings. Reported-by: rmbg Signed-off-by: Hans de Goede --- drivers/platform/x86/touchscreen_dmi.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers

Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-11 Thread Hans de Goede
Hi, On 11/7/18 5:53 AM, Daniel Drake wrote: On Mon, Nov 5, 2018 at 1:19 AM Pavel Machek wrote: Plus, I don't think "100% charge" is right test for "battery full". At least on thinkpads, there's configuration option, and it is common _not_ to charge batterry above 95% or so (to increase its lif

[PATCH 0/1] platform/x86: touchscreen_dmi: Add info for the "Connect Tablet 9" tablet

2018-07-01 Thread Hans de Goede
Hi, Note this patch applies on top of linux-platform-drivers-x86/review-andy which has the patches to alphabetically sort and rename touchscreen_dmi.c. Regards, Hans

[PATCH] platform/x86: touchscreen_dmi: Add info for the "Connect Tablet 9" tablet

2018-07-01 Thread Hans de Goede
Add touchscreen info for the "Connect Tablet 9" tablet. This appears to be a variant of the same hardware as the ITworks TW891 tablet, but it needs different firmware for the touchscreen to fonction properly. Signed-off-by: Hans de Goede --- drivers/platform/x86/touchscreen_

[PATCH] ahci: Disable LPM on Lenovo 50 series laptops with a too old BIOS

2018-07-01 Thread Hans de Goede
o I've chosen to set the date to which we compare to one day past the release date of the 2.34 BIOS. I plan to fix this with a follow up commit once I've the necessary info. Cc: sta...@vger.kernel.org Signed-off-by: Hans de Goede --- drivers/ata/ahci.c| 59 ++

Re: [RFC PATCH] ata: ahci: Enable DEVSLP by default on x86 modern standby platform

2018-07-02 Thread Hans de Goede
Hi, On 02-07-18 22:21, Tejun Heo wrote: On Mon, Jul 02, 2018 at 12:08:45PM -0700, Srinivas Pandruvada wrote: From: Srinivas One of the requirement for modern x86 system to enter lowest power mode (SLP_S0) is SATA IP block to be off. This is true even during when platform is suspended to idle

Re: [RFC PATCH] ata: ahci: Enable DEVSLP by default on x86 modern standby platform

2018-07-03 Thread Hans de Goede
Hi, On 03-07-18 00:08, Srinivas Pandruvada wrote: Hi Hans, On Mon, 2018-07-02 at 23:27 +0200, Hans de Goede wrote: SATA IP block doesn't get turned off till SATA is in DEVSLP mode. Here user has to either use scsi-host sysfs or tools like powertop to set the sata

Re: [RFC PATCH] ata: ahci: Enable DEVSLP by default on x86 modern standby platform

2018-07-03 Thread Hans de Goede
Hi, On 03-07-18 10:57, Hans de Goede wrote: Hi, On 03-07-18 00:08, Srinivas Pandruvada wrote: Hi Hans, On Mon, 2018-07-02 at 23:27 +0200, Hans de Goede wrote: SATA IP block doesn't get turned off till SATA is in DEVSLP mode. Here user has to either use scsi-host sysfs or tools

Re: simple-framebuffer enquire

2018-06-26 Thread Hans de Goede
Hi, On 25-06-18 15:29, Michael Nazzareno Trimarchi wrote: Hi Hans In order to let it even registered the simplefb I have added this change. According on what I understand from the code seems that this is the way to acquire memory with the correct attribute diff --git a/drivers/video/fbdev/simp

Re: simple-framebuffer enquire

2018-06-26 Thread Hans de Goede
Hi, On 26-06-18 15:29, Michael Nazzareno Trimarchi wrote: Hi to be more specific On Tue, Jun 26, 2018 at 3:06 PM, Michael Nazzareno Trimarchi wrote: Hi On Tue., 26 Jun. 2018, 12:01 pm Hans de Goede, wrote: Hi, On 25-06-18 15:29, Michael Nazzareno Trimarchi wrote: Hi Hans In order to

Re: simple-framebuffer enquire

2018-06-26 Thread Hans de Goede
Hi, On 26-06-18 16:42, Michael Nazzareno Trimarchi wrote: Hi Hans On Tue, Jun 26, 2018 at 3:38 PM, Michael Nazzareno Trimarchi wrote: Hi On Tue, Jun 26, 2018 at 3:36 PM, Hans de Goede wrote: Hi, On 26-06-18 15:29, Michael Nazzareno Trimarchi wrote: Hi to be more specific On Tue, Jun

Re: simple-framebuffer enquire

2018-06-26 Thread Hans de Goede
Hi, On 26-06-18 18:35, Michael Nazzareno Trimarchi wrote: Hi Hans On Tue, Jun 26, 2018 at 4:47 PM, Hans de Goede wrote: Hi, On 26-06-18 16:42, Michael Nazzareno Trimarchi wrote: Hi Hans On Tue, Jun 26, 2018 at 3:38 PM, Michael Nazzareno Trimarchi wrote: Hi On Tue, Jun 26, 2018 at 3

Re: staging: rtl8723bs: bug or pointless if else ?

2018-06-28 Thread Hans de Goede
Hi, On 28-06-18 09:43, Michael Straube wrote: Hi, I stumbled upon the following if else construct in drivers/staging/rtl8723bs/os_dep/sdio_intf.c:618     if (pwrpriv->bInternalAutoSuspend)     {     ret = rtw_resume_process(padapter);     }     else     {

Re: staging: rtl8723bs: bug or pointless if else ?

2018-06-28 Thread Hans de Goede
Hi, On 28-06-18 17:00, Michael Straube wrote: On 06/28/18 11:34, Bastien Nocera wrote: On Thu, 2018-06-28 at 10:22 +0200, Hans de Goede wrote: Hi, On 28-06-18 09:43, Michael Straube wrote: Hi, I stumbled upon the following if else construct in drivers/staging/rtl8723bs/os_dep/sdio_intf.c

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

2018-05-13 Thread Hans de Goede
Hi, On 05/04/2018 06:56 AM, Ard Biesheuvel wrote: Hi Hans, One comment below, which I missed in review before. On 29 April 2018 at 11:35, Hans de Goede wrote: Just like with PCI options ROMs, which we save in the setup_efi_pci* functions from arch/x86/boot/compressed/eboot.c, the EFI code

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

2018-05-13 Thread Hans de Goede
Hi, On 05/03/2018 11:31 PM, Luis R. Rodriguez wrote: On Wed, May 02, 2018 at 04:49:53PM +0200, Hans de Goede wrote: Hi, On 05/01/2018 09:29 PM, Andy Lutomirski wrote: On Sun, Apr 29, 2018 at 2:36 AM Hans de Goede wrote: +The EFI embedded-fw code works by scanning all EFI_BOOT_SERVICES_CODE

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

2018-05-13 Thread Hans de Goede
Hi, On 05/03/2018 11:35 PM, Andy Lutomirski wrote: On Thu, May 3, 2018 at 3:31 PM Luis R. Rodriguez wrote: On Wed, May 02, 2018 at 04:49:53PM +0200, Hans de Goede wrote: Hi, On 05/01/2018 09:29 PM, Andy Lutomirski wrote: On Sun, Apr 29, 2018 at 2:36 AM Hans de Goede wrote: +The EFI

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

2018-05-13 Thread Hans de Goede
Hi, On 05/13/2018 12:43 PM, Ard Biesheuvel wrote: On 13 May 2018 at 13:03, Hans de Goede wrote: Hi, On 05/04/2018 06:56 AM, Ard Biesheuvel wrote: Hi Hans, One comment below, which I missed in review before. On 29 April 2018 at 11:35, Hans de Goede wrote: Just like with PCI options

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

2018-05-13 Thread Hans de Goede
Hi, On 05/08/2018 06:12 PM, Luis R. Rodriguez wrote: On Fri, May 04, 2018 at 07:54:28AM +0200, Ard Biesheuvel wrote: On 4 May 2018 at 01:29, Luis R. Rodriguez wrote: On Sun, Apr 29, 2018 at 11:35:55AM +0200, Hans de Goede wrote: [...] diff --git a/Documentation/driver-api/firmware

Re: [PATCH v1] platform/x86: silead_dmi: Add touchscreen info for the Onda V891w V3 tablet

2018-06-17 Thread Hans de Goede
Hi, Thank you for this patch. Please rebase this patch on top of: http://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git/shortlog/refs/heads/review-andy Where the entries have been sorted alphabetically and the file has been renamed to touchscreen_dmi.c On 17-06-18 12:37, youlin

Re: [PATCH V2] platform/x86: touchscreen_dmi: Add info for ONDA V891W Dual OS

2018-06-17 Thread Hans de Goede
Hi, Thanks. On 17-06-18 15:12, youling257 wrote: Some commit message here would be good. Signed-off-by: youling257 Otherwise looks good to me: Reviewed-by: Hans de Goede Regards, Hans --- drivers/platform/x86/touchscreen_dmi.c | 27 ++ 1 file changed, 27

Re: [PATCH v4] platform/x86: touchscreen_dmi: Add info for the ONDA V891W Dual OS tablet

2018-06-18 Thread Hans de Goede
Hi, On 18-06-18 01:58, youling257 wrote: Add touchscreen info for the ONDA V891W Dual OS tablet Nitpick: still missing a period '.' at the end, this should be: Add touchscreen info for the ONDA V891W Dual OS tablet. Reviewed-by: Hans de Goede Signed-off-by: youling257 As Andy

<    1   2   3   4   5   6   7   8   9   10   >