Re: staging: rtl8723bs: bug or pointless if else ?

[Hans de Goede]

Hi,

On 28-06-18 09:43, Michael Straube wrote:

Hi,

I stumbled upon the following if else construct in
drivers/staging/rtl8723bs/os_dep/sdio_intf.c:618

         if (pwrpriv->bInternalAutoSuspend)
         {
                 ret = rtw_resume_process(padapter);
         }
         else
         {
                 if (pwrpriv->wowlan_mode || pwrpriv->wowlan_ap_mode)
                 {
                         ret = rtw_resume_process(padapter);
                 }
                 else
                 {
                         ret = rtw_resume_process(padapter);
                 }
         }

It does not matter if the conditions are true or not,
ret is always set to:

ret = rtw_resume_process(padapter)

Is this a bug or is the if else construct just pointless?

It probably is just pointless, my guess would be that once
upon a time there was a difference in the paths and at some
point that difference went away.

Regards,

Hans