Hi
On 02/12/2013 10:20 PM, Joe Perches wrote:
His email bounces
jwil...@redhat.com should work I think.
Note I think this may be the right call,
but asking him directly is better :)
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a mes
Hi,
First of all, sorry for not reporting this earlier in the cycle, but
I only got this (new) laptop yesterday ...
With both the 3.5 kernels as well as with the 3.6 kernels, there is
quite some unhappiness being reported in dmesg about the ACPI
tables, esp. surrounding BAT0. But with 3.5 I do g
Hi,
Applied to my gspca tree and included in my pull-req for 3.7 which I just send
out.
Thanks,
Hans
On 09/06/2012 05:24 PM, Peter Senna Tschudin wrote:
From: Peter Senna Tschudin
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplifi
Hi,
On 06/26/2013 11:16 PM, Maxime Ripard wrote:
Hi everyone,
It also finally adds a clocksource from the free running counter found in the
A10/A13 SoCs.
Hmm, have you benchmarked this? There have been reports from linux-sunxi kernel
users (xbmc project) that the waiting for the latch is
Hi,
On 06/27/2013 11:43 AM, Maxime Ripard wrote:
On Thu, Jun 27, 2013 at 11:27:02AM +0200, Hans de Goede wrote:
Hi,
On 06/26/2013 11:16 PM, Maxime Ripard wrote:
Hi everyone,
It also finally adds a clocksource from the free running counter found in the
A10/A13 SoCs.
Hmm, have you
Hi,
On 06/27/2013 06:54 PM, Maxime Ripard wrote:
On Thu, Jun 27, 2013 at 11:54:11AM +0200, Hans de Goede wrote:
Hi,
On 06/27/2013 11:43 AM, Maxime Ripard wrote:
On Thu, Jun 27, 2013 at 11:27:02AM +0200, Hans de Goede wrote:
Hi,
On 06/26/2013 11:16 PM, Maxime Ripard wrote:
Hi everyone
Hi,
On 06/27/2013 10:26 PM, Siarhei Siamashka wrote:
On Thu, 27 Jun 2013 18:54:36 +0200
Maxime Ripard wrote:
On Thu, Jun 27, 2013 at 11:54:11AM +0200, Hans de Goede wrote:
I notice that unlike the sunxi-3.4 code you don't do any locking,
so how do you stop 2 clocksource calls from r
Hi,
Thanks for the patch I've added this to my "gspca" tree, and this
will be included in my next pull-request to Mauro for 3.12
Regards,
Hans
On 08/05/2013 10:16 PM, Alexey Khoroshilov wrote:
If v4l2_fh_open() fails in dev_open(), gspca_dev->module left locked.
The patch adds module_put(gspc
Mauro,
Can you pick this one up? I don't have anything pending for gspca,
and to create a tree + pullreq for just a trivial patch is not really
efficient.
Alternatively I can put it on my TODO for when there is more gspca work,
esp. since there is not really a need to hurry with merging this.
R
Hi John,
Thanks for the new driver! Unfortunately the driver is still
using gspca's own/deprecated control mechanism rather then
the new v4l2-control framework which all drivers now a days
use.
And we've just finished converting all the gspca sub-drivers
to using this new control framework, and
Thanks for fixing this for me!
Acked-by: Hans de Goede
On 07/31/2012 09:56 PM, Mauro Carvalho Chehab wrote:
Em 31-07-2012 14:22, Randy Dunlap escreveu:
drivers/built-in.o: In function `radio_tea5777_set_freq':
radio-tea5777.c:(.text+0x4d8704): undefined reference to `__udivdi3'
v_register" [drivers/media/radio/shark2.ko] undefined!
ERROR: "led_classdev_unregister" [drivers/media/radio/shark2.ko] undefined!
which is seen if RADIO_SHARK2 is enabled, but LEDS_CLASS is not.
Since RADIO_SHARK2 depends on NEW_LEDS and LEDS_CLASS, select both if
it is enabled.
Cc: Han
Hi,
On 08/22/2012 08:57 PM, Arnd Bergmann wrote:
On Wednesday 22 August 2012, Guenter Roeck wrote:
On Wed, Aug 22, 2012 at 05:22:26PM +0200, Hans de Goede wrote:
Hi,
I've a better fix for this here:
http://git.linuxtv.org/hgoede/gspca.git/shortlog/refs/heads/media-for_v3.6
I already s
ERROR: "led_classdev_unregister" [drivers/media/radio/shark2.ko]
undefined!
Reported-by: Dadiv Rientjes
Cc: Hans de Goede
Signed-off-by: Mauro Carvalho Chehab
diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
index 8090b87..be68ec2 100644
--- a/drivers/media/radio
Hi,
On 08/09/2012 10:03 PM, David Rientjes wrote:
On Thu, 9 Aug 2012, Mauro Carvalho Chehab wrote:
Yeah, that would work as well, although the code would look uglier.
IMHO, using select/depend is better.
Agreed, I think it should be "depends on LEDS_CLASS" rather than select
it if there is
Hi,
On 08/09/2012 04:42 PM, Guenter Roeck wrote:
On Thu, Aug 09, 2012 at 08:55:26PM +0800, Fengguang Wu wrote:
Hi Guenter,
This commit triggered an oops which can be fixed by the attached diff.
Should it be folded into the original one (preferable for me), or be
resent as a standalone patch?
Reported-by: Dadiv Rientjes
Signed-off-by: Hans de Goede
---
drivers/media/radio/radio-shark2.c | 27 ---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/drivers/media/radio/radio-shark2.c
b/drivers/media/radio/radio-shark2.c
index b9575de..e593d5a 100644
Reported-by: Dadiv Rientjes
Signed-off-by: Hans de Goede
---
drivers/media/radio/radio-shark.c | 26 --
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git a/drivers/media/radio/radio-shark.c
b/drivers/media/radio/radio-shark.c
index c2ead23..f746ed0 100644
Hi,
On 08/10/2012 10:15 PM, Mauro Carvalho Chehab wrote:
Em 10-08-2012 16:58, Hans de Goede escreveu:
Reported-by: Dadiv Rientjes
Signed-off-by: Hans de Goede
---
drivers/media/radio/radio-shark.c | 26 --
1 file changed, 24 insertions(+), 2 deletions(-)
diff
Hi All,
Here is the second revision of my patch-set to fix the build breakage when
the radio-shark* drivers are enabled and CONFIG_LED_CLASS is not enabled.
This new version introduces 2 new cleanup / preparation patches, and take
into account the remarks from Mauro's review of v1.
Regards,
Han
Recent kernels properly clear the usb intfdata pointer when another
driver fails to bind (in the radio-shark* case the usbhid driver would try
to bind first.
Signed-off-by: Hans de Goede
---
drivers/media/radio/radio-shark.c | 9 -
drivers/media/radio/radio-shark2.c | 9 -
2
Signed-off-by: Hans de Goede
---
drivers/media/radio/radio-shark.c | 135 ++
1 file changed, 79 insertions(+), 56 deletions(-)
diff --git a/drivers/media/radio/radio-shark.c
b/drivers/media/radio/radio-shark.c
index 05e12bf..e1970bf 100644
--- a/drivers
Signed-off-by: Hans de Goede
---
drivers/media/radio/radio-shark2.c | 122 ++---
1 file changed, 73 insertions(+), 49 deletions(-)
diff --git a/drivers/media/radio/radio-shark2.c
b/drivers/media/radio/radio-shark2.c
index 217483c..7b4efdf 100644
--- a/drivers
This removes the need for shark_led_work to take the v4l2 lock.
Signed-off-by: Hans de Goede
---
drivers/media/radio/radio-shark.c | 13 ++---
drivers/media/radio/radio-shark2.c | 12 ++--
2 files changed, 4 insertions(+), 21 deletions(-)
diff --git a/drivers/media/radio/radio
Hi,
On 08/15/2012 07:13 AM, Miklos Szeredi wrote:
Suspend oopses in generic_ide_suspend() because dev_get_drvdata()
returns NULL (dev->p->driver_data == NULL) and this function is not
prepared for this.
I bisected it to 0998d063 (device-core: Ensure drvdata = NULL when no
driver is bound). Rev
Hi,
On 08/15/2012 09:59 PM, Rafael J. Wysocki wrote:
On Wednesday, August 15, 2012, Hans de Goede wrote:
Hi,
On 08/15/2012 07:13 AM, Miklos Szeredi wrote:
Suspend oopses in generic_ide_suspend() because dev_get_drvdata()
returns NULL (dev->p->driver_data == NULL) and this function
Hi all,
On 08/16/2012 10:02 PM, Rafael J. Wysocki wrote:
On Thursday, August 16, 2012, Alan Stern wrote:
On Thu, 16 Aug 2012, Miklos Szeredi wrote:
Yes, this appears to work. Following patch fixes the suspend oops.
Thanks,
Miklos
OK
Miklos, can you please send that to Dave with a proper
Hi,
On 08/17/2012 04:27 PM, Alan Stern wrote:
On Fri, 17 Aug 2012, Alan Stern wrote:
On Fri, 17 Aug 2012, Hans de Goede wrote:
No my patch was a hack to undo the results of the commit causing
the regression in the IDE case. But Alan's approach clearly is
much better! Once we are
Hi,
On 07/09/2012 01:33 PM, Martin-Éric Racine wrote:
Hmm, this is then likely caused by the new isoc bandwidth negotiation code
in 3.2, unfortunately the vc032x driver is one of the few gspca drivers
for which I don't have a cam to test with. Can you try to build your own
kernel from source?
Hi,
On 10/10/2012 10:31 PM, Henrik Rydberg wrote:
Hi Hans, Alan, Greg,
commit 3d97ff63f8997761f12c8fbe8082996c6eeaba1a
Author: Hans de Goede
Date: Wed Jul 4 09:18:03 2012 +0200
usbdevfs: Use scatter-gather lists for large bulk transfers
breaks an usb programming cable over here. The
tree?
Henrik, Very nice fix, thanks for debugging this.
Hans, any objection to me taking this?
No objections please take it, this patch is:
Acked-by: Hans de Goede
And stating the obvious:
CC: sta...@vger.kernel.org
To be backported to 3.6 only
Thanks & Regards,
Hans
--
To unsubsc
Hi,
On 10/12/2012 05:08 PM, Henrik Rydberg wrote:
Hi Alan,
Instead of introducing a new local variable, why not simply update
uurb->buffer? That's what we do elsewhere in the code.
It seemed fragile, due to these scary lines:
if (is_in && uurb->buffer_length > 0)
a
Hi,
On 10/13/2012 12:20 PM, Henrik Rydberg wrote:
The handling of large output bulk transfers is broken; the same user
page is read over and over again. Fixed with this patch.
Cc: sta...@kernel.org
Acked-by: Peter Stuge
Acked-by: Hans de Goede
Acked-by: Alan Stern
Signed-off-by: Henrik
Hi,
On 07/08/2012 03:01 PM, Martin-Éric Racine wrote:
2012/6/17 Martin-Éric Racine :
pe, 2012-06-15 kello 23:41 -0500, Jonathan Nieder kirjoitti:
Martin-Éric Racine wrote:
usb 1-7: new high-speed USB device number 3 using ehci_hcd
[...]
usb 1-7: New USB device found, idVendor=0ac8, idProdu
Adrian Bunk wrote:
abituguru3_read_increment_offset() can become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Looks good, good catch.
Acked-by: Hans de Goede <[EMAIL PROTECTED]>
---
--- linux-2.6.23-rc1-mm1/drivers/hwmon/abituguru3.c.old 2007-07-26
08:56:33.000
Mark M. Hoffman wrote:
Hi Justin:
(added some CCs)
* Justin Piszcz <[EMAIL PROTECTED]> [2007-10-14 15:30:18 -0400]:
As a regular user, I cannot see the sensors on the A-bit board, but I can
see the CPU temperature, how come I can see one but not the other?
What does "which sensors" say as
Jim Cromie wrote:
this patchset (on hwmon-git) re-introduces superio_locks module,
previously RFC'd here, where I 'borrowed' another thread..
http://marc.info/?l=linux-kernel&m=115821759424601&w=2
The module shares out slots/shared-reservations containing
a mutex, so that multiple modules can
Jean Delvare wrote:
On Wed, 21 Feb 2007 15:19:44 -0500, Dave Jones wrote:
Ah, Fedora has this horror in its initscripts (which explains why I missed
it in my grep)..
# Initialize ACPI bits
if [ -d /proc/acpi ]; then
for module in /lib/modules/$unamer/kernel/drivers/acpi/* ; do
modul
Dmitry Torokhov wrote:
On 6/13/07, Jiri Kosina <[EMAIL PROTECTED]> wrote:
On Wed, 13 Jun 2007, Hans de Goede wrote:
> Good to hear, so as everyone smees to agree, shall I write a (massive,
> complex, intrusive) patch to fix this, or are there until now silent
> parties tha
ngs for ID 0x21f, the real find and for
0x222, goto.
Signed-off-by: Hans de Goede <[EMAIL PROTECTED]>
--- linux-2.6.21.x86_64/drivers/hid/hid-input.c.hut 2007-06-12 19:26:58.0 +0200
+++ linux-2.6.21.x86_64/drivers/hid/hid-input.c 2007-06-12 19:33:32.0 +0200
@@ -598,7 +598,9 @@
Hi all,
As some of you might know from my earlier post/thread about atkbd and softraw,
I'm currently working on getting keyboards with internet/easy access keys to
work painlessly / plug and play.
In order to be able to better test / develop this I've bought 2 cheap such
keyboards today, one
H. Peter Anvin wrote:
Hans de Goede wrote:
In order to be able to better test / develop this I've bought 2 cheap
such keyboards today, one ps2 and one both usb and ps2 capable.
When comparing usb vs ps2 / testing the keycodes generated for the easy
access
keys on my trust (microsoft compa
Jiri Kosina wrote:
On Tue, 12 Jun 2007, H. Peter Anvin wrote:
In PS/2 mode it reports E0 32 which gets converted to keycode 150. In
USB mode it reports E0 02 which gets converted to keycode 172.
I don't know if it's the keyboard itself that's being inconsistent, or
if it is the table in usbkbd
abitguru breaks random machines, we probably should DMI whitelist,
too.
I never said it was breaking machines, just that it was accessing
arbitrary I/O ports.
This was already discussed with the driver's author (Hans de Goede,
Cc'd) and I think we agreed on the principle, but it didn
Hi all,
First a short intro I'm a Linux enthousiast and developer. I mainly write
userspace code, but I've also written 2 kernel drivers of which one is in the
mainline and the other is waiting for review.
I've been experimenting with getting the internetkeys on several keyboards to
work. My b
Vojtech Pavlik wrote:
On Thu, Jun 07, 2007 at 10:21:33AM +0200, Hans de Goede wrote:
Hans,
I've been experimenting with getting the internetkeys on several
keyboards to work. My biggest problem with this currently is the
following:
Step 1: press key, dmesg says:
atkbd.c: Un
Vojtech Pavlik wrote:
On Thu, Jun 07, 2007 at 04:55:23PM +0200, Hans de Goede wrote:
2) Somehow fix things so that selecting the right model in gnome/kde
keyboard-preferences will make the keys work. Like it does now with
softraw=0. Which leads me to asking what are the downsides of
Jean Delvare wrote:
Hi all,
I am resigning from my role as hardware monitoring subsystem
(drivers/hwmon) maintainer. This is too much work for me, I do not have
the necessary bandwidth to review all the incoming patches, in
particular new drivers, in a timely manner. Patch authors have been
comp
Rudolf Marek wrote:
Hello all,
Maybe we could try following:
1) person post the driver
2) quick review could be done critical fixes only, driver goes to -mm
3) review that goes deeper - check for interface conformity and all the
stuff which could break - fixes for non-critical stuff
4) after
Krzysztof Helt wrote:
This is comments from someone who is newbie to this list.
1a) We need a set of review guidelines / a review checklist.
Here is a start:
Maybe these guidelines can be described in more details and with
links or names of documents with more description.
Yes they should,
Hi,
On 09/21/2016 10:04 AM, Icenowy Zheng wrote:
On some newer Allwinner SoCs (H3 or A64), the PHY0 can be either routed to
the MUSB controller (which is an OTG controller) or the OHCI/EHCI pair
(which is a Host-only controller, but more stable and easy to implement).
This property marks whethe
Hi,
On 09/21/2016 10:19 AM, Icenowy Zheng wrote:
21.09.2016, 15:10, "Hans de Goede" :
Hi,
On 09/21/2016 10:04 AM, Icenowy Zheng wrote:
On some newer Allwinner SoCs (H3 or A64), the PHY0 can be either routed to
the MUSB controller (which is an OTG controller) or the OHCI/EHCI pa
for LCD panel, and one for
additional modules. Also there is CSI/DSI connector.
Signed-off-by: Stefan Mavrodiev
The new looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
Changes for v2:
- Removed unused power nodes
- Removed default-trigger for green led
Hi,
On 20-06-16 18:30, Chen-Yu Tsai wrote:
Hi,
On Mon, Jun 20, 2016 at 11:44 PM, Maxime Ripard
wrote:
Hi,
On Tue, Jun 14, 2016 at 09:19:58PM +0800, Chen-Yu Tsai wrote:
On Tue, Jun 14, 2016 at 8:59 PM, Quentin Schulz
wrote:
Hi,
On 13/06/2016 15:04, Chen-Yu Tsai wrote:
Hi,
On Mon, Jun 13
Hi,
On 30-07-16 11:36, Icenowy Zheng wrote:
A64 SoC features a MMC controller which need only the mod clock, and can
calibrate delay by itself. This patch adds support for the new MMC
controller IP core.
Signed-off-by: Icenowy Zheng
Cool stuff, thanks for your work on this!
---
drivers/mm
Hi,
On 30-07-16 13:35, Icenowy Zheng wrote:
30.07.2016, 18:30, "Hans de Goede" :
Hi,
On 30-07-16 11:36, Icenowy Zheng wrote:
A64 SoC features a MMC controller which need only the mod clock, and can
calibrate delay by itself. This patch adds support for the new MMC
controll
Hi,
On 30-07-16 13:35, Icenowy Zheng wrote:
30.07.2016, 18:30, "Hans de Goede" :
Hi,
On 30-07-16 11:36, Icenowy Zheng wrote:
A64 SoC features a MMC controller which need only the mod clock, and can
calibrate delay by itself. This patch adds support for the new MMC
controll
Hi,
On 31-07-16 13:02, Icenowy Zheng wrote:
A64 SoC features a MMC controller which need only the mod clock, and can
calibrate delay by itself. This patch adds support for the new MMC
controller IP core.
Based on work by Andre Przywara .
Signed-off-by: Icenowy Zheng
Looks good, some minor r
Hi,
On 31-07-16 13:25, Icenowy Zheng wrote:
There's something unknown in the pmu part.
Signed-off-by: Icenowy Zheng
Cool, I really like the work you're doing on A64 support,
keep up the good work!
---
drivers/phy/phy-sun4i-usb.c | 21 +++--
1 file changed, 19 insertions(+)
Hi,
On 31-07-16 16:50, Chen-Yu Tsai wrote:
FYI: H3 USB PHY support is not complete. USB0 PHY is not supported, and
it does not work. I did a preliminary comparison of this PHY driver and
the code in Allwinner's SDK. There are some bits missing.
Right that is a known issue, I believe someone w
Hi,
On 01-08-16 01:48, Icenowy Zheng wrote:
Hi,
31.07.2016, 22:30, "Hans de Goede" :
Hi,
On 31-07-16 13:02, Icenowy Zheng wrote:
A64 SoC features a MMC controller which need only the mod clock, and can
calibrate delay by itself. This patch adds support for the new MMC
controll
Hi,
On 01-08-16 09:05, Icenowy Zheng wrote:
clocks = <&ccu CLK_A64_BUS_OHCI1>,
<&ccu CLK_A64_BUS_EHCI1>,
<&ccu CLK_A64_USB_OHCI0>,
<&ccu CLK_A64_USB_OHCI1>;
On A64, EHCI re
Hi,
On 01-08-16 10:18, Icenowy Zheng wrote:
01.08.2016, 15:27, "Hans de Goede" :
Hi,
On 01-08-16 09:05, Icenowy Zheng wrote:
clocks = <&ccu CLK_A64_BUS_OHCI1>,
<&ccu CLK_A64_BUS_EHCI1>,
ned-off-by: Arnd Bergmann
Fixes: b33ecca87df9 ("phy-sun4i-usb: Add support for peripheral-only mode")
Good catch, patch LGTM:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/phy/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/Kconfig b/drive
the clock/regulator cleanup into the framebuffer destroy callback,
which gets called as part of the framebuffer unregister process.
Note this introduces asymmetry in how the resources are claimed and
released.
Signed-off-by: Chen-Yu Tsai
Good catch, patch LGTM:
Reviewed-by: Hans de Goede
Hi,
On 07-09-16 13:12, Geert Uytterhoeven wrote:
On Wed, Sep 7, 2016 at 11:09 AM, Chen-Yu Tsai wrote:
simplefb gets unregister when a proper framebuffer driver comes in and
kicks it out. However the claimed clocks and regulators stay enabled
as they are only released in the platform device rem
nxi: Add driver for sunxi usb phy")
Cc: Hans de Goede
Cc: sta...@vger.kernel.org
Signed-off-by: Chen-Yu Tsai
Good catch, but you're actually replacing the locking calls in the only
user of sun4i_usb_phy_data.mutex, so after your patch it is no longer
used anywhere. Can you do a v2 just o
Hi,
On 08-09-16 12:24, Chen-Yu Tsai wrote:
On Thu, Sep 8, 2016 at 6:16 PM, Hans de Goede wrote:
Hi,
On 08-09-16 05:14, Chen-Yu Tsai wrote:
The musb driver calls into this phy driver to disable/enable squelch
detection. This function was introduced in 24fe86a617c5 ("phy: sun4i-usb:
is time.
Signed-off-by: Arnd Bergmann
Thanks for catching this:
Reviewed-by: Hans de Goede
---
I see the original patch hasn't made it into linux-next
yet, so ideally just fold this patch into the first one.
The original patch is in 4.8-rc# (it got there after rc1).
Regards,
Hans
nxi: Add driver for sunxi usb phy")
Cc: Hans de Goede
Cc: sta...@vger.kernel.org
Signed-off-by: Chen-Yu Tsai
Looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
Changes since v1:
- Remove the old mutex, since it is no longer used
- Use irqsave/irqrestore var
Hi,
On 31-08-16 18:22, Maxime Ripard wrote:
On Mon, Aug 29, 2016 at 10:18:32PM +0800, Icenowy Zheng wrote:
UART1 is connected to the bluetooth part of RTL8723BS WiFi/BT combo card
on iNet D978 Rev2 board.
Enable the UART1 to make it possible to use the modified hciattach by
Realtek to drive th
Hi,
On 04-08-16 20:12, Luc Verhaegen wrote:
On Thu, Aug 04, 2016 at 06:58:55PM +0200, Noralf Trønnes wrote:
I didn't read the binding document[1], which I should have done.
If simpledrm claims to be compatible with simple-framebuffer I assume it
should support the entire binding doc which incl
Hi,
On 25-08-16 16:12, Icenowy Zheng wrote:
25.08.2016, 16:03, "Maxime Ripard" :
Hi,
On Thu, Aug 25, 2016 at 02:57:24PM +0800, Icenowy Zheng wrote:
diff --git a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
index 78823d8..3a
HI,
On 25-08-16 16:53, Icenowy Zheng wrote:
25.08.2016, 22:18, "Hans de Goede" :
Hi,
On 25-08-16 16:12, Icenowy Zheng wrote:
25.08.2016, 16:03, "Maxime Ripard" :
Hi,
On Thu, Aug 25, 2016 at 02:57:24PM +0800, Icenowy Zheng wrote:
>>>> diff --git a/
Hi,
On 16-08-17 17:54, Tony Lindgren wrote:
* Hans de Goede [170815 13:06]:
On some devices the USB Type-C port power (USB PD 2.0) negotiation is
done by a separate port-controller IC, while the current limit is
controlled through another (charger) IC.
It has been decided to model this by
Hi,
On 14-10-17 12:45, Andy Shevchenko wrote:
On Wed, Oct 11, 2017 at 12:41 PM, Hans de Goede wrote:
Hi All,
These are the last 3 patches from all my work to add support for
USB PD charging to Intel Cherry Trail devices with a Whiskey Cove PMIC
and fusb302 Type-C controller.
With these 3
property to the name of the
bq24272i charger for this.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/intel_cht_int33fe.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/platform/x86/intel_cht_int33fe.c
b/drivers/platform/x86/intel_cht_int33fe.c
index 6a1b2ca5b6fe
Hi,
On 22-05-17 12:57, Lee Jones wrote:
On Mon, 15 May 2017, Hans de Goede wrote:
The Crystal Cove PMIC provides an ACPI OPRegion handler, which must be
available before other drivers using it are loaded, which is why
INTEL_SOC_PMIC is a bool.
Just having the driver is not enough, the driver
Hi,
On 22-05-17 12:56, Lee Jones wrote:
On Mon, 15 May 2017, Hans de Goede wrote:
On x86 the axp288 PMIC provides an ACPI OpRegion handler, which must be
available before other drivers using it are loaded, which can only be
ensured if the mfd, OpRegionr and i2c-bus drivers are built in
ailed to change power state to D0
Signed-off-by: Hans de Goede
---
Changes in v2:
-Fix Kconfig depends and selects to fix warning reported by kbuild test robot
-Improve commit msg (add example of ACPI errors this avoids)
Changes in v3:
-Since the axp20x mfd code is used on ARM too where it doe
While at it this patch also changes the human readable name of the Kconfig
option to make clear the INTEL_SOC_PMIC option selects support for the
Intel Crystal Cove PMIC and documents why this is a bool.
Cc: Andy Shevchenko
Signed-off-by: Hans de Goede
Reviewed-by: Andy Shevchenko
---
Changes
menu controls are not allowed to have a step size, set step to 0 to
fix an oops from the WARN_ON in v4l2_ctrl_new_custom() triggering
because of this.
Signed-off-by: Hans de Goede
---
drivers/staging/media/atomisp/i2c/mt9m114.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
comments
in the source indicate, the check for these 2 special gmin variables with
a NULL device is a workaround for 2 specific evaluation boards, so
completely silencing the missing warning for these actually is a good
thing.
Signed-off-by: Hans de Goede
---
.../staging/media/atomisp/platform
efivar_entry struct we kzalloc as arguments to efivar_entry_get(),
which is how all the other callers of efivar_entry_get() do this.
Signed-off-by: Hans de Goede
---
.../atomisp/platform/intel-mid/atomisp_gmin_platform.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff
Hi,
On 28-05-17 19:08, Alan Cox wrote:
On Sun, 28 May 2017 14:30:35 +0200
Hans de Goede wrote:
Do not call dev_warn with a NULL device, this silence the following 2
warnings:
[ 14.392194] (NULL device *): Failed to find gmin variable gmin_V2P8GPIO
[ 14.392257] (NULL device *): Failed to
iewed-by for a
CHROMIUM
patch, but I'd rather not carry patches in the CrOS repo if we don't need to.
Would a
Fixes: a39be606f99d ("drm: Do a full device unregister when unplugging")
Reported-by: Marco Diego Aurélio Mesquita
Cc: Hans de Goede
convince us to look into this patc
Hi,
On 25-10-17 16:33, SF Markus Elfring wrote:
From: Markus Elfring
Date: Wed, 25 Oct 2017 16:26:29 +0200
Add a jump target so that a call of the function "mutex_unlock" is mostly
stored at the end of these function implementations.
Replace five calls by goto statements.
This issue was detec
Hi,
On 25-10-17 18:15, SF Markus Elfring wrote:
IMHO, if you do this, you should rework the function so that there is a single
unlock call
at the end, not a separate one in in error label.
Thanks for your update suggestion.
Does it indicate that I may propose similar source code adjustments
Hi,
On 25-10-17 18:58, SF Markus Elfring wrote:
If that is the only unlock in the function, then it is probably
best to keep things as is. In general gotos are considered
better then multiple unlocks, but not having either is
even better.
Thanks for your quick feedback.
How do you think abo
Hi,
On 14-11-17 01:56, Stephen Rothwell wrote:
Hi all,
After merging the bluetooth tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
drivers/bluetooth/Kconfig:35:warning: multi-line strings not supported
Introduced by commit
86be3c232877 ("Bluetooth: btusb: Ad
Hi,
On 18-10-17 04:33, Chanwoo Choi wrote:
Hi Hans,
On 2017년 09월 23일 03:37, Hans de Goede wrote:
Cherry Trail SoCs have a built-in USB-role mux for switching between
the host and device controllers, rather then using an external mux
controller by a GPIO.
There is a driver using the mux
Add "silead,home-button" property to entries for tablets which have
a capacitive home button (typically a windows logo on the front).
This new property is checked for by the new capacitive home button
support in the silead touchscreen driver.
Signed-off-by: Hans de Goede
---
driver
for
now we only respond to the Y coordinate bits 12-15 containing 0x01, on some
tablets *without* a capacative button I've noticed these bits containing
0x04 when crossing the edges of the screen.
Cc: Rob Herring
Signed-off-by: Hans de Goede
---
Changes in v2:
-Only enable support for the
he coordinates being
generated are wrong and we need to apply a rotation of 180 degrees to the
coordinates to fix this.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/silead_dmi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/platform/x86/silead_dmi.c
b/drivers/platform/x8
Hi All,
Here is a split-up version of my "drm/i915: Acquire PUNIT->PMIC bus for
intel_uncore_forcewake_reset()" patch, this time with the
arch/x86/platform/intel/iosf_mbi.c split out into a separate patch.
Since the iosf_mbi changes are fairly isolated, ideally this entire
series would go upstrea
is called
directly after unregistering the pmic_bus_access_notifier, we need to
hold the punit-lock over both calls to avoid a race where
intel_uncore_fw_release_timer() may execute between the 2 calls.
Signed-off-by: Hans de Goede
Reviewed-by: Imre Deak
---
Changes in v2:
-Rebase on current (J
For race free unregistration drivers may need to acquire PMIC bus access
through iosf_mbi_punit_acquire() and then (un)register the notifier without
dropping the lock.
This commit adds an unlocked variant of
iosf_mbi_unregister_pmic_bus_access_notifier for this use case.
Signed-off-by: Hans de
Hi,
On 19-10-17 16:42, Wolfram Sang wrote:
The first patch, although it is an i2c-core change, is really
quite simple. I believe anyone can review it. But it does need
someone other then me to take a proper look (and not just do
a code only review) because it is a core change. Maybe there
is a
Hi,
On 26-10-17 22:33, Wolfram Sang wrote:
On Wed, Oct 11, 2017 at 11:41:21AM +0200, Hans de Goede wrote:
The fusb302 driver as merged in staging uses "typec_fusb302" as i2c-id
rather then just "fusb302" and needs us to set a number of device-
properties, adjust the inte
From: Sergey Tshovrebov
Add touchscreen platform data for the Digma e200 tablet.
Signed-off-by: Sergey Tshovrebov
Signed-off-by: Hans de Goede
---
drivers/platform/x86/silead_dmi.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/drivers/platform/x86
1 - 100 of 2701 matches
Mail list logo
