Hi,
On 09-09-16 11:25, Arnd Bergmann wrote:
In commit "usb: phy: add USB_SUPPORT dependency", I tried to
fix the dependency for this driver, but unfortunately I missed
that we need both USB_COMMON and USB_SUPPORT here, and we
can still get the same link error in the much rarer case
that USB_COMMON is a loadable module and the phy driver is
build-in:
drivers/phy/phy-sun4i-usb.o: In function `sun4i_usb_phy_probe':
phy-sun4i-usb.c:(.text.sun4i_usb_phy_probe+0x1a6): undefined reference to
`of_usb_get_dr_mode_by_phy'
This adds the select, hopefully fixing it properly this time.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
Thanks for catching this:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
---
I see the original patch hasn't made it into linux-next
yet, so ideally just fold this patch into the first one.
The original patch is in 4.8-rc# (it got there after rc1).
Regards,
Hans
Sorry for not getting it right the first time around.
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 985dff8558e5..c717f306d131 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -262,6 +262,7 @@ config PHY_SUN4I_USB
depends on POWER_SUPPLY
depends on USB_SUPPORT
select GENERIC_PHY
+ select USB_COMMON
help
Enable this to support the transceiver that is part of Allwinner
sunxi SoCs.
