On 11/02/2017 01:08 PM, Christian Borntraeger wrote:
>
>
> On 10/16/2017 11:25 AM, Martin Schwidefsky wrote:
>> On Fri, 13 Oct 2017 13:39:04 -0400
>> Tony Krowiak wrote:
>>
>>> Sets up the following facilities bits to enable the specified AP
>>> facilities for the guest VM:
>>> * STFLE.12:
On 08/27/2018 03:51 PM, Cornelia Huck wrote:
On Mon, 27 Aug 2018 09:47:58 -0400
Tony Krowiak wrote:
On 08/27/2018 04:33 AM, Cornelia Huck wrote:
On Thu, 23 Aug 2018 10:16:59 -0400
Tony Krowiak wrote:
On 08/23/2018 06:25 AM, Cornelia Huck wrote:
On Wed, 22 Aug 2018 15:16:19 -0400
Tony
On 08/20/2018 10:16 PM, Tony Krowiak wrote:
Does the SIE complain if you specify a control
domain that the host does not have access to (I'd guess so)?
The SIE does not complain if you specify a domain to which the host - or a
lower level guest - does not have access. The firmware performs a
On 08/21/2018 07:07 PM, Tony Krowiak wrote:
On 08/21/2018 11:25 AM, Cornelia Huck wrote:
On Mon, 20 Aug 2018 13:41:32 -0400
Tony Krowiak wrote:
On 08/20/2018 10:23 AM, Cornelia Huck wrote:
On Mon, 13 Aug 2018 17:48:09 -0400
Tony Krowiak wrote:
From: Tony Krowiak
Provides the sysfs int
On 08/22/2018 11:42 AM, Cornelia Huck wrote:
On Wed, 22 Aug 2018 01:18:20 +0200
Halil Pasic wrote:
On 08/21/2018 07:07 PM, Tony Krowiak wrote:
This convention has been enforced by the kernel since v1. This is also
enforced by both the LPAR as well as in z/VM. The following is from the
PR
On 08/22/2018 12:13 PM, Harald Freudenberger wrote:
... about control domains
Talked with the s390 firmware guys. The convention that the control domain
mask is a superset of the usage domain mask is only true for 1st level guests.
It is absolutely valid to run a kvm guest with restricted co
On 08/22/2018 05:48 PM, Christian Borntraeger wrote:
On 08/22/2018 05:34 PM, Pierre Morel wrote:
On 22/08/2018 17:11, Christian Borntraeger wrote:
On 08/22/2018 01:03 PM, Pierre Morel wrote:
That's interesting.
IMHO this quote is quite a half-full half-empty cup one:
* it mandates the s
On 08/22/2018 09:16 PM, Tony Krowiak wrote:
On 08/22/2018 01:11 PM, Halil Pasic wrote:
On 08/22/2018 05:48 PM, Christian Borntraeger wrote:
On 08/22/2018 05:34 PM, Pierre Morel wrote:
On 22/08/2018 17:11, Christian Borntraeger wrote:
On 08/22/2018 01:03 PM, Pierre Morel wrote:
That&#
, then no
AP devices will be available to the guest regardless of
the guest's matrix configuration for the virtual
machine. This is a limitation of the Linux AP bus.
Signed-off-by: Tony Krowiak
Reviewed-by: Christian Borntraeger
Reviewed-by: Halil Pasic
Tested-by: Michael Mu
On 08/23/2018 02:47 PM, Pierre Morel wrote:
On 23/08/2018 13:12, David Hildenbrand wrote:
[..]
I'm confused, which 128 bit?
Me too :) , I was assuming this block to be 128bit, but the qci block
has 128 bytes
And looking at arch/s390/include/asm/ap.h, there is a lot of information
co
On 08/23/2018 07:40 PM, David Hildenbrand wrote:
On 23.08.2018 19:35, Tony Krowiak wrote:
On 08/23/2018 10:59 AM, Pierre Morel wrote:
On 23/08/2018 15:38, David Hildenbrand wrote:
On 23.08.2018 15:22, Halil Pasic wrote:
On 08/23/2018 02:47 PM, Pierre Morel wrote:
On 23/08/2018 13:12
On 06/29/2018 11:11 PM, Tony Krowiak wrote:
From: Tony Krowiak
Configures the AP adapters, usage domains and control domains for the
KVM guest from the matrix configured via the mediated matrix device's
sysfs attribute files.
[..]
+
+static void kvm_ap_set_crycb_masks(struct ap_matrix_mde
On 06/29/2018 11:11 PM, Tony Krowiak wrote:
Implements the open callback on the mediated matrix device.
The function registers a group notifier to receive notification
of the VFIO_GROUP_NOTIFY_SET_KVM event. When notified,
the vfio_ap device driver will get access to the guest's
kvm structure.
On 06/29/2018 11:11 PM, Tony Krowiak wrote:
From: Tony Krowiak
Configures the AP adapters, usage domains and control domains for the
[..]
+static inline void kvm_ap_clear_crycb_masks(struct ap_matrix_mdev *matrix_mdev)
+{
+ memset(&matrix_mdev->kvm->arch.crypto.crycb->apcb0, 0,
+
On 07/12/2018 06:03 PM, Tony Krowiak wrote:
+static int vfio_ap_mdev_open(struct mdev_device *mdev)
+{
+struct ap_matrix_mdev *matrix_mdev = mdev_get_drvdata(mdev);
+struct ap_matrix_dev *matrix_dev =
+to_ap_matrix_dev(mdev_parent_dev(mdev));
+unsigned long events;
+int
On 07/13/2018 02:24 PM, Tony Krowiak wrote:
On 07/09/2018 04:38 PM, Pierre Morel wrote:
On 09/07/2018 14:20, Pierre Morel wrote:
On 29/06/2018 23:11, Tony Krowiak wrote:
Provides a sysfs interface to view the AP matrix configured for the
mediated matrix device.
The relevant sysfs structure
On 01/23/2018 07:23 AM, Dong Jia Shi wrote:
> * Halil Pasic [2018-01-16 16:57:13 +0100]:
>
>>
>>
>> On 01/15/2018 09:59 AM, Dong Jia Shi wrote:
>>> * Halil Pasic [2018-01-12 19:10:20 +0100]:
>>>
>>>>
>>>>
>>>> On 01
On 01/11/2018 04:04 AM, Dong Jia Shi wrote:
> What are still missing, thus need to be offered in the next version are:
> - I/O termination and FSM state handling if currently we have I/O on the
> status
> switched path.
> - Vary on/off event is not sensible to a guest.
I don't see a doc updat
> in regular documentation.
> - Fix some typos.
> - Describe the current limitations in more detail.
>
> Signed-off-by: Cornelia Huck
> ---
Acked-by: Halil Pasic
On 01/15/2018 09:59 AM, Dong Jia Shi wrote:
> * Halil Pasic [2018-01-12 19:10:20 +0100]:
>
>>
>>
>> On 01/11/2018 04:04 AM, Dong Jia Shi wrote:
>>> What are still missing, thus need to be offered in the next version are:
>>> - I/O termination and FSM
On 01/15/2018 11:43 AM, Cornelia Huck wrote:
> The vfio-ccw documentation comes from the cover letter of the
> original patch submission, which shows in some parts. Give it some
> love; in particular:
>
> - Remove/rework statements that make sense in a cover letter, but not
> in regular docume
issue easier in future.
>
> Tracepoints are nice :)
>
>>
>> For details see the commit message portions of the inividual patches.
>
> Still digging through the post-vacation mail pile, will do more looking
> later.
>
>
>> Thanks.
>>
>>
On 03/27/2018 12:07 PM, Cornelia Huck wrote:
> On Tue, 27 Mar 2018 15:51:14 +0800
> Dong Jia Shi wrote:
>
>> * Cornelia Huck [2018-03-26 15:59:02 +0200]:
>>
>> [...]
>>
@@ -131,6 +138,8 @@ static void fsm_io_request(struct vfio_ccw_private
*private,
io_region-
On 03/20/2018 06:58 PM, Tony Krowiak wrote:
> I spoke with Christian this morning and he made a suggestion which I think
> would provide the best solution here.
> This is my proposal:
> 1. Get rid of the KVM_S390_VM_CRYPTO_INTERPRET_AP device attribute and return
> to setting ECA.28 from the
>
On 03/21/2018 03:08 AM, Dong Jia Shi wrote:
> From: Halil Pasic
>
> If the translation of a channel program fails, we may end up attempting
> to clean up (free, unpin) stuff that never got translated (and allocated,
> pinned) in the first place.
>
> By adjusting the
On 03/22/2018 10:37 AM, Pierre Morel wrote:
> On 22/03/2018 03:22, Dong Jia Shi wrote:
>> * Halil Pasic [2018-03-21 13:49:54 +0100]:
>>
>>>
>>> On 03/21/2018 03:08 AM, Dong Jia Shi wrote:
>>>> From: Halil Pasic
>>>>
>>>> If
On 04/10/2018 10:55 AM, Cornelia Huck wrote:
> On Tue, 10 Apr 2018 10:16:39 +0800
> Dong Jia Shi wrote:
>
>> Does the following effect make sense?
>>
>> # tracer: nop
>> #
>> # _-=> irqs-off
>> # / _=> need-resched
>> #
On 09/27/2018 12:42 AM, Alex Williamson wrote:
> On Tue, 25 Sep 2018 19:16:41 -0400
> Tony Krowiak wrote:
>
>> From: Tony Krowiak
[..]
>> +
>> +2. Secure the AP queues to be used by the three guests so that the host can
>> not
>> + access them. To secure them, there are two sysfs files tha
On 09/28/2018 03:35 PM, Cornelia Huck wrote:
> On Fri, 28 Sep 2018 09:33:21 -0400
> Tony Krowiak wrote:
>
>> From: Tony Krowiak
>>
>> Fixes case statement in vfio_ap_mdev_copy_masks() function in
>> vfio-ap-ops.c.
>> ---
>> drivers/s390/crypto/vfio_ap_ops.c | 3 ++-
>> 1 file changed, 2 inse
On Fri, 16 Nov 2018 11:47:48 +0100
Petr Tesarik wrote:
> The driver uses test_facility(), but does not include the
> corresponding include file explicitly. The driver currently builds
> only thanks to the following include chain:
>
> vfio_ap_drv.c
>
>
>
>
>
On 06/29/2018 11:11 PM, Tony Krowiak wrote:
Introduces a new AP device driver. This device driver
is built on the VFIO mediated device framework. The framework
provides sysfs interfaces that facilitate passthrough
access by guests to devices installed on the linux host.
The VFIO AP device dri
Christian Borntraeger
Reviewed-by: Halil Pasic
Signed-off-by: Tony Krowiak
I think it probably should be at the end of the series, other than that its
good.
If I move this to the end of the series, the very next patch checks the
KVM_S390_VM_CPU_FEAT_AP feature?
The point is the following: neve
en no
AP devices will be available to the guest regardless of
the guest's matrix configuration. This is a limitation
of the AP bus running under the guest.
Reviewed-by: Christian Borntraeger
Reviewed-by: Halil Pasic
Signed-off-by: Tony Krowiak
I think it probably should be at
On 06/29/2018 11:11 PM, Tony Krowiak wrote:
This patch provides documentation describing the AP architecture and
design concepts behind the virtualization of AP devices. It also
includes an example of how to configure AP devices for exclusive
use of KVM guests.
Signed-off-by: Tony Krowiak
--
On 06/29/2018 11:11 PM, Tony Krowiak wrote:
This patch provides documentation describing the AP architecture and
design concepts behind the virtualization of AP devices. It also
includes an example of how to configure AP devices for exclusive
use of KVM guests.
Signed-off-by: Tony Krowiak
On 07/03/2018 09:46 AM, Harald Freudenberger wrote:
On 02.07.2018 18:28, Halil Pasic wrote:
On 06/29/2018 11:11 PM, Tony Krowiak wrote:
This patch provides documentation describing the AP architecture and
design concepts behind the virtualization of AP devices. It also
includes an example
On 07/03/2018 01:52 PM, Cornelia Huck wrote:
On Tue, 3 Jul 2018 11:22:10 +0200
Halil Pasic wrote:
[..]
Let me try to invoke the DASD analogy. If one for some reason wants to detach
a DASD the procedure to follow seems to be (see
https://www.ibm.com/support/knowledgecenter/en/linuxonibm
On 07/03/2018 03:25 PM, Cornelia Huck wrote:
On Tue, 3 Jul 2018 14:20:11 +0200
Halil Pasic wrote:
On 07/03/2018 01:52 PM, Cornelia Huck wrote:
On Tue, 3 Jul 2018 11:22:10 +0200
Halil Pasic wrote:
[..]
Let me try to invoke the DASD analogy. If one for some reason wants to detach
a
On 07/09/2018 05:21 AM, Pierre Morel wrote:
On 03/07/2018 01:10, Halil Pasic wrote:
On 06/29/2018 11:11 PM, Tony Krowiak wrote:
This patch provides documentation describing the AP architecture and
design concepts behind the virtualization of AP devices. It also
includes an example of how
On 05/07/2018 05:11 PM, Tony Krowiak wrote:
Provides interfaces to manage the AP adapters, usage domains
and control domains assigned to a KVM guest.
The guest's SIE state description has a satellite structure called the
Crypto Control Block (CRYCB) containing three bitmask fields
identifying
On 05/07/2018 05:11 PM, Tony Krowiak wrote:
Registers the matrix device created by the VFIO AP device
driver with the VFIO mediated device framework.
Registering the matrix device will create the sysfs
structures needed to create mediated matrix devices
each of which will be used to configure t
On 05/14/2018 01:55 PM, Cornelia Huck wrote:
On Wed, 9 May 2018 19:36:47 +0200
Halil Pasic wrote:
There is at least one relevant control program (CP) that don't set the
I'd prefer not to talk about 'control program' here, as it is not a
term commonly used in Linux. Ca
On 05/14/2018 04:00 PM, Cornelia Huck wrote:
On Mon, 14 May 2018 15:37:17 +0200
Halil Pasic wrote:
On 05/14/2018 01:55 PM, Cornelia Huck wrote:
On Wed, 9 May 2018 19:36:47 +0200
Halil Pasic wrote:
[..]
+ /*
+* 2k byte block IDAWs (fmt1 or fmt2) are
On 07/03/2018 04:30 PM, Cornelia Huck wrote:
On Tue, 3 Jul 2018 15:58:37 +0200
Halil Pasic wrote:
On 07/03/2018 03:25 PM, Cornelia Huck wrote:
On Tue, 3 Jul 2018 14:20:11 +0200
Halil Pasic wrote:
On 07/03/2018 01:52 PM, Cornelia Huck wrote:
On Tue, 3 Jul 2018 11:22:10 +0200
Halil
On 06/29/2018 11:11 PM, Tony Krowiak wrote:
From: Tony Krowiak
Introduces a new structure for storing the AP matrix configured
for the mediated matrix device via its sysfs attributes files.
Signed-off-by: Tony Krowiak
---
drivers/s390/crypto/vfio_ap_ops.c | 12
driver
On 05/17/2018 10:09 AM, Cornelia Huck wrote:
[Dong Jia, Halil: Can you please take a look whether vfio-ccw is really
ok? I don't think we open up any new races, but I'd appreciate a second
or third opinion.]
I will wait for things to settle a bit before I start reviewing the
synchronization
On 08/20/2018 04:23 PM, Cornelia Huck wrote:
On Mon, 13 Aug 2018 17:48:09 -0400
Tony Krowiak wrote:
From: Tony Krowiak
Provides the sysfs interfaces for:
1. Assigning AP control domains to the mediated matrix device
2. Unassigning AP control domains from a mediated matrix device
3. Dis
On Wed, 12 Dec 2018 15:59:29 +0100
Christian Borntraeger wrote:
> Eric and Farhan will help with maintaining vfio-ccw.
>
> Cc: Cornelia Huck
> Cc: Halil Pasic
> Cc: Farhan Ali
> Cc: Eric Farman
> Signed-off-by: Christian Borntraeger
Acked-by: Halil Pasic
>
On Thu, 13 Dec 2018 16:39:53 +0100
Cornelia Huck wrote:
> On Wed, 28 Nov 2018 13:41:07 +0100
> Pierre Morel wrote:
>
> > When the user program is QEMU we rely on the QEMU lock to serialize
> > the calls to the driver.
> >
> > In the general case we need to make sure that two data transfer are
On Thu, 20 Dec 2018 12:49:56 +0100
Michael Mueller wrote:
>
>
> On 20.12.18 12:06, Cornelia Huck wrote:
> > On Wed, 19 Dec 2018 20:17:46 +0100
> > Michael Mueller wrote:
> >
> >> Use a single function with parameter irq_flags to differentiate
> >> between cases.
> >>
> >> New irq flag:
> >>
On Wed, 19 Dec 2018 20:17:52 +0100
Michael Mueller wrote:
> The patch adds the parameter irq_flags and allows to
> restore the Interruption Alert Mask (IAM) in the GISA
> atomically while guaranteeing the IPM is clean.
>
> The function returns the IPM of the GISA. If the returned
> value is 0x00
On Wed, 19 Dec 2018 20:17:54 +0100
Michael Mueller wrote:
> This function processes the Gib Alert List (GAL). It is required
> to run when either a gib alert interruption has been received or
> a gisa that is in the alert list is cleared or dropped.
>
> The GAL is build up by millicode, when the
On Tue, 8 Jan 2019 11:34:44 +0100
Cornelia Huck wrote:
> > >>
> > >>> + spin_unlock(&kvm->arch.iam_ref_lock);
> > >>> +
> > >>> + return gib->nisc;
> > >>> +}
> > >>> +EXPORT_SYMBOL_GPL(kvm_s390_gisc_register);
> > >>> +
> > >>> +int kvm_s390_gisc_unregister(struct kvm *kvm, u32 g
On Mon, 31 Dec 2018 06:03:51 +
"Wang, Wei W" wrote:
> On Sunday, December 30, 2018 2:06 PM, Halil Pasic wrote:
> >
> > I guess you are the first one trying to read virtio config from within
> > interrupt
> > context. AFAICT this never worked.
>
On Wed, 2 Jan 2019 10:53:14 +0100
Cornelia Huck wrote:
> On Tue, 1 Jan 2019 00:40:19 +0100
> Halil Pasic wrote:
>
> > On Mon, 31 Dec 2018 06:03:51 +
> > "Wang, Wei W" wrote:
> >
> > > On Sunday, December 30, 2018 2:06 PM, Halil Pasic wrote
On Wed, 2 Jan 2019 14:23:38 +0100
Cornelia Huck wrote:
> On Wed, 2 Jan 2019 10:53:14 +0100
> Cornelia Huck wrote:
>
> > On Tue, 1 Jan 2019 00:40:19 +0100
> > Halil Pasic wrote:
>
> > > As I said, at the moment I don't have a preference regarding the fix
On Wed, 2 Jan 2019 19:02:33 +0100
Cornelia Huck wrote:
> On Wed, 2 Jan 2019 16:59:19 +0100
> Halil Pasic wrote:
>
> > On Wed, 2 Jan 2019 14:23:38 +0100
> > Cornelia Huck wrote:
> >
> > > On Wed, 2 Jan 2019 10:53:14 +0100
> > > Cornelia Huck wro
limited to read config (aka. get()). But I'm fine with your formulation
as well.
> , so we tweak the virtballoon_changed implementation
> by moving the config read operations into the related workqueue contexts.
>
> Signed-off-by: Wei Wang
Reviewed-by: Halil Pasic
[..]
On Thu, 3 Jan 2019 13:31:02 +0800
Wei Wang wrote:
> There is no need to update the balloon actual register when there is no
> ballooning request. This patch avoids update_balloon_size when diff is 0.
>
> Signed-off-by: Wei Wang
Reviewed-by: Halil Pasic
I would be also fi
On Thu, 3 Jan 2019 17:08:04 +0100
Cornelia Huck wrote:
> Some transports (e.g. virtio-ccw) implement virtio operations that
> seem to be a simple read/write as something more involved that
> cannot be done from an atomic context.
>
> Give at least a hint about that.
>
> Signed-off-by: Cornelia
ts.
> The config_read_bitmap is used as a flag to the workqueue callbacks
> about the related config fields that need to be read.
>
> Reported-by: Christian Borntraeger
> Signed-off-by: Wei Wang
Reviewed-by: Halil Pasic
On Sat, 29 Dec 2018 02:45:49 +
"Wang, Wei W" wrote:
> On Friday, December 28, 2018 3:57 PM, Christian Borntraeger wrote:
> > On 28.12.2018 03:26, Wei Wang wrote:
> > > Some vqs don't need to be allocated when the related feature bits are
> > > disabled. Callers notice the vq allocation layer
On 10/05/2018 10:31 AM, Pierre Morel wrote:
> In the first patch we define kvm_arch_crypto_set_masks,
> a new function to centralize the setup the APCB masks
> inside the CRYCB SIE satelite and add KVM_EVENT() to
> kvm_arch_crypto_set_masks and kvm_arch_crypto_clear_masks.
>
> In the second pat
On 09/12/2018 09:43 PM, Tony Krowiak wrote:
> +/**
> + * vfio_ap_mdev_open_once
> + *
> + * @matrix_mdev: a mediated matrix device
> + *
> + * Return 0 if no other mediated matrix device has been opened for the
> + * KVM guest assigned to @matrix_mdev; otherwise, returns an error.
> + */
> +stat
uot;s390/virtio_ccw: use DMA handle from DMA API")
Signed-off-by: Halil Pasic
---
I know that checkpatch.pl complains about a missing 'Closes' tag.
Unfortunately I don't have an appropriate URL at hand. @Sebastian,
@Boqiao: do you have any suggetions?
---
drivers/s390/virt
On Wed, 12 Jun 2024 16:04:15 +0200
Thomas Huth wrote:
> On 11/06/2024 23.47, Halil Pasic wrote:
> > Commit e3e9bda38e6d ("s390/virtio_ccw: use DMA handle from DMA API")
> > broke configuration change notifications for virtio-ccw by putting the
> > DMA address o
vqi->name, vqi->ctx, ccw);
> if (IS_ERR(vqs[i])) {
> ret = PTR_ERR(vqs[i]);
Acked-by: Halil Pasic #s390
On Tue, 6 Apr 2021 11:31:09 -0400
Tony Krowiak wrote:
> Tony Krowiak (13):
> s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks
The subsequent patches, re introduce this circular locking dependency
problem. See my kernel messages for the details. The link we severe
in the a
From vfio-ccw perspective I join Connie's assessment: vfio-ccw should
be fine with these changes. I'm however not too deeply involved with
the mdev framework, thus I don't feel comfortable r-b-ing. That results
in
Acked-by: Halil Pasic
for both patches.
While at it I have wo
On 05/23/2018 10:56 AM, Cornelia Huck wrote:
On Tue, 22 May 2018 12:38:29 -0600
Alex Williamson wrote:
On Tue, 22 May 2018 19:17:07 +0200
Halil Pasic wrote:
From vfio-ccw perspective I join Connie's assessment: vfio-ccw should
be fine with these changes. I'm however not
of trying to process tcws as ccws.
>
> Signed-off-by: Cornelia Huck
Acked-by: Halil Pasic
> ---
> drivers/s390/cio/vfio_ccw_fsm.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/s390/cio/vfio_ccw_fsm.c b/drivers/s390/cio/vfio_ccw_fsm.c
> index c3042
On 04/30/2018 01:51 PM, Cornelia Huck wrote:
On Sat, 28 Apr 2018 13:50:23 +0800
Dong Jia Shi wrote:
* Cornelia Huck [2018-04-27 12:13:53 +0200]:
On Mon, 23 Apr 2018 13:01:13 +0200
Dong Jia Shi wrote:
typo in subject: s/traceponits/tracepoints/
From: Halil Pasic
Add some
On 04/30/2018 05:03 PM, Cornelia Huck wrote:
I think the naming of this fctl thing is a bit cryptic,
but if we don't see this as ABI I'm fine with it -- can be improved.
What would be a better name? I was thinking along the lines accept_request.
(Bad error code would mean that the request did n
On 06/07/2018 02:53 PM, Tony Krowiak wrote:
2) As I said above, what you show is not the effective mask used by the guest
Why would a sysfs attribute for the mediated matrix device show the effective
mask used by the guest?
OK, bad word, "effective", replace with "really".
We do not imple
On 05/15/2018 05:16 PM, Tony Krowiak wrote:
On 05/15/2018 10:17 AM, Pierre Morel wrote:
On 14/05/2018 21:42, Tony Krowiak wrote:
On 05/11/2018 01:18 PM, Halil Pasic wrote:
On 05/07/2018 05:11 PM, Tony Krowiak wrote:
Registers the matrix device created by the VFIO AP device
driver with
f the channel program is a not supported one.
Of course, the real solution would be doing proper translation for all
IDA. This is possible, but given the current code not straight forward.
Signed-off-by: Halil Pasic
Tested-by: Jason J. Herne
---
---
drivers/s390/cio/vfio_ccw_cp.c
On 04/25/2018 08:57 AM, Cornelia Huck wrote:
AFAIU this will be the problem of the person implementing the clear
and the halt for vfio-ccw. I.e. it's a non-problem right now.
Well, that person is me:) I will post some RFC Real Soon Now if I stop
getting sidetracked...
Makes sense. It shoul
On 04/25/2018 04:43 AM, Dong Jia Shi wrote:
[Some procedural notes: I've created a new vfio-ccw-fixes branch based
on the s390 fixes branch for easier handling. Things targeted for the
next release will go on the vfio-ccw branch on top of the s390 features
branch, as before. Does that work for
On Thu, 28 Feb 2019 10:42:23 +0100
Christian Borntraeger wrote:
>
>
> On 27.02.2019 19:00, Tony Krowiak wrote:
> > On 2/27/19 3:09 AM, Pierre Morel wrote:
> >> On 26/02/2019 16:47, Tony Krowiak wrote:
> >>> On 2/26/19 6:47 AM, Pierre Morel wrote:
> On 25/02/2019 19:36, Tony Krowiak wrote:
On Thu, 28 Feb 2019 14:47:35 +0100
Pierre Morel wrote:
> On 28/02/2019 14:44, Christian Borntraeger wrote:
> >
> >
> > On 28.02.2019 14:23, Pierre Morel wrote:
> >> On 28/02/2019 10:42, Christian Borntraeger wrote:
> >>>
> >>>
> >>> On 27.02.2019 19:00, Tony Krowiak wrote:
> On 2/27/19 3:0
On Fri, 22 Feb 2019 16:29:53 +0100
Pierre Morel wrote:
> This patch implement PQAP/AQIC interception in KVM.
>
> To implement this we need to add a new structure, vfio_ap_queue,to be
> able to retrieve the mediated device associated with a queue and specific
> values needed to register/unregiste
On Thu, 28 Feb 2019 15:12:16 +0100
Pierre Morel wrote:
> On 28/02/2019 13:39, Halil Pasic wrote:
> > On Thu, 28 Feb 2019 10:42:23 +0100
> > Christian Borntraeger wrote:
[..]
> >> Correct?
> >
> > IMHO mostly.
> >
> > I also doing the facil
On Thu, 28 Feb 2019 09:48:39 +0100
Pierre Morel wrote:
> On 28/02/2019 09:23, Christian Borntraeger wrote:
> > On 22.02.2019 16:29, Pierre Morel wrote:
> >> To be able to use the VFIO interface to facilitate the
> >> mediated device memory pining/unpining we need to register
> >> a notifier for I
On Mon, 15 Apr 2019 18:43:24 -0400
Tony Krowiak wrote:
> On 4/15/19 2:59 PM, Halil Pasic wrote:
> > On Mon, 15 Apr 2019 12:51:23 -0400
> > Tony Krowiak wrote:
> >
> >> Having said that, I understand your concern about a driver hogging
> >> resources
On Fri, 15 Mar 2019 14:26:34 +0100
Pierre Morel wrote:
> On 15/03/2019 11:20, Cornelia Huck wrote:
> > On Wed, 13 Mar 2019 17:04:58 +0100
> > Pierre Morel wrote:
> >
> >> +/*
> >> + * handle_pqap: Handling pqap interception
> >> + * @vcpu: the vcpu having issue the pqap instruction
> >> + *
> >
On Fri, 15 Mar 2019 15:10:25 +0100
Pierre Morel wrote:
> Sorry, wrong conclusion, handling this in userland will bring us much
> too far if we want to answer correctly for the case the hook is not
> there but QEMU accepted the facility for AQIC.
>
> The alternative is easier, we just continue
On Thu, 24 Jan 2019 13:59:27 +0100
Michael Mueller wrote:
> The explicit else path specified in set_intercept_indicators_io
> is not required as the function returns in case the first branch
> is taken anyway.
>
> Signed-off-by: Michael Mueller
Reviewed-by: Halil Pasic
>
On Thu, 24 Jan 2019 13:59:28 +0100
Michael Mueller wrote:
> Use a consistent bitmap declaration throughout the code.
>
> Signed-off-by: Michael Mueller
Reviewed-by: Halil Pasic
> ---
> arch/s390/include/asm/kvm_host.h | 2 +-
> arch/s390/kvm/interrupt.c| 2 +-
>
On Thu, 24 Jan 2019 13:59:30 +0100
Michael Mueller wrote:
> The change helps to reduce line length and
> increases code readability.
>
> Signed-off-by: Michael Mueller
> Reviewed-by: Cornelia Huck
> Reviewed-by: Pierre Morel
Reviewed-by: Halil Pasic
> ---
> arch/s
On Thu, 24 Jan 2019 13:59:32 +0100
Michael Mueller wrote:
> This will shorten the length of code lines. All GISA related
> static inline functions are local to interrupt.c.
>
> Signed-off-by: Michael Mueller
Reviewed-by: Halil Pasic
[..]
guess this is just a tiny optimization.
Reviewed-by: Halil Pasic
> ---
> arch/s390/kvm/interrupt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
> index 005dbe7252e7..cb48736867ed 100644
>
Janosch Frank , David
> Hildenbrand , Cornelia Huck , Halil
> Pasic , Pierre Morel , Michael
> Mueller
> Subject: [PATCH v6 06/13] KVM: s390: remove kvm_s390_ from gisa static inline
> functions
> Date: Thu, 24 Jan 2019 13:59:32 +0100
> X-Mailer: git-send-email 2.13.4
>
>
ASAP but does not affect the validity of this patch).
Reviewed-by: Halil Pasic
> ---
> arch/s390/include/asm/kvm_host.h | 6 -
> arch/s390/kvm/interrupt.c| 52
> +++-
> arch/s390/kvm/kvm-s390.c | 2 +-
> 3 files cha
this series.
>
> Signed-off-by: Michael Mueller
> Reviewed-by: Janosch Frank
> Reviewed-by: Christian Borntraeger
> Reviewed-by: Cornelia Huck
> Reviewed-by: Pierre Morel
I don't agree with the commit message to 100%, but I'd rather not start
a discussion.
Acked-by: Halil Pasic
[..]
of the names.
Another idea for later would be to sanity check in gisa destroy that
alert.mask is back to all zero -- to catch any corresponding driver
bugs.
Acked-by: Halil Pasic
>
> Signed-off-by: Michael Mueller
[..]
> static inline void gisa_set_ipm_gisc(struct kvm_s390_gisa
On Thu, 11 Feb 2021 09:21:26 -0500
Tony Krowiak wrote:
> Yes, it makes sense. I guess I didn't look closely at your
> suggestion when I said it was exactly what I implemented
> after agreeing with Connie. I had a slight difference in
> my implementation:
>
> static void vfio_ap_mdev_unset_kvm(st
le the lock is definitely
> needed to protect the setting/unsetting of the KVM pointer, it is not
> necessarily critical for setting the masks, so this will not be done under
> protection of the matrix_dev->lock.
With the one little thing I commented on below addressed:
Acked-by: H
On Wed, 10 Feb 2021 11:53:34 +0100
Cornelia Huck wrote:
> On Tue, 9 Feb 2021 14:48:30 -0500
> Tony Krowiak wrote:
>
> > This patch fixes a circular locking dependency in the CI introduced by
> > commit f21916ec4826 ("s390/vfio-ap: clean up vfio_ap resources when KVM
> > pointer invalidated").
On Wed, 10 Feb 2021 16:24:29 +0100
Halil Pasic wrote:
> > Maybe you could
> > - grab a reference to kvm while holding the lock
> > - call the mask handling functions with that kvm reference
> > - lock again, drop the reference, and do the rest of the processing?
>
On Wed, 10 Feb 2021 17:05:48 -0500
Tony Krowiak wrote:
> On 2/10/21 10:32 AM, Halil Pasic wrote:
> > On Wed, 10 Feb 2021 16:24:29 +0100
> > Halil Pasic wrote:
> >
> >>> Maybe you could
> >>> - grab a reference to kvm while holding the lock
>
1 - 100 of 318 matches
Mail list logo
