Re: [PATCH v2 0/6] atmel_serial: Cleanups, irq handler splitup & DMA

2007-12-22 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 21:32:44 +0100 "Remy Bohmer" <[EMAIL PROTECTED]> wrote: > > We need to fix the break- and error handling though. But my vacation > > starts tomorrow, so I probably won't be able to fix it until next > > year. > > In that case, I wish you very good holiday, and a happy new-ye

Re: [PATCH] w1-gpio: Add GPIO w1 bus master driver

2007-12-26 Thread Haavard Skinnemoen
On Fri, 21 Dec 2007 09:34:01 +0200 Ville Syrjala <[EMAIL PROTECTED]> wrote: > +static struct platform_device foo_w1_device = { > + .name = "w1-gpio", > + .id = -1, Assigning -1 to a u32 member isn't a very nice example. What does it mean anyway? > +s

Re: Correct use of __init and __devinit

2007-12-26 Thread Haavard Skinnemoen
On Mon, 24 Dec 2007 14:01:43 +0100 Sam Ravnborg <[EMAIL PROTECTED]> wrote: > So of the principle of least suprise it is best to use __devinit > for the probe function as most other drivers do. And if > the driver model happens to call your probe function after > init time then we will not oops. I

Re: git guidance

2007-11-28 Thread Haavard Skinnemoen
On Wed, 28 Nov 2007 00:20:46 +0100 (CET) Jan Engelhardt <[EMAIL PROTECTED]> wrote: > On Nov 27 2007 23:33, Tilman Schmidt wrote: > > > >It didn't work too well. The first result was one of maximal > >embarrassment: I produced a patch that didn't even compile when > >applied to the official tree. T

Re: git guidance

2007-11-29 Thread Haavard Skinnemoen
On Thu, 29 Nov 2007 13:45:44 +0100 Tilman Schmidt <[EMAIL PROTECTED]> wrote: > Haavard Skinnemoen schrieb: > > > > No, use "git rebase --interactive" ;-) > > What's that? I can't find it in "man git-rebase". I think it was added very

[PATCH] atmel_lcdfb: Validate display timings

2007-11-29 Thread Haavard Skinnemoen
Setting a display timing parameter too high or too low may cause it to wrap around and thus become completely wrong. Validate the timings in atmel_lcdfb_check_var() and saturate to the highest or lowest possible value if necessary. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTEC

[PATCH 1/2] [AVR32] Include instrumentation menu

2007-12-03 Thread Haavard Skinnemoen
Remove KPROBES option from Kconfig.debug and include kernel/Kconfig.instrumentation. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- arch/avr32/Kconfig |2 ++ arch/avr32/Kconfig.debug | 10 -- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git

[PATCH 2/2] [AVR32] Oprofile support

2007-12-03 Thread Haavard Skinnemoen
This adds the necessary architecture code to run oprofile on AVR32 using the performance counters documented by the AVR32 Architecture Manual. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> Acked-by: Philippe Elie <[EMAIL PROTECTED]> --- Mathieu, I want to get oprofile suppo

Re: [patch 0/4] Instrumentation menu removal

2007-12-04 Thread Haavard Skinnemoen
On Tue, 04 Dec 2007 12:43:58 -0500 Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > [PATCH 1/2] [AVR32] Include instrumentation menu > [PATCH 2/2] [AVR32] Oprofile support > > (which have been merged in the avr32 tree by Haavard) I forgot to actually apply the patches though. I've pushed them out

Re: [RFC 1/4] dmaengine: Add slave DMA interface

2007-12-05 Thread Haavard Skinnemoen
On Mon, 3 Dec 2007 12:20:15 -0700 "Dan Williams" <[EMAIL PROTECTED]> wrote: > Hi Haavard, > > Some (delayed) comments. Thanks for the feedback. > A few questions: > The one change that seems to be missing, at least in my mind, is > extending struct dma_client to include details about the slave

[PATCH] dmaengine: Simple DMA memcpy test client

2007-11-20 Thread Haavard Skinnemoen
This client tests DMA memcpy using various lengths and various offsets into the source and destination buffers. It will initialize both buffers with a know pattern and verify that the DMA engine copies the requested region and nothing more. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTEC

[PATCH] dmaengine: Driver for the AVR32 DMACA controller

2007-11-20 Thread Haavard Skinnemoen
This patch makes the "DMA Engine" menu visible on AVR32 and adds a driver for the DMACA (aka DW DMAC) controller. This DMA controller can be found on the AT32AP7000 chip and it primarily meant for peripheral DMA transfer, but can also be used for memory-to-memory transfers. The dmatest client show

Re: [PATCH] dmaengine: Simple DMA memcpy test client

2007-11-21 Thread Haavard Skinnemoen
On Tue, 20 Nov 2007 09:34:38 -0800 "Nelson, Shannon" <[EMAIL PROTECTED]> wrote: > >-Original Message- > >From: Haavard Skinnemoen [mailto:[EMAIL PROTECTED] > >+#define TEST_BUF_SIZE (16384) > > You might make this a module param

[PATCH] mmc: Add missing sg_init_table() call

2007-11-22 Thread Haavard Skinnemoen
mmc_init_queue only initializes the scatterlists with sg_init_table() when using a bounce buffer. This leads to a BUG() when CONFIG_DEBUG_SG is set. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- drivers/mmc/card/queue.c |3 ++- 1 files changed, 2 insertions(+), 1 del

[RFC 2/4] dmaengine: Make DMA Engine menu visible for AVR32 users

2007-11-23 Thread Haavard Skinnemoen
Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- drivers/dma/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 1db5499..9bcc392 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -4,

[RFC 3/4] dmaengine: Driver for the Synopsys DesignWare DMA controller

2007-11-23 Thread Haavard Skinnemoen
ff-by: Haavard Skinnemoen <[EMAIL PROTECTED]> Changes since v1: * Implement DMA slave operations * Set DWC_MAX_LEN to a more sane number * Get rid of the dummy descriptors * Fix DWC_CTLL_SRC_WIDTH() definition (wrong start bit) --- arch/avr32/mach-at32ap/at32ap7000.c| 29 +-

[PATCH v2] dmaengine: Simple DMA memcpy test client

2007-11-23 Thread Haavard Skinnemoen
This client tests DMA memcpy using various lengths and various offsets into the source and destination buffers. It will initialize both buffers with a know pattern and verify that the DMA engine copies the requested region and nothing more. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTEC

[RFC 0/4] dmaengine: Slave DMA interface and example users

2007-11-23 Thread Haavard Skinnemoen
rrors from time to time, so there are still some issues to be worked out. Haavard Haavard Skinnemoen (4): dmaengine: Add slave DMA interface dmaengine: Make DMA Engine menu visible for AVR32 users dmaengine: Driver for the Synopsys DesignWare DMA controller Atmel MCI: Driver fo

[RFC 4/4] Atmel MCI: Driver for Atmel on-chip MMC controllers

2007-11-23 Thread Haavard Skinnemoen
el sources provided by Atmel, but this particular version uses the generic DMA Engine framework (with the slave extensions) instead of an avr32-only DMA controller framework. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- arch/avr32/boards/atngw100/setup.c |6 + arch/avr32/

[RFC 1/4] dmaengine: Add slave DMA interface

2007-11-23 Thread Haavard Skinnemoen
controller to do slave DMA for a given device, and for terminating all pending transfers. The latter is needed because there may be errors outside the scope of the DMA Engine framework that requires DMA operations to be terminated prematurely. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTEC

Re: [RFC] Documentation about unaligned memory access

2007-11-24 Thread Haavard Skinnemoen
On Sat, 24 Nov 2007 17:22:36 + Luciano Rocha <[EMAIL PROTECTED]> wrote: > Nothing does, even memcpy doesn't check alignment of the source, or > alignment at all in some assembly implementations (only word-copy, > without checking if at word-boundary). An out-of-line implementation can only do

Re: [RFC 4/4] Atmel MCI: Driver for Atmel on-chip MMC controllers

2007-11-24 Thread Haavard Skinnemoen
On Sat, 24 Nov 2007 18:00:23 +0100 Pierre Ossman <[EMAIL PROTECTED]> wrote: > On Fri, 23 Nov 2007 13:20:13 +0100 > Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > > > This is a driver for the MMC controller on the AP7000 chips from > > Atmel. It should in the

Re: [RFC 4/4] Atmel MCI: Driver for Atmel on-chip MMC controllers

2007-11-24 Thread Haavard Skinnemoen
On Sat, 24 Nov 2007 10:48:39 -0800 David Brownell <[EMAIL PROTECTED]> wrote: > On Saturday 24 November 2007, Haavard Skinnemoen wrote: > > > > > > Why is this needed and is it perhaps something that can be moved > > > to the MMC core? > > > > We

Re: [PATCH] mmc: Add missing sg_init_table() call

2007-11-27 Thread Haavard Skinnemoen
On Mon, 26 Nov 2007 21:29:55 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Thu, 22 Nov 2007 20:32:51 +0100 Haavard Skinnemoen <[EMAIL PROTECTED]> > wrote: > > > mmc_init_queue only initializes the scatterlists with sg_init_table() > > when using a bounce b

[PATCH] ptrace: Call arch_ptrace_attach() when request=PTRACE_TRACEME

2007-11-27 Thread Haavard Skinnemoen
ally being debugged and keep it off otherwise. To be able to do this, I need to intercept PTRACE_TRACEME and PTRACE_ATTACH, as well as PTRACE_DETACH and thread exit. The latter two can be handled by existing hooks. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- kernel/ptrace.c |

Re: [RFC, PATCH] watchdog on gpio

2008-01-14 Thread Haavard Skinnemoen
On Mon, 14 Jan 2008 04:45:25 -0500 "Mike Frysinger" <[EMAIL PROTECTED]> wrote: > there is no hard requirement anywhere that says platform resources > must be in the board resources file. marking the functions as __init > instead of __devinit will basically cause a kernel crash if someone > tries

Re: [RFC, PATCH] watchdog on gpio

2008-01-14 Thread Haavard Skinnemoen
On Mon, 14 Jan 2008 07:22:39 -0500 "Mike Frysinger" <[EMAIL PROTECTED]> wrote: > > There is: platform_driver_probe(). It takes the probe function as a > > parameter so that it can be left out of the platform_driver struct. > > After it returns, there are no references to the probe function left >

Re: [RFC, PATCH, take 2] watchdog on generic gpio

2008-01-14 Thread Haavard Skinnemoen
On Mon, 14 Jan 2008 15:03:14 +0100 Florian Fainelli <[EMAIL PROTECTED]> wrote: > Le lundi 14 janvier 2008, Marc Pignat a écrit : > > Hi Florian! > > I understand your wish, but... > > You told me that your plaform doesn't implement the generic gpio > > interface (yet?), so this driver can't work f

Re: [PATCH]: Atmel Serial Console interrupt handler splitup

2007-12-17 Thread Haavard Skinnemoen
On Fri, 14 Dec 2007 12:46:09 +0100 "Remy Bohmer" <[EMAIL PROTECTED]> wrote: > Hello Andrew, > > So, to come to a conclusion about this complex patch series, I > attached all the latest versions to this mail. The latest patches from > yesterday including inline are also included to make the set co

Re: [PATCH]: Atmel Serial Console interrupt handler splitup

2007-12-17 Thread Haavard Skinnemoen
On Mon, 17 Dec 2007 13:17:01 +0100 Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > > 3) NEW: optional: add-atmel-serial-dma.patch, this merged the DMA > > code (from Chip Coldwell) in your 2.6.23 patch back on top of this > > series. Because the AT32 bug is not been fixed

Re: [PATCH]: Atmel Serial Console interrupt handler splitup

2007-12-17 Thread Haavard Skinnemoen
On Mon, 17 Dec 2007 21:56:30 +0100 "Remy Bohmer" <[EMAIL PROTECTED]> wrote: > > Btw, it would be nice if patches that affect more or less > > architecture-independent drivers were posted to linux-kernel (added > > to Cc.) > > Not really architecture independant, I believe, because thos are > driv

Re: [PATCH]: Atmel Serial Console interrupt handler splitup

2007-12-18 Thread Haavard Skinnemoen
On Mon, 17 Dec 2007 23:49:32 + Russell King - ARM Linux <[EMAIL PROTECTED]> wrote: > On Mon, Dec 17, 2007 at 09:56:30PM +0100, Remy Bohmer wrote: > > > > +#define lread(port) __raw_readl(port) > > > > +#define lwrite(v, port) __raw_writel(v, port) > > > > > > Why is this

[PATCH v2] atmel_serial: Clean up the code

2007-12-18 Thread Haavard Skinnemoen
From: Remy Bohmer <[EMAIL PROTECTED]> This patch cleans up the atmel_serial driver to conform the coding rules. It contains no functional change. [EMAIL PROTECTED]: additional cleanups] Signed-off-by: Remy Bohmer <[EMAIL PROTECTED]> Signed-off-by: Haavard Skinnemoen <[

Re: [PATCH]: Atmel Serial Console interrupt handler splitup

2007-12-18 Thread Haavard Skinnemoen
On Tue, 18 Dec 2007 12:08:05 +0200 "Andrew Victor" <[EMAIL PROTECTED]> wrote: > > #define at_readl(port, off) __raw_readl((port)->membase + (off)) > > #define at_writel(v, port, off) __raw_writel(v, (port)->membase + (off)) > > > > #define UART_PUT_CR(port, v)at_writel(v, port, ATMEL_US_CR

Re: [PATCH v2] atmel_serial: Clean up the code

2007-12-18 Thread Haavard Skinnemoen
On Tue, 18 Dec 2007 11:14:42 +0100 "Remy Bohmer" <[EMAIL PROTECTED]> wrote: > Hello Haavard, > > > Please note that I'm not trying to steal the show here -- I just want > > That did not even come to my mind at all... > I am happy with everything that helps making this driver better. Good :) >

Re: [PATCH v2] atmel_serial: Clean up the code

2007-12-18 Thread Haavard Skinnemoen
On Tue, 18 Dec 2007 21:22:01 +0800 steve birtles <[EMAIL PROTECTED]> wrote: > Is there any change can we clean this up? > /* >* We wrap our port structure around the generic uart_port. > @@ -142,8 +146,8 @@ static void atmel_set_mctrl(struct uart_port > *port, u_int mctrl) > #ifdef CONFI

[PATCH] atmel_serial: Split the interrupt handler

2007-12-18 Thread Haavard Skinnemoen
TECTED]: misc cleanups and simplifications] Signed-off-by: Remy Bohmer <[EMAIL PROTECTED]> Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- Changes since v1: Whitespace cleanups Allocate rx ring data separately Move more of the rx processing into tasklet

[PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-18 Thread Haavard Skinnemoen
; Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- drivers/serial/atmel_serial.c | 215 - 1 files changed, 169 insertions(+), 46 deletions(-) diff --git a/drivers/serial/atmel_serial.c b/drivers/serial/atmel_serial.c index a6b3828..990d3ab 10

[PATCH 3/5] atmel_serial: Use existing console options only if BRG is running

2007-12-18 Thread Haavard Skinnemoen
If BRGR is zero, the baud rate generator isn't running, so the boot loader can't have initialized the port. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- drivers/serial/atmel_serial.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) diff

[PATCH 1/5] atmel_serial: Clean up the code

2007-12-18 Thread Haavard Skinnemoen
From: Remy Bohmer <[EMAIL PROTECTED]> This patch cleans up the atmel_serial driver to conform the coding rules. It contains no functional change. [EMAIL PROTECTED]: additional cleanups] Signed-off-by: Remy Bohmer <[EMAIL PROTECTED]> Signed-off-by: Haavard Skinnemoen <[

[PATCH 0/5] atmel_serial: Cleanups, irq handler splitup & DMA

2007-12-18 Thread Haavard Skinnemoen
ing about it. Please let me know if this isn't how you want it. Chip Coldwell (1): atmel_serial: Add DMA support Haavard Skinnemoen (2): atmel_serial: Use cpu_relax() when busy-waiting atmel_serial: Use existing console options only if BRG is running Remy Bohm

[PATCH 2/5] atmel_serial: Use cpu_relax() when busy-waiting

2007-12-18 Thread Haavard Skinnemoen
Replace two instances of barrier() with cpu_relax() since that's the right thing to do when busy-waiting. This does not actually change anything since cpu_relax() is defined as barrier() on both ARM and AVR32. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- dri

[PATCH 5/5] atmel_serial: Add DMA support

2007-12-18 Thread Haavard Skinnemoen
L PROTECTED]: rebased onto irq-splitup patch] [EMAIL PROTECTED]: moved to tasklet, fixed dma bug, misc cleanups] Signed-off-by: Remy Bohmer <[EMAIL PROTECTED]> Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- drivers/serial/atmel_serial.c | 386 ++

Re: [PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-18 Thread Haavard Skinnemoen
On Tue, 18 Dec 2007 18:06:14 +0100 Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > From: Remy Bohmer <[EMAIL PROTECTED]> Heh. That's obviously wrong. Wonder what happened there? Looks like Chip's address got mangled too. Haavard -- To unsubscribe from this list: s

Re: [PATCH] atmel_serial: Split the interrupt handler

2007-12-18 Thread Haavard Skinnemoen
Crud...my mailer helpfully filtered this into the huge linux-kernel bin instead of leaving it in my inbox... On Tue, 18 Dec 2007 16:23:11 +0100 "Remy Bohmer" <[EMAIL PROTECTED]> wrote: > Hello Haavard, > > A few remarks: > > > From: Remy Bohmer <[EMAIL PROTECTED]> > > My name, at your address

Re: [PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-19 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 00:15:24 +0100 Jiri Slaby <[EMAIL PROTECTED]> wrote: > On 12/18/2007 06:06 PM, Haavard Skinnemoen wrote: > > port = &atmel_ports[pdev->id]; > > atmel_init_port(port, pdev); > > > > + data = kmalloc(ATMEL_SERIAL_

Re: [PATCH 0/5] atmel_serial: Cleanups, irq handler splitup & DMA

2007-12-19 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 09:29:52 +0200 "Vadim Yatsenko" <[EMAIL PROTECTED]> wrote: > What prepatches one need to aply to what kernel version (vanila, git, ...) > before these? They should apply to a fresh checkout of Linus' git tree. If you want to use 2.6.23, you need to apply this patch first: h

Re: [PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-19 Thread Haavard Skinnemoen
On Tue, 18 Dec 2007 13:19:39 -0500 (EST) Chip Coldwell <[EMAIL PROTECTED]> wrote: > > On Tue, 18 Dec 2007 18:06:14 +0100 > > Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > > > > > From: Remy Bohmer <[EMAIL PROTECTED]> > > > >

Re: [PATCH] atmel_serial: Split the interrupt handler

2007-12-19 Thread Haavard Skinnemoen
On Tue, 18 Dec 2007 16:23:11 +0100 "Remy Bohmer" <[EMAIL PROTECTED]> wrote: > Preempt-RT now absolutely requires my (4th) IRQ_NODELAY patch, because > the spinlock now is always inside the code, and not only in > theexception path, and thus without my NO_DELAY patch we have a panic > during boot.

Re: [PATCH] atmel_serial: Split the interrupt handler

2007-12-19 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 13:50:16 +0100 "Remy Bohmer" <[EMAIL PROTECTED]> wrote: > Hello Haavard, > > > Hmm...perhaps we can eliminate the locking in the status handler > > too...? Does anyone see a problem with this patch? > > I have not seen any problem so far, besides, I am very happy with a > l

Re: [PATCH] atmel_serial: Split the interrupt handler

2007-12-19 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 14:18:18 +0100 "Remy Bohmer" <[EMAIL PROTECTED]> wrote: > Hello Haavard, > > > Hrm. We probably need to lock while updating icount. That's a problem > > since we do that from the tx interrupt handler...and I don't suppose we > > want to move most of the atmel_tx_chars() code i

Re: [PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-19 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 12:40:08 +0100 Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > Btw, the funny thing is that, looking at my shell history, I think I > actually did the right thing when committing your patches: > > git commit -s --author 'Remy Bohmer <[EMAIL PR

[PATCH v2 4/6] atmel_serial: Fix bugs in probe() error path and remove()

2007-12-19 Thread Haavard Skinnemoen
When an error happens in probe(), the clocks should be disabled, but only if the port isn't already used as a console. In remove(), the port struct shouldn't be freed because it's defined statically. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- drivers/serial/

[PATCH v2 2/6] atmel_serial: Use cpu_relax() when busy-waiting

2007-12-19 Thread Haavard Skinnemoen
Replace two instances of barrier() with cpu_relax() since that's the right thing to do when busy-waiting. This does not actually change anything since cpu_relax() is defined as barrier() on both ARM and AVR32. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- dri

[PATCH v2 3/6] atmel_serial: Use existing console options only if BRG is running

2007-12-19 Thread Haavard Skinnemoen
If BRGR is zero, the baud rate generator isn't running, so the boot loader can't have initialized the port. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- drivers/serial/atmel_serial.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) diff

[PATCH v2 6/6] atmel_serial: Add DMA support

2007-12-19 Thread Haavard Skinnemoen
g, misc cleanups] Signed-off-by: Remy Bohmer <[EMAIL PROTECTED]> Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- drivers/serial/atmel_serial.c | 390 ++--- 1 files changed, 365 insertions(+), 25 deletions(-) diff --git a/drivers/serial/atm

[PATCH v2 0/6] atmel_serial: Cleanups, irq handler splitup & DMA

2007-12-19 Thread Haavard Skinnemoen
to this driver (including my own). The PDC error handling also accesses icount without locking. I'm tempted to just ignore the problem for now and hopefully come up with a solution later. Everyone, please give it a try and/or review the code. Chip Coldwell (1): atmel_serial: Add DMA support H

[PATCH v2 1/6] atmel_serial: Clean up the code

2007-12-19 Thread Haavard Skinnemoen
From: Remy Bohmer <[EMAIL PROTECTED]> This patch cleans up the atmel_serial driver to conform the coding rules. It contains no functional change. Signed-off-by: Remy Bohmer <[EMAIL PROTECTED]> Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- drivers/serial/atm

[PATCH v2 5/6] atmel_serial: Split the interrupt handler

2007-12-19 Thread Haavard Skinnemoen
ations] Signed-off-by: Remy Bohmer <[EMAIL PROTECTED]> Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- drivers/serial/atmel_serial.c | 239 +++-- 1 files changed, 184 insertions(+), 55 deletions(-) diff --git a/drivers/serial/atmel_serial.

Re: [PATCH v2 0/6] atmel_serial: Cleanups, irq handler splitup & DMA

2007-12-19 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 16:57:04 +0100 "Remy Bohmer" <[EMAIL PROTECTED]> wrote: > Hello Haavard, > > Sorry.. But I get an Oops on Preempt-RT with the latest set of > patches. I did not see it earlier today with the other set of patches. Hmm...from the backtrace, it looks like lock recursion -- port-

Re: [PATCH v2 0/6] atmel_serial: Cleanups, irq handler splitup & DMA

2007-12-19 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 17:40:44 +0100 "Remy Bohmer" <[EMAIL PROTECTED]> wrote: > But... I tried that patch, and it works a lot better, no oopses > anymore, Good :) > but I noticed that I sometimes get an input overrun (ttyS0: 1 > input overrun(s) ) during stress conditions. > This is something I di

Re: [PATCH v2 0/6] atmel_serial: Cleanups, irq handler splitup & DMA

2007-12-19 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 17:59:09 +0100 "Remy Bohmer" <[EMAIL PROTECTED]> wrote: > > > but I noticed that I sometimes get an input overrun (ttyS0: 1 > > > input overrun(s) ) during stress conditions. > > > This is something I did not notice before, maybe it was already there, > > > or has something cha

[GIT PULL] AVR32 update

2008-01-25 Thread Haavard Skinnemoen
architectures at the moment. Please update your patch so that it also updates the avr32 Kconfig when removing it. David Brownell (1): [AVR32] extint: change set_irq_type() handling Haavard Skinnemoen (16): [AVR32] Drop GFP_COMP for DMA memory allocations [AVR32] Remove redundant

Re: [PATCH -mm 1/2] Basic PWM driver for AVR32 and AT91

2008-01-27 Thread Haavard Skinnemoen
On Thu, 24 Jan 2008 12:53:13 -0800 David Brownell <[EMAIL PROTECTED]> wrote: > On Thursday 24 January 2008, Haavard Skinnemoen wrote: > > +config ATMEL_PWM > > +   tristate "Atmel AT32/AT91 PWM support" > > +   depends on (AVR32 || AT91) && E

Re: Question about DMA

2008-01-28 Thread Haavard Skinnemoen
On Mon, 28 Jan 2008 09:55:58 +0100 "Francis Moreau" <[EMAIL PROTECTED]> wrote: > My DMA controller has very little in common with ISA DMA one. But I'd like to > use it in a driver. This driver can do DMA but with the help of an external > DMA > controller. It's only implement the "slave" side. So

Re: [PATCH -mm 2/2] PWM LED driver

2008-01-28 Thread Haavard Skinnemoen
On Sun, 27 Jan 2008 21:32:32 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Thu, 24 Jan 2008 15:33:45 +0100 Haavard Skinnemoen <[EMAIL PROTECTED]> > wrote: > > > + if (i > 0) { > > + for (i = i - 1; i >= 0; i--) { > > +

Re: [PATCH -mm v4 7/9] atmel_serial: Add DMA support

2008-01-28 Thread Haavard Skinnemoen
On Sat, 26 Jan 2008 22:02:00 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > > On Thu, 24 Jan 2008 13:41:49 +0100 Haavard Skinnemoen <[EMAIL PROTECTED]> > > wrote: > > +#define PDC_RX_BUF(port) &(port)->pdc_rx[(port)->pdc_rx_idx] > > +#define

Re: [PATCH -mm 2/2] PWM LED driver

2008-01-28 Thread Haavard Skinnemoen
On Mon, 28 Jan 2008 01:29:32 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > > - if (i > 0) { > > - for (i = i - 1; i >= 0; i--) { > > - led_classdev_unregister(&leds[i].cdev); > > - pwm_channel_free(&leds[i].pwmc); > > - } > > + while (

Re: Question about DMA

2008-01-28 Thread Haavard Skinnemoen
On Mon, 28 Jan 2008 11:22:49 +0100 "Francis Moreau" <[EMAIL PROTECTED]> wrote: > > Please let me know if you think this will work for your hardware. > > Thanks for pointing this out. I currently can't look at this but I'll > try to give it > a deep look this week. Great. I'll Cc you on the nex

[PATCH -mm] atmel_serial dma: Misc fixes and cleanups

2008-01-28 Thread Haavard Skinnemoen
ERIAL_XMIT_SIZE/UART_XMIT_SIZE/ since the latter is what the serial core circ macros use. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- Please fold into atmel_serial-add-dma-support.patch, or let me know if you want a replacement for that patch. drivers/serial/

Re: [PATCH -mm v4 7/9] atmel_serial: Add DMA support

2008-01-28 Thread Haavard Skinnemoen
On Mon, 28 Jan 2008 02:20:00 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Mon, 28 Jan 2008 10:59:09 +0100 Haavard Skinnemoen <[EMAIL PROTECTED]> > wrote: > > > > ho-hum. The generic uart buffer-handling code does ringbuffers the wrong > > > way.

Re: at91sam9260 wakeup on serial port

2008-01-28 Thread Haavard Skinnemoen
On Mon, 28 Jan 2008 12:15:00 +0100 michael <[EMAIL PROTECTED]> wrote: > Hi, > I implement a little patch (ndr just for a try) for the atmel serial > driver atmel_serial.c to wakeup the system when it is in suspend-ram state. > I reconfigure the RXD pin as a gpio in suspend function and restore it

Re: at91sam9260 wakeup on serial port

2008-01-28 Thread Haavard Skinnemoen
On Mon, 28 Jan 2008 10:21:57 -0800 David Brownell <[EMAIL PROTECTED]> wrote: > What will AVR32 (AP7) need to do, when it supports system sleep states? Not sure. The PIOs seem to require a clock in order to detect a pin change, so I don't think we can enter very deep sleep states if we want to be

[RFC v2 0/5] dmaengine: Slave DMA interface and example users

2008-01-29 Thread Haavard Skinnemoen
moen/dmaslave.git master which contains everything you need to try it out. Haavard Skinnemoen (5): dmaengine: Add dma_client parameter to device_alloc_chan_resources dmaengine: Add slave DMA interface dmaengine: Make DMA Engine menu visible for AVR32 users dmaengine: Driver fo

[RFC v2 5/5] Atmel MCI: Driver for Atmel on-chip MMC controllers

2008-01-29 Thread Haavard Skinnemoen
el sources provided by Atmel, but this particular version uses the generic DMA Engine framework (with the slave extensions) instead of an avr32-only DMA controller framework. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- arch/avr32/boards/atngw100/setup.c |6 + arch/avr32/

[RFC v2 3/5] dmaengine: Make DMA Engine menu visible for AVR32 users

2008-01-29 Thread Haavard Skinnemoen
Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- drivers/dma/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 893a3f8..1a727c1 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -4,

[RFC v2 1/5] dmaengine: Add dma_client parameter to device_alloc_chan_resources

2008-01-29 Thread Haavard Skinnemoen
the client requesting the channel to the driver's device_alloc_chan_resources hook so that it can pick the necessary information from the dma_client struct by itself. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- drivers/dma/dmaengine.c |3 ++- drivers/dma/ioat_dma.c|

[RFC v2 2/5] dmaengine: Add slave DMA interface

2008-01-29 Thread Haavard Skinnemoen
ions to be terminated prematurely. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> dmaslave interface changes since v1: * Drop the set_direction and set_width descriptor hooks. Pass the direction and width to the prep function instead. * Declare a dma_slave struct with fixed inf

[RFC v2 4/5] dmaengine: Driver for the Synopsys DesignWare DMA controller

2008-01-29 Thread Haavard Skinnemoen
e DMA Engine framework. It also implements the proposed extensions to the DMA Engine API for slave DMA operations. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- arch/avr32/mach-at32ap/at32ap700x.c| 29 +- drivers/dma/Kconfig|9 + drivers/d

Re: [RFC v2 0/5] dmaengine: Slave DMA interface and example users

2008-01-29 Thread Haavard Skinnemoen
On Tue, 29 Jan 2008 19:10:08 +0100 Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > This patch series adds the necessary interfaces to the DMA Engine > framework to use functionality found on most embedded DMA controllers: > DMA from and to I/O registers with hardware handshaking

Re: [RFC v2 0/5] dmaengine: Slave DMA interface and example users

2008-01-30 Thread Haavard Skinnemoen
On Tue, 29 Jan 2008 22:56:14 -0800 David Brownell <[EMAIL PROTECTED]> wrote: > On Tuesday 29 January 2008, Haavard Skinnemoen wrote: > > > > Btw, there's one issue I forgot to mention: I believe the DMA Engine > > framework is currently misusing the DMA mapping

Re: [RFC v2 2/5] dmaengine: Add slave DMA interface

2008-01-30 Thread Haavard Skinnemoen
On Tue, 29 Jan 2008 23:30:05 -0800 David Brownell <[EMAIL PROTECTED]> wrote: > On Tuesday 29 January 2008, Haavard Skinnemoen wrote: > > @@ -297,6 +356,13 @@ struct dma_device { > > struct dma_async_tx_descriptor *(*device_prep_dma_interrupt)( > >   

Re: [PATCH -mm v4 6/9] atmel_serial: Split the interrupt handler

2008-01-30 Thread Haavard Skinnemoen
On Wed, 30 Jan 2008 00:12:23 +0100 michael <[EMAIL PROTECTED]> wrote: > I'm testing this patch on an at91sam9260 on 2.6.24-rt. I'm using this > patch with the tclib support for hrtimer and the clocksource pit_clk. > These are the results: > > - Voluntary Kernel Preemption the system (crash) > - P

Re: [PATCH -mm v4 6/9] atmel_serial: Split the interrupt handler

2008-01-30 Thread Haavard Skinnemoen
On Wed, 30 Jan 2008 11:21:49 +0100 "Remy Bohmer" <[EMAIL PROTECTED]> wrote: > > > * Drop the lock here since it might end up calling > > > * uart_start(), which takes the lock. > > >spin_unlock(&port->lock); > > > */ > > > tty_flip_buffer_push(port->info->tty); > > > /* > > > spin_l

Re: at91sam9260 wakeup on serial port

2008-01-30 Thread Haavard Skinnemoen
On Tue, 29 Jan 2008 19:44:53 -0800 David Brownell <[EMAIL PROTECTED]> wrote: > On Monday 28 January 2008, Haavard Skinnemoen wrote: > > > > > What will AVR32 (AP7) need to do, when it supports system sleep states? > > > > Not sure. The PIOs seem to requ

Re: [RFC v2 2/5] dmaengine: Add slave DMA interface

2008-01-30 Thread Haavard Skinnemoen
On Wed, 30 Jan 2008 02:52:49 -0800 David Brownell <[EMAIL PROTECTED]> wrote: > On Wednesday 30 January 2008, Haavard Skinnemoen wrote: > > Descriptor-based vs. register-based transfers sounds like something the > > DMA engine driver is free to decide on its own. > >

Re: [PATCH -mm v4 6/9] atmel_serial: Split the interrupt handler

2008-01-30 Thread Haavard Skinnemoen
On Wed, 30 Jan 2008 11:29:59 +0100 michael <[EMAIL PROTECTED]> wrote: > > Now, _that_ is strange. I can't see anything that needs protection > > across that call; in fact, I think we can lock a lot less than what we > > currently do. > > > > > I explain it bad: > - with spin_lock the system seem

Re: [PATCH -mm v4 6/9] atmel_serial: Split the interrupt handler

2008-01-30 Thread Haavard Skinnemoen
On Wed, 30 Jan 2008 12:05:40 +0100 "Remy Bohmer" <[EMAIL PROTECTED]> wrote: > > > I believe I have to look at the latest set of patches, and try to find > > > any regressions. Do you have a location somewhere where I can download > > > the latest versions? Or do I need to dig through LKML to find

Re: [PATCH -mm v4 6/9] atmel_serial: Split the interrupt handler

2008-01-30 Thread Haavard Skinnemoen
On Wed, 30 Jan 2008 16:26:27 +0100 michael <[EMAIL PROTECTED]> wrote: > > I have no idea. Could you post some more specifics about what you > > modified, for example a diff? > > > > > > ... > /* The interrupt handler does not take the lock */ > spin_lock_irqsave(&port->lock, flags); > atmel_

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-14 Thread Haavard Skinnemoen
On Wed, 14 Nov 2007 00:37:57 -0800 David Brownell <[EMAIL PROTECTED]> wrote: > Although another point is related to "trivial": the data > is being protected through an operation too trivial to be > worth paying for any of that priority logic. But isn't there any way we can remove the lock from t

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread Haavard Skinnemoen
On Wed, 14 Nov 2007 22:50:17 -0800 David Brownell <[EMAIL PROTECTED]> wrote: > > Since this is the code that runs under the lock > > No, there's more than that. This is what runs under it in > the hot paths, yes, but the gpio request/free paths do > more work than this. (That includes directi

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread Haavard Skinnemoen
On Thu, 15 Nov 2007 00:20:33 -0800 David Brownell <[EMAIL PROTECTED]> wrote: > > > - gpio_direction_input()/gpio_direction_output() implicitly > > > request the pins, if they weren't already requested. > > > > Eek, that's completely wrong. Allowing to access a resource _before_ > > it is

Re: [PATCH] More CFI fixups for Atmel chips

2007-11-15 Thread Haavard Skinnemoen
On Tue, 30 Oct 2007 16:33:07 +0100 Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > This patch (or some variation of it) has been posted a couple of times > before to the MTD list, and I find myself applying it over and over > again when testing stuff against the latest mai

[GIT PULL] avr32 fixes for 2.6.24-rc3

2007-11-15 Thread Haavard Skinnemoen
Linus, Please pull from ssh://master.kernel.org/pub/scm/linux/kernel/git/hskinnemoen/avr32-2.6.git for-linus to receive the following updates. Adrian Bunk (1): [AVR32] remove UID16 option Haavard Skinnemoen (4): [AVR32] pcmcia ioaddr_t should be 32 bits on AVR32 [AVR32

[PATCH] DMA: Fix broken device refcounting

2007-10-26 Thread Haavard Skinnemoen
after-free fun. Fix it by incrementing the device's reference count twice for each channel during registration. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- I'm not sure if this is the correct way to solve it, but it seems to work. The remove() function does not hang, whi

Re: [PATCH] DMAENGINE: too many kref_put calls

2007-10-27 Thread Haavard Skinnemoen
On Fri, 26 Oct 2007 16:56:48 -0700 Shannon Nelson <[EMAIL PROTECTED]> wrote: > @@ -134,8 +134,7 @@ static void dma_async_device_cleanup(struct kref > *kref); > static void dma_dev_release(struct device *dev) > { > - struct dma_chan *chan = to_dma_chan(dev); > - kref_put(&chan->device->r

Re: [PATCH] DMA: Fix broken device refcounting

2007-10-27 Thread Haavard Skinnemoen
On Fri, 26 Oct 2007 09:36:17 -0700 Dan Williams <[EMAIL PROTECTED]> wrote: > @@ -221,7 +220,6 @@ void dma_chan_cleanup(struct kref *kref) > { > struct dma_chan *chan = container_of(kref, struct dma_chan, refcount); > chan->device->device_free_chan_resources(chan); > - kref_put(&ch

Re: [PATCH] DMA: Correct invalid assumptions in the Kconfig text

2007-10-27 Thread Haavard Skinnemoen
On Fri, 26 Oct 2007 10:02:24 -0700 "Dan Williams" <[EMAIL PROTECTED]> wrote: > On 10/25/07, Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > > static irqreturn_t iop_adma_err_handler(int irq, void *data) > > { > > (...) > > > >

Re: [PATCH] DMA: Correct invalid assumptions in the Kconfig text

2007-10-27 Thread Haavard Skinnemoen
On Fri, 26 Oct 2007 09:44:44 -0700 "Dan Williams" <[EMAIL PROTECTED]> wrote: > On 10/24/07, Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > > > Otherwise, Acked-by: Dan Williams <[EMAIL PROTECTED]> > > > > Thanks. Are one of you going to

Re: sg_next() for struct scatterlist is confusing

2007-10-27 Thread Haavard Skinnemoen
On Sat, 27 Oct 2007 07:39:40 -0400 (EDT) "Robert P. J. Day" <[EMAIL PROTECTED]> wrote: > note how the comment says that the next entry will "usually" be > sg+1, "but" not if it's actually a pointer. > > however, as i read the code above, sg is *always* incremented before > that testing. is t

<    1   2   3   4   >