codecs are
TLV320AIC23 and WM8731.
Signed-off-by: Florian Meier
---
A Raspberry Pi kernel featuring this driver can be found at
https://github.com/koalo/linux rpi-3.8.y-asocdev
You can find more information about how to use it at
http://blog.koalo.de/2013/05/i2s-support-for-raspberry-pi.html
On 22.05.2013 17:22, Stephen Warren wrote:
> On 05/22/2013 08:10 AM, Florian Meier wrote:
>> This driver adds support for digital audio (I2S)
>> for the BCM2708 SoC that is used by the
>> Raspberry Pi. External audio codecs can be
>> connected to the Raspberry Pi via P5
On 22.05.2013 18:15, Stephen Warren wrote:
> On 05/22/2013 10:08 AM, Florian Meier wrote:
>> On 22.05.2013 17:22, Stephen Warren wrote:
>>> On 05/22/2013 08:10 AM, Florian Meier wrote:
>>>> This driver adds support for digital audio (I2S)
>>>> for the BCM2
On 22.05.2013 18:39, Mark Brown wrote:
> On Wed, May 22, 2013 at 04:10:20PM +0200, Florian Meier wrote:
>
>> This driver adds support for digital audio (I2S)
>> for the BCM2708 SoC that is used by the
>> Raspberry Pi. External audio codecs can be
>> connected to
2013/5/22 Lars-Peter Clausen
>
> On 05/22/2013 04:10 PM, Florian Meier wrote:
> [...]
> > diff --git a/sound/soc/bcm2708/bcm2708-i2s.c
> > b/sound/soc/bcm2708/bcm2708-i2s.c
> > new file mode 100644
> > index 000..a8e995f
> > --- /dev/null
> > +++
Thanks to you and to all who have looked at/corrected my patch!
I learned a lot!
On 01/07/2014 05:15 PM, Vinod Koul wrote:
> On Mon, Jan 06, 2014 at 08:18:24PM +0100, Florian Meier wrote:
>> Add support for DMA controller of BCM2835 as used in the Raspberry Pi.
>> Currently i
Thank you very much!
I am sorry and will try to make it better next time.
On 11/28/2013 09:50 AM, Wolfram Sang wrote:
> On Mon, Nov 25, 2013 at 09:01:50AM +0100, Florian Meier wrote:
>> In order to find I2C devices in the device tree, the platform nodes
>> have to be known by the
On 01/12/2014 10:11 PM, Daniel Matuschek wrote:
> Signed-off-by: Daniel Matuschek
>
> After some discussions of the patch last week, here is a new version.
> Simply reducing the post_table did not work, as for some frequencies
> both settings (MCLKDIV=0 and MCLKDIV=1) are needed (e.g. 96 and 192k
This adds the definitions for the BCM2835 dmaengine driver
to the device tree. The dma-channel-mask is currently
fixed. Later it should be set via the firmware.
Signed-off-by: Florian Meier
---
arch/arm/boot/dts/bcm2835.dtsi | 21 +
1 file changed, 21 insertions(+)
diff
This adds the definitions for the BCM2835 I2S driver
to the device tree. Some GPIO settings are needed for
the correct pin functions.
Signed-off-by: Florian Meier
---
arch/arm/boot/dts/bcm2835-rpi-b.dts | 12 +++-
arch/arm/boot/dts/bcm2835.dtsi | 10 ++
2 files changed, 21
This adds the definitions for the BCM2835 I2S driver
to the device tree. Some GPIO settings are needed for
the correct pin functions.
Signed-off-by: Florian Meier
---
Sorry, I forgot to disable word-wrap again
arch/arm/boot/dts/bcm2835-rpi-b.dts | 12 +++-
arch/arm/boot/dts
On 14.01.2014 03:57, Stephen Warren wrote:
> On 01/13/2014 04:16 AM, Florian Meier wrote:
>> This adds the definitions for the BCM2835 I2S driver
>> to the device tree. Some GPIO settings are needed for
>> the correct pin functions.
>
> Patch 1/1 and the .dtsi portion of
In order to find I2C devices in the device tree, the platform nodes
have to be known by the I2C core. Analogous to the i2c-omap driver
this requires setting the dev.of_node parameter of the adapter.
Signed-off-by: Florian Meier
---
I don't know if this is really necessary, but for me it
Add support for DMA controller of BCM2835 as used in the Raspberry Pi.
Currently it only supports cyclic DMA for serving the I2S driver.
Signed-off-by: Florian Meier
---
arch/arm/boot/dts/bcm2835.dtsi | 22 +
drivers/dma/Kconfig|6 +
drivers/dma/Makefile |1
This driver adds support for digital audio (I2S)
for the BCM2835 SoC that is used by the
Raspberry Pi. External audio codecs can be
connected to the Raspberry Pi via P5 header.
It relies on cyclic DMA engine support for BCM2835.
Signed-off-by: Florian Meier
---
This patch does not cleanly
Thank you for your helpful comments.
I have applied them to my code and will upload a new version soon
(hoping that I understand everything correctly).
2013/11/8 Russell King - ARM Linux :
> On Fri, Nov 08, 2013 at 06:22:34PM +0100, Florian Meier wrote:
>
> Hi Florian, some initial
Add support for DMA controller of BCM2835 as used in the Raspberry Pi.
Currently it only supports cyclic DMA.
Signed-off-by: Florian Meier
---
Second version of patch. Main improvements:
- Initialization of control blocks in prep function
- Request DREQ from device tree
- Request channel mask
Add support for DMA controller of BCM2835 as used in the Raspberry Pi.
Currently it only supports cyclic DMA.
Signed-off-by: Florian Meier
---
Thank you for your comments!
I hope I have now removed all leftovers of the sg struct.
Regarding the endian-ness: I have not found any hint about that
This driver adds support for digital audio (I2S)
for the BCM2835 SoC that is used by the
Raspberry Pi. External audio codecs can be
connected to the Raspberry Pi via P5 header.
It relies on cyclic DMA engine support for BCM2835.
Signed-off-by: Florian Meier
---
Second version
> + dev = devm_kzalloc(&pdev->dev, sizeof(*dev),
> +GFP_KERNEL);
> + if (IS_ERR(base))
> + return PTR_ERR(base);
Found a typo here, should be IS_ERR(dev) and PTR_ERR(dev).
Is the patch acceptable apart from that now?
Greetings,
Florian
--
To unsubscrib
This driver adds support for digital audio (I2S)
for the BCM2835 SoC that is used by the
Raspberry Pi. External audio codecs can be
connected to the Raspberry Pi via P5 header.
It relies on cyclic DMA engine support for BCM2835.
Signed-off-by: Florian Meier
---
- Uses
In order to find I2C devices in the device tree, the platform nodes
have to be known by the I2C core. This requires setting the
dev.of_node parameter of the adapter.
Signed-off-by: Florian Meier
---
Since the general approach is not easy enough
(see [PATCH] i2c: Fallback to of_node of parent
Add support for DMA controller of BCM2835 as used in the Raspberry Pi.
Currently it only supports cyclic DMA.
Signed-off-by: Florian Meier
---
This version includes some more style improvements
suggested in the previous thread.
.../devicetree/bindings/dma/bcm2835-dma.txt| 57
I have tested your patch.
There is a (non blocking) error message regarding .idle_bias_off, but I
assume that should not have something to do with your patch. Can we just
set idle_bias_off to false here?
Otherwise, it looks good to me.
On 01/14/2014 08:34 PM, Daniel Matuschek wrote:
> WM8804 can
bug.
Signed-off-by: Florian Meier
---
drivers/dma/bcm2835-dma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
index 6ae0708..a036021 100644
--- a/drivers/dma/bcm2835-dma.c
+++ b/drivers/dma/bcm2835-dma.c
@@ -611,6 +611,7 @@ static int
On 01/17/2014 07:33 PM, Mark Brown wrote:
> On Fri, Jan 17, 2014 at 07:06:24PM +0100, Florian Meier wrote:
>>
> Intentionally off-list?
Oh no - I am sorry!
>> If I remember correctly the error was
>> "codec can not start from non-off bias with idle_bias_off==true&q
Add support for DMA controller of BCM2835 as used in the Raspberry Pi.
Currently it only supports cyclic DMA.
Signed-off-by: Florian Meier
---
Besides of many minor improvements (thanks to your helpful comments),
this fourth version does the assignment of the virtual to the hardware
channel
On 13.11.2013 19:43, Tomasz Figa wrote:
> Hi Florian,
>
> Seems like I accidentally replied to some old version of this patch.
> Not sure how many of those comments were still relevant for V3, but
> let me look at this version and see whether we can still improve things
> a bit. Please see my comm
On 13.11.2013 21:39, Tomasz Figa wrote:
> On Wednesday 13 of November 2013 20:35:22 Florian Meier wrote:
>> On 13.11.2013 19:43, Tomasz Figa wrote:
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/dma/bcm2835-dma.txt
>>>> b/Document
2013/11/14 Tomasz Figa :
> On Thursday 14 of November 2013 08:12:46 Florian Meier wrote:
>> On 13.11.2013 21:39, Tomasz Figa wrote:
>> > On Wednesday 13 of November 2013 20:35:22 Florian Meier wrote:
>> >>>> +- brcm,dma-channel-mask: Bit mask representing the ch
2013/11/14 Tomasz Figa :
> On Thursday 14 of November 2013 15:44:05 Florian Meier wrote:
>> 2013/11/14 Tomasz Figa :
>> > On Thursday 14 of November 2013 08:12:46 Florian Meier wrote:
>> >> On 13.11.2013 21:39, Tomasz Figa wrote:
>> >> > On Wednesd
> I mean, something closer to:
> .
Ok :-)
>> >> I am becoming desperate anyway that this migration will ever fully
>> >> take place
>> >
>> > Why not? It's just a matter of people like you working on this (and
>> > addressing some review comments ;)).
>>
>> The most common comment about t
2013/11/14 Tomasz Figa :
> On Thursday 14 of November 2013 17:14:31 Florian Meier wrote:
>> >> >> I am becoming desperate anyway that this migration will ever fully
>> >> >> take place
>> >> >
>> >> > Why not? It's jus
Add support for DMA controller of BCM2835 as used in the Raspberry Pi.
Currently it only supports cyclic DMA.
Signed-off-by: Florian Meier
---
Fifth version with better error handling in probe.
.../devicetree/bindings/dma/bcm2835-dma.txt| 56 ++
drivers/dma/Kconfig
Add support for DMA controller of BCM2835 as used in the Raspberry Pi.
Currently it only supports cyclic DMA.
Signed-off-by: Florian Meier
---
Sixth version with some style improvements by Joe.
sizeof(s128) doesn't work. Therefore, still hardcoded byte counts.
.../devicetree/binding
CM2835: Linking platform nodes to adapter nodes
i2c: Fix device tree binding for i2c-cbus-gpio
Signed-off-by: Florian Meier
Suggested-by: Stephen Warren
---
drivers/i2c/i2c-core.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 4
Ok, I will try to find all relevant lines.
Where is the best place to document this?
Greetings,
Florian
2013/11/16 Wolfram Sang :
>
>> + if (!dev->of_node && dev->parent)
>> + dev->of_node = dev->parent->of_node;
>> +
>
> That is not enough. Current drivers could then have the ass
I have looked through all bus drivers and in most
cases they have a corresponding line that could be removed.
Although, this patch would break i2c-powermac, because it
relies on the fact that of_node stays NULL.
Any idea how to handle that?
Greetings,
Florian
On 16.11.2013 17:11, Florian Meier
Add support for DMA controller of BCM2835 as used in the Raspberry Pi.
Currently it only supports cyclic DMA.
Signed-off-by: Florian Meier
---
This version includes some more style improvements
suggested in the previous thread.
.../devicetree/bindings/dma/bcm2835-dma.txt| 56
On 17.11.2013 17:02, Joe Perches wrote:
> On Sun, 2013-11-17 at 16:39 +0100, Florian Meier wrote:
>> Add support for DMA controller of BCM2835 as used in the Raspberry Pi.
>> Currently it only supports cyclic DMA.
> []
>> diff --git a/drivers/dma/bcm2835-dma.c b/d
This driver adds support for digital audio (I2S)
for the BCM2835 SoC that is used by the
Raspberry Pi. External audio codecs can be
connected to the Raspberry Pi via P5 header.
It relies on cyclic DMA engine support for BCM2835.
Signed-off-by: Florian Meier
---
This successor of RFCv2 is no
Thank you! Few comments below.
> []
>> +static enum dma_status bcm2835_dma_tx_status(struct dma_chan *chan,
>> +dma_cookie_t cookie, struct dma_tx_state *txstate)
>> +{
>
> []
>
>> +} else {
>> +txstate->residue = 0;
>
> Useless assignment since dmaengine will do this for yo
Thank you!
>> diff --git a/Documentation/devicetree/bindings/sound/bcm2835-i2s.txt
>> b/Documentation/devicetree/bindings/sound/bcm2835-i2s.txt
>> new file mode 100644
>> index 000..7bf1d04
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/bcm2835-i2s.txt
>> @@ -0,0 +1,22 @@
>
+static enum dma_status bcm2835_dma_tx_status(struct dma_chan *chan,
+ dma_cookie_t cookie, struct dma_tx_state *txstate)
+{
>>>
>>> []
>>>
+ } else {
+ txstate->residue = 0;
>>>
>>> Useless assignment since dmaengine will do this for you in
>>> dma_cookie_status
>> +static int bcm2835_i2s_hw_params(struct snd_pcm_substream *substream,
>> + struct snd_pcm_hw_params *params,
>> + struct snd_soc_dai *dai)
>> +{
>> +struct bcm2835_i2s_dev *dev = snd_soc_dai_get_drvdata(dai);
>> +
>> +unsigned int
Add support for DMA controller of BCM2835 as used in the Raspberry Pi.
Currently it only supports cyclic DMA.
Signed-off-by: Florian Meier
Reviewed-by: Andy Shevchenko
---
Andy, thank you for the review!
The changes are just for the minor issues you raised.
.../devicetree/bindings/dma
On 02.01.2014 19:03, Arnd Bergmann wrote:
> On Thursday 02 January 2014 18:49:23 Florian Meier wrote:
>> Add support for DMA controller of BCM2835 as used in the Raspberry Pi.
>> Currently it only supports cyclic DMA.
>
> Looks very nice. Just a few details I noticed:
>
&
/rpi-dac.c
new file mode 100644
index 000..ef3cd93
--- /dev/null
+++ b/sound/soc/bcm/rpi-dac.c
@@ -0,0 +1,97 @@
+/*
+ * ASoC Driver for RPi-DAC.
+ *
+ * Author: Florian Meier
+ * Copyright 2013
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it
On 05.01.2014 15:06, Arnd Bergmann wrote:
> On Saturday 04 January 2014, Florian Meier wrote:
>> On 02.01.2014 19:03, Arnd Bergmann wrote:
>>> On Thursday 02 January 2014 18:49:23 Florian Meier wrote:
>>>> Add support for DMA controller of BCM2835 as used in the R
On 05.01.2014 19:52, Arnd Bergmann wrote:
> On Sunday 05 January 2014, Florian Meier wrote:
>> On 05.01.2014 15:06, Arnd Bergmann wrote:
>>>>
>>>> Sigh, the API is developing faster than I can keep track with updating
>>>> this patch. I hope some day I
Add support for DMA controller of BCM2835 as used in the Raspberry Pi.
Currently it only supports cyclic DMA.
Signed-off-by: Florian Meier
---
Merging and rebasing was easier than I feared and
I found an additional API change (DMA_SUCCESS).
Andy: I would be happy to have your Reviewed-by
Signed-off-by: Florian Meier
---
kernel/gcov/gcc_4_7.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
index e25e92f..6a5c239 100644
--- a/kernel/gcov/gcc_4_7.c
+++ b/kernel/gcov/gcc_4_7.c
@@ -18,7 +18,7 @@
#include
#include
On 30 June 2016 at 14:13, Peter Oberparleiter
wrote:
> On 29.06.2016 16:58, Florian Meier wrote:
>> Hello!
>>
>> I've noticed problems ("not executed"/ "file empty") with the gcov
>> kernel support, when I'm using a gcc version >=6.
>
Added support for gcc version >= 6 in gcov.
Signed-off-by: Florian Meier
---
kernel/gcov/gcc_4_7.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
index e25e92f..6a5c239 100644
--- a/kernel/gcov/gcc_4_7.c
+++ b/kernel/g
I'll repost it, that's the easiest fix.
On 4 July 2016 at 09:43, Peter Oberparleiter wrote:
> On 01.07.2016 18:26, Joe Perches wrote:
>> On Fri, 2016-07-01 at 15:09 +0200, Florian Meier wrote:
>>> Added support for gcc version >= 6 in gcov.
>>
>> It&
Added support for gcc version >= 6 in gcov.
Signed-off-by: Florian Meier
---
kernel/gcov/gcc_4_7.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
index e25e92f..6a5c239 100644
--- a/kernel/gcov/gcc_4_7.c
+++ b/kernel/g
-#if __GNUC__ == 5 && __GNUC_MINOR__ >= 1
+#if __GNUC__ == 6
+#define GCOV_COUNTERS 10
+#elif __GNUC__ == 5 && __GNUC_MINOR__ >= 1
#define GCOV_COUNTERS 10
#elif __GNUC__ == 4 && __GNUC_MINOR__ >= 9
#define GCOV_COUNTERS 9
Regards
Florian Meier
57 matches
Mail list logo
