On 07/27/2013 05:25 AM, Mark Brown wrote:
On Fri, Jul 26, 2013 at 04:13:40PM -0700, Felipe Tonello wrote:
On Fri, Jul 26, 2013 at 3:48 PM, Mark Brown wrote:
What I'd expect to happen here is that for multi function jacks we
create a control per function if the controls are valid.
Ok, so t
Hi Takashi,
On 07/29/2013 05:05 AM, Takashi Iwai wrote:
At Sat, 27 Jul 2013 13:25:24 +0100,
Mark Brown wrote:
On Fri, Jul 26, 2013 at 04:13:40PM -0700, Felipe Tonello wrote:
On Fri, Jul 26, 2013 at 3:48 PM, Mark Brown wrote:
What I'd expect to happen here is that for multi function jacks
Hi Takashi,
On 07/29/2013 05:10 AM, Takashi Iwai wrote:
At Fri, 26 Jul 2013 12:02:51 -0700,
Felipe Tonello wrote:
Hi Mark,
On Fri, Jul 26, 2013 at 11:56 AM, Mark Brown wrote:
On Fri, Jul 26, 2013 at 11:25:33AM -0700, Felipe F. Tonello wrote:
From: "Felipe F. Tonello"
ALSA standard jacks
On 07/29/2013 07:19 AM, Takashi Iwai wrote:
At Fri, 26 Jul 2013 15:45:11 -0700,
Felipe F. Tonello wrote:
From: "Felipe F. Tonello"
This patch adds jack support for alsa kcontrol.
This support is necessary since the new kcontrol is used by user-space
daemons, such as PulseAudio(>=2.0), to do
Hi Guennadi,
On Wednesday, May 22, 2013 10:30:40 PM Guennadi Liakhovetski wrote:
> On Wed, 22 May 2013, Felipe F. Tonello wrote:
> > From: "Felipe F. Tonello"
> >
> > This is useful for power managment purposes if a sdhci child host wants to
> > turn off some other peripheral also.
>
> Sorry, c
Hi,
On 05-08-2016 20:15, kbuild test robot wrote:
> Hi Felipe,
>
> [auto build test ERROR on balbi-usb/next]
> [also build test ERROR on v4.7 next-20160805]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
>
> url:
> https://github.com/0
Hi Robert,
On 27/10/15 06:53, Robert Baldyga wrote:
> On 10/26/2015 05:55 PM, Felipe F. Tonello wrote:
>> This function is shared between gadget functions, so this avoid unnecessary
>> duplicated code and potentially avoid memory leaks.
>>
>> Signed-off-by: Felipe F. Tonello
>> ---
>> drivers/us
Hi Robert,
On 27/10/15 06:47, Robert Baldyga wrote:
> On 10/26/2015 11:53 PM, Felipe Tonello wrote:
>> Hi Robert,
>>
>> On Mon, Oct 26, 2015 at 10:30 PM, Robert Baldyga
>> wrote:
>>> On 10/26/2015 05:55 PM, Felipe F. Tonello wrote:
This avoids duplication of USB requests for OUT endpoint and
Hi Robert,
On 27/10/15 06:41, Robert Baldyga wrote:
> On 10/26/2015 11:49 PM, Felipe Tonello wrote:
>> Hi Robert,
>>
>> On Mon, Oct 26, 2015 at 10:13 PM, Robert Baldyga
>> wrote:
>>> Hi Felipe,
>>>
>>> On 10/26/2015 05:55 PM, Felipe F. Tonello wrote:
This makes sure f_midi doesn't try to enq
Hi Peter,
Have you seen this patch? I saw that you didn't apply it to your tree,
so I wonder if it is good or do I have to change anything.
This patch is a bug fix for a memory leak, so it is quite important.
--
Felipe
On 18/09/15 18:30, e...@felipetonello.com wrote:
> From: "Felipe F. Tonello
Hi Dmitry,
On 12/15/2013 02:40 AM, Dmitry Torokhov wrote:
Hi Felipe,
On Tue, Dec 10, 2013 at 04:03:16PM -0800, Felipe F. Tonello wrote:
From: "Felipe F. Tonello"
This is useful to report for users of this device that don't know anything
about the suspension of the device. So users will recei
Hi Dmitry and Henrik,
On 01/01/2014 11:18 AM, Dmitry Torokhov wrote:
On Wed, Jan 01, 2014 at 05:19:10PM +0100, Henrik Rydberg wrote:
Hi Dmitry,
What problematic scenario is this supposed to solve?
The 'release on suspend' is only an approximation to the 'close
laptop' scenario, it is certain
Hi Balbi,
On 16/12/15 16:03, Felipe Balbi wrote:
>
> Hi
>
> Felipe Ferreri Tonello writes:
>> Hi all,
>>
>> On 01/12/15 18:30, Felipe F. Tonello wrote:
>>> Fixed all comments suggested by the linux-usb list.
>>>
>>> changes in v
Hi Robert,
On 11/12/15 11:24, Robert Baldyga wrote:
> It seems that gitotious repository is no longer accessible, so we replace
> it with address to active repository.
>
> Signed-off-by: Robert Baldyga
> ---
> Documentation/usb/gadget-testing.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 dele
Hi Clemens
On 27/11/15 09:05, Clemens Ladisch wrote:
> Felipe Ferreri Tonello wrote:
>> On 13/11/15 08:55, Clemens Ladisch wrote:
>>> Felipe F. Tonello wrote:
>>>> +static void f_midi_transmit(struct f_midi *midi)
>>>> +{
>>>> +...
>
Hi Robert,
On 16/11/15 11:43, Robert Baldyga wrote:
> On 11/16/2015 12:08 PM, Felipe Ferreri Tonello wrote:
>> Hi Robert,
>>
>> On 13/11/15 08:31, Robert Baldyga wrote:
>>> Hi Felipe,
>>>
>>> On 11/10/2015 06:52 PM, Felipe F. Tonello wrote:
>>
Hi Robert,
On 13/11/15 12:38, Robert Baldyga wrote:
> Hi Felipe,
>
> On 11/10/2015 06:52 PM, Felipe F. Tonello wrote:
>> This patch introduces pre-allocation of IN endpoint USB requests. This
>> improves on latency (requires no usb request allocation on transmit) and
>> avoid
>> several potentia
Hi Clemens
On 13/11/15 08:55, Clemens Ladisch wrote:
> Felipe F. Tonello wrote:
>> This patch introduces pre-allocation of IN endpoint USB requests. This
>> improves on latency (requires no usb request allocation on transmit) and
>> avoid
>> several potential probles on allocating too many usb re
On 01/12/15 18:31, Felipe F. Tonello wrote:
> This patch introduces pre-allocation of IN endpoint USB requests. This
> improves on latency (requires no usb request allocation on transmit) and avoid
> several potential probles on allocating too many usb requests (which involves
> DMA pool allocation
Hi Robert,
On 27/10/15 09:47, Robert Baldyga wrote:
> On 10/27/2015 10:18 AM, Felipe Ferreri Tonello wrote:
>> Hi Robert,
>>
>> On 27/10/15 06:53, Robert Baldyga wrote:
>>> On 10/26/2015 05:55 PM, Felipe F. Tonello wrote:
>>>> This function is shar
Hi Balbi,
On 26/10/15 16:55, Felipe F. Tonello wrote:
> Patch 7 has changes on how to transmit IN USB requests. It implements a FIFO
> of pre-allocated usb requests and uses then as needed, instead of allocating
> then on demand. This is my initial implementation and is open for
> suggestions and
Hi,
On 08/03/16 14:20, Felipe Balbi wrote:
>
> Hi,
>
> Krzysztof Opasiak writes:
>> [ text/plain ]
>>
>>
>> On 03/08/2016 02:54 PM, Felipe Ferreri Tonello wrote:
>> (...)
>>
>>>>
>>>>> sort of preset library of config
Hi Balbi,
On 08/03/16 14:01, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>>>>>>>> Since f_midi_transmit is called by both ALSA and USB frameworks, it
>>>>>>> can
>>>>>>>> potentially cause
Hi,
On 09/03/16 16:17, Felipe F. Tonello wrote:
> Since f_midi_transmit is called by both ALSA and USB sub-systems, it can
> potentially cause a race condition between both calls because f_midi_transmit
> is not reentrant nor thread-safe. This is due to an implementation detail that
> the transmit
Hi Steve,
On 09/03/16 22:43, Steve Calfee wrote:
> On Wed, Mar 9, 2016 at 11:39 AM, Felipe F. Tonello
> wrote:
>> buflen by default (256) is smaller than wMaxPacketSize (512) in high-speed
>> devices.
>>
>> That caused the OUT endpoint to freeze if the host send any data packet of
>> length grea
Hi Balbi and Mina,
On 30/03/16 13:33, Michal Nazarewicz wrote:
> On Wed, Mar 30 2016, Felipe Balbi wrote:
>> a USB packet, right. that's correct. But a struct usb_request can
>> point to whatever size buffer it wants and UDC is required to split
>> that into wMaxPacketSize transfers.
>
> D’oh. O
Hi Balbi,
On 01/04/16 11:22, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>> Hi Balbi and Mina,
>>
>> On 30/03/16 13:33, Michal Nazarewicz wrote:
>>> On Wed, Mar 30 2016, Felipe Balbi wrote:
>>>> a USB packet, right. that&#x
Hi Balbi,
On 04/04/16 11:46, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>>>> On 30/03/16 13:33, Michal Nazarewicz wrote:
>>>>> On Wed, Mar 30 2016, Felipe Balbi wrote:
>>>>>> a USB packet, right. that's corre
Hi Sergei,
On 10/11/15 18:43, Sergei Shtylyov wrote:
> Hello.
>
> On 11/10/2015 08:52 PM, Felipe F. Tonello wrote:
>
>> This avoids duplication of USB requests for OUT endpoint and
>> re-enabling endpoints.
>>
>> Signed-off-by: Felipe F. Tonello
>> ---
>> drivers/usb/gadget/function/f_midi.c
Hi Robert,
On 13/11/15 08:31, Robert Baldyga wrote:
> Hi Felipe,
>
> On 11/10/2015 06:52 PM, Felipe F. Tonello wrote:
>> This patch fixes a memory leak that occurs when an endpoint fails to enqueue
>> the request. If that happens the complete function will never be called, thus
>> never freeing t
Hi Clemens,
On 13/11/15 08:11, Clemens Ladisch wrote:
> Felipe Ferreri Tonello wrote:
>> On 10/11/15 18:43, Sergei Shtylyov wrote:
>>> On 11/10/2015 08:52 PM, Felipe F. Tonello wrote:
>>>> @@ -75,6 +75,7 @@ struct f_midi {
>>>> struct usb_ep
Hi Robert,
On 03/11/15 12:53, Robert Baldyga wrote:
> USB requests in Loopback function are allocated in loopback_get_alt()
> function, so we prefer to free them rather in loopback_disable() than
> in loopback_complete() when request is completed with error. It provides
> better symetry in resourc
Hi Baolin,
Sorry for not replying for previous emails because for some reason these
emails were archived. :(
On 12/07/16 10:01, Baolin Wang wrote:
> Some gadget device (such as dwc3 gadget) requires quirk_ep_out_aligned_size
> attribute, which means it need to align the request buffer's size to a
Forgot to mention, but changes from v1 is a typo alloc_ep_req().
On 26/07/16 20:18, Felipe F. Tonello wrote:
> This parameter was not really necessary and gadget drivers would almost always
> create an inline function to pass the same value to len and default_len.
>
> So this patch also removes d
Hi Balbi,
On 10/08/16 12:25, Felipe Balbi wrote:
>
> Hi,
>
> "Felipe F. Tonello" writes:
>> 512 is the value used by wMaxPacketSize, as specified by the USB Spec. This
>
> this is only true for HS :-) FS and SS use different sizes. Do you want
> to use 1024 (SS maxp) by default instead? Then a
Hi Balbi,
On 10/08/16 12:24, Felipe Balbi wrote:
>
> Hi,
>
> Baolin Wang writes:
>> On 26 July 2016 at 07:15, Felipe F. Tonello wrote:
>>> USB spec specifies wMaxPacketSize to be little endian (as other properties),
>>> so when using this variable in the driver we should convert to the current
Hi Michal,
On 27/07/16 20:37, Michal Nazarewicz wrote:
> On Tue, Jul 26 2016, Felipe F. Tonello wrote:
>> USB spec specifies wMaxPacketSize to be little endian (as other properties),
>> so when using this variable in the driver we should convert to the current
>> CPU endianness if necessary.
>>
>>
Hi Michal,
On 27/07/16 21:02, Michal Nazarewicz wrote:
> On Tue, Jul 26 2016, Felipe F. Tonello wrote:
>> This parameter was not really necessary and gadget drivers would almost
>> always
>
> I personally like when commit messages can be read without subject, so
> perhaps:
>
> The default
Hi Michal,
On 27/07/16 20:59, Michal Nazarewicz wrote:
> On Tue, Jul 26 2016, Felipe F. Tonello wrote:
>> Using usb_ep_align() makes sure that the buffer size for OUT endpoints is
>> always aligned with wMaxPacketSize (512 usually). This makes sure
>> that no buffer has the wrong size, which can c
On 29/08/16 08:55, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>>> Felipe Ferreri Tonello writes:
>>>>> "Felipe F. Tonello" writes:
>>>>>> The default_length parameter of alloc_ep_req was not really necessar
Hi Michal,
On 11/03/16 23:07, Michal Nazarewicz wrote:
> On Wed, Mar 09 2016, Felipe F. Tonello wrote:
>> buflen by default (256) is smaller than wMaxPacketSize (512) in high-speed
>> devices.
>>
>> That caused the OUT endpoint to freeze if the host send any data packet of
>> length greater than 2
Hi Clemens,
On 02/03/16 21:09, Clemens Ladisch wrote:
> Felipe F. Tonello wrote:
>> This refactor results in a cleaner state machine code
>
> It increases the number of states, and now juggles two state variables.
> I cannot agree to it being cleaner.
Yes, it increases the number of states. That
Hi Clemens,
On 03/03/16 11:38, Clemens Ladisch wrote:
> Felipe Ferreri Tonello wrote:
>> On 02/03/16 21:09, Clemens Ladisch wrote:
>>> Felipe F. Tonello wrote:
>>>> This refactor results in a cleaner state machine code
>>>
>>> It increases the numbe
Hi Clemens,
On March 4, 2016 8:07:40 AM GMT+00:00, Clemens Ladisch
wrote:
>Felipe Ferreri Tonello wrote:
>> On 03/03/16 11:38, Clemens Ladisch wrote:
>>> But in what way was the old state machine not "proper"?
>>
>> Because it didn't reflect al
Hi Balbi,
On March 4, 2016 7:13:05 AM GMT+00:00, Felipe Balbi wrote:
>"Felipe F. Tonello" writes:
>> [ text/plain ]
>> Signed-off-by: Felipe F. Tonello
>
>no commit log == no commit
Got it.
>
>> ---
>> drivers/usb/gadget/function/f_midi.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> d
Hi Balbi,
On March 4, 2016 7:11:30 AM GMT+00:00, Felipe Balbi wrote:
>
>Hi,
>
>"Felipe F. Tonello" writes:
>> [ text/plain ]
>> Patches are pretty much self-described.
>>
>> Patch 1 is revised from comments.
>
>you really need to describe what you changed. This also should have v2
>on subject l
Hi Balbi,
On March 4, 2016 7:16:42 AM GMT+00:00, Felipe Balbi wrote:
>
>Hi,
>
>"Felipe F. Tonello" writes:
>> [ text/plain ]
>> This gadget uses a bmAttributes and MaxPower that requires the USB
>bus to be
>> powered from the host, which is not correct because this
>configuration is device
>> s
Hi Balbi,
On March 4, 2016 7:20:10 AM GMT+00:00, Felipe Balbi wrote:
>
>Hi,
>
>"Felipe F. Tonello" writes:
>> [ text/plain ]
>> Since f_midi_transmit is called by both ALSA and USB frameworks, it
>can
>> potentially cause a race condition between both calls. This is bad
>because the
>> way f_mi
Hi Michal,
On March 4, 2016 7:17:31 PM GMT+00:00, Michal Nazarewicz
wrote:
>On Wed, Mar 02 2016, Felipe F. Tonello wrote:
>> Signed-off-by: Felipe F. Tonello
>> ---
>> drivers/usb/gadget/function/f_midi.c | 77
>+++-
>> 1 file changed, 40 insertions(+), 37 dele
mtronics Pty Ltd.
>> >>> * Ben Williamson
>> >>> *
>> >>> - * Licensed under the GPL-2 or later.
>> >>> + * Licensed under the GPLv2.
>>
>> > On March 4, 2016 7:17:31 PM GMT+00:00, Michal Nazarewicz
> wrote:
>> >
t;>> *
>>>> - * Licensed under the GPL-2 or later.
>>>> + * Licensed under the GPLv2.
>
>> On March 4, 2016 7:17:31 PM GMT+00:00, Michal Nazarewicz
> wrote:
>>> Any particular reason to do that?
>
>On Fri, Mar 04 2016, Felipe Ferreri Tonello wrote:
>>
Hi Balbi,
On 07/03/16 07:36, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>> [ text/plain ]
>> Hi Balbi,
>>
>> On March 4, 2016 7:13:05 AM GMT+00:00, Felipe Balbi wrote:
>>> "Felipe F. Tonello" writes:
>>>&g
Hi Balbi,
On 07/03/16 07:32, Felipe Balbi wrote:
>
> Hi,
>
> (please break your lines at 80-characters, have a look at
> Documentation/email-clients.txt if needed)
>
> Felipe Ferreri Tonello writes:
>> [ text/plain ]
>> Hi Balbi,
>>
>> On Mar
Hi Balbi,
On 07/03/16 07:35, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>> [ text/plain ]
>> Hi Michal,
>>
>> On March 5, 2016 4:28:45 PM GMT+00:00, Michal Nazarewicz
>> wrote:
>>>>> On Wed, Ma
Hi Balbi,
On 07/03/16 07:34, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>> [ text/plain ]
>> Hi Balbi,
>>
>> On March 4, 2016 7:16:42 AM GMT+00:00, Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>>>
Hi Balbi, how are you?
On 07/03/16 10:59, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>>>>> "Felipe F. Tonello" writes:
>>>>>> [ text/plain ]
>>>>>> This gadget uses a bmAttributes and MaxPower that re
Hi Balbi,
On 08/03/16 07:37, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>>>>>> Since f_midi_transmit is called by both ALSA and USB frameworks, it
>>>>> can
>>>>>> potentially cause a race conditi
Hi Balbi,
On 08/03/16 07:43, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>>>>>>>> @@ -63,6 +63,14 @@ static unsigned int out_ports = 1;
>>>>>>>> module_param(out_ports, uint, S_IRUGO);
>&g
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Hi Balbi,
On 22/12/15 17:49, Felipe Balbi wrote:
>
> Hi,
>
> "Felipe F. Tonello" writes:
>> This refactor includes the following: * Cleaner state machine
>> code; * Reset state if MIDI message parsed is non-conformant; *
>> Fixed bug when a confo
Hi Clemens,
On 22/12/15 17:10, Clemens Ladisch wrote:
> Felipe F. Tonello wrote:
>> This refactor includes the following:
>> * Cleaner state machine code;
>
> It does not correctly handle system real time messages inserted between
> the status and data bytes of other messages.
True, thanks for
Hi Nicolin,
On 29/01/16 18:02, Nicolin Chen wrote:
> On Fri, Jan 29, 2016 at 11:01:01AM +, Felipe F. Tonello wrote:
>> Signed-off-by: Felipe F. Tonello
>> ---
>> Documentation/devicetree/bindings/sound/fsl-asoc-card.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --gi
Hi all,
On 01/12/15 18:30, Felipe F. Tonello wrote:
> Fixed all comments suggested by the linux-usb list.
>
> changes in v6:
> - Removed patches already applied in Balbi's tree
> - Cleanups on pre-allocation usb requrests patch
> - Fixed indentention on patch 1
> - Added patch which fails set
Hi Nicolin,
On 28/01/16 18:24, Nicolin Chen wrote:
> On Thu, Jan 28, 2016 at 10:52:35AM +, Felipe F. Tonello wrote:
>> add cs4271 and cs42727 support for fsl-asoc-card
>>
>> Signed-off-by: Felipe F. Tonello
>> ---
>> .../devicetree/bindings/sound/imx-audio-cs427x.txt | 47
>> +++
Hi Rob,
On 26/01/16 02:29, Rob Herring wrote:
> On Mon, Jan 25, 2016 at 05:53:23PM +, Felipe F. Tonello wrote:
>> This is the initial imx-cs427x device-tree-only machine driver working with
>> fsl_ssi driver. More features can be added on top of it later.
>>
>> Signed-off-by: Felipe F. Tonello
Hi Fabio,
On 26/01/16 09:47, Fabio Estevam wrote:
> Hi Felipe,
>
> On Tue, Jan 26, 2016 at 7:43 AM, Felipe Ferreri Tonello
> wrote:
>
>> I agree, but that how it is today. These platform drivers for imx are
>> similar but not identical. Looking at them I would guess
Hi Michal,
On 26/01/16 14:53, Michal Nazarewicz wrote:
> Resending my previous two sets for f_fs and f_midi. This time rebased
> on top of Felipe’s next branch.
>
> Dan Carpenter (1):
> usb: gadget: f_midi: missing unlock on error path
>
> Du, Changbin (1):
> usb: f_fs: avoid race condition
Hi Blabi,
On 18/08/16 08:12, Felipe Balbi wrote:
>
> Hi,
>
> "Felipe F. Tonello" writes:
>> The default_length parameter of alloc_ep_req was not really necessary
>> and gadget drivers would almost always create an inline function to pass
>> the same value to len and default_len.
>>
>> So this p
Hi,
On 22/08/16 08:45, Felipe Balbi wrote:
>
> Hi,
>
> John Youn writes:
>> On 8/8/2016 1:30 PM, Felipe F. Tonello wrote:
>>> Use gadget's framework allocation function instead of directly calling
>>> usb_ep_alloc_request().
>>>
>>> Signed-off-by: Felipe F. Tonello
>>> ---
>>> drivers/usb/gad
Hi Balbi,
On 23/08/16 12:03, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>>> John Youn writes:
>>>> On 8/8/2016 1:30 PM, Felipe F. Tonello wrote:
>>>>> Use gadget's framework allocation function instead of directly cal
Hi Balbi,
On 23/08/16 12:01, Felipe Balbi wrote:
>
> Hi,
>
> Felipe Ferreri Tonello writes:
>>> "Felipe F. Tonello" writes:
>>>> The default_length parameter of alloc_ep_req was not really necessary
>>>> and gadget drivers would almost
70 matches
Mail list logo
