Re: PREEMPT_RT with e1000

2005-09-01 Thread Daniel Walker
On Thu, 2005-09-01 at 09:10 +0200, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > It looks like Gigabit Ethernet is still having some problems. This is > > with the e1000 driver. If I remove all the qdisc_restart changes it > > starts to wo

Re: PREEMPT_RT with e1000

2005-09-01 Thread Daniel Walker
On Thu, 2005-09-01 at 07:43 -0700, Daniel Walker wrote: > On Thu, 2005-09-01 at 09:10 +0200, Ingo Molnar wrote: > > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > > > It looks like Gigabit Ethernet is still having some problems. This is > > > wit

Re: FW: [RFC] A more general timeout specification

2005-09-01 Thread Daniel Walker
On Thu, 2005-09-01 at 16:32 +0200, Roman Zippel wrote: > Hi, > > On Thu, 1 Sep 2005, Joe Korty wrote: > > > > When you convert a user time to kernel time you can > > > automatically validate > > > > Kernel time sucks. It is just a single clock, it may not have > > the attributes of the clock th

Re: FW: [RFC] A more general timeout specification

2005-09-01 Thread Daniel Walker
On Thu, 2005-09-01 at 16:32 +0200, Roman Zippel wrote: > Hi, > > On Thu, 1 Sep 2005, Joe Korty wrote: > > > > When you convert a user time to kernel time you can > > > automatically validate > > > > Kernel time sucks. It is just a single clock, it may not have > > the attributes of the clock th

[PATCH 2.6.13] Warning in the e1000 driver

2005-09-01 Thread Daniel Walker
This should fix a small warning in the e1000 driver. It casts to the largest possible type dma field. This was found while compiling for X86_64 . Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> Index: linux-2.6.13/drivers/net/e1000/e1000_

[PATCH 2.6.13] Unhandled error condition in aic7xxx

2005-09-01 Thread Daniel Walker
This patch should handle the case when scsi_add_host() fails. Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> Index: linux-2.6.13/drivers/scsi/aic7xxx/aic7xxx_osm.c === --- linux-2.6.13.orig/drivers/scsi/aic7xxx/aic7xxx

[PATCH 2.6.13] Unhandled error condition in aic79xx

2005-09-01 Thread Daniel Walker
This patch should handle the case when scsi_add_host() fails. Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> Index: linux-2.6.13/drivers/scsi/aic7xxx/aic79xx_osm.c === --- linux-2.6.13.orig/drivers/scsi/aic7xxx/aic79xx

Re: [PATCH 2.6.13] Unhandled error condition in aic79xx

2005-09-01 Thread Daniel Walker
On Fri, 2005-09-02 at 00:10 +0400, Alexey Dobriyan wrote: > I see malloc(), kernel_thread() and multiple ahd_linux_alloc_target() > above. Ditto for 7xxx patch. > True, no wonder this condition hasn't been handled yet.. Daniel - To unsubscribe from this list: send the line "unsubscribe linux-k

[PATCH 2.6.13] Warning in the qla2xxx driver

2005-09-01 Thread Daniel Walker
Remove possible uninitialized "sg" field warning in the qla24xx driver Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> Index: linux-2.6.13/drivers/scsi/qla2xxx/qla_iocb.c === --- linux-2.6.13.orig/drivers/scsi/ql

Re: [PATCH 2.6.13] Unhandled error condition in aic79xx

2005-09-01 Thread Daniel Walker
On Fri, 2005-09-02 at 00:10 +0400, Alexey Dobriyan wrote: > I see malloc(), kernel_thread() and multiple ahd_linux_alloc_target() > above. Ditto for 7xxx patch. It looks like it's all handled inside ahd_free() . Here's the updated patch. Any concerns? Signed-Off-By: Danie

[PATCH] RT: trace_irqs_on in raw_local_irq_restore

2005-09-02 Thread Daniel Walker
Add trace_irqs_on() to raw_local_irq_restore() . Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> Index: linux-2.6.13/include/linux/rt_irq.h === --- linux-2.6.13.orig/include/linux/rt_irq.h2005-09-01 21:25:53.000

[PATCH] RT: Add raw_irqs_disabled to might_sleep

2005-09-02 Thread Daniel Walker
Add in raw_irqs_disabled() into the might sleep check. Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> Index: linux-2.6.13/kernel/sched.c === --- linux-2.6.13.orig/kernel/sched.c2005-09-02 23:42:18.0

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Daniel Walker
On Thu, 2008-01-03 at 02:16 -0500, Steven Rostedt wrote: > Index: linux-compile.git/Makefile > === > --- linux-compile.git.orig/Makefile 2008-01-03 01:02:28.0 -0500 > +++ linux-compile.git/Makefile 2008-01-03 01:02:39.000

Re: [PATCH] Deprecate checkpatch.pl --file

2008-01-08 Thread Daniel Walker
On Tue, 2008-01-08 at 17:14 +0100, Andi Kleen wrote: > +if ($file) { > + print < +WARNING: Using --file mode. Please do not send patches to linux-kernel > +that change whole existing files if you did not significantly change most > +of the the file for other reasons anyways or just wrote the

Re: [PATCH] Deprecate checkpatch.pl --file

2008-01-08 Thread Daniel Walker
On Tue, 2008-01-08 at 18:53 +0100, Sam Ravnborg wrote: > On Tue, Jan 08, 2008 at 08:50:33AM -0800, Daniel Walker wrote: > > > > On Tue, 2008-01-08 at 17:14 +0100, Andi Kleen wrote: > > > > > > > +if ($file) { > > > + print < > > +WARNING:

Re: [PATCH] Deprecate checkpatch.pl --file

2008-01-08 Thread Daniel Walker
On Tue, 2008-01-08 at 13:20 -0500, Theodore Tso wrote: > On Tue, Jan 08, 2008 at 10:01:19AM -0800, Daniel Walker wrote: > > > It is a simple pain/benefit issue. > > > Fixing the 25 errors and 13 warnings in kernel/profile.c may look > > > like an easy task but then w

Re: [PATCH] Deprecate checkpatch.pl --file

2008-01-08 Thread Daniel Walker
On Tue, 2008-01-08 at 20:21 +0100, Sam Ravnborg wrote: > But is discourage the creation of pure clean-up patches because it > may have a disturbing effect on several other peoples work. pure clean ups are _good_ patches , are they not? Daniel -- To unsubscribe from this list: send the line "un

Re: [PATCH] Deprecate checkpatch.pl --file

2008-01-08 Thread Daniel Walker
On Tue, 2008-01-08 at 16:14 -0500, Theodore Tso wrote: > On Tue, Jan 08, 2008 at 12:19:44PM -0800, Daniel Walker wrote: > > > But is discourage the creation of pure clean-up patches because it > > > may have a disturbing effect on several other peoples work. > > &g

Re: [RFC PATCH 16/22 -v2] add get_monotonic_cycles

2008-01-09 Thread Daniel Walker
On Wed, 2008-01-09 at 18:29 -0500, Steven Rostedt wrote: > +cycle_t notrace get_monotonic_cycles(void) > +{ > + cycle_t cycle_now, cycle_delta, cycle_raw, cycle_last; > + > + do { > + /* > +* cycle_raw and cycle_last can change on > +* anot

Re: [RFC PATCH 20/22 -v2] Add latency_trace format tor tracer

2008-01-09 Thread Daniel Walker
On Wed, 2008-01-09 at 18:29 -0500, Steven Rostedt wrote: > +enum trace_flag_type { > + TRACE_FLAG_IRQS_OFF = 0x01, > + TRACE_FLAG_NEED_RESCHED = 0x02, > + TRACE_FLAG_NEED_RESCHED_DELAYED = 0x04, > + TRACE_FLAG_HARDIRQ = 0x08, > + TRACE

Re: [RFC PATCH 22/22 -v2] Trace irq disabled critical timings

2008-01-09 Thread Daniel Walker
On Wed, 2008-01-09 at 18:29 -0500, Steven Rostedt wrote: > + /* Don't trace irqs off for idle */ > + stop_critical_timings(); > idle(); > + start_critical_timings(); Is there another way to hook into the id

[x86] list of style offenders

2008-01-10 Thread Daniel Walker
I was playing with checkpatch.pl ;) .. I made a list of style offenders inside the arch/x86/ sub-directory. I thought it might be helpful to prioritize any style clean ups that people might want to do for x86 .. OTOH some of these might show imperfections in checkpatch.pl .. Either way I thought

Re: [x86] list of style offenders

2008-01-10 Thread Daniel Walker
On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote: > On Jan 10, 2008 9:03 PM, Daniel Walker <[EMAIL PROTECTED]> wrote: > > > > > > I was playing with checkpatch.pl ;) .. I made a list of style offenders > > inside the arch/x86/ sub-directory.

Re: [x86] list of style offenders

2008-01-10 Thread Daniel Walker
On Thu, 2008-01-10 at 23:47 +0100, Paolo Ciarrocchi wrote: > On Jan 10, 2008 11:41 PM, Daniel Walker <[EMAIL PROTECTED]> wrote: > > > > On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote: > > > On Jan 10, 2008 9:03 PM, Daniel Walker <[EMAIL PROTECTED]>

Re: [x86] list of style offenders

2008-01-10 Thread Daniel Walker
On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote: > On Jan 10, 2008 9:03 PM, Daniel Walker <[EMAIL PROTECTED]> wrote: > > > > > > I was playing with checkpatch.pl ;) .. I made a list of style offenders > > inside the arch/x86/ sub-directory.

Re: [x86] list of style offenders

2008-01-10 Thread Daniel Walker
On Fri, 2008-01-11 at 00:40 +0100, Paolo Ciarrocchi wrote: > On Jan 11, 2008 12:08 AM, Daniel Walker <[EMAIL PROTECTED]> wrote: > > > The git logs also show that arch/x86/math-emu/fpu_trig.c hasn't been > > modified since it was pull in on Oct. 11 .. > > D

Re: [x86] list of style offenders

2008-01-10 Thread Daniel Walker
On Fri, 2008-01-11 at 00:40 +0100, Paolo Ciarrocchi wrote: > On Jan 11, 2008 12:08 AM, Daniel Walker <[EMAIL PROTECTED]> wrote: > > > The git logs also show that arch/x86/math-emu/fpu_trig.c hasn't been > > modified since it was pull in on Oct. 11 .. > > D

Re: [PATCH 3/3] printer port driver: semaphore to mutex

2007-12-06 Thread Daniel Walker
On Thu, 2007-12-06 at 21:01 +0100, Remy Bohmer wrote: > Daniel, > > FYI: I am working on the conversion of the 2 sem->mutex in kernel/printk.c I looked at the console_sem , but i was going to leave that as last.. The problem with the console_sem is that it can get locked from interrupt context,

Re: [PATCH 3/3] printer port driver: semaphore to mutex

2007-12-06 Thread Daniel Walker
On Thu, 2007-12-06 at 21:12 +0100, Remy Bohmer wrote: > Hello Matthias, > > Which do you have exactly on your list? (good to know, it prevents > double work...) Here's my list so far (in no particular order).. Most aren't tested fully yet.. I'll try to post them someplace eventually (later today

Re: Possible locking issue in viotape.c

2007-12-06 Thread Daniel Walker
On Thu, 2007-12-06 at 21:29 -0400, Kevin Winchester wrote: > Daniel Walker wrote: > > > > I've posted all the ones I've done so far .. > > > > ftp://source.mvista.com/pub/dwalker/sem2mutex-2.6.24-rc4/ > > > > Feel free to review or test them..

Re: [PATCH 3/3] printer port driver: semaphore to mutex

2007-12-06 Thread Daniel Walker
On Thu, 2007-12-06 at 19:30 -0400, Kevin Winchester wrote: > Daniel Walker wrote: > > On Thu, 2007-12-06 at 11:23 +0100, Ingo Molnar wrote: > >> * Daniel Walker <[EMAIL PROTECTED]> wrote: > >> > >>> The port_mutex is actually a semaphore,

[PATCH 4/4] md: dm driver: suspend_lock semaphore to mutex

2007-12-07 Thread Daniel Walker
Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- drivers/md/dm.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) Index: linux-2.6.23/drivers/md/dm.c === --- linux-2.6.23.orig/drivers/md/dm.c +++

[PATCH 1/4] media: video: usbvision: remove ctrlUrbLock

2007-12-07 Thread Daniel Walker
The ctrlUrbLock has all it's users commented out, and so it's unused. This patch removes it. Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- drivers/media/video/usbvision/usbvision-core.c |3 --- drivers/media/video/usbvision/usbvision-video.c |1 - drivers/media

[PATCH 2/4] docs: kernel-locking: Convert semaphore references

2007-12-07 Thread Daniel Walker
I converted some of the document to reflect mutex usage instead of semaphore usage. Since we shouldin't be promoting semaphore usage when it's on it's way out.. Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> --- Documentation/DocBook/kerne

[PATCH 3/4] mcheck mce_64: mce_read_sem to mutex

2007-12-07 Thread Daniel Walker
Converted to a mutex, and changed the name to mce_read_mutex. Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/mcheck/mce_64.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: linux-2.6.23/arch/x86/kernel/cpu/mcheck/mc

Re: lockdep problem conversion semaphore->mutex (dev->sem)

2007-12-08 Thread Daniel Walker
On Sat, 2007-12-08 at 13:16 +0100, Peter Zijlstra wrote: > On Sat, 2007-12-08 at 00:02 +0100, Remy Bohmer wrote: > > Hello Peter, > > > > > > What specifically is wrong with dev->sem ? > > > > > > Nothing really, other than that they use semaphores to avoid lockdep :-/ > > > > > > I think I know h

Re: lockdep problem conversion semaphore->mutex (dev->sem)

2007-12-08 Thread Daniel Walker
On Sat, 2007-12-08 at 18:11 +0100, Peter Zijlstra wrote: > > It must be the locking in __driver_attach(), taking dev->parent->sem > > then taking dev->sem .. Assuming those are different structures, why > > does lockdep trigger? > > They aren't different, parent is a struct device again. It's di

Re: Possible locking issue in viotape.c

2007-12-08 Thread Daniel Walker
On Sat, 2007-12-08 at 14:17 -0400, Kevin Winchester wrote: > Daniel Walker wrote: > > On Thu, 2007-12-06 at 21:29 -0400, Kevin Winchester wrote: > >> Daniel Walker wrote: > >>> I've posted all the ones I've done so far .. > >>> > >&

Re: Possible locking issue in viotape.c

2007-12-08 Thread Daniel Walker
On Sat, 2007-12-08 at 15:19 -0400, Kevin Winchester wrote: > > Yes, I've used quilt for working with mm patches in the past, but I'm > not too familiar with the mail features. For example, how do you get > the recipient list and Signed-off-by in the patch file? Do you just > edit it by hand? O

[PATCH -mm] media: video: usbvision: add mutex_unlock() to error paths

2007-12-11 Thread Daniel Walker
There are a few error paths which don't unlock the usbvision->lock. So I've added mutex_unlock() calls to fix those paths. Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- drivers/media/video/usbvision/usbvision-video.c |2 ++ 1 file changed, 2 insertions(+)

[PATCH -rt] preempt_max_latency to microseconds

2007-12-12 Thread Daniel Walker
Not to long ago preempt_max_latency was microseconds, and someplace along the way it turned into cycles. That's a bit unintuitive, so I converted it back to microseconds. Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> --- include/linux/clocksource.h | 12 +

[PATCH -rt] Add wakeup timing to expose /proc/preempt_max_latency

2007-12-12 Thread Daniel Walker
Fix my original mistake of using CONFIG_CRITICAL_TIMING , which only covers preempt and irqs-off timing.. Convert to CONFIG_LATENCY_TIMING, so wakeup timing also has these. Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> --- kernel/sysctl.c |2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH -rt] cycles_to_usecs rounding fix

2007-12-12 Thread Daniel Walker
do_div() rounds down, so we add have the divisor to round up. This effected my change to preempt_max_latency. Each time you read preempt_max_latency it gets rounded lower. Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- kernel/time/timekeeping.c |3 ++- 1 file changed, 2 inse

[PATCH 1/3] ps3: vuart: fix error path locking

2007-12-12 Thread Daniel Walker
This stray down would cause a permanent sleep which doesn't seem correct. The other uses of this semaphore appear fairly mutex like it's even initialized with init_MUTEX() .. So here a patch for removing this one down(). Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> ---

[PATCH 2/3] driver base: memory: semaphore to mutex

2007-12-12 Thread Daniel Walker
Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- drivers/base/memory.c |7 --- include/linux/memory.h |5 ++--- 2 files changed, 6 insertions(+), 6 deletions(-) Index: linux-2.6.23/drivers/base/me

[PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-12 Thread Daniel Walker
Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> --- drivers/net/wireless/bcm43xx/bcm43xx_debugfs.c | 30 - 1 file changed, 15 insertions(+), 15 deletions(-) Index: linux-2.6.23/drivers/net/wireless/bcm43xx/bcm43xx_deb

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-12 Thread Daniel Walker
On Thu, 2007-12-13 at 01:48 +0100, Michael Buesch wrote: > On Wednesday 12 December 2007 09:00:03 Daniel Walker wrote: > > > > Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> > > > > --- > > drivers/net/wireless/bcm43xx/bcm43xx_debugfs.c | 30 &g

Re: 2.6.24-rc8-rt1: Strange latencies on mpc5200 powerpc

2008-01-23 Thread Daniel Walker
On Wed, 2008-01-23 at 15:53 +0100, Luotao Fu wrote: > I was doing some tests on my mpc5200b Board to reproduce the high latency as > measured by wolfgang. > > I ran some tests with > while [ 1 ]; do ls /bin;done > as non-rt workload, as in Wolfgangs Scenario. > Can you try enabling CRITICAL_P

Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interrupts disabled

2008-01-23 Thread Daniel Walker
On Wed, 2008-01-23 at 11:02 -0500, Steven Rostedt wrote: > + if (!irqs_disabled() && wake_klogd) > wake_up_klogd(); This causes a regression .. When printk is called during an OOPS in kernels without this change then the OOPS will get logged, since the logging process (klogd) i

Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interrupts disabled

2008-01-23 Thread Daniel Walker
> if (wake_klogd && !runqueue_is_locked()) > wake_up_klogd(); > > This probably is the cleanest solution since it simply prevents the > deadlock from occurring. Do you really need to call it with the runqueue lock held .. There are other issue with the calls at that level.. F

Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interrupts disabled

2008-01-23 Thread Daniel Walker
On Wed, 2008-01-23 at 13:18 -0500, Steven Rostedt wrote: > The wakeup hook in schedule is when we find out that we hit our max. I > could postpone that somehow, but that would require more glue code than I > would like to add. Which hook specifically ? > As for -rt, we've disabled printk for co

Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interrupts disabled

2008-01-23 Thread Daniel Walker
On Wed, 2008-01-23 at 13:43 -0500, Steven Rostedt wrote: > On Wed, 23 Jan 2008, Daniel Walker wrote: > > > > > On Wed, 2008-01-23 at 13:18 -0500, Steven Rostedt wrote: > > > > > The wakeup hook in schedule is when we find out that we hit our max. I > >

Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interrupts disabled

2008-01-23 Thread Daniel Walker
On Wed, 2008-01-23 at 10:50 -0800, Daniel Walker wrote: > On Wed, 2008-01-23 at 13:43 -0500, Steven Rostedt wrote: > > On Wed, 23 Jan 2008, Daniel Walker wrote: > > > > > > > > On Wed, 2008-01-23 at 13:18 -0500, Steven Rostedt wrote: > > > > > >

[PATCH 1/4] usb microtek: remove unused semaphore

2007-12-21 Thread Daniel Walker
No current references, so removing it. Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- drivers/usb/image/microtek.c |1 - drivers/usb/image/microtek.h |1 - 2 files changed, 2 deletions(-) Index: linux-2.6.23/drivers/usb/image/micr

[PATCH 3/4] docs: convert kref semaphore to mutex

2007-12-21 Thread Daniel Walker
Just converting this documentation semaphore reference, since we don't want to promote semaphore usage. Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- Documentation/kref.txt | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) Index: linux-2.6.23/Do

[PATCH 2/4] prism54: remove questionable down_interruptible usage

2007-12-21 Thread Daniel Walker
rect. Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- drivers/net/wireless/prism54/isl_ioctl.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) Index: linux-2.6.23/drivers/net/wireless/prism54/isl_ioctl.c ===

[PATCH 4/4] usb: libusual: locking cleanup

2007-12-21 Thread Daniel Walker
I converted the usu_init_notify semaphore to normal mutex usage, and it should still prevent the request_module before the init routine is complete. Before it acted more like a complete, now the mutex protects two distinct section from running at the same time.. Signed-off-by: Daniel Walker

Re: [PATCH 4/4] usb: libusual: locking cleanup

2007-12-22 Thread Daniel Walker
On Fri, 2007-12-21 at 22:24 -0800, Pete Zaitcev wrote: > When I tried it, usb-storage would not load with unresolved symbols. > It happens if child (usu_probe_thread) runs ahead of its parent > (usb_usual_init -> usb_register -> usu_probe). It's entirely possible, > depending on your scheduler. >

Re: [PATCH 4/4] usb: libusual: locking cleanup

2007-12-23 Thread Daniel Walker
On Sat, 2007-12-22 at 23:37 -0800, Pete Zaitcev wrote: > On Sat, 22 Dec 2007 09:01:50 -0800, Daniel Walker <[EMAIL PROTECTED]> wrote: > > > Then in usu_probe_thread() your basically stopping it at the start of > > the function with a down(), and the up() is just ancil

Re: [PATCH 4/4] usb: libusual: locking cleanup

2007-12-24 Thread Daniel Walker
On Mon, 2007-12-24 at 06:12 -0800, Pete Zaitcev wrote: > On Sun, 23 Dec 2007 08:46:37 -0800, Daniel Walker <[EMAIL PROTECTED]> wrote: > > > I noticed you also have a spinlock held in usu_probe_thread(), the > > usu_lock.. That spinlock would preclude anything inside r

Re: [BUG 2.6.24-rc6-mm1] BUG() at check_irqs_on() in fs/buffer.c .

2007-12-25 Thread Daniel Walker
On Sun, 2007-12-23 at 16:16 +0100, Ingo Molnar wrote: > * Tetsuo Handa <[EMAIL PROTECTED]> wrote: > > > Hello. > > > > I encountered a BUG(). > > I didn't encounter this bug for 2.6.24-rc5-mm1 . > > I guess this bug was introduced between 2.6.24-rc5-mm1 and 2.6.24-rc6-mm1 . > > does the patch be

Re: [PATCH PREEMPT_RT]: On AT91 ARM: GPIO Interrupt handling can/will stall forever

2007-11-28 Thread Daniel Walker
says we don't need flow control.. > > You mean the Montavista real time tree? No .. I wouldn't comment about an company specific tree. I was talking about the broken out real time patches. Daniel Remove the IRQ_PENDING flag if it's asserted, and unmask the irq. Als

Re: [PATCH PREEMPT_RT]: On AT91 ARM: GPIO Interrupt handling can/will stall forever

2007-11-28 Thread Daniel Walker
On Wed, 2007-11-28 at 15:16 -0500, Steven Rostedt wrote: > > This could also simply be unique to the interrupt threads (only in RT). So > perhaps the patch is OK. > > Remy, sorry about this round-a-bout. But I don't have any of the hardware > that this affects, and I'm just being cautious. Igno

Re: [PATCH PREEMPT_RT]: On AT91 ARM: GPIO Interrupt handling can/will stall forever

2007-11-28 Thread Daniel Walker
On Wed, 2007-11-28 at 23:03 +, Russell King - ARM Linux wrote: > On Wed, Nov 28, 2007 at 04:13:07PM -0500, Steven Rostedt wrote: > > > > > > On Wed, 28 Nov 2007, Daniel Walker wrote: > > > > > > > > Ignoring the ARM side of things for a s

[PATCH] isapnp driver semaphore to mutex

2007-12-03 Thread Daniel Walker
Changed the isapnp semaphore to a mutex. Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> --- drivers/pnp/interface.c | 11 ++- drivers/pnp/manager.c | 19 ++- 2 files changed, 16 insertions(+), 14 deletions(-) Index: linux-2.6.23/drivers/pnp/inter

Re: [PATCH] isapnp driver semaphore to mutex

2007-12-03 Thread Daniel Walker
On Mon, 2007-12-03 at 16:57 +0100, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > Changed the isapnp semaphore to a mutex. > > cool - i'll give it a whirl. > > small immaterial nit: > > > Signed-Off-By: Daniel Walker <[EMAI

Re: [PATCH] isapnp driver semaphore to mutex

2007-12-03 Thread Daniel Walker
On Mon, 2007-12-03 at 17:47 +0100, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > On Mon, 2007-12-03 at 16:57 +0100, Ingo Molnar wrote: > > > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > > > > > Changed the isapnp

Re: [PATCH] isapnp driver semaphore to mutex

2007-12-03 Thread Daniel Walker
On Mon, 2007-12-03 at 20:11 +0100, Michal Schmidt wrote: > Dne Mon, 03 Dec 2007 10:35:01 -0800 > Daniel Walker <[EMAIL PROTECTED]> napsal(a): > > > Speaking of automating.. I created a little .vimrc add-on which helps > > doing sem2mutex type change

Re: [PATCH] isapnp driver semaphore to mutex

2007-12-03 Thread Daniel Walker
On Mon, 2007-12-03 at 17:47 +0100, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > On Mon, 2007-12-03 at 16:57 +0100, Ingo Molnar wrote: > > > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > > > > > Changed the isapnp

Re: [PATCH] USB testing driver: convert dev->sem to mutex

2007-12-04 Thread Daniel Walker
On Tue, 2007-12-04 at 17:55 +0100, Matthias Kaehlcke wrote: > @@ -1990,7 +1991,7 @@ static void usbtest_disconnect (struct > usb_interface *intf) > { > struct usbtest_dev *dev = usb_get_intfdata (intf); > > - down (&dev->sem); > + mutex_lock(&dev->lock); > > us

[PATCH 3/3] unix98 allocated_ptys_lock semaphore to mutex

2007-12-04 Thread Daniel Walker
Convert the unix98 allocated_ptys_lock to a mutex. Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- drivers/char/tty_io.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) Index: linux-2.6.23/drivers/char/tt

[PATCH 1/3] drivers/char/tty_io.c: remove pty_sem

2007-12-04 Thread Daniel Walker
I couldn't find any users, so removing it.. Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- drivers/char/tty_io.c |1 - include/linux/tty.h |1 - 2 files changed, 2 deletions(-) Index: linux-2.6.23/drivers/ch

[PATCH 2/3] drivers/isdn/i4l/isdn_tty.c: remove write_sem

2007-12-04 Thread Daniel Walker
I couldn't find any users, so removing it.. Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- drivers/isdn/i4l/isdn_tty.c |1 - include/linux/isdn.h|1 - 2 files changed, 2 deletions(-) Index: linux-2.6.23/drivers/isdn/i4l

[PATCH 2/3] Amiga serial driver: port_write_mutex fixup

2007-12-05 Thread Daniel Walker
The port_write_mutex was converted from a semaphore to a mutex, but there was still this ifdef'd init_MUTEX reference remaining. Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- drivers/char/ser_a2232.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6

[PATCH 3/3] printer port driver: semaphore to mutex

2007-12-05 Thread Daniel Walker
The port_mutex is actually a semaphore, so easily converted to a struct mutex. Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- drivers/char/lp.c | 11 ++- include/linux/lp.h |2 +- 2 files changed, 7 insertions(+), 6 deletions(-) Index: linux-2.6.23/drivers/cha

[PATCH 1/3] stopmachine semaphore to mutex

2007-12-05 Thread Daniel Walker
It's called stopmachine_mutex now, but it's a semaphore. So make it a "struct mutex" . Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- kernel/stop_machine.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: linux-2.

Re: [PATCH 3/3] printer port driver: semaphore to mutex

2007-12-06 Thread Daniel Walker
On Thu, 2007-12-06 at 11:23 +0100, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > The port_mutex is actually a semaphore, so easily converted to a > > struct mutex. > > > > Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> &g

Re: [BUG on PREEMPT_RT, 2.6.23.1-rt5] in rt-mutex code and signals

2007-11-19 Thread Daniel Walker
On Mon, 2007-11-19 at 02:24 -0500, Jon Masters wrote: > On Sat, 2007-11-17 at 09:55 -0800, Daniel Walker wrote: > > > Sure, you want to split the list? > > I'm happy to grab a few of these too. Let me know if either of you or > Ingo is working on the whole lot and abo

Re: [BUG on PREEMPT_RT, 2.6.23.1-rt5] in rt-mutex code and signals

2007-11-19 Thread Daniel Walker
On Mon, 2007-11-19 at 16:51 +0100, Remy Bohmer wrote: > Hello Daniel, > > Can we coordinate who is doing what somehow, to prevent double work? I actually haven't looked at any on Ingo's list (i8042tregs).. Feel free to call out the ones your looking at tho.. Daniel - To unsubscribe from this li

Re: [BUG on PREEMPT_RT, 2.6.23.1-rt5] in rt-mutex code and signals

2007-11-20 Thread Daniel Walker
On Sat, 2007-11-17 at 18:46 +0100, Ingo Molnar wrote: > fixing the top 20: > There are about 25 DECLARE_MUTEX() semaphores remaining .. One is the BKL which I would guess can't be converted. The others I've looked at appear to be trivial find/replace changes to get them to use the mutex type.. A

Re: [BUG on PREEMPT_RT, 2.6.23.1-rt5] in rt-mutex code and signals

2007-11-20 Thread Daniel Walker
On Tue, 2007-11-20 at 21:37 +0100, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > On Sat, 2007-11-17 at 18:46 +0100, Ingo Molnar wrote: > > > > > fixing the top 20: > > > > There are about 25 DECLARE_MUTEX() semaphores remaini

Re: [PATCH PREEMPT_RT]: On AT91 ARM: GPIO Interrupt handling can/will stall forever

2007-11-27 Thread Daniel Walker
On Tue, 2007-11-27 at 10:11 -0500, Steven Rostedt wrote: > Thomas, > > Can you ACK or NACK this patch. I know you play with a bunch of > hardware that this patch may affect. > My two cents, I think it's needed (or something like it).. It looks like handle_simple_irq normally expects a custom ca

Re: [PATCH PREEMPT_RT]: On AT91 ARM: GPIO Interrupt handling can/will stall forever

2007-11-27 Thread Daniel Walker
On Tue, 2007-11-27 at 07:25 -0800, Daniel Walker wrote: > On Tue, 2007-11-27 at 10:11 -0500, Steven Rostedt wrote: > > Thomas, > > > > Can you ACK or NACK this patch. I know you play with a bunch of > > hardware that this patch may affect. > > > >

[PATCH] checkpatch.pl: allow piping

2008-01-10 Thread Daniel Walker
A little feature addition to allow checkpatch.pl to check patches piped into it, in addition to specific file arguments. Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- scripts/checkpatch.pl | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) Index: linux-2.6.23/s

Re: [PATCH] checkpatch.pl: allow piping

2008-01-11 Thread Daniel Walker
On Fri, 2008-01-11 at 09:52 +0100, Jiri Slaby wrote: > On 01/11/2008 05:10 AM, Daniel Walker wrote: > > A little feature addition to allow checkpatch.pl to check patches piped > > into it, in addition to specific file arguments. > > You can still add - as an argument to chec

Re: [PATCH] checkpatch.pl: allow piping

2008-01-11 Thread Daniel Walker
On Fri, 2008-01-11 at 10:23 +0100, Bernd Petrovitsch wrote: > On Fre, 2008-01-11 at 10:21 +0100, Jiri Slaby wrote: > > On 01/11/2008 10:17 AM, Daniel Walker wrote: > > > On Fri, 2008-01-11 at 09:52 +0100, Jiri Slaby wrote: > > >> On 01/11/2008 05:10 AM, Daniel

Re: [PATCH] checkpatch.pl: allow piping

2008-01-11 Thread Daniel Walker
On Fri, 2008-01-11 at 10:34 +0100, Jiri Slaby wrote: > On 01/11/2008 10:30 AM, Daniel Walker wrote: > > On Fri, 2008-01-11 at 10:23 +0100, Bernd Petrovitsch wrote: > >> On Fre, 2008-01-11 at 10:21 +0100, Jiri Slaby wrote: > >>> git show 9914cad54c79d0b89b1f066c089

Re: [PATCH] checkpatch.pl: allow piping

2008-01-11 Thread Daniel Walker
On Fri, 2008-01-11 at 10:41 +0100, Jiri Slaby wrote: > On 01/11/2008 10:36 AM, Daniel Walker wrote: > > On Fri, 2008-01-11 at 10:34 +0100, Jiri Slaby wrote: > >> If somebody is hacking kernel, I think he should know the - trick used in > >> many > >> programs

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-11 Thread Daniel Walker
On Fri, 2008-01-11 at 18:06 +0100, Stefan Richter wrote: > Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > Acked-by: Jiri Slaby <[EMAIL PROTECTED]> > --- > scripts/checkpatch.pl |1 + > 1 file changed, 1 insertion(+) > > Index: linux/scripts/checkpatch.pl > ==

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-11 Thread Daniel Walker
On Fri, 2008-01-11 at 18:29 +0100, Stefan Richter wrote: > Daniel Walker wrote: > > On Fri, 2008-01-11 at 18:06 +0100, Stefan Richter wrote: > >> Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > >> + print "When patchfile is -, read standard input.\n&

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-14 Thread Daniel Walker
On Mon, 2008-01-14 at 17:17 +, Andy Whitcroft wrote: > On Fri, Jan 11, 2008 at 06:06:35PM +0100, Stefan Richter wrote: > > Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > > Acked-by: Jiri Slaby <[EMAIL PROTECTED]> > > As an absolute minimum this seems reasonable to me. I guess we could >

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-14 Thread Daniel Walker
On Mon, 2008-01-14 at 19:12 +, Andy Whitcroft wrote: > So it does, however that of itself differs from the unix norm; as with > this I cannot run checkpatch and "type" (ie paste) a patch fragment to > check it. So I don't think we want the semantics as you have there, > as its confusing to th

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-14 Thread Daniel Walker
On Mon, 2008-01-14 at 20:31 +0100, Stefan Richter wrote: > AFAIU Daniel's patch still leaves the possibility to use the '-' > syntax, > doesn't it? > > (The program 'cat' is of the kind which always reads from stdin if no > file name is given, or if '-' is given instead of a file name. So, > 'ca

Re: setting jiffies as the clocksource stops time

2008-01-16 Thread Daniel Walker
On Thu, 2008-01-17 at 02:09 +0530, Balaji Rao wrote: > Hi, > > When i set jiffies as the current_clocksource, date(1) tells me that > wallclock time has stopped, and soon after that, the > system becomes unresponsive. This is not seen with CONFIG_NO_HZ disabled. > > This happens in 2.6.24-rc4,

Re: 2.6.24-rc8-rt1

2008-01-17 Thread Daniel Walker
On Thu, 2008-01-17 at 11:13 +0100, Wolfgang Grandegger wrote: > Steven Rostedt wrote: > > We are pleased to announce the 2.6.24-rc8-rt1 tree, which can be > > downloaded from the location: > > > > http://rt.et.redhat.com/download/ > > It builds and runs fine on my Icecube-MPC5200 board, now al

Re: 2.6.24-rc8-rt1

2008-01-17 Thread Daniel Walker
On Thu, 2008-01-17 at 19:17 +0100, Wolfgang Grandegger wrote: > [0.733248] TCP bind hash table entries: 2048 (order: 3, 57344 > bytes) > [0.741132] TCP: Hash tables configured (established 2048 bind > 2048) > [0.747981] TCP reno registered > [0.805896] krcupreemptd setsched 0 > [

[PATCH] fix wrong sized spinlock flags argument

2008-01-17 Thread Daniel Walker
Correct wrong sized spinlock flags, form int to unsigned long. Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- drivers/media/video/saa7134/saa7134-core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.23/drivers/media/video/saa7134/saa7134-

Re: setting jiffies as the clocksource stops time

2008-01-17 Thread Daniel Walker
On Thu, 2008-01-17 at 23:34 +0100, Jan Engelhardt wrote: > On Jan 16 2008 13:20, Daniel Walker wrote: > >On Thu, 2008-01-17 at 02:09 +0530, Balaji Rao wrote: > >> Hi, > >> > >> When i set jiffies as the current_clocksource, date(1) tells me > >> th

Re: [PATCH] fix wrong sized spinlock flags argument

2008-01-17 Thread Daniel Walker
On Thu, 2008-01-17 at 15:48 -0800, Linus Torvalds wrote: > Applied. > > However, the patch itself didn't apply cleanly, because in my souce tree, > these two lines are in a different order: > > On Thu, 17 Jan 2008, Daniel Walker wrote: > > > >

[PATCH 2/2] [RESEND] driver base: memory: semaphore to mutex

2007-12-16 Thread Daniel Walker
Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- drivers/base/memory.c |7 --- include/linux/memory.h |5 ++--- mm/memory_hotplug.c|2 +- 3 files changed, 7 insertions(+), 7 deletions(-) Index: linux-2.6.23/drivers/base/me

<    1   2   3   4   5   6   7   8   9   >