/* this should unref the ttm bo */
> - drm_gem_object_unreference_unlocked(&bo->gem_base);
> + drm_gem_object_put_unlocked(&bo->gem_base);
> }
> }
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscr...@googlegroups.com.
> To post to this group, send email to outreachy-ker...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/1521570567-22519-1-git-send-email-santhameena13%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
On Wed, Mar 21, 2018 at 04:58:13PM +0200, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko
>
> Add support for Xen para-virtualized frontend display driver.
> Accompanying backend [1] is implemented as a user-space application
> and its helper library [2], capable of running as a We
On Tue, Mar 20, 2018 at 8:44 PM, Thomas Gleixner wrote:
> On Tue, 20 Mar 2018, Daniel Vetter wrote:
>
>> Sometimes it's really easy to know which object has gone boom and
>> where the offending code is, and sometimes it's really hard. One case
>> we're tr
the hardware.
> > *
> > * For drivers using drm_bridge, this store the hardware display
> > timings
> > * used between the CRTC and the first bridge. For other drivers, the
> > * meaning of the adjusted_mode field is purely driver implementation
> > * defined information, and will usually be used to store the hardware
> > * display timings used between the CRTC and encoder blocks.
> > */
> >
>
> Your proposal is very clear and understandable. I will make a new patch
> version based on it.
Just to avoid confusion: Needs to be a fully new patch on top of latest
drm-misc-next, since no rebasing in a group maintained tree.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
e, so the guest
> would need to find a free spot and ask the host to place the resource
> there. Then the guest needs page structs covering the mapped resource,
> so it can work with it. Didn't investigate how difficuilt that is. Use
> memory hotplug maybe? Can we easily unma
On Thu, Apr 05, 2018 at 05:11:17PM -0700, Matt Roper wrote:
> On Thu, Apr 05, 2018 at 10:32:04PM +0200, Daniel Vetter wrote:
> > Pulling this out of the shadows again.
> >
> > We now also have xen-zcopy from Oleksandr and the hyper dmabuf stuff
> > from Matt and Dongw
m shmem/memfd" ioctl. Sounds like a good
idea, and generally useful.
We might want to limit to memfd though for semantic reasons: dma-buf have
invariant size, shmem not so much. memfd can be locked down to not change
their size anymore. And iirc the core mm page invalidation protocol around
truncate() is about as bad as get_user_pages vs cow :-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
On Fri, Apr 06, 2018 at 08:02:16PM +0100, Ayan Halder wrote:
> On Tue, Mar 27, 2018 at 01:09:36PM +0200, Daniel Vetter wrote:
> > On Tue, Mar 27, 2018 at 11:59 AM, Ayan Halder wrote:
> > > On Tue, Mar 27, 2018 at 10:29:03AM +0200, Daniel Vetter wrote:
> > >> On M
On Fri, Apr 06, 2018 at 02:25:08PM +0300, Oleksandr Andrushchenko wrote:
> On 04/03/2018 12:47 PM, Daniel Vetter wrote:
> > On Thu, Mar 29, 2018 at 04:19:31PM +0300, Oleksandr Andrushchenko wrote:
> > > From: Oleksandr Andrushchenko
> > > +static int to_refs_
; diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c
> > > index 6d2a6e4..071221b 100644
> > > --- a/drivers/gpu/drm/drm_plane.c
> > > +++ b/drivers/gpu/drm/drm_plane.c
> > > @@ -1101,3 +1101,15 @@ int drm_mode_page_flip_ioctl(struct
> >
On Thu, Apr 05, 2018 at 11:59:57PM +, Deepak Singh Rawat wrote:
> > plane damage.
> >
> > On 04/05/2018 09:52 AM, Daniel Vetter wrote:
> > >
> > > TYPE_PLANE I have no idea who needs that. I suggest we just drop it.
> >
> > I'm as
and useful for drivers. There might be other cases where
> > clearing damage is the right thing to do. Also, there's the question of
> > whether no damage clips == full damage or not, so maybe we should call
> > this helper full_damage() instead.
>
> In my opinion if via proper documentation it is conveyed that no damage
> means full-update the clear_damage makes sense.
Documentation is the worst documentation. Function names, or just outright
implemented behaviour is much better (e.g. runtime checks). For full
damage if there's no clip rect I think the iterator should implement that
for us.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
;atomic worker wakupe latency, but should be a lot
better already.
> I'd like to hear comments on whether this seems reasonable, or whether
> I should go in some other direction.
Besides a few bikesheds to align better with other stuff going around I
think this looks good.
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
te mode 100644 drivers/video/stm32/stm32_dsi.c
> create mode 100644 include/dw_mipi_dsi.h
>
> --
> 1.9.1
>
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
t;
> +
> + return 0;
> +}
> +
> +static void __exit udmabuf_dev_exit(void)
> +{
> + misc_deregister(&udmabuf_misc);
> +}
> +
> +module_init(udmabuf_dev_init)
> +module_exit(udmabuf_dev_exit)
> +
> +MODULE_LICENSE("GPL v2");
> diff --gi
On Wed, Nov 21, 2018 at 10:31 AM Daniel Vetter wrote:
>
> On Tue, Nov 13, 2018 at 12:52:14AM -0500, Sasha Levin wrote:
> > From: "Lee, Shawn C"
> >
> > [ Upstream commit 922dceff8dc1fb4dafc9af78139ba65671408103 ]
> >
> > BOE panel (ID: 0x0771) that
i also gets shouted down. It's a gpu, any
idea of these drivers actually being platform independent is out of
the window from the start anyway, so we're ok with tying this to
platforms.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
Nobody's using cirrus because they care
> about color fidelity and it'll use less CPU to update. There's
> precedent here, mgag200 defaults to 16bpp on sufficiently memory-
> impaired devices.
Yeah nouveau does the same fallback to 16bpp if there's not enough vram.
Avoids the inverted condition compared to the open coded version.
Signed-off-by: Daniel Vetter
Cc: "Rafael J. Wysocki"
Cc: Viresh Kumar
Cc: linux...@vger.kernel.org
---
include/linux/cpufreq.h | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/include/linux
other places.
Motivated by a discussion with Andy and Yisheng, who want to add
another for_each_macro which would benefit from for_each_if() instead
of hand-rolling it.
Signed-off-by: Daniel Vetter
Cc: Gustavo Padovan
Cc: Maarten Lankhorst
Cc: Sean Paul
Cc: David Airlie
Cc: Andrew Morton
Cc: Kees
On Mon, Jul 09, 2018 at 04:30:01PM -0700, Andrew Morton wrote:
> On Mon, 9 Jul 2018 18:25:09 +0200 Daniel Vetter
> wrote:
>
> > To avoid compilers complainig about ambigious else blocks when putting
> > an if condition into a for_each macro one needs to invert the
> >
On Thu, Jun 28, 2018 at 11:45:37AM +0800, Stu Hsieh wrote:
> Hi, Daniel Vetter:
>
> On Mon, 2018-06-25 at 10:47 +0200, Daniel Vetter wrote:
> > On Wed, Jun 20, 2018 at 04:19:02PM +0800, Stu Hsieh wrote:
> > > This patch add support for the Mediatek MT2712 DISP subsystem.
On Wed, May 23, 2018 at 03:05:35PM +0530, Souptick Joarder wrote:
> On Mon, May 14, 2018 at 9:56 PM, Daniel Vetter wrote:
> > On Thu, May 10, 2018 at 02:51:38PM -0400, Sean Paul wrote:
> >> On Thu, May 10, 2018 at 07:58:11PM +0530, Souptick Joarder wrote:
> >> > Hi S
erwise you'll potentially have to patch every user of DRM_PANEL_BRIDGE as
> done in this patch.
Select isn't recursive, so this won't work unfortunately :-/
-Daniel
> --
> Regards,
>
> Laurent Pinchart
>
>
>
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
was still looking up at 128.
>
> Signed-off-by: Eric Anholt
> Fixes: 0d49f303e8a7 ("drm: remove all control node code")
> Cc: Daniel Vetter
> Cc: Sean Paul
Oops.
> ---
> include/drm/drm_file.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
On Wed, May 9, 2018 at 1:52 PM, Satendra Singh Thakur
wrote:
> On Thu, May 08, 2018 at 16:28:30 +0530, Satendra Singh Thakur wrote:
>> On Thu, May 07, 2018 at 15:46:02 +0200, Daniel Vetter wrote:
>> > On Thu, May 03, 2018 at 01:53:55PM +0530, Satendra Singh Thakur wrote:
&
get_page(obj->pages[page_offset]);
> > > --
> > > 1.9.1
> > >
> >
> > Any further comment on this patch ?
>
> Patch looks good to me. My build test fails, though, since vm_fault_t doesn't
> exist in drm-misc-next yet.
vm_fault_t is a
n using "<->", do you have a reference?
> But I guess the different arrow notations in math are somewhat overloaded
> and that someone at some point must have used "<->" to indicate a
> symmetric relationship...
Yeah I agree with Andrzej here, for me <-> implies a symmetric
relationship. Spelling it out like Andrzej suggested sounds like the
better idea.
-Daniel
>
> > Anyway:
> > Reviewed-by: Andrzej Hajda
>
> Thanks!
>
> Cheers,
> Peter
>
> > --
> > Regards
> > Andrzej
> >
> >> * @funcs: control functions
> >> * @driver_private: pointer to the bridge driver's internal context
> >> */
> >> @@ -271,6 +272,7 @@ struct drm_bridge {
> >>struct drm_bridge *next;
> >>struct list_head list;
> >>const struct drm_bridge_timings *timings;
> >> + struct device_link *link;
> >>
> >>const struct drm_bridge_funcs *funcs;
> >>void *driver_private;
> >
> >
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
ge(u8 link_status[DP_LINK_STATUS_SIZE],
> +int lane, u8 volt);
> +void drm_dp_set_adjust_request_pre_emphasis(u8
> link_status[DP_LINK_STATUS_SIZE],
> + int lane, u8 pre_emphasis);
>
> #define DP_BRANCH_OUI_H
+ // splat
> > > +#endif
> > > +
> > > if (unlikely(in_atomic_preempt_off())) {
> > > __schedule_bug(prev);
> > > preempt_count_set(PREEMPT_DISABLED);
> > > @@ -3391,7 +3396,7 @@ static void __sched notrace __schedule(bool preempt)
> > > rq = cpu_rq(cpu);
> > > prev = rq->curr;
> > >
> > > - schedule_debug(prev);
> > > + schedule_debug(prev, preempt);
> > >
> > > if (sched_feat(HRTICK))
> > > hrtick_clear(rq);
> >
> > --
> > Michal Hocko
> > SUSE Labs
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
On Mon, Dec 10, 2018 at 11:20:58AM +0100, Daniel Vetter wrote:
> On Mon, Dec 10, 2018 at 11:18:32AM +0100, Daniel Vetter wrote:
> > On Mon, Dec 10, 2018 at 11:06:34AM +0100, Greg Kroah-Hartman wrote:
> > > On Mon, Dec 10, 2018 at 09:46:53AM +0100, Daniel Vetter wrote:
> > &
On Wed, Dec 12, 2018 at 12:19 PM Greg Kroah-Hartman
wrote:
>
> On Wed, Dec 12, 2018 at 12:08:40PM +0100, Daniel Vetter wrote:
> > On Mon, Dec 10, 2018 at 11:20:58AM +0100, Daniel Vetter wrote:
> > > On Mon, Dec 10, 2018 at 11:18:32AM +0100, Daniel Vetter wrote:
> > >
I think. And maybe we need to update
MAINTAINERS, to make sure dri-devel gets cc'ed on patches touching the
dma-buf testcases.
-Daniel
> thanks,
> -- Shuah
>
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
d to be polished.
2. Make sure all drivers supporting legacy async cursor updates do through
the async_plane update infrastructure.
3. Get the async plane update stuff merged for amdgpu. Iirc that's still
stuck somewhere (but I'm not 100% sure what exactly they're doing).
On Thu, Dec 13, 2018 at 10:38:14AM +0100, Rafael J. Wysocki wrote:
> On Mon, Dec 10, 2018 at 9:47 AM Daniel Vetter wrote:
> >
> > Drivers might want to remove some sysfs files, which needs the same
> > locks and ends up angering lockdep. Relevant snippet o
On Thu, Dec 13, 2018 at 11:23 AM Rafael J. Wysocki wrote:
>
> On Thu, Dec 13, 2018 at 10:58 AM Daniel Vetter wrote:
> >
> > On Thu, Dec 13, 2018 at 10:38:14AM +0100, Rafael J. Wysocki wrote:
> > > On Mon, Dec 10, 2018 at 9:47 AM Daniel Vetter
> > > wrote:
&
8,6 @@ struct page **xen_drm_front_gem_get_pages(struct
> > drm_gem_object *gem_obj)
> > return xen_obj->pages;
> > }
> > -struct sg_table *xen_drm_front_gem_get_sg_table(struct drm_gem_object
> > *gem_obj)
> > -{
> > - struct xen_gem_object *xen_obj = to_xen_gem_obj(gem_obj);
> > -
> > - if (!xen_obj->pages)
> > - return ERR_PTR(-ENOMEM);
> > -
> > - return drm_prime_pages_to_sg(xen_obj->pages, xen_obj->num_pages);
> > -}
> > -
> > struct drm_gem_object *
> > xen_drm_front_gem_import_sg_table(struct drm_device *dev,
> > struct dma_buf_attachment *attach,
> > @@ -203,7 +237,7 @@ xen_drm_front_gem_import_sg_table(struct drm_device
> > *dev,
> > if (ret < 0)
> > return ERR_PTR(ret);
> > - xen_obj->sgt_imported = sgt;
> > + xen_obj->sgt = sgt;
> > ret = drm_prime_sg_to_page_addr_arrays(sgt, xen_obj->pages,
> >NULL, xen_obj->num_pages);
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
On Thu, Dec 13, 2018 at 5:18 PM Rafael J. Wysocki wrote:
>
> On Thu, Dec 13, 2018 at 1:36 PM Daniel Vetter wrote:
> >
> > On Thu, Dec 13, 2018 at 11:23 AM Rafael J. Wysocki
> > wrote:
> > >
> > > On Thu, Dec 13, 2018 at 10:58 AM Daniel Vetter wrote:
combination of someone
unbinding an usb device through sysfs which also has some device links
attached doesn't happen.
Since I've dug around in this, for this patch here from Rafael:
Reviewed-by: Daniel Vetter
Cheers, Daniel
>
> thanks,
>
> greg k-h
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
bject_idr
>* and @tile_idr.
>*/
> struct mutex idr_mutex;
>
> /**
> - * @crtc_idr:
> + * @object_idr:
>*
>* Main KMS ID tracking object. Use this idr for all IDs, fb, crtc,
>* connector, modes - just make
On Thu, Dec 13, 2018 at 07:09:15PM +0100, Rafael J. Wysocki wrote:
> On Thu, Dec 13, 2018 at 5:25 PM Daniel Vetter wrote:
> >
> > On Thu, Dec 13, 2018 at 5:18 PM Rafael J. Wysocki wrote:
> > >
> > > On Thu, Dec 13, 2018 at 1:36 PM Daniel Vetter
> > >
istribute it and/or modify
> > - * it under the terms of the GNU General Public License version 2 as
> > - * published by the Free Software Foundation.
> > */
> > #include
>
>
> --
> Regards,
>
> Laurent Pinchart
>
>
>
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
ot;
Cc: Greg Kroah-Hartman
Cc: Ramalingam C
Cc: Arend van Spriel
Cc: Andy Shevchenko
Cc: Geert Uytterhoeven
Cc: Bartosz Golaszewski
Cc: Heikki Krogerus
Cc: Vivek Gautam
Cc: Joe Perches
Signed-off-by: Daniel Vetter
---
drivers/base/bus.c | 4 ++--
include/linux/device.h | 4
2 f
On Wed, Dec 19, 2018 at 8:01 AM Greg Kroah-Hartman
wrote:
>
> On Tue, Dec 18, 2018 at 09:14:43PM +0100, Daniel Vetter wrote:
> > This is the much more correct fix for my earlier attempt at:
> >
> > https://lkml.org/lkml/2018/12/10/118
> >
> > Short recap:
>
(Greg).
Cc: "Rafael J. Wysocki"
Cc: Greg Kroah-Hartman
Cc: Ramalingam C
Cc: Arend van Spriel
Cc: Andy Shevchenko
Cc: Geert Uytterhoeven
Cc: Bartosz Golaszewski
Cc: Heikki Krogerus
Cc: Vivek Gautam
Cc: Joe Perches
Signed-off-by: Daniel Vetter
---
drivers/base/bus.c | 7 +
On Tue, Dec 18, 2018 at 04:27:58PM -0500, Lyude Paul wrote:
> On Fri, 2018-12-14 at 10:29 +0100, Daniel Vetter wrote:
> > On Thu, Dec 13, 2018 at 08:25:32PM -0500, Lyude Paul wrote:
> > > The current way of handling refcounting in the DP MST helpers is really
> > >
mode->vrefresh, mode->clock,
> mode->hdisplay, mode->hsync_start,
> mode->hsync_end, mode->htotal,
> diff --git a/drivers/gpu/drm/msm/edp/edp_bridge.c
> b/drivers/gpu/drm/msm/edp/edp_bridge.c
> index 931a5c97cccf..160e8d91eda2 100644
> --- a/drivers/gpu/drm/msm/edp/edp_bridge.c
> +++ b/drivers/gpu/drm/msm/edp/edp_bridge.c
> @@ -60,8 +60,8 @@ static void edp_bridge_mode_set(struct drm_bridge *bridge,
> struct edp_bridge *edp_bridge = to_edp_bridge(bridge);
> struct msm_edp *edp = edp_bridge->edp;
>
> - DBG("set mode: %d:\"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x",
> - mode->base.id, mode->name,
> + DBG("set mode: \"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x",
> + mode->name,
> mode->vrefresh, mode->clock,
> mode->hdisplay, mode->hsync_start,
> mode->hsync_end, mode->htotal,
> --
> 2.17.1
>
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
On Tue, Dec 18, 2018 at 11:38:10AM -0200, Shayenne Moura wrote:
> This patch removes the drm_mode_object prints, evaluation and use from
> drm_display_mode objects used in drm files. It removes dependency from
> drm_mode_object.
>
> Signed-off-by: Shayenne Moura
Reviewed-by
%d %d %d %d %d %d 0x%x 0x%x",
> + omap_crtc->name, mode->name,
> mode->vrefresh, mode->clock,
> mode->hdisplay, mode->hsync_start, mode->hsync_end, mode->htotal,
> mode->vdisplay, mode->vsync_start, mode->vsync_end, mode->vtotal,
> --
> 2.17.1
>
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
t; --
> 2.17.1
>
> _______
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
On Tue, Dec 18, 2018 at 11:38:25AM -0200, Shayenne Moura wrote:
> This patch removes base.id prints from drm_display_mode
>
> objects in sti files. It removes dependency from drm_mode_object.
>
> Signed-off-by: Shayenne Moura
Reviewed-by
i->priv;
> int vic = drm_match_cea_mode(mode);
>
> - DRM_DEBUG_DRIVER("%d:\"%s\" vic %d\n",
> - mode->base.id, mode->name, vic);
> + DRM_DEBUG_DRIVER("\"%s\" vic %d\n", mode->name, vic);
>
Shayenne Moura
I didn't yet compile-test all the drivers, but aside from that this looks
all good.
Reviewed-by: Daniel Vetter
> ---
> include/drm/drm_modes.h | 21 +++--
> 1 file changed, 3 insertions(+), 18 deletions(-)
>
> diff --git a/include/drm/drm_modes.
On Wed, Dec 19, 2018 at 01:49:30PM +0100, Greg Kroah-Hartman wrote:
> On Wed, Dec 19, 2018 at 01:39:09PM +0100, Daniel Vetter wrote:
> > --- a/include/linux/device.h
> > +++ b/include/linux/device.h
> > @@ -327,6 +327,7 @@ struct driver_attribute {
> > #
On Tue, Dec 18, 2018 at 04:52:24PM -0500, Lyude Paul wrote:
> On Fri, 2018-12-14 at 10:32 +0100, Daniel Vetter wrote:
> > On Thu, Dec 13, 2018 at 08:25:35PM -0500, Lyude Paul wrote:
> > > So that the ports stay around until we've destroyed the connectors, in
> > &g
On Wed, Dec 19, 2018 at 02:18:25PM +0100, Daniel Vetter wrote:
> On Wed, Dec 19, 2018 at 01:49:30PM +0100, Greg Kroah-Hartman wrote:
> > On Wed, Dec 19, 2018 at 01:39:09PM +0100, Daniel Vetter wrote:
> > > --- a/include/linux/device.h
> > > +++ b/include/linux/devi
he call to component_master_add_with_match.
>
> v2:
> No Change.
>
> Signed-off-by: Ramalingam C
> Suggested-by: Daniel Vetter
> Cc: Greg Kroah-Hartman
> Cc: Kate Stewart
> Cc: Thomas Gleixner
> Cc: Philippe Ombredanne
> Cc: linux-kernel@vger.kernel.org
Reviewed-b
On Wed, Dec 19, 2018 at 03:21:56PM +0100, Rafael J. Wysocki wrote:
> On Wed, Dec 19, 2018 at 1:39 PM Daniel Vetter wrote:
> >
> > This is the much more correct fix for my earlier attempt at:
> >
> > https://lkml.org/lkml/2018/12/10/118
> >
> > Short recap:
&
On Wed, Dec 19, 2018 at 6:29 PM Shayenne Moura
wrote:
>
> On 12/19, Daniel Vetter wrote:
> > On Tue, Dec 18, 2018 at 11:38:21AM -0200, Shayenne Moura wrote:
> > > This patch removes base.id prints from drm_display_mode
> > > objects in i915 files. It removes d
G("set mode: " DRM_MODE_FMT, DRM_MODE_ARG(mode));
>
> if (is_dual_dsi && !IS_MASTER_DSI_LINK(id))
> return;
> diff --git a/drivers/gpu/drm/msm/edp/edp_bridge.c
> b/drivers/gpu/drm/msm/edp/edp_bridge.c
> index 931a5c97cccf..153f350ce017 100644
> --- a/drivers/gpu/drm/msm/edp/edp_bridge.c
> +++ b/drivers/gpu/drm/msm/edp/edp_bridge.c
> @@ -60,14 +60,7 @@ static void edp_bridge_mode_set(struct drm_bridge *bridge,
> struct edp_bridge *edp_bridge = to_edp_bridge(bridge);
> struct msm_edp *edp = edp_bridge->edp;
>
> - DBG("set mode: %d:\"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x",
> - mode->base.id, mode->name,
> - mode->vrefresh, mode->clock,
> - mode->hdisplay, mode->hsync_start,
> - mode->hsync_end, mode->htotal,
> - mode->vdisplay, mode->vsync_start,
> - mode->vsync_end, mode->vtotal,
> - mode->type, mode->flags);
> + DBG("set mode: " DRM_MODE_FMT, DRM_MODE_ARG(mode));
>
> list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
> if ((connector->encoder != NULL) &&
> --
> 2.17.1
>
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
SYMBOL(drm_mode_create);
> --
> 2.17.1
>
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
ioctl */
> if (nr >= DRM_CORE_IOCTL_COUNT)
> goto err_i1;
> + nr = array_index_nospec(nr, DRM_CORE_IOCTL_COUNT);
> ioctl = &drm_ioctls[nr];
> }
>
> @@ -888,6 +893,7 @@ bool drm_ioctl_flags(unsigned i
On Fri, Dec 14, 2018 at 09:09:45AM +0200, Oleksandr Andrushchenko wrote:
> On 12/13/18 5:48 PM, Daniel Vetter wrote:
> > On Thu, Dec 13, 2018 at 12:17:54PM +0200, Oleksandr Andrushchenko wrote:
> > > Daniel, could you please comment?
> > Cross-revieweing someone else&#x
o post to this group, send email to outreachy-ker...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20181213225537.nq4dwidn6tma33iv%40smtp.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
ad.start_slot;
> - }
> + mgr->payloads[i].start_slot = req_payload.start_slot;
Entertaining!
Reviewed-by: Daniel Vetter
> /* work out what is required to happen with this payload */
> if (mgr->payloads[i].num_slots != req_payl
f (mgr->proposed_vcpis[j] &&
> + mgr->proposed_vcpis[j]->num_slots) {
> + set_bit(j + 1, &mgr->payload_mask);
> + } else {
> + clear_bit(j + 1, &mgr->payload_mask);
> + }
> }
> +
> + memset(&mgr->payloads[mgr->max_payloads - 1], 0,
> +sizeof(struct drm_dp_payload));
> + mgr->proposed_vcpis[mgr->max_payloads - 1] = NULL;
> + clear_bit(mgr->max_payloads, &mgr->payload_mask);
With the commit message improved to mention
- Add local variables in the first loop
- Early continue to reduce 1 indent in the 2nd loop
this is Reviewed-by: Daniel Vetter
> }
> mutex_unlock(&mgr->payload_lock);
>
> --
> 2.19.2
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
cess, learned that there is just no simple fix for this:
> the design is just broken. Unfortuntely, the usage of these helpers are
> quite broken as well. Some drivers like i915 have been smart enough to
> avoid accessing any kind of information from MST port structures, but
> others l
@ static struct drm_connector
> *intel_dp_add_mst_connector(struct drm_dp_mst_topolo
> if (ret)
> goto err;
>
> + drm_dp_mst_get_port_malloc(port);
Needs to be moved up where we assing intel_connector->port, or it'll
underflow on cleanup on error paths.
> +
> return connector;
>
> err:
> --
> 2.19.2
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
y allowing us to actually release said
> payloads correctly.
>
> Signed-off-by: Lyude Paul
I think with this we can also remove the int return value (that everyone
ignored except for some debug output) from drm_dp_update_payload_part1/2.
Follow-up cleanup patch ofc.
This looks good.
Review
On Thu, Dec 13, 2018 at 08:25:33PM -0500, Lyude Paul wrote:
> This has never actually worked, and isn't needed anyway: the driver's
> always going to try to deallocate VCPI when it tears down the display
> that the VCPI belongs to.
>
> Signed-off-by: Lyude Paul
R
new
>state, which would prevent us from incorrectly considering their
>bandwidth requirements alongside legitimate new payloads.
> - Add function references in drm_dp_atomic_release_vcpi_slots() - danvet
> - Annotate atomic VCPI and atomic check functions with __must_check
>
On Thu, Dec 13, 2018 at 11:35:33PM -0200, Helen Koike wrote:
> Hello,
>
> On 12/13/18 7:01 AM, Daniel Vetter wrote:
> > On Thu, Dec 13, 2018 at 04:43:57PM +0900, Tomasz Figa wrote:
> >> Hi Helen,
> >>
> >> On Sat, Nov 24, 2018 at 6:54 AM Helen Koike
&g
as synchronous as the current code, and so keep all these
preexisting races neatly tugged under the rug.
Cc: Ramalingam C
Cc: Greg Kroah-Hartman
Cc: "Rafael J. Wysocki"
Signed-off-by: Daniel Vetter
---
drivers/base/bus.c | 35 +--
1 file changed, 29 i
On Mon, Dec 10, 2018 at 11:06:34AM +0100, Greg Kroah-Hartman wrote:
> On Mon, Dec 10, 2018 at 09:46:53AM +0100, Daniel Vetter wrote:
> > Drivers might want to remove some sysfs files, which needs the same
> > locks and ends up angering lockdep. Relevant snippet of the
On Mon, Dec 10, 2018 at 11:18:32AM +0100, Daniel Vetter wrote:
> On Mon, Dec 10, 2018 at 11:06:34AM +0100, Greg Kroah-Hartman wrote:
> > On Mon, Dec 10, 2018 at 09:46:53AM +0100, Daniel Vetter wrote:
> > > Drivers might want to remove some sysfs files, which needs the same
>
= mode_cmd.width * ((sizes->surface_bpp + 7)/8);
> @@ -206,7 +205,6 @@ static int astfb_create(struct drm_fb_helper *helper,
> DRM_ERROR("failed to create fbcon backing object %d\n", ret);
> return ret;
> }
> - bo = gem_to_ast_bo(gobj);
>
> sysram = vmalloc(size);
> if (!sysram)
>
>
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
ian König"
Cc: David Rientjes
Cc: Daniel Vetter
Cc: "Jérôme Glisse"
Cc: linux...@kvack.org
Cc: Paolo Bonzini
Signed-off-by: Daniel Vetter
---
mm/mmu_notifier.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c
index 5119ff846769..ccc2
n
Cc: David Rientjes
Cc: "Jérôme Glisse"
Cc: Michal Hocko
Cc: "Christian König"
Cc: Greg Kroah-Hartman
Cc: Daniel Vetter
Cc: Mike Rapoport
Cc: linux...@kvack.org
Signed-off-by: Daniel Vetter
---
include/linux/mmu_notifier.h | 6 ++
mm/mmu_notifier.c| 7 +++
jes
Cc: "Christian König"
Cc: Daniel Vetter
Cc: "Jérôme Glisse"
Cc: linux...@kvack.org
Signed-off-by: Daniel Vetter
---
mm/mmu_notifier.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c
index ccc22f21b735..a5
s
not allowed to make sure there's forward progress.
Suggested by Michal Hocko.
Cc: Andrew Morton
Cc: Michal Hocko
Cc: David Rientjes
Cc: "Christian König"
Cc: Daniel Vetter
Cc: "Jérôme Glisse"
Cc: linux...@kvack.org
Signed-off-by: Daniel Vetter
---
include/linux/ker
implementation.
Thanks, Daniel
Daniel Vetter (4):
mm: Check if mmu notifier callbacks are allowed to fail
kernel.h: Add non_block_start/end()
mm, notifier: Catch sleeping/blocking for !blockable
mm, notifier: Add a lockdep map for invalidate_range_start
include/linux/kernel.h | 10
> Signed-off-by: Gerd Hoffmann
It's a bit a hack, but makes sense.
Acked-by: Daniel Vetter
> ---
> drivers/gpu/drm/bochs/bochs_hw.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/bochs/bochs_hw.c
> b/drivers/gpu/drm/bochs/bochs_h
On Thu, Dec 20, 2018 at 09:28:26AM +0100, Daniel Vetter wrote:
> On Thu, Dec 20, 2018 at 07:50:01AM +0100, Gerd Hoffmann wrote:
> > Check first two header bytes before trying to read the edid blob,
> > to avoid the log being spammed in case qemu has no edid support (old
> > qe
*data, struct drm_file *file_
> > >>>> {
> > >>>> struct drm_get_cap *req = data;
> > >>>> struct drm_crtc *crtc;
> > >>>> +struct drm_plane *plane;
> > >>>>
> > >>>> req->value = 0;
> > >>>>
> > >>>> @@ -292,6 +294,15 @@ static int drm_getcap(struct drm_device *dev,
> > >>>> void *data, struct drm_file *file_
> > >>>> case DRM_CAP_CRTC_IN_VBLANK_EVENT:
> > >>>> req->value = 1;
> > >>>> break;
> > >>>> +case DRM_CAP_ASYNC_UPDATE:
> > >>>> +req->value = 1;
> > >>>> +list_for_each_entry(plane, &dev->mode_config.plane_list,
> > >>>> head) {
> > >>>> +if (!plane->helper_private->atomic_async_update) {
> > >>>> +req->value = 0;
> > >>>> +break;
> > >>>> +}
> > >>>> +}
> > >>>> +break;
> > >>>> default:
> > >>>> return -EINVAL;
> > >>>> }
> > >>>> diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h
> > >>>> index 300f336633f2..ff01540cbb1d 100644
> > >>>> --- a/include/uapi/drm/drm.h
> > >>>> +++ b/include/uapi/drm/drm.h
> > >>>> @@ -649,6 +649,7 @@ struct drm_gem_open {
> > >>>> #define DRM_CAP_PAGE_FLIP_TARGET0x11
> > >>>> #define DRM_CAP_CRTC_IN_VBLANK_EVENT0x12
> > >>>> #define DRM_CAP_SYNCOBJ 0x13
> > >>>> +#define DRM_CAP_ASYNC_UPDATE0x14
> > >>>>
> > >>>> /** DRM_IOCTL_GET_CAP ioctl argument type */
> > >>>> struct drm_get_cap {
> > >>>> --
> > >>>> 2.19.1
> > >>>>
> > >>>> ___
> > >>>> dri-devel mailing list
> > >>>> dri-de...@lists.freedesktop.org
> > >>>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> > >>>
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
> Signed-off-by: Gerd Hoffmann
Reviewed-by: Daniel Vetter
> ---
> drivers/gpu/drm/bochs/bochs_hw.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/bochs/bochs_hw.c
> b/drivers/gpu/drm/bochs/bochs_hw.c
> index c90a0d492f..d0b4e1ce
On Thu, Dec 20, 2018 at 5:40 PM Alex Deucher wrote:
>
> + Nicholas
>
> On Thu, Dec 20, 2018 at 5:47 AM Daniel Vetter wrote:
> >
> > On Thu, Dec 20, 2018 at 10:07 AM Tomasz Figa wrote:
> > >
> > > Hi Helen,
> > >
> > >
On Thu, Dec 20, 2018 at 6:03 PM Alex Deucher wrote:
>
> + Harry
>
> On Thu, Dec 20, 2018 at 11:54 AM Daniel Vetter wrote:
> >
> > On Thu, Dec 20, 2018 at 5:40 PM Alex Deucher wrote:
> > >
> > > + Nicholas
> > >
> > > On Thu, Dec 20,
On Thu, Dec 20, 2018 at 6:16 PM Michel Dänzer wrote:
>
> On 2018-12-20 6:09 p.m., Daniel Vetter wrote:
> > On Thu, Dec 20, 2018 at 6:03 PM Alex Deucher wrote:
> >> On Thu, Dec 20, 2018 at 11:54 AM Daniel Vetter wrote:
> >
> >>> Not sure about the gamma t
ally
streaming dma, because with that all the zero copy buffer sharing
tricks become pointless. There's pretty epic amounts of hacks to work
around this, I have no idea what's supposed to give here.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
On Thu, Dec 20, 2018 at 6:38 PM Kazlauskas, Nicholas
wrote:
>
> On 12/20/18 12:09 PM, Daniel Vetter wrote:
> > On Thu, Dec 20, 2018 at 6:03 PM Alex Deucher wrote:
> >>
> >> + Harry
> >>
> >> On Thu, Dec 20, 2018 at 11:54 AM Daniel Vetter wrote:
On Thu, Dec 20, 2018 at 7:33 PM Christoph Hellwig wrote:
>
> On Thu, Dec 20, 2018 at 07:29:37PM +0100, Daniel Vetter wrote:
> > What we most definitely not want to end up with though is actually
> > streaming dma, because with that all the zero copy buffer sharing
> >
On Fri, Dec 21, 2018 at 10:47:27AM +0100, Michel Dänzer wrote:
> On 2018-12-20 6:16 p.m., Michel Dänzer wrote:
> > On 2018-12-20 6:09 p.m., Daniel Vetter wrote:
> >> On Thu, Dec 20, 2018 at 6:03 PM Alex Deucher wrote:
> >>> On Thu, Dec 20, 2018 at 11:54 AM Daniel
On Fri, Dec 21, 2018 at 12:51:05PM +0900, Tomasz Figa wrote:
> On Thu, Dec 20, 2018 at 7:47 PM Daniel Vetter wrote:
> >
> > On Thu, Dec 20, 2018 at 10:07 AM Tomasz Figa wrote:
> > >
> > > Hi Helen,
> > >
> > > On Fri, Dec 14, 2018 at 10:35 AM H
On Sat, Jan 05, 2019 at 09:11:53PM +0500, Ivan Mironov wrote:
> On Fri, 2018-12-28 at 13:15 +0100, Daniel Vetter wrote:
> > On Fri, Dec 28, 2018 at 04:13:07AM +0500, Ivan Mironov wrote:
> > > SDL 1.2 sets all fields related to the pixel format to zero in some
> > >
On Sat, Jan 05, 2019 at 09:21:21PM +0500, Ivan Mironov wrote:
> On Fri, 2018-12-28 at 13:06 +0100, Daniel Vetter wrote:
> > On Fri, Dec 28, 2018 at 04:13:08AM +0500, Ivan Mironov wrote:
> > > Strict requirement of pixclock to be zero breaks support of SDL 1.2
> > > whi
mp_handle < 0) {
> DRM_DEBUG("Not enough free contexts.\n");
> /* Should this return -EBUSY instead? */
> - return -ENOMEM;
> + return tmp_handle;
> }
>
> + ctx->handle = tmp_handle;
> +
> ctx_entry = kmalloc(sizeof(*ctx_entry), GFP_KERNEL);
> if (!ctx_entry) {
> DRM_DEBUG("out of memory\n");
> --
> 2.7.0
>
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
h EXPORT_SYMBOL_GPL makes sense here I think. Well most of drm is still
MIT, so it's a bit hm, but the semantics of _GPL still seem like what we.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
y: Sinan Kaya
> Reviewed-by: Lukas Wunner
> Acked-by: Daniel Vetter
I'm assuming this goes in through the acpi tree, correct?
-Daniel
> ---
> drivers/gpu/vga/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/vga/Kconfig b/drivers/gpu/vga/Kco
_DEV_ERROR(dev->dev,
> + "failed to set initial configuration, %d\n",
> + ret);
> + goto fini;
> + }
> +
> + return 0;
> +
> +fini:
> + drm_fb_helper_fini(helper);
> + return ret;
> +}
> +
> +void mtk_fbdev_fini(struct drm_device *dev)
> +{
> + struct mtk_drm_private *priv = dev->dev_private;
> + struct drm_fb_helper *helper = &priv->fb_helper;
> +
> + drm_fb_helper_unregister_fbi(helper);
> +
> + if (helper->fb) {
> + drm_framebuffer_unregister_private(helper->fb);
> + drm_framebuffer_remove(helper->fb);
> + }
> +
> + drm_fb_helper_fini(helper);
> +}
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_fbdev.h
> b/drivers/gpu/drm/mediatek/mtk_drm_fbdev.h
> new file mode 100644
> index ..45717b642dc5
> --- /dev/null
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_fbdev.h
> @@ -0,0 +1,25 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2018 MediaTek Inc.
> + * Author: CK Hu
> + */
> +
> +#ifndef MTK_DRM_FBDEV_H
> +#define MTK_DRM_FBDEV_H
> +
> +#ifdef CONFIG_DRM_FBDEV_EMULATION
> +int mtk_fbdev_init(struct drm_device *dev);
> +void mtk_fbdev_fini(struct drm_device *dev);
> +#else
> +int mtk_fbdev_init(struct drm_device *dev)
> +{
> + return 0;
> +}
> +
> +void mtk_fbdev_fini(struct drm_device *dev)
> +{
> +
> +}
> +#endif /* CONFIG_DRM_FBDEV_EMULATION */
> +
> +#endif /* MTK_DRM_FBDEV_H */
> --
> 2.17.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
n't set this, so
looks correct in all cases.
Reviewed-by: Daniel Vetter
(boolin.com has a bunch of drm-misc committers, so I'll leave pushing to
them).
-Daniel
> ---
> drivers/gpu/drm/drm_plane.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/d
601 - 700 of 3914 matches
Mail list logo
