On Tue, Dec 18, 2018 at 11:38:30AM -0200, Shayenne Moura wrote:
> This patch removes base.id prints from drm_display_mode
>
> objects in meson files. It removes dependency from drm_mode_object.
>
> Signed-off-by: Shayenne Moura <shayenneluzmo...@gmail.com>
> ---
> drivers/gpu/drm/meson/meson_dw_hdmi.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c
> b/drivers/gpu/drm/meson/meson_dw_hdmi.c
> index d8c5cc34e22e..b203560f666d 100644
> --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c
> +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c
> @@ -365,7 +365,7 @@ static int dw_hdmi_phy_init(struct dw_hdmi *hdmi, void
> *data,
> unsigned int wr_clk =
> readl_relaxed(priv->io_base + _REG(VPU_HDMI_SETTING));
>
> - DRM_DEBUG_DRIVER("%d:\"%s\"\n", mode->base.id, mode->name);
> + DRM_DEBUG_DRIVER("\"%s\"\n", mode->name);
>
> /* Enable clocks */
> regmap_update_bits(priv->hhi, HHI_HDMI_CLK_CNTL, 0xffff, 0x100);
> @@ -555,8 +555,8 @@ dw_hdmi_mode_valid(struct drm_connector *connector,
> int vic = drm_match_cea_mode(mode);
> enum drm_mode_status status;
>
> - DRM_DEBUG_DRIVER("Modeline %d:\"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x
> 0x%x\n",
> - mode->base.id, mode->name, mode->vrefresh, mode->clock,
> + DRM_DEBUG_DRIVER("Modeline \"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x
> 0x%x\n",
Here we could use DRM_MODE_FMT/ARG, other 2 changes lgtm.
-Daniel
> + mode->name, mode->vrefresh, mode->clock,
> mode->hdisplay, mode->hsync_start,
> mode->hsync_end, mode->htotal,
> mode->vdisplay, mode->vsync_start,
> @@ -650,8 +650,7 @@ static void meson_venc_hdmi_encoder_mode_set(struct
> drm_encoder *encoder,
> struct meson_drm *priv = dw_hdmi->priv;
> int vic = drm_match_cea_mode(mode);
>
> - DRM_DEBUG_DRIVER("%d:\"%s\" vic %d\n",
> - mode->base.id, mode->name, vic);
> + DRM_DEBUG_DRIVER("\"%s\" vic %d\n", mode->name, vic);
>
> /* VENC + VENC-DVI Mode setup */
> meson_venc_hdmi_mode_set(priv, vic, mode);
> --
> 2.17.1
>
> _______________________________________________
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
