On Thu, Mar 24, 2005 at 07:21:28AM -0800, [EMAIL PROTECTED] wrote:
>
> support configuration of AOE_PARTITIONS from Kconfig
>
> Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]>
>
> diff -uprN a/drivers/block/Kconfig b/drivers/block/Kconfig
> --- a/drivers/block/Kconfig 2005-03-07 17:37:58.0
> + dentry = __lookup_hash(&nd->last, nd->dentry, nd);
Please add a tiny wrapper lookup_hash_nd(struct nameidata *nd)
that expands to the above instead of opencoding it everywhere.
Or just call it lookup_hash() after you removed the original version..
-
To unsubscribe from this list: send the
On Thu, Mar 24, 2005 at 03:02:28AM +0100, Blaisorblade wrote:
> In this moment I need to clean up the missing symbol. If anyone wants to
> remove the code using this, then he might post a patch explictly removing it,
> and getting it refused probably.
>
> Or at least CC uml-devel when discussin
On Tue, Mar 29, 2005 at 11:06:16AM -0500, Ed L Cashin wrote:
> >
> > NACK. this changes devices nodes based on a compile-time option.
>
> I'm not sure I follow. This configuration option sets the number of
> partitions per device in the driver. It doesn't create device nodes.
>
> If the user
On Tue, Mar 29, 2005 at 04:30:44PM +1000, Nathan Scott wrote:
> On Mon, Mar 28, 2005 at 02:44:30PM -0800, Chris Wright wrote:
> > * Ali Akcaagac ([EMAIL PROTECTED]) wrote:
> > > And happy easter to you all. Just got this while trying to delete some
> > > files on my system.
> > ...
> > > : EIP is a
On Tue, Mar 29, 2005 at 11:48:48AM -0500, Ed L Cashin wrote:
> I don't know if it matters now that we have udev. When udev manages
> the device nodes it all just works,
But most peopel still don't use udev.
> If you're saying that it's bad in principal, then that's another
> story. If that's wh
On Tue, Mar 29, 2005 at 08:59:23AM -0800, Chris Wright wrote:
> * Nathan Scott ([EMAIL PROTECTED]) wrote:
> > On Mon, Mar 28, 2005 at 02:44:30PM -0800, Chris Wright wrote:
> > > * Ali Akcaagac ([EMAIL PROTECTED]) wrote:
> > > > And happy easter to you all. Just got this while trying to delete some
One more prematurely added drivers..
- plug various leaks and use after frees in the remove and
initialization failure path (some still left)
- remove useless global list of boards and use pci_set_drvdata instead
- unobsfucate init path by merging functions together
- kill various totally u
On Tue, Mar 29, 2005 at 01:47:34PM -0800, Andrew Morton wrote:
> Christoph Hellwig <[EMAIL PROTECTED]> wrote:
> >
> > One more prematurely added drivers..
>
> This driver was first sent out for review a month ago, was upissued twice
> and generated over seventy linu
On Tue, Mar 29, 2005 at 05:56:13PM -0500, Jeff Garzik wrote:
> It got a decent review, but from Christoph's list it looks like not all
> the issues raised during the review got addressed.
Exactly. Most reviews take more than one pass.
-
To unsubscribe from this list: send the line "unsubscribe
> +#define MAKE_LIST(list, nlist) \
> + do {\
> + if(list_empty(&list)) \
> + INIT_LIST_HEAD(nlist); \
> + else { nlist->next->prev = nlist; \
> + nlist->prev->next = nlist; \
> + }
On Thu, Mar 31, 2005 at 06:07:55PM +0900, Tejun Heo wrote:
> 01_scsi_no_REQ_SPECIAL_on_requeue.patch
>
> blk_insert_request() has 'reinsert' argument, which, when set,
> turns on REQ_SPECIAL and REQ_SOFTBARRIER and requeues the
> request. SCSI midlayer was the only user of this
On Thu, Mar 31, 2005 at 06:08:10PM +0900, Tejun Heo wrote:
> struct list_headsiblings; /* list of all devices on this host */
> struct list_headsame_target_siblings; /* just the devices sharing
> same target id */
>
> - volatile unsigned short device_busy;/* command
> /* Queue the command and wait for it to complete */
> /* Abuse eh_timeout in the scsi_cmnd struct for our purposes */
> init_timer(&cmd->eh_timeout);
> + cmd->eh_timeout.function = NULL;
I'd rather not see aic7xxx poke even deeper into this i
> +/*
> + * Macro to determine the size of SCSI command. This macro takes vendor
> + * unique commands into account. SCSI commands in groups 6 and 7 are
> + * vendor unique and we will depend upon the command length being
> + * supplied correctly in cmd_len.
> + */
> +#define CDB_SIZE(cmd)(
> - /*
> - * This sets up the scatter-gather table (allocating if
> - * required).
> - */
> + /* This sets up the scatter-gather table (allocating if
> + * required). */
the old comment style is the preferred in linux, pl
> - * Arguments:q - queue to operate on
> - * cmd - command that may need to be requeued.
> + * Arguments:cmd - command that may need to be requeued.
> + * reprep - needs to prep the command again?
> *
> * Returns: Nothing
> *
> @@ -478,11 +
the changes look good to me (although I haven't tested any of your patches
yet), but the code flow is rather confusing. What do you think about
the not even compile version of scsi_request_fn() below that should be
functionally identical to yours:
static void scsi_request_fn(struct request_queu
> - tg3 and bcm5700 totally overlap
bcm5700 isn't in the tree.
> - the same for e100 and eepro100, e1000 and eepro1000
there's no eepro1000
> - sata drivers ahci and ata_piix used to overlap too on a cople of
> devices
> - b44 and bcm4400 totally overlap
bcm4000 isn't in the tree
-
To unsub
On Wed, Mar 30, 2005 at 06:36:18PM +0530, shobhit dayal wrote:
> The goal here is to replace the head of a existing list pointed to by
> 'list' with a new head pointed to by 'nlist'.
> First there is a memcpy that copies the contents of list to nlist then
> this macro is called.
> The macro makes
On Wed, Mar 30, 2005 at 08:05:26PM +0200, Blaisorblade wrote:
> > My unaswered reply to the first submission is at
> >
> > http://groups-beta.google.com/group/linux.kernel/messages/de9504fe5963ccd1,
> >0c05294c599b22b1,eab26a4ed3f8ff17?thread_id=16c905c7e28e7498&mode=thread&noh
> >eader=1&q=uml-exp
EMAIL PROTECTED]>
+
+---
+
+What: register_ioctl32_conversion() / unregister_ioctl32_conversion()
+When: April 2005
+Why: Replaced by ->compat_ioctl in file_operations and other method
+ vecors.
+Who: Andi Kleen <[EMAIL PROTECTED]>, Christoph Hellwig <[EMAIL PRO
On Sat, Apr 02, 2005 at 11:28:12AM +, Luca Falavigna wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> This patch, compiled against version 2.6.12-rc1, implements RCU mechanism in
> intermodule functions.
There's no point as these functions are going to go away soon.
-
To unsubscr
On Sun, Apr 03, 2005 at 09:01:45PM -0700, Paul Jackson wrote:
> Mark wrote:
> > Probably all Linux binary drivers *are* compiled using GPL'd header files,
> > and thus are themselves subject to the GPL.
>
> I doubt that there is a consensus that simply compiling something with
> a GPL header neces
On Mon, Apr 04, 2005 at 08:59:03AM -0500, James Bottomley wrote:
> Well ... it's like this. Native means "pass through without swapping"
> and has an easy implementation on both BE and LE platforms. Logically
> io{read,write}{16,32}be would have to do byte swaps on LE platforms.
> Being lazy, I'm
When I did an allmodconfig on ppc64 it selected agp although ppc64
doesn't support agp and has not agp.h so the build failed.
This patch makes CONFIG_AGP depend on the architectures that actually
support agp.
--- 1.39/drivers/char/agp/Kconfig 2005-01-08 01:15:52 +01:00
+++ edited/drivers/c
arch/mips/kernel/binfmt_elfn32.c needs to override e_flags for elf
coredumps. It already defines ELF_CORE_EFLAGS before including
binfmt_elf.c, but the latter doesn't pick up the define yet.
--- 1.98/fs/binfmt_elf.c2005-01-12 03:07:01 +01:00
+++ edited/fs/binfmt_elf.c 2005-01-16 11:
Acked by Mikael Starvik.
--- 1.17/arch/cris/kernel/irq.c 2004-10-20 10:37:14 +02:00
+++ edited/arch/cris/kernel/irq.c 2005-01-07 12:26:22 +01:00
@@ -158,11 +158,6 @@
local_irq_disable();
}
irq_exit();
-
- if (softirq_pending(cpu))
-do_
The newly merged frv do_IRQ code calls softirq_pending(), but always with
the current cpu as argument - switch to local_softirq_pending().
Btw, this usage look bogus to me, any reason you need to call do_softirq
again after you did four lines above in irq_exit(), David?
--- 1.1/arch/frv/kernel/i
no more users left, time to kill the various implementations
--- 1.19/include/asm-ia64/hardirq.h 2004-11-16 20:10:08 +01:00
+++ edited/include/asm-ia64/hardirq.h 2005-01-07 13:21:28 +01:00
@@ -19,7 +19,6 @@
#define __ARCH_IRQ_STAT1
-#define softirq_pending(cpu) (cpu_d
On Fri, Jan 14, 2005 at 06:45:25PM +0100, Thomas Viehmann wrote:
> Hi.
>
> This may not be stritly on topic, but I couln't figure out a better
> place to ask:
>
> During the packaging of an application, I have the following problem:
> I would like to run a daemon as non-root. The daemon likes to
On Sun, Jan 16, 2005 at 01:05:50PM +0100, Adrian Bunk wrote:
> This doesn't seem to achieve what you want:
> PPC is defined on ppc64...
*grmbl*
--- 1.39/drivers/char/agp/Kconfig 2005-01-08 01:15:52 +01:00
+++ edited/drivers/char/agp/Kconfig 2005-01-16 11:39:56 +01:00
@@ -1,5 +1,6 @@
c
On Fri, Jan 14, 2005 at 07:23:09PM +0100, Jakob Oestergaard wrote:
> So apart from the general well known instability problems that will
> occur when you actually start *using* the system, there should be no
What known instabilities?
-
To unsubscribe from this list: send the line "unsubscribe lin
On Sun, Jan 16, 2005 at 04:37:32PM +0100, Mikael Pettersson wrote:
> You're preventing the ppc64 kernel for Apple PowerMac G5s
> from including AGP support via CONFIG_AGP_UNINORTH. I doubt
> that's correct.
It is correct. In mainline AGP for the G5 isn't supported at all.
On linuxppc64-dev there'
On Fri, Jan 14, 2005 at 04:11:38PM -0500, Karim Yaghmour wrote:
> Where does this appear in relayfs and what rights do
> user-space apps have over it (rwx).
Why would you want anything but read access?
> bufsize, nbufs:
> Usually things have to be subdivided in sub-buffers to ma
On Sat, Jan 15, 2005 at 01:24:16AM +0100, Thomas Gleixner wrote:
> Putting a 200k patch into the kernel for limited usage and maybe
> restricting a generic simple non intrusive and more generic
> implementation by its mere presence is making it inapplicable enough.
>
> Merge the instrumentation po
On Fri, Jan 14, 2005 at 06:09:23PM -0500, Karim Yaghmour wrote:
> relayfs implements two schemes: lockless and locking. The later uses
> standard linear locking mechanisms. If you need stringent constant
> time, you know what to do.
the lockless mode is really just loops around cmpxchg. It's spin
On Sun, Jan 16, 2005 at 03:11:00PM -0500, Robert Wisniewski wrote:
> int global_val;
>
> modify_val_spin()
> {
> acquire_spin_lock()
> // calculate some_value based on global_val
> // for example c=global_val; if (c%0) some_value=10; else some_value=20;
> global_val = globa
On Sun, Jan 16, 2005 at 09:11:03PM +, Alan Cox wrote:
> On Sul, 2005-01-16 at 12:04, Christoph Hellwig wrote:
> > > (where /proc/tty/driver/serial is mentioned as leaking sensitive
> > > information), to me the contents of usbserial look innocent enough.
> > >
> This e-mail message may contain proprietary, confidential or legally
> privileged information for the sole use of the person or entity to
> whom this message was originally addressed. Any review, e-transmission
> dissemination or other use of or taking of any action in reliance upon
> this inform
On Mon, Jan 17, 2005 at 10:48:52AM -0500, Robert Wisniewski wrote:
> Wow - disabling interrupts is handfuls to tens of cycles, so that means
> some architectures take thousands of cycles to do atomic operations. Then
> I would definitely agree we should not be using atomic operations on those,
> f
On Mon, Jan 17, 2005 at 02:52:16PM -0800, Chris Wright wrote:
> Yeah, "choose one, then put it here." I've set up
> [EMAIL PROTECTED]
Any chance we could have that @kernel.org or @vger.kernel.org?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message t
> +long compat_blkdev_ioctl(struct file *file, unsigned cmd, unsigned long arg)
> +{
> + struct block_device *bdev = file->f_dentry->d_inode->i_bdev;
> + struct gendisk *disk = bdev->bd_disk;
> + int ret = -ENOIOCTLCMD;
> + if (disk->fops->compat_ioctl) {
> + lock_kernel
On Tue, Jan 18, 2005 at 10:31:58AM +0100, Andi Kleen wrote:
> > - please don't introduce a new API with the BKL held.
>
> Nope, I'm not going to audit zillions of low level functions for this.
So just stick a lock_kernel() unlock_kernel() into the handler, it's
not like there's more than a handf
On Tue, Jan 18, 2005 at 12:48:16PM +0200, Michael S. Tsirkin wrote:
> Attached patch is against 2.6.11-rc1-bk5.
> It is split out from Andi's big patch.
> It is really unchanged so I dont put a signed-off-by here.
>
> Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
>
> SIOCDEVPRIVATE ioctl command
On Wed, Jan 19, 2005 at 10:43:52AM +0100, Gerd Knorr wrote:
> > This patch was already sent on:
> > - 9 Nov 2004
>
> Damn, yes. I have it. I don't consider those patches *that* important
> that I instantly forward the stuff, they'll go out with the next batch
> of v4l updates because it's less w
On Sun, Jan 16, 2005 at 02:13:46PM +0100, Thomas Viehmann wrote:
> Hi.
>
> Christoph Hellwig wrote:
> >Counter-question: What information is available in
> >/proc/tty/driver/usbserial but not in sysfs?
>
> Thanks for this hint, is there a way of finding vendor and p
> > > It looks like in the 3ware driver the procfs entry "/proc/scsi/3w-"
> > > has been removed (or actually moved to sysfs).
> > > Unfortunately, this breaks all the (binary only )-: tools provided by
> > > 3ware, which are indispensable for system maintenance.
> >
> > The change came from th
On Sun, Jan 16, 2005 at 02:30:33PM -0600, Tom Zanussi wrote:
> This would allow an application to write trace events of its own to a
> trace stream for instance.
I don't think this is a good idea. Userspace could aswell easily write
its trace into shared memory segments.
> Also, I added a user-r
On Sun, Jan 16, 2005 at 01:05:19PM -0600, Tom Zanussi wrote:
> One of the things that uses these functions to read from a channel
> from within the kernel is the relayfs code that implements read(2), so
> taking them away means you wouldn't be able to use read() on a relayfs
> file.
Removing them
sa_handler isn't the first member of struct sigaction on mips.
Use C99 initializers to avoid a compiler warning. (There don't
seem to be more serious problems as mips worked with that warning
for ages)
--- 1.33/include/linux/init_task.h 2005-01-05 03:48:20 +01:00
+++ edited/include/linux/in
To convert page->index to a byte index you need to cast it to loff_t
first so it's a 64bit value. There have been quite a few places that
got it wrong in the kernel. To make it easier a nice little helper
would be nice, and in fact the NFS code already has it. Let's move it
to pagemap.h so every
small changes from Linux/MIPS CVS and typedef removal from me
--- 1.12/drivers/scsi/jazz_esp.c2004-08-27 12:34:15 +02:00
+++ edited/drivers/scsi/jazz_esp.c 2005-01-19 12:33:09 +01:00
@@ -6,6 +6,7 @@
* jazz_esp is based on David S. Miller's ESP driver and cyber_esp
*/
+#include
On Thu, Jan 20, 2005 at 10:57:09AM +0100, Steffen Klassert wrote:
> On Wed, Jan 19, 2005 at 09:38:18PM -0800 or thereabouts, Andrew Morton wrote:
>
> > +kill-softirq_pending.patch
> >
> > Remove softirq_pending(). This breaks net/core/pktgen.c.
>
> net/built-in.o: In function `pktgen_thread_wo
> +uml-provide-a-release-method-for-the-ubd-driver.patch
This one is bogus. The driver core doesn't warn about a missing
release method just so that we add an empty one and bloat the kernel.
The object's lifetime rules needs fixing instead, and until that
happens that warning should be kept.
-
On Thu, Jan 20, 2005 at 01:16:33PM -0500, John Richard Moser wrote:
> Granted, you're somewhat more diverse than I pointed out; but I don't
> keep up on what you're doing. The point was more that you're not a
> major security figure and/or haven't donated your life to security and
> forsaken all l
On Thu, Jan 20, 2005 at 10:59:17AM -0800, William Lee Irwin III wrote:
> On Thu, Jan 20, 2005 at 07:20:19PM +0100, Adrian Bunk wrote:
> > I haven't found any modular usage of profile_pc in the kernel.
> > Is the patch below correct?
> > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
>
> In theory,
On Fri, Jan 21, 2005 at 05:53:35PM +, James Simmons wrote:
>
> Now its starting to look like the linuxconsole project :-)
Again, what's the linuxconsole project?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More major
--- 1.35/arch/sh/Kconfig2005-01-15 23:31:06 +01:00
+++ edited/arch/sh/Kconfig 2005-01-21 18:11:39 +01:00
@@ -29,6 +29,14 @@
bool
default y
+config GENERIC_HARDIRQS
+ bool
+ default y
+
+config GENERIC_IRQ_PROBE
+ bool
+ default y
+
source "in
(forgot to mention that I'd like to thank Tom Rini for testing the
patch on his Hitachi SE7750 and correcting two stupid little bugs)
On Sat, Jan 22, 2005 at 01:20:09PM +0100, Christoph Hellwig wrote:
>
> --- 1.35/arch/sh/Kconfig 2005-01-15 23:31:06 +01:00
> +++ edited/a
On Sat, Jan 22, 2005 at 11:01:29AM -0500, Chip Salzenberg wrote:
> Those of you who are using VMWare 4.5 will find that 2.6.11-rc2
> removes the public function "skb_copy_datagram", breaking VMWare
> (and any other module using that interface *sigh*).
>
> The attached patch restores the (little ha
On Mon, Jan 24, 2005 at 10:24:55PM +1100, Andrew Tridgell wrote:
> Andreas,
>
> I'm starting to think the bug I saw is hardware error. I just got this
> while trying to reproduce it tonight:
>
> Jan 24 02:43:32 dev4-003 kernel: qlogicfc0 : abort failed
> Jan 24 02:43:32 dev4-003 kernel: qlogicfc0
> +i4l-new-hfc_usb-driver-version.patch
this drivers wants:
- update for Documentation/CodingStyle
- conversion to proper pci API
> +posix-timers-tidy-up-clock-interfaces-and-consolidate-dispatch-logic.patch
umm, this adds extreme obsfucation. Roland, please try to follow normal
Linux style,
> inotify.patch
> inotify
Haven't had time to look at the current implementation, but the in-kernel
interface is still horrible as it duplicates the dnotify calls all over the
place, using IN_FOO instead of DN_FOO. Please add a layer of notify_foo
wrappers that calls into both.
Also ioctl is n
On Mon, Jan 24, 2005 at 01:25:41PM +0100, Adrian Bunk wrote:
> On Mon, Jan 24, 2005 at 02:15:16AM -0800, Andrew Morton wrote:
> >...
> > Changes since 2.6.11-rc1-mm2:
> >...
> > bk-i2c.patch
> >...
> > Latest versions of various bk trees
> >...
>
> This causes the following compile error:
Where
> bk-i2c.patch
This contains two new subsystems, both aren't exactly the nicest code
on earth and one isn't even explained what it is. And both aren't
really i2c-related.
Greg, any chance you could stop funneling new tasteless code in through
the backdoor?
-
To unsubscribe from this list: send
On Mon, Jan 24, 2005 at 06:54:49PM +0100, Adrian Bunk wrote:
> It seems noone who reviewed the SuperIO patches noticed that there are
> now two modules "scx200" in the kernel...
Did anyone review them?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a mes
On Mon, Jan 24, 2005 at 01:34:42PM -0800, Greg KH wrote:
> And as for the "these patches have never been reviewed" comments, that's
> why I put them in my tree, and have them show up in -mm. It's getting
> them a wider exposure and finding out these kinds of issues. So the
> process is working pr
On Mon, Jan 24, 2005 at 09:36:24PM +0100, Karsten Keil wrote:
> > - conversion to proper pci API
>
> ??? the driver is not PCI related at all
Sorry, this was actually a comment for i4l-hfc-4s-and-hfc-8s-driver.patch.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
t
On Mon, Jan 24, 2005 at 10:02:56PM -0800, Greg KH wrote:
> > It would be a lot more productive to follow the normal rules, though.
> > That is posting them on lkml as properly split up patches, and with
> > proper descriptions of what they're doing.
>
> As previously mentioned, these patches have
On Tue, Jan 25, 2005 at 01:41:17AM +0100, Sytse Wielinga wrote:
> Linus, could you please put skb_copy_datagram back in place? It's not used
> anymore in the kernel, but the vmnet module (in vmware) still uses this
> interface to skb_copy_datagram_iovec.
>
> Patch for 2.6.11-rc2 follows. It compil
Review of the superio subsystem sneaked in through bk-i2c.patch:
diff -Nru a/drivers/superio/Kconfig b/drivers/superio/Kconfig
--- /dev/null Wed Dec 31 16:00:00 196900
+++ b/drivers/superio/Kconfig 2005-01-23 22:34:15 -08:00
@@ -0,0 +1,56 @@
+menu "SuperIO subsystem support"
+
+config SC_SUPE
> > +obj-$(CONFIG_SC_SUPERIO) += superio.o
> > +obj-$(CONFIG_SC_GPIO) += sc_gpio.o
> > +obj-$(CONFIG_SC_ACB) += sc_acb.o
> > +obj-$(CONFIG_SC_PC8736X) += pc8736x.o
> > +obj-$(CONFIG_SC_SCX200)+= scx200.o
> > +
> > +superio-objs := sc.o chain.
> It is not the driver per se, but the way the memory which is the I/O
> source/target is presented to the driver. In linux there is a good
> chance it will have to use more scatter gather elements to represent
> the same amount of data.
Note that a change made a few month ago after seeing issues
> Zeroing can be found easily - the whole structure is NULL pointer,
> and will always panic if accessed(from running superio code),
> but redzoning is only happen on borders,
> and can catch writes over the boards, which is rarely in this case.
As I mentioned the redzoning was a brainfar on my
Content-Description: Forwarded message - TASK_SIZE is variable.
> Date: Tue, 25 Jan 2005 22:26:52 +
> From: David Woodhouse <[EMAIL PROTECTED]>
> Subject: TASK_SIZE is variable.
> To: linux-arch@vger.kernel.org
> X-Mailer: Evolution 2.0.2 (2.0.2-3.dwmw2.1)
>
> Bad things can happen if a 32-bi
On Sat, Nov 10, 2007 at 12:08:12AM +0100, Sam Ravnborg wrote:
> With this patchset the former ARCH=i386 / ARCH=x86_64 are
> replaced by ARCH=x86.
> The rationale behind the patchset are that with a
> unified x86 architecture this should be reflected in
> the build commands.
>
> With this patch set
On Sat, Nov 10, 2007 at 03:55:15PM +0100, Thomas Koeller wrote:
> cdrom.h uses INT_MAX, so it must include kernel.h or
> limits.h (userspace) for a definition.
Nack, we shoiuld never include userspace headers in kernel headers,
an even more never add !__KERNEL__ ifdefs. Just make sure your
progra
On Sun, Nov 11, 2007 at 06:01:37PM +0100, Jochen Friedrich wrote:
> --- a/arch/powerpc/sysdev/commproc.c
> +++ b/arch/powerpc/sysdev/commproc.c
> @@ -51,6 +51,8 @@ static void m8xx_cpm_dpinit(void);
> static uint host_buffer; /* One page of host buffer */
> static uint host_end;/* end + 1 */
>
On Tue, Nov 13, 2007 at 12:21:16PM -0800, Jeremy Fitzhardinge wrote:
> Subject: x86/paravirt: revert exports to restore old behaviour
>
> Subdividing the paravirt_ops structure caused a regression in certain
> non-GPL modules which try to use mmu_ops and cpu_ops. This restores
> the old behaviour
What about investing some effort to do a proper performance counter
infrastructure or turning the mess perfom is into one instead of this
useless rant? Code is not getting any better by your complain ccing
gazillions of useless list.
-
To unsubscribe from this list: send the line "unsubscribe li
On Tue, Nov 13, 2007 at 10:32:39AM -0800, Stephane Eranian wrote:
> It would obvisouly cause a lot of troubles to existing perfmon libraries and
> applications (e.g. PAPI). It would also be fairly tricky to do because you'd
> have to make sure that in the beginning, you leave enough flexiblity suc
On Wed, Nov 14, 2007 at 06:24:36PM +1100, Paul Mackerras wrote:
> Whose sentiment?
Mine for example. The whole userspace interface is just on crack,
and the code is full of complexities aswell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
On Wed, Nov 14, 2007 at 09:43:02PM +1100, Paul Mackerras wrote:
> Christoph Hellwig writes:
>
> > Mine for example. The whole userspace interface is just on crack,
> > and the code is full of complexities aswell.
>
> Could you give some _technical_ details of what yo
On Tue, Nov 13, 2007 at 11:04:00PM -0800, Chris Wedgwood wrote:
> With 2.6.24-rc2 (amd64) I sometimes (usually but perhaps not always)
> see a hang when accessing some NFS exported XFS filesystems. Local
> access to these filesystems ahead of time works without problems.
>
> This does not occur w
On Wed, Nov 14, 2007 at 12:39:22PM -0500, J. Bruce Fields wrote:
> This must have come up before; feel free to remind me: is there any way
> to make the interface easier to use? (E.g. would it help if the filldir
> callback could be passed a dentry?)
The best thing for the filesystem would be to
On Wed, Nov 14, 2007 at 12:53:22PM -0500, J. Bruce Fields wrote:
> On Wed, Nov 14, 2007 at 05:44:19PM +0000, Christoph Hellwig wrote:
> > On Wed, Nov 14, 2007 at 12:39:22PM -0500, J. Bruce Fields wrote:
> > > This must have come up before; feel free to remind me: is there any way
On Fri, Nov 16, 2007 at 06:06:51PM +0300, Alexey Dobriyan wrote:
> proc_kill_inodes() can clear ->i_fop in the middle of vfs_readdir resulting in
> NULL dereference during "file->f_op->readdir(file, buf, filler)".
>
> The solution is to remove proc_kill_inodes() completely:
> a) we don't have tric
On Fri, Nov 16, 2007 at 12:47:35PM -0500, Trond Myklebust wrote:
>
> On Sat, 2007-11-17 at 02:34 +0900, [EMAIL PROTECTED]
> wrote:
> > plain text document attachment
> > (add-wrapper-functions-for-vfs-helper-functions.patch)
> > This patch allows LSM hooks refer previously associated "struct vfsmo
On Fri, Nov 16, 2007 at 11:25:27PM +0100, Andi Kleen wrote:
> [EMAIL PROTECTED] writes:
>
> > does somebody know if there is a website or a project for giving
> > comfortable and deeper insight into what`s specific to distro`s kernels and
> > what`s their difference to vanilla kernel ?
> >
> > i
On Fri, Nov 16, 2007 at 03:09:36PM -0800, Christoph Lameter wrote:
> cntp = (xfs_icsb_cnts_t *)
> - per_cpu_ptr(mp->m_sb_cnts, (unsigned long)hcpu);
> + CPU_PTR(mp->m_sb_cnts, (unsigned long)hcpu);
> - mp->m_sb_cnts = alloc_percpu(xfs_icsb_cnts_t);
On Fri, Oct 26, 2007 at 07:37:21AM -0700, Arjan van de Ven wrote:
> before going into the LSM / security side of things, I'd like to get
> the VFS guys to look at your VFS interaction code.
It's been NACKed a few times, and just reposting it won't help.
-
To unsubscribe from this list: send the l
On Wed, Oct 24, 2007 at 06:26:26PM +0200, Adrian Bunk wrote:
> The Coverity checker spotted the following array overflow caused by
> commit 34c0d154243dd913c5690ae6ceb9557017429b9c:
The line is a left-over from times when gfs stored the mode of the
inode in the file handle. It can simply be delet
Nice, I always hated these double-indented switch statements.
> + case FIBMAP:
> + {
> + struct address_space *mapping = filp->f_mapping;
> + int res;
> + /* do we support this mess? */
> + if (!mapping->a_ops->bmap)
> + r
On Sat, Oct 27, 2007 at 07:10:44PM -0400, Erez Zadok wrote:
> Rename old vfs_ioctl to do_ioctl, because the comment above it clearly
> indicates that it is an internal function not to be exported to modules;
> therefore it should have a more traditional do_XXX name. The new do_ioctl
> is exported
On Sun, Oct 28, 2007 at 02:05:16PM -0400, Erez Zadok wrote:
>
> Sure. I assume you mean an internal function to encapsulate the entire case
> statement's code, one for each of the FIO* cases.
Yes.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message
On Sun, Oct 28, 2007 at 07:57:47PM -0700, Daniel Phillips wrote:
> On 10/28/07, Christoph Hellwig <[EMAIL PROTECTED]> wrote:
> > While you're at it, it's probably worth splitting this out into
> > a small helper function.
>
> Why? Is the same pattern calle
On Sun, Oct 28, 2007 at 08:40:56PM -0400, Erez Zadok wrote:
> +/**
> + * vfs_ioctl - call filesystem specific ioctl methods
> + *
> + * @filp: [in] open file to invoke ioctl method on
> + * @cmd: [in] ioctl command to execute
> + * @arg: [in/out] command-specific argument for ioctl
I've
> +static int __ioctl_fibmap(struct file *filp, int __user *p)
I'd say kill the __ prefix for all the functions you're adding.
> +static int __ioctl_fionbio(struct file *filp, unsigned long arg)
> +static int __ioctl_fioasync(unsigned int fd, struct file *filp,
> + unsign
On Mon, Oct 29, 2007 at 05:07:08PM -0700, H. Peter Anvin wrote:
> Dave Jones wrote:
> >Before the arch merge, I frequently would test 32bit compiles
> >by doing make ARCH=i386 {bzImage/modules/file.o}
> >
> >Since commit 47572387d58a9584c60ebbbdee56fc92c627f16f
> >how does one do this?
> >
>
> mak
901 - 1000 of 14612 matches
Mail list logo
