Re: 2.6.11-rc2-mm1: SuperIO scx200 breakage

2005-01-26 Thread Christoph Hellwig
On Wed, Jan 26, 2005 at 01:12:34PM +, Russell King wrote: > On Wed, Jan 26, 2005 at 10:14:34AM +0000, Christoph Hellwig wrote: > > That's simply not true. The amount of patches submitted is extremly > > huge and the reviewers don't have time to look at everythning. &

Re: UDF madness

2005-01-27 Thread Christoph Hellwig
> Yes, me too. generic_shutdown_super() takes lock_super(). And udf uses > lock_super for protecting its block allocation data strutures. Trivial > deadlock on unmount. > > Filesystems really shouldn't be using lock_super() for internal purposes, > and the main filesystems have been taught to n

Re: Patch 4/6 randomize the stack pointer

2005-01-27 Thread Christoph Hellwig
> -#ifdef CONFIG_X86_HT > +#ifdef __HAVE_ARCH_ALIGN_STACK > /* >* In some cases (e.g. Hyper-Threading), we want to avoid L1 >* evictions by the processes running on the same package. One >* thing we can do is to shuffle the initial stack

Re: reiser4 core patches: [Was: [RFC] per thread page reservation patch]

2005-01-27 Thread Christoph Hellwig
> So, currently, reiser4 depends on the core patches listed below. Would > you please look over them and let us know which look reasonable and > which are to be eliminated. > reiser4-sb_sync_inodes.patch > This patch adds new operation (sync_inodes) to struct super_operations. > This operation all

Re: 2.6.11-rc2-mm1: fuse patch needs new libs

2005-01-27 Thread Christoph Hellwig
On Tue, Jan 25, 2005 at 01:03:39AM +0100, Sytse Wielinga wrote: > Hi Andrew, > > On Mon, Jan 24, 2005 at 02:15:16AM -0800, Andrew Morton wrote: > > fuse-transfer-readdir-data-through-device.patch > > fuse: transfer readdir data through device > It is great that this is fixed, don't remove it, bu

Re: Patch 4/6 randomize the stack pointer

2005-01-27 Thread Christoph Hellwig
John, coult you please piss off and troll elsewhere? thanks - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Patch 4/6 randomize the stack pointer

2005-01-27 Thread Christoph Hellwig
> + p = arch_align_stack((unsigned long)p); looking at the code p already is unsigned long, so the cast is not needed. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: Patch 4/6 randomize the stack pointer

2005-01-27 Thread Christoph Hellwig
> The patch below replaces the existing 8Kb randomisation of the userspace > stack pointer (which is currently only done for Hyperthreaded P-IVs) with a > more general randomisation over a 64Kb range. 64Kb is not a lot, but it's a > start and once the dust settles we can increase this value to a mo

Re: Patch 4/6 randomize the stack pointer

2005-01-27 Thread Christoph Hellwig
On Thu, Jan 27, 2005 at 03:40:48PM -0500, Rik van Riel wrote: > On Thu, 27 Jan 2005, Christoph Hellwig wrote: > > >>+unsigned long arch_align_stack(unsigned long sp) > >>+{ > >>+ if (randomize_va_space) > >>+ sp -= ((get_random_int

Re: [ANN] removal of certain net drivers coming soon: eepro100, xircom_tulip_cb, iph5526

2005-01-27 Thread Christoph Hellwig
On Thu, Jan 27, 2005 at 03:45:40PM -0500, Jeff Garzik wrote: > 1) iphase (iph5526 a.k.a. drivers/net/fc/*) > > Been broken since 2.3 or 2.4. Only janitors have kept it compiling. No, it doesn't even compile, and didn't so for more than two years. - To unsubscribe from this list: send the line "

Re: make flock_lock_file_wait static

2005-01-28 Thread Christoph Hellwig
On Fri, Jan 28, 2005 at 06:14:46AM -0800, Paul E. McKenney wrote: > In my experience, the only way to get exports into a major distribution > is to get them into mainline kernel.org. If you can get Red Hat to > change its stance on this, works for me! That's not the point. You're trying to let u

Re: [PATCH 1/2] pci: Arch hook to determine config space size

2005-01-28 Thread Christoph Hellwig
> +int __attribute__ ((weak)) pcibios_exp_cfg_space(struct pci_dev *dev) { > return 1; } - prototypes belong to headers - weak linkage is the perfect way for total obsfucation please make this a regular arch hook > Please read the FAQ at http://www.tux.org/lkml/ ---end quoted text--- - To uns

Re: [Wbsd-devel] [PATCH 540] MMC_WBSD depends on ISA

2005-01-29 Thread Christoph Hellwig
On Sat, Jan 29, 2005 at 02:37:39PM +0100, Pierre Ossman wrote: > Pierre Ossman wrote: > >Geert Uytterhoeven wrote: > > > >>MMC_WBSD depends on ISA (needs isa_virt_to_bus()) > >> > >> > > > >Thanks. Shouldn't have missed something so obvious :) > > > >Russell, can you fix this in your next merge? >

Re: [Wbsd-devel] [PATCH 540] MMC_WBSD depends on ISA

2005-01-29 Thread Christoph Hellwig
On Sat, Jan 29, 2005 at 02:54:17PM +, Russell King wrote: > Christoph, did you mean to add anything? Yes, this somehow got lost: - > > Russell, please undo this patch. isa_virt_to_bus() is not dependent on > > CONFIG_ISA. It causes problems on x86_64 platforms which cannot enable > > I

Re: [Wbsd-devel] [PATCH 540] MMC_WBSD depends on ISA

2005-01-29 Thread Christoph Hellwig
On Sat, Jan 29, 2005 at 03:13:46PM +, Russell King wrote: > One thing which comes up in this instance is: what struct device should > be used. Current convention is to use a NULL device, it's from pre-generic DMA times were only the pci_* types existed. - To unsubscribe from this list: send t

Re: UDF madness

2005-01-29 Thread Christoph Hellwig
_inode() call moved outside locked section to avoid another deadlock - unused variable ino killed - is_directory moved into the conditional it's actually used in Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> (note that I see memory corruption in UDF_I_DATA(inode), but I&#

Re: [Wbsd-devel] [PATCH 540] MMC_WBSD depends on ISA

2005-01-29 Thread Christoph Hellwig
On Sat, Jan 29, 2005 at 04:31:16PM +0100, Pierre Ossman wrote: > The problem was that the DMA API didn't work for x86_64 when I wrote the > driver. I see now that it has been fixed. > isa_virt_to_bus still works even though CONFIG_ISA is not configured. So It may not exist at all. - To unsubscr

Re: [Wbsd-devel] [PATCH 540] MMC_WBSD depends on ISA

2005-01-29 Thread Christoph Hellwig
On Sat, Jan 29, 2005 at 05:08:32PM +0100, Pierre Ossman wrote: > For i386 and x86_64 it's defined as virt_to_phys in asm/io.h without any > #ifdef:s protecting it. Not all the world is a PC - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMA

Re: Patch 4/6 randomize the stack pointer

2005-01-29 Thread Christoph Hellwig
On Sat, Jan 29, 2005 at 12:49:05PM -0500, John Richard Moser wrote: > > The ideas in IBM's ProPolice changes are good and worth > > implementing, but the current implementation is bad. > > > > Lies. I've read the paper on the current implementation, it's > definitely good. It only operates on C

Re: Patch 4/6 randomize the stack pointer

2005-01-29 Thread Christoph Hellwig
On Sat, Jan 29, 2005 at 01:10:54PM -0500, John Richard Moser wrote: > > Yeah, I guess your extensive compiler internals experience and knowledge > > of gcc internals weights a lot more than the opinion of the gcc team.. > > > > I read "implementation" as "the way it's implemented," not as "the >

Re: 2.6.11-rc2-mm2

2005-01-30 Thread Christoph Hellwig
On Sat, Jan 29, 2005 at 11:56:53PM -0800, Andrew Morton wrote: > bix:/home/akpm> grep EXPORT x > CONFIG_XFS_EXPORT=y > CONFIG_EXPORTFS=m > > That isn't going to work. Something like this, perhaps? We want to avoid building xfs_export.o when CONFIG_EXPORTFS isn't set. CONFIG_XFS_EXPORT=y and CON

Re: 2.6.11-rc2-mm2

2005-01-30 Thread Christoph Hellwig
On Sun, Jan 30, 2005 at 10:54:29AM +, Christoph Hellwig wrote: > We want to avoid building xfs_export.o when CONFIG_EXPORTFS > isn't set. CONFIG_XFS_EXPORT=y and CONFIG_EXPORTFS=m worked for > me in my testing. Do you have XFS builtin or modular? > > I suspect we need

Re: [RFC: 2.6 patch] drivers/acpi/: possible cleanups

2005-01-30 Thread Christoph Hellwig
On Thu, Jan 27, 2005 at 06:04:20PM -0500, Len Brown wrote: > I've already asked Bob Moore to migrate to the use of static in the > interpreter. There are some somewhat urgent functional issues he needs > to focus on first, but static is on the list. If we allow him to do it > upstream (w/o lookin

Re: kbuild: shorthand ym2y, ym2m etc

2005-01-30 Thread Christoph Hellwig
> We have in several cases the need to transpose a i'm' to 'y' in the Kbuild > files. > One example is the following snippet from sound/Makefile: > ifeq ($(CONFIG_SND),y) > obj-y += last.o > endif > > Alternative syntax could be: > obj-$(call y2y,CONFIG_SND) += last.o This should go away with e

Re: 2.6.11-rc2-mm2

2005-01-30 Thread Christoph Hellwig
On Mon, Jan 31, 2005 at 12:36:02AM +0100, Roman Zippel wrote: > Why not just let XFS_FS select EXPORTFS directly: > > config XFS_FS > select EXPORTFS if NFSD Makes sense. We'll still need the XFS_EXPORT symbol in it's original form to select building xfs_export.o. - To unsubscribe from th

Re: 2.6.11-rc2-mm2

2005-01-31 Thread Christoph Hellwig
On Sat, Jan 29, 2005 at 11:56:53PM -0800, Andrew Morton wrote: > Paul Blazejowski <[EMAIL PROTECTED]> wrote: > > > > Kernel compile errors here, i think this might be XFS related... > > > > fs/built-in.o(.text+0x52a93): In function `linvfs_decode_fh': > > : undefined reference to `find_exported_

Re: [PATCH] Altix : ioc4 serial driver support

2005-02-01 Thread Christoph Hellwig
On Mon, Jan 31, 2005 at 04:45:05PM -0600, Pat Gefre wrote: > > I've updated this patch with suggestions from the reviews. And moved it > up the latest 2.6 (since it has been awhile...). I'm also adding > Bartlomiej as a CC since there are IDE mods involved. This looks much better, thanks. Please

Re: [RFC][PATCH 0/3] Access Control Lists for tmpfs and /dev/pts

2005-02-02 Thread Christoph Hellwig
On Wed, Feb 02, 2005 at 05:13:40PM +0100, Andreas Gruenbacher wrote: > Here is a set of three patches which implement some general > infrastructure and on top of that, acls for tmpfs and /dev/pts files. Why would you want ACLs on /dev/pts? - To unsubscribe from this list: send the line "unsubscri

Re: [PATCH] Altix : ioc4 serial driver support

2005-02-02 Thread Christoph Hellwig
On Wed, Feb 02, 2005 at 02:36:15PM -0600, Patrick Gefre wrote: > >Please kill ioc4_ide_init as it's completely unused and make > >ioc4_serial_init > >a normal module_init() handler in ioc4_serial, there's no need to call > >them from the generic driver. > > > > I want ioc4_serial_init called befo

Re: SysKonnect sk98lin Gigabit lan missing in action from 2.6.10 on

2005-02-04 Thread Christoph Hellwig
On Fri, Feb 04, 2005 at 07:41:24AM -0700, maxer wrote: > What is the status of sk98lin? Do we have to wait until Syskonnect gets > their act together > and write a new driver for 2.6.10? > > Their latest is Oct 2004 and not at all compatible with 2.6.10 and beyond. Use the driver intree or bette

Re: [PATCH] relayfs redux, part 3

2005-02-04 Thread Christoph Hellwig
First set of comments. Mostly ignores the actual filesystem sematics bits, that'll come next. > +# > +# relayfs Makefile > +# probably superflous comment ;-) > + mem = vmap(*page_array, *page_count, GFP_KERNEL, PAGE_KERNEL); Do you really need to vmap it, and eat up vmallocspace and TLB e

Re: [PATCH] relayfs redux, part 3

2005-02-04 Thread Christoph Hellwig
in the filesystem path especially relayfs_create_entry and the functions called by it seem overly complex, probably because copying from ramfs which allows namespace operations from userland. See the totally untested code below for how it could be done more cleanly. What I really dislike is the c

Re: 2.6.11-rc3-mm1 : can't insmod dm-mod

2005-02-05 Thread Christoph Hellwig
On Sat, Feb 05, 2005 at 03:26:05AM -0800, Andrew Morton wrote: > You've enabled CONFIG_BASE_SMALL and so the major_names[] hashtable has > just one element. device-mapper uses dynamic major allocation, the range > of which is limited to the size of the top-level major_names[] array. You > ran out

Re: msdos/vfat defaults are annoying

2005-02-05 Thread Christoph Hellwig
On Sun, Feb 06, 2005 at 12:33:43AM -0500, John Richard Moser wrote: > I dunno. I can never understand the innards of the kernel devs' minds. filesystem detection isn't handled at the kerne level. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message t

Re: [PROPOSAL/PATCH] Remove PT_GNU_STACK support before 2.6.11

2005-02-06 Thread Christoph Hellwig
On Sun, Feb 06, 2005 at 02:01:52PM +0100, Andi Kleen wrote: > > correct, > > http://lists.ximian.com/archives/public/mono-list/2004-June/021592.html > > > > that fixes mono instead > > Silent breakage => bad. silent breakage for newly compiled buggty and non-portable code. Still not nice but ce

Re: [ANNOUNCE] "iswraid" (ICHxR ataraid sub-driver) for 2.4.29

2005-02-06 Thread Christoph Hellwig
On Sun, Feb 06, 2005 at 09:38:54AM -0500, Jeff Garzik wrote: > Without device mapper (another new feature) to enable dmraid, these > users are just sorta S.O.L. > > I consider it not a new feature, but a missing feature, since otherwise > user data cannot be accessed in the RAID setups. So thos

Re: [ANNOUNCE] "iswraid" (ICHxR ataraid sub-driver) for 2.4.29

2005-02-06 Thread Christoph Hellwig
On Sun, Feb 06, 2005 at 10:03:27AM -0500, Jeff Garzik wrote: > Red herring. > > 2.4.x has ICH5/6 support -- but is missing the RAID support component. > > We are talking about hardware that is ALREADY supported by 2.4.x kernel, > not new hardware. You're talking about software not support (the

Re: [ANNOUNCE] "iswraid" (ICHxR ataraid sub-driver) for 2.4.29

2005-02-06 Thread Christoph Hellwig
On Sun, Feb 06, 2005 at 11:09:37AM -0500, Jeff Garzik wrote: > I'm talking about being able to access data, or not. And your point is? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel

Re: [patch -mm series] ia64 specific /dev/mem handlers

2005-02-23 Thread Christoph Hellwig
> + page = pfn_to_page(p >> PAGE_SHIFT); > + /* > + * On ia64 if a page has been mapped somewhere as > + * uncached, then it must also be accessed uncached > + * by the kernel or data corruption may occur > + */ > +#ifdef A

Re: [Patch 1/6] Bind Mount Extensions 0.06

2005-02-23 Thread Christoph Hellwig
On Tue, Feb 22, 2005 at 01:10:49PM +0100, Herbert Poetzl wrote: > > > ; > ; Bind Mount Extensions > ; > ; This part adds support for the RDONLY, NOATIME and NODIRATIME > ; vfsmount flags, propagates those options into loopback (bind) > ; mounts and displays them properly in show_vfsmnt()/proc wr

Re: [Patch 2/6] Bind Mount Extensions 0.06

2005-02-23 Thread Christoph Hellwig
On Tue, Feb 22, 2005 at 01:11:29PM +0100, Herbert Poetzl wrote: > > > ; > ; Bind Mount Extensions > ; > ; This part adds the required checks for touch_atime() to allow > ; for vfsmount based NOATIME and NODIRATIME > ; autofs4 update_atime is the only exception (ignored on purpose) and that purpo

Re: [Patch 6/6] Bind Mount Extensions 0.06

2005-02-23 Thread Christoph Hellwig
> +++ > linux-2.6.11-rc4-bme0.06-bm0.01-at0.01-cc0.01-co0.01-xa0.01-ro0.01/fs/ext2/ioctl.c > 2005-02-19 06:32:05 +0100 > @@ -29,7 +29,8 @@ int ext2_ioctl (struct inode * inode, st > case EXT2_IOC_SETFLAGS: { > unsigned int oldflags; > > - if (IS_RDONLY(ino

Re: [2.6.11-rc4-mm1 patch] drivers/scsi/arcmsr/arcmsr.c cleanups

2005-02-27 Thread Christoph Hellwig
On Sun, Feb 27, 2005 at 04:48:10PM +0100, Adrian Bunk wrote: > - aren't the "if defined(__x86_64__)" wrong for other 64bit > architectures? Yes. Having arch or 64bit ifdefs is pretty wrong pretty much always. In one case it's only used to make a typedef a 32bit or 64bit integeger, that should b

Re: [2.6 patch] unexport do_settimeofday

2005-02-27 Thread Christoph Hellwig
On Fri, Feb 25, 2005 at 12:28:04AM -0800, Andrew Morton wrote: > > for _set_ time of day? I really can't imagine anyone messing with that. > > _get_... sure. but set??? > > Sure. But there must have been a reason to export it in the first place. NO. Speaking from experience there's tons of tota

Re: [patch 10/16] Infrastructure and server side of nfsacl

2005-02-27 Thread Christoph Hellwig
On Sun, Feb 27, 2005 at 04:22:53PM +0100, Andreas Gruenbacher wrote: > This adds functions for encoding and decoding POSIX ACLs for the NFSACL > protocol extension, and the GETACL and SETACL RPCs. The implementation is > compatible with NFSACL in Solaris. Can you add a new fs/nfscommon/ directory

Re: [ patch 4/7] drivers/serial/jsm: new serial device driver

2005-02-27 Thread Christoph Hellwig
On Sun, Feb 27, 2005 at 06:39:51PM -0500, Wen Xiong wrote: > This patch is for jsm_proc.c and includes the functions relating to > /proc/jsm entry. please don't put in more procfs driver interfaces. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [ patch 6/7] drivers/serial/jsm: new serial device driver

2005-02-27 Thread Christoph Hellwig
On Sun, Feb 27, 2005 at 07:47:58PM -0500, Jeff Garzik wrote: > >+struct shrink_buf_struct { > >+unsigned intshrink_buf_vaddr; /* Virtual address of board > >*/ > >+unsigned intshrink_buf_phys;/* Physical address of board > >*/ > > Major bug. These should be unsigne

Re: [ patch 7/7] drivers/serial/jsm: new serial device driver

2005-02-27 Thread Christoph Hellwig
> +config SERIAL_JSM > +tristate "Digi International NEO PCI Support" > +select SERIAL_CORE shouldn't this depend on CONFIG_PCI? > diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/Makefile > linux-2.6.9.new/drivers/serial/jsm/Makefile > --- linux-2.6.9.orig/drivers/serial/jsm/Makef

Re: [2.6 patch] drivers/scsi/qla2xxx/: cleanups

2005-02-28 Thread Christoph Hellwig
On Mon, Feb 28, 2005 at 10:00:24PM +0100, Adrian Bunk wrote: > This patch contains the following cleanups: > - make needlessly global code static > - kill the unused global *_version and *_version_str variables > in the firmware files The firmware files are generated, so it'd be better to leave

Re: [PATCH] perthread_pages_alloc cleanup

2005-02-28 Thread Christoph Hellwig
On Mon, Feb 28, 2005 at 10:52:48AM -0500, Martin Hicks wrote: > > Hi Andrew, > > This is just a cleanup - no functional changes. Gets a bunch of code > outside an if by returning NULL earlier. the last discussion of that code had the outcome we should just drop it, probably not worth wasting an

Re: [2.6 patch] drivers/scsi/scsi_transport_fc.c: #0 unused code

2005-02-28 Thread Christoph Hellwig
On Mon, Feb 28, 2005 at 11:00:20PM +0100, Adrian Bunk wrote: > This patch #if 0's the following EXPORT_SYMBOL'ed but unused functions: > - fc_target_block > - fc_target_unblock > - fc_host_block > - fc_host_unblock A driver using them is scheduled to be merged soon, and at least one other will be

Re: [2.6 patch] SCSI: possible cleanups

2005-02-28 Thread Christoph Hellwig
On Mon, Feb 28, 2005 at 10:31:59PM +0100, Adrian Bunk wrote: > Before I'm getting flamed to death: > This patch contains possible cleanups. If parts of this patch conflict > with pending changes these parts of my patch have to be dropped. > > This patch contains the following possible cleanups: >

Re: [2.6 patch] SCSI: possible cleanups

2005-03-01 Thread Christoph Hellwig
On Tue, Mar 01, 2005 at 09:40:48AM -0500, Luben Tuikov wrote: > On 03/01/05 03:14, Douglas Gilbert wrote: > >> - scsi_error.c: scsi_normalize_sense > > > > > >I introduced scsi_normalize_sense() recently, Christoph H. > >proposed it should be static but Luben Tuikov (aic7xxx > >maintainer) said he

[PATCH] put newly registered shrinkers at the tail of the list

2005-03-01 Thread Christoph Hellwig
This way we actually share dentries before inodes and thus mark more inodes reclaimable once we shake them. --- 1.240/mm/vmscan.c 2005-02-04 01:53:32 +01:00 +++ edited/mm/vmscan.c 2005-03-02 07:09:00 +01:00 @@ -137,7 +137,7 @@ struct shrinker *set_shrinker(int seeks, shrinker->

Re: cciss CSMI via sysfs for 2.6

2005-03-01 Thread Christoph Hellwig
On Fri, Feb 18, 2005 at 12:05:52PM -0800, Greg KH wrote: > On Fri, Feb 18, 2005 at 07:46:28PM +0000, Christoph Hellwig wrote: > > > /* > > > + * sysfs stuff > > > + * this should be moved to it's own file, maybe cciss_sysfs.h > > > + */ > > &

Re: [request for inclusion] Filesystem in Userspace

2005-03-02 Thread Christoph Hellwig
On Wed, Mar 02, 2005 at 07:17:13PM +0100, Miklos Szeredi wrote: > Hi Andrew! > > Do you have any objections to merging FUSE in mainline kernel? > > It's been in -mm for the 2.6.11 cycle, and the same code was released > a month ago as FUSE-2.2. So it should have received a fair amount of > testi

Re: RFD: Kernel release numbering

2005-03-02 Thread Christoph Hellwig
On Thu, Mar 03, 2005 at 12:59:20PM +1100, Neil Brown wrote: > I think there is a case for the "community" providing the most > "stable" kernel that it (reasonably) can without depending on > "distributions" to do that. The point is that it's happening anyway. See Andres' -as tree which is the bas

Re: RFD: Kernel release numbering

2005-03-03 Thread Christoph Hellwig
On Thu, Mar 03, 2005 at 08:41:02PM +0100, Krzysztof Halasa wrote: > > 2) After 2.6.11 release is out, there is no established process for > > "oh shit, 2.6.11 users will really want that fixed." > > We can do 2.6.11.x scheme. For the last stable kernel, of course > (i.e., one additional small patc

Re: ps2 keyboard filter hook

2001-06-16 Thread Christoph Hellwig
In article <[EMAIL PROTECTED]> you wrote: > One of these centuries we must replace the present keyboard > and console stuff, probably by something very similar to > Vojtech's input device stuff, and we must make sure that > the new code is powerful enough to last for a few years again. Why only s

Re: [ANNOUNCE] HotPlug CPU patch against 2.4.5

2001-06-16 Thread Christoph Hellwig
In article you wrote: > Hi all, > > http://sourceforge.net/projects/lhcs/ > > Version 0.3 (untested) of the HotPlug CPU Patch is out, with > ia64 and x86 support. Bringing CPUs down and up is as simple as: > > # Down... > echo 0 > /proc/sys/cpu/1 >

Re: Making a module 2.4 compatible

2001-06-25 Thread Christoph Hellwig
Hi Horst, In article <[EMAIL PROTECTED]> you wrote: > Seconded! There are a few users of iBCS around here, who _need_ the > functionality and don't get it with 2.4.x (in this case, Red Hat 7.1). Or > is there a replacement for it? Take a look at inux-abi: http://linux-abi.sourceforge.net ft

Re: problem building 2.4.6 pre 6 + freevxfs

2001-06-28 Thread Christoph Hellwig
Hi Giampaolo, In article <993718178.8885.0.camel@castle> you wrote: > gcc -D__KERNEL__ -I/u1/usr.src/linux/include -Wall -Wstrict-prototypes > -Wno-traphs -O2 -fomit-frame-pointer -fno-strict-aliasing -pipe > -mpreferred-stack-bdary=2 -march=i686-c -o vxfs_inode.o vxfs_inode.c > vxfs_inode.c

Re: [PATCH] cleanup virtual console <-> selection.c interface

2005-01-15 Thread Christoph Hellwig
On Sat, Jan 15, 2005 at 04:36:55AM +0100, Roman Zippel wrote: > I should really sent out my own patches faster. :) > I have three patches which take this a bit further and removes these > macros completely and does some other small cleanups. It saves a bit more > than 3KB. I was planning to do t

Re: Undefined symbols in 2.6.11-rc5-mm1

2005-03-05 Thread Christoph Hellwig
On Sat, Mar 05, 2005 at 10:19:23AM -0500, Kai Germaschewski wrote: > On Sat, 5 Mar 2005, Adrian Bunk wrote: > > > And this can break as soon as the "unused" object files contains > > EXPORT_SYMBOL's. > > > > Is it really worth it doing it in this non-intuitive way? > > I don't think it non-intu

Re: RFD: Kernel release numbering

2005-03-05 Thread Christoph Hellwig
On Fri, Mar 04, 2005 at 08:41:34PM +0100, Jesper Juhl wrote: > That's true. I guess my lack of trust in vendor kernels is part being > bitten by them in the past where my own custom build vanilla kernels have > worked fine, and part the fear of getting locked-in to some vendor > specific feature

Re: [PATCH] blockdev: fixes race between mount/umount

2005-03-05 Thread Christoph Hellwig
On Fri, Mar 04, 2005 at 03:04:45PM -0500, Jeffrey Mahoney wrote: > This patch fixes a race between mount and umount in set_blocksize. The results > can vary between buffer errors and infinite loops in __getblk_slow, and > possibly others. > > The patch makes set_blocksize run under the bdev_lock i

Re: [patch] inotify for 2.6.11

2005-03-05 Thread Christoph Hellwig
On Fri, Mar 04, 2005 at 01:37:24PM -0500, Robert Love wrote: > Below is inotify, diffed against 2.6.11. > > I greatly reworked much of the data structures and their interactions, > to lay the groundwork for sanitizing the locking. I then, I hope, > sanitized the locking. It looks right, I am hap

Re: Undefined symbols in 2.6.11-rc5-mm1

2005-03-05 Thread Christoph Hellwig
On Sat, Mar 05, 2005 at 11:36:23AM -0500, Kai Germaschewski wrote: > However, I spoke too soon. There actually is a legitimate use for > EXPORT_SYMBOL() in a lib-y object, e.g. lib/dump_stack.c. This provides a > default implementation for dump_stack(). Most archs provide their own > implementat

Re: [PATCH 2/29] FAT: Updated FAT attributes patch

2005-03-06 Thread Christoph Hellwig
On Sun, Mar 06, 2005 at 04:53:29PM +0100, Michael Geng wrote: > On Sun, Mar 06, 2005 at 03:42:28AM +0900, OGAWA Hirofumi wrote: > > +/* has used 0x72 ('r') in collision, so skip a few */ > > These ioctls in videotext.h have been removed with 2.6.11. They were not used > anywhere in the > kernel

Re: [2.6 patch] mm/{mmap,nommu}.c: several unexports

2005-03-06 Thread Christoph Hellwig
On Sun, Mar 06, 2005 at 03:43:19PM +0100, Adrian Bunk wrote: > I didn't find any possible modular usage in the kernel. > > These were there because we had core MM dunctionality duplicated in every security module. They definitly shouldn't be exported. - To unsubscribe from this list: send the l

Re: [2.6 patch] mm/swap_state.c: unexport swapper_space

2005-03-06 Thread Christoph Hellwig
On Sun, Mar 06, 2005 at 03:28:19PM +, Hugh Dickins wrote: > immediately on demand). It's used by the inline page_mapping() in > include/linux/mm.h, which _was_ used by various arch cacheflushing > inlines, which could reasonably be called from modular filesystems. > > I think those architectu

Re: [PATCH 23/29] FAT: Remove the multiple MSDOS_SB() call

2005-03-06 Thread Christoph Hellwig
On Sun, Mar 06, 2005 at 03:56:51AM +0900, OGAWA Hirofumi wrote: > > Since MSDOS_SB() is inline function, it increases text size at each calls. > I don't know whether there is __attribute__ for avoiding this. If you mark it pure the compile should be smart enough to optimize way multiple invocatio

Re: [PATCH 4/29] let fat handle MS_SYNCHRONOUS flag

2005-03-06 Thread Christoph Hellwig
> mark_buffer_dirty(bh); > + if (sb->s_flags & MS_SYNCHRONOUS) > + sync_dirty_buffer(bh); These three lines are duplicated a lot. I think you want a helper ala: static inline void fat_buffer_modified(struct super_block *sb, struct buff

Re: [patch] inotify for 2.6.11-mm1

2005-03-06 Thread Christoph Hellwig
> - if ((ret + (type == READ)) > 0) > - dnotify_parent(file->f_dentry, > - (type == READ) ? DN_ACCESS : DN_MODIFY); > + if ((ret + (type == READ)) > 0) { > + struct dentry *dentry = file->f_dentry; > + if (type == READ) > +

Re: [patch] inotify for 2.6.11

2005-03-06 Thread Christoph Hellwig
On Sat, Mar 05, 2005 at 07:40:06PM -0500, Robert Love wrote: > On Sun, 2005-03-06 at 00:04 +0000, Christoph Hellwig wrote: > > > The user interface is still bogus. > > I presume you are talking about the ioctl. I have tried to engage you > and others on what exactly you pr

Re: Atheros wi-fi card drivers (?)

2005-03-07 Thread Christoph Hellwig
On Mon, Mar 07, 2005 at 04:45:38PM +0100, Mateusz Berezecki wrote: > Hi list members, > > I've been doing some reverse engineering of madwifi HAL (Hardware > Abstraction Layer) object file recently. > I ended up with an almost complete source code for one chipset so far A different one than the

Re: [PATCH] [request for inclusion] Realtime LSM

2005-03-07 Thread Christoph Hellwig
On Mon, Mar 07, 2005 at 07:50:20PM -0800, Andrew Morton wrote: > > So I still have the rt-lsm patch floating about, saying "merge me, merge > me!". I'm not sure that the world would end were I to do so. > > Consider this a prod in the direction of those who were pushing > alternatives ;) It's s

Re: [PATCH] [request for inclusion] Realtime LSM

2005-03-07 Thread Christoph Hellwig
On Mon, Mar 07, 2005 at 08:28:21PM -0800, Andrew Morton wrote: > > please describe this "very simple and very real-world problem" in simple > > terms. Lets make sure "problem" and "solution" didnt become detached. > > > > Well others can do that better than I but I'd describe it as > > - Audio a

Re: [patch] inotify for 2.6.11-mm1, updated

2005-03-07 Thread Christoph Hellwig
> > this one seems totally unrelated. > > Eh? We did not add that. ;) Sorry, I thought I saw a + somewhere there at the beggining of the line, my fault. > > Should probably use the /dev/mem major. > > Hrm, should we? > > Also, the memory class stuff is all local to mem.c. For example, I > ca

Re: [PATCH] Restore PWC driver

2005-03-07 Thread Christoph Hellwig
On Mon, Mar 07, 2005 at 09:26:43PM -0800, Greg KH wrote: > Ick, Alan, couldn't you have had the decency to run this through the USB > developers, and at least pinged me on it? Especially due to all of the > hate-email I have gotten over this driver in the past. > > As it is, the coding style suck

Re: [PATCH] unified device list allocator

2005-03-07 Thread Christoph Hellwig
On Mon, Mar 07, 2005 at 09:33:02PM -0800, Andrew Morton wrote: > Matt Mackall <[EMAIL PROTECTED]> wrote: > > > > + /* search for insertion point in reverse for dynamic allocation */ > > + list_for_each_prev(l, list) { > > hrmph. Any time we do anything in O(n) time, some smarty comes along wi

Re: [PATCH] unified device list allocator

2005-03-07 Thread Christoph Hellwig
On Mon, Mar 07, 2005 at 09:50:35PM -0800, Andrew Morton wrote: > > register_blkdev only happens at module_init time (and in fact should go > > away completely, so I'm not happy wit hthe surgey to keep it barely alive > > at all) > > Is anyone working on that? I had a patch from a long time ago th

Re: [PATCH] unified device list allocator

2005-03-07 Thread Christoph Hellwig
On Mon, Mar 07, 2005 at 10:11:55PM -0800, Matt Mackall wrote: > > - when called with the major argument as 0 it returns an unused major > > number > >from the top of the old 255 entries major list. This should be replaced > >by a real dynamic dev_t allocator, similar to alloc_chrdev_regi

Re: [PATCH] [request for inclusion] Realtime LSM

2005-03-08 Thread Christoph Hellwig
On Tue, Mar 08, 2005 at 01:55:55PM -0500, Lee Revell wrote: > And as I mentioned a few times, the authors have neither the inclination > nor the ability to do that, because they are not kernel hackers. The > realtime LSM was written by users (not developers) of the kernel, to > solve a specific re

Re: [PATCH] resync ATI PCI idents into base kernel

2005-03-08 Thread Christoph Hellwig
On Tue, Mar 08, 2005 at 10:15:30AM +, Alan Cox wrote: > > Was there a reason you did this without using tabs, like the rest of the > > file? > > No but I'll send Linus an update to fix that now. > > > Again, the maintainer chain is well documented... > > Really - so does it go to the PCI mai

Re: 2.6.11-mm2

2005-03-08 Thread Christoph Hellwig
> +sh-merge-updates.patch > > sh/sh64 updates btw, it would be nice if you'd give a period of say 48 hours for people to review non-critical patches before sending them off to Linus. The sh update was pretty nice, so no coplaints about this one, but we had worse things passed on in the past. >

Re: Direct io on block device has performance regression on 2.6.x kernel - fix sync I/O path

2005-03-08 Thread Christoph Hellwig
> --- linux-2.6.9/drivers/char/raw.c2004-10-18 14:54:37.0 -0700 > +++ linux-2.6.9.ken/drivers/char/raw.c2005-03-08 17:22:07.0 > -0800 this is not the blockdevice, but the obsolete raw device driver. Please benchmark and if nessecary fix the blockdevice O_DIRECT codepa

Re: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

2005-03-09 Thread &#x27;Christoph Hellwig'
On Wed, Mar 09, 2005 at 09:43:47AM -0500, Bagalkote, Sreenivas wrote: > During the module load time, I allocate 32 bit or 64 bit SGLs based on > whether I can receive 64 bit DMA addresses or not. If size of dma_addr_t > is 4, then I allocate only 32 bit SGLs. During the run time, I prepare > 32/64

Re: [PATCH] resync ATI PCI idents into base kernel

2005-03-09 Thread Christoph Hellwig
On Wed, Mar 09, 2005 at 03:45:43PM +, Alan Cox wrote: > On Maw, 2005-03-08 at 22:33, Christoph Hellwig wrote: > > > Really - so does it go to the PCI maintainer, the IDE maintainer or the > > > DRI maintainer or someone else, or all of them, or in bits to different > &g

Re: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

2005-03-09 Thread &#x27;Christoph Hellwig'
On Wed, Mar 09, 2005 at 05:47:27PM -0500, Bagalkote, Sreenivas wrote: > > > >Even for kernels with a 64bit dma_addr_t you can get 32bit dma > >addresses > >only. As a start check whether the pci_set_dma_mask for the 64bit mask > >failed - in that case you can always use 32bit SGLs. > > > > Pleas

Re: [Linux-fbdev-devel] [announce 0/7] fbsplash - The Framebuffer Splash

2005-03-09 Thread Christoph Hellwig
On Wed, Mar 09, 2005 at 12:38:42PM +0100, Pavel Machek wrote: > Hi! > > > > Fbsplash - The Framebuffer Splash - is a feature that allows displaying > > > images in the background of consoles that use fbcon. The project is > > > partially descended from bootsplash. > > > > What are you trying to

Re: [06/11] [TCP]: Put back tcp_timer_bug_msg[] symbol export.

2005-03-10 Thread Christoph Hellwig
> --- a/net/ipv4/tcp_timer.c2005-03-09 17:20:38 -08:00 > +++ b/net/ipv4/tcp_timer.c2005-03-09 17:20:38 -08:00 > @@ -38,6 +38,7 @@ > > #ifdef TCP_DEBUG > const char tcp_timer_bug_msg[] = KERN_DEBUG "tcpbug: unknown timer value\n"; > +EXPORT_SYMBOL(tcp_timer_bug_msg); > #endif not compl

Re: Atrocious icache/dcache in 2.4.2

2001-04-27 Thread Christoph Hellwig
Hi Pete, In article <[EMAIL PROTECTED]> you wrote: > After a little thinking it seems apparent to me that it > may be a good thing to have VM taking pages from dentry and > inode pools directly. This sounds almost what slab does, > so let me speculate about it (it is a bad idea, but it is > inter

Re: [Lse-tech] Re: Linux 2.4 Scalability, Samba, and Netbench

2001-05-09 Thread Christoph Hellwig
On Wed, May 09, 2001 at 12:30:35PM -0500, Andrew M. Theurer wrote: > I do have kernprof ACG and lockmeter for a 4P run. We saw no > significant problems with lockmeter. csum_partial_copy_generic was the > highest % in profile, at 4.34%. I'll see if we can get some space on > http://lse.sourcefo

Re: Announcing Journaled File System (JFS) release 0.3.1 available

2001-05-09 Thread Christoph Hellwig
Hi Steve, On Wed, May 09, 2001 at 12:40:25PM -0500, Steve Best wrote: > Release 0.3.1 of JFS was made available today. > > Drop 31 on May 9, 2001 (jfs-0.3.1.tar.gz) includes fixes to the > file system and utilities. > > For more details about the problems fixed, please see the README. would it

Re: Linux 2.4.4-ac10

2001-05-17 Thread Christoph Hellwig
Hi Alan, In article <[EMAIL PROTECTED]> you wrote: > >ftp://ftp.linux.org.uk/pub/linux/alan/2.4-ac/ > Can't find it there (neither -ac9), but on the other hand it is on kernel.org... Christoph -- Of course it doesn't work. We've performed a software upgrade. - To unsubscri

Re: Linux-2.4.4 failure to compile

2001-05-17 Thread Christoph Hellwig
In article <[EMAIL PROTECTED]> you wrote: > "Richard B. Johnson" wrote: >> >> Hello; >> >> I downloaded linux-2.4.4. The basic kernel compiles but the aic7xxx >> SCSI module that I require on some machines, doesn't. > The aic7xxx assembler requiring libdb1 is a bungle. Getting the headers > fo

Re: megaraid driver (proposed patch)

2005-03-25 Thread Christoph Hellwig
On Fri, Mar 25, 2005 at 12:39:52PM -0600, James Bottomley wrote: > On Fri, 2005-03-25 at 19:22 +0100, Bruno Cornec wrote: > > Would you consider to apply the following patch proposed by Thierry > > Vignaud as a solution for the MandrakeSoft kernel in the mainstream 2.6 > > kernel ? > > Well, to b

Re: megaraid driver (proposed patch)

2005-03-25 Thread Christoph Hellwig
On Fri, Mar 25, 2005 at 01:04:37PM -0600, James Bottomley wrote: > You get a kernel with two drivers trying to claim some of the same set > of cards. The winner will be the driver that gets its init routines > called first, but this isn't a desirable outcome. > > I wouldn't object to a patch that

Re: [PATCH] - MPT FUSION - SPLITTING SCSI HOST DRIVERS

2005-03-26 Thread Christoph Hellwig
I took a quick look an a here's a few comments: - I don't think renaming mptscsih.c to mpt_core.c makes sense. the new name is confusing at best, and keeping the old name allows to keep SCCS history aswell. That means the new SPI stub driver should be called mptspi or something like tha

<    4   5   6   7   8   9   10   11   12   13   >