On Sat, Mar 05, 2005 at 07:40:06PM -0500, Robert Love wrote: > On Sun, 2005-03-06 at 00:04 +0000, Christoph Hellwig wrote: > > > The user interface is still bogus. > > I presume you are talking about the ioctl. I have tried to engage you > and others on what exactly you prefer instead. I have said that moving > to a write interface is fine but I don't see how ut is _any_ better than > the ioctl. Write is less typed, in fact, since we lose the command > versus argument delineation. > > But if it is a anonymous decision, I'll switch it. Or take patches. ;-) > It isn't a big deal.
See the review I sent. Write is exactly the right interface for that kind of thing. For comment vs argument either put the number first so we don't have the problem of finding a delinator that isn't a valid filename, or use '\0' as such. > > Also now version of it has stayed in -mm long enough because bad > > bugs pop up almost weekly. > > I don't follow this sentence. It means that every re3vision of inotify so far has been buggy in some respect and ig got dropped from -mm again and again. It should get some more testing there and not sent firectly for mainline. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
