Re: [patch] linux/ufs_fs.h: use __u64 for userspace

2008-01-01 Thread Christoph Hellwig
On Wed, Jan 02, 2008 at 04:02:42AM +0200, Adrian Bunk wrote: > But userspace anyway can't use them since it doesn't know what "uspi" > is, so you should better reduce the userspace visibility of this header. We had this come up before and the header should not be exported to userspace at all. It

Re: [patch] linux/ufs_fs.h: use __u64 for userspace

2008-01-02 Thread Christoph Hellwig
On Wed, Jan 02, 2008 at 12:04:44AM -0800, David Miller wrote: > From: Christoph Hellwig <[EMAIL PROTECTED]> > Date: Wed, 2 Jan 2008 07:50:33 + > > > The only non-kernel user of this known to me is silo, which should just > > have it's own header documenting

Re: WARNING: do not add new typedefs - is that for real?

2008-01-02 Thread Christoph Hellwig
On Tue, Jan 01, 2008 at 06:15:46PM +0200, Boaz Harrosh wrote: > I have this code: > > > /* > * osd-r10 4.12.5 Data-In and Data-Out buffer offsets > * byte offset = mantissa * (2^(exponent+8)) > */ > typedef __be32 osd_cdb_offset; Given that you can't do normal arithmetic on this type it shou

Re: [patch] scsi: revert "[SCSI] Get rid of scsi_cmnd->done"

2008-01-02 Thread Christoph Hellwig
On Wed, Jan 02, 2008 at 11:57:10AM -0800, Linus Torvalds wrote: > > > On Wed, 2 Jan 2008, Matthew Wilcox wrote: > > > > sd_done and sr_done are called for REQ_TYPE_FS -- if the request comes > > in through one of the SG interfaces, we call scsi_setup_blk_pc_cmnd() > > which sets the ->done callb

Re: getting rid of filp search in fs_may_remount_ro()

2008-01-02 Thread Christoph Hellwig
On Mon, Dec 31, 2007 at 11:54:26AM -0800, Dave Hansen wrote: > > Btw, I just noticed in current -mm fs_may_remount_ro() is still around > > and not replaced by ther per-sb writers count. That surely sounds like > > some kind of mismerge.. > > I was actually leaving that for later. Getting rid of

Re: getting rid of filp search in fs_may_remount_ro()

2008-01-02 Thread Christoph Hellwig
On Mon, Dec 31, 2007 at 02:54:48PM -0800, Dave Hansen wrote: > Here's one blatantly untested idea I have. The idea is to keep track if > anyone might be writing to a mnt. We keep track on a flag in the mnt. > When we set the flag, we increment a counter in the sb and decrement > when the flag is

Re: WARNING: do not add new typedefs - is that for real?

2008-01-02 Thread Christoph Hellwig
On Wed, Jan 02, 2008 at 02:18:27PM +0200, Boaz Harrosh wrote: > > But yes, this is one of the rare cases where a typedef makes sense, > > but ???'d call it osd_off_t or something like that. > > > > You mean osd_cdb_offset_t. I thought of dropping that _t, I hate it, > just a personal preference.

Re: [patch 2/3] CONFIG_HIGHPTE vs. sub-page page tables.

2008-01-02 Thread Christoph Hellwig
On Mon, Nov 12, 2007 at 03:30:11PM +0100, [EMAIL PROTECTED] wrote: > From: Martin Schwidefsky <[EMAIL PROTECTED]> > Solution: The only solution I found to this dilemma is a new typedef: > a pgtable_t. For s390 pgtable_t will be a (pte *) - to be introduced > with a later patch. For everybody else i

Re: Out of tree module using LSM

2007-11-28 Thread Christoph Hellwig
On Wed, Nov 28, 2007 at 12:42:52PM +, Tvrtko A. Ursulin wrote: > > Hi Linus, all, > > During one recent LKML discussion > (http://marc.info/?l=linux-kernel&m=119267398722085&w=2) about LSM going > static you called for LSM users to speak up. > > We here at Sophos (the fourth largest endpo

Re: Out of tree module using LSM

2007-11-28 Thread Christoph Hellwig
On Wed, Nov 28, 2007 at 08:38:43AM -0800, Casey Schaufler wrote: > Would you like to expound on that, or do you feel your claws > are sharp enough already? Just take a look at code. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTEC

Re: Out of tree module using LSM

2007-11-29 Thread Christoph Hellwig
On Thu, Nov 29, 2007 at 05:53:33PM +0100, Jan Engelhardt wrote: > >> But the problem is that this isn't just Samba, this is a countless > >> myriad of different applications. And if one of them doesn't support > >> on-access scanning, then the whole solution isn't worth using. > > > >Ok, which spec

Re: [PATCH x86/mm 08/11] x86 ia32 ptrace getreg/putreg merge

2007-11-29 Thread Christoph Hellwig
On Thu, Nov 29, 2007 at 04:00:31AM -0800, Roland McGrath wrote: > +#define R32(l,q) \ > + case offsetof(struct user32, regs.l): \ > + regs->q = value; break > + > +#define SEG32(rs)

Re: [PATCH x86/mm 4/6] x86-64 ptrace get/putreg current task

2007-11-29 Thread Christoph Hellwig
On Wed, Nov 28, 2007 at 04:41:18PM -0800, Roland McGrath wrote: > > This generalizes the getreg and putreg functions so they can be used on the > current task, as well as on a task stopped in TASK_TRACED and switched off. > This lays the groundwork to share this code for all kinds of user-mode > m

Re: [PATCH] xfs: revert to double-buffering readdir

2007-12-03 Thread Christoph Hellwig
On Fri, Nov 30, 2007 at 04:36:25PM -0600, Stephen Lord wrote: > Wow, was it really that long ago! > > Looks like the readdir is in the bowels of the btree code when filldir gets > called > here, there are probably locks on several buffers in the btree at this > point. This > will only show up for

Re: [PATCH] xfs: revert to double-buffering readdir

2007-12-03 Thread Christoph Hellwig
On Fri, Nov 30, 2007 at 06:22:09PM +1100, Timothy Shimmin wrote: > Hmmm, don't see the point of "eof" local var now. > Previously bhv_vop_readdir() returned eof. > I presume if we don't move the offset (offset == startoffset) then > we're done and break out? > So we lost eof when going to the filld

Re: overdue items in feature-removal-schedule

2007-12-03 Thread Christoph Hellwig
On Mon, Dec 03, 2007 at 11:58:07AM -0500, Erez Zadok wrote: > There are 29 listed items in feature-removal-schedule.txt. 11 of those have > dates or kernel versions that have passed, including this one: > > What: remove EXPORT_SYMBOL(kernel_thread) > When: August 2006 We still haven't managed to

Re: [0/4] DST: Distributed storage.

2007-12-04 Thread Christoph Hellwig
> > * fixed bug with XFS metadata update (it can provide slab pages to the > > DST, so it is not allowed to transfer them using ->sendpage()) xfs hasn't been doing that anymore for quite a while. Block drivers don't need hacks for it anymore, epsecially as it's not reliably detectable.

Re: [patch 1/2] Linux Kernel Markers - Support Multiple Probes

2007-12-04 Thread Christoph Hellwig
I think this is complete overkill. We should rather get one proper tracing infrastructure in tree instead of having multiple hacking ones in different places. Yes, please consider this a NACK ;-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [patch 2/2] Linux Kernel Markers - Create modpost file

2007-12-04 Thread Christoph Hellwig
On Tue, Dec 04, 2007 at 01:18:47PM -0500, Mathieu Desnoyers wrote: > This adds some new magic in the MODPOST phase for CONFIG_MARKERS. > Analogous to the Module.symvers file, the build will now write a > Module.markers file when CONFIG_MARKERS=y is set. This file lists > the name, defining module,

Re: [patch 2/2] Linux Kernel Markers - Create modpost file

2007-12-04 Thread Christoph Hellwig
On Tue, Dec 04, 2007 at 02:15:28PM -0500, Mathieu Desnoyers wrote: > Yup. What I would really like is to, at least, get the API stabilised > for 2.6.24. It that means extracting the API changes from the first > patch, I could do it. Then we would have plenty of time to discuss the > multiple probes

Re: 2.6.24-rc3-git1: Reported regressions from 2.6.23

2007-11-19 Thread Christoph Hellwig
On Mon, Nov 19, 2007 at 05:21:10PM -0500, J. Bruce Fields wrote: > On Mon, Nov 19, 2007 at 11:15:05PM +0100, Rafael J. Wysocki wrote: > > Subject : nfsd gets stuck when underlying filesystem is XFS > > Submitter : Christian Kujau <[EMAIL PROTECTED]> > > Chris Wedgwood <[

Re: [rfc 18/45] cpu alloc: XFS counters

2007-11-20 Thread Christoph Hellwig
On Mon, Nov 19, 2007 at 05:11:50PM -0800, [EMAIL PROTECTED] wrote: > Also remove the useless zeroing after allocation. Allocpercpu already > zeroed the objects. You still haven't answered my comment to the last iteration. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH 1/4] proc: fix NULL ->i_fop oops

2007-11-20 Thread Christoph Hellwig
On Tue, Nov 20, 2007 at 10:05:05AM -0500, Stephen Smalley wrote: > > Nice, getting rid of this is a very good step formwards. Unfortunately > > we have another copy of this junk in > > security/selinux/selinuxfs.c:sel_remove_entries() which would need the > > same treatment. > > Can't just be dro

Re: [patch 1/1] selinux: do not clear f_op when removing entries

2007-11-21 Thread Christoph Hellwig
On Wed, Nov 21, 2007 at 09:01:36AM -0500, Stephen Smalley wrote: > Do not clear f_op when removing entries since it isn't safe to do. If this is still safe for selinux I'm fine with it. It also gets rid of one of them few remaining s_files users which is always good. Btw, after this patch we sho

Re: [ANN] Squashfs 3.3 released

2007-11-21 Thread Christoph Hellwig
On Wed, Nov 21, 2007 at 02:02:43PM +, Phillip Lougher wrote: > Unfortunately the move to fixed little endian filesystem will involve > another filesystem layout change. The current filesystem layout still > uses packed bitfield structures, and it is impossible to swap these > using the stan

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-21 Thread Christoph Hellwig
On Wed, Nov 14, 2007 at 01:08:38PM -0500, J. Bruce Fields wrote: > > Personally I'd prefer it to only grow a struct stat or rather it's members > > But the nfsd code currently expects a dentry so this might require some > > major refactoring. > > Well, we need to check for mountpoints, for example

Re: [PATCH] Linux Kernel Markers - Support Multiple Probes

2007-11-22 Thread Christoph Hellwig
On Wed, Nov 21, 2007 at 10:41:26PM -0500, Mathieu Desnoyers wrote: > RCU style multiple probes support for the Linux Kernel Markers. Why would we want this? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-22 Thread Christoph Hellwig
On Thu, Nov 22, 2007 at 02:56:22PM +1100, Rusty Russell wrote: > This is an interesting idea, thanks for the code! My only question is > whether we can get most of this benefit by dropping the indirection of > namespaces and have something like "EXPORT_SYMBOL_TO(sym, modname)"? It > doesn't

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-22 Thread Christoph Hellwig
Very nice, looking forward to organize the exports mess a bit more. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-22 Thread Christoph Hellwig
On Thu, Nov 22, 2007 at 12:54:49PM +0100, Andi Kleen wrote: > On Thursday 22 November 2007 12:06, Christoph Hellwig wrote: > > Very nice, looking forward to organize the exports mess a bit more. > > I would need people to help me converting more subsystems to this new scheme. >

Re: [PATCH 6/9] Remove xfs_icluster

2007-11-23 Thread Christoph Hellwig
On Thu, Nov 22, 2007 at 11:39:52AM +1100, David Chinner wrote: > Remove the xfs_icluster structure and replace with a radix tree lookup. > > We don't need to keep a list of inodes in each cluster around anymore > as we can look them up quickly when we need to. The only time we need > to do this no

Re: [PATCH 5/9] Don't block pdflush when flushing inodes

2007-11-23 Thread Christoph Hellwig
> +++ 2.6.x-xfs-new/fs/xfs/xfs_inode.c 2007-11-22 10:33:51.037704348 +1100 > @@ -183,12 +183,20 @@ xfs_imap_to_bp( > int ni; > xfs_buf_t *bp; > > + if (buf_flags == 0) > + buf_flags = XFS_BUF_LOCK; There's just two caller and they never pass 0, so t

Re: [PATCH 9/9] Clean up open coded inode dirty checks

2007-11-23 Thread Christoph Hellwig
> +STATIC_INLINE int xfs_inode_clean(xfs_inode_t *ip) > +{ > + return (((ip->i_itemp == NULL) || > + !(ip->i_itemp->ili_format.ilf_fields & XFS_ILOG_ALL)) && > + (ip->i_update_core == 0)); > +} Can we please get rid of this useless STATIC_INLINE junk? It's really hurti

Re: [Cbe-oss-dev] [RFC/PATCH] Export force_sig_info

2007-11-23 Thread Christoph Hellwig
On Thu, Nov 22, 2007 at 11:41:41PM -0800, Andrew Morton wrote: > Perhaps export it from within a powerpc-specific C file (along with > suitable comment) to prevent people from generally relying upon the export? Yes, please. I don't like this beeing exported at all. - To unsubscribe from this lis

Re: [PATCH 4/9] Factor common inode cluster buffer lookup code

2007-11-23 Thread Christoph Hellwig
On Thu, Nov 22, 2007 at 11:36:42AM +1100, David Chinner wrote: > +STATIC int > +xfs_ino_to_imap( > + xfs_mount_t *mp, > + xfs_trans_t *tp, > + xfs_ino_t ino, > + xfs_imap_t *imap, > + uintimap_flags) > +{ > + int error; > + > +

Re: [PATCH 3/9] Use _META bio I/O types for metadata I/O

2007-11-23 Thread Christoph Hellwig
On Thu, Nov 22, 2007 at 11:35:12AM +1100, David Chinner wrote: > Improve metadata I/O merging in the elevator > > Change all async metadata buffers to use [READ|WRITE]_META I/O types > so that the I/O doesn't get issued immediately. This allows merging > of adjacent metadata requests but still pri

[PATCH] xfs: revert to double-buffering readdir

2007-11-25 Thread Christoph Hellwig
t's basically the 2.6.23 version minus the uio and vnops junk. I'll try to find something more optimal for 2.6.25 or at least find a way to use the proper version for local access. Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Index: linux-2.6/fs/xfs/l

Re: [PATCH 01/27] ptrace: arch_has_single_step

2007-11-25 Thread Christoph Hellwig
On Sun, Nov 25, 2007 at 01:55:07PM -0800, Roland McGrath wrote: > This defines the new macro arch_has_single_step() in linux/ptrace.h, a > default for when asm/ptrace.h does not define it. It declares the new > user_enable_single_step and user_disable_single_step functions. > This is not used yet,

Re: [PATCH 10/27] ptrace: generic resume

2007-11-25 Thread Christoph Hellwig
On Sun, Nov 25, 2007 at 02:01:09PM -0800, Roland McGrath wrote: > This makes ptrace_request handle all the ptrace requests that wake > up the traced task. These do low-level ptrace implementation magic > that is not arch-specific and should be kept out of arch code. The > implementations on each

Re: [PATCH 05/27] rename open_namei() to open_pathname()

2007-11-26 Thread Christoph Hellwig
On Thu, Nov 01, 2007 at 04:08:32PM -0700, Dave Hansen wrote: > > open_namei() no longer touches namei's. rename it > to something more appropriate: open_pathname(). The name is quite non-descriptive. What about just leaving it as filp_open and merging this into the previous patches to avoid the

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-27 Thread Christoph Hellwig
On Tue, Nov 27, 2007 at 08:43:24AM -0700, Jonathan Corbet wrote: > Might the recent discussion on the exporting of sys_open() and > sys_read() be an example here? There would appear to be a consensus > that people should not have used those functions, but they are now > proving difficult to unexpo

Re: [ANNOUNCE] Open-FCoE - Fibre Channel over Ethernet Project

2007-11-27 Thread Christoph Hellwig
I just did a very quick glance over the tree. Some extremly highlevel comments to start with before actually starting the source review: - why do you need your own libcrc? lib/crc32.c has a crc32_le - libsa should go. Much of it is just wrappers of kernel functions that should be used dir

Re: [patch 2/2] reiser4: new export ops

2007-11-28 Thread Christoph Hellwig
This code looks a little confusing to me.. > */ > static char *decode_inode(struct super_block *s, char *addr, > reiser4_object_on_wire * obj) > @@ -41,7 +42,8 @@ > fplug = file_plugin_by_disk_id(reiser4_get_tree(s), (d16 *) addr); > if (fplug != NULL) { >

Re: [PATCH 00/16] udf: cleanup

2008-01-11 Thread Christoph Hellwig
p://lkml.org/lkml/2008/1/5/211 [PATCH 0/7] udf: more cleanups > > I hope I addressed all comments sent by Christoph Hellwig and Jan Kara. > Thanks for review! The whole patch series looks fine to me. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

Re: [PATCH] serial: remove "too much work for irq" printk

2008-01-12 Thread Christoph Hellwig
On Sat, Jan 12, 2008 at 03:15:43PM -0500, Benjamin LaHaise wrote: > When using kvm with a serial console, the serial driver will print out > "too much work for irq4" on any heavy activity (ie vi on a file repainting > the terminal). This message is entirely spurious, as output continues to > wo

Re: Could not set non-blocking flag with 2.6.24-rc5

2008-01-12 Thread Christoph Hellwig
On Thu, Dec 13, 2007 at 09:16:01PM +0100, Tino Keitel wrote: > Hi folks, > > I often build Debian packages inside a chroot. Today I discovered a > failure during an "aptitude update", which is a command to download new > package lists for the package management. In strace, the lines around > the f

Re: [PATCH 3/6] NLM: Initialize completion variable in lockd_up

2008-01-13 Thread Christoph Hellwig
The patch hasn't actually been tested but I'm sure it will fix this issue. Btw, lockd() takes BKL just after starting up and only implicitly drops it when blocking. This seems very dangerous to me and badly wants updating to some real locking scheme.. Signed-off-by: Christoph Hellwig

Re: [PATCH] Fix kprobes on ia64

2008-01-13 Thread Christoph Hellwig
On Sun, Jan 13, 2008 at 07:24:24PM -0700, Matthew Wilcox wrote: > If CONFIG_KPROBES is set, we get the error during build: > > kernel/kprobes.c:1057: error: __ksymtab_jprobe_return causes a section > type conflict > > This is because ia64 defines a static inline jprobe_return which kprobes > atte

Re: [patch] block: fix blktrace timestamps

2008-01-14 Thread Christoph Hellwig
Folks, this is getting a little silly. Even if CONFIG_NO_HZ is new this is a an important regression, and yes we should avoid regressions wherever we can, and for such a quite important feature we should fix it. On the other hand blktrace is using the wrong interface, and it has been told multip

Re: [PATCH 3/6] NLM: Initialize completion variable in lockd_up

2008-01-14 Thread Christoph Hellwig
On Mon, Jan 14, 2008 at 09:24:54AM -0500, Jeff Layton wrote: > Thanks Christoph. I incorporated this into my latest patchset. It does > seem to fix the issue (tested by bouncing NFS up and down for 30 mins > or so). Let me know if you want me to add a signed-off-by line for > you... No need to add

Re: [CALL FOR TESTING] Make Ext3 fsck way faster [2.6.24-rc6 -mm patch]

2008-01-15 Thread Christoph Hellwig
On Tue, Jan 15, 2008 at 03:04:41AM -0800, Andrew Morton wrote: > I'm wondering about the real value of this change, really. > > In any decent environment, people will fsck their ext3 filesystems during > planned downtime, and the benefit of reducing that downtime from 6 > hours/machine to 2 hours/

Re: [CALL FOR TESTING] Make Ext3 fsck way faster [2.6.24-rc6 -mm patch]

2008-01-15 Thread Christoph Hellwig
On Tue, Jan 15, 2008 at 01:15:33PM +, Christoph Hellwig wrote: > They won't fsck in planned downtimes. They will have to use fsck when > the shit hits the fan and they need to. Not sure about ext3, but big > XFS user with a close tie to the US goverment were concerned about t

Re: [RFC/PATCH 4/8] revoke: core code V7

2008-01-15 Thread Christoph Hellwig
On Tue, Jan 15, 2008 at 04:14:54PM +0100, Peter Zijlstra wrote: > Humm, we were trying to get rid of file_list_lock(), this puts up > another user of the sb file list. > > Also, that loop looks horribly expensive: n*(1+m); where n is the list > size, and m the number of matching fds. > > Granted,

Re: [PATCH 1/2] Massive code cleanup of sys_msync()

2008-01-15 Thread Christoph Hellwig
On Tue, Jan 15, 2008 at 07:02:44PM +0300, Anton Salikhmetov wrote: > +++ b/mm/msync.c > @@ -1,24 +1,25 @@ > /* > * linux/mm/msync.c > * > + * The msync() system call. > * Copyright (C) 1994-1999 Linus Torvalds > + * > + * Massive code cleanup. > + * Copyright (C) 2008 Anton Salikhmetov <[

Re: [PATCH 2/2] Updating ctime and mtime at syncing

2008-01-15 Thread Christoph Hellwig
On Tue, Jan 15, 2008 at 07:02:45PM +0300, Anton Salikhmetov wrote: > +/* > + * Update the ctime and mtime stamps for memory-mapped block device files. > + */ > +static void bd_inode_update_time(struct inode *inode, struct timespec *ts) > +{ > + struct block_device *bdev = inode->i_bdev; > +

Re: [PATCH 1/2] Massive code cleanup of sys_msync()

2008-01-15 Thread Christoph Hellwig
On Tue, Jan 15, 2008 at 08:28:48PM +0100, Peter Zijlstra wrote: > Notice that error is already -EINVAL, so a simple goto should suffice. Yes, for the start of the function you can basically leave it as-is. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [Patch] document ext3 requirements (was Re: [RFD] Incremental fsck)

2008-01-16 Thread Christoph Hellwig
On Wed, Jan 16, 2008 at 08:43:25AM +1100, David Chinner wrote: > ext3 is not the only filesystem that will have trouble due to > volatile write caches. We see problems often enough with XFS > due to volatile write caches that it's in our FAQ: In fact it will hit every filesystem. A write-back cac

Re: [PATCH 04/27] kill filp_open()

2008-01-16 Thread Christoph Hellwig
On Wed, Jan 16, 2008 at 09:04:56AM -0800, Dave Hansen wrote: > > is using filp_open() and hence doesn't work very well. > > > > A shall revert dm-loop.patch and run away. > > This one's pretty easy, thank goodness. Just replace filp_open() with > open_namei(): > > /filp_open(/open_namei(A

Re: [PATCH 04/27] kill filp_open()

2008-01-16 Thread Christoph Hellwig
On Wed, Jan 16, 2008 at 09:41:12AM -0800, Dave Hansen wrote: > On Wed, 2008-01-16 at 17:10 +0000, Christoph Hellwig wrote: > > > > But ultimatively I think we should remove this silly renaming from > > the patch. It doesn't help the goal and just created churn, so pl

Re: [PATCH 2/3] Add GD-Rom support to the SEGA Dreamcast

2007-12-16 Thread Christoph Hellwig
On Sun, Dec 16, 2007 at 06:50:19PM +0900, Paul Mundt wrote: > > +static irqreturn_t gdrom_command_interrupt(int irq, void *dev_id) > > +{ > > + if (dev_id != &gd) > > + return IRQ_NONE; > > You aren't setting this up as a shared IRQ, so this shouldn't be > necessary. It's not nessecar

Re: [PATCH 3/7] SUNRPC: make new svc_create_kthread function

2007-12-18 Thread Christoph Hellwig
> +int > +svc_create_kthread(svc_thread_fn func, struct svc_rqst *rqstp) > +{ > + struct svc_serv *serv = rqstp->rq_server; > + struct task_struct *task; > + > + task = kthread_create((int (*)(void *)) func, rqstp, serv->sv_name); > + if (IS_ERR(task)) > + return PTR_ER

Re: [PATCH] x86: unify module_{32|64}.h

2007-12-18 Thread Christoph Hellwig
On Tue, Dec 18, 2007 at 04:04:30AM -0800, Harvey Harrison wrote: > +/* x86_32/64 are simple */ > +struct mod_arch_specific > +{ > +}; what about just /* x86 is simple */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: xfs mknod regression

2007-12-18 Thread Christoph Hellwig
for it is trivial: we can just remove the assignment because xfs_revalidate_inode has done the proper job before unlocking the inode. Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Index: linux-2.6-xfs/fs/xfs/linu

Re: [xfs-masters] [PATCH] XFS: don't expose sysv device encoding in inode->i_rdev

2007-12-19 Thread Christoph Hellwig
I've sent Dave a patch yesterday that fixes the problem in an even nicer way by just removing the assignment in xfs_vn_mknod because we're doing the proper translation deeper down in the stack. The patch should already be on it's way to Linus. -- To unsubscribe from this list: send the line "unsu

Re: [RFC] ext3 freeze feature

2008-01-26 Thread Christoph Hellwig
On Fri, Jan 25, 2008 at 09:42:30PM +0900, Takashi Sato wrote: > Hi, > > >I am also wondering whether we should have system call(s) for these: > > > >On Jan 25, 2008 12:59 PM, Takashi Sato <[EMAIL PROTECTED]> wrote: > >>+ case EXT3_IOC_FREEZE: { > > > >>+ case EXT3_IOC_THAW: { > > > >An

Re: [PATCH] unifdef linux/vt.h

2008-01-26 Thread Christoph Hellwig
On Fri, Jan 25, 2008 at 07:02:15PM +0100, Olaf Hering wrote: > > remove the newly added __KERNEL__ block from linux/vt.h > > Signed-off-by: Olaf Hering <[EMAIL PROTECTED]> We shouldn't add more unifdef-y headers. Please move the newly-added kernel-only section to a different file instead and be

Re: [PATCH] block: look up block device path in sysfs

2008-01-26 Thread Christoph Hellwig
On Fri, Jan 25, 2008 at 10:04:51PM -0700, Dan Williams wrote: > Given an fd on a block device, returns a string like > > /block/sda/sda1 > > which can be used to find related information in /sys. > > Ideally we should have an ioctl that works on char devices as well, > but that seems far f

Re: [patch] drop linux/ufs_fs.h from userspace export

2008-01-26 Thread Christoph Hellwig
On Sat, Jan 26, 2008 at 04:09:52AM -0500, Mike Frysinger wrote: > Per previous discussions about cleaning up ufs_fs.h, people just want this > straight up dropped from userspace export. The only remaining consumer (silo) > has been fixed a while ago to not rely on this header. Thanks! Care to mo

[PATCH] kill do_generic_mapping_read

2008-01-26 Thread Christoph Hellwig
the buffered read path. Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Index: linux-2.6/include/linux/fs.h === --- linux-2.6.orig/include/linux/fs.h 2008-01-26 20:56:55.0 +0100 +++ linux-2.6/include/linu

Re: [2.6 patch] unexport sys_{open,read}

2008-01-28 Thread Christoph Hellwig
On Tue, Jan 29, 2008 at 12:10:40AM +0200, Adrian Bunk wrote: > Now that they are unused we can finally unexport sys_{open,read}. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Linus. any reason this is not in? > > fs/open.c |1 - > fs/read_write.c |1 - > 2 files changed, 2

Re: [patch 1/1] uml-export-getgid-for-hostfs

2005-03-14 Thread Christoph Hellwig
> EXPORT_SYMBOL_PROTO(getuid); > +EXPORT_SYMBOL_PROTO(getgid); please don't. as mentioned in the discussion about ROOT_DEV the whole code using it is bogus. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo inf

Re: Exports to enable clock driver modules

2005-03-14 Thread Christoph Hellwig
On Mon, Mar 14, 2005 at 08:37:43PM -0800, Christoph Lameter wrote: > The following exports are necessary to allow loadable modules to define > new clocks. Without these the mmtimer driver cannot be build > correctly as a module (there is another mmtimer specific fix necessary to > get it to build

Re: [PATCH] Per cpu irq stat

2005-03-15 Thread Christoph Hellwig
On Mon, Mar 14, 2005 at 10:32:34PM -0800, Christoph Lameter wrote: > The definition of the irq_stat as an array means that the individual > elements of the irq_stat array are located on one NUMA node requiring > internode traffic to access irq_stat from other nodes. This patch makes > irq_stat a pe

Re: [PATCH] Xen/i386 cleanups - AGP bus/phys cleanups

2005-03-16 Thread Christoph Hellwig
On Wed, Mar 16, 2005 at 11:48:29AM +, Keir Fraser wrote: > This patch cleans up AGP driver treatment of bus/device memory. Every > use of virt_to_phys/phys_to_virt should properly be converting between > virtual and bus addresses: this distinction really matters for the Xen > hypervisor. It's

Re: [PATCH] Xen/i386 cleanups - AGP bus/phys cleanups

2005-03-16 Thread Christoph Hellwig
On Wed, Mar 16, 2005 at 10:01:07AM -0500, Rik van Riel wrote: > In the case of AGP, the AGPGART effectively _is_ the > IOMMU. Calculating the addresses right for programming > the AGPGART is probably worth fixing. Well, it's a half-assed one. And some systems have a real one. But the real probl

Re: [PATCH] Xen/i386 cleanups - AGP bus/phys cleanups

2005-03-16 Thread Christoph Hellwig
On Wed, Mar 16, 2005 at 06:35:28PM +, Keir Fraser wrote: > > On 16 Mar 2005, at 18:10, Christoph Hellwig wrote: > > >On Wed, Mar 16, 2005 at 10:01:07AM -0500, Rik van Riel wrote: > >>In the case of AGP, the AGPGART effectively _is_ the > >>IOMMU. Ca

Re: [PATCH] Xen/i386 cleanups - AGP bus/phys cleanups

2005-03-16 Thread Christoph Hellwig
On Wed, Mar 16, 2005 at 06:55:13PM -0500, Rik van Riel wrote: > Thing is, the rest of the kernel uses virt_to_phys for > two different things. Only one of them has to do with > the real physical address, the other is about getting > the page frame number. The latter usage has been converted to pa

Re: Building Areca arcmsr driver outside kernel source tree

2005-03-20 Thread Christoph Hellwig
On Sat, Mar 19, 2005 at 06:47:27PM +, Matt Dainty wrote: > To get the arcmsr driver working with CentOS/RHEL 4 and using the > facility to build kernel modules outside of the kernel source tree, I > found the attached patch was necessary to remove the dependencies on the > internal drivers/scsi

Re: [PATCH 529] M68k: Update signal delivery handling

2005-03-21 Thread Christoph Hellwig
On Mon, Mar 21, 2005 at 09:25:49PM +0100, Geert Uytterhoeven wrote: > M68k: Update signal delivery handling, which was broken by the removal of > notify_parent() in 2.6.9-rc2 After that patch the #ifndef HAVE_ARCH_GET_SIGNAL_TO_DELIVER in kernel/signal.c can go away now. - To unsubscribe from thi

Re: [6/9] [RFC] Steps to fixing the driver model locking

2005-03-22 Thread Christoph Hellwig
On Mon, Mar 21, 2005 at 12:48:47PM -0800, Patrick Mochel wrote: > > [EMAIL PROTECTED], 2005-03-21 11:45:16-08:00, [EMAIL PROTECTED] > [klist] Add initial implementation of klist helpers. > This klist interface provides a couple of structures that wrap around > struct list_head to provide ex

Re: [patch 03/12] uml: export getgid for hostfs

2005-03-22 Thread Christoph Hellwig
On Tue, Mar 22, 2005 at 05:21:23PM +0100, [EMAIL PROTECTED] wrote: > > Export this symbol which is not satisfied currently. The code using it has > been merged, so please export this symbol. and it's still bogus, and you haven't replied when I mentioned it last time. - To unsubscribe from this l

Re: [PATCH 2.6.11-rc2 09/09] ide: remove REQ_DRIVE_CMD handling

2005-02-05 Thread Christoph Hellwig
> - __REQ_DRIVE_CMD, > + __REQ_DRIVE_CMD,/* obsolete, unused anymore - tj */ dito - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH 2.6.11-rc2 06/09] ide: remove REQ_DRIVE_TASK handling

2005-02-05 Thread Christoph Hellwig
> __REQ_DRIVE_CMD, > - __REQ_DRIVE_TASK, > + __REQ_DRIVE_TASK, /* obsolete, unused anymore - tj */ please kill it completely - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vg

Re: [PATCH] Altix : ioc4 serial driver support

2005-02-07 Thread Christoph Hellwig
On Mon, Feb 07, 2005 at 09:58:33AM -0600, Patrick Gefre wrote: > Latest version with review mods: > ftp://oss.sgi.com/projects/sn2/sn2-update/033-ioc4-support - still not __iomem annotations. - still a ->remove method more comments (mostly nipicks I missed last time, nothing too exciting): +

Re: How to retrieve version from kernel source (the right way)?

2005-02-09 Thread Christoph Hellwig
On Wed, Feb 09, 2005 at 09:17:35AM +0100, Michael Renzmann wrote: > Hi all. > > (Please CC: me, I'm not subscribed - although I'm following the list > through gmane.org) > > I'm working on Madwifi (a driver for wireless lan cards with Atheros > chipset), which isn't part of the kernel (and prob

Re: 2.6.11-rc3-mm2

2005-02-10 Thread Christoph Hellwig
On Thu, Feb 10, 2005 at 02:35:08AM -0800, Andrew Morton wrote: > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11-rc3/2.6.11-rc3-mm2/ > > > - Added the mlock and !SCHED_OTHER Linux Security Module for the audio guys. > It seems that nothing else is going to come along

Re: [PATCH] Altix : ioc4 serial driver support

2005-02-10 Thread Christoph Hellwig
On Thu, Feb 10, 2005 at 11:09:43AM -0800, Jesse Barnes wrote: > On Tuesday, February 8, 2005 8:52 am, Patrick Gefre wrote: > > I've update the patch with changes from the comments below. > > > > ftp://oss.sgi.com/projects/sn2/sn2-update/033-ioc4-support > > >

Re: 2.6.11-rc3-mm2

2005-02-11 Thread Christoph Hellwig
On Fri, Feb 11, 2005 at 09:14:22AM +0100, Ingo Molnar wrote: > an "RT priorities rlimit" is still not adequate as a desktop solution, > because it still allows the box to be locked up. Also, if it turns out > to be a mistake then it's already codified into the ABI, while RT-LSM is > much less 'pers

Re: [PATCH] device-mapper: multipath round-robin path selector.

2005-02-11 Thread Christoph Hellwig
> +#include "dm.h" > +#include "dm-path-selector.h" > + > +#include private after public again. Also it kinda looks to me like dm headers pull in far too much kernel headers? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]

Re: [PATCH] device-mapper: multipath

2005-02-11 Thread Christoph Hellwig
> +#include "dm.h" > +#include "dm-path-selector.h" > +#include "dm-bio-list.h" > +#include "dm-bio-record.h" > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include Always include private headers after public ones. > +MODULE_DESCRI

Re: [PATCH] device-mapper: multipath hardware handler for EMC

2005-02-11 Thread Christoph Hellwig
> +/* Code borrowed from dm-lsi-rdac by Mike Christie */ Any reason that module isn't submitted? > + bio->bi_bdev = path->dev->bdev; > + bio->bi_sector = 0; > + bio->bi_private = path; > + bio->bi_end_io = emc_endio; > + > + page = alloc_page(GFP_ATOMIC); > + if (!page) {

Re: [PATCH] device-mapper: multipath

2005-02-11 Thread Christoph Hellwig
On Fri, Feb 11, 2005 at 01:36:32PM -0800, Andrew Morton wrote: > Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > > > +EXPORT_SYMBOL(dm_register_path_selector); > > > +EXPORT_SYMBOL(dm_unregister_path_selector); > > > > I though we agree

Re: avoiding pci_disable_device()...

2005-02-14 Thread Christoph Hellwig
On Mon, Feb 14, 2005 at 11:43:02AM +0100, Michal Rokos wrote: > Hello, > > > Currently, in almost every PCI driver, if pci_request_regions() fails -- > > indicating another driver is using the hardware -- then > > pci_disable_device() is called on the error path, disabling a device > > that ano

Re: [patch] add scsi changer driver

2005-02-15 Thread Christoph Hellwig
[this should go to linux-scsi] > +#include not needed. > +#include I doubt you'll need this one. > +#include > + > +#include /* here are all the ioctls */ should always go before > +#define MAJOR_NR SCSI_CHANGER_MAJOR please kill this one > +#include "scsi.h"

Re: [PATCH] 2.6.10 patch to export kallsyms_lookup_name()

2005-02-18 Thread Christoph Hellwig
On Fri, Feb 18, 2005 at 10:29:08AM -0800, Badari Pulavarty wrote: > Hi, > > Trivial patch to export kallsyms_lookup_name() for > kprobe/jprobe module use. > > Please apply. > > (BTW, I personally don't care if it should be > EXPORT_SYMBOL_GPL or EXPORT_SYMBOL). Certainly should be _GPL. And w

Re: cciss CSMI via sysfs for 2.6

2005-02-18 Thread Christoph Hellwig
> /* > + * sysfs stuff > + * this should be moved to it's own file, maybe cciss_sysfs.h > + */ > + > +static ssize_t cciss_firmver_show(struct device *dev, char *buf) > +{ > + ctlr_info_t *h = dev->driver_data; > +return sprintf(buf,"%c%c%c%c\n", h->firm_ver[0], h->firm_ver[1], > +

Re: make flock_lock_file_wait static

2005-01-26 Thread Christoph Hellwig
> o vfs_follow_link(): used to interpret symbolic links, which > might point outside of SAN Filesystem. This one is going away very soon, including the whole old-style ->follow_link support - for technical reasons. Please convert your driver to put the contents of the symlink into ... a

Re: make flock_lock_file_wait static

2005-01-26 Thread Christoph Hellwig
On Wed, Jan 26, 2005 at 09:51:31AM +, Al Viro wrote: > On Wed, Jan 26, 2005 at 09:43:08AM +0000, Christoph Hellwig wrote: > > > o vfs_follow_link(): used to interpret symbolic links, which > > > might point outside of SAN Filesystem. > > > > This one is go

Re: 2.6.11-rc2-mm1: SuperIO scx200 breakage

2005-01-26 Thread Christoph Hellwig
On Wed, Jan 26, 2005 at 01:35:56AM +0300, Evgeniy Polyakov wrote: > I have one rule - if noone answers that it means noone objects, > or it is not interesting for anyone, and thus noone objects. That's simply not true. The amount of patches submitted is extremly huge and the reviewers don't have

Re: [PATCH] Documentation updates

2005-01-26 Thread Christoph Hellwig
On Wed, Jan 26, 2005 at 11:56:21AM +0100, Martin Waitz wrote: > hoi :) > > I have created some updates to the Linux documentation. > > This includes two important fixes that allow to generate DocBook > documenation from kernel-doc comments again and some low-priority > updates to the kernel-doc c

<    3   4   5   6   7   8   9   10   11   12   >