On Wed, Nov 28, 2012 at 10:14:33AM +1100, Dave Chinner wrote:
> From: Dave Chinner
>
> Several subsystems use the same construct for LRU lists - a list
> head, a spin lock and and item count. They also use exactly the same
> code for adding and removing items from the LRU. Create a generic
> type
> + if (!xfs_dqflock_nowait(dqp))
> + xfs_dqunlock(dqp);
> + goto out_miss_busy;
This seems to miss braces.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://v
On Thu, Mar 21, 2013 at 12:32:52PM +0100, Jan Kara wrote:
> On Wed 20-03-13 22:07:18, Tejun Heo wrote:
> > Hello, Dave.
> >
> > On Thu, Mar 21, 2013 at 12:57:21PM +1100, Dave Chinner wrote:
> > > When you have a system that has 50+ active filesystems (pretty
> > > common in the distributed storage
I'd suspect it's something with the actual radix tree code, Ccing
linux-mm in case they know more.
On Mon, Aug 27, 2012 at 11:00:10AM -0400, Justin Piszcz wrote:
> Hi,
>
> Moving ~276GB of files (mainly large backups) and everything has
> seemed to lockup on the client moving data to the server,
On Tue, Sep 04, 2012 at 06:17:47PM +0800, Li Wang wrote:
> For file system created on file-backed loop device, there will be two-levels
> of
> page cache present, which typically doubles the memory consumption.
And the right fix is to not use buffer I/O on the backing file instead
of hacks like
After the release of Linux 3.5 in July, August saw the big XFS merge for
the Linux 3.6 merge window. In the meantime the XFS tree has seen low
activity, with refined support for SEEK_HOLE/SEEK_DATA that takes unwritten
extents into account as the main feature. A couple of fixes also went in
and m
On Wed, Jan 30, 2008 at 02:41:34PM +0300, Denis V. Lunev wrote:
> The pid of the locking daemon can be substituted with a task struct
> without a problem. Namely, the value if filled in the context of the lockd
> thread and used in lockd_up/lockd_down.
>
> It is possible to save task struct instea
On Mon, Feb 04, 2008 at 06:04:10PM +0100, Miklos Szeredi wrote:
> a_ops->perform_write() was left out from Nick Piggin's new a_ops
> patchset, as it was non-essential, and postponed for later inclusion.
>
> This short series reintroduces it, but only adds the fuse
> implementation and not simple_p
On Mon, Feb 04, 2008 at 09:52:06PM +0100, Miklos Szeredi wrote:
> Moving up to higher layers might not be possible, due to lock/unlock
> of i_mutex being inside generic_file_aio_write().
Well some bits can be moved up. Here's my grand plan which I plan
to implement once I get some time for it (or
> +#define AUDIT_TYPE_UNKNOWN 0 /* we don't know yet */
> +#define AUDIT_TYPE_NORMAL1 /* a "normal" audit record */
I don't care about tab vs space after the #define, but at least be
consistent.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" i
On Mon, Oct 01, 2012 at 08:16:11PM -0400, Jeff Layton wrote:
> In some cases, we were passing in NULL even when we have a dentry.
>
> Reported-by: Eric Paris
> Signed-off-by: Jeff Layton
> ---
> kernel/auditsc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kerne
On Mon, Oct 01, 2012 at 08:16:12PM -0400, Jeff Layton wrote:
> If name is NULL then the condition in the loop will never be true. Also,
> with this change, we can eliminate the check for n->name == NULL since
> the equivalence check will never be true if it is.
Given that name == NULL is a static
On Tue, Oct 02, 2012 at 01:16:44PM -0700, Nicholas A. Bellinger wrote:
> * Optionally allow fd_buffered_io=1 to be enabled for people
> * who want use the fs buffer cache as an WriteCache mechanism.
> *
> * This means that in event of a hard failure, there is a r
On Tue, Oct 23, 2012 at 01:54:48AM -0700, Joel Becker wrote:
> On Sat, Oct 20, 2012 at 02:19:00PM +0200, Marco Stornelli wrote:
> > Removed vmtruncate
> >
> > Signed-off-by: Marco Stornelli
>
> Acked-by: Joel Becker
>
> Do you want me to pull this, or are you going to send it with your set?
I
On Mon, Oct 22, 2012 at 10:15:00AM -0500, Dave Kleikamp wrote:
> This is the current version of the patchset I presented at the LSF-MM
> Summit in San Francisco in April. I apologize for letting it go so
> long before re-submitting.
>
> This patchset was begun by Zach Brown and was originally subm
On Thu, Oct 18, 2012 at 07:33:45PM +0200, Yann E. MORIN wrote:
> Some systems (eg. Cygwin, FreeBSD) are missing the CIRCLEQ macros.
> They were removed in Y2000 from FreeBSD:
> http://svnweb.freebsd.org/base?view=revision&revision=70469
>
> The reason was that TAILQ are perfectly capable of do
On Sat, Oct 20, 2012 at 02:17:33PM +0200, Marco Stornelli wrote:
> Removed vmtruncate
>
> Signed-off-by: Marco Stornelli
As Al pointed out we probably shouldn't even allow truncate on procfs.
Can look into refusing it instead, please?
--
To unsubscribe from this list: send the line "unsubscribe
[skipping the populate_rootfs discussion as it seems you have a better
handle on that than me]
On Sun, Feb 10, 2008 at 12:58:09PM +0100, Eric Piel wrote:
> >And while we're at it the file reading thing in there is utter crap
> >aswell. You really should be using the firmware loader which works
>
On Fri, Feb 08, 2008 at 02:26:41PM -0800, Dave Hansen wrote:
> This is against current Linus git
> (a4ffc0a0b240a29cbe489f6db9dae112a49ef1c1).
>
> This rolls up all the -mm bugfixes that were accumulated, and
> addresses some new review comments from Al. Also contains some
> reworking from hch an
On Tue, Feb 12, 2008 at 07:35:22PM +0200, Boaz Harrosh wrote:
>
> The patch: "gdth: switch to modern scsi host registration"
>
> missed one simple fact when moving a way from scsi_module.c.
> That is to call scsi_scan_host() on the probed host.
> With this the gdth driver from 2.6.24 is again abl
On Mon, Feb 11, 2008 at 04:14:52PM +0530, Ananth N Mavinakayanahalli wrote:
> The following series of patches create and populate the toplevel tests/
> directory. This will henceforth be the place where all in-kernel tests
> live.
>
> All patches against 2.6.25-rc1 and are just code movement witho
On Tue, Feb 12, 2008 at 03:35:57PM -0800, David Miller wrote:
> What XFS does is really unfortunate, let's learn from it's
> mistake.
I'd rather say what Sun did with their disklabels was rather unfortunate :)
But yeah, new filesystem should cater for it's braindamage because it
doesn't have any k
On Tue, Feb 12, 2008 at 12:50:51PM -0800, Greg KH wrote:
> I can run the numbers, but almost every one of those changes has at
> least 2 signed-off-by: on them, so they should all be being reviewed
> properly.
Good joke..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
On Tue, Feb 12, 2008 at 09:45:15PM -0800, Paul Menage wrote:
> From: Paul Menage <[EMAIL PROTECTED]>
>
> Add a new mount() flag, MS_BIND_FLAGS.
>
> MS_BIND_FLAGS indicates that a bind mount should take its per-mount flags
> from the arguments passed to mount() rather than from the source
> mountpoi
On Wed, Feb 13, 2008 at 11:03:45AM -0600, James Bottomley wrote:
> > I don't understand please explain.
> > What does a driver need to do if it needs a consistent shutdown retine?
> > module or built in? unload or shutdown?
>
> It needs to register a reboot notifier, which gdth does.
Well, for c
On Wed, Feb 13, 2008 at 12:06:21AM +0100, [EMAIL PROTECTED] wrote:
> From: Marcin Slusarz <[EMAIL PROTECTED]>
>
> replace all:
> big/little_endian_variable =
> cpu_to_[bl]eX([bl]eX_to_cpu(big/little_endian_variable) +
> expression_in_cpu_byteorder);
> with:
>
On Tue, Feb 12, 2008 at 06:56:50PM -0500, Mathieu Desnoyers wrote:
> Update spufs to the new linux kernel markers API, which supports connecting
> more than one probe to a single marker.
Compiles and works for me. But saying I like the odd API would be lying.
--
To unsubscribe from this list: se
On Thu, Feb 14, 2008 at 10:24:43AM -0800, Arjan van de Ven wrote:
> Bill Davidsen wrote:
> >Note that because the hardware is old, it's highly likely that most of
> >it will be retired before that sk98lin driver needs a change. I can't
> >see anyone using sk98lin on a new system, so it would be l
On Thu, Feb 14, 2008 at 10:21:03PM -0800, Andrew Morton wrote:
> Linus has just merged all the VFS renaming patches, so the decks
> are clear for looking at this work.
>
> However David and Christoph are beavering away on the r-o-bind-mounts
> patches and I expect that there will be overlaps with
On Fri, Feb 15, 2008 at 01:09:51AM -0800, Andrew Morton wrote:
> > > However David and Christoph are beavering away on the r-o-bind-mounts
> > > patches and I expect that there will be overlaps with unprivileged mounts.
> > >
> > > Could we coordinate things a bit please? Decide who goes first, r
On Fri, Feb 15, 2008 at 05:11:19PM -0800, Andrew Morton wrote:
> > It would be nice if an initial patch which introduces the new
> > functionality you need for r/o bind mounts could get introduced into
> > mainline *first*, and then people could add patches that call
> > mnt_want_write(), et. al in
On Thu, Feb 14, 2008 at 02:04:37AM -0500, Christoph Hellwig wrote:
> > diff --git a/fs/sysv/sysv.h b/fs/sysv/sysv.h
> > index 42d51d1..38ebe3f 100644
> > --- a/fs/sysv/sysv.h
> > +++ b/fs/sysv/sysv.h
> > @@ -217,9 +217,9 @@ static inline __fs32 fs32_add(struct sys
On Fri, Feb 15, 2008 at 08:51:15PM +0900, Takashi Sato wrote:
> So XFS_IOC_FREEZE and XFS_IOC_THAW cannot be lifted to generic code simply.
> I think we should create new generic numbers for freeze and thaw
Actually we've lifted specific ioctls to the generic layer before all
the time in drivers.
Looks good, Dave has actually sent it a tidbit earlier as part
of his series with fixes for 3.7-rc
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Ple
On Mon, Jul 30, 2012 at 09:31:06AM +0200, Paolo Bonzini wrote:
> You only need to add REQ_FLUSH support. The virtio-blk protocol does
> not support REQ_FUA, because there's no easy way to do it in userspace.
A bio-based driver needs to handle both REQ_FLUSH and REQ_FUA as it does
not get the sequ
On Mon, Jul 30, 2012 at 12:43:12PM +0800, Asias He wrote:
> I think we can add REQ_FLUSH & REQ_FUA support to bio path and that
> deserves another patch.
Adding it is a requirement for merging the code.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a m
On Mon, Jul 30, 2012 at 11:25:51AM +0930, Rusty Russell wrote:
> I consider this approach a half-way step. Quick attempts on my laptop
> and I couldn't find a case where the bio path was a loss, but in theory
> if the host wasn't doing any reordering and it was a slow device, you'd
> want the gues
, though.
> > From: Dave Chinner
> >
> > Signed-off-by: Dave Chinner
Looks good,
Reviewed-by: Christoph Hellwig
And I agree that vmap needs to be fixed to pass through the gfp flags
ASAP.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
September saw the release of Linux 3.6 which included a slightly smaller
than usual XFS update:
51 files changed, 2607 insertions(+), 2455 deletions(-)
The bulk of the changes in Linux 3.6 is made up by native support for
discontinuous buffers, with various minor bug fixes and cleanups making up
On Mon, Sep 30, 2013 at 03:25:47PM +0200, Bartlomiej Zolnierkiewicz wrote:
> This is not a SCSI host driver so remove SCSI subsystem specific
> includes.
The sad thing is that it is a driver for a device speaking SCSI, but for
some reason that was never discussed it is written to the block layer.
On Wed, Oct 02, 2013 at 04:27:57PM +0200, Jan Kara wrote:
> Provide a wrapper for get_user_pages() which takes care of acquiring and
> releasing mmap_sem. Using this function reduces amount of places in
> which we deal with mmap_sem.
>
> Signed-off-by: Jan Kara
Seem like this should be the defau
On Wed, Oct 02, 2013 at 11:56:23AM -0400, Kevin Mulvey wrote:
> replace all kerneli with kernel
kerneli is correct in this case.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.ker
The current version of "percpu_counter: make APIs irq safe" in the blk-mq
tree doesn't properly restore irqs, thus causing the boot of the blk-multique
tree to fail with various irqs_disabled() BUGs and related issues.
Signed-off-by: Christoph Hellwig
diff --git a/lib/per
On Sat, Jul 20, 2013 at 09:48:28AM -0500, Mike Christie wrote:
> What about the attached only compile tested patch. The patch has the mq
> block code work like the non mq code for bio cleanups.
>
>
> blk-mq: blk-mq should free bios in pass through case
>
> For non mq calls, the block layer will
On Fri, Oct 04, 2013 at 03:53:51AM +0100, Al Viro wrote:
> Speaking of those two - I really want to see file_table.c one killed.
> Christoph, do you have anything along the lines of getting rid of the
> mark_files_ro() nonsense? After all, a combination of r/w vfsmount
> and a superblock with MS_R
The current version of "percpu_counter: make APIs irq safe" in the blk-mq
tree doesn't properly restore irqs, thus causing the boot of the blk-multique
tree to fail with various irqs_disabled() BUGs and related issues.
Signed-off-by: Christoph Hellwig
---
lib/percpu_counter.c |
ff-by: Christoph Hellwig
---
block/blk-core.c |3 ---
block/blk-exec.c |7 ---
include/linux/blkdev.h |2 --
3 files changed, 12 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index f80df88..5620e58 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -
Consumers of the block layer shouldn't have to care if a driver uses
blk-mq or not, so make blk_get/put_request call the mq equivalents
underneath.
Signed-off-by: Christoph Hellwig
---
block/blk-core.c | 31 ---
block/blk
There is no need to reinvent blk_execute_rq for blk-mq if we can easily
reuse the sync and async versions already present.
Signed-off-by: Christoph Hellwig
---
block/blk-exec.c |7 +++
block/blk-mq.c | 36
drivers/block
The first two patches make blk-mq work fine again for me in a KVM VM,
the others make sure that consumers don't have to care if the underlying queue
uses blk-mq or not and remove some code at the same time.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a
off-by: Christoph Hellwig
---
block/blk-flush.c |2 +-
block/blk-mq.c| 14 ++
block/blk-mq.h|1 +
3 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/block/blk-flush.c b/block/blk-flush.c
index 3e4cc9c..c56c37d 100644
--- a/block/blk-flush.c
+++ b/block/
That patch looks fine to me. Having the s_readonly_remount infrastructure
around certainly makes things easier.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-i
On Fri, Oct 04, 2013 at 12:39:33PM -0500, Mike Christie wrote:
> Sorry, messed up function name. I meant blk_end_request*.
>
> For blk_execute_rq_nowait/blk_execute_rq and normal request use, the
> lower levels free the bios as they are completed by one of the
> blk_finish_request* calls. The call
On Sat, Oct 05, 2013 at 10:21:21AM -0400, Theodore Ts'o wrote:
> add_device_randomness() is called from __dev_open() and
> dev_set_mac_address() in net/core/dev.c. This is above the ethernet
> and infiniband level. So as long as it looks like a Linux network
> device, and they are setting the har
On Sat, Oct 05, 2013 at 03:20:05PM -0500, Mike Christie wrote:
> The functions take in requests as the argument, but they end up
> operating on bios too. The scsi layer does
> scsi_io_completion->scsi_end_request-> blk_end_request ->
> blk_end_bidi_request -> blk_update_bidi_request -> blk_update_r
It can be merged into the only caller, and doing so allows accounting for
I/O completion in the correct place as well.
Signed-off-by: Christoph Hellwig
---
block/blk-mq.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index
Make sure we set bio errors correctly and don't complete bios midway
through a flush sequence. Largely copied from the old I/O path.
Signed-off-by: Christoph Hellwig
---
block/blk-mq.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/block/blk-m
Patch 1 makes sure bios are completed more carefully, fixing the regression
with the earlier patch from Mike as well as a few issues found during code
inspection. Patches 2 and 3 are a split up and better documented version
of "blk-mq: blk-mq should free bios in pass through case", and the last tw
From: Mike Christie
Complete bios for all requests going through blk_mq_complete_request.
This mirrors the old I/O path and avoids blk-mq special casing in every
->end_io handler.
[hch: split up and reworded the changelog]
Signed-off-by: Mike Christie
Signed-off-by: Christoph Hell
From: Mike Christie
These are fundamentally different operations, so keep them separate.
[hch: split up and reworded the changelog]
Signed-off-by: Mike Christie
Signed-off-by: Christoph Hellwig
---
block/blk-flush.c |1 +
block/blk-mq.c|5 +++--
2 files changed, 4 insertions
Remove dead code and a dead argument.
Signed-off-by: Christoph Hellwig
---
block/blk-mq.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 99a600e..2b85029 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -857,15
which can go
away again as soon as we remove old-school request_fn based drivers.
Signed-off-by: Christoph Hellwig
---
block/blk-core.c | 29 -
block/blk-mq.c | 81 -
include/linux/blk-mq.h |4 +-
include/linux
The only caller of blk_mq_start_stopped_hw_queues is in irq context,
leading to lockdep splat when it actually gets called. Fix this by
deferring the hw queue run to workqueue context.
Signed-off-by: Christoph Hellwig
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 2b85029..923e9e1 100644
On Fri, Sep 13, 2013 at 01:27:12PM +0200, Gerd Hoffmann wrote:
> Simplifies locking, we'll protect the list with the device spin lock.
> Also plugs races which can happen when two devices operate on the
> global list.
>
> While being at it rename the list head from "list" to "work", preparing
> fo
On Thu, Sep 05, 2013 at 11:08:29AM +0200, Geert Uytterhoeven wrote:
> ERROR: "flush_ptrace_access" [drivers/staging/lustre/lustre/libcfs/libcfs.ko]
> undefined!
This seems to be more copy_to_user_page fallout, so instead of all these
arch patches we should figure out why lustre absolutely wants to
On Fri, Sep 06, 2013 at 05:56:13AM -0700, Christoph Hellwig wrote:
> On Thu, Sep 05, 2013 at 11:08:29AM +0200, Geert Uytterhoeven wrote:
> > ERROR: "flush_ptrace_access"
> > [drivers/staging/lustre/lustre/libcfs/libcfs.ko]
> > undefined!
>
> This seems to
On Sun, Sep 08, 2013 at 06:59:45PM -0700, Greg Kroah-Hartman wrote:
> Can't we just export the functions for those arches? Surely lutre
> isn't the first/only driver that needs this?
Lustre is. These are core mm helpers, and lustre uses them to
reimplement another core VM function. It then uses
> Modules linked in: oracleacfs(P)(U) oracleadvm(P)(U) oracleoks(P)(U)
Please reproduce without this weird crap loaded.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/m
.
Signed-off-by: Christoph Hellwig
diff --git a/Documentation/filesystems/porting
b/Documentation/filesystems/porting
index 206a1bd..f089058 100644
--- a/Documentation/filesystems/porting
+++ b/Documentation/filesystems/porting
@@ -451,3 +451,7 @@ in your dentry operations instead.
--
[mandatory
On Wed, Sep 11, 2013 at 01:14:11AM +0800, Peng Tao wrote:
> The problem is access_process_vm() is not exported since certain
> version of kernel including the latest. According to Christoph in the
> other mail, access_process_vm() is also a core mm function that is not
> supposed to be exported. Th
On Wed, Sep 11, 2013 at 10:51:50AM +0800, Peng Tao wrote:
> I'm not fighting against removing the piece of code. But if there is a
> strong reason to keep the functionality, we need to find a way to
> implement it. The convenience of using environment variables is that
> job scheduler can set the e
On Sun, Oct 06, 2013 at 12:10:13PM -0600, Jens Axboe wrote:
> Thanks, applied. Might not be a bad idea to just mimic the run queue
> API, and provide a blk_mq_start_hw_queue(hctx, is_async) instead.
I have to see I really don't like this is_async, I'd much preper to
untangle those into separate ve
On Tue, Oct 08, 2013 at 10:43:07AM +1100, Dave Chinner wrote:
> > Maybe, writeboost should disable deferring barriers
> > if barrier_deadline_ms parameter is especially 0.
> > Linux kernel's layered architecture is obviously not always perfect
> > so there are similar cases in other boundaries
> >
On Tue, Oct 08, 2013 at 02:38:18PM +0200, Christian Ruppert wrote:
> The symbols splice_to_pipe, splice_grow_spd and splice_shrink_spd are not
> currently exported from the kernel. This prevents the implementation of
> drivers using splice in modules not statically linked with the kernel. This
> pa
On Tue, Oct 08, 2013 at 01:36:17PM +0200, Richard Weinberger wrote:
> Both arguments are unused, remove them.
And with the get_signal macro left as the only caller, that one should
become the implementation function.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the
> What is the criteria for patches to include in your tree? I would suggest
> to consider this one https://lkml.org/lkml/2013/8/9/90 if it fits.
For this one you probably want to send a patch to Jens to move blk-mq-tag.h
to include/linux first instead of doing the relative include hack.
Also the
This is also the preferred way to do it for XFS. Maybe word it in a way
that we can easily add subsystems.
To me it generally seems to be the best way to do it - having random Ccs
and lots of stable trees doesn't seem like a very good way of handling
it.
--
To unsubscribe from this list: send th
On Mon, Sep 23, 2013 at 01:34:05PM -0700, Joe Perches wrote:
> Maybe adding a mechanism to MAINTAINERS would be better.
> Maybe a default B: (backport?) of sta...@vger.kernel.org
> with a per-subsystem override?
Sounds fine to me.
--
To unsubscribe from this list: send the line "unsubscribe linux
by: Lubomir Rintel
Looks good.
Signed-off-by: Christoph Hellwig
Al, can you add this to the next VFS pile?
> ---
> fs/sysv/super.c |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/fs/sysv/super.c b/fs/sysv/super.c
> index d0c6a00..eda1095 100644
>
On Wed, Sep 18, 2013 at 09:33:04AM +0200, Gerd Hoffmann wrote:
> > > While being at it rename the list head from "list" to "work", preparing
> > > for the addition of a second list.
> >
> > Why do you even the list?
>
> The list was already there when I took over maintainance ...
>
> > What woul
Just curious, what's the state of the remaining immutable bio work?
On Thu, Aug 08, 2013 at 02:15:29PM -0700, Kent Overstreet wrote:
> > What is preventing you from sending those out as well? While it's not
> > absolutely nessecary it would certainly be good if we'd avoid a struct
> > bio size re
On Tue, Sep 24, 2013 at 09:20:14AM -0400, Mike Snitzer wrote:
> Have you been over the patchset? Looks sane to you?
I looked over it, although I didn't dig into the details of all driver
patches, and I like what I see. As said in the previous mail I'd love
to see the patches to shrink struct bio
On Fri, Sep 07, 2012 at 05:30:31PM +0200, Paolo Bonzini wrote:
> Here are the fixes for zero-length commands, that ultimately let
> all command go through normal processing, even if they have
> zero length.
>
> The first patch is for PSCSI, the others are for IBLOCK and friends.
> I tried to order
On Fri, Nov 30, 2012 at 01:49:10PM +1100, Dave Chinner wrote:
> > Ugh. That's a big violation of how buffer-heads are supposed to work:
> > the block number is very much defined to be in multiples of b_size
> > (see for example "submit_bh()" that turns it into a sector number).
> >
> > But you're
On Sat, Dec 01, 2012 at 09:40:41AM +1100, Dave Chinner wrote:
> So it was based on this interface?
Based on that. I had dropped the inode operation as it's not really
a generic operation but a callback for either the buffered I/O code
or direct I/O and should be treated as such. I've also split
On Sun, Oct 21, 2012 at 01:07:31PM +1000, Dave Airlie wrote:
> Why couldn't this script just be a wrapper around qemu
It can be. Here is my ususual one:
#!/bin/sh
/opt/qemu/bin/qemu-system-x86_64 \
-m 1500 \
-enable-kvm \
-drive if=none,file=/home/hch/qemu-root.img,cache
On Wed, Dec 05, 2012 at 07:45:39AM -0800, Linus Torvalds wrote:
> On Wed, Dec 5, 2012 at 2:48 AM, Martin Steigerwald
> wrote:
> >
> > Linus, while I am interested in an answer I think that Dave and Christoph
> > as Linux filesystem developers actually deserve one (instead of silently
> > being ig
On Thu, Dec 06, 2012 at 12:14:02PM +1100, Dave Chinner wrote:
> On Wed, Dec 05, 2012 at 10:25:17AM -0800, Linus Torvalds wrote:
> > Yes, people can argue that "process" is about technical issues too,
> > but let's be honest: our process is fluid. Not everything gets
> > reviewed on the mailing list
On Thu, Dec 06, 2012 at 10:26:28PM +0400, Pavel Shilovsky wrote:
> Network filesystems CIFS, SMB2.0, SMB3.0 and NFSv4 have such flags - this
> change can benefit cifs and nfs modules. While this change is ok for network
> filesystems, itsn't not targeted for local filesystems due security problem
On Fri, Dec 07, 2012 at 11:42:55AM +1100, Dave Chinner wrote:
> The problem wth doing this is that the sync can delay the freeze
> process by quite some time under the exact conditions you describe.
> If you want freeze to take effect immediately (i.e instantly stop
> new modifications), then addin
> + if (flags[0] & 0x08)
> + cmd->se_cmd_flags |= SCF_WRITE_SAME_DISCARD;
I don't like this flag at all. We can still simply check the CDB
during ->execute_cmd and avoid this redundant flag.
Except for that bit the changes look fine, but should not be a patch
on their own. Witho
On Thu, Nov 08, 2012 at 08:07:17PM +, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger
>
> This patch adds a new max_write_same_len device attribute for use with
> WRITE_SAME w/ UNMAP=0 backend emulation.
>
> Also, update block limits VPD emulation code in spc_emulate_evpd_b0() to
> s
> + /*
> + * Enable WRITE_SAME emulation for IBLOCK, use scsi_debug.c default
> + */
Why would we care what scsi_debug.c uses?
> + dev->dev_attrib.max_write_same_len = 0x;
>
> if (blk_queue_nonrot(q))
> dev->dev_attrib.is_nonrot = 1;
> @@ -375,22 +379,8
On Tue, Nov 06, 2012 at 07:06:42AM -0500, J. Bruce Fields wrote:
> On Tue, Nov 06, 2012 at 02:14:50PM +0400, Stanislav Kinsbursky wrote:
> > 09.10.2012 23:35, J. Bruce Fields ??:
> > >Cc'ing Eric since I seem to recall he suggested doing it this way?
> > >
> > >Seems OK to me, but maybe tha
On Tue, Nov 06, 2012 at 08:07:06AM -0500, J. Bruce Fields wrote:
> So you're worried that a bug in the nfs code could modify the root and
> then not restore it?
At least the link you pointed to earlier never sets it back. Instead
of messing with it I'd rather have the sunrpc code use vfs_path_loo
On Sun, Dec 30, 2012 at 02:16:50AM +0300, Sergei Trofimovich wrote:
> It fixes boot panic when trying to boot from btrfs filesystem.
> kernel tries to mount as xfs and gets fatal -EUCLEAN:
>
> [0.17] VFS: Cannot open root device "ubda" or unknown-block(98,0):
> error -117
> [0.17]
NAK, we went through great trouble to get rid of the nasty layering
violation where the VM called file_update_time directly just a short
while ago, reintroducing that is a massive step back.
Make sure whatever "solution" for your problem you come up with keeps
the file update in the filesystem or
On Thu, Nov 15, 2012 at 11:29:46AM -0800, Nicholas A. Bellinger wrote:
> Well at least for the latter that is because UNMAP=0 does not have a
> payload. ;)
UNMAP=0 does have a payload, we just ignore it. In fact I was told
that targets should check for a completely zeroed sector sized payload
fo
ange that is likely to be NAKed. A long-term
> subsystem maintainer should know better than to push changes in this
> manner.
Agreed, this needs to be reverted.
Reviewed-by: Christoph Hellwig
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the
Having RCU for modification mostly workloads never is a good idea, so
I don't think it makes sense to mention it here.
If you care about the overhead it's worth trying to use per-cpu lists,
though.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message
1 - 100 of 14595 matches
Mail list logo
