[GIT PULL] Btrfs #2 for 3.16

2014-06-13 Thread Chris Mason
Hi Linus, Please pull my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus This has a few fixes since our last pull and a new ioctl for doing btree searches from userland. It's very similar to the existing ioctl, but lets us return larger items bac

[GIT PULL] Btrfs

2014-01-30 Thread Chris Mason
Btrfs: skip merge part for delayed data refs (+7/-0) Btrfs: introduce a head ref rbtree (+99/-60) Chris Mason (3) commits (+64/-32): Btrfs: setup inode location during btrfs_init_inode_locked (+9/-9) Btrfs: don't use ram_bytes for uncompressed inline items (+52/-22) Btrfs: fi

Re: [GIT PULL] Btrfs

2014-02-03 Thread Chris Mason
On Mon 03 Feb 2014 12:54:05 PM EST, David Sterba wrote: On Thu, Jan 30, 2014 at 04:52:54PM -0500, Chris Mason wrote: Chris Mason (3) commits (+64/-32): Btrfs: setup inode location during btrfs_init_inode_locked (+9/-9) Btrfs: don't use ram_bytes for uncompressed inline items (+5

[GIT PULL] Btrfs

2014-02-04 Thread Chris Mason
Hi Linus, Please pull my for-linus: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Filipe is fixing compile and boot problems with our crc32c rework, and Josef has disabled snapshot aware defrag for now. As the number of snapshots increases, we're hitting OOM. F

Re: [GIT PULL] Btrfs

2014-02-04 Thread Chris Mason
On 02/04/2014 02:50 PM, Greg KH wrote: On Mon, Feb 03, 2014 at 01:18:40PM -0500, Chris Mason wrote: On Mon 03 Feb 2014 12:54:05 PM EST, David Sterba wrote: On Thu, Jan 30, 2014 at 04:52:54PM -0500, Chris Mason wrote: Chris Mason (3) commits (+64/-32): Btrfs: setup inode location during

[GIT PULL] Btrfs

2013-11-14 Thread Chris Mason
Hi Linus, Please pull my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus This is our usual merge window set of bug fixes, performance improvements and cleanups. Miao Xie has some really nice optimizations for writeback. Josef also expanded our sa

Re: [GIT PULL] Btrfs

2013-11-15 Thread Chris Mason
Quoting Heiko Carstens (2013-11-15 06:32:16) > On Thu, Nov 14, 2013 at 12:19:52PM -0500, Chris Mason wrote: > > Hi Linus, > > > > Please pull my for-linus branch: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git > > for-linus

Re: [GIT PULL] Btrfs

2013-11-15 Thread Chris Mason
Quoting Chris Mason (2013-11-15 07:21:31) > Quoting Heiko Carstens (2013-11-15 06:32:16) > > On Thu, Nov 14, 2013 at 12:19:52PM -0500, Chris Mason wrote: > > > Hi Linus, > > > > > > Please pull my for-linus branch: > > > > > > git://git.ker

[GIT PULL] Btrfs

2013-11-15 Thread Chris Mason
Hi Linus, This pull fixes the empty_zero_page bug that Heiko reported, and includes one more cleanup from Al Viro. Please grab my for-linus: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Chris Mason (1) commits (+7/-2): btrfs: fix empty_zero_page misusage

Re: [btrfs] BUG: unable to handle kernel NULL pointer dereference at 0000000000000038

2014-02-07 Thread Chris Mason
On Fri 07 Feb 2014 07:10:38 AM EST, Fengguang Wu wrote: On Fri, Feb 07, 2014 at 02:13:59AM -0800, David Rientjes wrote: On Fri, 7 Feb 2014, Fengguang Wu wrote: [1.625020] BTRFS: selftest: Running btrfs_split_item tests [1.627004] BTRFS: selftest: Running find delalloc tests [2.2891

[GIT PULL] Btrfs

2014-02-09 Thread Chris Mason
Hi Linus, Please pull my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus This is a small collection of fixes Josef Bacik (2) commits (+4/-5): Btrfs: don't loop forever if we can't run because of the tree mod log (+1/-0) Btrfs: fix assert

[GIT PULL] Btrfs Maintainer update

2013-12-04 Thread Chris Mason
entry for Josef as well. Instead of diffstat etc, I've put the patch below. The commit is also signed, my updated key should be floating around the pgp servers now. commit c0778e2534b81be6b85b5ee07c0e15ff774f7136 Author: Chris Mason Date: Tue Dec 3 20:16:03 2013 -0500 Btrfs:

Re: [GIT PULL] Btrfs Maintainer update

2013-12-05 Thread Chris Mason
Quoting Linus Torvalds (2013-12-05 12:53:26) > On Wed, Dec 4, 2013 at 9:53 AM, Chris Mason wrote: > > > > Instead of diffstat etc, I've put the patch below. The commit is also > > signed, my updated key should be floating around the pgp servers now. > > You&#

Re: 1be41b78: +18% increased btrfs write throughput

2014-01-03 Thread Chris Mason
On Fri, 2014-01-03 at 23:54 +0800, fengguang...@intel.com wrote: > Hi Josef, > > FYI. We are doing 0day performance tests and happen to notice that > btrfs write throughput increased considerably during v3.10-11 time > frame: > > v3.10 v3.11 v3.

Re: [RFC v2 2/2] fs: btrfs: Extends btrfs/raid56 to support up to six parities

2014-01-06 Thread Chris Mason
On Mon, 2014-01-06 at 10:31 +0100, Andrea Mazzoleni wrote: > This patch changes btrfs/raid56.c to use the new raid interface and > extends its support to an arbitrary number of parities. > > More in details, the two faila/failb failure indexes are now replaced > with a fail[] vector that keeps tra

[GIT PULL] Btrfs for rc3

2014-08-26 Thread Chris Mason
n inserting overlap extent map. (+5/-6) Wang Shilong (2) commits (+4/-1): Btrfs: fix wrong write range for filemap_fdatawrite_range() (+2/-1) Btrfs: fix wrong extent mapping for DirectIO (+2/-0) Chris Mason (1) commits (+9/-1): Btrfs: fix filemap_flush call in btrfs_file_relea

Re: [btrfs] 8d875f95: xfstests.generic.226.fail

2014-08-19 Thread Chris Mason
On 08/19/2014 10:23 AM, David Sterba wrote: > On Tue, Aug 19, 2014 at 07:58:20PM +0800, Fengguang Wu wrote: >> We noticed an xfstests failure on commit >> >> 8d875f95da43c6a8f18f77869f2ef26e9594fecc ("btrfs: disable strict file >> flushes for renames and truncates") >> >> It's 100% reproducible in

Re: [btrfs] 8d875f95: xfstests.generic.226.fail

2014-08-20 Thread Chris Mason
On 08/20/2014 06:52 AM, Miao Xie wrote: > On Tue, 19 Aug 2014 10:58:09 -0400, Chris Mason wrote: >> On 08/19/2014 10:23 AM, David Sterba wrote: >>> On Tue, Aug 19, 2014 at 07:58:20PM +0800, Fengguang Wu wrote: >>>> We noticed

[PATCH] Btrfs: fix filemap_flush call in btrfs_file_release

2014-08-20 Thread Chris Mason
We should only be flushing on close if the file was flagged as needing it during truncate. I broke this with my ordered data vs transaction commit deadlock fix. Thanks to Miao Xie for catching this. Signed-off-by: Chris Mason Reported-by: Miao Xie Reported-by: Fengguang Wu diff --git a/fs

Re: btrfs BUG() in __set_extent_bit on GFP_ATOMIC failure.

2014-08-08 Thread Chris Mason
On 08/08/2014 12:26 AM, Dave Jones wrote: > While playing with fault injection, I hit this quite easily. > > kernel BUG at fs/btrfs/extent_io.c:990! > invalid opcode: [#1] PREEMPT SMP DEBUG_PAGEALLOC > CPU: 1 PID: 1270 Comm: fsx Not tainted 3.16.0+ #41 > task: 88023fe46d60 ti: 8802405

Re: [PATCH] Btrfs: Fix memory corruption by ulist_add_merge() on 32bit arch

2014-08-12 Thread Chris Mason
On 08/06/2014 11:14 AM, Takashi Iwai wrote: >>> >>> I meant that I don't care how you do it, if you want to do it the simple way >>> first and then send the cleanup later thats fine by me. Thanks, >> >> Ah, misunderstood. Then please disregard my v2 patches and take just >> v1 patch. It's even

Re: linux-next: new stuff in the btrfs tree

2014-08-13 Thread Chris Mason
On 08/13/2014 08:07 PM, Stephen Rothwell wrote: > Hi all, > > Are all the commits just added to the btrfs tree really intended for > v3.17? If not then please remove them until after v3.17-rc1 is > released. If so, then they are very late :-( > > I suspect the latter because some of them seem t

[GIT PULL] Btrfs

2014-08-14 Thread Chris Mason
: use IS_ALIGNED() for assertion in btrfs_lookup_csums_range() for simplicity (+2/-2) btrfs: label should not contain return char (+12/-3) chandan (1) commits (+1/-2): Btrfs: fill_holes: Fix slot number passed to hole_mergeable() call. HIMANGI SARAOGI (1) commits (+2/-2): Btrfs: use BUG_ON Chris Mas

Re: [GIT PULL] Btrfs

2014-08-14 Thread Chris Mason
On 08/14/2014 02:10 PM, Linus Torvalds wrote: > On Thu, Aug 14, 2014 at 11:59 AM, Chris Mason wrote: >> Hi Linus, >> >> Please pull my for-linus branch: > > Yeah, I think this will be for the next merge window. > > This clearly got rebased today. At the end of

[GIT PULL] Smaller btrfs pull

2014-08-15 Thread Chris Mason
for the rest of the rcs. These are all in my for-linus2 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus2 Chris Mason (1) commits (+6/-267): btrfs: disable strict file flushes for renames and truncates David Sterba (1) commits (+45/-6): btrfs:

Re: [GIT PULL] Smaller btrfs pull

2014-08-16 Thread Chris Mason
On 08/16/2014 11:11 AM, Linus Torvalds wrote: > On Fri, Aug 15, 2014 at 11:26 AM, Chris Mason wrote: >> >> I've been running xfstests with these against your current git >> overnight, but I'm queueing up longer tests as well. I understand >> you may want t

Re: Work Queue for btrfs compression writes

2014-08-04 Thread Chris Mason
On 07/29/2014 11:54 PM, Nick Krause wrote: > Hey Guys , > I am new to reading and writing kernel code.I got interested in > writing code for btrfs as it seems to > need more work then other file systems and this seems other then > drivers, a good use of time on my part. > I interested in helpin

Re: btrfs extents related oops.

2014-08-05 Thread Chris Mason
On 08/04/2014 09:57 PM, Dave Jones wrote: > On Mon, Aug 04, 2014 at 09:28:45PM -0400, Dave Jones wrote: > > Possibly related to some changes I've been making to my fuzz tester today > > to operate on the same file from multiple threads. > > This was on v3.16-829-g98959948a7ba, but probably exist

Re: btrfs extents related oops.

2014-08-05 Thread Chris Mason
On 08/05/2014 09:47 AM, Chris Mason wrote: > On 08/04/2014 09:57 PM, Dave Jones wrote: >> On Mon, Aug 04, 2014 at 09:28:45PM -0400, Dave Jones wrote: >> > Possibly related to some changes I've been making to my fuzz tester today >> > to operate on the same file f

[GIT PULL] Btrfs fixes

2014-11-01 Thread Chris Mason
Hi Linus, We have a few fixes in my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Filipe is nailing down some problems with our skinny extent variation, and Dave's patch fixes endian problems in the new super block checks. Filipe Manana (2) com

Re: btrfs: kernel BUG at fs/btrfs/extent_io.c:676!

2014-10-13 Thread Chris Mason
On Sun, Oct 12, 2014 at 10:15 PM, Sasha Levin wrote: Ping? This BUG_ON()ing due to GFP_ATOMIC allocation failure is really silly :( Agreed, I have a patch for this in testing. It didn't make my first pull but I'll get it fixed up. -chris -- To unsubscribe from this list: send the line

[GIT PULL] Btrfs corruption fix

2014-10-16 Thread Chris Mason
o cover it. Please pull: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Chris Mason (1) commits (+33/-36): Revert "Btrfs: race free update of commit root for ro snapshots" Total: (1) commits (+33/-36) fs/btrfs/inode.c | 36 --

Re: [PATCH v5] Move BTRFS RCU string to common library

2014-11-07 Thread Chris Mason
On Fri, Nov 7, 2014 at 3:17 PM, Omar Sandoval wrote: The RCU-friendly string API used internally by BTRFS is generic enough for common use. This doesn't add any new functionality, but instead just moves the code and documents the existing API. Reviewed-by: Josh Triplett Acked-by: Paul E.

[GIT PULL] Btrfs

2014-11-08 Thread Chris Mason
Hi Linus, Please pull my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus It's a one liner for an error cleanup path that leads to crashes. Chris Mason (1) commits (+1/-1): Btrfs: fix kfree on list_head in btrfs_lookup_csums_range

Re: [PATCH block/for-linus] block: export bio_associate_*() and wbc_account_io()

2015-07-23 Thread Chris Mason
On Thu, Jul 23, 2015 at 02:27:09PM -0400, Tejun Heo wrote: > bio_associate_blkcg(), bio_associate_current() and wbc_account_io() > are used to implement cgroup writeback support for filesystems and > thus need to be exported. Export them. Thanks, these were the only three I needed on the btrfs si

Re: [Ksummit-discuss] [CORE TOPIC] lightweight per-cpu locks / restartable sequences

2015-07-09 Thread Chris Mason
On Thu, Jul 09, 2015 at 11:32:45AM -0700, Andy Lutomirski wrote: > Several people have suggested that Linux should provide users with a > lightweight mechanism that allows light-weight fancy per-cpu > operations. This could be used to implement free lists or counters > without any barriers or atom

Re: [PATCH 2/2] ubifs: Allow O_DIRECT

2015-08-24 Thread Chris Mason
On Tue, Aug 25, 2015 at 09:46:11AM +1000, Dave Chinner wrote: > On Mon, Aug 24, 2015 at 01:19:24PM -0400, Jeff Moyer wrote: > > Brian Norris writes: > > > > > On Mon, Aug 24, 2015 at 10:13:25AM +0300, Artem Bityutskiy wrote: > > >> Now, some user-space fails when direct I/O is not supported. > >

Re: [PATCH 2/2] ubifs: Allow O_DIRECT

2015-08-25 Thread Chris Mason
On Tue, Aug 25, 2015 at 10:00:58AM -0400, Jeff Moyer wrote: > Dave Chinner writes: > > > On Mon, Aug 24, 2015 at 01:19:24PM -0400, Jeff Moyer wrote: > >> Brian Norris writes: > >> > >> > On Mon, Aug 24, 2015 at 10:13:25AM +0300, Artem Bityutskiy wrote: > >> >> Now, some user-space fails when di

[GIT PULL] Btrfs

2015-08-08 Thread Chris Mason
Hi Linus, We have a btrfs quota regression fix in my for-linus-4.2 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.2 I merged this one on Thursday and have run it through tests against current master. Normally I wouldn't have sent this while you were fin

Re: [RFC -v2 7/8] btrfs: Prevent from early transaction abort

2015-08-18 Thread Chris Mason
On Tue, Aug 18, 2015 at 12:40:32PM +0200, Michal Hocko wrote: > From: Michal Hocko > > Btrfs relies on GFP_NOFS allocation when commiting the transaction but > since "mm: page_alloc: do not lock up GFP_NOFS allocations upon OOM" > those allocations are allowed to fail which can lead to a pre-matu

Re: [PATCH 0/2] btrfs: fortification for GFP_NOFS allocations

2015-08-19 Thread Chris Mason
On Wed, Aug 19, 2015 at 02:17:39PM +0200, mho...@kernel.org wrote: > Hi, > these two patches were sent as a part of a larger RFC which aims at > allowing GFP_NOFS allocations to fail to help sort out memory reclaim > issues bound to the current behavior > (http://marc.info/?l=linux-mm&m=14387683061

[GIT PULL] Btrfs

2015-07-17 Thread Chris Mason
Hi Linus, We have some fixes in my for-linus-4.2 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.2 These are all from Filipe, and cover a few problems we've had reported on the list recently (along with ones he found on his own). Filipe Manana (5) commit

Re: sched: tweak select_idle_sibling to look for idle threads

2016-05-02 Thread Chris Mason
On Mon, May 02, 2016 at 04:58:17PM +0200, Peter Zijlstra wrote: > On Mon, May 02, 2016 at 04:50:04PM +0200, Mike Galbraith wrote: > > Oh btw, did you know single socket boxen have no sd_busy? That doesn't > > look right. > > I suspected; didn't bother looking at yet. The 'problem' is that the LLC

Re: sched: tweak select_idle_sibling to look for idle threads

2016-05-05 Thread Chris Mason
On Thu, May 05, 2016 at 11:33:38AM +0200, Peter Zijlstra wrote: > On Wed, May 04, 2016 at 01:46:16PM -0400, Chris Mason wrote: > > It should, make sure you're at the top commit in git. > > > > git://git.kernel.org/pub/scm/linux/kernel/git/mason/schbench.git > >

Re: sched: tweak select_idle_sibling to look for idle threads

2016-05-06 Thread Chris Mason
On Fri, May 06, 2016 at 09:12:51AM +0200, Peter Zijlstra wrote: > ontent-Length: 973 > > On Thu, May 05, 2016 at 09:58:44AM -0400, Chris Mason wrote: > > > I'll try and have a prod at the program itself if you have no pending > > > changes on your end. &

Re: [RFC][PATCH 0/7] sched: select_idle_siblings rewrite

2016-05-09 Thread Chris Mason
On Mon, May 09, 2016 at 12:48:07PM +0200, Peter Zijlstra wrote: > Hai, > > here be a semi coherent patch series for the recent select_idle_siblings() > tinkering. Happy benchmarking.. Thanks Peter, I'll have some production numbers tomorrow, but based on schbench I'm hoping it'll score better th

Re: [PATCHSET v5] Make background writeback great again for the first time

2016-05-03 Thread Chris Mason
On Tue, May 03, 2016 at 02:17:19PM +0200, Jan Kara wrote: > On Thu 28-04-16 12:46:41, Jens Axboe wrote: > > >>- rwb->wb_max = 1 + ((depth - 1) >> min(31U, rwb->scale_step)); > > >>- rwb->wb_normal = (rwb->wb_max + 1) / 2; > > >>- rwb->wb_background = (rwb->wb_max + 3) / 4; > > >>+ if (rwb->queue_de

Re: [PATCHSET v5] Make background writeback great again for the first time

2016-05-03 Thread Chris Mason
On Tue, May 03, 2016 at 03:06:09PM +0200, Jan Kara wrote: > On Tue 03-05-16 08:40:11, Chris Mason wrote: > > On Tue, May 03, 2016 at 02:17:19PM +0200, Jan Kara wrote: > > > On Thu 28-04-16 12:46:41, Jens Axboe wrote: > > > > >>- rwb->wb_max = 1 + (

Re: sched: tweak select_idle_sibling to look for idle threads

2016-05-03 Thread Chris Mason
On Tue, May 03, 2016 at 04:32:25PM +0200, Peter Zijlstra wrote: > On Mon, May 02, 2016 at 11:47:25AM -0400, Chris Mason wrote: > > On Mon, May 02, 2016 at 04:58:17PM +0200, Peter Zijlstra wrote: > > > On Mon, May 02, 2016 at 04:50:04PM +0200, Mike Galbraith wrote: > >

Re: sched: tweak select_idle_sibling to look for idle threads

2016-05-04 Thread Chris Mason
On Wed, May 04, 2016 at 05:45:10PM +0200, Peter Zijlstra wrote: > On Tue, May 03, 2016 at 11:11:53AM -0400, Chris Mason wrote: > > # pick a single core, in my case cpus 0,20 are the same core > > # cpu_hog is any program that spins > > # > > taskset -c 20 cpu_hog &

Re: [RFC][PATCH 0/7] sched: select_idle_siblings rewrite

2016-05-11 Thread Chris Mason
On Mon, May 09, 2016 at 12:48:07PM +0200, Peter Zijlstra wrote: > Hai, > > here be a semi coherent patch series for the recent select_idle_siblings() > tinkering. Happy benchmarking.. I ran a few more rounds of the production benchmarks, and NO_AVG_CPU is consistently faster by about 5% than AVG_

[GIT PULL] Btrfs

2016-05-21 Thread Chris Mason
Hi Linus, My for-linus-4.7 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.7 Has our merge window series of cleanups and fixes. These target a wide range of issues, but do include some important fixes for qgroups, O_DIRECT, and fsync handling. Jeff Mah

Re: general protection fault (btrfs_real_readdir)

2016-05-18 Thread Chris Mason
On Wed, May 18, 2016 at 01:21:14PM +0100, Al Viro wrote: > On Wed, May 18, 2016 at 01:31:40PM +0200, Markus Trippelsdorf wrote: > > I'm running the latest Linus git tree and the parallel filesystem directory > > handling update seems to cause the following issue: > > > Call Trace: > > [] ? btr

Re: general protection fault (btrfs_real_readdir)

2016-05-18 Thread Chris Mason
On Wed, May 18, 2016 at 01:21:14PM +0100, Al Viro wrote: > On Wed, May 18, 2016 at 01:31:40PM +0200, Markus Trippelsdorf wrote: > > I'm running the latest Linus git tree and the parallel filesystem directory > > handling update seems to cause the following issue: > > > Call Trace: > > [] ? btr

incoming merge conflict to linux-next

2016-05-18 Thread Chris Mason
Hi Stephen, Dave Sterba's tree in linux-next has a few btrfs patches that we're not sending yet into Linus. We've got an update for Josef's enospc work that'll get sent in next week. So he prepped a pull for me that merged up a number of his branches but didn't include Josef's new code. It has

Re: [RFC][PATCH 0/7] sched: select_idle_siblings rewrite

2016-05-25 Thread Chris Mason
On Mon, May 09, 2016 at 12:48:07PM +0200, Peter Zijlstra wrote: > Hai, > > here be a semi coherent patch series for the recent select_idle_siblings() > tinkering. Happy benchmarking.. This took a while, mostly because my original schbench showed your patches were just as fast as our internal patc

Re: [RFC][PATCH 0/7] sched: select_idle_siblings rewrite

2016-05-25 Thread Chris Mason
On Wed, May 25, 2016 at 06:24:49PM +0200, Peter Zijlstra wrote: On Wed, May 25, 2016 at 10:51:20AM -0400, Chris Mason wrote: On Mon, May 09, 2016 at 12:48:07PM +0200, Peter Zijlstra wrote: > Hai, > > here be a semi coherent patch series for the recent select_idle_siblings() > tink

[GIT PULL] Btrfs

2016-05-27 Thread Chris Mason
find_workspace always succeed (+12/-8) btrfs: preallocate compression workspaces (+16/-0) Liu Bo (2) commits (+7/-3): Btrfs: fix unexpected return value of fiemap (+5/-1) Btrfs: free sys_array eb as soon as possible (+2/-2) Chris Mason (1) commits (+17/-10): Btrfs: fix handling of faults from

Re: 4.6.0-rc3+: WARNING: CPU: 16 PID: 17257 at fs/btrfs/inode.c:9261 btrfs_destroy_inode

2016-04-27 Thread Chris Mason
On Wed, Apr 27, 2016 at 02:25:50PM +0200, Christian Borntraeger wrote: > Folks, > > I can sometimes trigger the following bug > > [ 244.493534] [ cut here ] > [ 244.493624] WARNING: CPU: 16 PID: 17257 at fs/btrfs/inode.c:9261 > btrfs_destroy_inode+0x288/0x2b0 [btrfs] >

[GIT PULL] Btrfs

2015-11-13 Thread Chris Mason
Hi Linus, My for-linus-4.4 branch is ready for pulling: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.4 Some of this got cherry-picked from a github repo this week, but I verified the patches. We have three small scrub cleanups and a collection of fixes. Zhao

[GIT PULL] Btrfs

2015-11-27 Thread Chris Mason
Hi Linus, I have a few fixes ready in my for-linus-4.4 branch. git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.4 This has Mark Fasheh's patches to fix quota accounting during subvol deletion, which we've been working on for a while now. The patch is pretty small

Re: 4.4rc3 nfsd/btrfs kasan warning.

2015-12-02 Thread Chris Mason
On Wed, Dec 02, 2015 at 11:09:43AM -0500, Dave Jones wrote: > On Wed, Dec 02, 2015 at 10:11:28AM -0500, Josef Bacik wrote: > > On 12/02/2015 09:59 AM, Dave Jones wrote: > > > Got a few of these in the logs this morning after an overnight rsync > over nfs > > > to an exported btrfs volume. > >

Re: 4.4rc3 nfsd/btrfs kasan warning.

2015-12-02 Thread Chris Mason
On Wed, Dec 02, 2015 at 09:32:34PM +0300, Andrey Ryabinin wrote: > 2015-12-02 20:14 GMT+03:00 Chris Mason : > > On Wed, Dec 02, 2015 at 11:09:43AM -0500, Dave Jones wrote: > >> On Wed, Dec 02, 2015 at 10:11:28AM -0500, Josef Bacik wrote: > >> > On 12/02/2

Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR

2015-12-12 Thread Chris Mason
On Sat, Dec 12, 2015 at 11:41:26AM -0800, Linus Torvalds wrote: > On Sat, Dec 12, 2015 at 10:33 AM, Linus Torvalds > wrote: > > > > Peter, did that patch also handle just plain "lock_page()" case? > > Looking more at it, I think this all goes back to commit 743162013d40 > ("sched: Remove prolifer

Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR

2015-12-13 Thread Chris Mason
On Sun, Dec 13, 2015 at 10:50:01AM +0100, Peter Zijlstra wrote: > On Sat, Dec 12, 2015 at 11:41:26AM -0800, Linus Torvalds wrote: > > It looks like PeterZ's pending patch should fix this, by passing in > > the proper TASK_UNINTERRUPTIBLE to the bit_wait_io function, and going > > back to signal_pen

Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR

2015-12-14 Thread Chris Mason
On Mon, Dec 14, 2015 at 01:33:56PM -0500, Dave Jones wrote: > On Sat, Dec 12, 2015 at 07:07:46PM -0500, Chris Mason wrote: > > On Sat, Dec 12, 2015 at 11:41:26AM -0800, Linus Torvalds wrote: > > > On Sat, Dec 12, 2015 at 10:33 AM, Linus Torvalds > > > wrote: >

Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR

2015-12-14 Thread Chris Mason
On Mon, Dec 14, 2015 at 01:33:56PM -0500, Dave Jones wrote: > On Sat, Dec 12, 2015 at 07:07:46PM -0500, Chris Mason wrote: > > On Sat, Dec 12, 2015 at 11:41:26AM -0800, Linus Torvalds wrote: > > > On Sat, Dec 12, 2015 at 10:33 AM, Linus Torvalds > > > wrote: >

[GIT PULL] Btrfs

2015-09-11 Thread Chris Mason
Hi Linus, We have a few more for the btrfs tree in my for-linus-4.3 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.3 These are small cleanups, and also some fixes for our async worker thread initialization. I was having some trouble testing these, but i

[PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

2015-09-11 Thread Chris Mason
/0x140 [btrfs] [ 2854.294259] [] btrfs_raid_unplug+0x23/0x70 [btrfs] [ 2854.307334] [] blk_flush_plug_list+0x82/0x1f0 [ 2854.319542] [] blk_finish_plug+0x34/0x50 [ 2854.330878] [] writeback_sb_inodes+0x122/0x580 [ 2854.343256] [] wb_writeback+0x136/0x4e0 Signed-off-by: Chris Mason Reviewed-by: Jens Axboe

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

2015-09-11 Thread Chris Mason
On Fri, Sep 11, 2015 at 02:04:13PM -0700, Linus Torvalds wrote: > On Fri, Sep 11, 2015 at 1:40 PM, Josef Bacik wrote: > > > > So we talked about this when we were trying to figure out a solution. The > > problem with this approach is now we have a plug that covers multiple super > > blocks (__writ

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

2015-09-11 Thread Chris Mason
On Fri, Sep 11, 2015 at 03:06:18PM -0700, Linus Torvalds wrote: > On Fri, Sep 11, 2015 at 2:04 PM, Linus Torvalds > wrote: > > > > Of course, actual numbers would be the deciding factor if this really > > is noticeable. But "cleaner code and saner locking" is definitely an > > issue at least for m

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

2015-09-11 Thread Chris Mason
On Fri, Sep 11, 2015 at 05:52:27PM -0700, Linus Torvalds wrote: > On Fri, Sep 11, 2015 at 4:36 PM, Linus Torvalds > wrote: > > > > Are we really ok with waiting synchronously for an inode while holding > > the plug? No chance of deadlock (waiting for IO that we've plugged)? > > That issue is true

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

2015-09-12 Thread Chris Mason
On Fri, Sep 11, 2015 at 04:36:39PM -0700, Linus Torvalds wrote: > On Fri, Sep 11, 2015 at 4:16 PM, Chris Mason wrote: > > > > For 4.3 timeframes, what runs do you want to see numbers for: > > > > 1) revert > > 2) my hack > > 3) plug over multiple sbs (on dif

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

2015-09-12 Thread Chris Mason
On Sat, Sep 12, 2015 at 04:29:06PM -0700, Linus Torvalds wrote: > On Sat, Sep 12, 2015 at 4:00 PM, Chris Mason wrote: > > > > I did the plain revert as well, just to have a baseline. > > Ahh, I ended up not expecting you to get this done until after rc1 was > out, s

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

2015-09-13 Thread Chris Mason
On Sat, Sep 12, 2015 at 07:46:32PM -0400, Chris Mason wrote: > I don't think the XFS numbers can be trusted too much since it was > basically bottlenecked behind that single pegged CPU. It was bouncing > around and I couldn't quite track it down to a process name (or perf &

Re: use-after-free in perf_trace_btrfs__work

2016-01-21 Thread Chris Mason
On Thu, Jan 14, 2016 at 10:07:31PM -0500, Dave Jones wrote: > I just hit a bunch of instances of this spew.. > This is on Linus' tree from a few hours ago > > == > BUG: KASAN: use-after-free in perf_trace_btrfs__work+0x1b1/0x2a0 [btrf

[GIT PULL] Btrfs

2016-01-22 Thread Chris Mason
Hi Linus, Please pull my for-linus-4.5 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.5 These are mostly fixes that we've been testing, but also we grabbed and tested a few small cleanups that had been on the list for a while. Zhao Lei's patchset also f

Re: [PATCH RESEND] btrfs:Fix incorrect return statement if failure occurs in the function btrfs_mark_extent_written

2015-12-30 Thread Chris Mason
On Tue, Dec 29, 2015 at 08:20:47PM -0500, Nicholas Krause wrote: > This fixes the incorrect return statement if failure occurs by > returning 0 rather then the variable ret which may hold a error > code to signal when a failure has occurred in the function > btrfs_mark_extent_written to its callers

Re: [PATCH RESEND 2/2] btrfs:Fix error handling in the function btrfs_dev_replace_kthread

2015-12-30 Thread Chris Mason
On Tue, Dec 29, 2015 at 08:10:07PM -0500, Nicholas Krause wrote: > This fixes error handling in the function btrfs_dev_replace_kthread > by checking if the call to the function btrfs_dev_replace_continue_on_mount > has failed and if so return the error code to this function's caller in > order to s

Re: [PATCH] btrfs: Don't check for file->private_data on open(). It is set by the core.

2014-11-12 Thread Chris Mason
On Wed, Nov 12, 2014 at 11:38 AM, Martin Kepplinger wrote: The miscdevice core now sets file->private_data to the struct miscdevice so don't fail when this is not NULL. Signed-off-by: Martin Kepplinger --- This is a question: what does this check provide and does overwriting file->private_dat

Re: frequent lockups in 3.18rc4

2014-12-01 Thread Chris Mason
I'm not sure if this is related, but running trinity here, I noticed it was stuck at 100% system time on every CPU. perf report tells me we are spending all of our time in spin_lock under the sync system call. I think it's coming from contention in the bdi_queue_work() call from inside sync_inode

Re: frequent lockups in 3.18rc4

2014-12-01 Thread Chris Mason
On Mon, Dec 1, 2014 at 6:25 PM, Linus Torvalds wrote: On Mon, Dec 1, 2014 at 3:08 PM, Chris Mason wrote: I'm not sure if this is related, but running trinity here, I noticed it was stuck at 100% system time on every CPU. perf report tells me we are spending all of our ti

New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
Hi everyone, I was running some tests on Saturday before my pull, and I'm now hitting this consistently across two boxes. One box has plain linus git: commit cb95413971d605b0d152d3ceecc47ba8991d66fb Merge: ecde006 6bab4a8 Author: Linus Torvalds Date: Sat Nov 22 14:33:11 2014 -0800 The other

[GIT PULL] Btrfs deadlock fix

2014-11-23 Thread Chris Mason
btrfs reacquires locks in the btree. Chris Mason (1) commits (+25/-15): btrfs: fix lockups from btrfs_clear_path_blocking Total: (1) commits (+25/-15) fs/btrfs/ctree.c | 14 ++ fs/btrfs/locking.c | 24 +--- fs/btrfs/locking.h | 2 ++ 3 files changed, 25 inser

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 10:02 AM, Chris Mason wrote: Since it looks like a race between process exit and /proc, I'll try to hammer on that for a better reproduction. But, here's hoping that someone has already seen this one: It falls over in less than 5 minutes with a fork bomb go

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 11:11 AM, Borislav Petkov wrote: On Sun, Nov 23, 2014 at 10:56:27AM -0500, Chris Mason wrote: On Sun, Nov 23, 2014 at 10:02 AM, Chris Mason wrote: >Since it looks like a race between process exit and /proc, I'll try to >hammer on that for a better r

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 11:32 AM, Borislav Petkov wrote: On Sun, Nov 23, 2014 at 11:16:51AM -0500, Chris Mason wrote: It must be: commit 6e998916dfe327e785e7c2447959b2c1a3ea4930 Author: Stanislaw Gruszka Date: Wed Nov 12 16:58:44 2014 +0100 sched/cputime: Fix clock_nanosleep

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 11:32 AM, Borislav Petkov wrote: On Sun, Nov 23, 2014 at 11:16:51AM -0500, Chris Mason wrote: It must be: commit 6e998916dfe327e785e7c2447959b2c1a3ea4930 Author: Stanislaw Gruszka Date: Wed Nov 12 16:58:44 2014 +0100 sched/cputime: Fix clock_nanosleep

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 4:05 PM, Thomas Gleixner wrote: On Sun, 23 Nov 2014, Chris Mason wrote: On Sun, Nov 23, 2014 at 11:32 AM, Borislav Petkov wrote: > On Sun, Nov 23, 2014 at 11:16:51AM -0500, Chris Mason wrote: > > It must be: > &g

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 4:11 PM, Chris Mason wrote: On Sun, Nov 23, 2014 at 4:05 PM, Thomas Gleixner wrote: On Sun, 23 Nov 2014, Chris Mason wrote: On Sun, Nov 23, 2014 at 11:32 AM, Borislav Petkov wrote: > On Sun, Nov 23, 2014 at 11:16:51AM -0500, Chris Mason wrote: > > I

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 4:38 PM, Thomas Gleixner wrote: On Sun, 23 Nov 2014, Chris Mason wrote: On Sun, Nov 23, 2014 at 4:05 PM, Thomas Gleixner wrote: > On Sun, 23 Nov 2014, Chris Mason wrote: > > On Sun, Nov 23, 2014 at 11:32 AM, Borislav Petkov wrote: > > > On

Re: [GIT PULL] Btrfs deadlock fix

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 7:23 PM, Benjamin Herrenschmidt wrote: On Sun, 2014-11-23 at 10:14 -0500, Chris Mason wrote: Hi Linus, My for-linus branch: Not sure if this is related, but with -rc4, on this ppc64el box, when grub updates (it starts trying to mount everything under the sun

Re: [GIT PULL] Btrfs deadlock fix

2014-11-24 Thread Chris Mason
On Mon, Nov 24, 2014 at 12:39 PM, David Sterba wrote: Hi Chris, I thought the fix for the scrub/replace deadlock would be included in this pull, I can reproduce it on each run of xfstests with 3.18-rc. btrfs: fix dead lock while running replace and defrag concurrently https://patchwork.kern

Re: frequent lockups in 3.18rc4

2014-12-02 Thread Chris Mason
On Tue, Dec 2, 2014 at 11:33 AM, Linus Torvalds wrote: On Tue, Dec 2, 2014 at 6:13 AM, Mike Galbraith wrote: At the same time, the whole "incapacitated by the rt throttle long enough for the hard lockup detector to trigger" commentary about that skip_clock_update issue does make me go "Hmmm..

Re: frequent lockups in 3.18rc4

2014-12-03 Thread Chris Mason
On Wed, Dec 3, 2014 at 2:00 PM, Dave Jones wrote: On Wed, Dec 03, 2014 at 10:45:57AM -0800, Linus Torvalds wrote: > On Wed, Dec 3, 2014 at 10:41 AM, Dave Jones wrote: > > > > I've been stuck on this kernel for a few days now trying to prove it > > good/bad one way or the other, and I'm

Re: frequent lockups in 3.18rc4

2014-12-03 Thread Chris Mason
On Wed, Dec 3, 2014 at 3:11 PM, Dave Jones wrote: On Wed, Dec 03, 2014 at 02:59:58PM -0500, Chris Mason wrote: > You've also mentioned a few times where messages stopped hitting the > console? > > commit 5874af2003b1053128d655710140e3187226 > Author: Jan Kara

Re: frequent lockups in 3.18rc4

2014-12-03 Thread Chris Mason
I asked Dave for his lockups from 3.17-rc1, and they were in the flush_tlb code waiting for remote CPUs to finish flushing. It feels like that's a common theme, and there are a few commits there between 3.16 and 3.17. One guess is that trinity is generating a huge number of tlb invalidations over

Re: [GIT PULL] Btrfs corruption fix

2014-10-17 Thread Chris Mason
On 10/16/2014 03:51 AM, Chris Mason wrote: > Hi Linus, > > I'm testing a pull with more fixes, but wanted to get this one out so > Greg can pick it up. The corruption isn't easy to hit, you have to do a > readonly snapshot and have orphans in the snapshot. But my re

[GIT PULL] Btrfs

2014-10-10 Thread Chris Mason
btrfs: label should not contain return char (+12/-3) HIMANGI SARAOGI (1) commits (+2/-2): Btrfs: use BUG_ON Sage Weil (1) commits (+9/-3): Btrfs: fix race in WAIT_SYNC ioctl Filipe David Borba Manana (1) commits (+3/-2): Btrfs: set default max_inline to 8KiB instead of 8MiB Li RongQi

[GIT PULL] Btrfs

2015-05-22 Thread Chris Mason
where it was possible to double allocate chunks on the drive. Mark has a fix for fiemap. All three will get bundled off for stable as well. Chris Mason (1) commits (+18/-0): Btrfs: fix regression in raid level conversion Filipe Manana (1) commits (+3/-0): Btrfs: fix racy system chunk

<    1   2   3   4   5   6   7   8   >