Re: [PATCH] fs: xattr: rewrite simple_xattr_set()

orig/fs/xattr.c2012-10-23 16:02:41.155857391 -0400 > +++ github/fs/xattr.c 2012-10-25 11:17:15.118197552 -0400 > @@ -842,55 +842,46 @@ > return ret; > } > Looks good to me Reviewed-by: Carlos Maiolino -- --Carlos -- To unsubscribe from this list: send the lin

Re: [RESEND PATCH] fs/super.c set_anon_super calling optimization

Hi, On Thu, Oct 25, 2012 at 05:08:19PM +0530, Abhijit Pawar wrote: > Hi, > set_anon_super is called by many filesystems. Some call directly and > some call through the wrapper. Many of them in the wrapper's call to > this function are passing the second argument to this function which > is not use

Re: jbd2: don't wake kjournald unnecessarily

On Mon, Jan 21, 2013 at 11:47:33AM +0100, Jan Kara wrote: > On Sun 20-01-13 01:06:40, Sedat Dilek wrote: > > On Sun, Jan 20, 2013 at 12:44 AM, Sedat Dilek wrote: > > > Hi, > > > > > > I and some others hit a similiar problem in Linux-Next > > > (next-20130118), please see [1] and [2]. > > > > > >

Re: [PATCH v2 0/4] vfs: track per-sb writeback errors and report them via fsinfo()

t > have an xfstest for it, since the syscall is still quite new. Once that > goes in and we get fsinfo support in xfs_io, it should be rather > trivial to roll a testcase for this. > Whole patch sounds fine, you can add: Reviewed-by: Carlos Maiolino Cheers > Al, if this lo

Re: [PATCH] xfs: libxfs: move xfs_perag_put late

On Sat, Nov 24, 2018 at 05:44:20PM +0800, Pan Bian wrote: > The function xfs_alloc_get_freelist calls xfs_perag_put to drop the > reference. In this case, pag may be released. However, > pag->pagf_btreeblks is read and write after the put operation. This may > result in a use-after-free bug. This p

Re: [PATCH V2] xfs: libxfs: move xfs_perag_put late

glish speaker too, but I believe it should be "is read and written after..." But, for the code itself, you can add: Reviewed-by: Carlos Maiolino Cheers > > Signed-off-by: Pan Bian > --- > V2: correct the commit log > --- > fs/xfs/libxfs/xfs_alloc.c | 2 +-

Re: [PATCH] vfs: remove iterate_supers_type

On Thu, May 17, 2018 at 11:47:37AM -0400, Jeff Layton wrote: > From: Jeff Layton > > Nothing calls this. > > Signed-off-by: Jeff Layton looks like there are no reviews here yet, and it looks good to me, so, feel free to add. Reviewed-by: Carlos Maiolino > --- > fs

Re: WARNING in shmem_release_dquot

On Mon, Feb 19, 2024 at 08:26:20PM -0800, Hugh Dickins wrote: > On Mon, 29 Jan 2024, Ubisectech Sirius wrote: > > > Hello. > > We are Ubisectech Sirius Team, the vulnerability lab of China ValiantSec. > > Recently, our team has discovered a issue in Linux kernel > > 6.8.0-rc1-gecb1b8288dc7. Atta

Re: [PATCH v4 0/6] Add alignment check for DAX mount

s looks good to me, the conflicts with Dan's patches, also should not cause any semantics change of this patchset, you can add: Reviewed-by: Carlos Maiolino Cheers > --- > block/ioctl.c | 30 > fs/block_dev.c | 96 > +++

Re: [PATCH] fs: xfs: xfs_log: Change return type from int to void

c:4886:7-12: Unneeded variable: "error". Return > "0" on line 4926 > > Signed-off-by: Hariprasad Kelam Looks ok. You can add: Reviewed-by: Carlos Maiolino > --- > fs/xfs/xfs_log.c | 8 ++-- > fs/xfs/xfs_log.h | 2 +- > fs/

Re: [patch] direct-io: propagate -ENOSPC errors

This looks good to me. Reviewed-by: Carlos Maiolino On Mon, Mar 14, 2016 at 05:10:00PM -0400, Jeff Moyer wrote: > dio_bio_complete turns all errors into -EIO. This is historical, > since you used to only get 1 bit precision for errors (BIO_UPTODATE). > Now that we get actual error