Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

2018-07-23 Thread Boris Brezillon
+Neil On Mon, 23 Jul 2018 15:06:43 -0700 Brian Norris wrote: > Hi Boris, > > On Mon, Jul 23, 2018 at 1:10 PM, Boris Brezillon > wrote: > > On Mon, 23 Jul 2018 11:13:50 -0700 > > Brian Norris wrote: > >> I noticed this got merged, but I wanted to put my 2 ce

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

2018-07-23 Thread Boris Brezillon
On Tue, 24 Jul 2018 08:46:33 +1000 NeilBrown wrote: > On Mon, Jul 23 2018, Brian Norris wrote: > > > Hi Boris, > > > > On Mon, Jul 23, 2018 at 1:10 PM, Boris Brezillon > > wrote: > >> On Mon, 23 Jul 2018 11:13:50 -0700 > >> Brian Norris wrote:

Re: [PATCH v2] mtd/maps: fix solutionengine.c printk format warnings

2018-07-23 Thread Boris Brezillon
x27;} [-Wformat=] > ../drivers/mtd/maps/solutionengine.c:62:72: note: format string is defined > here > printk(KERN_NOTICE "Solution Engine: Flash at 0x%08lx, EPROM at 0x%08lx\n", > ^ >

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

2018-07-24 Thread Boris Brezillon
On Tue, 24 Jul 2018 12:52:02 -0700 Brian Norris wrote: > > > Or even better: put this hack behind a DT flag, so that one has to > > > admit that their board design is broken before it will even do > > > anything. Proposal: "linux,badly-designed-flash-reset". > > > > I think we can remove the "

Re: [PATCH] mtd: spi-nor: cadence-quadspi: make return type fit wait_for_completion_timeout

2018-07-24 Thread Boris Brezillon
On Sat, 21 Jul 2018 18:08:13 +0200 Nicholas Mc Guire wrote: > wait_for_completion_timeout returns an unsigned long not int. declare a > suitably type timeout and fix up assignment and check. > > Signed-off-by: Nicholas Mc Guire > Reported-by: Vignesh R > Fixes: 140623410536 ("mtd: spi-nor: Add

Re: [PATCH v4 04/35] mtd: rawnand: denali: convert to nand_scan()

2018-07-25 Thread Boris Brezillon
On Wed, 25 Jul 2018 18:42:44 +0900 Masahiro Yamada wrote: > > You need to remove kfree(denali->buf) > from denali_remove(), right? Absolutely. > > void denali_remove(struct denali_nand_info *denali) > { > struct mtd_info *mtd = nand_to_mtd(&denali->nand); > > nand_release(mtd

Re: [PATCH] MAINTAINERS: drop Wenyou Yang from Atmel NAND driver support

2018-07-25 Thread Boris Brezillon
On Wed, 25 Jul 2018 16:56:28 +0200 Miquel Raynal wrote: > Mails to wenyou.y...@microchip.com are not deliverable. > Drop him as Microchip/Atmel NAND controller driver maintainer. > > Signed-off-by: Miquel Raynal Acked-by: Boris Brezillon > --- > MAINTAINERS | 1 - &g

Re: [PATCH] MAINTAINERS: drop Wenyou Yang from Atmel NAND driver support

2018-07-25 Thread Boris Brezillon
On Wed, 25 Jul 2018 16:56:28 +0200 Miquel Raynal wrote: > Mails to wenyou.y...@microchip.com are not deliverable. > Drop him as Microchip/Atmel NAND controller driver maintainer. > > Signed-off-by: Miquel Raynal > --- > MAINTAINERS | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/MAINT

Re: [PATCH v2 7/7] drm/atmel-hlcdc: Replace the panel usage with drm_panel_bridge.

2017-05-11 Thread Boris Brezillon
> > Signed-off-by: Eric Anholt Acked-by: Boris Brezillon A few comments below (no need to address them, those are just minor things that can be fixed later on, or things I'm not comfortable with but cannot be addressed easily). > --- > > This patch is just a proposal fo

Re: [PATCH v2 6/7] drm/atmel-hlcdc: Drop custom encoder cleanup func.

2017-05-11 Thread Boris Brezillon
On Thu, 11 May 2017 11:31:27 -0700 Eric Anholt wrote: > drm_encoder_cleanup() finishes with memsetting it to 0, already. > > Signed-off-by: Eric Anholt Acked-by: Boris Brezillon > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 8 +--- > 1 file changed,

Re: [PATCH v2 1/7] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-12 Thread Boris Brezillon
way. > > v2: Fix build with CONFIG_DRM=m, drop "dev" argument that should just > be the panel's dev, move kerneldoc up a level and document > _remove(). > > Signed-off-by: Eric Anholt > Acked-by: Daniel Vetter Reviewed-by: Boris Brezillon >

Re: [PATCH v2 2/7] drm/vc4: Switch DSI to the panel-bridge layer, and support bridges.

2017-05-12 Thread Boris Brezillon
"dev" argument. > > Signed-off-by: Eric Anholt > Acked-by: Daniel Vetter Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/vc4/Kconfig | 2 +- > drivers/gpu/drm/vc4/vc4_dsi.c | 154 > ++ > 2 files changed, 21 insertio

Re: [PATCH v2 3/7] drm/vc4: Switch DPI to using the panel-bridge helper.

2017-05-12 Thread Boris Brezillon
On Thu, 11 May 2017 11:31:24 -0700 Eric Anholt wrote: > Another 100 lines of boilerplate gone, while allowing for bridges to > be connected in the display chain. > > Signed-off-by: Eric Anholt Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/v

Re: [PATCH v2 4/7] drm/mediatek: Use the panel-bridge helper.

2017-05-12 Thread Boris Brezillon
ould be when you do things that require the link to be > brought up), but there may be issues here. > > Signed-off-by: Eric Anholt Reviewed-by: Boris Brezillon > --- > > Note that I haven't tested this change, and am not committed to this > patch. It's ju

Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper.

2017-05-12 Thread Boris Brezillon
On Thu, 11 May 2017 11:31:26 -0700 Eric Anholt wrote: > Another 100 lines of boilerplate gone. Bridges aren't supported yet, > but will be trivial to add later. > > Signed-off-by: Eric Anholt > --- > [...] > @@ -1082,28 +993,13 @@ int ltdc_load(struct drm_device *ddev) > > DRM_INFO(

Re: [PATCH 1/2] mtd: nand: add generic helpers to check, match, maximize ECC settings

2017-05-15 Thread Boris Brezillon
Hi Masahiro, Sorry for the late reply. On Mon, 8 May 2017 12:40:47 +0900 Masahiro Yamada wrote: > Hi Boris, > > > 2017-04-29 1:32 GMT+09:00 Boris Brezillon > : > > >> + for (setting = caps->ecc_settings; setting->step; setting++) { > >> +

Re: [PATCH 0/5] Convert more books to ReST

2017-05-15 Thread Boris Brezillon
On Sat, 13 May 2017 08:10:53 -0300 Mauro Carvalho Chehab wrote: > This patch series convert the following books to ReST: > - librs > - mtdnand > - sh > > And it is based on my previous series of conversion patches. > > After this series, there will be just one DocBook pending

Re: [PATCH] crypto: marvell/cesa - Fix DMA API misuse

2018-01-10 Thread Boris Brezillon
Hi Christoph, On Wed, 10 Jan 2018 16:48:17 +0100 Christoph Hellwig wrote: > On Wed, Jan 10, 2018 at 04:25:22PM +0100, Boris Brezillon wrote: > > On Wed, 10 Jan 2018 15:15:43 + > > Robin Murphy wrote: > > > > > phys_to_dma() is an internal helper for c

Re: stable-rc build: 0 warnings 5 failures (stable-rc/v3.18.91-23-g72813f7)

2018-01-12 Thread Boris Brezillon
On Fri, 12 Jan 2018 11:57:55 +0100 Arnd Bergmann wrote: > On Fri, Jan 12, 2018 at 11:49 AM, Olof's autobuilder wrote: > > Here are the build results from automated periodic testing. > > > > The tree being built was stable-rc, found at: > > > > URL: > > git://git.kernel.org/pub/scm/linux/kernel/

Re: [PATCH v2] MAINTAINERS: mtd/nand: update Microchip nand entry

2018-01-12 Thread Boris Brezillon
On Thu, 11 Jan 2018 17:26:59 +0100 Nicolas Ferre wrote: > Update Wenyou Yang email address. > Take advantage of this update to move this entry to the MICROCHIP / ATMEL > location and add the DT binding documentation link. > > Signed-off-by: Nicolas Ferre > Acked-by: Wenyou Yang Applied. Than

Re: [PATCH -next v3 1/2] mtd: nand: toshiba: Retrieve ECC requirements from extended ID

2018-01-30 Thread Boris Brezillon
On Tue, 30 Jan 2018 08:44:30 +0900 KOBAYASHI Yoshitake wrote: > On 2017/12/27 15:06, KOBAYASHI Yoshitake wrote: > > On 2017/12/19 20:56, Boris Brezillon wrote: > >> On Tue, 19 Dec 2017 20:42:36 +0900 > >> KOBAYASHI Yoshitake wrote: > >> > >&g

Re: [PATCH v3] mtd: nand: vf610: fix error handling in vf610_nfc_probe()

2018-01-30 Thread Boris Brezillon
Alexey Khoroshilov > --- > v2: Add nand_cleanup() to undone nand_scan_tail() as Boris Brezillon noted. > v3: Rename error labels, remove of_node_put() per Boris Brezillon request. Should be separated in 3 patches IMO: 1/ remove the unnecessary of_node_put() 2/ rename error label in

Re: [PATCH] mtd: nand: gpmi: fall back to legacy mode if no ECC information present

2018-01-30 Thread Boris Brezillon
Hi Stefan, On Mon, 29 Jan 2018 15:44:40 +0100 Stefan Agner wrote: > In case fsl,use-minimum-ecc is set, the driver tries to determine > ECC layout by using the ECC information provided by the MTD stack. > However, in case the NAND chip does not provide any information, > the driver currently fai

Re: [PATCH] mtd: nand: MTD_NAND_MARVELL should depend on HAS_DMA

2018-01-30 Thread Boris Brezillon
On Tue, 30 Jan 2018 14:46:47 +0100 Miquel Raynal wrote: > Hi Geert, > > On Tue, 30 Jan 2018 14:23:21 +0100 > Geert Uytterhoeven wrote: > > > If NO_DMA=y: > > > > ERROR: "bad_dma_ops" [drivers/mtd/nand/marvell_nand.ko] undefined! > > > > Add a dependency on HAS_DMA to fix this. > > > > F

Re: [PATCH -next] mtd: ubi: wl: Fix error return code in ubi_wl_init()

2018-01-18 Thread Boris Brezillon
On Thu, 18 Jan 2018 15:11:32 +0100 Boris Brezillon wrote: > On Thu, 18 Jan 2018 15:08:01 +0100 > Boris Brezillon wrote: > > > On Thu, 18 Jan 2018 14:05:05 + > > Wei Yongjun wrote: > > > > > Fix to return error code -ENOMEM from the kmem_cache_alloc

Re: [PATCH -next] mtd: onenand: omap2: Remove redundant dev_err call in omap2_onenand_probe()

2018-01-20 Thread Boris Brezillon
On Wed, 17 Jan 2018 11:25:33 + Wei Yongjun wrote: > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. Applied. Thanks, Boris > > Signed-off-by: Wei Yongjun > --- > drivers/mtd/onenand/omap2.c | 4 +--- > 1 fi

Re: [PATCH][V2] mtd: nand: marvell: fix spelling mistake: "suceed"-> "succeed"

2018-01-20 Thread Boris Brezillon
On Fri, 19 Jan 2018 07:55:31 + Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistakes in dev_err error message text. Applied. Thanks, Boris > > Signed-off-by: Colin Ian King > --- > drivers/mtd/nand/marvell_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 del

Re: [PATCH][V2] mtd: nand: marvell: remove redundant variable 'oob_len'

2018-01-20 Thread Boris Brezillon
On Fri, 19 Jan 2018 07:59:54 + Colin King wrote: > From: Colin Ian King > > Variable oob_len is assigned and never read, hence it is redundant and > can be removed. > > Cleans up clang warnings: > > drivers/mtd/nand/marvell_nand.c:1356:6: warning: Value stored to 'oob_len' > during its in

Re: [PATCH v2 5/7] dt-bindings: i3c: Document core bindings

2018-01-22 Thread Boris Brezillon
Hi Rob, On Sun, 7 Jan 2018 15:14:25 +0100 Boris Brezillon wrote: > Hi Rob, > > On Tue, 26 Dec 2017 12:29:34 -0600 > Rob Herring wrote: > > > >> > > > +Optional properties > > >> > > > +--- > > >>

Re: [PATCH v2] mtd: nand: vf610: fix error handling in vf610_nfc_probe()

2018-01-06 Thread Boris Brezillon
undone nand_scan_tail() as Boris Brezillon noted. > > drivers/mtd/nand/vf610_nfc.c | 25 +++-- > 1 file changed, 15 insertions(+), 10 deletions(-) > > diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c > index 8037d4b48a05..2dac25a8ccbf 1006

Re: [PATCH v2] mtd: nand: vf610: fix error handling in vf610_nfc_probe()

2018-01-06 Thread Boris Brezillon
undone nand_scan_tail() as Boris Brezillon noted. > > drivers/mtd/nand/vf610_nfc.c | 25 +++-- > 1 file changed, 15 insertions(+), 10 deletions(-) > > diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c > index 8037d4b48a05..2dac25a8ccbf 1006

Re: [PATCH -next] mtd: sharpslpart: make local function sharpsl_nand_cleanup_ftl() static

2018-01-06 Thread Boris Brezillon
On Fri, 22 Dec 2017 11:09:15 +0100 Andrea Adami wrote: > On Wed, Dec 20, 2017 at 6:45 AM, Wei Yongjun wrote: > > Fixes the following sparse warnings: > > > > drivers/mtd/parsers/sharpslpart.c:222:6: warning: > > symbol 'sharpsl_nand_cleanup_ftl' was not declared. Should it be static? > > > > Si

Re: [PATCH v2 5/7] dt-bindings: i3c: Document core bindings

2018-01-07 Thread Boris Brezillon
Hi Rob, On Tue, 26 Dec 2017 12:29:34 -0600 Rob Herring wrote: > >> > > > +Optional properties > >> > > > +--- > >> > > > +- reg: static address. Only valid is the device has a static > >> > > > address. > >> > > > +- i3c-dynamic-address: dynamic address to be assigned to this >

Re: [PATCH 1/3] mtd: spi-nor: add optional DMA-safe bounce buffer for data transfer

2018-01-07 Thread Boris Brezillon
On Tue, 26 Dec 2017 14:59:00 +0100 Cyrille Pitchen wrote: > Hi Vignesh > > Le 26/12/2017 à 14:42, Vignesh R a écrit : > > Hi Cyrille, > > > > Thanks for doing this series! One comment below. > > > > On 24-Dec-17 10:06 AM, Cyrille Pitchen wrote: > > [...] > >> diff --git a/drivers/mtd/spi-nor

Re: [PATCH 1/3] mtd: spi-nor: add optional DMA-safe bounce buffer for data transfer

2018-01-07 Thread Boris Brezillon
Hi Cyrille, On Sun, 24 Dec 2017 05:36:04 +0100 Cyrille Pitchen wrote: > This patch has two purposes: > > 1 - To fix the compatible issue between the MTD and SPI sub-systems > > The MTD sub-system has no particular requirement about the memory areas it > uses. Especially, ubifs is well known fo

Re: [PATCH v2 3/6] clocksource/drivers: atmel-pit: allow unselecting ATMEL_PIT

2018-01-08 Thread Boris Brezillon
On Mon, 8 Jan 2018 08:23:02 +0100 Daniel Lezcano wrote: > On 07/01/2018 19:44, Alexandre Belloni wrote: > > On 07/01/2018 at 19:07:13 +0100, Daniel Lezcano wrote: > >> On 05/01/2018 15:30, Alexandre Belloni wrote: > >>> With the new TCB clocksource driver, atmel platforms are now able to boot

Re: stable-rc/linux-4.4.y build: 178 builds: 4 failed, 174 passed, 8 errors (v4.4.110-18-g5da3d9af3a4b)

2018-01-08 Thread Boris Brezillon
Hi Arnd, On Mon, 8 Jan 2018 14:16:25 +0100 Arnd Bergmann wrote: > On Mon, Jan 8, 2018 at 12:25 PM, kernelci.org bot wrote: > > > > stable-rc/linux-4.4.y build: 178 builds: 4 failed, 174 passed, 8 errors > > (v4.4.110-18-g5da3d9af3a4b) > > Full Build Summary: > > https://kernelci.org/build/sta

Re: stable-rc/linux-4.4.y build: 178 builds: 4 failed, 174 passed, 8 errors (v4.4.110-18-g5da3d9af3a4b)

2018-01-08 Thread Boris Brezillon
On Mon, 8 Jan 2018 15:01:38 +0100 Arnd Bergmann wrote: > On Mon, Jan 8, 2018 at 2:44 PM, gregkh wrote: > > On Mon, Jan 08, 2018 at 02:16:25PM +0100, Arnd Bergmann wrote: > >> On Mon, Jan 8, 2018 at 12:25 PM, kernelci.org bot > >> wrote: > >> > > >> > stable-rc/linux-4.4.y build: 178 builds

[GIT PULL] mtd: Changes for 4.16

2018-01-29 Thread Boris Brezillon
cron memories Boris Brezillon (15): mtd: nand: hynix: Don't wait after applying new read-retry params mtd: nand: provide several helpers to do common NAND operations mtd: nand: force drivers to explicitly send READ/PROG commands mtd: nand: denali: Avoid using ecc->co

Re: [PATCH] drm/vc4: Flush the caches before the bin jobs, as well.

2018-01-18 Thread Boris Brezillon
g each RCL job to make sure that the sampling of the > previous RCL's output is correct. > > Fixes flickering in the top left of 3DMMES Taiji. > > Signed-off-by: Eric Anholt > Fixes: ca26d28bbaa3 ("drm/vc4: improve throughput by pipelining binning and >

Re: [PATCH -next] mtd: ubi: wl: Fix error return code in ubi_wl_init()

2018-01-18 Thread Boris Brezillon
On Thu, 18 Jan 2018 14:05:05 + Wei Yongjun wrote: > Fix to return error code -ENOMEM from the kmem_cache_alloc() error > handling case instead of 0, as done elsewhere in this function. I guess you've used a static analysis code to detect this problem, can you name it in the commit message, a

Re: [PATCH -next] mtd: ubi: wl: Fix error return code in ubi_wl_init()

2018-01-18 Thread Boris Brezillon
On Thu, 18 Jan 2018 15:08:01 +0100 Boris Brezillon wrote: > On Thu, 18 Jan 2018 14:05:05 + > Wei Yongjun wrote: > > > Fix to return error code -ENOMEM from the kmem_cache_alloc() error > > handling case instead of 0, as done elsewhere in this function. > > I

Re: [PATCH 01/19] drm/fourcc: Add a function to tell if the format embeds alpha

2018-01-09 Thread Boris Brezillon
On Tue, 9 Jan 2018 11:56:20 +0100 Maxime Ripard wrote: > There's a bunch of drivers that duplicate the same function to know if a > particular format embeds an alpha component or not. > > Let's create a helper to avoid duplicating that logic. > > Cc: Boris Br

Re: [PATCH 02/19] drm/atmel-hlcdc: Use the alpha format helper

2018-01-09 Thread Boris Brezillon
On Tue, 9 Jan 2018 11:56:21 +0100 Maxime Ripard wrote: > Now that the core has a drm format helper to tell if a format embeds an > alpha component in it, let's use it. > > Cc: Boris Brezillon Acked-by: Boris Brezillon > Signed-off-by: Maxime Ripard > --- > d

Re: [PATCH 06/19] drm/blend: Add a generic alpha property

2018-01-09 Thread Boris Brezillon
On Tue, 9 Jan 2018 11:56:25 +0100 Maxime Ripard wrote: > Some drivers duplicate the logic to create a property to store a per-plane > alpha. > > Let's create a helper in order to move that to the core. > > Cc: Boris Brezillon Reviewed-by: Boris Brezillon > Cc:

Re: [PATCH 07/19] drm/atmel-hclcdc: Convert to the new generic alpha property

2018-01-09 Thread Boris Brezillon
On Tue, 9 Jan 2018 11:56:26 +0100 Maxime Ripard wrote: > Now that we have support for per-plane alpha in the core, let's use it. > > Cc: Boris Brezillon Acked-by: Boris Brezillon > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h

Re: [PATCH] crypto: marvell/cesa - Fix DMA API misuse

2018-01-10 Thread Boris Brezillon
didn't exist when the offending code was first merged, but it does now. > > Signed-off-by: Robin Murphy Acked-by: Boris Brezillon > --- > > Found by inspection and compile-tested only > > drivers/crypto/marvell/cesa.c | 19 --- > 1 file changed, 1

Re: [PATCH] mtd: onenand: samsung: remove incorrect __iomem annotation

2018-01-14 Thread Boris Brezillon
On Sat, 13 Jan 2018 17:56:16 +0100 Christophe JAILLET wrote: > 'page_buf' and 'oob_buf' are allocated with 'devm_kzalloc()' and should not > have __iommem decoration. ^ __iomem No need to send a new version, I'll fix it when applying. > > Remove these decorations and some useless cast

Re: [PATCH] mtd: onenand: samsung: remove incorrect __iomem annotation

2018-01-15 Thread Boris Brezillon
On Sat, 13 Jan 2018 17:56:16 +0100 Christophe JAILLET wrote: > 'page_buf' and 'oob_buf' are allocated with 'devm_kzalloc()' and should not > have __iommem decoration. > > Remove these decorations and some useless casting. > Applied. Thanks, Boris > Signed-off-by: Christophe JAILLET > --- >

Re: [PATCH] mtd: onenand: omap2: print resource using %pR format string

2018-01-16 Thread Boris Brezillon
On Tue, 16 Jan 2018 08:43:40 +0100 Arnd Bergmann wrote: > The omap2 onenand driver is now available for compile-testing, which > uncovers a warning in configurations that have a 64-bit resource_size_t: > > drivers/mtd/onenand/omap2.c: In function 'omap2_onenand_probe': > drivers/mtd/onenand/omap

Re: [REGRESSION] linux-next panics when trying to mount root

2018-01-16 Thread Boris Brezillon
> Author: Rafał Miłecki > Date: Thu Jan 4 08:05:34 2018 +0100 > > mtd: ofpart: add of_match_table with "fixed-partitions" > > This allows using this parser with any flash driver that takes care of > setting of_node (using mtd_set_of_node helper) correct

Re: [REGRESSION] linux-next panics when trying to mount root

2018-01-16 Thread Boris Brezillon
On Tue, 16 Jan 2018 14:56:52 +0100 Peter Rosin wrote: > On 2018-01-16 14:36, Boris Brezillon wrote: > > Hi Peter, > > > > On Tue, 16 Jan 2018 14:28:38 +0100 > > Peter Rosin wrote: > > > >> Hi! > >> > >> When trying next-20180116 I

Re: [REGRESSION] linux-next panics when trying to mount root

2018-01-16 Thread Boris Brezillon
On Tue, 16 Jan 2018 16:02:35 +0100 Peter Rosin wrote: > On 2018-01-16 15:21, Boris Brezillon wrote: > > On Tue, 16 Jan 2018 14:56:52 +0100 > > Peter Rosin wrote: > > > >> Hmmm, I guess the question is if the command line should override the > >> device

Re: [PATCH] mtdchar: fix usage of mtd_ooblayout_ecc()

2018-03-05 Thread Boris Brezillon
ion); > + ret = mtd_ooblayout_ecc(mtd, i, &oobregion); Ditto. > if (ret < 0) { > if (ret != -ERANGE) > return ret; Thanks, Boris -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v2] mtdchar: fix usage of mtd_ooblayout_ecc()

2018-03-06 Thread Boris Brezillon
(mtd, section, &oobregion); > + ret = mtd_ooblayout_ecc(mtd, section++, &oobregion); > if (ret < 0) { > if (ret != -ERANGE) > return ret; -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 4.4 054/108] mtd: cfi: convert inline functions to macros

2018-03-06 Thread Boris Brezillon
{ \ > [...] > > The right-hand side of this comparison is now using val2 instead of > val3. (This bug seems to be unfixed upstream.) Indeed. This being said, it's not buggy since all users of map_word_andequal() pass the same value to val2 and val3. Maybe we should just patch the macro and all call-sites to remove val3. > > Ben. > -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 4.4 03/34] mtd: nand: gpmi: Fix failure when a erased page has a bitflip at BBM

2018-03-07 Thread Boris Brezillon
doesn't appear to do any harm. I wonder why the fix was backported to stable releases in the first place. AFAICS, there's no Cc-stable or Fixes tag in the original commit. It's probably something in the backport-to-stable process I'm not aware of. Anyway, not an issues since the changes seems to be harmless. -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v3 01/11] i2c: Export of_i2c_get_board_info()

2018-03-25 Thread Boris Brezillon
ut any further modification, and leaving info->archdata to NULL has the exact same effect (see [1]). Regards, Boris [1]https://elixir.bootlin.com/linux/v4.16-rc6/source/drivers/i2c/i2c-core-base.c#L711 -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v3 01/11] i2c: Export of_i2c_get_board_info()

2018-03-25 Thread Boris Brezillon
closer look and it seems the only user of info->archdata is i2c-core-of.c, so we can even remove the info->archdata field. -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v3 05/11] dt-bindings: i3c: Document core bindings

2018-03-26 Thread Boris Brezillon
Hi Geert, On Mon, 26 Mar 2018 12:22:24 +0200 Geert Uytterhoeven wrote: > Hi Boris, > > On Fri, Mar 23, 2018 at 12:00 PM, Boris Brezillon > wrote: > > From: Boris Brezillon > > > > A new I3C subsystem has been added and a generic description has been > >

Re: [PATCH v3 11/11] dt-bindings: gpio: Add bindings for Cadence I3C gpio expander

2018-03-26 Thread Boris Brezillon
Hi Geert, On Mon, 26 Mar 2018 12:17:26 +0200 Geert Uytterhoeven wrote: > Hi Boris, > > On Fri, Mar 23, 2018 at 12:00 PM, Boris Brezillon > wrote: > > Document the Cadence I3C gpio expander bindings. > > > > Signed-off-by: Boris Brezillon > > Thanks

Re: [PATCH v3 11/11] dt-bindings: gpio: Add bindings for Cadence I3C gpio expander

2018-03-26 Thread Boris Brezillon
On Mon, 26 Mar 2018 12:12:54 +0200 Geert Uytterhoeven wrote: > Hi Boris, > > On Fri, Mar 23, 2018 at 12:00 PM, Boris Brezillon > wrote: > > Document the Cadence I3C gpio expander bindings. > > > > Signed-off-by: Boris Brezillon > > Thanks for your p

[GIT PULL] mtd: Changes for 4.17

2018-04-06 Thread Boris Brezillon
mtd: ftl: Use DIV_ROUND_UP() Boris Brezillon (23): mtd: Make sure the device supports erase operations in mtd_erase() mtd: nand: Get rid of comments giving the file path inside the file itself mtd: nand: Stop using full path when referring to files placed in the same dir mtd: nand

Re: [Letux-kernel] [Bug]: mtd: onenand: omap2plus: kernel panic with OneNAND on OMAP3 (DM3730) device GTA04A5

2018-04-11 Thread Boris Brezillon
Hi Ladislav, On Wed, 11 Apr 2018 08:26:07 +0200 Ladislav Michl wrote: > Hi Andreas, > > On Wed, Apr 11, 2018 at 06:59:03AM +0200, Andreas Kemnade wrote: > > Hi Ladis, > > > > On Tue, 10 Apr 2018 22:56:43 +0200 > > Ladislav Michl wrote: > > > > > Hi Nikolaus, > > > > > > On Tue, Apr 10, 20

Re: [Letux-kernel] [Bug]: mtd: onenand: omap2plus: kernel panic with OneNAND on OMAP3 (DM3730) device GTA04A5

2018-04-11 Thread Boris Brezillon
On Wed, 11 Apr 2018 09:36:56 +0200 Ladislav Michl wrote: > Hi Boris, > > On Wed, Apr 11, 2018 at 09:15:28AM +0200, Boris Brezillon wrote: > > Hi Ladislav, > > > > On Wed, 11 Apr 2018 08:26:07 +0200 > > Ladislav Michl wrote: > > > > > Hi And

Re: [Letux-kernel] [Bug]: mtd: onenand: omap2plus: kernel panic with OneNAND on OMAP3 (DM3730) device GTA04A5

2018-04-11 Thread Boris Brezillon
On Wed, 11 Apr 2018 10:27:46 +0200 Ladislav Michl wrote: > On Wed, Apr 11, 2018 at 10:08:06AM +0200, Boris Brezillon wrote: > > On Wed, 11 Apr 2018 09:36:56 +0200 > > Ladislav Michl wrote: > > > > > Hi Boris, > > > > > > On Wed, Apr 11,

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-04-11 Thread Boris Brezillon
On Wed, 11 Apr 2018 16:44:10 +0200 Peter Rosin wrote: > Hi Nicolas, > > Boris asked for your input on this (the datasheet difference appears to > have no bearing on the issue) elsewhere in the tree of messages. It's > now been a week or so and I'm starting to wonder if you missed this > altogeth

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-04-11 Thread Boris Brezillon
On Wed, 11 Apr 2018 17:10:43 +0200 Peter Rosin wrote: > On 2018-04-11 16:59, Boris Brezillon wrote: > > On Wed, 11 Apr 2018 16:44:10 +0200 > > Peter Rosin wrote: > > > >> Hi Nicolas, > >> > >> Boris asked for your input on this (the datasheet d

Re: [PATCH] drm/vc4: Fix leak of the file_priv that stored the perfmon.

2018-04-12 Thread Boris Brezillon
On Mon, 9 Apr 2018 13:58:13 -0700 Eric Anholt wrote: > Signed-off-by: Eric Anholt > Fixes: 65101d8c9108 ("drm/vc4: Expose performance counters to userspace") Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/vc4/vc4_drv.c | 1 + > 1 file changed, 1 insertion(+)

Re: [Letux-kernel] [Bug]: mtd: onenand: omap2plus: kernel panic with OneNAND on OMAP3 (DM3730) device GTA04A5

2018-04-12 Thread Boris Brezillon
On Wed, 11 Apr 2018 11:12:24 +0200 Ladislav Michl wrote: > On Wed, Apr 11, 2018 at 10:52:01AM +0200, Boris Brezillon wrote: > > On Wed, 11 Apr 2018 10:27:46 +0200 > > Ladislav Michl wrote: > > > > > On Wed, Apr 11, 2018 at 10:08:06AM +0200, Boris Brezillon w

Re: [PATCH v2] mtd: chips: Replace printk() with more standardize output format

2018-03-20 Thread Boris Brezillon
gt; @@ -2157,8 +2162,7 @@ static int cfi_intelext_lock(struct mtd_info *mtd, > loff_t ofs, uint64_t len) > ofs, len, DO_XXLOCK_ONEBLOCK_LOCK); > > #ifdef DEBUG_LOCK_BITS > - printk(KERN_DEBUG "%s: lock status after, ret=%d\n", > -

[PATCH v3 00/11] Add the I3C subsystem

2018-03-23 Thread Boris Brezillon
, this way maybe I'll have reviews on the doc itself :-). Thanks, Boris Boris Brezillon (11): i2c: Export of_i2c_get_board_info() i3c: Add core I3C infrastructure docs: driver-api: Add I3C documentation i3c: Add sysfs ABI spec dt-bindings: i3c: Document core bindings dt-bi

[PATCH v3 03/11] docs: driver-api: Add I3C documentation

2018-03-23 Thread Boris Brezillon
From: Boris Brezillon Add the I3C documentation describing the protocol, the master driver API and the device driver API. Signed-off-by: Boris Brezillon --- Changes in v2: - Moved out of patch "i3c: Add core I3C infrastructure" - Add link to the I3C spec - Move rst files in Doc

[PATCH v3 11/11] dt-bindings: gpio: Add bindings for Cadence I3C gpio expander

2018-03-23 Thread Boris Brezillon
Document the Cadence I3C gpio expander bindings. Signed-off-by: Boris Brezillon --- .../devicetree/bindings/gpio/gpio-cdns-i3c.txt | 38 ++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/gpio-cdns-i3c.txt diff --git a

[PATCH v3 10/11] gpio: Add a driver for Cadence I3C GPIO expander

2018-03-23 Thread Boris Brezillon
Add a driver for Cadence I3C GPIO expander. Signed-off-by: Boris Brezillon --- drivers/gpio/Kconfig | 11 ++ drivers/gpio/Makefile| 1 + drivers/gpio/gpio-cdns-i3c.c | 380 +++ 3 files changed, 392 insertions(+) create mode 100644

[PATCH v3 01/11] i2c: Export of_i2c_get_board_info()

2018-03-23 Thread Boris Brezillon
From: Boris Brezillon I3C busses have to know about all I2C devices connected on the I3C bus to properly initialize the I3C master, and I2C frames can't be sent on the bus until this initialization is done. We can't let the I2C core parse the DT and instantiate I2C devices as p

[PATCH v3 08/11] i3c: master: Add driver for Cadence IP

2018-03-23 Thread Boris Brezillon
From: Boris Brezillon Add a driver for Cadence I3C master IP. Signed-off-by: Boris Brezillon --- Changes in v3: - Adjust to match I3C framework changes - Implement support the CMD RESPONSE QUEUE and IBI QUEUE added in the latest revision of Cadence master IP - Remove support for HDR modes

[PATCH v3 09/11] dt-bindings: i3c: Document Cadence I3C master bindings

2018-03-23 Thread Boris Brezillon
From: Boris Brezillon Document Cadence I3C master DT bindings. Signed-off-by: Boris Brezillon --- .../devicetree/bindings/i3c/cdns,i3c-master.txt| 45 ++ 1 file changed, 45 insertions(+) create mode 100644 Documentation/devicetree/bindings/i3c/cdns,i3c-master.txt

[PATCH v3 06/11] dt-bindings: i3c: Add macros to help fill I3C/I2C device's reg property

2018-03-23 Thread Boris Brezillon
The reg property of devices connected to an I3C bus have 3 cells, and filling them manually is not trivial. Provides macros to help doing that. Signed-off-by: Boris Brezillon --- include/dt-bindings/i3c/i3c.h | 28 1 file changed, 28 insertions(+) create mode

[PATCH v3 07/11] MAINTAINERS: Add myself as the I3C subsystem maintainer

2018-03-23 Thread Boris Brezillon
Create an entry for the I3C subsystem and mark it as maintained by me. There's no official git repository, patchwork instance, mailing list or website yet, but this will be added after the subsystem has been accepted. Signed-off-by: Boris Brezillon --- MAINTAINERS | 9 + 1 file ch

[PATCH v3 05/11] dt-bindings: i3c: Document core bindings

2018-03-23 Thread Boris Brezillon
From: Boris Brezillon A new I3C subsystem has been added and a generic description has been created to represent the I3C bus and the devices connected on it. Document this generic representation. Signed-off-by: Boris Brezillon --- Changes in v3: - Rename {i2c,i3c}-scl-frequency DT prop into

Re: [PATCH v3 00/11] Add the I3C subsystem

2018-03-23 Thread Boris Brezillon
On Fri, 23 Mar 2018 12:00:09 +0100 Boris Brezillon wrote: > This patch series is a proposal for a new I3C [1] subsystem. > > This infrastructure is not complete yet and will be extended over > time. > > There are a few design choices that are worth mentioning because they &g

[PATCH v3 02/11] i3c: Add core I3C infrastructure

2018-03-23 Thread Boris Brezillon
From: Boris Brezillon Add core infrastructure to support I3C in Linux and document it. This infrastructure is not complete yet and will be extended over time. There are a few design choices that are worth mentioning because they impact the way I3C device drivers can interact with their devices

[PATCH v3 04/11] i3c: Add sysfs ABI spec

2018-03-23 Thread Boris Brezillon
From: Boris Brezillon Document sysfs files/directories/symlinks exposed by the I3C subsystem. Signed-off-by: Boris Brezillon --- Changes in v2: - new patch --- Documentation/ABI/testing/sysfs-bus-i3c | 95 + 1 file changed, 95 insertions(+) create mode 100644

Re: [PATCH v3 05/11] dt-bindings: i3c: Document core bindings

2018-03-23 Thread Boris Brezillon
ot;; > > + i2c-scl-frequency = <10>; > > Another s/frequency/hz/ instance, similar to those reported by Thomas. Will fix it in v4. Thanks, Boris -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v3 09/11] dt-bindings: i3c: Document Cadence I3C master bindings

2018-03-23 Thread Boris Brezillon
On Fri, 23 Mar 2018 12:10:35 +0100 Thomas Petazzoni wrote: > Hello, > > On Fri, 23 Mar 2018 12:00:18 +0100, Boris Brezillon wrote: > > > +Optional properties defined by the generic binding (see > > +Documentation/devicetree/bindings/i3c/i3c.txt for more details): > &

[GIT PULL] mtd: fixes for 4.16-rc7

2018-03-23 Thread Boris Brezillon
16 insertions(+), 26 deletions(-) -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 1/9] mtd: nand: qcom: use the ecc strength from device parameter

2018-04-10 Thread Boris Brezillon
On Tue, 10 Apr 2018 09:55:58 +0200 Miquel Raynal wrote: > > Hi Abhishek, > > > > On Tue, 10 Apr 2018 11:39:35 +0530, Abhishek Sahu > > wrote: > > > > > On 2018-04-06 18:01, Miquel Raynal wrote: > > > > Hi Abhishek, > > > > > > > > On Wed, 4 Apr 2018 18:12:17 +0530, Abhishek Sahu > > >

Re: [PATCH v2 0/2] clk: at91: Added more information logging

2018-04-10 Thread Boris Brezillon
Hi Marcin On Mon, 9 Apr 2018 20:15:51 -0400 Marcin Ziemianowicz wrote: > This is a series of patches which resolves set_rate() for the PLL not > having any effect and therefore the USB Host port not working. Also, a > few messages were added which may be helpful in the future when others > are w

Re: [PATCH v2 1/2] clk: at91: Added more information logging.

2018-04-10 Thread Boris Brezillon
Hi Marcin, On Mon, 9 Apr 2018 20:16:21 -0400 Marcin Ziemianowicz wrote: > I noticed that when debugging some USB clocking issue that there weren't > many ways to tell what the state of the USB clocking system was. This > adds a few logging statements to see what the relevant code is trying to >

Re: [PATCH v2 2/2] clk: at91: Fix for PLL set_rate changes not being actually written to PLL peripheral bits

2018-04-10 Thread Boris Brezillon
Hi Marcin, On Mon, 9 Apr 2018 20:16:49 -0400 Marcin Ziemianowicz wrote: > When a USB device is connected to the USB host port on the SAM9N12 then > you get "-62" error which seems to indicate USB replies from the device > are timing out. Looking around, I saw the USB bus was running at half > sp

Re: [PATCH] ubi: Reject MLC NAND

2018-03-07 Thread Boris Brezillon
support for hardware that "only works by mistake" may be good > idea, but maybe it is slightly too surprising for a -stable. I wouldn't say "work by mistake" but "seems to work at first but in the end breaks", so definitely a candidate for -stable IMO. Regards, Boris [1]https://github.com/bbrezillon/linux/tree/nand/mlc -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH] ubi: Reject MLC NAND

2018-03-07 Thread Boris Brezillon
uch presumptuous statements (you can have a look at these slides if you want some details about why this is not so simple [1]). I'm definitely not saying supporting MLC NANDs in Linux is impossible, and if you're interested in working on this topic I'd be happy to help. But please don&#

Re: [PATCH 1/2] mtd: use put_device() if device_register fail

2018-03-14 Thread Boris Brezillon
ill looks wrong. It's probably better to move the of_node_put() and the below idr_remove() call in the ->release() hook if you want to use put_device(). > idr_remove(&mtd_idr, i); > fail_locked: -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v2 3/8] mtd: maps: gpio-addr-flash: Use devm_* functions

2018-09-27 Thread Boris Brezillon
On Wed, 5 Sep 2018 16:36:38 +0200 Ricardo Ribalda Delgado wrote: > @@ -234,9 +234,11 @@ static int gpio_flash_probe(struct platform_device *pdev) > state->map.copy_to= gf_copy_to; > state->map.bankwidth = pdata->width; > state->map.size = state->win_size * (1 << state

Re: [PATCH v2 7/8] mtd: maps: gpio-addr-flash: Add support for device-tree devices

2018-09-27 Thread Boris Brezillon
On Wed, 5 Sep 2018 16:36:42 +0200 Ricardo Ribalda Delgado wrote: > +static int gpio_flash_probe_gpios(struct platform_device *pdev, > + struct async_state *state) > +{ > + struct physmap_flash_data *pdata; > + struct device_node *dn; > + struct resource

Re: [PATCH v2 5/8] mtd: maps: gpio-addr-flash: Replace array with an integer

2018-09-27 Thread Boris Brezillon
On Wed, 5 Sep 2018 16:36:40 +0200 Ricardo Ribalda Delgado wrote: > By replacing the array with an integer we can avoid completely > the bit comparison loop if the value has not changed (by far > the most common case). > > Signed-off-by: Ricardo Ribalda Delgado > --- > drivers/mtd/maps/gpio-ad

Re: [PATCH v2 0/8] gpio-addr-flash: Support for device-tree and cleanup

2018-09-27 Thread Boris Brezillon
> Changelog v2: > > From Boris Brezillon: > -Add Fixes and cc:stable > > From kbuild: > - Fix warnings > > - Rebase > > Ricardo Ribalda Delgado (8): > mtd: maps: gpio-addr-flash: Replace custom printk > mtd: maps: gpio-addr-flash: Fix ioremapped size

Re: [PATCH 1/2] spi: spi-mem: Add the spi_set_xfer_bpw function

2018-09-27 Thread Boris Brezillon
Hi Chuanhua, On Fri, 21 Sep 2018 15:06:26 +0800 Chuanhua Han wrote: > Before we add this spi_transfer to the spi_message chain table, we need > bits_per_word_mask based on spi_control to set the bits_per_word of > this spi_transfer. It's not clear to me what you're trying to fix/improve. Can yo

Re: [PATCH 2/2] spi: spi-fsl-dspi: Fix support for XSPI transport mode

2018-09-27 Thread Boris Brezillon
Hi Chuanhua, On Fri, 21 Sep 2018 15:06:27 +0800 Chuanhua Han wrote: > This patch fixes the problem that the XSPI mode of the dspi controller > cannot transfer data properly. > In XSPI mode, cmd_fifo is written before tx_fifo, which transforms the > byte order of sending and receiving data. Agai

<    3   4   5   6   7   8   9   10   11   12   >